From patchwork Tue Feb 3 07:54:49 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4454 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id B9CC23F24C for ; Tue, 3 Feb 2026 08:55:57 +0100 (CET) Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-480717a8e05sf52656355e9.3 for ; Mon, 02 Feb 2026 23:55:57 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1770105357; cv=pass; d=google.com; s=arc-20240605; b=jPM1vRpPLL1/5q+kZpU7lytdtuO5Bv80Kij7p1obA9+arYZ1wov6YxV9pYPqvwKqjY eu/FXx6yq02fw62zBjaRC/Il7zJEb5jGBmCh29Gui9tbflTP6dRIrCW/02KLeDUkPhPM GCa6gt7JqpXVZ4eJYfzVvZO32MaeiscNdkrg+Th1WJrUicsr1ONh9SVL0yqO+aMDn8Fg KpD2dss8U8akD4gg2cFCRzU/jJ0202j3s1bMLx7aaQ6tv6/BHYysCYYQfHpVHXcwJH3F BhHNFcHfcvIkbac1DVhCYyU7i/VL8QHzRJOrDDT0AWfjQSMtIb+qjpiI+eVCVTp6Z23w 9boA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=Km/cnWYCmuf8jV+ySzpJnvTqE7wRuSEWIv5J7ykdxks=; fh=pEYiPu8dpjXRYOyp6pPtn3lejahtCRfy9H9byygnHHo=; b=YUwXBfMA9OnDaOoAChQmpsexyei0uGaAlqiSvY7m5vmbqpkoAV/ep/DBWv2dfdedot Dqv7o7PG3w7T5DyNU0jZUYLnrzCbIucTJzvLledMW4bUF6jVNI2OY3dgcCGNBQudI1ae Drv1+nbLiaZjMRJ5DjUGrqDeT2/sD/zKU6OVoxkoTQ48E0VltbcNb0kEle20dpJexhcQ iSExxlMXAnIZcn5dV8RvWWZAbQeX0lI6Tx+fdeRPjqWusNLpyGzJ9dv19Rn/tVT70+pv wnFRBrRim+2Fc9zZpzd2aEZTfdPo48N4Y+bOQfc7UxR/vAcW4PDnqPL8ZXO+8//o09IX HGyw==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=HfwV2cRj; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1770105357; x=1770710157; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Km/cnWYCmuf8jV+ySzpJnvTqE7wRuSEWIv5J7ykdxks=; b=rA0fpygknor3foD/3rxrlJvRqyGuNGcM7eKXtKKoMfhE350Fnvm4gNFaO0BA6Sky/8 4qp6OULdLMVrrjCYHxNQjHvcWLlQWjt8nxH6b/YqcuLkqBRnAv2Nsy5IbSHUYGN69rG1 s5oJGMc6RNBlcpCp1qUGfEdFTYYhC+mtru5gI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770105357; x=1770710157; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Km/cnWYCmuf8jV+ySzpJnvTqE7wRuSEWIv5J7ykdxks=; b=RJjMLqk0nDAR5Ej4/7cV/twmvvZjuaZH5N6Hx2OAF4VSb2209RA48+I4Ca5Jwx001r 4VGLQEWtw7SpsNyF7XxLrZ1lpx0VCk0tNmpbmUylAw0DJNT6ABwnfxxNB++AJrXSl9sh zub0FXEIuBpyLoRkQUFQLiv+0fg+njT5c51x13gNMQCATjl8T2g6u4hK/4eF9Fu4p/JT wJTNuOaqY09u8eCr8z4rQqAq3Nbo1tXB0NB7nPhtJryGc3WihOEwMe6su98B+HuILTz/ CgMXv5yaMxuLAtyKGx40oll59kJnt9l+B66Nxi+ybdHlELZ3Bp7eKhtI6vmSJ/lmuqr8 19jQ== X-Forwarded-Encrypted: i=2; AJvYcCWJ6Xg/4dsXGY4dtQdJ0KoyYTVmQIIeQpj/Z32KYPx2KQegXWw+vzUx8+aecFc1ZzjN/1MDJXqTvdtM43fB@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YwbfTQFm7Duab1rSm1LuJ5o9N/BAkdtiAbN7kDuNRWZ+Vszp6FM GvKYgRU4ii7lLw10s/3jUeREt6UjHs+q6y3P8C/df7+BNz87liV14EvjT8dkhHaCHc0ZrSeFYgj dag== X-Received: by 2002:a05:600c:8b0a:b0:477:af8d:203a with SMTP id 5b1f17b1804b1-482db49993bmr192414065e9.27.1770105357315; Mon, 02 Feb 2026 23:55:57 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com; h="AV1CL+EtmtCL+96qh2EFZRS3y1OiIhV8BUiAiIbMjOXK+rb3MA==" Received: by 2002:a05:600c:1c2a:b0:47e:e788:97d2 with SMTP id 5b1f17b1804b1-482e9dca15als27447265e9.0.-pod-prod-07-eu; Mon, 02 Feb 2026 23:55:55 -0800 (PST) X-Received: by 2002:a05:600c:530f:b0:480:4a90:1afe with SMTP id 5b1f17b1804b1-482db4a62aamr186571825e9.34.1770105355194; Mon, 02 Feb 2026 23:55:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1770105355; cv=none; d=google.com; s=arc-20240605; b=UQZnVsphNECxQmedmZJpAu94LOUMvjct+vJ4JtTbVAdEXbjILMFIQX4m0UPoV1NwUq QJWuYRSl17K8JpPch/X5raNM6i/IufHmejFD8d8hSQUw7e+1BQa0kChjyLj3ycv8tvj/ LkdU5dcAjoS3Y133dwF++YJ2u+Cd57aCgTi2j0n4Fzt2lgzyhDEqfs6m8uXaOuJpu0dI QqLVevx1/Wrcnd+uZebGCISgu5AizJvvcmXEntu4FX0cu2xYIwnTCp0cxYGQBjn//Xtd +4wLr34joA/QFMeNqQxb7y1q+zDWgcYU8Y4v0HyFKO7Tqhbq22SarKTq27sXVAMq4Pza 5ptw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=EIVzFm2wIlSLx0Rbu93iak9eeRh07s43e8fHxMkJycE=; fh=AdINyqa0RrhYjILkNDREXbEInCFvYIP+gW50d4EJsQ0=; b=Avv4c9UIAZjWN3y91a7+Rtlgsp8Q02oJmHYFsxJ5BAp9DkJx4sFqkIQorviVN68mbk 9l99GbBCulGYde1xdLac87/8c/CllQ6ft6OTvttjCr7zRIR2XxiKYxHdRCDB5l0aRELn 048EzIncAYQ6G3VQ/EVxXeyhWkZpPhLtoa2qyZMDgWiLMqcwo3AZyt8EdhNFhoUVQeNY YGLJqmZR52z4Jd66YbNccAK0uEtsVKoGfZBkV4+l4kuoGnFvKfEUoHDXTF2u0LkKbsga pTCtnOo0k5GUWjIGo//2wFJHqL645E3etTqmi25k4W+ObbbGTJc6BFpY2cl2qSddFYhg DmeA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=HfwV2cRj; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 5b1f17b1804b1-4806cdead1bsor25195595e9.4.2026.02.02.23.55.55 for (Google Transport Security); Mon, 02 Feb 2026 23:55:55 -0800 (PST) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: AZuq6aLPZvFYqzoCLY9jC4hpYK35JMKDfA7JA0IyoJGI/U0nIh5JRI1N6R6BWKlwOaY X955wyaqSxJ3KOuy6v7uojYQY0ZAi4bf+DGMQRK8z2PJdA1fE68zKuODX+sULmLlOG19ClWIslI +x6s9eL2otlbdOsUcxmIxvCw3UOhd9w27ey0ORQ2j5WOH5PXG4qimgS7Jsb4gN1V/MZcMfJLD3z CcX9WDJqJXSUtF9Q25or9tledsoparbqNxn1KHUaxEK1umFkXXz94+ePV0AFiLMSo7HFzkTndT+ qbInc2DCzcCBFZYhvNhgyot2LFDhqwcjEbUZTT2BOUrkW2tZlcWIkOuCe0u4e/jkX1P//Y75MHG o6S5t84KijSK8K+slKdK88e1hP8bt+q0J6WsC2bM7adM6W5Zo+bGFYdmcLba7sR9CWG8FpwpSkC 7081RsWvT9GOfaBxg21SKqiTL5Hei+sd/VsCUsehVXacpo0zAnVcmEi4x4877BoefGOvzqxTfbj DDk6ORNGkYw+rQdvu9HGfmEYwlG7ctCTk/ynozx8JDJ1/7i9n/w727N6W2oUigEOFZ1fsAo82dG d/2oQYn4S2U= X-Received: by 2002:a05:600c:c4a5:b0:477:b642:9dc1 with SMTP id 5b1f17b1804b1-482db492454mr173565565e9.20.1770105354660; Mon, 02 Feb 2026 23:55:54 -0800 (PST) Received: from dario-ThinkPad-P14s-Gen-5.homenet.telecomitalia.it (host-95-248-31-95.retail.telecomitalia.it. [95.248.31.95]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-482e267b699sm111939885e9.16.2026.02.02.23.55.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 23:55:54 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , David Airlie , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Michael Walle , Neil Armstrong , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v3 2/4] drm/panel: ilitek-ili9806e: split core and DSI logic Date: Tue, 3 Feb 2026 08:54:49 +0100 Message-ID: <20260203075548.14907-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260203075548.14907-1-dario.binacchi@amarulasolutions.com> References: <20260203075548.14907-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=HfwV2cRj; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Split the driver to support multiple transport buses. The core logic (power, GPIO, backlight) is moved to a dedicated core module, while DSI-specific code is restricted to the DSI module. Introduce DRM_PANEL_ILITEK_ILI9806E_CORE as a hidden Kconfig symbol selected by the bus-specific configuration. Signed-off-by: Dario Binacchi --- (no changes since v1) MAINTAINERS | 2 +- drivers/gpu/drm/panel/Kconfig | 8 +- drivers/gpu/drm/panel/Makefile | 1 + .../drm/panel/panel-ilitek-ili9806e-core.c | 129 +++++++++++++++ .../drm/panel/panel-ilitek-ili9806e-core.h | 15 ++ .../gpu/drm/panel/panel-ilitek-ili9806e-dsi.c | 151 +++++------------- 6 files changed, 195 insertions(+), 111 deletions(-) create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.h diff --git a/MAINTAINERS b/MAINTAINERS index 46941413ed5c..b856a62666dc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7917,7 +7917,7 @@ F: drivers/gpu/drm/panel/panel-ilitek-ili9805.c DRM DRIVER FOR ILITEK ILI9806E PANELS M: Michael Walle S: Maintained -F: drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c +F: drivers/gpu/drm/panel/panel-ilitek-ili9806e-* DRM DRIVER FOR JADARD JD9365DA-H3 MIPI-DSI LCD PANELS M: Jagan Teki diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 692cd474910d..333e981eda96 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -257,11 +257,15 @@ config DRM_PANEL_ILITEK_ILI9805 Say Y if you want to enable support for panels based on the Ilitek ILI9805 controller. +config DRM_PANEL_ILITEK_ILI9806E_CORE + tristate + depends on OF + depends on BACKLIGHT_CLASS_DEVICE + config DRM_PANEL_ILITEK_ILI9806E_DSI tristate "Ilitek ILI9806E-based DSI panels" - depends on OF depends on DRM_MIPI_DSI - depends on BACKLIGHT_CLASS_DEVICE + select DRM_PANEL_ILITEK_ILI9806E_CORE help Say Y if you want to enable support for panels based on the Ilitek ILI9806E controller using DSI. diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index 00071a983242..13034cadb8d8 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -26,6 +26,7 @@ obj-$(CONFIG_DRM_PANEL_HYDIS_HV101HD1) += panel-hydis-hv101hd1.o obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) += panel-ilitek-ili9322.o obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9341) += panel-ilitek-ili9341.o obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9805) += panel-ilitek-ili9805.o +obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9806E_CORE) += panel-ilitek-ili9806e-core.o obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9806E_DSI) += panel-ilitek-ili9806e-dsi.o obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9881C) += panel-ilitek-ili9881c.o obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9882T) += panel-ilitek-ili9882t.o diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c new file mode 100644 index 000000000000..c088685d9d85 --- /dev/null +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c @@ -0,0 +1,129 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Ilitek ILI9806E core driver. + * + * Copyright (c) 2026 Amarula Solutions, Dario Binacchi + */ + +#include + +#include +#include +#include +#include +#include +#include + +#include "panel-ilitek-ili9806e-core.h" + +struct ili9806e { + void *transport; + struct drm_panel panel; + + struct regulator_bulk_data supplies[2]; + struct gpio_desc *reset_gpio; +}; + +static const char * const regulator_names[] = { + "vdd", + "vccio", +}; + +void *ili9806e_get_transport(struct drm_panel *panel) +{ + struct ili9806e *ctx = container_of(panel, struct ili9806e, panel); + + return ctx->transport; +} +EXPORT_SYMBOL_GPL(ili9806e_get_transport); + +int ili9806e_power_on(struct device *dev) +{ + struct ili9806e *ctx = dev_get_drvdata(dev); + int ret; + + gpiod_set_value(ctx->reset_gpio, 1); + + ret = regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies); + if (ret) { + dev_err(dev, "regulator bulk enable failed: %d\n", ret); + return ret; + } + + usleep_range(10000, 20000); + gpiod_set_value(ctx->reset_gpio, 0); + usleep_range(10000, 20000); + + return 0; +} +EXPORT_SYMBOL_GPL(ili9806e_power_on); + +int ili9806e_power_off(struct device *dev) +{ + struct ili9806e *ctx = dev_get_drvdata(dev); + int ret; + + gpiod_set_value(ctx->reset_gpio, 1); + + ret = regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies); + if (ret) + dev_err(dev, "regulator bulk disable failed: %d\n", ret); + + return ret; +} +EXPORT_SYMBOL_GPL(ili9806e_power_off); + +int ili9806e_probe(struct device *dev, void *transport, + const struct drm_panel_funcs *funcs, + int connector_type) +{ + struct ili9806e *ctx; + int i, ret; + + ctx = devm_kzalloc(dev, sizeof(struct ili9806e), GFP_KERNEL); + if (!ctx) + return -ENOMEM; + + dev_set_drvdata(dev, ctx); + ctx->transport = transport; + + for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++) + ctx->supplies[i].supply = regulator_names[i]; + + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies), + ctx->supplies); + if (ret) + return dev_err_probe(dev, ret, "failed to get regulators\n"); + + ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(ctx->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio), + "Failed to get reset-gpios\n"); + + drm_panel_init(&ctx->panel, dev, funcs, connector_type); + + ret = drm_panel_of_backlight(&ctx->panel); + if (ret) + return dev_err_probe(dev, ret, "Failed to get backlight\n"); + + ctx->panel.prepare_prev_first = true; + drm_panel_add(&ctx->panel); + + return 0; + +} +EXPORT_SYMBOL_GPL(ili9806e_probe); + +void ili9806e_remove(struct device *dev) +{ + struct ili9806e *ctx = dev_get_drvdata(dev); + + drm_panel_remove(&ctx->panel); +} +EXPORT_SYMBOL_GPL(ili9806e_remove); + +MODULE_AUTHOR("Dario Binacchi "); +MODULE_AUTHOR("Gunnar Dibbern "); +MODULE_AUTHOR("Michael Walle "); +MODULE_DESCRIPTION("Ilitek ILI9806E Controller Driver"); +MODULE_LICENSE("GPL"); diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.h b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.h new file mode 100644 index 000000000000..dddece62cf42 --- /dev/null +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.h @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +#ifndef _PANEL_ILITEK_ILI9806E_CORE_H +#define _PANEL_ILITEK_ILI9806E_CORE_H + +void *ili9806e_get_transport(struct drm_panel *panel); +int ili9806e_power_off(struct device *dev); +int ili9806e_power_on(struct device *dev); + +int ili9806e_probe(struct device *dev, void *transport, + const struct drm_panel_funcs *funcs, + int connector_type); +void ili9806e_remove(struct device *dev); + +#endif /* _PANEL_ILITEK_ILI9806E_CORE_H */ diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c index c337c4f1a1c7..ecdbed8d4a3a 100644 --- a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c @@ -1,15 +1,12 @@ // SPDX-License-Identifier: GPL-2.0 -#include #include #include #include -#include #include #include #include #include -#include #include #include @@ -18,7 +15,9 @@ #include