From patchwork Wed Feb 4 17:31:18 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4459 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id EC7733F09C for ; Wed, 4 Feb 2026 18:32:06 +0100 (CET) Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-47ee3dd7fc8sf432235e9.3 for ; Wed, 04 Feb 2026 09:32:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1770226326; cv=pass; d=google.com; s=arc-20240605; b=AZvhIJTzlt/uCMQB2fLEtA9zgPVi8NwYOuExGpNiQasc4NVHiUv/llCryS0QyQ+qZp /JHSqYG1ufrg+7LtvYMFZf0OS0D4onG0ltw6sm+Tzj5DDPWGtUm/0MfjIZH2pgzQfKL8 qG0Qa+80RAlMgv+LPy63rmb/sMtMxCtgO4azZ+Qmkfg5SuoRbc4gY7d7b0znNQR9V5nw fCoRFudMOJkjrsuceReljBR0ikgutZDYzmxrRzPoGhisFicsSnojamHZJ21quE8gqfq0 QhiY1El6V7ctbMW6WuzjTz3TDSh9v4gjsaEkyetp+2LMfoX8YzOW6OuRPIJ+O+piiq8O UZTA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=4yxp7X7f4tNV55yPYMVB5y6/nTq6p4bL/YrY+sLk5E4=; fh=/H5RKI7Sd3pOGUBY8/zhE68btBjazKAKCAX6fweK13w=; b=Zs7iPeXDZcVXK+doCbGlV0SZc3VUL+0Hm9yyunKeMdbhRcp6EbMYwXUCH5TwTUzz4l v1Ktdi1ZH1p1sAtBwNlJDAQt1V23rT6m04c5zymRtUOLem8E0FQkq+w0MeXtHzGwtk0w z8sDb7nRh3WCqWXQGYqJhRpwwbgQOFUIWazYifsp+zVNxmjbhL6uIoT1aR4fPpgKyYUT z8Dq6wbXe8V+T1+LgMLHEgSfjYPYCoZtS3IIO2kfD5LYid60RN0soqc4ujXGyS8cQf34 Pz06Ct50sRE+LU4s/qCXlPZ8+5Gs8Oa+3hQcNYgCxk3T44ipVbtgObwWcatWQjwwUi5n zqpg==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=dVApJRgv; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1770226326; x=1770831126; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=4yxp7X7f4tNV55yPYMVB5y6/nTq6p4bL/YrY+sLk5E4=; b=VFrPRhphPpvUGQbJVR6WHzSil+FUyb0X4ftafzWVN81BSR9nNFLkY+KozKhQZx1rKX S5VdyoyUwTqKw4GOx8vHgZWYdJuVLqmysPDYh7ITFHoq0pRrDyourofpX3q2CidpRdI9 odL7HiLBKhDEFN4+AOR/GQPFQTP6Tr00vuwY8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770226326; x=1770831126; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4yxp7X7f4tNV55yPYMVB5y6/nTq6p4bL/YrY+sLk5E4=; b=GgfuTMfN667K9kHGoeylg3ZTslmoSfxFbbrd55vhn+WE/5Gtj2GbZ4j8IpIlNcedFb K47A8UZGS8IyXWI2oO6OZBObWQYTpMLAovO7WFb3STv42MMQe63uOSs3Ye+lvedefJnd eAEqfS0VwjL7lbXkCKr47onseATZYQxzDftXh9N45G3PJGO9MSxDpFsD2uq9Ulo/iaE9 6MUYgkyNOSmnvxUqc7p6xfaM/tcWT93Xk44c7quXW9FNE222jKTNacziiguOlmVSXRDP A1oOoU1NLbB4JrOAfosU7++FOFr6HLgQpHnZVR0s1465exk2doJ6b1gh/+HTFv3bWm3G 1xtg== X-Forwarded-Encrypted: i=2; AJvYcCXB9MjD3+5Z+jobYLKAjp40R8OjHRujR75b0j2QGsrfQf9NIa8OEGoyJfeh7WvYi/38Ef424vGhzISFqcob@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YwEl5KZ1pVZkK0oxbxcMVQHSw+YjXhrpy4gSNtViwTVmxy3q/vx JvcmEa+/pFv1ev/6QIri6y2V7VEBwJ2WILKwywG0ygjx8smNPCPAD3UjaMeD5k6IMlM6bA== X-Received: by 2002:a05:600c:6748:b0:475:dd8d:2f52 with SMTP id 5b1f17b1804b1-4830e99b60dmr44668925e9.32.1770226326185; Wed, 04 Feb 2026 09:32:06 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com; h="AV1CL+H0lOD/YtyT19x7duHofFAMYniNAMBIhPxd8LJ+L8egYw==" Received: by 2002:a05:600c:524e:b0:480:6d1a:97b4 with SMTP id 5b1f17b1804b1-483175234f9ls425535e9.0.-pod-prod-06-eu; Wed, 04 Feb 2026 09:32:04 -0800 (PST) X-Received: by 2002:a05:600c:3143:b0:477:a978:3a7b with SMTP id 5b1f17b1804b1-4830e987c76mr57742275e9.22.1770226323827; Wed, 04 Feb 2026 09:32:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1770226323; cv=none; d=google.com; s=arc-20240605; b=Wg3czarVJnyt2jRU6SQnlRBwX6E+M2OZoUznJyM9eJ+u24sEe3ciDo5wEd47VT4SZJ SE6qPMP2wcLENyrcjSGEO7vbGfYtcZ/CTP2tcUnRMHJoIInQhlx0r8j+I+FbYLFp8EIV FPuPI7+M5PHUk7IjtU2X4Lbu+9VZCsV0XE8D8k48EI7Oe2S4u9wE6IJBzvRD8PayB8PJ J2x5ON3XHGiNLfMop0vFIcRjfVQwGFfACVua64b27G67WBSmfOVV92QT5jld/J911bHf Cg2d2RWw+b5960M7mg4S9x3CCqAg0/NQoSYVo4KWDWR7sZd8hEHRxpBlsbBx7eZgPryH O30A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=KEmenxrmDwzNeXpzlEfB0IxhIpMig5qGpRyQpXt0OQM=; fh=AdINyqa0RrhYjILkNDREXbEInCFvYIP+gW50d4EJsQ0=; b=QAPqCqnpM71f8JuNl50T9qhccUPrdDcwSfKJ2Dbmt5cHWWb/H7P8+aLdVefrvU+hjZ nSfPLa+rssLi/obnIOhLbBU60d2cuTglMeza4KmWqhLPMLicCelMofXmNOmkm9u86sr6 +ZElC9yh8cMsSymOf2Kfu7b/QW+NpFUkRtKpnak4ws0Jrh1sg9KP/WuyVuEoABLzx75/ D/9l/fDSgCzCvN4CaRIt5DqPDgL9hDg6VPASUlP5G4CBxGapLdHi54ksCjXK/iAzTo5Z m1JbFRQMVY/Cq818CyHaeZHeNypeAxJ2wPVX28bnkPKplCDYEMRKBz1iyZbmZS/F49zn dLVA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=dVApJRgv; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 5b1f17b1804b1-4830eb30f1dsor4361105e9.16.2026.02.04.09.32.03 for (Google Transport Security); Wed, 04 Feb 2026 09:32:03 -0800 (PST) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: AZuq6aKaDlfBCbRe5L/rm87LdlYIkLyVtUGYlF3WXVEh9nyuYghtRtdUNoxQKQe0/nt HnqufYU9G6j45CzMiLta8Pd1SfcuwOY/wcxCgfWtt4ypF//WubNZkbYdtgXztlzrIw2QlqzZBJZ A40JYOye6Dz8nnD5Elo7C5zKL7YfN4AXm0shB2a+GV64TmroPYUwbhnO0+PmGKXt6LjGOk6LGFH lVQ7UfkMtQXC7jZv4IQHTNflJp6AHWYHl6NePr+Tc0R4G80mJPHmZahXchQSLpb+FqjdQLQ5dg1 9mh/hGW+VP8x1beSajCp9+l1cpSWR26R9gVPdLdDsz5xwP2Y5/U1mW2HcyUB1ufS/4Y+72+As1B z+PIJGHjJJJ6YqyReeM9iMe11PiAqZb+TucQlN8g+bonKRE+lvMTTZ6xDvhd8yCFHbON7ld94ae T8eqv/nP0080E+Zt4OwY3u9R81l0/izK9Vjb8kHjWA6wPYBXI96Pntx7PcQ1rYm5UPWdbfk7fvw yWVZwQwompwkR7K50wjIR+cPknTYzyEpNxhhtBHfZed X-Received: by 2002:a05:600c:19cd:b0:477:2f7c:314f with SMTP id 5b1f17b1804b1-4830e94c659mr50283265e9.10.1770226323299; Wed, 04 Feb 2026 09:32:03 -0800 (PST) Received: from dario-ThinkPad-P14s-Gen-5.amarulasolutions.com ([2.196.42.58]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436180640f2sm7241565f8f.39.2026.02.04.09.32.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 09:32:02 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , David Airlie , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Michael Walle , Neil Armstrong , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v4 2/4] drm/panel: ilitek-ili9806e: split core and DSI logic Date: Wed, 4 Feb 2026 18:31:18 +0100 Message-ID: <20260204173154.337674-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260204173154.337674-1-dario.binacchi@amarulasolutions.com> References: <20260204173154.337674-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=dVApJRgv; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Split the driver to support multiple transport buses. The core logic (power, GPIO, backlight) is moved to a dedicated core module, while DSI-specific code is restricted to the DSI module. Introduce DRM_PANEL_ILITEK_ILI9806E_CORE as a hidden Kconfig symbol selected by the bus-specific configuration. Signed-off-by: Dario Binacchi --- Changes in v4: - Fix "WARNING: unmet direct dependencies detected for DRM_PANEL_ILITEK_ILI9806E_CORE" reported by kernel test robot MAINTAINERS | 2 +- drivers/gpu/drm/panel/Kconfig | 4 + drivers/gpu/drm/panel/Makefile | 1 + .../drm/panel/panel-ilitek-ili9806e-core.c | 129 +++++++++++++++ .../drm/panel/panel-ilitek-ili9806e-core.h | 15 ++ .../gpu/drm/panel/panel-ilitek-ili9806e-dsi.c | 151 +++++------------- 6 files changed, 193 insertions(+), 109 deletions(-) create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.h diff --git a/MAINTAINERS b/MAINTAINERS index 58cd78fb9731..1daf45133c39 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7917,7 +7917,7 @@ F: drivers/gpu/drm/panel/panel-ilitek-ili9805.c DRM DRIVER FOR ILITEK ILI9806E PANELS M: Michael Walle S: Maintained -F: drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c +F: drivers/gpu/drm/panel/panel-ilitek-ili9806e-* DRM DRIVER FOR JADARD JD9365DA-H3 MIPI-DSI LCD PANELS M: Jagan Teki diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 692cd474910d..cbfee8abba0c 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -257,11 +257,15 @@ config DRM_PANEL_ILITEK_ILI9805 Say Y if you want to enable support for panels based on the Ilitek ILI9805 controller. +config DRM_PANEL_ILITEK_ILI9806E_CORE + tristate + config DRM_PANEL_ILITEK_ILI9806E_DSI tristate "Ilitek ILI9806E-based DSI panels" depends on OF depends on DRM_MIPI_DSI depends on BACKLIGHT_CLASS_DEVICE + select DRM_PANEL_ILITEK_ILI9806E_CORE help Say Y if you want to enable support for panels based on the Ilitek ILI9806E controller using DSI. diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index 00071a983242..13034cadb8d8 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -26,6 +26,7 @@ obj-$(CONFIG_DRM_PANEL_HYDIS_HV101HD1) += panel-hydis-hv101hd1.o obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) += panel-ilitek-ili9322.o obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9341) += panel-ilitek-ili9341.o obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9805) += panel-ilitek-ili9805.o +obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9806E_CORE) += panel-ilitek-ili9806e-core.o obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9806E_DSI) += panel-ilitek-ili9806e-dsi.o obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9881C) += panel-ilitek-ili9881c.o obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9882T) += panel-ilitek-ili9882t.o diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c new file mode 100644 index 000000000000..c088685d9d85 --- /dev/null +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c @@ -0,0 +1,129 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Ilitek ILI9806E core driver. + * + * Copyright (c) 2026 Amarula Solutions, Dario Binacchi + */ + +#include + +#include +#include +#include +#include +#include +#include + +#include "panel-ilitek-ili9806e-core.h" + +struct ili9806e { + void *transport; + struct drm_panel panel; + + struct regulator_bulk_data supplies[2]; + struct gpio_desc *reset_gpio; +}; + +static const char * const regulator_names[] = { + "vdd", + "vccio", +}; + +void *ili9806e_get_transport(struct drm_panel *panel) +{ + struct ili9806e *ctx = container_of(panel, struct ili9806e, panel); + + return ctx->transport; +} +EXPORT_SYMBOL_GPL(ili9806e_get_transport); + +int ili9806e_power_on(struct device *dev) +{ + struct ili9806e *ctx = dev_get_drvdata(dev); + int ret; + + gpiod_set_value(ctx->reset_gpio, 1); + + ret = regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies); + if (ret) { + dev_err(dev, "regulator bulk enable failed: %d\n", ret); + return ret; + } + + usleep_range(10000, 20000); + gpiod_set_value(ctx->reset_gpio, 0); + usleep_range(10000, 20000); + + return 0; +} +EXPORT_SYMBOL_GPL(ili9806e_power_on); + +int ili9806e_power_off(struct device *dev) +{ + struct ili9806e *ctx = dev_get_drvdata(dev); + int ret; + + gpiod_set_value(ctx->reset_gpio, 1); + + ret = regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies); + if (ret) + dev_err(dev, "regulator bulk disable failed: %d\n", ret); + + return ret; +} +EXPORT_SYMBOL_GPL(ili9806e_power_off); + +int ili9806e_probe(struct device *dev, void *transport, + const struct drm_panel_funcs *funcs, + int connector_type) +{ + struct ili9806e *ctx; + int i, ret; + + ctx = devm_kzalloc(dev, sizeof(struct ili9806e), GFP_KERNEL); + if (!ctx) + return -ENOMEM; + + dev_set_drvdata(dev, ctx); + ctx->transport = transport; + + for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++) + ctx->supplies[i].supply = regulator_names[i]; + + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies), + ctx->supplies); + if (ret) + return dev_err_probe(dev, ret, "failed to get regulators\n"); + + ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(ctx->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio), + "Failed to get reset-gpios\n"); + + drm_panel_init(&ctx->panel, dev, funcs, connector_type); + + ret = drm_panel_of_backlight(&ctx->panel); + if (ret) + return dev_err_probe(dev, ret, "Failed to get backlight\n"); + + ctx->panel.prepare_prev_first = true; + drm_panel_add(&ctx->panel); + + return 0; + +} +EXPORT_SYMBOL_GPL(ili9806e_probe); + +void ili9806e_remove(struct device *dev) +{ + struct ili9806e *ctx = dev_get_drvdata(dev); + + drm_panel_remove(&ctx->panel); +} +EXPORT_SYMBOL_GPL(ili9806e_remove); + +MODULE_AUTHOR("Dario Binacchi "); +MODULE_AUTHOR("Gunnar Dibbern "); +MODULE_AUTHOR("Michael Walle "); +MODULE_DESCRIPTION("Ilitek ILI9806E Controller Driver"); +MODULE_LICENSE("GPL"); diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.h b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.h new file mode 100644 index 000000000000..dddece62cf42 --- /dev/null +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.h @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +#ifndef _PANEL_ILITEK_ILI9806E_CORE_H +#define _PANEL_ILITEK_ILI9806E_CORE_H + +void *ili9806e_get_transport(struct drm_panel *panel); +int ili9806e_power_off(struct device *dev); +int ili9806e_power_on(struct device *dev); + +int ili9806e_probe(struct device *dev, void *transport, + const struct drm_panel_funcs *funcs, + int connector_type); +void ili9806e_remove(struct device *dev); + +#endif /* _PANEL_ILITEK_ILI9806E_CORE_H */ diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c index c337c4f1a1c7..ecdbed8d4a3a 100644 --- a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c @@ -1,15 +1,12 @@ // SPDX-License-Identifier: GPL-2.0 -#include #include #include #include -#include #include #include #include #include -#include #include #include @@ -18,7 +15,9 @@ #include