From patchwork Wed Feb 25 16:16:57 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4487 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 947BA3F1C6 for ; Wed, 25 Feb 2026 17:19:08 +0100 (CET) Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-43630b02fb4sf6356388f8f.3 for ; Wed, 25 Feb 2026 08:19:08 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1772036348; cv=pass; d=google.com; s=arc-20240605; b=KGcXf/O4yUOz7oEubNNreW+0KwA1yH4cMnorlhpeD21n1RqXrVpDYSz8evZvVTgZyM es9ukLX190LBWf3vw03dP2aXJjZflUCC9D8MYa3rkiqC0d+NYYbL3KQukppkFlUO7cMT H9cE8fcEwJfd1acOOGnE4X05DNtD8o6B/rj2ImLcjyciG1ELlDeFEW4FegzBHanW7GCx jsBQKNyuinHuMjGUSapwBXDWOfB3anhbaVQB7i/kTxfVUbU0xUKv1p/mPwYgMQrINCYg v7jvuxmBFAY/+XPPN7aXj/Ff5sEzPaUSK1UVcxdnptaQSm9fqhK+cYRqQQeqj2XM7b30 gKKw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=HGK3DBBNI/uEFORiadlAQE6ktZg/Jj+mIoldTVBM8aY=; fh=JzdbNVKkhYvBhLhMZNH/SYxye+iId6HEBH8A//G9/gQ=; b=d90yyCbFTdJb9sZx0NnH3kR5+mFKdihg6bfxjkRkOU4jqqEURtHpCaYategfaWFsZO AZEElMRpEZlUqv9koPNBwNGON8E1wxC20FQOS5lxUocPabLKnxCGOq+k5+1tYyQ+jlVj cDSoUHvXjm1ONl1wgQhtK5GE79ibUxup2bK6mx9oovKn5X+/jriJMV71eSZoE5welSx1 gFSZtx1iaCEHUyDvbfRvMc08Gg2/WGYd28Dudpxjw3RyohoECQUg+cfImYul+bXDRbXk GUSSwwJj1gnVLpxCmpW8x0zxQKEjbHho7QcivTlMIYV9alaeaDeOtY0CziIU0iUEw3sA n6EA==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=CgDZxRhW; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1772036348; x=1772641148; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=HGK3DBBNI/uEFORiadlAQE6ktZg/Jj+mIoldTVBM8aY=; b=jyTgvp64MGfflWKqLhu0Fc1h1GIQUbFKVQe2FwF9TqfnlRv+QBBhHoPB0e89mC6QLF 5dbr1HyQsRqzgmXowYkP/yEBgJ0NuMVHOxu2FMFo6ick2K9w35xGvfvtwvNkDHd1NDTf BFWEAjiU2bG3KoegLLJFWAyRVvwzMewdG4O64= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772036348; x=1772641148; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HGK3DBBNI/uEFORiadlAQE6ktZg/Jj+mIoldTVBM8aY=; b=qrEIMFZUhkCFGH9EAizwFiXNk2i6kUB7ct7OexPtT7Cv1NJbI3mXZPslAQ2kmhjb0o tJVA35GI7EYbuNhXoUndxwwlGGV1kw8EKWsnNaOhSEfqHU6f76Gp11UR/nZRHzub5k3K TJ4rlYUdoBiLOQIx6HckqJ0KD0NV78SYo8N2CY8C134RDsqwBjO5F3yJSkRHmFfa7Gnj EiPTbR6WuFEv/+eXcOPFWlV393ixmcjBpYOGSLNXpOxjmKu/8ZQJELcCp01+Dpb0KlyG 1vxPu5eGQQEDvtrL54MSCqVxBA5v89dJpSLinovba7fitvPAKHxQSF+5yBoFriuvCptN 7E0w== X-Forwarded-Encrypted: i=2; AJvYcCXCrmxvbnz4A5xEUoK4nCjn8kbBkBccnGfZsz8+OyCpTvZSk5hhTq/IQ/anNR81k1H6ULvhBv/I8gDMEzM9@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Yz8xjuc93GgT/Mm8NgFlgGH0T8Q7DO/mtbyKEpi1KYqE6OBrB3t QGqt9ClrlROseJ3h3dWRTjU3E9vbSMTG63cg0wpH6wAQV4IH2R+66TdkWcxIxCY7KhZL9w== X-Received: by 2002:a5d:588a:0:b0:435:9144:1417 with SMTP id ffacd0b85a97d-4396f183942mr28211180f8f.49.1772036348095; Wed, 25 Feb 2026 08:19:08 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com; h="AV1CL+GNbKAsNMSTkcSni3RcI7QsPwn1KnkdzBM/PpUqjm26bg==" Received: by 2002:a05:6000:240d:b0:439:8f85:db00 with SMTP id ffacd0b85a97d-439901856d1ls454199f8f.0.-pod-prod-02-eu; Wed, 25 Feb 2026 08:19:06 -0800 (PST) X-Received: by 2002:a05:6000:601:b0:432:5d73:79a1 with SMTP id ffacd0b85a97d-4396f188996mr32405869f8f.55.1772036346021; Wed, 25 Feb 2026 08:19:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1772036346; cv=none; d=google.com; s=arc-20240605; b=QqePO6dxO+hnYnavR1QMdVlZu8XD07F7GuCfIsWmr2rrAan6Q0gi9HWpA09s/v5Jm9 jlkYoZ45tiboPbqnYvJUYnP63K0BlGWo8OFiO8hBeKhfHWzzT+Xbu2ldHr48Wq2DdMY8 7tEYkWDfDBTk36R/y1zthJyGYiPKY7VvQ6fwjZ1uXtrtFWqFedDdKrMgM6yAwUATZMIF ZxZohPQFaXBvGfHVF0Oj5QbcEEzdX97amELc2ja6KJD80Drv9JUT8ho2ogaF7I9YOlbI i9t2xgMPPKFi8CgZDfAOQEucYmEdE0e1JmdKFAZVsiqAj/jHoPVimXkgEaqPnaBWzBSt 5gUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=GkJhvi1974w4+hMGdr7GktoYxy4wpW/zeqmFApZg+vA=; fh=QZoutJPT+pXy1qUk539h9r/tpUMLR61JfMC4cgv8pmc=; b=WNco0ZbCcwXApAQzA8ehFpAuUyHigWfVOguyvo221Zg7317GhhEybAXWQq5va6h+52 1VYcZCTzVfJSspZp4QcxdDi60ogxHolbJAEAAIBeFnR3ft8H7Y6zGK3IGhVkfNCXH9+6 CuxSuGVQsZX1QWj99ORN7D8iTrhzNYjb/z/76MpkKskwGIo/+woK5rU7JSzWzr7aHmud 1vGloZh5xWIZK7G9oMEnfgxUWZ8HHmu2QHk3NbLHADjisCA8i4kFWkHMqoAadgxRvriJ nE8vmiAGejadvbsbJHNtzDEpm2PUJVCFyFGKR13nucLdWIYq73KJHOH1uvZA/iKMtnm0 Ag4w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=CgDZxRhW; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ffacd0b85a97d-43970d531d2sor2252874f8f.11.2026.02.25.08.19.05 for (Google Transport Security); Wed, 25 Feb 2026 08:19:06 -0800 (PST) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ATEYQzzp/4/smMviHSczMfTSmGMf3zSwPEfODhrNTITdcFkvl7etltiz1HLocV9+aUp np6uGrPT42sTqiq2+xf1dlSsiL81MvNcgJ3PRiO/vwMffjfK+avE1mi9KaZ77axqRrF0AQsP3+k E+ZDVu8YMMTBgF2qGuGDoxXiGR3aJpww1SRNCK5Rsv89MNNibX7WdLonLaCRtAQLLmipit5Q0n5 E/0lJzedrjGKKQ9W0X39Jc042Qock4En5S8pAoVi4jkrNGbcinjbuVMx/vIIQQzExmgdLxC/d/3 0275uIAvq00xsPdhRxAfttZnKl+sIPCVirwuQxsbXL/95PQfghCgrcVF0UEg0Daqd4v6ZhIedb7 vxysyief/Cwg/rSkbB6PshbQZ0zbjJS0Rabgn2CFYvX8Yf8QZkdoTJ93iyiSR0L7o0YgClm+FvG BlLJiMVrZQNMVUYLqtg8h6pU5gdFKZ39j8qb7q/h9tpRpCVsla8sIwhix51Li8dmtQqGqGKUgPo m3K7JsvdzC1QcCW8DrK74Xs2JLStY+ZCPY7c+pjJC9bQUbx X-Received: by 2002:a05:600c:4f4b:b0:477:a54a:acba with SMTP id 5b1f17b1804b1-483a95e1f34mr292230325e9.17.1772036345446; Wed, 25 Feb 2026 08:19:05 -0800 (PST) Received: from dario-ThinkPad-P14s-Gen-5.amarulasolutions.com ([2.196.43.111]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bd6f19f5sm186562265e9.1.2026.02.25.08.19.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 08:19:05 -0800 (PST) From: Dario Binacchi To: u-boot@lists.denx.de Cc: linux-amarula@amarulasolutions.com, Patrick Delaunay , Patrice Chotard , Dario Binacchi , Jagan Teki , Tom Rini , uboot-stm32@st-md-mailman.stormreply.com Subject: [PATCH v3 6/9] spi: stm32: add stm32_spi_is_enabled() helper Date: Wed, 25 Feb 2026 17:16:57 +0100 Message-ID: <20260225161851.2475274-7-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260225161851.2475274-1-dario.binacchi@amarulasolutions.com> References: <20260225161851.2475274-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=CgDZxRhW; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Add a helper to check the SPE (SPI Enable) bit and replace the open-coded bitwise check in stm32_spi_stopxfer() with this helper to improve readability and consistency. This is also a preparatory step for future driver updates that require checking the SPI enable state across different code paths. Signed-off-by: Dario Binacchi --- (Added in v3) drivers/spi/stm32_spi.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/spi/stm32_spi.c b/drivers/spi/stm32_spi.c index adba97915cd3..70eb8735e03d 100644 --- a/drivers/spi/stm32_spi.c +++ b/drivers/spi/stm32_spi.c @@ -192,6 +192,11 @@ static void stm32_spi_read_rxfifo(struct udevice *bus) log_debug("%d bytes left\n", priv->rx_len); } +static bool stm32_spi_is_enabled(void __iomem *base) +{ + return !!(readl(base + STM32_SPI_CR1) & SPI_CR1_SPE); +} + static int stm32_spi_enable(void __iomem *base) { log_debug("\n"); @@ -245,9 +250,7 @@ static void stm32_spi_stopxfer(struct udevice *dev) dev_dbg(dev, "\n"); - cr1 = readl(base + STM32_SPI_CR1); - - if (!(cr1 & SPI_CR1_SPE)) + if (!stm32_spi_is_enabled(base)) return; /* Wait on EOT or suspend the flow */