From patchwork Wed Sep 2 10:07:33 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4832 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 8BBEC40D07 for ; Wed, 2 Sep 2026 12:15:53 +0200 (CEST) Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-47f6db77430sf582381f8f.0 for ; Wed, 02 Sep 2026 03:15:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1788344153; cv=pass; d=google.com; s=arc-20260327; b=mKvLYzQ/o8fyZz02y1hGaKxM8tDU3fUKT8KnaqxP0x7fcZLei5uhtR0nwRHP4mHLJ/ r3TB7C4zQRkS0VDhU7Rx2NI14zL+r6z1IcjXtF+sYizbdivKDCQxaV73WNe2RXJZQ8DZ J8khA43tQttH2ZQm20bf4Zuv7blt7LDI0J4UGCFoO0V/Fy6hN0a73s2+pjawu/MA85HR Jez4DQ1/FG+7J/dyoE2Xs3JeN29318z7JDL+8KMCRSku2rYiWM1/sK+u0X3Znpl3j1KP qAa/2K2vbQhiHVbSw0tJ9h7eGXUrBX+JymaLBT47R1SHuNrdaagPFZ+bYN8IDpAnZ3eU ybCw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=DmgSSemJu7TbHsfWskFQPnTelIwHxH3qV5+yu3FHUFM=; fh=/UTvz8UgQZuwKtcHHHrWeJiqQ8KKN92LER2QyONWTlw=; b=i658Mhw1jqG+WtjhOLMZ/ybieVs6VUoXJt92ED4v0Q9lygVa1Bqx58XTTtjHzGN87p aihyqSaA8MUqOpbEW2dUkkzB2N4i+obocWrBMcDH/PVkx8jEDuXyb+x3zuTw8UGIcOVf +oqt/9jyKQBXbbaS7KVNq1DIiDFCDevKTsMa+Ta08PIvPH6cK0n2GnRn6bevGkUUXU6e EgF0VzIT97mA19plcisr16/yK8uspKKnRPRdTd5Uv1UYlO8eWZmxP5fnWG8ZMEiOO72A 33gL2e541y3JFfjSxMQJfygjmqmE0owK5iWUhLEvIFdLCxCFiRyubYhjt2OrOvldztIe A12g==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=A+6x1EWd; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1788344153; x=1788948953; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:content-type :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=DmgSSemJu7TbHsfWskFQPnTelIwHxH3qV5+yu3FHUFM=; b=MCBOSZQ6+NfKx5AtUY4Yq0ybyvm4buo/yAWVoFzw+Trup0pnUm4/aB1m78eTOSq/Oy moG0mgfq+gjuI/hp86VmFpJ7yjXbmW0IWmp9RTWwTGJRp9CTZpPtrJUl/a+hj1fTQOit kc0ok15PTxw8kfdfJxaQxJeigNtnAJxGYv1dk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788344153; x=1788948953; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :content-type:x-original-authentication-results:x-original-sender :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-gg:x-beenthere:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DmgSSemJu7TbHsfWskFQPnTelIwHxH3qV5+yu3FHUFM=; b=o+xgIa5xeBxsA98fnFyzLGLbsDc4lU3hFNb74DcNqTI1DtTBsOaEh7HRUhkV8VYFw/ oN8VSchmmumvgZJOoSsSBaMAqem9mz4VJEy+XjKTXFbt3b7+qyuW2drWM/UzIfZB4a+N MCZlNDq4NTcu61DYZRDtrF76TfYkTgsSU4lFkZoMRXD3m55r1OXRdc0WAHOy5SefAXVy LFFlae17WXdUAVejMk71oyuXuCKsHwNGLAhn5Lr0Wcj30/xWsQWARtwLlYDiJtsBlGJV zwtFFv/rJKKzkiboazKlKTzjnHVyto61sYZ6fsZpvQiXu0SEK/EcBePvJ28UUd1HHu9t diuA== X-Forwarded-Encrypted: i=2; AKwUvBwVzsS/7+WheEsNUYGz8b3iiJAX5+LtCC5+or+J6gOxAViHa8LnaMDn40Vw3UN98YBpN0YUYQZ62oOnA55Z@patchwork.amarulasolutions.com X-Gm-Message-State: AFuF++kXpJgdHb1Y3BQdkCwjPQVgrdZoPeCTcQLizR0opo8u1coUn0Fb YPXXXtsYq+WC83RIWO+isGo0wjYPuIEHwHJKrCvu8mqQ+NyHtWsnq2LelWR5t+ziGnWpV8lCZ2D 62g== X-Received: by 2002:a5d:5f48:0:b0:482:e2ea:7ff6 with SMTP id ffacd0b85a97d-48488f00a34mr5546882f8f.4.1788344134990; Wed, 02 Sep 2026 03:15:34 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h="ATskLdfQPE49T6H4TrbJ8pK0D3Pe1OiKkaC248NFyjLEA8FbJQ==" Received: by 2002:adf:e195:0:b0:47d:8d06:16b7 with SMTP id ffacd0b85a97d-482ee375320ls5638204f8f.1.-pod-prod-03-eu; Wed, 02 Sep 2026 03:15:33 -0700 (PDT) X-Received: by 2002:a05:6000:61e:b0:484:36c8:ffde with SMTP id ffacd0b85a97d-4847b625aafmr7136563f8f.0.1788344132953; Wed, 02 Sep 2026 03:15:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1788344132; cv=none; d=google.com; s=arc-20260327; b=jUgfw//1/PZCqRzxIVNfEafwarGPcs5YKL5a4ddMWyD+HltnBuHt4DO/uBXdmMI2y4 QOp6sOhB2cb86WHw7PT0TSBMoUWVFpBL6xb/fELOk8UvTl8t/j4Vo8QP7RKtqVw3Xc+G vl+/JK2eBT8qA+t+b/8w2GBj0kCcRXCGsC5whjazBGoz/x4FFwtC+e7lshJPZy6utZzc lc/JfsYErxcycdJoU4okcZIkPnZKi68k+fR6JSxwfvcY/g03ltztrWu3t0oex5IBgk17 VdlnAy00nuWsWfKhEaaXH+cR4MZ45Y/iTBq6Zk5DI8vDvyO24h2yxiHvPDR/DrXkT+1w jOzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=vA/vjABT1jnzam7kJz2zSU4WQLgLEnlH7iz/BFpMd5E=; fh=q8e/EHvBEWuf6aRaMuq+Cj9TRCAmjZAY7X57C2C+8qo=; b=Lgd/9F0d6GGe5iGT8LhV4jUyWC7xknAhYKtL/Q4J6AdKd0jACqDHF558nNmHXAHSo9 AiXCkcU1hmdXNU5FjmxwWTvKQYG3ZRQpNqnfVl6vGPT9RP1AFjB0ryVGrXv9usGpq5ie UwgzIxnA+mafuIGY5GwgDv5cr/yLA4mkwYCo3S2X+tlkEH+e5L6IaRK5+5gPSWytcKxH yb9I+9ZOJA4IR51ZbpEmXCrBwY0DJCtQoSKXt5JKr5QO/E4sD7A9uvMPAuUmUyLqCxhm 2iYZT1AVdl+4hSZYWbo2OVB3odFmsu7vVfaHfR1ED7RjUZmAm0BJfCB6c4rz1t6JGZdA kFxQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=A+6x1EWd; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ffacd0b85a97d-484494cccaasor352387f8f.15.2026.09.02.03.15.32 for (Google Transport Security); Wed, 02 Sep 2026 03:15:32 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: AR+sD12ehlDzwIrVWyQMeZyClxDvc7jhMuf3NU2yNw0hLJUGho2opzgpR45QKs0PTta NfRtHz2/lFnHJL2V1DnbQ6oEM3sLBfCAEOChzfRoCP1v/7jfteM6xuvl/pn3kl3gSX7To5jX5MR RvV/EZ3jD6uNJSU+v8NxSPPdaYT6Ax42Z8sGWfJNg4QoRZSbz4Y/gG1En4djsxwAbF+QBR7lfov OtuKRo4EUchOlZedfEL1AwwFrisNuOsYp36JX5E3Sw/L8aJTFF2xrQ8XpDq5I4C3BViJnIUuGAY sQq8mDAsHa6v+0DvSp9VoeoS+OJoGaDo9jvWR/UUwjHMF/Efa3KyeRFMdH5PXuj3Zl75MM2Rj0B SolXD/NPZBKBSL/FBOdX9v+LT3GnLDTtJ5DKBvheIDpNTvcZl9MnzC0POnKlAHXuyKzmAO39dN4 LkzMC577PqB3pLAbu+NjbIvUKDdcSAg6m85EFSuciBOKB/SK2zWnOr1PCwH2Jft9IaHDSrE1aqT LLL7EpZsevo+J6NLUcVwyohJS4yZYe1TD76Fu0+aQRRg683UkVlPQp73es1Mw41zjTqJI5ag+EL dYHlasD5hpRanNkbv8jcPVmXAC/sWioSH6+HluVSwoXJTnw03vXzZisNE8jmiA== X-Received: by 2002:a05:600c:310e:b0:49c:e3ad:41d3 with SMTP id 5b1f17b1804b1-49ce55906cfmr48006695e9.0.1788344132449; Wed, 02 Sep 2026 03:15:32 -0700 (PDT) Received: from dario-ThinkPad-P14s-Gen-5.homenet.telecomitalia.it (host-87-9-102-148.retail.telecomitalia.it. [87.9.102.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cdd73f7a4sm139618475e9.12.2026.09.02.03.15.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 03:15:30 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Brian Masney , Cristian Marussi , Jerome Brunet , Peng Fan , Sebin Francis , Stephen Boyd , linux-clk@vger.kernel.org Subject: [PATCH v12 1/3] clk: scmi: fix SSC permyriad conversion Date: Wed, 2 Sep 2026 12:07:33 +0200 Message-ID: <20260902101515.167819-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260902101515.167819-1-dario.binacchi@amarulasolutions.com> References: <20260902101515.167819-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=A+6x1EWd; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The spread_bp field of struct clk_spread_spectrum holds the modulation depth in permyriad (1/100 of a percent), as documented in clk-provider.h and in the assigned-clock-sscs binding. The i.MX SCMI OEM extension expects an integer percentage in extConfigValue[7:0]. The conversion divides spread_bp by 10000 instead of 100, so any valid configuration is truncated to 0 (or to 1 for a 100% spread) and the hardware is silently programmed with no spread at all. Divide by 100 to correctly convert permyriad to percent. Fixes: 77369b1e6a37 ("clk: scmi: Add i.MX95 OEM extension support for SCMI clock driver") Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/clk/clk-scmi-oem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk-scmi-oem.c b/drivers/clk/clk-scmi-oem.c index be11d359b4ec..3e56e91ae68c 100644 --- a/drivers/clk/clk-scmi-oem.c +++ b/drivers/clk/clk-scmi-oem.c @@ -44,7 +44,7 @@ scmi_clk_imx_set_spread_spectrum(struct clk_hw *hw, * extConfigValue[24] - Enable/Disable * extConfigValue[31:25] - Reserved */ - val = FIELD_PREP(SCMI_CLOCK_IMX_SS_PERCENTAGE_MASK, ss_conf->spread_bp / 10000); + val = FIELD_PREP(SCMI_CLOCK_IMX_SS_PERCENTAGE_MASK, ss_conf->spread_bp / 100); val |= FIELD_PREP(SCMI_CLOCK_IMX_SS_MOD_FREQ_MASK, ss_conf->modfreq_hz); if (ss_conf->method != CLK_SPREAD_NO) val |= SCMI_CLOCK_IMX_SS_ENABLE_MASK;