From patchwork Fri Sep 4 10:06:30 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4839 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id E9ABD3F1D4 for ; Fri, 4 Sep 2026 12:12:53 +0200 (CEST) Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-4858e4b3e92sf17335f8f.3 for ; Fri, 04 Sep 2026 03:12:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1788516773; cv=pass; d=google.com; s=arc-20260327; b=fUgzIvQXU9UetstL+kLd/ZPDE0w7ygq/QhRl1cmRfzRjvUZ7B2xodHvwFS0Ar8J106 RsLaWg1uMV0d+0DOBEcDdb+Y4VW93dMmqCWyvxyyRTdvAb4vX1aALKBPOUjYwbCgF3o0 TIoz2sqg260U1ukc9MKV5FINr5jRYJ8pNfQNCglt1Utxu/dj8V4qYGDzpBQb12BzvZ8T Oz2leMSTsWvIL3fQkGMfcgoZvxznwv7Katihpi1YffKQ/ciTRtJBWkgL5ufvUPZohcPp 9yJn5af4XOVb6fT76d9y+ba+HQ0WWFISu4vkVHu65cTFFNpXy4zRUi2txMWYJEnZarxj BkQQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=O52Jv1BOSzJXz32j5fkK0fcdem20r+ryLKZbLZ0pLhw=; fh=q2hFqDdF+XmB5lDMQiELgKsyFTg4kA+BXCoLkUFHBs4=; b=oSjrmBGt0vhXmhTDrWqbhbm33d2FGztKyIst7BS0tKDFp5SUTUGXRbWC5PmMFOhYlX GmlLC2p25W1YVLHFASB0S7UvXrYNUl9gOUUGtg9sfL+vCqJR9CuzM6z7dK94isGDVVu7 JjPGrOpDwB5UuTltligNmy+YP+A1H13zfX3Qi+1JR64SjFQ03NQFq333TFCD5IfKCdWU ifFlAfponOwFJ0gCE5LCNhOPH6sL7n5fUlRzLMaoPNqZtgQaOX4S1uKBz6lgQQDGCFEX ATQWWPf6BmWdIl5UOK8E2xlxjxiFBCQDRB1cGyK1QR0zgUYIXGmG+SX7qw5pdvFyqaqh cXgw==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=fTYoQSHa; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1788516773; x=1789121573; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:content-type :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=O52Jv1BOSzJXz32j5fkK0fcdem20r+ryLKZbLZ0pLhw=; b=TsB0ovDzkFMJPi6D/+D+fWkKk/W1uvoOomvtXManp9NquuutINUZiB5luC6bL4EA4v m/vUMm7LpAWEt5KZ1WCpIQYGu8/Vq8yjy6tLsL1l0vbX9UsF0pWGftcB+1rATza+65ys B8jB0Z/uIllUY/qMawWllezSsvfk19PpXKySk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788516773; x=1789121573; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :content-type:x-original-authentication-results:x-original-sender :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-gg:x-beenthere:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=O52Jv1BOSzJXz32j5fkK0fcdem20r+ryLKZbLZ0pLhw=; b=gvELmKC4GrsgHxdiiaWXBXNMxCAX4AJHhljQ6ZJSaMo4mgHEqZkqdEp7o+caQ0lTSI P5nUGAmUqCU9SJhq6FRKZfFAVpFskv5KVG6B7BY+PdC5bMDqzDrv84BaPZ715UxwQddd vVbVCy45H+Dyed3Ry/g11Wj5Hg8sbQnn9JN9F2PtzBG81PCnZODe23MHlnXyfpGmpVaS nziSvz3ok2d/FMCw817bmeN6zNH20dvNZ1hYa/jpqNudZXvU1Fh9WDccy/SZIdKWCaJA KNLSJkE+pwYtRFNT5T3oVgRRWg7EF4bcHydgtF7UohlqQ7aMqhGJcWH47/yXgd0aLvhO FqCA== X-Forwarded-Encrypted: i=2; AKwUvByBvHFQCTT6wLn78djpwNEePmPuNTIlJ34DYxSxPiSKlR6YJZQ3JxEzoiHKchgVfwiMnUkven1Lj9tWYwdu@patchwork.amarulasolutions.com X-Gm-Message-State: AFuF++lqp3kQGKhpm73Kuh3ofBdOSz+S6PRGAqZOJG/Ss/GKdzyOOV9r Zr2lUt3PehicruG5DCjkB3cWUXHkOIUGD2TJNLpvcoo3zB7APjtuYO/rmYjyorDQzyIzzSn8JiB PaA== X-Received: by 2002:a05:6000:26d3:b0:481:5b58:c589 with SMTP id ffacd0b85a97d-485870935eamr6318300f8f.10.1788516773586; Fri, 04 Sep 2026 03:12:53 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h="ATskLdeDc+q11GpMOx9nZKzR+hPivyN1JYdKfLR/QZvFD2+TDQ==" Received: by 2002:a05:6000:25f7:b0:47f:5ef0:da75 with SMTP id ffacd0b85a97d-4858651a2a2ls527372f8f.2.-pod-prod-03-eu; Fri, 04 Sep 2026 03:12:52 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBxNk445KR+HjnrWHg0K1tfSMPF7uwDU76bI9mNIw15w4zyCp2wQGcyoyRW6O0g2DAQe9Y+gONuxvhMhM7yh@amarulasolutions.com X-Received: by 2002:a5d:5e87:0:b0:485:8a47:5b85 with SMTP id ffacd0b85a97d-4858a475c6bmr2998734f8f.34.1788516771531; Fri, 04 Sep 2026 03:12:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1788516771; cv=none; d=google.com; s=arc-20260327; b=PQsPJVYOLU45hqJJq0lXq0EgTNCttbUVCiqAsxSKOv9Wdf87aiISPdjm9yII3noGaR uquQ87sXY6+3xdtfckZNedk2/N1WoXgPg0CWYFv+PuKWLBN82rgBEPU/3FW5gSBF+Uz2 zKoYLFLLbat+eyMCbuVEh/JgfTmFmincGl+iW+R+HOnZCWe+tVeq5Fc4rI1uunlh5rzx EvXLbCM0jiy79j2dvXfsi4OeKFcc7PkAgmqV7qXzs6AtPSs4n9+iQbWFIyTt/YX+oZCu 9caawR19+7n/ysk2SpMNkYHDB9UHDKaXgJugNJ210i9Z9A1/vobl62jui5DpSfIxYfeN IuOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=trMLdDdWbBp5aYskl2hpYhEKm0ijNRyi5bjjWx05fj4=; fh=PGTbqOq+Ia+l7dW4IIb9tEOZNED8hpyIKodVoKPXwDE=; b=KuPwwYiWPRqdLa4G35u1gR9+k2jtbTvWi0cGd9B5kJN6nu+cz+2lHPcOGjKTffxUjl 6VNQRqWWvGtHm+tXTYdEemQCSWUvE8QqwS+bpSc3yFeprcfcj03OZ8sgeLfKEqZX9yNQ zNX48PmTaPTJSTUrYDywGA6InLNbcAHmjEcTbfrg9nW+/zUKGArLy+eLRaPZeCa9e4n5 MHLCmC1zGkAv5aBV30htXHJAn5hWaJ3rdmnlRhKQNH9vAkJmA8LaLjTsUaFMr6pAsQ4q 3B1SVUyblmXoICThXck6v8JtYbI3Km0WCoOE0p+kCaTDMVc4OPCc8sJFfuCh7h+ZI2pI xreA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=fTYoQSHa; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ffacd0b85a97d-485885bad5bsor304622f8f.9.2026.09.04.03.12.51 for (Google Transport Security); Fri, 04 Sep 2026 03:12:51 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AKwUvByLCC2DypbD4cNt5fiw1F+guk76m4wgp3Y7IXBaE/K6SqMuXlfzJ7n93fEJi56eK/SHgS90PKXkmUHZJvNT@amarulasolutions.com X-Gm-Gg: AYBFou3dgMBxFh1Yr+CIs7npFjS2HCQPUC/+zo3hVG7HHJVpfiRp9lZljgUSiKl8Tpe lkh+D/cpPhVkyCZ9ZdAXLBgMea75IaFjLtuvJX7A1Atay8Mi9avUlO++WTygPZcflv0P+B0FCBr wWX48j6B2Bgunsh35qKZhfs9j5BT9c7G3Ylcioge4voqtZSJzDXZsVaa8R9aFFEV5Gz6okUxjLa KX/02L7k5yNerO03r3lyJtROoDY+g+3AUzu56y3xiYekfgYWxf78paV0U+RPa1gW9M9pPyKyAUn BiJ/G1jPzv9mUNwoSCwrDpR6ahv26+ACoJp7l9hY4oOoUvHQ3+6SqZFdS1776VOvOaM1/hoZ3qz 5Dbr46AdqTQOlhIqpvwc7Z7Yq2GcIhiKbftZqW6lIDcJK4fu9chqA+Eggxc8YLXwwp5Zh6mQ7WT 7P4wC33RUDKG0ZONJuM7Zs/KSxCJe1jHRj8kcUxY4VNvQe9qOAWN/b8OrI2htGfNdXaZNMz/CH3 6op7HZ4T0lASEUztUOtUAkruTHK2QXk+bGuDOxNAtl7Pzw3LC0ErGEobTJz0zNL6kiTenRGSc7/ 8KfnLkzYjTA3GsHGD3J7W68XcKap641yT5FTv2TDfpi2oWFfM6bnXiZABjCtuupOcw== X-Received: by 2002:a05:6000:41d8:b0:485:8a47:5b96 with SMTP id ffacd0b85a97d-4858a475cc1mr2833945f8f.51.1788516771007; Fri, 04 Sep 2026 03:12:51 -0700 (PDT) Received: from dario-ThinkPad-P14s-Gen-5.amarulasolutions.com (host-95-245-93-90.retail.telecomitalia.it. [95.245.93.90]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48588390e30sm5317990f8f.7.2026.09.04.03.12.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2026 03:12:50 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: michael@amarulasolutions.com, linux-amarula@amarulasolutions.com, Dario Binacchi , Sashiko , Peng Fan , Brian Masney , Cristian Marussi , Jerome Brunet , Sebin Francis , Stephen Boyd , linux-clk@vger.kernel.org Subject: [PATCH v14 1/4] clk: scmi: fix SSC spread conversion Date: Fri, 4 Sep 2026 12:06:30 +0200 Message-ID: <20260904101243.412006-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260904101243.412006-1-dario.binacchi@amarulasolutions.com> References: <20260904101243.412006-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=fTYoQSHa; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The spread_bp field of struct clk_spread_spectrum holds the modulation depth in permyriad (1/100 of a percent), as documented in clk-provider.h and in the assigned-clock-sscs binding, while the i.MX SCMI OEM extension expects a value in tenths of a percent, as pointed out by Peng Fan. The conversion divides spread_bp by 10000 instead of 10, as reported by Sashiko, so any valid configuration is truncated to 0 and the hardware is silently programmed with no spread at all. Divide by 10 and fix the comment accordingly. Fixes: 77369b1e6a37 ("clk: scmi: Add i.MX95 OEM extension support for SCMI clock driver") Reported-by: Sashiko Closes: https://lore.kernel.org/r/20260901155657.6A5981F00A3A@smtp.kernel.org Reported-by: Peng Fan Closes: https://lore.kernel.org/r/ZR6PR04MB375776A27E98F140534E8F7FE488B62@ZR6PR04MB375776.eurprd04.prod.outlook.com Reviewed-by: Peng Fan Signed-off-by: Dario Binacchi --- Changes in v14: - Add Reviewed-by of Peng Fan Changes in v13: - Divide spread_bp by 10 instead of 100 as requested by Peng Fan. - Rename the patch title and reword the description accordingly. - Add the Reported-by/Closes tags for Sashiko and Peng Fan. drivers/clk/clk-scmi-oem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-scmi-oem.c b/drivers/clk/clk-scmi-oem.c index be11d359b4ec..c1ebbdc6bbc5 100644 --- a/drivers/clk/clk-scmi-oem.c +++ b/drivers/clk/clk-scmi-oem.c @@ -39,12 +39,12 @@ scmi_clk_imx_set_spread_spectrum(struct clk_hw *hw, u32 val; /* - * extConfigValue[7:0] - spread percentage (%) + * extConfigValue[7:0] - spread percentage in tenths of a percent * extConfigValue[23:8] - Modulation Frequency * extConfigValue[24] - Enable/Disable * extConfigValue[31:25] - Reserved */ - val = FIELD_PREP(SCMI_CLOCK_IMX_SS_PERCENTAGE_MASK, ss_conf->spread_bp / 10000); + val = FIELD_PREP(SCMI_CLOCK_IMX_SS_PERCENTAGE_MASK, ss_conf->spread_bp / 10); val |= FIELD_PREP(SCMI_CLOCK_IMX_SS_MOD_FREQ_MASK, ss_conf->modfreq_hz); if (ss_conf->method != CLK_SPREAD_NO) val |= SCMI_CLOCK_IMX_SS_ENABLE_MASK;