From patchwork Tue Jun 11 14:51:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 520 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id D38203F08A for ; Tue, 11 Jun 2019 16:56:26 +0200 (CEST) Received: by mail-pg1-f198.google.com with SMTP id a21sf9259461pgh.11 for ; Tue, 11 Jun 2019 07:56:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1560264985; cv=pass; d=google.com; s=arc-20160816; b=LbzUk3eSnJAU6LhPO8swK9IlqB5bdqkenN8Ri9P/p9dgSRtQvwv8AzLwEzREF12iyr TyB6BixKDHsAzEnZDziWgOAFvd6D84gTTe4zfxhoti4/gHrljrnhHdB5ukQpWw4aTjqs jomV+57XJ+nQzheIk+m+gY1V3QirE/m80oku4dRSA3VSj50g91Jsd9lUUdj4TVLpCGWb tyf9UXkaEchABCqXZi3ivnWCcNdzUrRcVLJlwUahWvqrP/EV+LJavDRitW6pANqR6XPg w4s3IMFbkBFJUEa/h7aR2Qh4LHceIgnWWBQmHPbj6H/UrTfJszQwmOeBV1ipZVBqtdPf zPXQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=Eb0a8TQhOJT8UxuTC9UM0le+JxMOYqOT7COxYjw4RqU=; b=tdEpfJ5bqfZYbY14yH1dsJazH5cb6gSzfOD/Jyog3XenWj0q1mWMY9y2LWv427x+6N Dh09ctUimdVNFdLoLCGuNHiLmSFDWWPfjNvx5xadMe/ix+WdUvgbigxHcPNI3TQScS6x kAG0CatxdDQi0Pts3q+QywzJcSp+t3iD2+S+bJmG/CNWqf/HHlXnIimEmU1tdg8BjUj4 XXTlUC7ajqiDEsC/2MoECL773VC463zK5oU6DySO1jUkL96DOIuKvblPBiD8u3IUEeaa w3pB90L/+SrEi2OWrElJ8djdcj1NEQYi/t90HGOuSw8ERjzMx0YOFD2iOaSloPiChf4k KISg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=mqkCBdj5; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=Eb0a8TQhOJT8UxuTC9UM0le+JxMOYqOT7COxYjw4RqU=; b=L7GslkCur5aP2zdrNS9hy7JAKLlGHUXMRzgXggl8vqhBX3QB5jSFfx/7wr53XCt0fl 1oSYqJAq2uXSt+44XOzg9+kuSuKR+mHRth5fRHedsmLatbQvLmIrfrpZ6rAakk/spjRl VVnavZYFgIpNwc29Q2+KNFM+Fjb09vpsiULbo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=Eb0a8TQhOJT8UxuTC9UM0le+JxMOYqOT7COxYjw4RqU=; b=S9j0ciUpK0SxmVUzsalLGn2tEsBuY6G3O0mGJvM3j1mdeBBK6bzryb8IxrytskXXEg 6lrBTb4dHluIgXvx5EVNBWlcOVCLTqTrPcZJlpLGOck3QxRAZHMBpvxx+VB7QsZUGPaA ZhQtlozl/8erBlE3zhT9s+0s9BZ8LSNSI7LFqabGZRlyYkc9RtvCkSI/LnSx6cycBoEr +KhXYALNun5ufVxBuQlrh57/oOZyguxT4sXqKdyELnsh8g8MDtcsBusbWdqMh1hFtSTs 1ddxreDqAvWzlv6BsDA4NBY+ahrBvvFkmjWudG1fkssOW2omgelCKh9sQ1Sd2O/rK7Vw 90uw== X-Gm-Message-State: APjAAAUNJLuCBWY+IrJV5M2FRO/RG6NwLEP1t8iQyLsBiTfHVFRMqc8j 0MyN7bgbT4r5OmYx5iAeaYZVxNAx X-Google-Smtp-Source: APXvYqxsLm+rG7C8Te1kX5Ugv+4mNfk1XcKnXdnS7T0igoxjY5dTkeaEFzZ1EnvNR7rXVLCt8p2jrw== X-Received: by 2002:a65:42cd:: with SMTP id l13mr20274576pgp.72.1560264985597; Tue, 11 Jun 2019 07:56:25 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:902:b605:: with SMTP id b5ls4896248pls.12.gmail; Tue, 11 Jun 2019 07:56:25 -0700 (PDT) X-Received: by 2002:a17:90a:7343:: with SMTP id j3mr26034474pjs.84.1560264984965; Tue, 11 Jun 2019 07:56:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560264984; cv=none; d=google.com; s=arc-20160816; b=AK2zOYlX1WWEtGrzwRN9AAgOSnp43ZTjffr99k3a/4HWpgAU5n252QwCGIKmITE9Ax qGdEAx6e9/HMAXF/RVkr0twj/L/3qMIgQWghwQNU4ceWuVlahZOCV0MmwMtW1BjASJPr SuirHVAftQR/WqVHltBHWAPWRg2XBZdh/6uMEKuZOGg2D41q+wHvEu7BGIZvLN/fy47u FSjhIviCQzXRKLucS54/beGrxO+azsvVLcUJ7qUGJ5/S9RCEqzoLJ+sx3GB9asKoE6Y2 P6/KxS5t3Rdl/fSChurI9afeCqE2N2gdsHcuoFwXyHkLawRIPqiMfgc1XmfZuz/SV6SI 4jxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=CdKYTAWEPhUXylEOQSNrbOliIo7eTy5laKiwuvhYZ0Q=; b=RVJDjU8ReGJlRtsDbQzOo4bRWj+bXQNrACBvG5+/AFFdI302jm7DX3rNbkfEZt3wY+ lctmQgjTc4yTP8HviPJk3Re676lTPcXcEXq89nkSGVdvraEd19LiHpDRQWQoYOqZTJpE jfp0dmUm5bAwyIVcPqX/vRNlxDE46kQV3/NDtFgAnR/piTngTj2Tz5xMFZPV4wwCO6/D I2koQf1Ih2vXIF7sMff8TCXmdBjIHtQknVv0EBpoLwYd6PNQHzOV2sb6Q0x7Kkv7oNb6 cpjVltXv+GRg0TmVqqN7Uiw/rZDrNcR9e26EuTHbQdp3wj/2KLH73DtmwOQAJcAI0q7n QQJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=mqkCBdj5; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id x5sor3270183pjp.9.2019.06.11.07.56.24 for (Google Transport Security); Tue, 11 Jun 2019 07:56:24 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; X-Received: by 2002:a17:90a:a116:: with SMTP id s22mr26976818pjp.51.1560264984603; Tue, 11 Jun 2019 07:56:24 -0700 (PDT) Received: from localhost.localdomain ([115.97.180.18]) by smtp.gmail.com with ESMTPSA id e9sm16206208pfn.154.2019.06.11.07.56.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Jun 2019 07:56:24 -0700 (PDT) From: Jagan Teki To: Simon Glass , Philipp Tomsich , Kever Yang , YouMin Chen , u-boot@lists.denx.de Cc: gajjar04akash@gmail.com, linux-rockchip@lists.infradead.org, linux-amarula@amarulasolutions.com, Jagan Teki Subject: [PATCH 69/92] ram: rk3399: Don't disable dfi dram clk for lpddr4, rank 1 Date: Tue, 11 Jun 2019 20:21:12 +0530 Message-Id: <20190611145135.21399-70-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20190611145135.21399-1-jagan@amarulasolutions.com> References: <20190611145135.21399-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=mqkCBdj5; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The hardware for LPDDR4 with - CLK0P/N connect to lower 16-bits - CLK1P/N connect to higher 16-bits and usually dfi dram clk is configured via CLK1P/N, so disabling dfi dram clk will disable the CLK1P/N as well. So, add patch to not to disable dfi dram clk for lpddr4, with rank 1. Signed-off-by: Jagan Teki Signed-off-by: YouMin Chen --- drivers/ram/rockchip/sdram_rk3399.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c index a251fc6045..9151b023e2 100644 --- a/drivers/ram/rockchip/sdram_rk3399.c +++ b/drivers/ram/rockchip/sdram_rk3399.c @@ -1233,8 +1233,18 @@ static void dram_all_config(struct dram_info *dram, writel(noc_timing->ddrmode.d32, &ddr_msch_regs->ddrmode); - /* rank 1 memory clock disable (dfi_dram_clk_disable = 1) */ - if (sdram_params->ch[channel].cap_info.rank == 1) + /** + * rank 1 memory clock disable (dfi_dram_clk_disable = 1) + * + * The hardware for LPDDR4 with + * - CLK0P/N connect to lower 16-bits + * - CLK1P/N connect to higher 16-bits + * + * dfi dram clk is configured via CLK1P/N, so disabling + * dfi dram clk will disable the CLK1P/N as well for lpddr4. + */ + if (sdram_params->ch[channel].cap_info.rank == 1 && + sdram_params->base.dramtype != LPDDR4) setbits_le32(&dram->chan[channel].pctl->denali_ctl[276], 1 << 17); }