[v5,1/2] arm: i.MX: Add CMD_NANDBCB Kconfig entry
diff mbox series

Message ID 20190612083231.7816-1-shyam.saini@amarulasolutions.com
State New
Headers show
Series
  • [v5,1/2] arm: i.MX: Add CMD_NANDBCB Kconfig entry
Related show

Commit Message

Shyam Saini June 12, 2019, 8:32 a.m. UTC 
Add Kconfig entry for CMD_NANDBCB, and default y on i.MX6
platform with NAND_MXS defined.

Reviewed-by: Stefano Babic <sbabic@denx.de>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Signed-off-by: Shyam Saini <shyam.saini@amarulasolutions.com>
---
Hi,

This patch series is based on feedback gathered from this [1] discussion
and [2] patch submitted by Stefan.

[1] https://patchwork.ozlabs.org/patch/870467/
[2] https://patchwork.ozlabs.org/patch/897222/

Changes for v5:
- New patch
Changes for v4:
- No change
Changes for v3:
- Fixed Typo 'seprate'
Changes for v2:
- New patch
 arch/arm/mach-imx/Kconfig | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Jagan Teki June 13, 2019, 6:13 a.m. UTC | #1 
On Wed, Jun 12, 2019 at 2:02 PM Shyam Saini
<shyam.saini@amarulasolutions.com> wrote:
>
> Add Kconfig entry for CMD_NANDBCB, and default y on i.MX6
> platform with NAND_MXS defined.
>
> Reviewed-by: Stefano Babic <sbabic@denx.de>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> Signed-off-by: Shyam Saini <shyam.saini@amarulasolutions.com>
> ---
> Hi,
>
> This patch series is based on feedback gathered from this [1] discussion
> and [2] patch submitted by Stefan.
>
> [1] https://patchwork.ozlabs.org/patch/870467/
> [2] https://patchwork.ozlabs.org/patch/897222/
>
> Changes for v5:
> - New patch
> Changes for v4:
> - No change
> Changes for v3:
> - Fixed Typo 'seprate'
> Changes for v2:
> - New patch
>  arch/arm/mach-imx/Kconfig | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index ec09ef240f..5dd286f9a7 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -71,6 +71,17 @@ config CMD_HDMIDETECT
>           This enables the 'hdmidet' command which detects if an HDMI monitor
>           is connected.
>
> +config CMD_NANDBCB
> +       bool "i.MX6 NAND Boot Control Block(BCB) command"
> +       depends on NAND && CMD_MTDPARTS
> +       default y if ARCH_MX6 && NAND_MXS
> +       help
> +         Unlike normal 'nand write/erase' commands, this command update
> +         Boot Control Block(BCB) for i.MX6 platform NAND IP's.
> +
> +         This is similar to kobs-ng, which is used in Linux as separate
> +         rootfs package.
> +

This patch structuring is not in proper order.

01: Add support for nandbcb (would have all required code, kconfig,
makefile changes)
02: Enable it on board config.
03: Readme, about the steps.
Shyam Saini June 13, 2019, 7:20 a.m. UTC | #2 
> >
> > Add Kconfig entry for CMD_NANDBCB, and default y on i.MX6
> > platform with NAND_MXS defined.
> >
> > Reviewed-by: Stefano Babic <sbabic@denx.de>
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > Signed-off-by: Shyam Saini <shyam.saini@amarulasolutions.com>
> > ---
> > Hi,
> >
> > This patch series is based on feedback gathered from this [1] discussion
> > and [2] patch submitted by Stefan.
> >
> > [1] https://patchwork.ozlabs.org/patch/870467/
> > [2] https://patchwork.ozlabs.org/patch/897222/
> >
> > Changes for v5:
> > - New patch
> > Changes for v4:
> > - No change
> > Changes for v3:
> > - Fixed Typo 'seprate'
> > Changes for v2:
> > - New patch
> >  arch/arm/mach-imx/Kconfig | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> > index ec09ef240f..5dd286f9a7 100644
> > --- a/arch/arm/mach-imx/Kconfig
> > +++ b/arch/arm/mach-imx/Kconfig
> > @@ -71,6 +71,17 @@ config CMD_HDMIDETECT
> >           This enables the 'hdmidet' command which detects if an HDMI monitor
> >           is connected.
> >
> > +config CMD_NANDBCB
> > +       bool "i.MX6 NAND Boot Control Block(BCB) command"
> > +       depends on NAND && CMD_MTDPARTS
> > +       default y if ARCH_MX6 && NAND_MXS
> > +       help
> > +         Unlike normal 'nand write/erase' commands, this command update
> > +         Boot Control Block(BCB) for i.MX6 platform NAND IP's.
> > +
> > +         This is similar to kobs-ng, which is used in Linux as separate
> > +         rootfs package.
> > +
>
> This patch structuring is not in proper order.
>
> 01: Add support for nandbcb (would have all required code, kconfig,
> makefile changes)
> 02: Enable it on board config.
> 03: Readme, about the steps.

okay, will fix this in next version.

Thanks!!

Patch
diff mbox series 

diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index ec09ef240f..5dd286f9a7 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -71,6 +71,17 @@  config CMD_HDMIDETECT
 	  This enables the 'hdmidet' command which detects if an HDMI monitor
 	  is connected.
 
+config CMD_NANDBCB
+	bool "i.MX6 NAND Boot Control Block(BCB) command"
+	depends on NAND && CMD_MTDPARTS
+	default y if ARCH_MX6 && NAND_MXS
+	help
+	  Unlike normal 'nand write/erase' commands, this command update
+	  Boot Control Block(BCB) for i.MX6 platform NAND IP's.
+
+	  This is similar to kobs-ng, which is used in Linux as separate
+	  rootfs package.
+
 config NXP_BOARD_REVISION
 	bool "Read NXP board revision from fuses"
 	depends on ARCH_MX6 || ARCH_MX7