From patchwork Mon Jun 17 07:31:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 600 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id D40113F353 for ; Mon, 17 Jun 2019 09:37:59 +0200 (CEST) Received: by mail-pg1-f197.google.com with SMTP id b10sf7175838pgb.22 for ; Mon, 17 Jun 2019 00:37:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1560757078; cv=pass; d=google.com; s=arc-20160816; b=slkZCzuL0Eqks3E03iVTHUM4/iqwRO3MEQyOtGPwTbQU7+vUomm41Lkf91Cl8i0JZS 5vqGHgcS6rX2+BDcj+8ts5nXswG6dacG7etNDLcmM1b5dNEflRZvo6QtGh4hqBdhZmQD uTOAm6YjrrsvUTuSLJ39Lz/GTcqth/qQGYHXy4AqGrUfxxrRdUWwod/P18HluAeC1toY l+Xg5/yCVANXGwwo+HXNuWnGKm9Qu6aMcVQpXmOnnrYk5TDru9K955wcIAWnMokJC+Qi 5gK55GN1Lt98t+soZx6U0eWj9TUaEkgSuPfvpNO8cWxduqGs51SaFKzxlJqJ7kdwbeD6 F59g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=9rFX/RU8nkT8SJS/yuZUPbE8Dxtj+D4awtaD1L1ss74=; b=oaX8MGk21WkK6wq0ZXsmFUKkNSEYmq7PaZtDI4EHGDUzkWlxDUkiU6CBUBwSkgfT5O 6uQOyUfsag1ppBtAAJX0Kmg6YHQ5oQnSAhgPfjd24MQC0OJyF4jEiNJLlDeR15c7YU65 ha5d57O88iADWGQ6Jc0y4kKK2UpPpiUbPUhb33k58s/SDfyK7skSOy83KlOtpEyi7NaY 7Ns/PlSQyNGqSkoPgmJ8S7CU1hHFah1rKZQYjHX9l21o4hx2e4vN28yhNPynERjPJdDj 4oiGDATl15JycGxZ0jPQarKztmgZjUL53xQKY8ATxEFYbmlTp6MYnMk0D7bZ9NFmIdpX XZHw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Lmmb1TIQ; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=9rFX/RU8nkT8SJS/yuZUPbE8Dxtj+D4awtaD1L1ss74=; b=fhpq3fb0TH4iT0VA4xqQA7RodhWW3PdNSkUuY9CSrO+zDrZVj65k5Ny4qUj+6zqTbh vbdrOOGAt7EdTXrYNg0IfjfGl/9J7guFEev1boVQRj9uErYLG8IupWZ+1ySeRzx9nnkZ BysNgI0C5MkcStq4JYIkdAPEdu6PvIzGrIhSc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=9rFX/RU8nkT8SJS/yuZUPbE8Dxtj+D4awtaD1L1ss74=; b=tcCzrB678RxDJ/yIDDYmVeSKmK9/HzhEhiFiw7xFEV2csVcriEmbhluod+RE0C5+aR DriSZB3iTHep9Aa9nT0fkScoN0uB9uqd1xPxN8wBiWOTCatWVLpbz+4NWcph0gFU9oVO pexY8sEg8slhzOzFi+tKd4yFjGBa9wiCt6wapS5rX44/Hg3h9NU/dkizWN2fubCFUwMb MSOT3llHPFny4bF2dDfkWO1K8qiZhnR2KOoxlRNhczEnmY2w4FBPdaYqH6tVFHCIEB19 9yA9opaeQuPQvA61KUWgkhT3YtmnozGK9FrpWDgDsc+iKzvxXfz7XbijKNkL1GzI2pcS WuUA== X-Gm-Message-State: APjAAAVfpJXR99Tyfjlhw+BU8N74c/nBWtQYSMfgDjblgtUer7R9xUfh XIpzp7qu1R9ie0F5P2TnL0Hkn9uN X-Google-Smtp-Source: APXvYqy74CdQHKSxzuLVqTe47cFAG40wyol4P8MNKs5V9HNB2HBrYRXXpzh/Uw3R2z6Fm/RMh05wcQ== X-Received: by 2002:a62:1ac8:: with SMTP id a191mr50827660pfa.164.1560757078688; Mon, 17 Jun 2019 00:37:58 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:90a:3aa7:: with SMTP id b36ls1456127pjc.5.gmail; Mon, 17 Jun 2019 00:37:58 -0700 (PDT) X-Received: by 2002:a17:902:b098:: with SMTP id p24mr16337737plr.146.1560757078359; Mon, 17 Jun 2019 00:37:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560757078; cv=none; d=google.com; s=arc-20160816; b=ylJ3ncn137NaWfwxiM8RZlb39Znzhs4U+lf9jOsV+BtbVv7ID57qMO8d/mX+vq3Uqu E5fCsphlvHjEoIBtM3MOsaRHWiFQbaxhujlac4rI9LFHv4JXZc6f422RebJ2eOjZfgjw ATMsxWVO4JIi13CB50MGEST2yT99B6ZWANOOAFfArJwyNCVvNFXOiYe4POkSoJ0KHLy1 gXZQbhDxhykxR8R8SbniK40cJ0EYyeU/sBg4/4ZKgozhCHGVixgHCPFRdaprkyRRyVre txhsRnCe+gMn8OnbQKWaqj9Q/vnyOrHiC+gU7RXuDb6Fw+TWY60GsBj0X2uT7boOrsYz i0WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=aKfA0ut8I1Le1vPQe5OQteNOxVFg016J7FpHlk5ewlI=; b=rU3evRefubJM6F0im/W8iwEXsdaoRjyS/elezG0hpyCxhTcBhW0KGZfZdftgBxFw55 I2LHnfRluZU3pnuadGzC/5/9otrrFN26IsH2+yz41QnnPeOUT2gxjkhYpjQ4uoVwyJoJ laLqNN4b+XYp0uVDALc3WIHpwH4wlk2k1ohX3jokJMLe8LCMbIXPro0h9YyzL/1oxjCM 5PCaf9zGy8r9XHuFYQCTZYhBlvSzEJjmRC7eZBBQAEsAaXgj1epn7/edf0+TLpkUtvRo X+1et/P+WVDfuUPUSC6PIJUx/9QQxBSu0mLVbHWz5DGiS36aDuRTBuibTmIGRr9cweRB jINw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Lmmb1TIQ; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id j2sor12496064pll.35.2019.06.17.00.37.58 for (Google Transport Security); Mon, 17 Jun 2019 00:37:58 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; X-Received: by 2002:a17:902:6ac6:: with SMTP id i6mr92874147plt.233.1560757078092; Mon, 17 Jun 2019 00:37:58 -0700 (PDT) Received: from localhost.localdomain ([49.206.203.245]) by smtp.gmail.com with ESMTPSA id m41sm15205998pje.18.2019.06.17.00.37.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2019 00:37:57 -0700 (PDT) From: Jagan Teki To: Simon Glass , Philipp Tomsich , Kever Yang , YouMin Chen , u-boot@lists.denx.de Cc: Manivannan Sadhasivam , gajjar04akash@gmail.com, linux-rockchip@lists.infradead.org, linux-amarula@amarulasolutions.com, Jagan Teki Subject: [PATCH v2 29/99] ram: rk3399: Handle pctl_cfg return type Date: Mon, 17 Jun 2019 13:01:42 +0530 Message-Id: <20190617073252.27810-30-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20190617073252.27810-1-jagan@amarulasolutions.com> References: <20190617073252.27810-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Lmmb1TIQ; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Add proper return type handling of pctl_cfg with meaningful print statement. Signed-off-by: Jagan Teki --- drivers/ram/rockchip/sdram_rk3399.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c index dc9229ddf3..d408459daf 100644 --- a/drivers/ram/rockchip/sdram_rk3399.c +++ b/drivers/ram/rockchip/sdram_rk3399.c @@ -1119,6 +1119,7 @@ static int sdram_init(struct dram_info *dram, unsigned char dramtype = params->base.dramtype; unsigned int ddr_freq = params->base.ddr_freq; int channel; + int ret; debug("Starting SDRAM initialization...\n"); @@ -1138,9 +1139,10 @@ static int sdram_init(struct dram_info *dram, if (channel >= params->base.num_channels) continue; - if (pctl_cfg(chan, channel, params) != 0) { - printf("pctl_cfg fail, reset\n"); - return -EIO; + ret = pctl_cfg(chan, channel, params); + if (ret < 0) { + printf("%s: pctl config failed\n", __func__); + return ret; } /* LPDDR2/LPDDR3 need to wait DAI complete, max 10us */