From patchwork Mon Jun 17 07:31:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 605 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 6DD673F353 for ; Mon, 17 Jun 2019 09:38:16 +0200 (CEST) Received: by mail-pl1-f199.google.com with SMTP id i33sf5512934pld.15 for ; Mon, 17 Jun 2019 00:38:16 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1560757095; cv=pass; d=google.com; s=arc-20160816; b=hOdkjJcne/6jjN7OfeUkxqoBF8aGftRnu6jII0VuvvgWkYzeVfxl4w9xDseQGUKUG5 G4tRov4K39RW3t5zKJwp2OjDY4NC+u5WR29iv5DOhOM9OwvOvAzaJ+jOvxanz+0fkObC LSbL9ArYFKwftqh/kRywLN2ArcG52EWxpslhVU/wPNb9wez8GyQ9yZFPRP51MC2qfOCg kfD29z/bMvUHtccv3Hs68zB5Emo755eWEoOXTxsEQ6a4VcXsbHjS4eryzZBYTH2J+Bww Y+v+Up22ZWBLHtGLMP80B9WccobbiN8NQYicReSHZuAPLy0gafHS1+QM7pklIW2wJF1r bWeQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=OhXtzAHCO6flHUS+8oqNWLv/tDCkFDXBpUjP0WZKSJs=; b=s2a0znLIoIFtsLP097GK4shfr/uj0IqdraUmbgK8jRa6ydHZlub7brQEa2S0lPwIn8 XIIf6BzKSemaSXQBMlHRoe93dJNt9OpvTQACmyBLlnw+rnWrYAiBBHVYUAQNQeaq/CIX 04UIUZy4HfVGlIVxWeoC//sEbAbjRbY9ERMLnHxJpx7JtdUQZqlGnJUNBpYopSeI6zmv ngOsPuLGLv1CEqg4omQ01ka6WrOXeBOx7oOnvLkcoGJfc+JbTnKWJzt0PJ5eFNeHvlkw 1h/ry1GbVhMEkLzdqk7WWc5K6uJ8ObVMT39yBm8cyjC95r8m530vnFe2cobWwYVsShvo ebKw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=aQzvRKeb; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=OhXtzAHCO6flHUS+8oqNWLv/tDCkFDXBpUjP0WZKSJs=; b=rkdjHhKUYj1BA+ExJ75XepLm+Cd5+oI6ZSNn8mflYLJZyPR4dR+VnO1Xdfy6vB4qMd g9R+NqN4gaW3f1e2eRwQ3BNU8bLa1c3PmnEKMrF7lvJO7eqVHTpr8uTlYoru0AwIhfIc GnCXwAOkemrty+zuZbbHZfiS1QDSNwijfmaSs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=OhXtzAHCO6flHUS+8oqNWLv/tDCkFDXBpUjP0WZKSJs=; b=bOt32MYEDh3HlFr8bjx7YsgxYaAIfljFNJZUiobVsz5QL+14r27m7qRR9k3rONHzZe /iO+PfJuTBdhSafnW5IGmBbBcIXngJ3BJxDBFKWtmcSiPJGFC1+pY+spSoeMZS6LfNdy ipNYYG4BLddAVVRT7vXZFHq1og7rs0MhfKPjswInfl3afdkX9cKXPrrL7/7VNraf9IuW xnU6f7eg8XEkyBeykT3nhQoHqsa2Szh7evsFQUaFQcAe0ufYpSDxGVv9xWebuDh2QFud n/J05VyTowgDAAlyJh3AmFgAaq6Q8OOPpPJmnKcPy5LvjbRY07Ebk4wlGv9qpmXK6qG/ Glkw== X-Gm-Message-State: APjAAAW2DEMR3zN1LTe/Pd66Lby76p0xIEZxfVD7vGvgDLtpOy56Dour 6KVVOSbwHnD/KntYLIc07Q+t/hfp X-Google-Smtp-Source: APXvYqyTU3TynAZOUH9IxKHQCvh1gER1IOArpbsu2d6Ia00eb0Z9vJnTdk7wo8of0iF8YPJTiwgqUg== X-Received: by 2002:a17:902:2a69:: with SMTP id i96mr97587003plb.108.1560757095308; Mon, 17 Jun 2019 00:38:15 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:aa7:8056:: with SMTP id y22ls3372355pfm.6.gmail; Mon, 17 Jun 2019 00:38:15 -0700 (PDT) X-Received: by 2002:aa7:972a:: with SMTP id k10mr79250529pfg.116.1560757095034; Mon, 17 Jun 2019 00:38:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560757095; cv=none; d=google.com; s=arc-20160816; b=r4xWwHb20YwPn3wT115gh8GN8vpadPxwegAwpOHj6VvVHdjESsG9EPev1ywSYZ8WNN Jm7SJEUSkFb4VZefyh9uKz/khlTpNt/p3XPRpCzLqIMF2V9b+Wfy2AefWi4Pory66iWj QxSWVIdUOV3uuuV5LJEqUDNdCRPctNTxmvvVQDgPBEpdTohUKrR481WRbmWMBjaYXkwq RiQfYZ1uZiVrhQhwd2Ohs47BtJfYIs6Vnhrs1LTfrxSjJqJerSOl9Eybs9+N8mTemN30 fqESG1Iv5Yqo7lhx5Qtf6LD7s2naoRAWSIBy5Efwkw8C28QEzZr4diXoEzScxpj93648 6bWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=ghxhPBWP5O1a4V7OzoOwioqRRw5KZIUMBpByPZdUPk8=; b=eksJNc+owtw0hS/IKMgwETNvQgW3xrgFKAILPQYXml++1gC+CAbaQVahwrAQ8Gc3vX 9sLYYJz7rZ0Nma/3F63ds5QZgkUKl+sJ6jgRrF80rzwNAtWGcGUOJdzu5/8vDBq3SgmZ 00w5kBIxfI18+zqaWgUxPaPYLQnu7MU4RVO0I6n3FfnnuvQj8nZS1rr6KSQOUqdGZLnN tvPRU1Rx94aAKzsZzhcbSrU22n7aEmgH2/0yoLGCLyrlUX5M4D7crq5MINR0SG1pokDK 4zLipkKA6wxRgfBFo/Se5bn7nsvTFLUpSBH5vPmfyiuhR1LBHtTTT1dYyTJb9kHlbVRn 7FzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=aQzvRKeb; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id v185sor5342266pgv.10.2019.06.17.00.38.15 for (Google Transport Security); Mon, 17 Jun 2019 00:38:15 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; X-Received: by 2002:a65:404a:: with SMTP id h10mr6117657pgp.262.1560757094670; Mon, 17 Jun 2019 00:38:14 -0700 (PDT) Received: from localhost.localdomain ([49.206.203.245]) by smtp.gmail.com with ESMTPSA id m41sm15205998pje.18.2019.06.17.00.38.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2019 00:38:14 -0700 (PDT) From: Jagan Teki To: Simon Glass , Philipp Tomsich , Kever Yang , YouMin Chen , u-boot@lists.denx.de Cc: Manivannan Sadhasivam , gajjar04akash@gmail.com, linux-rockchip@lists.infradead.org, linux-amarula@amarulasolutions.com, Jagan Teki Subject: [PATCH v2 34/99] ram: rk3399: Order tsel variables Date: Mon, 17 Jun 2019 13:01:47 +0530 Message-Id: <20190617073252.27810-35-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20190617073252.27810-1-jagan@amarulasolutions.com> References: <20190617073252.27810-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=aQzvRKeb; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Order tsel* variable declarations and assignment in proper and meaningful way. No functionality change. Signed-off-by: Jagan Teki Signed-off-by: YouMin Chen --- drivers/ram/rockchip/sdram_rk3399.c | 37 +++++++++++++++++------------ 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c index 78010c707f..f81ea1bdbf 100644 --- a/drivers/ram/rockchip/sdram_rk3399.c +++ b/drivers/ram/rockchip/sdram_rk3399.c @@ -159,41 +159,48 @@ static void set_ds_odt(const struct chan_info *chan, u32 *denali_phy = chan->publ->denali_phy; u32 tsel_idle_en, tsel_wr_en, tsel_rd_en; - u32 tsel_idle_select_p, tsel_wr_select_dq_p, tsel_rd_select_p; - u32 tsel_wr_select_ca_p, tsel_wr_select_ca_n; - u32 tsel_idle_select_n, tsel_wr_select_dq_n, tsel_rd_select_n; + u32 tsel_idle_select_p, tsel_rd_select_p; + u32 tsel_idle_select_n, tsel_rd_select_n; + u32 tsel_wr_select_dq_p, tsel_wr_select_ca_p; + u32 tsel_wr_select_dq_n, tsel_wr_select_ca_n; u32 reg_value; if (params->base.dramtype == LPDDR4) { tsel_rd_select_p = PHY_DRV_ODT_HI_Z; - tsel_wr_select_dq_p = PHY_DRV_ODT_40; - tsel_wr_select_ca_p = PHY_DRV_ODT_40; + tsel_rd_select_n = PHY_DRV_ODT_240; + tsel_idle_select_p = PHY_DRV_ODT_HI_Z; + tsel_idle_select_n = PHY_DRV_ODT_240; - tsel_rd_select_n = PHY_DRV_ODT_240; + tsel_wr_select_dq_p = PHY_DRV_ODT_40; tsel_wr_select_dq_n = PHY_DRV_ODT_40; + + tsel_wr_select_ca_p = PHY_DRV_ODT_40; tsel_wr_select_ca_n = PHY_DRV_ODT_40; - tsel_idle_select_n = PHY_DRV_ODT_240; } else if (params->base.dramtype == LPDDR3) { tsel_rd_select_p = PHY_DRV_ODT_240; - tsel_wr_select_dq_p = PHY_DRV_ODT_34_3; - tsel_wr_select_ca_p = PHY_DRV_ODT_48; + tsel_rd_select_n = PHY_DRV_ODT_HI_Z; + tsel_idle_select_p = PHY_DRV_ODT_240; + tsel_idle_select_n = PHY_DRV_ODT_HI_Z; - tsel_rd_select_n = PHY_DRV_ODT_HI_Z; + tsel_wr_select_dq_p = PHY_DRV_ODT_34_3; tsel_wr_select_dq_n = PHY_DRV_ODT_34_3; + + tsel_wr_select_ca_p = PHY_DRV_ODT_48; tsel_wr_select_ca_n = PHY_DRV_ODT_48; - tsel_idle_select_n = PHY_DRV_ODT_HI_Z; } else { tsel_rd_select_p = PHY_DRV_ODT_240; - tsel_wr_select_dq_p = PHY_DRV_ODT_34_3; - tsel_wr_select_ca_p = PHY_DRV_ODT_34_3; + tsel_rd_select_n = PHY_DRV_ODT_240; + tsel_idle_select_p = PHY_DRV_ODT_240; + tsel_idle_select_n = PHY_DRV_ODT_240; - tsel_rd_select_n = PHY_DRV_ODT_240; + tsel_wr_select_dq_p = PHY_DRV_ODT_34_3; tsel_wr_select_dq_n = PHY_DRV_ODT_34_3; + + tsel_wr_select_ca_p = PHY_DRV_ODT_34_3; tsel_wr_select_ca_n = PHY_DRV_ODT_34_3; - tsel_idle_select_n = PHY_DRV_ODT_240; } if (params->base.odt == 1)