From patchwork Mon Jun 17 07:32:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 641 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 6B2E43F353 for ; Mon, 17 Jun 2019 09:40:15 +0200 (CEST) Received: by mail-pf1-f197.google.com with SMTP id y7sf6565388pfy.9 for ; Mon, 17 Jun 2019 00:40:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1560757214; cv=pass; d=google.com; s=arc-20160816; b=Mgw4fQTO+sb/I7cEKbXV20CIXYtlAsuaZCuEhaIAPwqp1V8lNqvBHuD3QyRKHk3lXD lYoCNS6mo059wS7EXMopXsFXrN5xpxn8CkH00WHV8m+irkArDcC3oLSNBfACMRkimQNS 58oLtKCNqRzHti0amznI0CS4xwNSoG+dm7usDc9T6JSZdIQpjbrAFJ+O06Rl2xU1GcMk +jHsCQsN+CxKVBD0GJrZp1zvhDFPPQ9wTnZ1/yPR4TjRbLgOEhdyFUv6lNof3FJnO/9j O8XRudYMhHqZhVOd+TZoypgmIR6kgVIbZMXqL1XpQPCUH+zu+94dpQChEyFixsDYQ8BC qS9Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=ucqsbQSR/qWzGDia8MaeSlWx6vDdv5BNtjWZ5CFi8IY=; b=0lYkfixswKn9kCjGwZvEBGJ7op5grUSUkHMfkZtjtDxS8788ChL9RYwkElf8yZWutv kWYoMo8xWh1VWJ/0ZgAx0uFgmXpQItuG7Kpwm4v5ICnw3f92AufjYqXMBOf9djkfw2n7 7nY8qEhBH3AoSIGeW0qZi1kbwYCAn5bfImjoOcfnQLW9UnCr57mLv3ykb6ckXAaOzrH6 JOFkw3kDYClFThttyFaxpk4j/RigoDuXC3dtRcE8odSxopMHSWfxJ+XpQjkbcGTc9TU2 sNiurWTgcS34YfIZ7RUdTGGHX70tlaLGlW/PZEK6m/QR+Ek6j0sJS5LC7ZHnSCLL5uAA ugKw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Ex7J857t; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=ucqsbQSR/qWzGDia8MaeSlWx6vDdv5BNtjWZ5CFi8IY=; b=b3R4RDY5Jq+KtcGJmXuhnLo19VHyeH8D5Um2nBhem9/bRrkoqzFcbB9demIJt69xbv 7a7ofsrig+MP57cpk/4xo40/yKe6EYwrpof2lvCQNEou2/MT9cSfrqW8S2JbzE8r9xnu WGDIwSEy4BrfzeBaxMNgHQbdXdR/gSGjxxsD4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=ucqsbQSR/qWzGDia8MaeSlWx6vDdv5BNtjWZ5CFi8IY=; b=lqH/OyZ9xu1mEq3IYsguGBeuNAVsFPGncFDIKWCAw03zCJW+X6juri1YQO79cv5yyK y63HBQ200GtIopL6QOUXMz5NoWSMSIvtm8ceFJhqjDq2/tYQSuoM+B20w0SnbvDgXczf XftBF3lwMfKvUy8zlQzKNwl6/YtfeZfAmSEKdMws6x7b79EFtOMsA5AZlGTeeB2WZdui i3oyXLQkVGJd31dCUfxiE5ltGkaxiWD4kwaBg0Bex18T/B5Y6Zoyj3HiodM06pElXPfa hdYcUY0fTXvBGNzlfkhCd8s9VsHDoqrgUdG0XPlNU/KmjohBW+Fu7VnsG3venCLVrazK zxqw== X-Gm-Message-State: APjAAAXutcOfFIn9EweJ/krUIwxv2u3NqKVtaKxHeFMq4lUvRCvNgnWu xbz9PAWb8aNHpkzo4rxUb2MtwbNh X-Google-Smtp-Source: APXvYqzHmqcj5N77yVxX7oD4X8HcEsBEk4tqJtsgf0RR0ZgAQjqRu4cG35VOmNHKn/FUFENlzWh8sA== X-Received: by 2002:aa7:8102:: with SMTP id b2mr86364209pfi.105.1560757214268; Mon, 17 Jun 2019 00:40:14 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:aa7:8115:: with SMTP id b21ls3368846pfi.12.gmail; Mon, 17 Jun 2019 00:40:14 -0700 (PDT) X-Received: by 2002:a63:e953:: with SMTP id q19mr31606422pgj.313.1560757213952; Mon, 17 Jun 2019 00:40:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560757213; cv=none; d=google.com; s=arc-20160816; b=dzYrvvVlZ1q942A6zmN2fKk4aUv3ElOWzdNlpIsKCpvvahEFc7OUMKrUL5h2ZwRGDy G/GFy5j3J+vJ9g0b3Wx4iklC16YT+5tyRVE7GKj+iOli/E56eFnrqWAUH/yut57waCWi 88QQgD3n1bf530JqMplBLVGmRgjESlSP2MMGsDELzBMRkp8SF2ZzXmV0OU+VO1cseb3x mL76TroNONFY7lxzwh0+K9wMkbZm9Z04mQsX46x/pr+akd3fZX3S8Zb/JiRPPBTRtEMB 5plzgZE+N/cu2IrzV99Ia2josStIG13BMbIUp+pbPjx0BoK/wbhcbzEzGXwV2nnHPfC1 5ytQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=IJlTrExUV036P/BMRgn4pTMf63sVmYGkjOW1YSSrKmc=; b=BPrLOx4xUOaI5rGJR/UdMQz6bP02hdl+RemyUlV6FC/CQCzgCnoVgimAw8z0BRql5c BCPwro39T9BPjP0/9D2Nnti3gtLoUrrzkW9HnAhojC95WCacb9JVx/RGZ/77xIk0NQre yQwVyqkCvmiU/5zw3s5gS8d8XW6xObgl3C927H5iYX4oqvHDo1I1ZI1/UYtSKRMPeNa+ N48g4bSZZaHLpsRH+aoOm4r1oChQZiBZ1KmtAhh0S6OdDg+tOYt4K16jtc2JvKyn8QZ8 WpiP3QJ7JrmPtXzvRf7B3dApv2lQwVNf+k7Qc13MqwtjHim68TiYODq3qgtUaYjTM+bz /7dA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Ex7J857t; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id g95sor12566545plb.67.2019.06.17.00.40.13 for (Google Transport Security); Mon, 17 Jun 2019 00:40:13 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; X-Received: by 2002:a17:902:f216:: with SMTP id gn22mr88263731plb.118.1560757213677; Mon, 17 Jun 2019 00:40:13 -0700 (PDT) Received: from localhost.localdomain ([49.206.203.245]) by smtp.gmail.com with ESMTPSA id m41sm15205998pje.18.2019.06.17.00.40.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2019 00:40:13 -0700 (PDT) From: Jagan Teki To: Simon Glass , Philipp Tomsich , Kever Yang , YouMin Chen , u-boot@lists.denx.de Cc: Manivannan Sadhasivam , gajjar04akash@gmail.com, linux-rockchip@lists.infradead.org, linux-amarula@amarulasolutions.com, Jagan Teki Subject: [PATCH v2 70/99] ram: rk3399: Configure tsel write ca for lpddr4 Date: Mon, 17 Jun 2019 13:02:23 +0530 Message-Id: <20190617073252.27810-71-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20190617073252.27810-1-jagan@amarulasolutions.com> References: <20190617073252.27810-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Ex7J857t; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , tsel write ca_p and ca_n values need to write on PHY 544, 672 and 800 to configure ds odt. Configure the same PHY register for lpddr4 would require a mask value of (300 << 8). Add support for it. Signed-off-by: Jagan Teki Signed-off-by: YouMin Chen --- drivers/ram/rockchip/sdram_rk3399.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c index e03181fbc9..41dd19a9e6 100644 --- a/drivers/ram/rockchip/sdram_rk3399.c +++ b/drivers/ram/rockchip/sdram_rk3399.c @@ -502,9 +502,18 @@ static void set_ds_odt(const struct chan_info *chan, /* phy_adr_tsel_select_ 8bits DENALI_PHY_544/672/800 offset_0 */ reg_value = tsel_wr_select_ca_n | (tsel_wr_select_ca_p << 0x4); - clrsetbits_le32(&denali_phy[544], 0xff, reg_value); - clrsetbits_le32(&denali_phy[672], 0xff, reg_value); - clrsetbits_le32(&denali_phy[800], 0xff, reg_value); + if (IS_ENABLED(CONFIG_RAM_RK3399_LPDDR4)) { + /* LPDDR4 these register read always return 0, so + * can not use clrsetbits_le32(), need to write32 + */ + writel((0x300 << 8) | reg_value, &denali_phy[544]); + writel((0x300 << 8) | reg_value, &denali_phy[672]); + writel((0x300 << 8) | reg_value, &denali_phy[800]); + } else { + clrsetbits_le32(&denali_phy[544], 0xff, reg_value); + clrsetbits_le32(&denali_phy[672], 0xff, reg_value); + clrsetbits_le32(&denali_phy[800], 0xff, reg_value); + } /* phy_pad_addr_drive 8bits DENALI_PHY_928 offset_0 */ clrsetbits_le32(&denali_phy[928], 0xff, reg_value);