From patchwork Mon Jun 17 07:32:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 642 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id A52AB3F353 for ; Mon, 17 Jun 2019 09:40:18 +0200 (CEST) Received: by mail-pf1-f197.google.com with SMTP id z1sf6563115pfb.7 for ; Mon, 17 Jun 2019 00:40:18 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1560757217; cv=pass; d=google.com; s=arc-20160816; b=Q7iCxcOWD6bnhqlQTDJFGLJPz2p0sSUKjpt5p6oLDM0vnqzqo/mFOH/tUcfGZLfQ/P jYZJNGArlThO6sGOILYyK9J/XNbIzd5XYzSUPJucNqG2WMB4ItPKpX8PQOtgWa6bImc/ XHkzs3V3u/PoxpIsQfNZ+WlNQtJ4LDrAaGclF5slQOkn8GYuEarsFUD3cn377WXy0qBo E4Scj9LZxo6vc4DqxpH55ZVln6vCCyfwaH1MFV5mASD0Izk6QOkFxMQpPBxHYhKcJmoS ca7pjpWvwHbFXtdfUy0he/3sswZ2kOOroqamfHXT7v3zfwM1uTEaAwRzbkuFpdxSNUOo 2VYQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=vjFp8iw18d2RDfr1qr0ivZFN8yZjfsFz2vS//p4pF0M=; b=LvDlVpv7+UTU+gBFBwN5YIVQgMZARZCoZCG69zLSt96qIcgngIUdBgPEOdHuuu91IU aoTEcrRVKah1qmESPMIi0k3fNr/n4SPJufz8O3uUFOQepM+kQ+eioxlm7R8YUyyxRN0o VdSoujNdE2AQVf/pcwPvBqzQe7FRhc4uocyIL0yRUF908phqI3j7DNrp1p7r5m6CMcfp Y/JMjXkiZTfHOHj+V4IOZicDSu8DFWvPCovOHfaBVGfw2ffXtTMi9ewAdjVBwCOBNkPG 0DS2ld4kM/JU2jC85rykGnEvNHnh/uRgnH/TVWPFhzGzyAn2cjtI4pZyVlljxKyl0I91 7FQQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=JjGc2KIq; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=vjFp8iw18d2RDfr1qr0ivZFN8yZjfsFz2vS//p4pF0M=; b=LVUk8F7pYmO/TZtlTz/8fzc+CCBI6gmEPubKlXyST9JLSP/VlBCCMPBy/vg311CmW4 ErrAvovbV34a883+0UF69TyISB9QhuCrX+xMKXYhwdsOQG9FFGh+ExPO3LSh+tMT4Wys +TSqWsqXQAPs3a8qeXdUIFo3iDzIn/ybhWlTY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=vjFp8iw18d2RDfr1qr0ivZFN8yZjfsFz2vS//p4pF0M=; b=UGo4Q+2OUDAJIwFadOU/zL1B+JJrHv/GdxEqPdszwnfPOfJ992pnV2AK2mJBKFXa3d 20ZlMDX8ugjpily2ZiOrWSk7jarHQLhmoAmmoORqWTgIwqSKfPunWTbn1Ci6AnidP+Ig YGxPuHuwg4FN+0JR0+RzxG9+64n3qbmReZ855INFe4a5PwB+R8CFy+yhlATGlMdj6teq 3MhpI3N4nxoD2bAmjNh//6OocnSVkC8ZVQN5PQ4zt5ZXP+KOkiu/RWkHfuKpGoWMh2li AfQFn7qJFyCWsYhY7xK75KS3BiHJBzm9laYvgZUEAjiwm0ZXP036LhPtyRMrmWkmOotr rjTw== X-Gm-Message-State: APjAAAWRi++76lX3XVqLyFKwbDFHN2rWNDFqIvBwtEjbdHFGGFbo87qn 4BiOOo/lUbXBhhaMs05OFGbnCGDC X-Google-Smtp-Source: APXvYqzkzaO906uLyszAQ0t4fg51ALTRcBANnEWWij1MFq/oFtxbMj6a0PKOsjJodkIpnp29vzuh0g== X-Received: by 2002:a17:90a:ad41:: with SMTP id w1mr24590935pjv.52.1560757217533; Mon, 17 Jun 2019 00:40:17 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:90a:9301:: with SMTP id p1ls3980066pjo.3.canary-gmail; Mon, 17 Jun 2019 00:40:17 -0700 (PDT) X-Received: by 2002:a17:902:b115:: with SMTP id q21mr45766409plr.36.1560757217205; Mon, 17 Jun 2019 00:40:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560757217; cv=none; d=google.com; s=arc-20160816; b=clWUdSxzNE46giPg8LZ8BLZe+ZvEwNQZ9sndueyg3nt9usCY5zGkoQpx97CuV4myUc mqH4caaOFOq+FGAhoyl03YB8OJ7K30ikeN9bne6/xVDHuRg4Mhz5gf6odvlA7b2p7Z8G H02yTHC7P+HNIxxN1n/Vi04HmOJDTcbE8FPvrZsaN0hR38hAVxSqAcnJ3HNfXGtuuM9w 7Rk/FDjc+jo38yS13bVR4GsTqB2L55XStxFM2k5NXUN59D4A/ap9XZb/SJwOXNEsQ2Wl BxvkrrwmqRMsI56opxyIvuai3cZQS1+4yI4oy7Vh5bUMKa68yUjO+AtBs7aMUfc7UOK+ u3BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=Lvq7XoR1Ix45f8hq3+WTfHQFFNcm7BVHJc5pM7f8ftQ=; b=rz422jMLC8HPar/RGrdLMpgUWvHZ9t0z85IcUKPRSu7fo1FYUMNuOMWv5/HWXt1qxz fX5Vx5bzZs0k9QBbClnAXML7m1psjlgAP5ISZZh0I+XZqXuE/yjEN0bWepcTREnmKdJR 8bigEMwaIEG+J1yrDg+/aTfQiViIjpQyPnY0GvBmzMxzc/jbUEiHWhTQyu1etD0Kl5iF j7+YcCwDMds9U3VBUMvzcwI8hrjVDWp9cNKXkwcIOaBSeL/uTCRwg5V/NdwHWEfAEaBy UCBMrq3jBGkB6Ped9aZlQa10bchsiytIvyGXxCR+KVyzbhBXT2J3hih4R3bEKJTL0fyJ pGJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=JjGc2KIq; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id a13sor12301631pjh.1.2019.06.17.00.40.17 for (Google Transport Security); Mon, 17 Jun 2019 00:40:17 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; X-Received: by 2002:a17:90a:d151:: with SMTP id t17mr24712621pjw.60.1560757216913; Mon, 17 Jun 2019 00:40:16 -0700 (PDT) Received: from localhost.localdomain ([49.206.203.245]) by smtp.gmail.com with ESMTPSA id m41sm15205998pje.18.2019.06.17.00.40.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2019 00:40:16 -0700 (PDT) From: Jagan Teki To: Simon Glass , Philipp Tomsich , Kever Yang , YouMin Chen , u-boot@lists.denx.de Cc: Manivannan Sadhasivam , gajjar04akash@gmail.com, linux-rockchip@lists.infradead.org, linux-amarula@amarulasolutions.com, Jagan Teki Subject: [PATCH v2 71/99] ram: rk3399: Don't disable dfi dram clk for lpddr4, rank 1 Date: Mon, 17 Jun 2019 13:02:24 +0530 Message-Id: <20190617073252.27810-72-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20190617073252.27810-1-jagan@amarulasolutions.com> References: <20190617073252.27810-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=JjGc2KIq; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The hardware for LPDDR4 with - CLK0P/N connect to lower 16-bits - CLK1P/N connect to higher 16-bits and usually dfi dram clk is configured via CLK1P/N, so disabling dfi dram clk will disable the CLK1P/N as well. So, add patch to not to disable dfi dram clk for lpddr4, with rank 1. Signed-off-by: Jagan Teki Signed-off-by: YouMin Chen --- drivers/ram/rockchip/sdram_rk3399.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c index 41dd19a9e6..d1b3aeef47 100644 --- a/drivers/ram/rockchip/sdram_rk3399.c +++ b/drivers/ram/rockchip/sdram_rk3399.c @@ -1226,8 +1226,18 @@ static void dram_all_config(struct dram_info *dram, writel(noc_timing->ddrmode.d32, &ddr_msch_regs->ddrmode); - /* rank 1 memory clock disable (dfi_dram_clk_disable = 1) */ - if (params->ch[channel].cap_info.rank == 1) + /** + * rank 1 memory clock disable (dfi_dram_clk_disable = 1) + * + * The hardware for LPDDR4 with + * - CLK0P/N connect to lower 16-bits + * - CLK1P/N connect to higher 16-bits + * + * dfi dram clk is configured via CLK1P/N, so disabling + * dfi dram clk will disable the CLK1P/N as well for lpddr4. + */ + if (params->ch[channel].cap_info.rank == 1 && + params->base.dramtype != LPDDR4) setbits_le32(&dram->chan[channel].pctl->denali_ctl[276], 1 << 17); }