[v3,21/57] ram: rk3399: Add lpddr4 rank mask for ca training
diff mbox series

Message ID 20190716115745.12585-22-jagan@amarulasolutions.com
State New
Headers show
Series
  • ram: rk3399: Add LPDDR4 support
Related show

Commit Message

Jagan Teki July 16, 2019, 11:57 a.m. UTC 
Add rank_mask based on the rank number for lpddr4.

This would keep the ca data training loop based on the
desired rank mask value instead of looping for all values.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Signed-off-by: YouMin Chen <cym@rock-chips.com>
---
 drivers/ram/rockchip/sdram_rk3399.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Kever Yang July 16, 2019, 1:11 p.m. UTC | #1 
On 2019/7/16 下午7:57, Jagan Teki wrote:
> Add rank_mask based on the rank number for lpddr4.
>
> This would keep the ca data training loop based on the
> desired rank mask value instead of looping for all values.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> Signed-off-by: YouMin Chen <cym@rock-chips.com>

Reviewed-by: Kever Yang <Kever.yang@rock-chips.com>

Thanks,
  - Kever
> ---
>   drivers/ram/rockchip/sdram_rk3399.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c
> index a49677285d..8ecc3a1b74 100644
> --- a/drivers/ram/rockchip/sdram_rk3399.c
> +++ b/drivers/ram/rockchip/sdram_rk3399.c
> @@ -687,7 +687,10 @@ static int data_training_ca(const struct chan_info *chan, u32 channel,
>   	/* clear interrupt,PI_175 PI_INT_ACK:WR:0:17 */
>   	writel(0x00003f7c, (&denali_pi[175]));
>   
> -	rank_mask = (rank == 1) ? 0x1 : 0x3;
> +	if (params->base.dramtype == LPDDR4)
> +		rank_mask = (rank == 1) ? 0x5 : 0xf;
> +	else
> +		rank_mask = (rank == 1) ? 0x1 : 0x3;
>   
>   	for (i = 0; i < 4; i++) {
>   		if (!(rank_mask & (1 << i)))

Patch
diff mbox series 

diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c
index a49677285d..8ecc3a1b74 100644
--- a/drivers/ram/rockchip/sdram_rk3399.c
+++ b/drivers/ram/rockchip/sdram_rk3399.c
@@ -687,7 +687,10 @@  static int data_training_ca(const struct chan_info *chan, u32 channel,
 	/* clear interrupt,PI_175 PI_INT_ACK:WR:0:17 */
 	writel(0x00003f7c, (&denali_pi[175]));
 
-	rank_mask = (rank == 1) ? 0x1 : 0x3;
+	if (params->base.dramtype == LPDDR4)
+		rank_mask = (rank == 1) ? 0x5 : 0xf;
+	else
+		rank_mask = (rank == 1) ? 0x1 : 0x3;
 
 	for (i = 0; i < 4; i++) {
 		if (!(rank_mask & (1 << i)))