[4/5] ARM: dts: rockchip: Add Radxa Carrier board

Message ID 20191120113923.11685-5-jagan@amarulasolutions.com
State New
Headers show
Series
  • arm64: dts: rockchip: Add Rock Pi N10 support
Related show

Commit Message

Jagan Teki Nov. 20, 2019, 11:39 a.m. UTC
Carrier board often referred as baseboard. For making
complete SBC, the associated SOM will mount on top of
this carrier board.

Radxa has a carrier board which supports on board
peripherals, ports like USB-2.0, USB-3.0, HDMI, MIPI DSI/CSI,
eDP, Ethernet, PCIe, USB-C, 40-Pin GPIO header and etc.

Currently this carrier board can be used together with
VMARC RK3399Por SOM for making Rock PI N10 SBC.

So add this carrier board dtsi as a separate file in
ARM directory, so-that the same can reuse it in both
arm32 and arm64 variants of Rockchip SOMs.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 .../boot/dts/rockchip-radxa-carrierboard.dtsi | 81 +++++++++++++++++++
 1 file changed, 81 insertions(+)
 create mode 100644 arch/arm/boot/dts/rockchip-radxa-carrierboard.dtsi

Comments

Heiko Stuebner Nov. 20, 2019, 1:25 p.m. UTC | #1
Hi Jagan,

Am Mittwoch, 20. November 2019, 12:39:22 CET schrieb Jagan Teki:
> Carrier board often referred as baseboard. For making
> complete SBC, the associated SOM will mount on top of
> this carrier board.
> 
> Radxa has a carrier board which supports on board
> peripherals, ports like USB-2.0, USB-3.0, HDMI, MIPI DSI/CSI,
> eDP, Ethernet, PCIe, USB-C, 40-Pin GPIO header and etc.
> 
> Currently this carrier board can be used together with
> VMARC RK3399Por SOM for making Rock PI N10 SBC.
> 
> So add this carrier board dtsi as a separate file in
> ARM directory, so-that the same can reuse it in both
> arm32 and arm64 variants of Rockchip SOMs.

Do you really think someone will create an arm32 soc using that
carrier board?

Similarly so far I don't think we haven't even seen a lot of reuse
of existing carrier boards at all, other than their initial combination.

So maybe just having the content of your
	rockchip-radxa-carrierboard.dtsi
in
	rockchip/rk3399pro-rock-pi-n10.dts
from patch 5 might be a better start - at least until there is any
further usage - if at all?

Also rockchip-radxa-carrierboard might even be overly generic
as there may be multiple carrierboards from Radxa later on.

Heiko


> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>  .../boot/dts/rockchip-radxa-carrierboard.dtsi | 81 +++++++++++++++++++
>  1 file changed, 81 insertions(+)
>  create mode 100644 arch/arm/boot/dts/rockchip-radxa-carrierboard.dtsi
> 
> diff --git a/arch/arm/boot/dts/rockchip-radxa-carrierboard.dtsi b/arch/arm/boot/dts/rockchip-radxa-carrierboard.dtsi
> new file mode 100644
> index 000000000000..df3712aedf8a
> --- /dev/null
> +++ b/arch/arm/boot/dts/rockchip-radxa-carrierboard.dtsi
> @@ -0,0 +1,81 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2019 Fuzhou Rockchip Electronics Co., Ltd
> + * Copyright (c) 2019 Radxa Limited
> + * Copyright (c) 2019 Amarula Solutions(India)
> + */
> +
> +#include <dt-bindings/pwm/pwm.h>
> +
> +/ {
> +	chosen {
> +		stdout-path = "serial2:1500000n8";
> +	};
> +};
> +
> +&gmac {
> +	status = "okay";
> +};
> +
> +&i2c1 {
> +	status = "okay";
> +	i2c-scl-rising-time-ns = <140>;
> +	i2c-scl-falling-time-ns = <30>;
> +};
> +
> +&i2c2 {
> +	status = "okay";
> +	clock-frequency = <400000>;
> +
> +	hym8563: hym8563@51 {
> +		compatible = "haoyu,hym8563";
> +		reg = <0x51>;
> +		#clock-cells = <0>;
> +		clock-frequency = <32768>;
> +		clock-output-names = "hym8563";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&hym8563_int>;
> +		interrupt-parent = <&gpio4>;
> +		interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
> +	};
> +};
> +
> +&pwm0 {
> +	status = "okay";
> +};
> +
> +&pwm2 {
> +	status = "okay";
> +};
> +
> +&sdmmc {
> +	bus-width = <4>;
> +	cap-mmc-highspeed;
> +	cap-sd-highspeed;
> +	cd-gpios = <&gpio0 RK_PA7 GPIO_ACTIVE_LOW>;
> +	disable-wp;
> +	vqmmc-supply = <&vccio_sd>;
> +	max-frequency = <150000000>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>;
> +	status = "okay";
> +};
> +
> +&uart0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&uart0_xfer &uart0_cts>;
> +	status = "okay";
> +};
> +
> +&uart2 {
> +	status = "okay";
> +};
> +
> +&pinctrl {
> +	hym8563 {
> +		hym8563_int: hym8563-int {
> +			rockchip,pins =
> +				<4 RK_PD6 0 &pcfg_pull_up>;
> +		};
> +	};
> +};
>
Jagan Teki Nov. 20, 2019, 1:45 p.m. UTC | #2
Hi Heiko,

On Wed, Nov 20, 2019 at 6:55 PM Heiko Stübner <heiko@sntech.de> wrote:
>
> Hi Jagan,
>
> Am Mittwoch, 20. November 2019, 12:39:22 CET schrieb Jagan Teki:
> > Carrier board often referred as baseboard. For making
> > complete SBC, the associated SOM will mount on top of
> > this carrier board.
> >
> > Radxa has a carrier board which supports on board
> > peripherals, ports like USB-2.0, USB-3.0, HDMI, MIPI DSI/CSI,
> > eDP, Ethernet, PCIe, USB-C, 40-Pin GPIO header and etc.
> >
> > Currently this carrier board can be used together with
> > VMARC RK3399Por SOM for making Rock PI N10 SBC.
> >
> > So add this carrier board dtsi as a separate file in
> > ARM directory, so-that the same can reuse it in both
> > arm32 and arm64 variants of Rockchip SOMs.
>
> Do you really think someone will create an arm32 soc using that
> carrier board?

Yes, we have Rock Pi N8 which is using same carrier board design with
(+ external codec) on top of RK3288 SOM. I didn't mentioned on the
commit message since radxa doesn't officially announced on the
website.

>
> Similarly so far I don't think we haven't even seen a lot of reuse
> of existing carrier boards at all, other than their initial combination.
>
> So maybe just having the content of your
>         rockchip-radxa-carrierboard.dtsi
> in
>         rockchip/rk3399pro-rock-pi-n10.dts
> from patch 5 might be a better start - at least until there is any
> further usage - if at all?

But, this particular design has proper use case.
1. rk3399pro SOM + carrier board (Rock Pi N10)
2. rk3288 SOM + carrier board (Rock Pi N8)

>
> Also rockchip-radxa-carrierboard might even be overly generic
> as there may be multiple carrierboards from Radxa later on.

I'm slightly disagree of having overlay here, since these are fixed
design combinations. where SOM with respective carrier board is
mandatory to make final board. Understand that we can have a
maintenance over-ahead if we have multiple carrier boards, but right
now radxa has only one carrier board with 2 sets of SOM's combinations
that indeed fit like a dev board, so there is unused carrier board.

Jagan.
Heiko Stuebner Nov. 20, 2019, 1:53 p.m. UTC | #3
Hi Jagan,

Am Mittwoch, 20. November 2019, 14:45:35 CET schrieb Jagan Teki:
> On Wed, Nov 20, 2019 at 6:55 PM Heiko Stübner <heiko@sntech.de> wrote:
> > Am Mittwoch, 20. November 2019, 12:39:22 CET schrieb Jagan Teki:
> > > Carrier board often referred as baseboard. For making
> > > complete SBC, the associated SOM will mount on top of
> > > this carrier board.
> > >
> > > Radxa has a carrier board which supports on board
> > > peripherals, ports like USB-2.0, USB-3.0, HDMI, MIPI DSI/CSI,
> > > eDP, Ethernet, PCIe, USB-C, 40-Pin GPIO header and etc.
> > >
> > > Currently this carrier board can be used together with
> > > VMARC RK3399Por SOM for making Rock PI N10 SBC.
> > >
> > > So add this carrier board dtsi as a separate file in
> > > ARM directory, so-that the same can reuse it in both
> > > arm32 and arm64 variants of Rockchip SOMs.
> >
> > Do you really think someone will create an arm32 soc using that
> > carrier board?
> 
> Yes, we have Rock Pi N8 which is using same carrier board design with
> (+ external codec) on top of RK3288 SOM. I didn't mentioned on the
> commit message since radxa doesn't officially announced on the
> website.
> 
> >
> > Similarly so far I don't think we haven't even seen a lot of reuse
> > of existing carrier boards at all, other than their initial combination.
> >
> > So maybe just having the content of your
> >         rockchip-radxa-carrierboard.dtsi
> > in
> >         rockchip/rk3399pro-rock-pi-n10.dts
> > from patch 5 might be a better start - at least until there is any
> > further usage - if at all?
> 
> But, this particular design has proper use case.
> 1. rk3399pro SOM + carrier board (Rock Pi N10)
> 2. rk3288 SOM + carrier board (Rock Pi N8)
> 
> >
> > Also rockchip-radxa-carrierboard might even be overly generic
> > as there may be multiple carrierboards from Radxa later on.
> 
> I'm slightly disagree of having overlay here, since these are fixed
> design combinations. where SOM with respective carrier board is
> mandatory to make final board. Understand that we can have a
> maintenance over-ahead if we have multiple carrier boards, but right
> now radxa has only one carrier board with 2 sets of SOM's combinations
> that indeed fit like a dev board, so there is unused carrier board.

All is good ... with that information from above (rk3288) this definitly
makes more sense :-)

The naming of the file is still a tiny struggle though. Does this board
maybe have some actual product name or is it really just called
"carrierboard"? :-)

Thanks
Heiko
Jagan Teki Nov. 20, 2019, 3:33 p.m. UTC | #4
Hi Heiko,

On Wed, Nov 20, 2019 at 7:23 PM Heiko Stübner <heiko@sntech.de> wrote:
>
> Hi Jagan,
>
> Am Mittwoch, 20. November 2019, 14:45:35 CET schrieb Jagan Teki:
> > On Wed, Nov 20, 2019 at 6:55 PM Heiko Stübner <heiko@sntech.de> wrote:
> > > Am Mittwoch, 20. November 2019, 12:39:22 CET schrieb Jagan Teki:
> > > > Carrier board often referred as baseboard. For making
> > > > complete SBC, the associated SOM will mount on top of
> > > > this carrier board.
> > > >
> > > > Radxa has a carrier board which supports on board
> > > > peripherals, ports like USB-2.0, USB-3.0, HDMI, MIPI DSI/CSI,
> > > > eDP, Ethernet, PCIe, USB-C, 40-Pin GPIO header and etc.
> > > >
> > > > Currently this carrier board can be used together with
> > > > VMARC RK3399Por SOM for making Rock PI N10 SBC.
> > > >
> > > > So add this carrier board dtsi as a separate file in
> > > > ARM directory, so-that the same can reuse it in both
> > > > arm32 and arm64 variants of Rockchip SOMs.
> > >
> > > Do you really think someone will create an arm32 soc using that
> > > carrier board?
> >
> > Yes, we have Rock Pi N8 which is using same carrier board design with
> > (+ external codec) on top of RK3288 SOM. I didn't mentioned on the
> > commit message since radxa doesn't officially announced on the
> > website.
> >
> > >
> > > Similarly so far I don't think we haven't even seen a lot of reuse
> > > of existing carrier boards at all, other than their initial combination.
> > >
> > > So maybe just having the content of your
> > >         rockchip-radxa-carrierboard.dtsi
> > > in
> > >         rockchip/rk3399pro-rock-pi-n10.dts
> > > from patch 5 might be a better start - at least until there is any
> > > further usage - if at all?
> >
> > But, this particular design has proper use case.
> > 1. rk3399pro SOM + carrier board (Rock Pi N10)
> > 2. rk3288 SOM + carrier board (Rock Pi N8)
> >
> > >
> > > Also rockchip-radxa-carrierboard might even be overly generic
> > > as there may be multiple carrierboards from Radxa later on.
> >
> > I'm slightly disagree of having overlay here, since these are fixed
> > design combinations. where SOM with respective carrier board is
> > mandatory to make final board. Understand that we can have a
> > maintenance over-ahead if we have multiple carrier boards, but right
> > now radxa has only one carrier board with 2 sets of SOM's combinations
> > that indeed fit like a dev board, so there is unused carrier board.
>
> All is good ... with that information from above (rk3288) this definitly
> makes more sense :-)
>
> The naming of the file is still a tiny struggle though. Does this board
> maybe have some actual product name or is it really just called
> "carrierboard"? :-)

True, I felt the same. Just now Tom has named this as 'Dalang Carrier
board' so we can have rockchip-radxa-dalang.dtsi or
rockchip-radxa-dalang-carrier.dtsi as file names. or let me know if
you have any suggestions on the file name?

Jagan.

Patch

diff --git a/arch/arm/boot/dts/rockchip-radxa-carrierboard.dtsi b/arch/arm/boot/dts/rockchip-radxa-carrierboard.dtsi
new file mode 100644
index 000000000000..df3712aedf8a
--- /dev/null
+++ b/arch/arm/boot/dts/rockchip-radxa-carrierboard.dtsi
@@ -0,0 +1,81 @@ 
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2019 Fuzhou Rockchip Electronics Co., Ltd
+ * Copyright (c) 2019 Radxa Limited
+ * Copyright (c) 2019 Amarula Solutions(India)
+ */
+
+#include <dt-bindings/pwm/pwm.h>
+
+/ {
+	chosen {
+		stdout-path = "serial2:1500000n8";
+	};
+};
+
+&gmac {
+	status = "okay";
+};
+
+&i2c1 {
+	status = "okay";
+	i2c-scl-rising-time-ns = <140>;
+	i2c-scl-falling-time-ns = <30>;
+};
+
+&i2c2 {
+	status = "okay";
+	clock-frequency = <400000>;
+
+	hym8563: hym8563@51 {
+		compatible = "haoyu,hym8563";
+		reg = <0x51>;
+		#clock-cells = <0>;
+		clock-frequency = <32768>;
+		clock-output-names = "hym8563";
+		pinctrl-names = "default";
+		pinctrl-0 = <&hym8563_int>;
+		interrupt-parent = <&gpio4>;
+		interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
+	};
+};
+
+&pwm0 {
+	status = "okay";
+};
+
+&pwm2 {
+	status = "okay";
+};
+
+&sdmmc {
+	bus-width = <4>;
+	cap-mmc-highspeed;
+	cap-sd-highspeed;
+	cd-gpios = <&gpio0 RK_PA7 GPIO_ACTIVE_LOW>;
+	disable-wp;
+	vqmmc-supply = <&vccio_sd>;
+	max-frequency = <150000000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>;
+	status = "okay";
+};
+
+&uart0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&uart0_xfer &uart0_cts>;
+	status = "okay";
+};
+
+&uart2 {
+	status = "okay";
+};
+
+&pinctrl {
+	hym8563 {
+		hym8563_int: hym8563-int {
+			rockchip,pins =
+				<4 RK_PD6 0 &pcfg_pull_up>;
+		};
+	};
+};