From patchwork Wed Dec 18 19:10:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 933 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id D7BFA3F08E for ; Wed, 18 Dec 2019 20:10:43 +0100 (CET) Received: by mail-pl1-f198.google.com with SMTP id bd7sf1663989plb.0 for ; Wed, 18 Dec 2019 11:10:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1576696242; cv=pass; d=google.com; s=arc-20160816; b=kBvKw9kYNNvfVEzOFsE/Dd2RUVzqhv2whGPv7SvLAoJr970YZensoitoenCBFxwdJO Jp8jMMi6IhCtiXrWLcz2cwn0F1pE06W7ESX3JCCFkB6Do14lPYkc8CaAY6K2R6RqWpP1 3OGR62EVVy4f94N3mOIG/JHkRuFk+oFML1xzyRcGL/vPrqP7JqTfsut4ORqBbEFroXUJ 9t0FTCh2dtY2fq8LtHSBvKPD8cX+pBrTx9QAhS00wGX0CFeDiRbvRXPShscT8CuUQgOq gvIUGUfwFI02cplCra5IuFS1rcpmivZezRUPR9O1oHTWPhKJamJfv9S2QjgsZjK4MXPJ sazA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=luJeaO/Cg5UAyNt7ob51Zua8FEFMkY1sWoBW+VgEFeE=; b=mJllnyRbMoyjuhEnK/Wd0M/NrhTNzmCqrPzghQ02dwyZgSezspy4J1HYdILle+1LZh tbJ7vBF3XUbiVMy9or1hamwXFG37QxhM5WGZ7Qm0toyHfSlgUgW2zgNcJjJ+tw8V7eez 4US5fMANAq62WOM2sYwaeaa8jAR4ihRoPAktkEpvOF5Dcf1ep8YP6eq3q64C5GHozLIJ 6XSIHmKuq/0vMNUPVBB7v4Z9uaWmRCMrFLPSKmC6ZkUM1d/GqvnM6HrMJBVJNxT/FBO6 ZKvLVJ2REsAPlN9f1sSRu/g8pyFf6AARHxnkVRSZ2hoUgRaR7IbocYsv7aWHhL/qje3C qoyg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ahpP2VUF; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=luJeaO/Cg5UAyNt7ob51Zua8FEFMkY1sWoBW+VgEFeE=; b=BG+jfqRm2nuMxxsRLykVGyytF9mwI7YQrFq9g77Ogz3F+sRBfKJ0EULXZuD8wcFKta VnY+sWZMGiZtI3cauNUS1p309eOi37z7H/Bej2t8vKEifcF40BLoXsrcsncgL1k9Bozi iLIWi2JaHDUpaDfuFonpJbt2QhxlHOqt068Ro= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=luJeaO/Cg5UAyNt7ob51Zua8FEFMkY1sWoBW+VgEFeE=; b=DaxjdeLNjXAThiecZ+31DgM/egrUfBGBH8Xct1TLZFszyEfVd9K59FHJwpSqdEYhTI Vog/EBH6FgHXDnDmdniXseHx+ibTyr6p+cfpgYCVDjAg4Nc4yc3YFmE5oZPObprx/GSY qyR46vy1GFRXyqG3Nqd2ZdFDh7Rvsn4z2c3G6sbUzfFg9pBqmqAJ3gVh0zYqtDwOYuVJ 3+ABkVry6s0dkKmZD/eUXA22bWkgaNaZCP1CehvVfMqPSeAEYi5dfxgJWY+zozcvg5mm Ujeiq8Fs+oID4Vtcvi04t+MAQlkV32Xs+pykciipU/mgJMa/RqLicQjS21UH3a1igEU9 fS8w== X-Gm-Message-State: APjAAAWnRDdZG29fT2tHZpQRZmkHefov5a8SPNCB3H0Cf/ldRe4ghbKB i8bEu60GgX1CIUkThweOR8+NHW2J X-Google-Smtp-Source: APXvYqwE8oFv+otQv9Gunb0ELz/52uYdUoBc6zAcMaVfN+vYSlOkzUlJ+AeCUoi7oMTTu+CTtSyvNA== X-Received: by 2002:a63:1b47:: with SMTP id b7mr4686544pgm.446.1576696241831; Wed, 18 Dec 2019 11:10:41 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a65:4948:: with SMTP id q8ls705223pgs.12.gmail; Wed, 18 Dec 2019 11:10:41 -0800 (PST) X-Received: by 2002:a63:ce50:: with SMTP id r16mr4797995pgi.32.1576696241220; Wed, 18 Dec 2019 11:10:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576696241; cv=none; d=google.com; s=arc-20160816; b=eWoLIaMn5CnTFIYCf6ZSpvM0cr/YfcIGN7g/2JgYZMC+1U4X7n4B1RCMmW6wDwmGtg N+YsAFtHTD+19AO31PCUar4dPSavSEAyX4l+nIS1irJ2zSw7meKEnAYFOIHZ6So9QARD qSMDx9ihqmlFYNaZ3Tku+zXnzX+ZqKLjHo++VZhWtqnDhsojezpb8EDYFPtklDw6VIgW AxMMAdIFCoPlAo4rEtH2q80eDkVKaPTeWDFW86i1v9ldFw8zv+LldaO/XDcJBxSchhWR pYAuHPdlDy86QxsEErF8/x9YNeQ9EAGrSFabzB+qBzE6OmfndaeJGmevu3tw+LS57NE/ Kn5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=Hp8TQeL3yIB1KqyuldLYK5Mau4+1RzHQTjjW58JR+LE=; b=QYpE0qDS18UgXQs1HNeCBFLXhuUsdwXGYqQLAq+iSwfFxoF6xCmG+JyhAbuM0sZrmC 6TIkkisppzNlZ0uiqv7ka5mff4qO+D7DHBE7MgVMu/0oVvfe+SSBt6sXyq9CRmhL0qw1 +O2qBBlW6UYItq/k5vg/QGEGe6xONuK3yV+8dfbopajS+s6yjhBDf0yLVgids7O2sLGs XN8ZGsIo9I1zQrkoCcWKm1NMblxxv3CQZZObAbP5jqsDMPP4ZWL+g6LYgPM7Ac8xUnYP HPgJZK7xVYqOju3SnSdZ+ahhXQ9TtT+cyEruDUAI2CpvC94LBGbdQAhZau7h+/mC1hpm cTrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ahpP2VUF; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id w7sor3076861pjr.23.2019.12.18.11.10.41 for (Google Transport Security); Wed, 18 Dec 2019 11:10:41 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; X-Received: by 2002:a17:90a:fb4f:: with SMTP id iq15mr4735561pjb.86.1576696240895; Wed, 18 Dec 2019 11:10:40 -0800 (PST) Received: from localhost.localdomain ([2405:201:c809:c7d5:78ea:e014:edb4:e862]) by smtp.gmail.com with ESMTPSA id q7sm3745855pjd.3.2019.12.18.11.10.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2019 11:10:40 -0800 (PST) From: Jagan Teki To: Maxime Ripard , Chen-Yu Tsai , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland Cc: michael@amarulasolutions.com, Icenowy Zheng , linux-sunxi , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-amarula@amarulasolutions.com, Jagan Teki Subject: [PATCH v13 3/7] drm/sun4i: dsi: Get the mod clock for A31 Date: Thu, 19 Dec 2019 00:40:13 +0530 Message-Id: <20191218191017.2895-4-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20191218191017.2895-1-jagan@amarulasolutions.com> References: <20191218191017.2895-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ahpP2VUF; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , As per the user manual, look like mod clock is not mandatory for all Allwinner MIPI DSI controllers, it is connected to CLK_DSI_SCLK for A31 and not available in A64. So, add compatible check for A31 and get mod clock accordingly. Tested-by: Merlijn Wajer Signed-off-by: Jagan Teki --- Changes for v13: - Drop has_mod_clk quirk as commented by Chen-Yu drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c index c958ca9bae63..68b88a3dc4c5 100644 --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c @@ -1120,10 +1120,13 @@ static int sun6i_dsi_probe(struct platform_device *pdev) return PTR_ERR(dsi->reset); } - dsi->mod_clk = devm_clk_get(dev, "mod"); - if (IS_ERR(dsi->mod_clk)) { - dev_err(dev, "Couldn't get the DSI mod clock\n"); - return PTR_ERR(dsi->mod_clk); + if (of_device_is_compatible(dev->of_node, + "allwinner,sun6i-a31-mipi-dsi")) { + dsi->mod_clk = devm_clk_get(dev, "mod"); + if (IS_ERR(dsi->mod_clk)) { + dev_err(dev, "Couldn't get the DSI mod clock\n"); + return PTR_ERR(dsi->mod_clk); + } } /*