mbox series

[v3,0/6] rockchip: rk3399: Make u-boot.itb as BUILD_TARGET

Message ID 20190507185215.15441-1-jagan@amarulasolutions.com
Headers
Series rockchip: rk3399: Make u-boot.itb as BUILD_TARGET |

Message

Jagan Teki May 7, 2019, 6:52 p.m. UTC 
RK3399 TPL changes are merged recently which I was thinking 
of waiting for next MW. so this series skip binman changes 
from previous version[1] and have only BUILD_TARGET changes.

BINMAN changes would need another rework, where we need to consider 
the TPL image as well and that would send separately.

CHanges for v3:
- skip binman changes
- rebase on u-boot-rockchip/master
 
[1] https://patchwork.ozlabs.org/cover/1092198/

Jagan Teki (6):
  Makefile: clean image.map
  Makefile: clean bl31_*.bin
  travis.yml: Add pyelftools install entry
  rockchip: rk3399: Get bl31.elf via BL31
  board: puma: Get bl31.bin via BL31 and rk3399m0.bin via PMUM0
  Kconfig: Add u-boot.itb BUILD_TARGET for Rockchip

 .travis.yml                                   |  1 +
 Kconfig                                       |  2 +-
 Makefile                                      |  3 +-
 arch/arm/mach-rockchip/make_fit_atf.py        | 11 ++-
 .../puma_rk3399/fit_spl_atf.its               | 58 ------------
 .../puma_rk3399/fit_spl_atf.sh                | 94 +++++++++++++++++++
 configs/puma-rk3399_defconfig                 |  2 +-
 doc/README.rockchip                           | 14 ++-
 8 files changed, 115 insertions(+), 70 deletions(-)
 delete mode 100644 board/theobroma-systems/puma_rk3399/fit_spl_atf.its
 create mode 100755 board/theobroma-systems/puma_rk3399/fit_spl_atf.sh

Comments

Jagan Teki June 13, 2019, 6:53 a.m. UTC | #1 
Hi Kever,

On Wed, May 8, 2019 at 12:23 AM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> RK3399 TPL changes are merged recently which I was thinking
> of waiting for next MW. so this series skip binman changes
> from previous version[1] and have only BUILD_TARGET changes.
>
> BINMAN changes would need another rework, where we need to consider
> the TPL image as well and that would send separately.
>
> CHanges for v3:
> - skip binman changes
> - rebase on u-boot-rockchip/master
>
> [1] https://patchwork.ozlabs.org/cover/1092198/
>
> Jagan Teki (6):
>   Makefile: clean image.map
>   Makefile: clean bl31_*.bin
>   travis.yml: Add pyelftools install entry
>   rockchip: rk3399: Get bl31.elf via BL31
>   board: puma: Get bl31.bin via BL31 and rk3399m0.bin via PMUM0
>   Kconfig: Add u-boot.itb BUILD_TARGET for Rockchip

I think you hold for this with puma changes? any further comments
please let me know.
Kever Yang June 18, 2019, 7:09 a.m. UTC | #2 
Hi Jagan,


On 06/13/2019 02:53 PM, Jagan Teki wrote:
> Hi Kever,
>
> On Wed, May 8, 2019 at 12:23 AM Jagan Teki <jagan@amarulasolutions.com> wrote:
>> RK3399 TPL changes are merged recently which I was thinking
>> of waiting for next MW. so this series skip binman changes
>> from previous version[1] and have only BUILD_TARGET changes.
>>
>> BINMAN changes would need another rework, where we need to consider
>> the TPL image as well and that would send separately.
>>
>> CHanges for v3:
>> - skip binman changes
>> - rebase on u-boot-rockchip/master
>>
>> [1] https://patchwork.ozlabs.org/cover/1092198/
>>
>> Jagan Teki (6):
>>   Makefile: clean image.map
>>   Makefile: clean bl31_*.bin
>>   travis.yml: Add pyelftools install entry
>>   rockchip: rk3399: Get bl31.elf via BL31
>>   board: puma: Get bl31.bin via BL31 and rk3399m0.bin via PMUM0
>>   Kconfig: Add u-boot.itb BUILD_TARGET for Rockchip
> I think you hold for this with puma changes? any further comments
> please let me know.
>

Yes, one reason is not get response from puma board.
And I think this does not break the board support but maybe
break the build process if not all the environment has export as expected?

Thanks,
- Kever
Jagan Teki June 18, 2019, 7:16 a.m. UTC | #3 
On Tue, Jun 18, 2019 at 12:40 PM Kever Yang <kever.yang@rock-chips.com> wrote:
>
> Hi Jagan,
>
>
> On 06/13/2019 02:53 PM, Jagan Teki wrote:
> > Hi Kever,
> >
> > On Wed, May 8, 2019 at 12:23 AM Jagan Teki <jagan@amarulasolutions.com> wrote:
> >> RK3399 TPL changes are merged recently which I was thinking
> >> of waiting for next MW. so this series skip binman changes
> >> from previous version[1] and have only BUILD_TARGET changes.
> >>
> >> BINMAN changes would need another rework, where we need to consider
> >> the TPL image as well and that would send separately.
> >>
> >> CHanges for v3:
> >> - skip binman changes
> >> - rebase on u-boot-rockchip/master
> >>
> >> [1] https://patchwork.ozlabs.org/cover/1092198/
> >>
> >> Jagan Teki (6):
> >>   Makefile: clean image.map
> >>   Makefile: clean bl31_*.bin
> >>   travis.yml: Add pyelftools install entry
> >>   rockchip: rk3399: Get bl31.elf via BL31
> >>   board: puma: Get bl31.bin via BL31 and rk3399m0.bin via PMUM0
> >>   Kconfig: Add u-boot.itb BUILD_TARGET for Rockchip
> > I think you hold for this with puma changes? any further comments
> > please let me know.
> >
>
> Yes, one reason is not get response from puma board.
> And I think this does not break the board support but maybe
> break the build process if not all the environment has export as expected?

It can't break the build, for not exporting cases the script will
create dummy bl31 elf and the bl31 variable assign it and finally
trigger warning. fyi, the else statement on this patch [1] does what I
mentioned.

[1] https://patchwork.ozlabs.org/patch/1096505/
Kever Yang June 18, 2019, 9:11 a.m. UTC | #4 
On 06/18/2019 03:16 PM, Jagan Teki wrote:
> On Tue, Jun 18, 2019 at 12:40 PM Kever Yang <kever.yang@rock-chips.com> wrote:
>> Hi Jagan,
>>
>>
>> On 06/13/2019 02:53 PM, Jagan Teki wrote:
>>> Hi Kever,
>>>
>>> On Wed, May 8, 2019 at 12:23 AM Jagan Teki <jagan@amarulasolutions.com> wrote:
>>>> RK3399 TPL changes are merged recently which I was thinking
>>>> of waiting for next MW. so this series skip binman changes
>>>> from previous version[1] and have only BUILD_TARGET changes.
>>>>
>>>> BINMAN changes would need another rework, where we need to consider
>>>> the TPL image as well and that would send separately.
>>>>
>>>> CHanges for v3:
>>>> - skip binman changes
>>>> - rebase on u-boot-rockchip/master
>>>>
>>>> [1] https://patchwork.ozlabs.org/cover/1092198/
>>>>
>>>> Jagan Teki (6):
>>>>   Makefile: clean image.map
>>>>   Makefile: clean bl31_*.bin
>>>>   travis.yml: Add pyelftools install entry
>>>>   rockchip: rk3399: Get bl31.elf via BL31
>>>>   board: puma: Get bl31.bin via BL31 and rk3399m0.bin via PMUM0
>>>>   Kconfig: Add u-boot.itb BUILD_TARGET for Rockchip
>>> I think you hold for this with puma changes? any further comments
>>> please let me know.
>>>
>> Yes, one reason is not get response from puma board.
>> And I think this does not break the board support but maybe
>> break the build process if not all the environment has export as expected?
> It can't break the build, for not exporting cases the script will
> create dummy bl31 elf
Could you create dummy bl31.elf after check if there is one already there,
which is what we used to do instead of use BL31 env, and then this won't
break anything and we can migrate to use BL31 smoothly.

Thanks,
- Kever
>  and the bl31 variable assign it and finally
> trigger warning. fyi, the else statement on this patch [1] does what I
> mentioned.
>
> [1] https://patchwork.ozlabs.org/patch/1096505/
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>