mbox series

[v3,0/5] rockchip: rk3399: Fix HDMI out

Message ID 20200402114125.2501-1-jagan@amarulasolutions.com
Headers
Series rockchip: rk3399: Fix HDMI out |

Message

Jagan Teki April 2, 2020, 11:41 a.m. UTC 
Due to recent Linux dts(i) sync for rk3399. the existing
vop driver is not working with HDMI out on RK3399.

This is v3 patchset, for previous version fixes[1]. 

Changes for v3:
- handle vopl clks in clk driver
- drop dts changes
- fix 4K display out for rk3399
Changes for v2:
- use usbkbd as stdin
- enable USB Keyboard

[1] https://patchwork.ozlabs.org/cover/1264187/

Any inputs?
Jagan.

Jagan Teki (5):
  clk: rk3399: Set empty for vopl assigned-clocks
  video: rockchip: Fix vop modes for rk3399
  rockchip: Enable pre console for rk3399
  rockchip: Enable HDMI output on rk3399 board w/ HDMI
  video: rockchip: Support 4K resolution for rk3399, HDMI

 arch/arm/include/asm/arch-rockchip/vop_rk3288.h | 11 +++++++++++
 arch/arm/mach-rockchip/Kconfig                  |  1 +
 common/Kconfig                                  |  1 +
 configs/nanopc-t4-rk3399_defconfig              |  7 +++++++
 configs/nanopi-m4-rk3399_defconfig              |  7 +++++++
 configs/nanopi-neo4-rk3399_defconfig            |  7 +++++++
 configs/roc-pc-rk3399_defconfig                 |  6 ++++++
 configs/rock960-rk3399_defconfig                |  7 +++++++
 drivers/clk/rockchip/clk_rk3399.c               |  7 +++++++
 drivers/video/rockchip/Kconfig                  |  2 ++
 drivers/video/rockchip/rk3399_vop.c             |  2 --
 drivers/video/rockchip/rk_vop.c                 |  4 ++++
 include/configs/evb_rk3399.h                    |  5 +++++
 include/configs/rock960_rk3399.h                |  5 +++++
 14 files changed, 70 insertions(+), 2 deletions(-)

Comments

Peter Robinson April 2, 2020, 12:39 p.m. UTC | #1 
On Thu, Apr 2, 2020 at 12:41 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> Due to recent Linux dts(i) sync for rk3399. the existing
> vop driver is not working with HDMI out on RK3399.
>
> This is v3 patchset, for previous version fixes[1].
>
> Changes for v3:
> - handle vopl clks in clk driver
> - drop dts changes
> - fix 4K display out for rk3399
> Changes for v2:
> - use usbkbd as stdin
> - enable USB Keyboard
>
> [1] https://patchwork.ozlabs.org/cover/1264187/
>
> Any inputs?

This series works for me for display output on the Rock960, I had
tried one of the prior versions with it (I think v1) and it had caused
issues but the display comes up and outputs on HDMI for me so:
Tested-by: Peter Robinson <pbrobinson@gmail.com>

> Jagan.
>
> Jagan Teki (5):
>   clk: rk3399: Set empty for vopl assigned-clocks
>   video: rockchip: Fix vop modes for rk3399
>   rockchip: Enable pre console for rk3399
>   rockchip: Enable HDMI output on rk3399 board w/ HDMI
>   video: rockchip: Support 4K resolution for rk3399, HDMI
>
>  arch/arm/include/asm/arch-rockchip/vop_rk3288.h | 11 +++++++++++
>  arch/arm/mach-rockchip/Kconfig                  |  1 +
>  common/Kconfig                                  |  1 +
>  configs/nanopc-t4-rk3399_defconfig              |  7 +++++++
>  configs/nanopi-m4-rk3399_defconfig              |  7 +++++++
>  configs/nanopi-neo4-rk3399_defconfig            |  7 +++++++
>  configs/roc-pc-rk3399_defconfig                 |  6 ++++++
>  configs/rock960-rk3399_defconfig                |  7 +++++++
>  drivers/clk/rockchip/clk_rk3399.c               |  7 +++++++
>  drivers/video/rockchip/Kconfig                  |  2 ++
>  drivers/video/rockchip/rk3399_vop.c             |  2 --
>  drivers/video/rockchip/rk_vop.c                 |  4 ++++
>  include/configs/evb_rk3399.h                    |  5 +++++
>  include/configs/rock960_rk3399.h                |  5 +++++
>  14 files changed, 70 insertions(+), 2 deletions(-)
>
> --
> 2.17.1
>
Anatolij Gustschin April 2, 2020, 1:56 p.m. UTC | #2 
On Thu,  2 Apr 2020 17:11:20 +0530
Jagan Teki jagan@amarulasolutions.com wrote:
...
> Jagan Teki (5):
>   clk: rk3399: Set empty for vopl assigned-clocks
>   video: rockchip: Fix vop modes for rk3399
>   rockchip: Enable pre console for rk3399
>   rockchip: Enable HDMI output on rk3399 board w/ HDMI
>   video: rockchip: Support 4K resolution for rk3399, HDMI
> 
>  arch/arm/include/asm/arch-rockchip/vop_rk3288.h | 11 +++++++++++
>  arch/arm/mach-rockchip/Kconfig                  |  1 +
>  common/Kconfig                                  |  1 +
>  configs/nanopc-t4-rk3399_defconfig              |  7 +++++++
>  configs/nanopi-m4-rk3399_defconfig              |  7 +++++++
>  configs/nanopi-neo4-rk3399_defconfig            |  7 +++++++
>  configs/roc-pc-rk3399_defconfig                 |  6 ++++++
>  configs/rock960-rk3399_defconfig                |  7 +++++++
>  drivers/clk/rockchip/clk_rk3399.c               |  7 +++++++
>  drivers/video/rockchip/Kconfig                  |  2 ++
>  drivers/video/rockchip/rk3399_vop.c             |  2 --
>  drivers/video/rockchip/rk_vop.c                 |  4 ++++
>  include/configs/evb_rk3399.h                    |  5 +++++
>  include/configs/rock960_rk3399.h                |  5 +++++
>  14 files changed, 70 insertions(+), 2 deletions(-)

Series applied to u-boot-video/video-fixes-v2020.04, thanks!

--
Anatolij
Kever Yang April 2, 2020, 2:28 p.m. UTC | #3 
Hi Anatolij,

On 2020/4/2 下午9:56, Anatolij Gustschin wrote:
> On Thu,  2 Apr 2020 17:11:20 +0530
> Jagan Teki jagan@amarulasolutions.com wrote:
> ...
>> Jagan Teki (5):
>>    clk: rk3399: Set empty for vopl assigned-clocks
>>    video: rockchip: Fix vop modes for rk3399
>>    rockchip: Enable pre console for rk3399
>>    rockchip: Enable HDMI output on rk3399 board w/ HDMI
>>    video: rockchip: Support 4K resolution for rk3399, HDMI
>>
>>   arch/arm/include/asm/arch-rockchip/vop_rk3288.h | 11 +++++++++++
>>   arch/arm/mach-rockchip/Kconfig                  |  1 +
>>   common/Kconfig                                  |  1 +
>>   configs/nanopc-t4-rk3399_defconfig              |  7 +++++++
>>   configs/nanopi-m4-rk3399_defconfig              |  7 +++++++
>>   configs/nanopi-neo4-rk3399_defconfig            |  7 +++++++
>>   configs/roc-pc-rk3399_defconfig                 |  6 ++++++
>>   configs/rock960-rk3399_defconfig                |  7 +++++++
>>   drivers/clk/rockchip/clk_rk3399.c               |  7 +++++++
>>   drivers/video/rockchip/Kconfig                  |  2 ++
>>   drivers/video/rockchip/rk3399_vop.c             |  2 --
>>   drivers/video/rockchip/rk_vop.c                 |  4 ++++
>>   include/configs/evb_rk3399.h                    |  5 +++++
>>   include/configs/rock960_rk3399.h                |  5 +++++
>>   14 files changed, 70 insertions(+), 2 deletions(-)
> Series applied to u-boot-video/video-fixes-v2020.04, thanks!

I was about to apply these patches, and under travis build now.

It's also OK for these patches to merge into u-boot-video.


Thanks,

- Kever

>
> --
> Anatolij
>
>
Anatolij Gustschin April 2, 2020, 2:42 p.m. UTC | #4 
Hi Kever,

On Thu, 2 Apr 2020 22:28:53 +0800
Kever Yang kever.yang@rock-chips.com wrote:
...
> > Series applied to u-boot-video/video-fixes-v2020.04, thanks!  
> 
> I was about to apply these patches, and under travis build now.
> 
> It's also OK for these patches to merge into u-boot-video.

I'm build testing the series [1] and will submit a pull request to
Tom.

[1] https://gitlab.denx.de/u-boot/custodians/u-boot-video/pipelines/2606

--
Anatolij