From patchwork Fri Dec 16 13:25:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 2573 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 297543F081 for ; Fri, 16 Dec 2022 14:25:27 +0100 (CET) Received: by mail-wm1-f70.google.com with SMTP id r129-20020a1c4487000000b003d153a83d27sf1223500wma.0 for ; Fri, 16 Dec 2022 05:25:27 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1671197127; cv=pass; d=google.com; s=arc-20160816; b=TPPYejEVMcKi3pfKJFedBfMUyWucaLrpjFVxk1Mk3gt/Oqx6DUMcD8jf2l0VnHsx9J jFYbGHD62KQkFC2SE257yE1G5Jki6XPJs0l846U7h7dnYSx9eTENTiCRUDUX95OOyOT1 kPcUC40OsqQEntCEc+8eNHfXWnzyoRjlYoM71hhnW0ameX0z1WMASz/bCMK9lSxGgdcT a3ZNhzoEpUXF48wzouBPVapuvN+BB2UKCwlWPW1VzCq+EXz5d7JDPvY1b/NFROj7i5tv 6JnfGpyrOxz7YU4bauyuXBaXub4wUiBZ3HS+MFn2PpePWFSL6oCfIyjwTFa1HYuwak5Z PMBg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:message-id:mime-version:date:cc:to:from :subject:sender:dkim-signature; bh=bV8lzqwl/tPT1n+LPYzLRcw/TlfU+FT8XiHCLmiWIcg=; b=BeLgprxMFQ+j1Pyk2aWE8xSp31Kx2YH6awPmz3Taqx2iMEYwAx4RRIT8EaU24PGf4A +KkhN1diWhZt8ZeI4D+I8HJVvSY6coHHDXToUJ2m2k0A5Q6027dzge2v+aIGVGIlhop/ v5NBOrrWwqhBdPoeSmtjtG6MQWq2stZcH9puxt4pKLTjiNjOEAEAvDDOH/usTBm2lTtf 60KY+pIHXL5N/OiCbKLrsVoaaDi++DKLjjTSu5YreaC3vB8hdE7ZH4GKkdIpjhScdbkZ YOpkblIUHY9f7KdM+/+IHF0gIOeuwVHVYDhScyElbRJO7yPTRd0Gi+e1nzrf+Y+tUjYg rGtA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@tq-group.com header.s=key1 header.b=K7l5P3KC; dkim=pass header.i=@tq-group.com header.s=key1 header.b=K7l5P3KC; spf=pass (google.com: domain of alexander.stein@ew.tq-group.com designates 93.104.207.81 as permitted sender) smtp.mailfrom=Alexander.Stein@ew.tq-group.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=tq-group.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:message-id:mime-version:date:cc:to:from:subject :sender:from:to:cc:subject:date:message-id:reply-to; bh=bV8lzqwl/tPT1n+LPYzLRcw/TlfU+FT8XiHCLmiWIcg=; b=Cr2bDkea0TZBypYXTQgKnn1N5P8yfS8BenIjtNCUvxQ0vIzo4eptd4bw7cxlcksWxe PvkpPd7mBzhP77cLj0PqQ6k2qhX46L0rkof3EtXDysQ/FXkmOyweWZtr1NUgB2QDea8C u26H+PveCqGr4LA28F5WYo4NQ8FxNn8MUqkyU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:message-id :mime-version:date:cc:to:from:subject:x-gm-message-state:sender:from :to:cc:subject:date:message-id:reply-to; bh=bV8lzqwl/tPT1n+LPYzLRcw/TlfU+FT8XiHCLmiWIcg=; b=z4aTipX36BM+bXwPljcGntYXbLZUw/2u1LkvpQzKgW+6MUvwOG+zxoXg5nfBelrp3k K8mt8kn89XdmdQkwjINCc/Mv8Q0GuXGixmkmzNs+S7wq26csHq51dhy90HmXnJmCW943 B401qbh0+0iSrWQTPI5bGcqLKGoE8t3tbUalmVbXXavc+md1AvqTGAPw4xqi65mIXMbG +tj8Vzntf0+l5yhZm9Q64nUJn+/lgagSHCjtxB7m3gWXahSRy4tKTHw6Ud056doEutBd 2/8+STSrb8fR6jhBQbuyC3NK9RgdqTzBs7Tq+Mwg8nUWz9Rrkl+9/0NL9rSYew200rNO xEBw== Sender: linux-amarula@amarulasolutions.com X-Gm-Message-State: ANoB5pkLQJUIk3swk64q8zQeGpizLv7XM8zB1kbwr3rZZ+n/8mjb4Gbb 6h+vIzHVFr2KZiX01a8pMO9+Mri7 X-Google-Smtp-Source: AA0mqf5wv7evtoj+ZMp9gGkPmtuo6HmvhHi0bA8nUVRr1E0aZO22efgQp/V8OZ9ZR6WJPKbIVpW2eA== X-Received: by 2002:a05:600c:2941:b0:3cf:88df:d355 with SMTP id n1-20020a05600c294100b003cf88dfd355mr633852wmd.141.1671197126840; Fri, 16 Dec 2022 05:25:26 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:adf:d20a:0:b0:228:ddd7:f40e with SMTP id j10-20020adfd20a000000b00228ddd7f40els1658039wrh.3.-pod-prod-gmail; Fri, 16 Dec 2022 05:25:26 -0800 (PST) X-Received: by 2002:a05:6000:1e0d:b0:252:5adc:238a with SMTP id bj13-20020a0560001e0d00b002525adc238amr10915189wrb.33.1671197125942; Fri, 16 Dec 2022 05:25:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671197125; cv=none; d=google.com; s=arc-20160816; b=voFJaV7JcZgkPn7xbCl/Tce+UjpwA/K7LWDf1YliQaPODo2yPuW3JBQfJsy43o1BUA JtepY3zOhTbojjddwFZD+IRrdmZqQPRJ7Yb+1/R6U7v/DWCjpci160RPOGExAhEF5OeK 3fVnPnj/ibqoiojSEi9X0D9lONXBorr4OJnhhvLRFC7EPHwtQEseAdGt1gOcz27arCoU 8EBVHo2xVeDIzw+SqXn2AW+RhpOapoBgFYCPQQrf6QzXW0kI6yGq3URsmcNDkZGYv5wF R5TUytH0X/KSsGjPIIFklkJq0QLWhTr902AWDlXlSTdyH3lttsKlfvzbL8MbV+Hehy8p nfSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:content-transfer-encoding:mime-version:date:cc:to:from :subject:dkim-signature:dkim-signature; bh=2rOMZ+WqluKpGt9T2gsxd25x1tfiSnhzu7edlmN+S9g=; b=hOXA86VXO9PbejVEQqEFp/4sgsNXmXpIiaACDIlNymU41jMVsPBQrrrEMZrr7m/KAj 7GytlmUik7sp3qkmJMidOAPp77HalhwENFw/cvwOejBIASaT45HYVBwf0DAyHt/4Fl7H n1b0F8f0ko5N8q+vNpZpwid/GFUhuusZ4hgahvjTy/ToB9/rZwSsnTbKw2dKqqS5f2JG 9/szy8Ey6+fMD/qXVkDUYt0mftn4ldI9U2vyfx89gJOHHuQN1AoZ6SfWd9lI43F4J/Xj Fg7HVsTVyDzjuLb+AnKXCdH7keCsgAmuZk8o8wmyZNDIZNxrOmrHx8Q3GvVWbR9i1zlj gHkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tq-group.com header.s=key1 header.b=K7l5P3KC; dkim=pass header.i=@tq-group.com header.s=key1 header.b=K7l5P3KC; spf=pass (google.com: domain of alexander.stein@ew.tq-group.com designates 93.104.207.81 as permitted sender) smtp.mailfrom=Alexander.Stein@ew.tq-group.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=tq-group.com Received: from mx1.tq-group.com (mx1.tq-group.com. [93.104.207.81]) by mx.google.com with ESMTPS id bj30-20020a0560001e1e00b0024258f2fc57si1967354wrb.823.2022.12.16.05.25.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Dec 2022 05:25:25 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.stein@ew.tq-group.com designates 93.104.207.81 as permitted sender) client-ip=93.104.207.81; X-IronPort-AV: E=Sophos;i="5.96,249,1665439200"; d="scan'208";a="28001487" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 16 Dec 2022 14:25:25 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 16 Dec 2022 14:25:25 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 16 Dec 2022 14:25:25 +0100 X-IronPort-AV: E=Sophos;i="5.96,249,1665439200"; d="scan'208";a="28001486" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 16 Dec 2022 14:25:25 +0100 Received: from vtuxmail01.tq-net.de (localhost [127.0.0.1]) by vtuxmail01.tq-net.de (Postfix) with ESMTP id DFA1E280071; Fri, 16 Dec 2022 14:25:24 +0100 (CET) Received: by vtuxmail01 (kopano-spooler) with MAPI; Fri, 16 Dec 2022 14:25:24 +0100 Subject: [PATCH v10 00/18] drm: Add Samsung MIPI DSIM bridge From: "Alexander Stein" To: "Andrzej Hajda" , "Inki Dae" , "Marek Szyprowski" , Joonyoung Shim , "Seung-Woo Kim" , Kyungmin Park , "Frieder Schrempf" , "Fancy Fang" , Tim Harvey , "Michael Nazzareno Trimarchi" , "Adam Ford" , Neil Armstrong , "Robert Foss" , Laurent Pinchart , "Tommaso Merciai" , dri-devel@lists.freedesktop.org , Marek Vasut Cc: linux-samsung-soc@vger.kernel.org , "Matteo Lisi" , "NXP Linux Team" , linux-amarula , linux-arm-kernel@lists.infradead.org , Jagan Teki Date: Fri, 16 Dec 2022 13:25:24 +0000 Mime-Version: 1.0 X-Priority: 3 (Normal) X-Mailer: Kopano 8.7.82 Message-Id: X-Original-Sender: alexander.stein@ew.tq-group.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@tq-group.com header.s=key1 header.b=K7l5P3KC; dkim=pass header.i=@tq-group.com header.s=key1 header.b=K7l5P3KC; spf=pass (google.com: domain of alexander.stein@ew.tq-group.com designates 93.104.207.81 as permitted sender) smtp.mailfrom=Alexander.Stein@ew.tq-group.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=tq-group.com Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Hi Marek, Am Freitag, 16. Dezember 2022, 13:58:13 CET schrieb Marek Vasut: > On 12/16/22 13:41, Alexander Stein wrote: > > Hi, > > Hi, > > > thanks for the new update. > > > > Am Mittwoch, 14. Dezember 2022, 13:58:49 CET schrieb Jagan Teki: > >> This series supports common bridge support for Samsung MIPI DSIM > >> which is used in Exynos and i.MX8MM SoC's. > >> > >> The final bridge supports both the Exynos and i.MX8M Mini/Nano/Plus. > >> > >> Patch 0001 - 0004: adding devm_drm_of_dsi_get_bridge > >> > >> Patch 0005 - 0006: optional PHY, PMS_P offset > >> > >> Patch 0007 : introduce hw_type > >> > >> Patch 0008 : fixing host init > >> > >> Patch 0009 : atomic_check > >> > >> Patch 0010 : input_bus_flags > >> > >> Patch 0011 : atomic_get_input_bus_fmts > >> > >> Patch 0012 - 0013: component vs bridge > >> > >> Patch 0014 : DSIM bridge > >> > >> Patch 0015 - 0016: i.MX8M Mini/Nano > >> > >> Patch 0017 - 0018: i.MX8M Plus > > > > Tested using LVDS bridges and works on: > > * imx8mp-tqma8mpql-mba8mpxl (i.MX8M Plus) > > * imx8mm-tqma8mqml-mba8mx (i.MX8M Mini) > > * imx8mn-tqma8mqnl-mba8mx (i.MX8M Nano) > > > > But I noticed that tqma8mqml and tqma8mqnl only have a stable output if I > > specify 'data-lanes = <0 1 2>' (not <0 1 2 3>!) on the DSI-LVDS-Bridge (TI > > SN65DSI83) input endpoint, e.g. > > > > dsi_lvds_bridge: bridge@2d { > > > > compatible = "ti,sn65dsi83"; > > reg = <0x2d>; > > enable-gpios = <&gpio_delays 0 130000 0>; > > vcc-supply = <®_sn65dsi83_1v8>; > > status = "okay"; > > ports { > > > > #address-cells = <1>; > > #size-cells = <0>; > > port@0 { > > > > reg = <0>; > > lvds_bridge_in: endpoint { > > > > data-lanes = <0 1 2>; > > remote-endpoint = <&mipi_dsi_out>; > > > > }; > > > > }; > > port@2 { > > > > reg = <2>; > > lvds_bridge_out: endpoint { > > > > remote-endpoint = <&panel_in_lvds0>; > > > > }; > > > > }; > > > > }; > > > > }; > > > > I have no idea if this is on the DSIM side or the DSI-LVDS bridge side. > > Register 0xe5 on sn65dsi83 shows that CHA_LPP_ERR and CHA_SOT_BIT_ERR > > error > > bits are set, indicating there are low level protocol and SoT leader > > sequence bit errors. I can't find any significant difference in sn65dsi83 > > driver compared to downstream-kernel, so I would assume something in DSIM > > driver is different. > > Make sure the HS clock rate expected by the DSI83 bridge chip and the > one generated by the DSIM bridge from PMS PLL match. There is currently > no negotiation of this frequency and both sides divine it on their own. > > See sn65dsi83_get_dsi_range() and samsung_dsim_set_pll(). Oh, nice, thanks for the pointer. When setting > samsung,burst-clock-frequency = <668250000>; in imx8mm.dtsi I get a non-flickering display using 4 lanes. Although admittedly this is just random guessing. I'm not sure which clock exactly has to be in the range CHA_DSI_CLK_RANGE is configured to. With 4 lanes SN65DSI84 is configured for 205-210 MHz (0x29), while I get these PLL PMS settings on DSIM: > samsung-dsim 32e10000.dsi: PLL freq 668250000, (p 4, m 99, s 0) > samsung-dsim 32e10000.dsi: hs_clk = 668250000, byte_clk = 83531250, esc_clk = 16706250 AFAICS DSIM bridge is configurung hs_clk, byte_clk and esc_clk just from DT properties, while SN65DSI84 is using display mode and number of lanes. Is it expected that the DSIM PLL frequencies are set in DT for a specific bridge/display setup? Best regards, Alexander