| Message ID | 20190418134838.8806-1-jagan@amarulasolutions.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-amarula+bncBD7MFH7A7EEBBRMA4LSQKGQEAF5MD4A@amarulasolutions.com> X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id A3C7740B21 for <linux-amarula@patchwork.amarulasolutions.com>; Thu, 18 Apr 2019 15:48:59 +0200 (CEST) Received: by mail-pf1-f198.google.com with SMTP id j18sf1417983pfi.20 for <linux-amarula@patchwork.amarulasolutions.com>; Thu, 18 Apr 2019 06:48:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1555595336; cv=pass; d=google.com; s=arc-20160816; b=K4adQFtq2PTk7Ux42mAdnx1DNBI5woVVfG1e4RYyOb6NYNcC+YwfQGhbPTkqCk+2NS oVMlsTANJ900GO3yQLW9tkFw6VWb5ee/V84stCAfe7nUY6m1pjiThmWTlDGmE2ufqCEm 3C9Bd/eUnXfPVxH3fKpyn0UT4r3YMkGcckId8i/F9ySbrKlUhUaeTp1N0unJoFK+yteZ Xd4Gnd3xmpq7nKcjeKy2YxgKkkkI14RLWnLnijC4Vdfp6FlqsEPMeVnnEGQ6/im1EJvy ZNzwXL/Io75xdvtrUVwJ6GTCGVAiXIQbVzRFSGgq0B4XDiwISkenFjWNBKfP3xPh/2Zs Ga5A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=adUwO5cDUqeBVb/Bdp8BB3/Cr8F5Sc+UlPkiGmoozT4=; b=s6CkNxGpLRq902vsp3xahES/rbiEylS16vdNwxF+07Binl1ArV579RoQZ5ApffOM3R wh/q6Zv6t9rZcNOpjG6WSB295KsMZbqubWJTbJXoeOar0jgjyWEKPThWmItTnp+7/I1c bHI7Mq7U7icXX9UWmwNlf6tI735aMBz5R9yJbuSCqkv4vQ2Rdw51gCm2/XmvjdJ5qRkF 0v2Uv5kTrqoCvCTjJahnBkPVDEITL72iR2LPOVeiQpQW7omksRNYp1hVZ5PNoq9cMCuQ 1GFG+j5HsPJbiKd3e8eG4AXyKR3r1E4mUd8Z/hZD0VVEZaQdyjS+kd3VSpYVjL36wYuS pi9w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Vrs38dCL; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=adUwO5cDUqeBVb/Bdp8BB3/Cr8F5Sc+UlPkiGmoozT4=; b=eF44qOm4Xw2lrGmL23a1b/EmsAuwESOisd9cBrH67lkQb9BpQRxPIikhHZEVdntKAK tCESPA9NYBVHL0JN4zQhEVaauoSoYmayFssj7VCXQU3XNKTi4F4hHh7y/NQpOdzFfWd2 u9n6zzQOEqapeKJTJ7zbWQL/TZpwvMIEU8GB4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:x-spam-checked-in-group:list-post:list-help :list-archive:list-unsubscribe; bh=adUwO5cDUqeBVb/Bdp8BB3/Cr8F5Sc+UlPkiGmoozT4=; b=rWogFB3zrKaQbIDSyC1I1oIwNiKAy1pLfRpiMoSzVQMhW8EUXdI9QDftK0U2+Ol8Op kBnmNEW2pW2QAAankMKoX46ckCFkOF3Yg5PfVK29JlHpxmF1LLSIo+Vsc7RcVHf/uquO ZFtIX12QZXsP95KOTMpVOvX2G/jLs/egHSDGYbzqs1ecL0hrNo96/I4aD8782ujKBF+r vILjT2K+kPQG25dk2nJ38/1euC0/Ure444KLlCFDfX/Bl0PVnjUEmkMzKaim6gIYlqt8 l8Zc5KN+yVYQdyM6n9JKQAOXiaKGUSjit6c0gO6C7TwEkgz7wmoE4pIKfyomwkfs7MmY zxSQ== X-Gm-Message-State: APjAAAWtTorhRYFnz/82hmg93wr9XQi3sjzWdwgC5ys7zzsSl9gdLLpd aOV6N8UOjLu6U/c8VvceiXZK2wqY X-Google-Smtp-Source: APXvYqzANf4DV0kvXrXSw+nXWpPi0YnYLloyHTGXTW8ABFQU2LlxWBUVMCw75UcsmTsk1/wxbmaXgA== X-Received: by 2002:a17:902:28e9:: with SMTP id f96mr73293197plb.190.1555595333983; Thu, 18 Apr 2019 06:48:53 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:902:7581:: with SMTP id j1ls695241pll.9.gmail; Thu, 18 Apr 2019 06:48:53 -0700 (PDT) X-Received: by 2002:a17:902:d211:: with SMTP id t17mr92793473ply.214.1555595333532; Thu, 18 Apr 2019 06:48:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555595333; cv=none; d=google.com; s=arc-20160816; b=LgPqI570iXCt+ERSqLLAOsoh9JTkvkxnaiBdho+2FFSYHU9xUVTZdatUyN9VkpU2FD G+Bdb/VvawNOMjWIUi3uYtmo+Sz193MpglIGY0toREL/Tu2QI3OGjHXhOr46Uavbm5wQ 3gKesmlvfdVX1l8yp75fu4aFcmphBLg0a33r/u7DWAYp3fj/o4GBprJQgVmwM7LDz+Cp FrddUdiASAYQRZZxAiZ84kSxpmUpsOXAWJTQHBMdvJa3ZF7y4fdknQC/4FQPHilkUbg3 dLRHwPl07V7hxrwdyhYEF58hlvAt9JvhJMNGNVgsTSMQKEjFQZCa59MnPVvSMfTEo1Ax ScSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=9JIj/FFqgEfC6z9nZwVGyT2L22JvM9xjpTRFOThEtFc=; b=Fo0ixUs6mvFDCovQGyYO/O2dh7OBIBzWER5+Q4es6fPrgmGlfdU3GO9kYF+lD2MUtL 8ZBnViuLQ0dlZp9PBZX2dgstlRR/6MUwD2XPNd0kNuPJz8NWL8+vclb+6JtEiUMmNpM+ PGrs7IrbJjvQNv9yM0izAUviJ3FGTCUaD3jPIk3ubS14Zv0zxbS3w+x7LNtw9Z3ctyN/ F0f70ewwV9WkApk8/HMcEAob2DhyUrmKrTfCDFEuKC8nfpumxKCDmSxCkJyVzMU0wYF3 JrmW3m4yKxWPhH+sNpap6+18Hg6TKAUaM+ewB2iUk5xndperoXRlZUExps0TKJ+O0s93 NJbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Vrs38dCL; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id a8sor2313147ple.51.2019.04.18.06.48.52 for <linux-amarula@amarulasolutions.com> (Google Transport Security); Thu, 18 Apr 2019 06:48:52 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; X-Received: by 2002:a17:902:a704:: with SMTP id w4mr92370617plq.51.1555595332489; Thu, 18 Apr 2019 06:48:52 -0700 (PDT) Received: from localhost.localdomain ([115.97.185.144]) by smtp.gmail.com with ESMTPSA id x8sm2348377pgp.48.2019.04.18.06.48.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Apr 2019 06:48:51 -0700 (PDT) From: Jagan Teki <jagan@amarulasolutions.com> To: Maxime Ripard <maxime.ripard@bootlin.com>, Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com> Cc: Michael Trimarchi <michael@amarulasolutions.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com, Jagan Teki <jagan@amarulasolutions.com> Subject: [PATCH v3 1/2] arm64: dts: allwinner: a64-amarula-relic: Add GT5663 CTP node Date: Thu, 18 Apr 2019 19:18:37 +0530 Message-Id: <20190418134838.8806-1-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Vrs38dCL; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: <linux-amarula.amarulasolutions.com> X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>, <mailto:linux-amarula@amarulasolutions.com> List-Help: <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>, <mailto:linux-amarula+help@amarulasolutions.com> List-Archive: <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/> List-Unsubscribe: <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>, <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe> |
| Series |
[v3,1/2] arm64: dts: allwinner: a64-amarula-relic: Add GT5663 CTP node
|
|
Commit Message
Jagan Teki
April 18, 2019, 1:48 p.m. UTC
Add Goodix GT5663 capacitive touch controller node on
Amarula A64-Relic board.
The CTP connected to board with,
- SDA, SCK from i2c1
- GPIO-LD0 as AVDD28 supply
- PH4 gpio as interrupt pin
- PH8 gpio as reset pin
- X axis is inverted
- Y axis is inverted
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v3:
- Use 2.8v for reg_ldo_io0
Changes for v2:
- drop i2c1, bias-pull-up
.../allwinner/sun50i-a64-amarula-relic.dts | 25 +++++++++++++++++++
1 file changed, 25 insertions(+)
Comments
On Thu, Apr 18, 2019 at 07:18:37PM +0530, Jagan Teki wrote: > Add Goodix GT5663 capacitive touch controller node on > Amarula A64-Relic board. > > The CTP connected to board with, > - SDA, SCK from i2c1 > - GPIO-LD0 as AVDD28 supply > - PH4 gpio as interrupt pin > - PH8 gpio as reset pin > - X axis is inverted > - Y axis is inverted > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > Changes for v3: > - Use 2.8v for reg_ldo_io0 > Changes for v2: > - drop i2c1, bias-pull-up > > .../allwinner/sun50i-a64-amarula-relic.dts | 25 +++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > index 3575db216016..bd31a4385bc1 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > @@ -49,6 +49,24 @@ > bias-pull-up; > }; > > +&i2c1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c1_pins>; You haven't fixed this, and you didn't either in the second patch. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
On Thu, Apr 18, 2019 at 7:34 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Thu, Apr 18, 2019 at 07:18:37PM +0530, Jagan Teki wrote: > > Add Goodix GT5663 capacitive touch controller node on > > Amarula A64-Relic board. > > > > The CTP connected to board with, > > - SDA, SCK from i2c1 > > - GPIO-LD0 as AVDD28 supply > > - PH4 gpio as interrupt pin > > - PH8 gpio as reset pin > > - X axis is inverted > > - Y axis is inverted > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > Changes for v3: > > - Use 2.8v for reg_ldo_io0 > > Changes for v2: > > - drop i2c1, bias-pull-up > > > > .../allwinner/sun50i-a64-amarula-relic.dts | 25 +++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > index 3575db216016..bd31a4385bc1 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > @@ -49,6 +49,24 @@ > > bias-pull-up; > > }; > > > > +&i2c1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&i2c1_pins>; > > You haven't fixed this, and you didn't either in the second patch. Sorry, I interpreted previous comment to keep this pinctrl. Since i2c1 node in sun50i-a64.dtsi doesn't have pinctrl attached to it, added here like i2c0 is it something wrong?
On Thu, Apr 18, 2019 at 07:39:28PM +0530, Jagan Teki wrote: > On Thu, Apr 18, 2019 at 7:34 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > On Thu, Apr 18, 2019 at 07:18:37PM +0530, Jagan Teki wrote: > > > Add Goodix GT5663 capacitive touch controller node on > > > Amarula A64-Relic board. > > > > > > The CTP connected to board with, > > > - SDA, SCK from i2c1 > > > - GPIO-LD0 as AVDD28 supply > > > - PH4 gpio as interrupt pin > > > - PH8 gpio as reset pin > > > - X axis is inverted > > > - Y axis is inverted > > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > > --- > > > Changes for v3: > > > - Use 2.8v for reg_ldo_io0 > > > Changes for v2: > > > - drop i2c1, bias-pull-up > > > > > > .../allwinner/sun50i-a64-amarula-relic.dts | 25 +++++++++++++++++++ > > > 1 file changed, 25 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > > index 3575db216016..bd31a4385bc1 100644 > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > > @@ -49,6 +49,24 @@ > > > bias-pull-up; > > > }; > > > > > > +&i2c1 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&i2c1_pins>; > > > > You haven't fixed this, and you didn't either in the second patch. > > Sorry, I interpreted previous comment to keep this pinctrl. > > Since i2c1 node in sun50i-a64.dtsi doesn't have pinctrl attached to > it, added here like i2c0 is it something wrong? If that's the only muxing option, it should be in the DTSI. If it's not the only muxing option, then the name is wrong. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts index 3575db216016..bd31a4385bc1 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts @@ -49,6 +49,24 @@ bias-pull-up; }; +&i2c1 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c1_pins>; + status = "okay"; + + touchscreen@5d { + compatible = "goodix,gt5663"; + reg = <0x5d>; + AVDD28-supply = <®_ldo_io0>; /* VCC-CTP: GPIO0-LDO */ + interrupt-parent = <&pio>; + interrupts = <7 4 IRQ_TYPE_EDGE_FALLING>; + irq-gpios = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* CTP-INT: PH4 */ + reset-gpios = <&pio 7 8 GPIO_ACTIVE_HIGH>; /* CTP-RST: PH8 */ + touchscreen-inverted-x; + touchscreen-inverted-y; + }; +}; + &mmc1 { pinctrl-names = "default"; pinctrl-0 = <&mmc1_pins>; @@ -212,6 +230,13 @@ regulator-name = "vdd-cpus"; }; +®_ldo_io0 { + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; + regulator-name = "vcc-ctp"; + status = "okay"; +}; + ®_rtc_ldo { regulator-name = "vcc-rtc"; };