| Message ID | 20190425173427.13445-4-jagan@amarulasolutions.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-amarula+bncBD7MFH7A7EEBBQO7Q7TAKGQEYLKQMLQ@amarulasolutions.com> X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id E8FA43F086 for <linux-amarula@patchwork.amarulasolutions.com>; Thu, 25 Apr 2019 19:34:58 +0200 (CEST) Received: by mail-pg1-f199.google.com with SMTP id e12sf202198pgh.2 for <linux-amarula@patchwork.amarulasolutions.com>; Thu, 25 Apr 2019 10:34:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1556213697; cv=pass; d=google.com; s=arc-20160816; b=c0NKm6Gs/45+pF8tYasyIlfOHoLgI+r7APLrO3TRVa/zR0cBElbjszGRMWS4xDdtpd iqeGMJH4DIzjBl/PdfspMQsmDuhYSUXKr44hgmCtg+K2iicnCq2EXtMVBGVqnYv3rtGz DgL8YOREC1m/vQWqw8r3vd5ozVKw/4p3pwPcmA1ugl75VwzDCHsepXiKqZ2N4k9oCx5U nnx5LyJzdnvWGV+UcdiXyK3Xn75G67nNSyA/1hrIq6jfdGMIw64BJyAsNCt73Z2MOr/e 2ckgz2FZ4E/vo6Cbt4KEP3Nqr7RvVEuiYE9+Ktvj/pblS8vXMarSeF2f9u+UiZbGf5bB +sRg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=IwubS1mZFPbIE8xN0VfDOR1ceqQunwRhk8XOtanDERw=; b=f1Ap1sYLWmzQsK3u5WwGfL+4S2E+p6JPlRo3zwVexDXXj43I/DY0rmV3ISOXS68jGU aGdg3nwEYNoHECUT6I4bPgyBEAeOQOeU+fPlYHoFIHQMzCQZ+uFsp7cwDjEZx+29Di8O JAx+9BZXDamzCH9BibbfTIk6i/T6bCHV9Wgu6IO0dg6f3Meb4QxQPB0lwu8BUn2HxaLC QmqAXzs8fk7K23SvHgNgmx3z6JL+kNCmMfBnXWaDb1f8lNoS4ZjOx8uov6qJco9fKMb6 s/q3c1fKZYiCY48jEGF2TrOpywIP8d8aSA8aTukyW3X+poZ20dbqV0kgZJ1NDyXtmHJt E5iQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=oNWUCGXL; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=IwubS1mZFPbIE8xN0VfDOR1ceqQunwRhk8XOtanDERw=; b=CVbQtzQnDXPvev3Pfq7tJvW8K7dDTdbG6MOiurY0pf1mzL/QWvalRWTfRoFndQJcum x1px+UDd7+u4lpkHRGRd8TRkECiD5jxJ6nQG5gfIxz3TLwAsQvX6Tb2nyIwqXETxALcj qCW1XlKBG432JyiHFicaZQM2cIoghzkl6kbtE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=IwubS1mZFPbIE8xN0VfDOR1ceqQunwRhk8XOtanDERw=; b=nCtk2QUTzeZsyi8d9dYCRXWvLTOLq+ulmuZhn4CL4l7MtVcNjDpWJxthRtQWR/d7I2 q+C4/XLW5G2mUsi1r/G6cUG1LQmiTS3JNxvxe4AwA9inP/DFA3C696eu4mUXAgrkV7Ar 5fBYhpRR81o0wx3yJRR5SN/gTlGTT6lDkwnEvP9GpRtU+NVd/bIvUYKVCqf9L84nC+Q8 R7QG3h/Xetb5puWoOQaqRO/7/22SgkK6tKo+CDevDDh/O8YekGxmrJlOklDbHgXpoX57 vd7vUe/97D1l4Pvp0fTQ9NaZ31rnx1H+BwiHYNkOX5+JIxtemUp3eVzxkruEFO0cgBK+ t08A== X-Gm-Message-State: APjAAAWRuU8WR2w8VAwU3R839WNkq+nWOq17xZNBkXWDc+6KxCHnvRSz AwtnhGOEe46ZtxLdNxitficwzGuh X-Google-Smtp-Source: APXvYqxR7mSz6yGqDKcZj8QPugKo0yFGDBl6bRQMNZoRrAklfdO89n441ca2L23zNnkfhOdQ4fBJzQ== X-Received: by 2002:a65:608a:: with SMTP id t10mr38636960pgu.125.1556213697768; Thu, 25 Apr 2019 10:34:57 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a63:ff24:: with SMTP id k36ls5690410pgi.2.gmail; Thu, 25 Apr 2019 10:34:57 -0700 (PDT) X-Received: by 2002:aa7:8dc2:: with SMTP id j2mr3185498pfr.82.1556213697389; Thu, 25 Apr 2019 10:34:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556213697; cv=none; d=google.com; s=arc-20160816; b=SF28/EibiVaEi/E0omuTtSkqtlXJoIP7UwPj8zEYjJSFGs4xTS5XMRRSHa/65xhsnf Fgq7aM7vNcHhEGjsqZ93KsnmVq0XyU3GtjNUpXWItYG16G3ljNgHsGVqIXwdY2L04Kf+ PVjPOjL8KQtcsCg8GQguzx1/hZpweNJ1G629qlXqySzUHJnzIc9d7DGdudcdrnPQcJ/w SFm1dRi4lqDxtsDrhU6+A2L6eTZIoE+fEHRnqOiQbN7LovrQ0U8kk/Byhb2bCJN+454X olc062SIQo6VgdoHF3ENYKhle5Tpwj9p7V7+Qq2dsf6L5t4AQE3U1OT+u1mGRxLWtlRg hWxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=r+v9pTUEzK82bdiFTgus9L7UjHVzZLDhVq3HmF1YZ9E=; b=N7xvV70djIml49JhgUIJ2GXYXkz2h/QMkNS8bqjOk+s3K3Ako/d1VFnjdYnWb3UuCK jRvpa6QOlikxLQEp4yWIo6zu59efbspIZbXIXlFCFdvQ60a2s366S4g2VPlu11ZK1gL2 AkuNfy7rfTKRFP4jmtFgLSsdYxXoJWfqL8pCdKnT9npPGPBiFYBY7wN08dWRvVM4bY/s KbwG5Py0171rjYni7I8FUoUrf/3mjo97rvHMJ1hWhOpJrqE2/WHZEAYVwNLCaW3QHun0 lVDPD/BSCKX1ns5jDqSpiGQ10dNRZtjrOqZtTARAIYwt3anyJpr6OPXXli6aCqoVUDHJ 80OA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=oNWUCGXL; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id o23sor25904535pfi.26.2019.04.25.10.34.57 for <linux-amarula@amarulasolutions.com> (Google Transport Security); Thu, 25 Apr 2019 10:34:57 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; X-Received: by 2002:a62:5185:: with SMTP id f127mr41888625pfb.199.1556213697063; Thu, 25 Apr 2019 10:34:57 -0700 (PDT) Received: from localhost.localdomain ([115.97.185.144]) by smtp.gmail.com with ESMTPSA id i3sm38265876pgl.57.2019.04.25.10.34.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Apr 2019 10:34:56 -0700 (PDT) From: Jagan Teki <jagan@amarulasolutions.com> To: Simon Glass <sjg@chromium.org>, Philipp Tomsich <philipp.tomsich@theobroma-systems.com>, Kever Yang <kever.yang@rock-chips.com>, Akash Gajjar <akash@openedev.com> Cc: Paul Kocialkowski <paul.kocialkowski@bootlin.com>, linux-rockchip@lists.infradead.org, linux-amarula@amarulasolutions.com, u-boot@lists.denx.de, Jagan Teki <jagan@amarulasolutions.com> Subject: [PATCH v3 03/13] rockchip: dts: rk3399: Create initial rk3399-u-boot.dtsi Date: Thu, 25 Apr 2019 23:04:17 +0530 Message-Id: <20190425173427.13445-4-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20190425173427.13445-1-jagan@amarulasolutions.com> References: <20190425173427.13445-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=oNWUCGXL; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: <linux-amarula.amarulasolutions.com> X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>, <mailto:linux-amarula@amarulasolutions.com> List-Help: <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>, <mailto:linux-amarula+help@amarulasolutions.com> List-Archive: <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/> List-Unsubscribe: <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>, <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe> |
| Series |
rockchip: Add new rk3399 boards
|
|
Commit Message
Jagan Teki
April 25, 2019, 5:34 p.m. UTC
u-boot,dm-pre-reloc is required for SDMMC booted rk3399 boards and which is U-Boot specific devicetrees binding. Move it on global rk3399-u-boot.dtsi file and rest of the U-Boot bindings will move it future based on the requirement. This would help to sync the devicetrees from Linux whenever required instead of adding specific nodes. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> --- arch/arm/dts/rk3399-evb.dts | 1 - arch/arm/dts/rk3399-firefly.dts | 1 - arch/arm/dts/rk3399-puma.dtsi | 1 - arch/arm/dts/rk3399-u-boot.dtsi | 8 ++++++++ 4 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 arch/arm/dts/rk3399-u-boot.dtsi
Comments
On Thu, Apr 25, 2019 at 11:04 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > u-boot,dm-pre-reloc is required for SDMMC booted rk3399 boards and > which is U-Boot specific devicetrees binding. > > Move it on global rk3399-u-boot.dtsi file and rest of the U-Boot > bindings will move it future based on the requirement. > > This would help to sync the devicetrees from Linux whenever required > instead of adding specific nodes. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > --- > arch/arm/dts/rk3399-evb.dts | 1 - > arch/arm/dts/rk3399-firefly.dts | 1 - > arch/arm/dts/rk3399-puma.dtsi | 1 - > arch/arm/dts/rk3399-u-boot.dtsi | 8 ++++++++ > 4 files changed, 8 insertions(+), 3 deletions(-) > create mode 100644 arch/arm/dts/rk3399-u-boot.dtsi > > diff --git a/arch/arm/dts/rk3399-evb.dts b/arch/arm/dts/rk3399-evb.dts > index ce004d0d18..9162f3dd50 100644 > --- a/arch/arm/dts/rk3399-evb.dts > +++ b/arch/arm/dts/rk3399-evb.dts > @@ -155,7 +155,6 @@ > }; > > &sdmmc { > - u-boot,dm-pre-reloc; > bus-width = <4>; > status = "okay"; > }; > diff --git a/arch/arm/dts/rk3399-firefly.dts b/arch/arm/dts/rk3399-firefly.dts > index f90e7e88db..46f2ffaf8d 100644 > --- a/arch/arm/dts/rk3399-firefly.dts > +++ b/arch/arm/dts/rk3399-firefly.dts > @@ -592,7 +592,6 @@ > }; > > &sdmmc { > - u-boot,dm-pre-reloc; > bus-width = <4>; > status = "okay"; > }; > diff --git a/arch/arm/dts/rk3399-puma.dtsi b/arch/arm/dts/rk3399-puma.dtsi > index 8304f67192..9049694243 100644 > --- a/arch/arm/dts/rk3399-puma.dtsi > +++ b/arch/arm/dts/rk3399-puma.dtsi > @@ -492,7 +492,6 @@ > }; > > &sdmmc { > - u-boot,dm-pre-reloc; We need to explicitly include rk3399-u-boot.dtsi to these files since the SoC name is rockchip, I'm sending other series for these changes. and I have send v3.1 patches for only this change [1] and rest unchanged. Sorry for not noticing before. [1] https://patchwork.ozlabs.org/patch/1091534/
Hi, On Fri, 2019-04-26 at 18:51 +0530, Jagan Teki wrote: > On Thu, Apr 25, 2019 at 11:04 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > u-boot,dm-pre-reloc is required for SDMMC booted rk3399 boards and > > which is U-Boot specific devicetrees binding. > > > > Move it on global rk3399-u-boot.dtsi file and rest of the U-Boot > > bindings will move it future based on the requirement. > > > > This would help to sync the devicetrees from Linux whenever required > > instead of adding specific nodes. > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > > --- > > arch/arm/dts/rk3399-evb.dts | 1 - > > arch/arm/dts/rk3399-firefly.dts | 1 - > > arch/arm/dts/rk3399-puma.dtsi | 1 - > > arch/arm/dts/rk3399-u-boot.dtsi | 8 ++++++++ > > 4 files changed, 8 insertions(+), 3 deletions(-) > > create mode 100644 arch/arm/dts/rk3399-u-boot.dtsi > > > > diff --git a/arch/arm/dts/rk3399-evb.dts b/arch/arm/dts/rk3399-evb.dts > > index ce004d0d18..9162f3dd50 100644 > > --- a/arch/arm/dts/rk3399-evb.dts > > +++ b/arch/arm/dts/rk3399-evb.dts > > @@ -155,7 +155,6 @@ > > }; > > > > &sdmmc { > > - u-boot,dm-pre-reloc; > > bus-width = <4>; > > status = "okay"; > > }; > > diff --git a/arch/arm/dts/rk3399-firefly.dts b/arch/arm/dts/rk3399-firefly.dts > > index f90e7e88db..46f2ffaf8d 100644 > > --- a/arch/arm/dts/rk3399-firefly.dts > > +++ b/arch/arm/dts/rk3399-firefly.dts > > @@ -592,7 +592,6 @@ > > }; > > > > &sdmmc { > > - u-boot,dm-pre-reloc; > > bus-width = <4>; > > status = "okay"; > > }; > > diff --git a/arch/arm/dts/rk3399-puma.dtsi b/arch/arm/dts/rk3399-puma.dtsi > > index 8304f67192..9049694243 100644 > > --- a/arch/arm/dts/rk3399-puma.dtsi > > +++ b/arch/arm/dts/rk3399-puma.dtsi > > @@ -492,7 +492,6 @@ > > }; > > > > &sdmmc { > > - u-boot,dm-pre-reloc; > > We need to explicitly include rk3399-u-boot.dtsi to these files since > the SoC name is rockchip, I'm sending other series for these changes. > and I have send v3.1 patches for only this change [1] and rest > unchanged. Does this mean that the rk3399-u-boot.dtsi file won't be auto-included from the boards dtsi? If so, we should probably create -u-boot.dtsi files for each device, to include rk3399-u-boot.dtsi. Cheers, Paul > Sorry for not noticing before. > > [1] https://patchwork.ozlabs.org/patch/1091534/
diff --git a/arch/arm/dts/rk3399-evb.dts b/arch/arm/dts/rk3399-evb.dts index ce004d0d18..9162f3dd50 100644 --- a/arch/arm/dts/rk3399-evb.dts +++ b/arch/arm/dts/rk3399-evb.dts @@ -155,7 +155,6 @@ }; &sdmmc { - u-boot,dm-pre-reloc; bus-width = <4>; status = "okay"; }; diff --git a/arch/arm/dts/rk3399-firefly.dts b/arch/arm/dts/rk3399-firefly.dts index f90e7e88db..46f2ffaf8d 100644 --- a/arch/arm/dts/rk3399-firefly.dts +++ b/arch/arm/dts/rk3399-firefly.dts @@ -592,7 +592,6 @@ }; &sdmmc { - u-boot,dm-pre-reloc; bus-width = <4>; status = "okay"; }; diff --git a/arch/arm/dts/rk3399-puma.dtsi b/arch/arm/dts/rk3399-puma.dtsi index 8304f67192..9049694243 100644 --- a/arch/arm/dts/rk3399-puma.dtsi +++ b/arch/arm/dts/rk3399-puma.dtsi @@ -492,7 +492,6 @@ }; &sdmmc { - u-boot,dm-pre-reloc; clock-frequency = <150000000>; max-frequency = <40000000>; supports-sd; diff --git a/arch/arm/dts/rk3399-u-boot.dtsi b/arch/arm/dts/rk3399-u-boot.dtsi new file mode 100644 index 0000000000..f533ed95eb --- /dev/null +++ b/arch/arm/dts/rk3399-u-boot.dtsi @@ -0,0 +1,8 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright (C) 2019 Jagan Teki <jagan@amarulasolutions.com> + */ + +&sdmmc { + u-boot,dm-pre-reloc; +};