diff mbox series

[2/2] mtd: spi-nor-ids: Enable 4B_OPCODES for is25wp256

Message ID 20200420100607.23009-2-jagan@amarulasolutions.com
State New
Headers
Series [1/2] mtd: spi-nor: Enable QE bit for ISSI flash |

Commit Message

Jagan Teki April 20, 2020, 10:06 a.m. UTC 
IS25WP256 flash chips do support 4byte address opcodes,
so enable support for it.

Cc: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/mtd/spi/spi-nor-ids.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Sagar Kadam April 20, 2020, 4:31 p.m. UTC | #1 
Hi Jagan,

> -----Original Message-----
> From: Jagan Teki <jagan@amarulasolutions.com>
> Sent: Monday, April 20, 2020 3:36 PM
> To: Vignesh R <vigneshr@ti.com>; u-boot@lists.denx.de
> Cc: Bin Meng <bmeng.cn@gmail.com>; linux-
> amarula@amarulasolutions.com; Jagan Teki
> <jagan@amarulasolutions.com>; Sagar Kadam <sagar.kadam@sifive.com>
> Subject: [PATCH 2/2] mtd: spi-nor-ids: Enable 4B_OPCODES for is25wp256
> 
> [External Email] Do not click links or attachments unless you recognize the
> sender and know the content is safe
> 
> IS25WP256 flash chips do support 4byte address opcodes,
> so enable support for it.
> 
> Cc: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>  drivers/mtd/spi/spi-nor-ids.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index 973b6f86c9..f95bfb59e6 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -135,7 +135,8 @@ const struct flash_info spi_nor_ids[] = {
>         { INFO("is25wp128",  0x9d7018, 0, 64 * 1024, 256,
>                         SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>         { INFO("is25wp256",  0x9d7019, 0, 64 * 1024, 512,
> -                       SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> +                       SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                       SPI_NOR_4B_OPCODES) },

Looks good thanks for including.

Reviewed-by: Sagar Kadam <sagar.kadam@sifive.com>

Thanks & BR,
Sagar Kadam

>  #endif
>  #ifdef CONFIG_SPI_FLASH_MACRONIX       /* MACRONIX */
>         /* Macronix */
> --
> 2.17.1
diff mbox series

Patch

diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
index 973b6f86c9..f95bfb59e6 100644
--- a/drivers/mtd/spi/spi-nor-ids.c
+++ b/drivers/mtd/spi/spi-nor-ids.c
@@ -135,7 +135,8 @@  const struct flash_info spi_nor_ids[] = {
 	{ INFO("is25wp128",  0x9d7018, 0, 64 * 1024, 256,
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ INFO("is25wp256",  0x9d7019, 0, 64 * 1024, 512,
-			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			SPI_NOR_4B_OPCODES) },
 #endif
 #ifdef CONFIG_SPI_FLASH_MACRONIX	/* MACRONIX */
 	/* Macronix */