From patchwork Fri Oct 2 09:49:31 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roman_Smr=C5=BE?= X-Patchwork-Id: 4869 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id F2A773F0B7 for ; Fri, 2 Oct 2026 11:49:49 +0200 (CEST) Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4a01eb045fesf18426975e9.1 for ; Fri, 02 Oct 2026 02:49:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1790934589; cv=pass; d=google.com; s=arc-20260327; b=GODVyNrrvG7WQkXTxlgPM2FS8weTzIwU3zGP4eVFQ7UFMAfi0svXMEfvM+2sXXHSDT Cq5paApepSVljko5J1hCdHNG+vSXItd2/AgwDOnrbIKbBDy5Eu0TKi6Fj3WjQfvAx08t qdouV5uHJNA7JQtv//xNKpJhnsfLAKf9Vfz2Z4JHYCDf/Y34h3YODO78FUW8b3q/krm+ A5wxhp/11JSk5/GZnzS4CuPtzn254RdqbAHg5BaayZljJNAZhvfAPc7FJ/fwsBSPqozw asQH9xhILTS/rs2364JIetOTaQFBAU8dE4OSqx46fr5wJaOlz/qbtHgU6R1SH0S7EHoG /FMQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=98uJi4x4gVUw2PfMGKj7mIKwiVNB6l9fSK9aYnHZ6kw=; fh=LRmAw+eFnwJvjewMwJEDwlJbz9hooRcN9TYB9evyVgo=; b=FNmXHkK/3RFbmEeYjFmyUysQ3eNtd2znG4+TN93DSDzl5gEmNwL8GJlXRXkfUCmXrd M63y6nAypY5AlJwE0eGuDdooKWd1pfMwYJi4BfXujQPl6QFLS2ugTZ4yEHFmug61eTqM YY6+zzKyn84wQmN/EKTMTub/I+yLNFYgyXQB/L8NeLoyu6pO3kIULtp3mBRKzVlvz1T4 ilZCNN6aC7dINWctNjwSsc8h0VbismThvgU/aPHEd6LK48t9VQT9yb09Vj1GRRUjXKJX SA2q1adIkoQY5XCnNA8DnT7+hxnm0KwX8UC/w6+N7Ll33X8GmmsWlFoo3gITBjCArV8v ATxg==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="Vr49/3JU"; spf=pass (google.com: domain of roman@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=roman@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1790934589; x=1791539389; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:cc:to:in-reply-to:references:message-id :content-transfer-encoding:content-type:mime-version:subject:date :from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=98uJi4x4gVUw2PfMGKj7mIKwiVNB6l9fSK9aYnHZ6kw=; b=AOwP8YmRUs9ZC/RxuZX/S7C7WBEM/F3KKRC2gHpZAXfpx2mcXWVYO2XjrdlvAfW3qg X1skVEZw6hwGbWxJi9TWgo9tdh8Rc2oKX97BuX0rg+FH4Yv5SQ4PCbJHp6fp9CCNS7WB qOxKg9z404g+jBM0aVivCKdD/pHJ+mDkfS6E8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790934589; x=1791539389; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:cc:to :in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg:x-beenthere :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=98uJi4x4gVUw2PfMGKj7mIKwiVNB6l9fSK9aYnHZ6kw=; b=fK/+OilcOXCCJtgcd+Z1l5Mhzz+LKXOGOie23VStVKZSCQx8HwWRDz+3jonbaC/1F8 WCzE9xc3s0tKT2+yT/eCBVTJHPMwT27862Qod0NQ41U8uxFKGw3owgX65lIPvTJGQ4K2 IhBGG6JVPkDgQFYKLMEe7Ev8RVjPd2UTnKxi3JdNHXPbRi9QZXX6+rXH8dp5ZJjHv3ul hPbYhidBPD8TZW69E8JmY9LvVbRFgfrDOaExnoF9N0IMrpmCk1+eyLvZ4ccZZimOUovk Zv2HLJkqXn4kYsDfHcZvIT3jTRhgUwxD7bQIkSyYZENk1vLfpeuLJeh1IutxIKU9JU6P Z0YQ== X-Forwarded-Encrypted: i=2; AKwUvBypqDKJ9mVPq1VAmDABBiX8AdcQ7/gV8JPsex6fS0tu3ZBdzOP6H5dk34FyU2QLo8ZCWRLQq8frwxgJqhYN@patchwork.amarulasolutions.com X-Gm-Message-State: AFuF++no+fwgUuyQQWsZqBMIB8aWm+thxtyYb39emI+AlIfEz4F6MKnc UzwsgC4n6h14qk/YFz1bbU7SOJ/oeC/wzc35AQzaY8aE75Z/dtD2owcRuyycfprMZ8quiA== X-Received: by 2002:a05:600c:19c8:b0:49e:7a00:b9a5 with SMTP id 5b1f17b1804b1-4a02752340emr42498275e9.4.1790934589686; Fri, 02 Oct 2026 02:49:49 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h="ATskLdfHY8oZY7S8W59x+K//ScuUO0gNFjwbBaZ50mkS42a44Q==" Received: by 2002:a05:600c:3b9d:b0:49f:ff6b:bc53 with SMTP id 5b1f17b1804b1-4a0285226abls9367425e9.0.-pod-prod-08-eu; Fri, 02 Oct 2026 02:49:48 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBwPoR6Ub3XFe/SCzC32CUy5scNhgihUhgwjtlsB2/4sSTMrfop1venDaFVVGqkEIR5v1v9sPrheIwBO/h+3@amarulasolutions.com X-Received: by 2002:a05:600c:3b21:b0:49f:cac3:c68a with SMTP id 5b1f17b1804b1-4a0276f090bmr40607825e9.31.1790934588006; Fri, 02 Oct 2026 02:49:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1790934588; cv=none; d=google.com; s=arc-20260327; b=Vxwj2nDEyoQnO2ZGpAwLt+M2+yy7s5bkyCWDHYoP+94GVt+yzsEKLU/e+C1/wYMfBj ijroKhYMD7CD9iPWuDS6H3fRL3BTjJl0nTGvtceTXf/xHMY23wb+5aFhEvKZGmkCP0+4 uWXWF5DeKoRb6rRz1TFrhjyEqFopQArRtXEJECjtPYv0Yg/YkQ9PvZVEMHMfohrbOdbH IP+qPSEVHgzRdFtLShqbkYg7LP8h+1rogGYSYuNgqd5bF7I8yxwg5RC1G/aYhgbHOscG u3QZnEhE/WejI8KIMXwc3dGwO8xVPJhqf9l+aOZA5oEXyLsgw8UCvcWrTBXn14EK1YBX c/1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=x+lEaq8UIfWxZ/tIjV0SG6p5OStGVbQ7BX4PDBI90Lg=; fh=Vz43ORa96qtSuv30xGM2PdYpR7KwEgZm/kiacrEnAbE=; b=GJ4oPGMA2Oxw3/vYDUyaYlLSZA2+c62f8MNpmMKkOLxfmasq45YbRJeRzJSQxDZCEC o6l2V9t5Mlqc+5ruJU2KT8Oz37ZGpZjpeBM5fcnPn9GkUakvhZqR9eZlNX8a2YZznSwF fQFUOWUnESZ/46dEvznajO/9d6XsY1UIPH0LK5Do1p+CaFvASCOxd7MRpqhKjsapjUse l34XY6d8e3N4GEi8v9iwEW8LeX6S8r3RLt9SOxEvMmHFQkonMBmHlEZ/lPSNehQS4VQ/ QXjeM7W7287lCy2lKXwz2hJ7A1Vga/OAzuxlD0L4E0hCxDIsn4rDfr1pcDEtsERfAsa1 sf6w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="Vr49/3JU"; spf=pass (google.com: domain of roman@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=roman@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 5b1f17b1804b1-4a0282f375asor2922025e9.15.2026.10.02.02.49.47 for (Google Transport Security); Fri, 02 Oct 2026 02:49:47 -0700 (PDT) Received-SPF: pass (google.com: domain of roman@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AKwUvBxUdQQebzIjxxIknD+DnVJM9L4+Cw3acMeSqpm3XCm+JllpEmqVtfAh4UPyO/RRafpZMtyrO9qjNDAiv9ue@amarulasolutions.com X-Gm-Gg: AYBFou0u9lAOGQGM7d+acX/57lnCtriiHF9yAJkilXP65A7SZR01enw1rL4aWqzQKWQ IoRIUDN0KyVIAldTwDuaTZSLcYGO9R2Zba1AdHGT8uFW7hvXa/F+ZCjvv/GMfVrnp5YegQVDNnE DxL6poq7DDg9XDeFs0Ezs9O8z16LUlnuTBX237FfwSq0/1vQlo3B2NZzrCLjjYB0qFZ5kJ/MW0I cK5FJlhnXrgvBezEZRUlgpnvYZ4TRg1ZKSFEXt/HYAkMroQhOkK6C3YU8eDkFCEFydmgQDVTV6A oPEJUBwUrUrcq3Dvn93e5wnLsv8SVrleX3PvBU6y2dDxfvkFWz+CIT/N7D7KFEB2phT5ls43h6u A0IHA7xTjZ4FgyNezlnQST7Azq8mBFsDmFzRBWE//bTaALH1F3lpVyG1k9fnT0GdAASV7pMHg4Y KM4ovrVYEeHJbqvokbGopAWmHsCC6yuR1sNWpCiv3M5cixNVHFKDLPX3jBLTt3kiAIR9t5T8LMS fY= X-Received: by 2002:a05:600c:1d09:b0:4a0:37d:9e21 with SMTP id 5b1f17b1804b1-4a0276ed19amr37928025e9.29.1790934587622; Fri, 02 Oct 2026 02:49:47 -0700 (PDT) Received: from localhost ([93.90.163.238]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a039505568sm52146605e9.3.2026.10.02.02.49.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2026 02:49:47 -0700 (PDT) From: =?utf-8?q?Roman_Smr=C5=BE?= Date: Fri, 02 Oct 2026 11:49:31 +0200 Subject: [PATCH 2/5] ASoC: pcm179x: Refactor regmap value lookup MIME-Version: 1.0 Message-Id: <20261002-work-v1-2-f0e53bc7331f@amarulasolutions.com> References: <20261002-work-v1-0-f0e53bc7331f@amarulasolutions.com> In-Reply-To: <20261002-work-v1-0-f0e53bc7331f@amarulasolutions.com> To: =?utf-8?q?Martin_Povi=C5=A1er?= , Lars-Peter Clausen , =?utf-8?q?Nuno_S=C3=A1?= , Peter Rosin , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , Jaroslav Kysela , Takashi Iwai Cc: patches@opensource.cirrus.com, linux-sound@vger.kernel.org, asahi@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Roman_Smr=C5=BE?= , linux-amarula@amarulasolutions.com X-Mailer: b4 0.15.2 X-Original-Sender: roman@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="Vr49/3JU"; spf=pass (google.com: domain of roman@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=roman@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Use a table lookup to find values for fmt register instead of switch statements to prepare for additional codec variants of the same family. Signed-off-by: Roman Smrž --- sound/soc/codecs/pcm179x.c | 60 +++++++++++++++++++++++----------------------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/sound/soc/codecs/pcm179x.c b/sound/soc/codecs/pcm179x.c index cb70927872aa..61b87dab3266 100644 --- a/sound/soc/codecs/pcm179x.c +++ b/sound/soc/codecs/pcm179x.c @@ -65,6 +65,31 @@ struct pcm179x_private { unsigned int rate; }; +struct pcm179x_fmt_table { + unsigned int fmt; /* SND_SOC_DAIFMT_* */ + unsigned int width; /* sample width in bits */ + unsigned int value; /* FMT[2:0] */ +}; + +static const struct pcm179x_fmt_table pcm1792a_fmt[] = { + { SND_SOC_DAIFMT_RIGHT_J, 16, 0 }, + { SND_SOC_DAIFMT_RIGHT_J, 24, 2 }, + { SND_SOC_DAIFMT_RIGHT_J, 32, 2 }, + { SND_SOC_DAIFMT_I2S, 16, 4 }, + { SND_SOC_DAIFMT_I2S, 24, 5 }, + { SND_SOC_DAIFMT_I2S, 32, 5 }, +}; + +static int pcm179x_fmt_value(struct pcm179x_private *priv, unsigned int fmt, + unsigned int width) +{ + for (unsigned int i = 0; i < ARRAY_SIZE(pcm1792a_fmt); i++) + if (pcm1792a_fmt[i].fmt == fmt && pcm1792a_fmt[i].width == width) + return pcm1792a_fmt[i].value; + + return -EINVAL; +} + static int pcm179x_set_dai_fmt(struct snd_soc_dai *codec_dai, unsigned int format) { @@ -96,40 +121,15 @@ static int pcm179x_hw_params(struct snd_pcm_substream *substream, { struct snd_soc_component *component = dai->component; struct pcm179x_private *priv = snd_soc_component_get_drvdata(component); - int val = 0, ret; + int val, ret; priv->rate = params_rate(params); - switch (priv->format & SND_SOC_DAIFMT_FORMAT_MASK) { - case SND_SOC_DAIFMT_RIGHT_J: - switch (params_width(params)) { - case 24: - case 32: - val = 2; - break; - case 16: - val = 0; - break; - default: - return -EINVAL; - } - break; - case SND_SOC_DAIFMT_I2S: - switch (params_width(params)) { - case 24: - case 32: - val = 5; - break; - case 16: - val = 4; - break; - default: - return -EINVAL; - } - break; - default: + val = pcm179x_fmt_value(priv, priv->format & SND_SOC_DAIFMT_FORMAT_MASK, + params_width(params)); + if (val < 0) { dev_err(component->dev, "Invalid DAI format\n"); - return -EINVAL; + return val; } val = val << PCM179X_FMT_SHIFT | PCM179X_ATLD_ENABLE;