From patchwork Fri Oct 16 10:33:55 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roman_Smr=C5=BE?= X-Patchwork-Id: 4878 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id EDA093F0B7 for ; Fri, 16 Oct 2026 12:34:19 +0200 (CEST) Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4a0284121c6sf23054085e9.3 for ; Fri, 16 Oct 2026 03:34:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1792146859; cv=pass; d=google.com; s=arc-20260327; b=h01xgVpDrIDUO2Uoc3fxrxrOIZv+T7LZrCpMttbFdDc+HfsqJ2axUlEfWetRK9ugbZ F/1reUk83uWFLGcUZsWZWJQQXOFVuADw1xxANOsmwOXZh6NXdsLFaIIdDjzJ2KFEpLTW lTRrpwU7o1+jyh4dR6FIWx+q1tP/MrYNmPPSZHOLsVwWt+SCHXkyl2kB5DBphQFFKrhv dpQvwv7KP2848TPLrovWEDHSlm5MuIX3dn+9gX6IMTntazlcxnmWJ93Hxmt+kWg56ixA 0DJkBExelhuy7CQ1wBU6mnXYmZhj+y8rIgVbYRwZTfLqyUBvi7BIDMvrELaQ2hmnxYkK YeAg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=98uJi4x4gVUw2PfMGKj7mIKwiVNB6l9fSK9aYnHZ6kw=; fh=FGwdxSjXF+CRGtX37aAEQCEwQV/egvCs/ZusSyOcNfc=; b=l1E8i0PTJXfOxC+VW3MtAYkQgilkABL3O1LZHfaWd8qaLcmNDPiTlZN6skaCzjgYGe RL90wGM7/BFGHNVbYmi4kjw12IKCZ47qm06sWh7UgcXyjNrNe8pvLztXpotVcDuzaa7M dMVEdHpRQuAl2YvE7w4Uek2TV5itgEK3RSdkdnHFeQ2G44I96oYn465khN92gH4xXSui G/GOth2Jle03hY+sE/J19/XsC8a6kiAjzRxwLFFr3kqVotnm3JHTw2S4r5WmplDrq3JD 4+TvqbyO2QGCZ18vGJXlg3Fuqga/lhpne1JiF1cWvc8P/KFscmOBM6AgKuArqF4t4E+P FQYQ==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=SvWmK6GA; spf=pass (google.com: domain of roman@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=roman@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1792146859; x=1792751659; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:cc:to:in-reply-to:references:message-id :content-transfer-encoding:content-type:mime-version:subject:date :from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=98uJi4x4gVUw2PfMGKj7mIKwiVNB6l9fSK9aYnHZ6kw=; b=lJ/KPg3+br1HL1e5tIxyQYpkhtyqrC8kkn1nuZNxzDN/CSXZLP5/LOjYo+3MmnOAjX zFcauLn+pygJXfz3wbdqN1JZJGfpg7Eprw7wjpW3EE+bsbMcmPfIzLtX5HJd05OPBQ95 fEuAxnBmGXDPUGN96v/kh7I9zFf3vVzVaArQo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792146859; x=1792751659; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:cc:to :in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg:x-beenthere :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=98uJi4x4gVUw2PfMGKj7mIKwiVNB6l9fSK9aYnHZ6kw=; b=DgwL4AHhAH6fejFZmPJHp46yb6HC8zyKcbG+2OOwutwzh82FE3sRBOIDHLiZEh7lxR 3vo3bJpMOnXAcE29zsoZR4wLjICbHi83hG/LTgqSsOggdk0eAIx2PDkZ/1vkj+N/ss9P jeRo56ilPBLWtv7XaPwdKQHzCkczVn1sEfJFICtlZdYUqU/ewrN04IB+YBO/smJobmRv FlLooGiR1LzmWs+ynzJ4YTctFRvwDSetQ7ZZ8Lle+5M87rrtPzum11PTHJLq2dmalfI7 uLVNlhgHsXmZucp/pjqAdUQnThK0UTj6qp9znpTTaz4UOYPAkNM/+iREqfdzslBx7Zya TENg== X-Forwarded-Encrypted: i=2; AKwUvByzlbS6VkTRI/vVxRmdPaMHZwFV2iviBgILoQzYN/YJnQw8fxqhiHWavgFNe+aI4/5jI3OmZPrl94hIx5Ca@patchwork.amarulasolutions.com X-Gm-Message-State: AFq9FYKlP8JCV7xYvLmv0fJiDcU8FEOVZQxAjsiarNIJPa6aBbNX2aUO wEFWvbS6W77Wt7WMzwy9bWv7TfKZhFg0UGX+KLDm2oKUZyJYbHNoEq01Py9vDka10W2KzQ== X-Received: by 2002:a05:600c:4e89:b0:4a0:12d7:4c88 with SMTP id 5b1f17b1804b1-4a18e4ac77amr490915945e9.30.1792146859619; Fri, 16 Oct 2026 03:34:19 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h="ATskLddcXtWuiuHyHkxc8C8BzlNg8jQrOJpHbEliIaH4yQsb3w==" Received: by 2002:a05:600c:c172:b0:4a1:7c7d:8876 with SMTP id 5b1f17b1804b1-4a1c78fc674ls6378805e9.2.-pod-prod-08-eu; Fri, 16 Oct 2026 03:34:18 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBy4tSoFmHy/0skuM5nKRaFf9jcAgPUAoncInS8oQHGpJHS7oha4YXmKUPDYOsoBKTMceLuwcpFo0VKnlg+5@amarulasolutions.com X-Received: by 2002:a05:600c:8509:b0:4a1:7d9b:d4ae with SMTP id 5b1f17b1804b1-4a18e47a8cdmr426097675e9.5.1792146857963; Fri, 16 Oct 2026 03:34:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1792146857; cv=none; d=google.com; s=arc-20260327; b=Ut9UbCPXUA4NvNehduFoXNOrpzihwGq8AAJYvctP1Aa5Xd+FFNyb6x/G71Bu4QpVl9 8vOuNUMfv5Q0S6KK6KtGUYFmRu7ce/+yntxuMI5HdUDbyfxNKpchjxDOZmvcY9+jPMdk 0L1ym6N0N8i1b+DeTW9XzO5k8lAc0DAolipyDEQ9Aw9KBJrkuK9Efx5Yf2Rhc8Kyt5UM 3UFr0eMlmlvxqabo005VG1KoBGEDQofDzHiO1XbEye+yV+6OYx0EAXgybd1wNu8T/qdl 7SriJxD2YpRhF157+kWW6gMVPkZE2BmEW5MR7+2QF0eBRAjahtj+QRNoMKQ9rM1T/KAM Z7nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=x+lEaq8UIfWxZ/tIjV0SG6p5OStGVbQ7BX4PDBI90Lg=; fh=g+dYJh5YCj0d6NgqUI+zo1B6C9O54NTHfNfyCQHv/eg=; b=K/Pgl+EGyesU1bFQtBOrfTWwRl9vrbxRcTlTPZNLX8afwibXPNrVz2ZVgyG0mV4Lwf b7NigbxJaQ0IsbAjxM0+48TqpHJvwKHRhz2uy4cUV5vJCmEfs2O1aYNyWZCOqTSTuvLr M7H+OG93JQKr9yMqCzJoWLxUCqJdOm6pU4Xf5wQIPU+Km5lgOnfmgQPk/JrNsMqaAFC4 S6obokUhkvRm5UhlILChcHbBC7A71dYN2l4VbUxQKg7sCWyRXFQ+R+bDH3nKwDqj/6fw UadYxhvvA4UjMAOx9JgtGQ66rzbfp+8qF16I7bxasZ6QaeQbOXpcTcIfnzl+WMAIU6jM ggvw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=SvWmK6GA; spf=pass (google.com: domain of roman@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=roman@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ffacd0b85a97d-48dfd4d127bsor320921f8f.9.2026.10.16.03.34.17 for (Google Transport Security); Fri, 16 Oct 2026 03:34:17 -0700 (PDT) Received-SPF: pass (google.com: domain of roman@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AKwUvBxnVAVyEfsZcUtDoh2eNh1jta5PVDzoXdU6CqFc7oUbCPxBDmVCqFxpyP8GQ7Pbc4bf/PTcFlucB6qc+COu@amarulasolutions.com X-Gm-Gg: AYBFou3K45TTGpUrKI92kjJ26zQj/PEr1tyXgB0htBpO4TkMPKmfZMuKXfZ96xN4gRC 1nrGqU8EW2BWursodD47n1Hqm+BOu8uM7OI00whmjCoDApIIpxa9TSF6wVS5g4/fHI8P0BKq2D7 Td0lB9ZWS+7D9PQw3JWqu2FzM6MtGctSsbBwBB9MZXuj5wwA+V2zMpzsykmEXeEzXoUKIwM7JOk oXuF9Divy5NK8KnVw4Oaicrs2sJYTZtr3YKeokl4A0IIgJJktTzOQt5XqWeZqmZib7vB2g8UKAb oXuA+wTb+imyeeIC/dksf5O+zBlO9R4WMIgiCGVbwDRQZHYuL+Fa4U2MgnQoroZkvuKBfIKuaKi W7gFW8bqyHru9nnNCVWSGY0EmbMBfmH7YVEk7jN9doM4LcdnJ5IVw+zcPdYpNaAgzJTdaSUAZfW b3fNDBieQRcdUCGs5b/Sg9hDZPh8pt8qjIhgQCNZ+Rn31HCRMlEKobeT65qxLG6qMLJuAbjZ28T erWZzUV0EJIEdGu9NRhEA9ewdrGXAl0QPfQviEgQ8KRrC2B+HYEZSs= X-Received: by 2002:a05:6000:2905:b0:48c:6d9d:9f90 with SMTP id ffacd0b85a97d-48dba9d0b47mr43566956f8f.26.1792146856850; Fri, 16 Oct 2026 03:34:16 -0700 (PDT) Received: from localhost (dynamic-2a00-1028-8382-0206-0000-0000-0000-0bc0.ipv6.o2.cz. [2a00:1028:8382:206::bc0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48dfd503862sm4154979f8f.46.2026.10.16.03.34.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2026 03:34:16 -0700 (PDT) From: =?utf-8?q?Roman_Smr=C5=BE?= Date: Fri, 16 Oct 2026 12:33:55 +0200 Subject: [PATCH v2 2/5] ASoC: pcm179x: Refactor regmap value lookup MIME-Version: 1.0 Message-Id: <20261016-work-v2-2-9340b9555fbb@amarulasolutions.com> References: <20261016-work-v2-0-9340b9555fbb@amarulasolutions.com> In-Reply-To: <20261016-work-v2-0-9340b9555fbb@amarulasolutions.com> To: Peter Rosin , =?utf-8?q?Martin_Povi=C5=A1er?= , Lars-Peter Clausen , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , Jaroslav Kysela , Takashi Iwai Cc: asahi@lists.linux.dev, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com, =?utf-8?q?Roman_Smr=C5=BE?= X-Mailer: b4 0.16.0 X-Original-Sender: roman@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=SvWmK6GA; spf=pass (google.com: domain of roman@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=roman@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Use a table lookup to find values for fmt register instead of switch statements to prepare for additional codec variants of the same family. Signed-off-by: Roman Smrž --- sound/soc/codecs/pcm179x.c | 60 +++++++++++++++++++++++----------------------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/sound/soc/codecs/pcm179x.c b/sound/soc/codecs/pcm179x.c index cb70927872aa..61b87dab3266 100644 --- a/sound/soc/codecs/pcm179x.c +++ b/sound/soc/codecs/pcm179x.c @@ -65,6 +65,31 @@ struct pcm179x_private { unsigned int rate; }; +struct pcm179x_fmt_table { + unsigned int fmt; /* SND_SOC_DAIFMT_* */ + unsigned int width; /* sample width in bits */ + unsigned int value; /* FMT[2:0] */ +}; + +static const struct pcm179x_fmt_table pcm1792a_fmt[] = { + { SND_SOC_DAIFMT_RIGHT_J, 16, 0 }, + { SND_SOC_DAIFMT_RIGHT_J, 24, 2 }, + { SND_SOC_DAIFMT_RIGHT_J, 32, 2 }, + { SND_SOC_DAIFMT_I2S, 16, 4 }, + { SND_SOC_DAIFMT_I2S, 24, 5 }, + { SND_SOC_DAIFMT_I2S, 32, 5 }, +}; + +static int pcm179x_fmt_value(struct pcm179x_private *priv, unsigned int fmt, + unsigned int width) +{ + for (unsigned int i = 0; i < ARRAY_SIZE(pcm1792a_fmt); i++) + if (pcm1792a_fmt[i].fmt == fmt && pcm1792a_fmt[i].width == width) + return pcm1792a_fmt[i].value; + + return -EINVAL; +} + static int pcm179x_set_dai_fmt(struct snd_soc_dai *codec_dai, unsigned int format) { @@ -96,40 +121,15 @@ static int pcm179x_hw_params(struct snd_pcm_substream *substream, { struct snd_soc_component *component = dai->component; struct pcm179x_private *priv = snd_soc_component_get_drvdata(component); - int val = 0, ret; + int val, ret; priv->rate = params_rate(params); - switch (priv->format & SND_SOC_DAIFMT_FORMAT_MASK) { - case SND_SOC_DAIFMT_RIGHT_J: - switch (params_width(params)) { - case 24: - case 32: - val = 2; - break; - case 16: - val = 0; - break; - default: - return -EINVAL; - } - break; - case SND_SOC_DAIFMT_I2S: - switch (params_width(params)) { - case 24: - case 32: - val = 5; - break; - case 16: - val = 4; - break; - default: - return -EINVAL; - } - break; - default: + val = pcm179x_fmt_value(priv, priv->format & SND_SOC_DAIFMT_FORMAT_MASK, + params_width(params)); + if (val < 0) { dev_err(component->dev, "Invalid DAI format\n"); - return -EINVAL; + return val; } val = val << PCM179X_FMT_SHIFT | PCM179X_ATLD_ENABLE;