From patchwork Wed Sep 10 13:58:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4272 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id B79B53FA5D for ; Wed, 10 Sep 2025 15:59:23 +0200 (CEST) Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-62297f39033sf4993519a12.0 for ; Wed, 10 Sep 2025 06:59:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1757512763; cv=pass; d=google.com; s=arc-20240605; b=ao+gBimGshHus0/eEwGeumETyY50YPtKuQlMZwyxBcV6Ri29uE0QMifLVB6KMyjdSb qIY/yeIjuO32bFTfN/F7NpzPZzGaMNvQiikzwISTHxJ3AbGfulQip1i1TxVufzETJ4AL o8Tnx4gz2+s97bVU7yi8X6kEMH1qlnrgQau+UTHwHkz4Tf3Sa+qPA+9kg6mo9paw1SNs 9pbz9jepP1xY/ZuutvmZ5IVWZYG0TTTDBcCnfzv8EIjrQPYpVi6XKi28EwkPqUM6N40l U9m0vvJkalGiwq1LLA1BApXK/LtCt8SdvAnyAUidBsBQUug7rmOkR92eysZTCVMatEuw 5fOg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=4zNlbSj3K5eKjcQ7aJkmtVqvlY5zvsjWBS2L/TCMjRM=; fh=TJMhGh6NkE+FYkMORHBqcYzG/2dvvPwyr8LLXS4UgTk=; b=OtCZrFk16IZX2XGfaHOj82VRX5aRAHpgzd+zro+UQi7MXw8egpKU5HC8pA8pu1o/tt MrnphGOQR1fAHS5v5p0WzG11YVySkSDFmlcDd3wEkfCGlun0NrUJgKVjS6o3XbphHpIK eo15tNutbeeyE6Pua7jB04hZJVLsMCqguwdd6w03new7ui5j0WE6N3EbnccP0JoOeMSG XEwa+oqqys0OC9x4fMZ+Vv6J00aYCYXeRkPPP3L9mA4vb1pnJ0W1Mc2fSOD3cpPPYO64 zywXdl4DuUwpLIB5lBdA1bzb8lkyTYAFJPlVLxgK/UHEjan0I0tzwXacA8E44wxogAXq XHJg==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=EjAWrtyb; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1757512763; x=1758117563; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=4zNlbSj3K5eKjcQ7aJkmtVqvlY5zvsjWBS2L/TCMjRM=; b=LS3Bx1u/rG5J4r1JT70AmLoPWO0YyTSkzovTZU8qW62yKg7/xdKtclvyTlg0pXRZ9X j7ixDQNdbr5eUG3qrgUbzznmQvnKGIxzSwPZcZkwTGnbu40G3BLHREO3iw6Oh87jfhT7 2LQcDW2s2CmzwEW31CqHSlPpwFra5Td64g+h4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757512763; x=1758117563; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4zNlbSj3K5eKjcQ7aJkmtVqvlY5zvsjWBS2L/TCMjRM=; b=LdQL+M9tP2MlHf43AKxehR7RLFbpu7R5VnsQiDHAuo47Pq9MU06BuM1ticAgGJFN9P /NQGY/dPwLStvVvYnum3tO4LE3XcBfgDK0h7VmDgNRlF1VpGqeG3r8q1r+TNjXeAhykX 1wSAY5FRbUbB4DzpNncxCwmXGTiAD0P0fc/Ru9a/Yc+zkGXBmRX9wh/kbXMt0hUWI51v v36pW44t3PsKN1q9Z+6MZI4cWDKqfpwNEgKGIgvizkUYGrPmKazaydW+aMc4CH9U049A sPWBtjWB9B6U+kYwucltt7XckHxn13c22j3kOuHTPHi31Q4d9ZeC7RcXSBuLh1M4oTyM yvrA== X-Forwarded-Encrypted: i=2; AJvYcCUp2wow1f6LI757wkC6K1rlbG0FCnyzGxGUbAErfotRooYDhO11QPCv+AJKy7UNEiX+Rm0ORVf7leKY7J2V@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YzvfVUDjyU5Kd2/HFD7WTDnDb2QjVeSrbAEaKfC5r9WjwVwH8kq AEGFRaO1thj42rMNvcsZ5ha5Nn7q085D8AQnDcz7aPf/TGK6f7TXoZ5JY94dYlLc6Bb4Yg== X-Google-Smtp-Source: AGHT+IG90NLd6nxzBED5k26hu9upmpfbgwB8wPciq3nFfv2umlARB3KD1Q0ymSE/oNKrhVRTQ+f/1g== X-Received: by 2002:a05:6402:27cf:b0:62d:c711:7a37 with SMTP id 4fb4d7f45d1cf-62dc7117dd3mr1341259a12.5.1757512763371; Wed, 10 Sep 2025 06:59:23 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd45GWwT+uowttpaRrTrZKWrXSRjUWYSvpHP6TmfZxD0Tg== Received: by 2002:a50:bac8:0:b0:61c:38df:202f with SMTP id 4fb4d7f45d1cf-621429720a1ls1113469a12.0.-pod-prod-06-eu; Wed, 10 Sep 2025 06:59:21 -0700 (PDT) X-Received: by 2002:a17:907:1c98:b0:b04:76ed:3ff5 with SMTP id a640c23a62f3a-b04b169606dmr1556997866b.40.1757512760919; Wed, 10 Sep 2025 06:59:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1757512760; cv=none; d=google.com; s=arc-20240605; b=ikvvcT/S2ZEb3xar3xKVGV5V8LRvkBNcGqJ73i/XFXcmzV9sxpShiLQF/K5NYRL9SO RGJTHdXOwXem8r0v2k9zCzHKgKZCDi6bPYiH+yFYZvNDDMorjYkIOpRyxh9GDB0YK8xz kFQOqQv3tLzi68pRsbfCEHld2xqs1ppOCFyO0JXl/m8VIjJxcQCWmi/SptBMb9HZF9i7 sDZ5DSc1EuyO5DZPH3PbIWIxeT9ehIcEbQzSR/mod5a6iTnFEohiRksCiuoiUpSUc1ed YXQKA/P7A9ubeOVTP+eYk5RdYkKWqlsJ5r9KxmICJcZC0e2ucV/fOIbtKp2pHp8PwCO7 kspg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=fOaQOy4NwCzyitlYEvpuiMsUEgnozIVGmGmKLfL9eXI=; fh=AUpCjfKtUfys7cG3pwG6onzZKCwAk3NzwNW/OBNBOi8=; b=Yg3C/P9hVWYjv6TnV/UOlDB7iTrlmwZUKQypi8XY4o5fPzKBJHoQ8ImMQkIa22mgfS YdzykCm/eTEKipNOH8q3xMwmVADaOFEc5Kue7POUUet0q3UX47ZndqmIEgqrLWgj9R+l LmpMtLXTIjuNLNu1qNa30qqbVzswjyhizfrQNavMyXNwNAKb3L+WFWEKbvncRZZcrGeW vauirTBdW3m24IArFtnL5/sk61gdaTaJWTwMAKpeZARuQu8IFKdn+AeBHcNb8Ry4+Y44 AymUxsSGVLHU6cW4rV2Z3J8wwYkSwoNPCYRSAEXAhEk7Jhs+haUA4D+B0/ZSWpov/fq+ eA+w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=EjAWrtyb; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-aff17d9a827sor1089639566b.0.2025.09.10.06.59.20 for (Google Transport Security); Wed, 10 Sep 2025 06:59:20 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGncuKG4WyWjaJQhx9ij6gURW34BvH6Rv4LN2vosOFU02BMmuY0c5GjNi6S17YHWY blRx1wd76hnokwNDHzUTUyNY2VN8NiXenSdCwyn73MeMwHhOE2sIM4GEzUs6C7cNV6IISN+YMPo Nn0L64GOX5K8eSDavVmqJ9F0rAMJJEln+FYpcB2KUQFrmSWregMES3oz4so73iuSNuuRqtrF9bW lIPbBg2uSRHhDywSx/7KNQe1ELXZBx6RwmT3a/LRlVjqx6kMa4sRobMMWFITGaYhaTfEHz8Rpsf ciLKR/+TRm/LcVKIwtWi2UR+A36YkjWiK5l3WCjvGI9fuLbdh5CWfenh3QFRYfAqZRXAYXP1f+4 KnqRaDsIoDgPxCrAonXZBPv3Mqo79NZ4qaPUfPoKY/ayjy6GJZ1Ll2O+dl/gfmcs1v2QFeCiOFg RDYwcgCmuJEUTu2LXlSWtACDFGfRU3PXok6A50R8wrHXnzPsI7mdRE/boQn0bq6qZJ7shNO+cQm 0k= X-Received: by 2002:a17:907:25c4:b0:b03:fa9e:4b68 with SMTP id a640c23a62f3a-b04b1696b7cmr1544984566b.32.1757512760390; Wed, 10 Sep 2025 06:59:20 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07833a4e37sm172523066b.76.2025.09.10.06.59.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 06:59:20 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Michael Trimarchi , Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [RESEND PATCH 1/4] Input: imx6ul_tsc - fix typo in register name Date: Wed, 10 Sep 2025 15:58:35 +0200 Message-ID: <20250910135916.3939502-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250910135916.3939502-1-dario.binacchi@amarulasolutions.com> References: <20250910135916.3939502-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=EjAWrtyb; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Michael Trimarchi Replace 'SETING' with 'SETTING'. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- drivers/input/touchscreen/imx6ul_tsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index 6ac8fa84ed9f..c2c6e50efc54 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -55,7 +55,7 @@ #define ADC_TIMEOUT msecs_to_jiffies(100) /* TSC registers */ -#define REG_TSC_BASIC_SETING 0x00 +#define REG_TSC_BASIC_SETTING 0x00 #define REG_TSC_PRE_CHARGE_TIME 0x10 #define REG_TSC_FLOW_CONTROL 0x20 #define REG_TSC_MEASURE_VALUE 0x30 @@ -192,7 +192,7 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) basic_setting |= tsc->measure_delay_time << 8; basic_setting |= DETECT_4_WIRE_MODE | AUTO_MEASURE; - writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETING); + writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); From patchwork Wed Sep 10 13:58:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4273 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 8191E3F16F for ; Wed, 10 Sep 2025 15:59:25 +0200 (CEST) Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-61d31626b01sf6353866a12.0 for ; Wed, 10 Sep 2025 06:59:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1757512765; cv=pass; d=google.com; s=arc-20240605; b=Bh1DUlZylML46G/BznPQM+i5zTtH5/MwiIYrE8MHLw2Zj4XFlM88l8WRo+2+R0gUqY i3xRWqZ928pEV6HbtlbpOjmxzxSjYqwBI8yotzG/5bd7itFVd5/Yqt7MuHz91T4Z+ZjO 4AeLJVftg1w6y/w0RdjmYj1Wjcj4uCjGZo2ymKC391NqTo2SESiNIK6Q/4REdvfJrU1R nOi/NTFnjsG+Az0ltQO6M/WKw6CvhugQStOD8iHkUXuB9Jd9HK96THgl1WCceTvQfLRN 1BtJBCMvuGPRFW0KxUxo4/A8qdhsbBc4yYt4hp0WoRsqAM/7YQRstMO9NrbwHzREzpqj 9v9w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=PIXC/ArfQmnrQNbmnxsxaVZMl4LHraFo8UBIC6q/P1w=; fh=/hB+iaqhSi3dSQFv6QG3xb7681JPX0iPCKJNRnowFy4=; b=jsHB56UlJrGCVB0qqLmlFOHQGvFBDuDQj3qdx7t6I5XElVBpHf9ayxYYhbeeXB++M/ thpDLPYidMvH5aeeeLFnwXkmDWctM51d/TmL/zfC5AvJNlBuKo1TvOBpDPLjM2/+da/W wEgPwJWxlWIpgh8DoYxMwAg7s/1GEDnORZiEmflRSaj0Cox88/bTxYY3TNwQrmYYHHDI 6Yz5e9GbpYgUJXXGV+WtANWJ7lU2h15s02Qyp0JY2hDbCBr2kXucyE30nexKOt6ZYRt9 bCuTwKrTQTt4yVYiQenEqZjHxpZn+wUT2XB7RyW2mTPdo2KQixxstV103gX7TMGjEK4P 5Btg==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=MUI6SxZG; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1757512765; x=1758117565; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=PIXC/ArfQmnrQNbmnxsxaVZMl4LHraFo8UBIC6q/P1w=; b=GOZHKz6BqEZXZbOPtis36TOcvM+AhEWEH3eWpY9jJWeh6dcx1EzI00qMnBa5Vi1fjl Dc5ZFRhA3WlI+shpWg1olSerce6EGgj8w1Kv9N6FN8/sWVXAq0ez8jVmlvC4H7KsPDNz 9g4vrHwKoLziO+DLZMttSGnsN9iVmk6itYefM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757512765; x=1758117565; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PIXC/ArfQmnrQNbmnxsxaVZMl4LHraFo8UBIC6q/P1w=; b=Itppwsg4poxE1bFQxMckxea66BKoqpxx9O97T60F01A93eJvmqgYGCLRKnjUKptcgM Y5IiQbSMiO3E00Rfpj/xz4FJZ/ZAPCrrandhHy5TD8IneS2UqrutU9x/oQ8sQ2ZYAvbI yNepIfJktzLEr5TgYVaF4AtTm+lvwBl+dyokKcm7QwwCvGGI+oBI3/aL0BRfMYXMH9bV hOgRU4QEroKDH/JIOFO3mxUz8b9uszmcgKqA9nBx7skN5G58EBjN1QwI3KPNS2c9do7n f1+qAtJWQkuoNQD3OOEYcKE+ltwp543RY6UAvBipnvC8Z0W0DZZCKwKJlyaQLpr84RcB Wx2Q== X-Forwarded-Encrypted: i=2; AJvYcCUoiVpfQiK+BjERM/yLTRPGs5LRpzxxAMF61Cv6trBOkJFmqnom8bHydNbq+ZHcFrTFEHoc70WmMsUDu7A3@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Yz0y5ef89mu0VDm/ufSGqRtLBl2hxACysPVf23FkL62fYSH8TdE b1q2uB2J8qJI6Z8+xL1pqUnSnsbj5FqXgiRTcbwPIuESpUQI12d26BkHxo/77IilTkXlUw== X-Google-Smtp-Source: AGHT+IEduam5Eu0MQYkgh/JDDDLxtMPewUidZD9OLSVasW6zvEin1kQFQ9XztfJ/kjl2tXp1peDIYw== X-Received: by 2002:a05:6402:d09:b0:621:5564:bcaf with SMTP id 4fb4d7f45d1cf-6237ebc6ff9mr13985450a12.18.1757512765111; Wed, 10 Sep 2025 06:59:25 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd6CzocB+oo3/3x4JXZa4YSPKYNxx50bx1e2f15DL3yhrg== Received: by 2002:a50:ab0a:0:b0:618:8cd:5cc1 with SMTP id 4fb4d7f45d1cf-62147daf57dls5033756a12.2.-pod-prod-04-eu; Wed, 10 Sep 2025 06:59:22 -0700 (PDT) X-Received: by 2002:a17:907:6d0d:b0:b04:ae7c:703e with SMTP id a640c23a62f3a-b04b140a770mr1433341766b.24.1757512762591; Wed, 10 Sep 2025 06:59:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1757512762; cv=none; d=google.com; s=arc-20240605; b=R+lIQdyoo02mr4QMweWjLeAnhH9XlNzsqFUB5TU9NtvbWD1NMJw+c/L+wVUANWcsWh szZtNznTq0dQ6ZVSYaSyLL3+xAdGHOwFgfAK5zRGFGCePzRTQ8OqylnTXhPh39X2V9Rl wl/G+ICJOAxoc+CAoFMBrnnedlgri12a4q1Z3y139pI9xcNL6/Ix8wwC/++D+37IlSwx M7Ms765Em7aXM3jo41LFKZgkQjKzybBO82qZM7z2YSpXEcVLL6s/oFB1q08ixUoCetXO CoGZkoaZ0sDYE1eBgxu25PScRKZ/mh0I7K7pj1AQdNIb6ztF4S4o2ydmFKmfwNbaCZAO z/1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=GtY6xQODciaFQXT13QEjMt2xFfxEtt0WYueluTMBhAE=; fh=euIalU/jf6N5x2NNEskqvzHuFozMvE/8fvBnhWHdeuM=; b=b5bToQb97RISoPiVg9/ZFYvoRXB1fkkpPWX7GQct8XU5mvMDR16MBD8dT/I2PI5m/S 7v72zOzi3/M/QkyGh+RO2/n6gjLlm6bUrY9BibqlLUaGlWC9mGKr/npNqvU8OaG+inyY Dt+dZY1dj/Dz9z0OahKYSCGapzSRq2DY5JCKODZFDXTd3kVrf6vCFAiO+P0PUf/O5zeM 8UDDaupDhdkMQtjoKMTM10AmtlKeGpNi5AeeZt7IwSjjxFHrigg4Gv0iCOgbrAVC3Kdf sQjQOEzeEpb1DgvObz0wiW2wseoLKNKmif27daVJKRZPkxEcMD3Boslj2nrG6uYxrQb3 WRSQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=MUI6SxZG; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-aff15a7c8fbsor1104399966b.17.2025.09.10.06.59.22 for (Google Transport Security); Wed, 10 Sep 2025 06:59:22 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGncvtiEzTpKM7immY1gWZ2dpw1hC6NcSyWuVn6oFooFpo7sGVny8UiicaG0li3Uh eeGicbxun05gYeX5YPOVbdp1DuoY2clUKt0mmJY/TNRYoOnM371KNhxj9vxB5EaLUtKhYVjci8W LfcOJmkDXN3f3JWPDzS7rG+N5GJm78s8LOahrlJgg9ZTEyu6CjxD8JsB0LgE02C6fHZ+hRe/7Qq tIANxGJcZwOCdTvJ38CZuCQwDFwNSDUOlWnEu0pX42ifp2FEYDZO8+R4I08sMTqhxyvyDFDEtQX Ii1vgGuVwVq+5aCGnPpbQlbbtBBCV9BElK+qMqn5iKyRM7MlN3abVM1QEyichPE0DfGHo80ewms 0OCmSm8MkZAW2l3uLTI4Rf8KgcGwpdZUNKBxd/e5dIvtCa/FKF3m3hOGzNpiQBWHZmRR509XXpV T9yBKdhMwoMaBSHSiQc2BW8JSLRWm7/AaeifnVgO7+K5Ttt+L0836a34jrpf13sqmp X-Received: by 2002:a17:907:d91:b0:b04:626e:f43d with SMTP id a640c23a62f3a-b04b167b9f2mr1190384166b.47.1757512761817; Wed, 10 Sep 2025 06:59:21 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07833a4e37sm172523066b.76.2025.09.10.06.59.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 06:59:21 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Conor Dooley , Dmitry Torokhov , Fabio Estevam , Haibo Chen , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [RESEND PATCH 2/4] dt-bindings: input: touchscreen: fsl,imx6ul-tsc: add fsl,glitch-threshold Date: Wed, 10 Sep 2025 15:58:36 +0200 Message-ID: <20250910135916.3939502-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250910135916.3939502-1-dario.binacchi@amarulasolutions.com> References: <20250910135916.3939502-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=MUI6SxZG; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Add support for glitch threshold configuration. A detected signal is valid only if it lasts longer than the set threshold; otherwise, it is regarded as a glitch. Signed-off-by: Dario Binacchi --- .../input/touchscreen/fsl,imx6ul-tsc.yaml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml index 678756ad0f92..2fee2940213f 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml @@ -62,6 +62,23 @@ properties: description: Number of data samples which are averaged for each read. enum: [ 1, 4, 8, 16, 32 ] + fsl,glitch-threshold: + $ref: /schemas/types.yaml#/definitions/uint32 + default: 0 + enum: [ 0, 1, 2, 3 ] + description: | + Indicates the glitch threshold. The threshold is defined by number + of clock cycles. A detect signal is only valid if it is exist longer + than threshold; otherwise, it is regarded as a glitch. + 0: Normal function: 8191 clock cycles + Low power mode: 9 clock cycles + 1: Normal function: 4095 clock cycles + Low power mode: 7 clock cycles + 2: Normal function: 2047 clock cycles + Low power mode: 5 clock cycles + 3: Normal function: 1023 clock cycles + Low power mode: 3 clock cycles + required: - compatible - reg @@ -94,4 +111,5 @@ examples: measure-delay-time = <0xfff>; pre-charge-time = <0xffff>; touchscreen-average-samples = <32>; + fsl,glitch-threshold = <2>; }; From patchwork Wed Sep 10 13:58:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4274 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id B23253FA5D for ; Wed, 10 Sep 2025 15:59:26 +0200 (CEST) Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-628cc072d53sf3219045a12.1 for ; Wed, 10 Sep 2025 06:59:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1757512766; cv=pass; d=google.com; s=arc-20240605; b=jDQ6nKyXxB9i62JYLPe7H6uFJbaDH85uYy+WLQvDjE66U8+Md/cmE0VSoAUnj0EPJ/ czqVKmStJ5cgyjvoS9BpYikwIqM/Vu2aERBLucgADm+Q6C6niKO8cHx0ChoYohIODh+o tMKiHh8U8aVJT7DtBdAlCbBIoO8uTVTgHWjpj5lfEbgkQbxQp0sd7fxD5kng1yRiY+Tl kQbFmd5jlgyiC3JSOzrkILqcfmii1lnL4GuTVs/2Zt6paMbyY3IYf+SdpqrBAF0VcBTi TozE4OC8BpGoyl0eg8ewVqonfI3+akJqvNyvlbKHzMSbpwxexT/jozn5hDSXxBW1WJk9 xGaw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=caRuVMvZU4mj559QiA5FDIYylRJectxLC7J/y8bOFEo=; fh=9OyKKFKmJ4lIilkQe0GBWB/W4FrSMXX6PpbXuNaMjBE=; b=jqejtFfkjxTaJUc8dPulpg+tOpV5DSdNd/2ae582dReQIFzvplhl695zJOCEgWM6EL wUCdz17m2cDX11+0MBzatyGFUpjmXmXGCAJFEqbXXnB303LXqTUbrk8HXqa/UMRBb8B5 lEURT4Ud7ApMHX0477MQhrUFjngXTz8aiO2z7hno1+BjtjuBnGvsTHBEnb+1PyOI5Bo0 syqfEAW7exxFvwG7ZXAB3OUGZWjpSsA7N6Cwz/OfLotNy5oVg7a17iWR+Q7r9MF1IU0v Ujliv/3r/+5gpc/r05CpXamQ1+KUAblmjw5mxTHFI2ERP5bYT0cgQ950I4GhVMnbyye0 cTFw==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="U/W67J38"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1757512766; x=1758117566; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=caRuVMvZU4mj559QiA5FDIYylRJectxLC7J/y8bOFEo=; b=Gl5IfV4MqqXdu5UZHwM1+uhS5hjZ/R03x3+eP/BmYjGp2FDwRsyyqr1e0pAGhOoha0 ICWgwNNiT5ht3XVLGohWU5ZPrOAFlN1oLUx29dAOp/l6+tZ3GPg0WD80XTKEXZFaOdSz 7hg4STb5cNQ/HRHpUn5sthGEUetCtJSXN+Ya4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757512766; x=1758117566; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=caRuVMvZU4mj559QiA5FDIYylRJectxLC7J/y8bOFEo=; b=YMFcZZYiOTXKrzU7Sur42NHwQqBHi9yLtErGQnvGqs9vAlGdghSLpE8OGzWdlWqKwV bgkWT8802jcfEuAqCGK1++W0jybmUh4OGxkG9bk+7XXCNHVHQsngp3SSsTn0yU4ftAPw JxoxI7VW0q+rZWj2NT4F2NZGEJUjgPZXCJ2JzsQTszCdI5c97z/ieFHCINktH0HXawFw Rq2KKrFRLbI3jT8bUcUQyLFMzd9shSbC/3DOKFXAINY9F8bK6c47xsASvzJlZR57GXzt acCRFbJrG7vzJyT6VeCvfD2fy7osPRAwJP9czKYs2HLUBDOeGNFW4FWMPWhFRd+KVDRh hZ4g== X-Forwarded-Encrypted: i=2; AJvYcCVvuKm7RVCDjcDe41qvB+o1MOTPckiutJ8yF7uwvEOL7hDvMDER9I5EBDynQZWF9jRJ5+y2AbdwXjAtii6/@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YzQ3zGVp2mGj3rC/O/zH6peUfKAavClUaGu0GJ2qkJvrWfjeWSv uaAoEb0vPdks/VVaETx8lVRBsxr8QBJdCYHJeKsY/gOH0sXIYr52M+tjbcOKHPNWcnF3TA== X-Google-Smtp-Source: AGHT+IE+NA/LcPptmTeaj8qkondfytVBkuJeSkc3uxEpc5VkhUOvoUo/+Y4BG/yZ+pkfOHO/pYz5pQ== X-Received: by 2002:a05:6402:5203:b0:627:6281:e441 with SMTP id 4fb4d7f45d1cf-6276281e8d7mr11598306a12.23.1757512766053; Wed, 10 Sep 2025 06:59:26 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd4i6LWbCcncdEknBbepUk8IYUjVOzRvihAjNsdfckDVcg== Received: by 2002:a05:6402:23cf:b0:61c:3fe3:ce7d with SMTP id 4fb4d7f45d1cf-62146c05117ls5078120a12.1.-pod-prod-07-eu; Wed, 10 Sep 2025 06:59:23 -0700 (PDT) X-Received: by 2002:a17:907:3d8f:b0:b04:6cf7:75d4 with SMTP id a640c23a62f3a-b04b1764321mr1833838566b.49.1757512763492; Wed, 10 Sep 2025 06:59:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1757512763; cv=none; d=google.com; s=arc-20240605; b=bQkATBWZQmJq67GDjOdVYVCGkTCcrbf3Ax7yHsyULy/r6DrzXsSfgtnPwq9r6a0DdU 0Qf/9/x+YWje/ROdeMZG80GpoiiCzGCsiHfhnsENPxGlKZeA8YJdCLiKBt3So8SVfztV qKKPMP1IrPPWswu+5CiiinUFc0p7PJIQoDfW6CD23xoSc9TxpsfbUL33u5mJjsDPAc3F d7iS/Nxfn+ymZqAzjMFd7nX5SCOkrUys9HXEnXj7Uf5/3+kHWtNLLaYNJ5MQzrBEGEgu 7+Ai/s+Gf18tDnnocii+7/RsCpuhIHNtvONp0HxpmG6dQZkAhBQH1xS+7m9Lcaze0JzI lmrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=B0R5rRW0Dwv8g9EBflVK6bi6TKX/71M89TmluJsUG60=; fh=4gXLHhtG5blgxpWML+oiv0GiMs5uzMuOuNd/RJVWDWw=; b=GboIZR+DYpj4ViZx2i/OmdqYrdjO43dUhWxKHAghZptiqCEZCgxJ36fxIrwbzzL3LF DmsP588F5lnmrPTy6udPBTlokwwDY7zf6wUETQwE6LUK4SPd/i7bMdXwilJwnHkSPun7 k0QlyBlWJmE+x850akEwuT/P7FPPlHPUeOv9I2JEi83YvB3rEPJ+70brIzgPdiM2wwRt rLvagsmRDFL7eOLJrXPmTJhfUkE8KBQWReBFW+HfvThOY8fhzmMYNGOX+nCpQugigfZA CKRaVZ2BHSsfuZtZwa7owin7ep2gsHr9lYTV+uGe74qKEPd2RMDFnDnKiF0BjQ+vMmSI YLsw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="U/W67J38"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b045922c96fsor823512866b.13.2025.09.10.06.59.23 for (Google Transport Security); Wed, 10 Sep 2025 06:59:23 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGncu+MQZO9S3IVma7dA9OkLgM2PD2zRcp0OYLkTRXs4NzHknZHQdHa0NyKUSjcZ1 2SNzjJnuo1rcQH1UPQKNsWm93dT627gLC+X+4Mhp04pvQ21pmokLMIcVPA5Lq2wVCzEYJfEOrvy lsrP/YsatmvH3oS5T+ha8/+woqXOiQvVV0ZY3QG6Z1/9WGkeWI8mA34XiFune/H878+d9dHsich hPV7cxJJcZ9UjWB5msafUe1/t/vUvl+SeUl91v6gifW7QQaql4ie1+d7xynRT2SiUv01Ln7C41g wMTtAA10KUewyYUqCyyBPzwXus5vQxbOXQrGlEblKiOZ9djOhYjbzHF3AtWzw4Wa0Oc8XPXTxL6 1zcvFslJ/mHSO6fQvroQhYrFe9be+DgtNxBhiEX3xKpPkirt/dtd9/QAxPBE8FKxQS9c6GEoSz1 R90Or9pn+Dp7Bsv0wtpzgMQG9su84/iA7Rdg45jzbwR4uRlyboyox5bX1sBcBf1bfA X-Received: by 2002:a17:907:1c25:b0:b04:5c90:8013 with SMTP id a640c23a62f3a-b04b173763amr1525363866b.45.1757512762970; Wed, 10 Sep 2025 06:59:22 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07833a4e37sm172523066b.76.2025.09.10.06.59.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 06:59:22 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [RESEND PATCH 3/4] Input: imx6ul_tsc - set glitch threshold by DTS property Date: Wed, 10 Sep 2025 15:58:37 +0200 Message-ID: <20250910135916.3939502-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250910135916.3939502-1-dario.binacchi@amarulasolutions.com> References: <20250910135916.3939502-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="U/W67J38"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Set the glitch threshold previously hardcoded in the driver. The change is backward compatible. Signed-off-by: Dario Binacchi --- drivers/input/touchscreen/imx6ul_tsc.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index c2c6e50efc54..a6066643bd48 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -74,7 +75,8 @@ #define MEASURE_INT_EN 0x1 #define MEASURE_SIG_EN 0x1 #define VALID_SIG_EN (0x1 << 8) -#define DE_GLITCH_2 (0x2 << 29) +#define DE_GLITCH_MASK GENMASK(30, 29) +#define DE_GLITCH_DEF 0x02 #define START_SENSE (0x1 << 12) #define TSC_DISABLE (0x1 << 16) #define DETECT_MODE 0x2 @@ -92,6 +94,7 @@ struct imx6ul_tsc { u32 pre_charge_time; bool average_enable; u32 average_select; + u32 de_glitch; struct completion completion; }; @@ -188,13 +191,15 @@ static void imx6ul_tsc_channel_config(struct imx6ul_tsc *tsc) static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) { u32 basic_setting = 0; + u32 debug_mode2; u32 start; basic_setting |= tsc->measure_delay_time << 8; basic_setting |= DETECT_4_WIRE_MODE | AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); - writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); + debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, tsc->de_glitch); + writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); writel(MEASURE_INT_EN, tsc->tsc_regs + REG_TSC_INT_EN); @@ -501,6 +506,17 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) return -EINVAL; } + err = of_property_read_u32(np, "fsl,glitch-threshold", &tsc->de_glitch); + if (err) + tsc->de_glitch = DE_GLITCH_DEF; + + if (tsc->de_glitch > FIELD_MAX(DE_GLITCH_MASK)) { + dev_err(&pdev->dev, + "fsl,glitch-threshold (%u) must be less or equal to %lu\n", + tsc->de_glitch, FIELD_MAX(DE_GLITCH_MASK)); + return -EINVAL; + } + err = input_register_device(tsc->input); if (err) { dev_err(&pdev->dev, From patchwork Wed Sep 10 13:58:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4275 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id A15CD3F16F for ; Wed, 10 Sep 2025 15:59:27 +0200 (CEST) Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-61d1327a8besf4672254a12.1 for ; Wed, 10 Sep 2025 06:59:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1757512767; cv=pass; d=google.com; s=arc-20240605; b=c33lueSPLf8zvDJQZ5lelGRC/CBmPWjPqMIVCqMGGb4+d64Pf6ZI3tvna4VpJGFgbx MdgwJXHSU+CRg41f7EzUr3XIkczGY9NIxekol/D5xQHacYzbn3g7Lle91YC3ks11fYwU jgcPkNCZo0sDnVuz2EucodCakx1TLiSs3SEXKzBzYZ1Lh4fHOyUpCqhNc/+/fvZ9XTI6 4ujxiAxYB1WuFXvlExK5R2rybHLIDAJf/pr6K8Loq8iLtBwQefZ9WYO0tapdE536P+EN BjwaEdBpk2T4oa/COB7IrBe7q2t6ry3ub53o8LRvlwTx0xLtLpfgBjB5dgvqDcwXqU3h dUJw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=NwIYOPx+SivDsZ+fJEZfMbkbJ4KKzXEO3esPBItUo1E=; fh=fZhKhnEWUQleQ8fqURa3fIkQOmFO6cCsdPPHpqX5Vd8=; b=kpNVgm98dnv5GcxmSQmru3qXBpRrYdquhscMfbJoIj2wz3M80dn5RRfspcxvNJUBZX UudkuOvGHaRGWFUAXquaLH1AItxO9G2SZgfras5MjWyzPt4mZ1tvOf88LIVD2drmC1Vk wj8ZD9B2nGSvt+HYHvqOCRxBsDAdABg3NdrI9aTP3YBACTaOPu31Ddu1Xqqcxho3i4jG e/TIH9Mdzveq++dvIlash2HYEKp/zH5uWRrjLj9O7YXTc/Gl7dpED0H/HCF5n7n62ojT gMOM3YubZ2YVC8I+Gs1XVIrXdnY13cNrb8wqdZ6pfFV9jTOK6Gs4cphiSV/ujYJpDTKk tVTA==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=hbyOMPih; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1757512767; x=1758117567; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=NwIYOPx+SivDsZ+fJEZfMbkbJ4KKzXEO3esPBItUo1E=; b=em4Xtz8xNOyL4d0RBjqs8t0FjWm+3Zlsa7V4YAxH9D40yOWE6JvKjbrjpFN7jAsC0B QCwJcWz4e3cpHI+EgjOT5z79hrz8S7Av+RjB8KbCG3IcnddJbgTLIwhrNbimAY0wfMBc 2ZpdBUtRMxRt2v4oGeCdPVjYtVr/Hf796Jp/E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757512767; x=1758117567; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NwIYOPx+SivDsZ+fJEZfMbkbJ4KKzXEO3esPBItUo1E=; b=BLIxZk1UpQ5Cu5fIWjIPuHo9BCW9hRkhw7EscaQExcFW0/sn9NtCmHC/wNN4wwPs7c 83T54n4ia3ctjBdwW3t7VaOIR+6ITzhAaUK8npaKcc5r+meso1dOEzgUbgkAULl3Iae1 jm76M6kIZ9my5XcrTThjn5m6BYPcyOcEnLnrDWprzQqOC3Nf8wFQt1+NAsiPPL5k0XR5 eJ3kVwn4/lNWX77A6knhUQM3evJ1D+MmlXtOXw0PRlM8KUwVv6pHWYSsh0CRjSwp34+4 bT2hSrpVn/HL8wfSTqVOlI1MWHykjcFbpDTbM+tXyEXiXijn7UiBh0LAivXmUelIRn8p aiUA== X-Forwarded-Encrypted: i=2; AJvYcCWksB7gPLf1K/Gl7bDJPB6LxKNjUO3ylyNle8SxYjjCk64yJuvhD9q+2jgz5s9+gf9p1nuODC+v74OycrKx@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Yx0wqrlCaL8IOqBJFAZMWhx5pNFGLdQ+PhwzHE5p/xJtJmOenvA ZV1bLsQ83E8dU1Q5lWHlB4D8wWbD9kTJDH8H5Mkar/3rIGGio105b5OWJ9H45jRbkwm6nw== X-Google-Smtp-Source: AGHT+IGMGDqbnjESD1rER2j/qktsPOpPXZAtmEuwR3ELPGlFdj/rm67ARULWI3oDg3wL3OACya90Ow== X-Received: by 2002:a05:6402:358f:b0:628:bee2:b31d with SMTP id 4fb4d7f45d1cf-628bee2b6e7mr10862528a12.3.1757512767266; Wed, 10 Sep 2025 06:59:27 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd4lq9lUveGq+YQhmmaEBGTLkcvHFWEszs4e2sUisw5sZw== Received: by 2002:a50:9fee:0:b0:615:7125:5fa3 with SMTP id 4fb4d7f45d1cf-62148956631ls4606007a12.1.-pod-prod-02-eu; Wed, 10 Sep 2025 06:59:25 -0700 (PDT) X-Received: by 2002:a17:907:1c28:b0:b04:9854:981f with SMTP id a640c23a62f3a-b04b16bf13dmr1495438466b.43.1757512764788; Wed, 10 Sep 2025 06:59:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1757512764; cv=none; d=google.com; s=arc-20240605; b=RNESj/RzjmNhAh2GfscJAa1k9bW7NiysP+9CKsG0WeqDtvOTxRNKtFmWmyubSng72y oL+InmM6xLoJvaXrseWurdI9ARpQl0UYb4HNNbGiHFrVF+UWZQNC717YTCZaYGs4gylN lpBM216MgJ3K8Kic7lEbyfXhvhkMC+F3+qjtF6obYHt2c0fnnxranOnt/DKZVHyhP6z/ Zw5nWCYDT5V+a8wGP681cKc6H/W9rxPmsQnuE1xqr8om8WZb2g/AeTtlD/Msgtgp7qoX tuftvNuinUzVx8TU+teDewFKgsp+FlC8AT2n5IZaFVJ+iZ9YISAkBh1GUYbq2Zxstw5Z Tk1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=2oVD/JfoNNaDmsm+Xmi5oDSaNjfSX3YkjZgxJuhnDRo=; fh=4gXLHhtG5blgxpWML+oiv0GiMs5uzMuOuNd/RJVWDWw=; b=VBXrnjQy8BRzo6ZDzJt5+aw6LAejcr5QsOdSll68F2RmFfkl+4t2T42itrp9q69vIu DhFrYuLZc+z3mDM00lL6LjP+PL12aDz4+sqSejbQBSZ0hrVN2cJiCHitCq4pI3/0dyID T7+4EOXsIOY2jkuVujQRIotlbbupNoOmjXDJbRGq8Cb7iTsmFejdtkV+fEP1H1vkBema mD+i/jLagHVXBzD3qQ2H/Ebezd2vRtZOUaw452ZY7cMuufclnn2asP/sAcmjvLXogvb7 85GSBt8MODdKtfeVkDW3NKU9lboSh1E76epIdWnqa5QTMEpnJ4GA2zulU1zNOVP0+GYk 3GPQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=hbyOMPih; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b076e727424sor182774066b.6.2025.09.10.06.59.24 for (Google Transport Security); Wed, 10 Sep 2025 06:59:24 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGnctZyACw6W+C7W5kqvv787k1BZZsXOU8hlDRP5xGwnKs3TGiu7I8bIhVXASZZZY yy+VsNDoDtdrmD+T7yEWp0U2S3eQFUAoz4zobHUtby1IbRb1rJps4HNxD1H3BesL3c81mYCAVK+ VaVlaL7O5zbhhNEIWjfQ4ZAVdRMzmZR2GxX/NB00BxgqEAB38Z7ypjPHCmgdcpmQMSxyZVbWJWx rtBmMUli47FWsRFOCLg37vo5mzWv1bWfqXrhrXLaBMx6mPbYT8qUhTpKjxI0Lvc95xLyTMwcV61 paIjdJkXPOqPHMy1EyEvrlTO1YPKb6SFDd0tc76+W5kQ03a5wrqqfFQU/wJ1oOl7ApIBW6i9+55 Jmear9IZ50weaintWvD51s+uBGyQTR/jOs4Sx7WPnR0NBXORTQc9fQAq0w219sVukK2ruFojOkv GLTnFtWeYZQBZfn2oj1qTdfb2TCBa8wBQd8mF88zcoKApTZNWFCgIafAo4xxU16BlP X-Received: by 2002:a17:907:3d16:b0:b04:59d5:fb78 with SMTP id a640c23a62f3a-b04b1702bbemr1507295166b.62.1757512764270; Wed, 10 Sep 2025 06:59:24 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07833a4e37sm172523066b.76.2025.09.10.06.59.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 06:59:23 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [RESEND PATCH 4/4] Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros Date: Wed, 10 Sep 2025 15:58:38 +0200 Message-ID: <20250910135916.3939502-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250910135916.3939502-1-dario.binacchi@amarulasolutions.com> References: <20250910135916.3939502-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=hbyOMPih; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Replace opencoded masking and shifting, with BIT(), GENMASK(), FIELD_GET() and FIELD_PREP() macros. Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- drivers/input/touchscreen/imx6ul_tsc.c | 88 ++++++++++++++------------ 1 file changed, 48 insertions(+), 40 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index a6066643bd48..e74999c5e22f 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -21,25 +21,23 @@ #include /* ADC configuration registers field define */ -#define ADC_AIEN (0x1 << 7) +#define ADC_AIEN BIT(7) +#define ADC_ADCH_MASK GENMASK(4, 0) #define ADC_CONV_DISABLE 0x1F -#define ADC_AVGE (0x1 << 5) -#define ADC_CAL (0x1 << 7) -#define ADC_CALF 0x2 -#define ADC_12BIT_MODE (0x2 << 2) -#define ADC_CONV_MODE_MASK (0x3 << 2) +#define ADC_AVGE BIT(5) +#define ADC_CAL BIT(7) +#define ADC_CALF BIT(1) +#define ADC_CONV_MODE_MASK GENMASK(3, 2) +#define ADC_12BIT_MODE 0x2 #define ADC_IPG_CLK 0x00 -#define ADC_INPUT_CLK_MASK 0x3 -#define ADC_CLK_DIV_8 (0x03 << 5) -#define ADC_CLK_DIV_MASK (0x3 << 5) -#define ADC_SHORT_SAMPLE_MODE (0x0 << 4) -#define ADC_SAMPLE_MODE_MASK (0x1 << 4) -#define ADC_HARDWARE_TRIGGER (0x1 << 13) -#define ADC_AVGS_SHIFT 14 -#define ADC_AVGS_MASK (0x3 << 14) +#define ADC_INPUT_CLK_MASK GENMASK(1, 0) +#define ADC_CLK_DIV_8 0x03 +#define ADC_CLK_DIV_MASK GENMASK(6, 5) +#define ADC_SAMPLE_MODE BIT(4) +#define ADC_HARDWARE_TRIGGER BIT(13) +#define ADC_AVGS_MASK GENMASK(15, 14) #define SELECT_CHANNEL_4 0x04 #define SELECT_CHANNEL_1 0x01 -#define DISABLE_CONVERSION_INT (0x0 << 7) /* ADC registers */ #define REG_ADC_HC0 0x00 @@ -66,20 +64,26 @@ #define REG_TSC_DEBUG_MODE 0x70 #define REG_TSC_DEBUG_MODE2 0x80 +/* TSC_MEASURE_VALUE register field define */ +#define X_VALUE_MASK GENMASK(27, 16) +#define Y_VALUE_MASK GENMASK(11, 0) + /* TSC configuration registers field define */ -#define DETECT_4_WIRE_MODE (0x0 << 4) -#define AUTO_MEASURE 0x1 -#define MEASURE_SIGNAL 0x1 -#define DETECT_SIGNAL (0x1 << 4) -#define VALID_SIGNAL (0x1 << 8) -#define MEASURE_INT_EN 0x1 -#define MEASURE_SIG_EN 0x1 -#define VALID_SIG_EN (0x1 << 8) +#define MEASURE_DELAY_TIME_MASK GENMASK(31, 8) +#define DETECT_5_WIRE_MODE BIT(4) +#define AUTO_MEASURE BIT(0) +#define MEASURE_SIGNAL BIT(0) +#define DETECT_SIGNAL BIT(4) +#define VALID_SIGNAL BIT(8) +#define MEASURE_INT_EN BIT(0) +#define MEASURE_SIG_EN BIT(0) +#define VALID_SIG_EN BIT(8) #define DE_GLITCH_MASK GENMASK(30, 29) #define DE_GLITCH_DEF 0x02 -#define START_SENSE (0x1 << 12) -#define TSC_DISABLE (0x1 << 16) +#define START_SENSE BIT(12) +#define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 +#define STATE_MACHINE_MASK GENMASK(22, 20) struct imx6ul_tsc { struct device *dev; @@ -115,19 +119,20 @@ static int imx6ul_adc_init(struct imx6ul_tsc *tsc) adc_cfg = readl(tsc->adc_regs + REG_ADC_CFG); adc_cfg &= ~(ADC_CONV_MODE_MASK | ADC_INPUT_CLK_MASK); - adc_cfg |= ADC_12BIT_MODE | ADC_IPG_CLK; - adc_cfg &= ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE_MASK); - adc_cfg |= ADC_CLK_DIV_8 | ADC_SHORT_SAMPLE_MODE; + adc_cfg |= FIELD_PREP(ADC_CONV_MODE_MASK, ADC_12BIT_MODE) | + FIELD_PREP(ADC_INPUT_CLK_MASK, ADC_IPG_CLK); + adc_cfg &= ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE); + adc_cfg |= FIELD_PREP(ADC_CLK_DIV_MASK, ADC_CLK_DIV_8); if (tsc->average_enable) { adc_cfg &= ~ADC_AVGS_MASK; - adc_cfg |= (tsc->average_select) << ADC_AVGS_SHIFT; + adc_cfg |= FIELD_PREP(ADC_AVGS_MASK, tsc->average_select); } adc_cfg &= ~ADC_HARDWARE_TRIGGER; writel(adc_cfg, tsc->adc_regs + REG_ADC_CFG); /* enable calibration interrupt */ adc_hc |= ADC_AIEN; - adc_hc |= ADC_CONV_DISABLE; + adc_hc |= FIELD_PREP(ADC_ADCH_MASK, ADC_CONV_DISABLE); writel(adc_hc, tsc->adc_regs + REG_ADC_HC0); /* start ADC calibration */ @@ -167,19 +172,21 @@ static void imx6ul_tsc_channel_config(struct imx6ul_tsc *tsc) { u32 adc_hc0, adc_hc1, adc_hc2, adc_hc3, adc_hc4; - adc_hc0 = DISABLE_CONVERSION_INT; + adc_hc0 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc0, tsc->adc_regs + REG_ADC_HC0); - adc_hc1 = DISABLE_CONVERSION_INT | SELECT_CHANNEL_4; + adc_hc1 = FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_4); writel(adc_hc1, tsc->adc_regs + REG_ADC_HC1); - adc_hc2 = DISABLE_CONVERSION_INT; + adc_hc2 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc2, tsc->adc_regs + REG_ADC_HC2); - adc_hc3 = DISABLE_CONVERSION_INT | SELECT_CHANNEL_1; + adc_hc3 = FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_1); writel(adc_hc3, tsc->adc_regs + REG_ADC_HC3); - adc_hc4 = DISABLE_CONVERSION_INT; + adc_hc4 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc4, tsc->adc_regs + REG_ADC_HC4); } @@ -194,8 +201,9 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) u32 debug_mode2; u32 start; - basic_setting |= tsc->measure_delay_time << 8; - basic_setting |= DETECT_4_WIRE_MODE | AUTO_MEASURE; + basic_setting |= FIELD_PREP(MEASURE_DELAY_TIME_MASK, + tsc->measure_delay_time); + basic_setting |= AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, tsc->de_glitch); @@ -255,7 +263,7 @@ static bool tsc_wait_detect_mode(struct imx6ul_tsc *tsc) usleep_range(200, 400); debug_mode2 = readl(tsc->tsc_regs + REG_TSC_DEBUG_MODE2); - state_machine = (debug_mode2 >> 20) & 0x7; + state_machine = FIELD_GET(STATE_MACHINE_MASK, debug_mode2); } while (state_machine != DETECT_MODE); usleep_range(200, 400); @@ -283,8 +291,8 @@ static irqreturn_t tsc_irq_fn(int irq, void *dev_id) if (status & MEASURE_SIGNAL) { value = readl(tsc->tsc_regs + REG_TSC_MEASURE_VALUE); - x = (value >> 16) & 0x0fff; - y = value & 0x0fff; + x = FIELD_GET(X_VALUE_MASK, value); + y = FIELD_GET(Y_VALUE_MASK, value); /* * In detect mode, we can get the xnur gpio value,