From patchwork Sun Sep 14 17:15:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4283 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 8EF6C3FA4F for ; Sun, 14 Sep 2025 19:16:20 +0200 (CEST) Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-62ee9a53791sf1965908a12.0 for ; Sun, 14 Sep 2025 10:16:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1757870180; cv=pass; d=google.com; s=arc-20240605; b=hBOJDDiC0ymC6jnpfF0L8zXDUAaeAschNcR8yZSBFW4gt/lcrp0mVNxYPTopVleLDF 3uKOaoXYszJ5/4+pedysDmevbDEJY9SFYcUNu+0Gr10Q+E9p/xHP0Pb1wWyLq5ba+fGi GZMaektnQ+T3FGxjgIf3rPFGmoixUjwSj+BLDUk55r3fvDMSdh1xB1iGX5XG/n/C1U15 36VWv0Ewj84DzLanlY8IZ4HVOKEVfpuOBAAIjSCXlHwqv77cogt+EG7uGVTm0KHdAb6E pouvvDRXKde1ai0vTimX/qkUlHOVuFXr1RHjKa1FuSgM1r/N5NqpMrzNOLFekTFRc3X/ 9hoQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=zGLCQteh9egFpmTweguKizz1GTd5Hz5uePHDEffv4oQ=; fh=8oV7o8g8gALRQp3r5rlC8yXr9iVMeorrpbYrymm86Eg=; b=DNCd9PZsMLzXYg71N1S+3QdEyAPABi79W/r1Azxdi5fPP+hW8CGNUknfOrmzuiHOx4 HSFG6waKrIE6Klu35erndbxdLi+obLM3K0ALzzCrutBCEPiL/B/MQBelD6syqSseFFs0 gVyl6dILtXjqhfcOJRmhAVeQp/MVMHvhfr4XbHYtvocbGoRZ+SN3Axb4MKlrFLexJNKC ctalsTjF4AqfXf6ete7dNAQF80weI9fR3FXxr+R3IUJeQuyC/rUNvgil6jyNEUQB1TaR 1rn/oCXGOWvT1zWyDEXI45IBudvUK4ldojt352bMMwoRnf0A07gE2FpVsC7dCc8pxuN7 PG/A==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=bguk7AyE; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1757870180; x=1758474980; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=zGLCQteh9egFpmTweguKizz1GTd5Hz5uePHDEffv4oQ=; b=H/odK/roq+D640hPmEs6FbvD6s/DG/icp4Bgiu7ZgQLSSDgiKx/yAjab5WZ/IJT8cR HZBsGm/grTRZoTBLJ+KzMZqgQ4PubGIcV2Yggc9xd3Iykx+Jc9DKizn5dlszzFWz6ng8 tx/IkpTK1ujF/rCNHGCNkezjCe3IvCvmVaE7Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757870180; x=1758474980; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zGLCQteh9egFpmTweguKizz1GTd5Hz5uePHDEffv4oQ=; b=Nk6NLrfedkParPD8EQEtuKpec4D/Qfq6Q9+vZE3u/im1Lq/eVSAT1vKL4W4nyvKetR EYl/ehTRgwVIK/o5HRHGd4/SYXfWZpWlgafhWH9WcgVFT//1eLnlTVgPpU9rSvDjK7I+ TFGaltqEGA3/GpWFbJ633L5b7EIsqkM0oIcOVawUYuR6FWBcuK95mdEajNRbzo6SbBSx SgxLlrb4xxqlX5SCXYHVfxF62e+Yt349O/tSLMWnaQ6ygbZH7pG4a76RZVr7rsQybfuJ b0sdH2ZS5JEHY0P+GKBKVuCJZ0tDhGZROoYFOjXBaJaftm+dbNTXgKepSS3CQ70hxN33 Rchw== X-Forwarded-Encrypted: i=2; AJvYcCVvTDD6ZDfVcqhHZVGckhC5lW/CK1EQhZbSG/QwZC3dQV1Mr+K1I3yKeJ/P35Y9pX1ZBllQW815IErFiS4p@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YxovCg/yYcbNtCFrwq943HsAnYaHkJYnr637X/JQzcvH68EhCI8 VD7SVya3OcPq/Dc8g9k8s0CVWsWhvC/j/z5jGM9fI8aQSsRkiNYmJp+f5lq8/BJMjN7x8Q== X-Google-Smtp-Source: AGHT+IEMbr1YU8iYmyXi2PCF26PIn9CzDsOpfTilskwJZPFibYwhDnHJP0SV7F2v1OLh1/cL7hPQ8Q== X-Received: by 2002:a05:6402:84c:b0:625:ec92:9cb9 with SMTP id 4fb4d7f45d1cf-62ed97f056amr9903465a12.6.1757870180176; Sun, 14 Sep 2025 10:16:20 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd6wqMw9honnJkFLmHY1kfMTOpQYSTzby35aHR+XxJYjWw== Received: by 2002:a05:6402:46cc:b0:62d:845d:50fa with SMTP id 4fb4d7f45d1cf-62d845d55b4ls1730230a12.2.-pod-prod-00-eu-canary; Sun, 14 Sep 2025 10:16:18 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUDPg6RyKbWRjAXGFL3m5Pi1LoBvj22IrApvoEo0uIx8awfynvOZtal4Y8ZZWht9PxUyqKnzBiZmB/G6AgI@amarulasolutions.com X-Received: by 2002:a17:906:c10e:b0:b07:dd5e:16be with SMTP id a640c23a62f3a-b07dd5e1716mr682423366b.4.1757870177632; Sun, 14 Sep 2025 10:16:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1757870177; cv=none; d=google.com; s=arc-20240605; b=JNylpcx0kDEfK+/OCR2SzO5R12L/rIfKzo17lFfU4SEDqtjFnXIp/IGV5HTWlEFwmk iNhDI/HNExLBEulPhwyjfC7SRa6qnbtqM4Z0454GB9BYJcZ6JzfOzfLitRxXO4i0HC7+ 29RAjU+/mHi3uELfWWq14LOZmWodrB4bBwIJtd7iJuOhO5N9RGYeyPKiidrmXop7H1Yk dFm5GYuh75fDjcOdhf1pwJt/EjkNuYrOCyyNz4f45FvX22dV/rAnwKUhXsocjIAX8nVN 1x6nY3UQdROQLkatRosgGupLyXpjwcdEBcnDfneuMuWedu+ubiDf90PlQgur0wILVmYi PytQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=v0a/vjTQEtX+/yGwy3GQfrzKjZgyz27Pw8rW7Pi3j2A=; fh=qlpsu/zyGc9dG9OAhxiNqncd0S8FSd+RBflvpNXsHks=; b=gwLtIiDY+C01uOq3YS8rAkuThI+/J5S+WRbwJPhFS08mo2hEXFi+3Ve3PyFBTYOYce Wbjg4hG/nRxISphqYZwBfysfduPw6neEAyjWT6IJgSK6I3EiNxNkscpbeARjzNSYFYKp eRlSLySPeD5lopGg0NMWh6apSD6nYw10xXaxLE/hqTjKqtreWRoSsvYKMK/mphwVs7cM vF//0Wao7XN/CDcmY86F5o3whL8Y4ifsyszmTd0NESjNxTSfb9p/4jir7LgOJGEbz0IY a90WFiWglFzrloRsyVBEE48UkP6JQdsWmm9Q/Wyc1anVC4mSHyUlctP9fsW37DqWL79t sCww==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=bguk7AyE; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b07b32d9948sor361944166b.5.2025.09.14.10.16.17 for (Google Transport Security); Sun, 14 Sep 2025 10:16:17 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCXX/H/qf2HL/hElyQkCd4JxbBzOi4aTrPy48/13qstqzk/PEVOdFhNmRRCr1KC1jyRIFD3OpqIq2Cl9xakF@amarulasolutions.com X-Gm-Gg: ASbGncu35sSK5IO3hNtMA+MuBAJd2Y1SoTW9E/Yetboj6U3bOBkXf8I65+Vpb30Txaf C/qttg18l6tCEaRjylf7msdyUYhrby9RkHg8GhIs8i2E2fB3kM0E1XNQRUw/lRTyUvuCIl+/NJX aBM7gpiRlqgz4ryH/VbQZ4MO6J0FFDduqq4QUc2ZaHR9UhuNoz9/86eeCH6yBsMn7UDiH+dJRKc wdNhvzDW4yabL/2qY4nxo/DXi/NSVUuRZAwpIjcEbeeizeYP/JELTafN1UvW84nnOk79ovzKR2j fBxQatSiphDEjuA3P5EF6FGMt7dXSo4nxcvu/KhaPgbaKLeLU8f75rH7GsjMDEruKagrhD81A8h jvhwCVbm+ICu77itfO5fDRlEONNC8H24SpOY4mbqbnrjJc12Et2QCxyGvo03i/B0OnczFAGrzsM BJkDfsJwAkpq4DIhpPvUgtVX+5haBz86jCKDcWgUsIIFRW91b3AqZiPFADkLKRd4M1 X-Received: by 2002:a17:907:971d:b0:b0c:7269:8459 with SMTP id a640c23a62f3a-b0c726986afmr363002766b.7.1757870177023; Sun, 14 Sep 2025 10:16:17 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07b334e76dsm776980466b.102.2025.09.14.10.16.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Sep 2025 10:16:16 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Michael Trimarchi , Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v2 1/6] Input: imx6ul_tsc - fix typo in register name Date: Sun, 14 Sep 2025 19:15:58 +0200 Message-ID: <20250914171608.1050401-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250914171608.1050401-1-dario.binacchi@amarulasolutions.com> References: <20250914171608.1050401-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=bguk7AyE; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Michael Trimarchi Replace 'SETING' with 'SETTING'. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- Changes in v2: - Add Reviewed-by tag of Frank Li. drivers/input/touchscreen/imx6ul_tsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index 6ac8fa84ed9f..c2c6e50efc54 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -55,7 +55,7 @@ #define ADC_TIMEOUT msecs_to_jiffies(100) /* TSC registers */ -#define REG_TSC_BASIC_SETING 0x00 +#define REG_TSC_BASIC_SETTING 0x00 #define REG_TSC_PRE_CHARGE_TIME 0x10 #define REG_TSC_FLOW_CONTROL 0x20 #define REG_TSC_MEASURE_VALUE 0x30 @@ -192,7 +192,7 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) basic_setting |= tsc->measure_delay_time << 8; basic_setting |= DETECT_4_WIRE_MODE | AUTO_MEASURE; - writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETING); + writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); From patchwork Sun Sep 14 17:15:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4284 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 56B003FA44 for ; Sun, 14 Sep 2025 19:16:22 +0200 (CEST) Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-62efab531d8sf1411445a12.3 for ; Sun, 14 Sep 2025 10:16:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1757870182; cv=pass; d=google.com; s=arc-20240605; b=UCto0KVXn0452znKNXUbWUoU/844VIbxgiQJA5txYvlkt/QYbjo4L+md2dolycNbLo CsRdRdy/NxYPu1jYnRDC7sR0cYjyO0HNzJsbAteqahyghFZdi1XWvdpBLFvYFF2/3H91 MHv84OGqME8XurPzzgwoE1iEjLyC1tXgVHTs77XDfxtKChAvzPeo0hX/wZp2B6HmJ48k yBFkRsKwHSNcYUX50cTn9RUn4S7CJ57zuFnvsIEPsjJGow1paJY/zajyoYamvRUUKDpx ENOZxBKXC9wQy+2eHoGeW2EE5nsnK4qRrAKCeXdCrdBwpQfYMoRMlgu+AtkgVbf7q4s2 TvPw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=ot3VmZ+boF1x4NVi/L3plaINCZaH97iELO+mpw22L94=; fh=12aTbU+HkKh6QOWrDN+KUcGix+A3WgA4RvTsYkDVQ0o=; b=VLZUXlTpuBz/DgQdHDJd5ZkMKXtt/RTf89bu8fe9+3fc90hYB7JFlCiBVsy0abIfik UkM5ZAx8UIWHVrC6nWhMmBywTmmu5OtNBjrW6fwMpGRIAsf+e5TglB4nT+2GI4D85mUi 6lxDBCLWikul2pOEL1JfwRMecobd12edCp/iifBTtR+4gQGCCiUr3Jeck2lzziX5h9sL NZnZHPb0CYFHnyfBIe6eewoo/N8VAPSQlyfdKvZm6UN1zG00CMnJDwC1lOEYtG2KVsSR rKg58xRW3AjopXuz/VkIJgcfROa+Idl6xH7YPcF1Hi1d+t9pck/vDc41sTU1xNnn/qdd SI7g==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=h26Ojo3O; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1757870182; x=1758474982; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ot3VmZ+boF1x4NVi/L3plaINCZaH97iELO+mpw22L94=; b=afVBJezRdBegwk1H2+nBdPEmHvd288bLe3Y0c+nxq/0ar4qKM1uJUFLVGejQ8wyO7s +jbaXNMz72fkoyK1Q7IhEBxg6nq+g+SCHx0bB4qtnSKDlbZU8bqr0a1/0xqffU3K6cVw FnW7L34vZD3Cyen+ioLENymqtgXEA+DdrEquw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757870182; x=1758474982; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ot3VmZ+boF1x4NVi/L3plaINCZaH97iELO+mpw22L94=; b=RQvlT+3Xe/yB1MWGrHo0z88C7hZ1aHBQsSaooYkHD9ufAEkr55fmODQNrs097QWSxF qb+Sht2PkQFW7F4Ek3er+AB0TWg2gOljFBbdGAbCQOQ1MYGi0WhEiytaVfVwVfY0wbfp PkoRd/rQN6obcy6sccKN/Yn++K5oY4/YfkRHRnD+DBhC3rFkG5TbsXp4aeu9D4FOXkgs mv1RjcEbAbFZNK6LvT1yqdS0yJ0eFZ3ntKGKuMNI0VAe5AzqtMm2uuIzvz9tXVHRtxH+ RHcUhj5I7t8axQR2cKwivWLbSdYTfibgR3AwZFBoolA/I0RYgNdRVX4jTiUlO/DXg4u6 4GqQ== X-Forwarded-Encrypted: i=2; AJvYcCW6u2gL9VXyM3sp4wJxk+LNaEIZ0aM0nZS7EV/bMV3XROO7JXI0c+ehmgBtjilABBWNNRXGuBIlfAjh8tUW@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Yxv1qs505qjUduZqBMRazMWYJZdQIjZGEQ7GN2t/6IixbXA1xxM fJm05Zf18r86PhcT598nVcLjq8JLZTBREF60EfAXPJqbKw4qRFrQH58Pl00eSfrPcdIdBQ== X-Google-Smtp-Source: AGHT+IHLHn2pIhXLZ2NKJWx0nFJKfOjGhRPomRu6pQU6M2gF8IDEuRAGvz8sJsT6bHN24s1rDusrWQ== X-Received: by 2002:a05:6402:34cd:b0:62f:2c1a:920e with SMTP id 4fb4d7f45d1cf-62f2c1a94cfmr2728553a12.28.1757870181743; Sun, 14 Sep 2025 10:16:21 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd6ZkMrDTo8+sf+dh1elDbDD6U0eLvxsZSg/AUeHjCbY4g== Received: by 2002:a05:6402:a0cf:b0:61c:ef7f:7d32 with SMTP id 4fb4d7f45d1cf-62ec03bacf3ls2795604a12.2.-pod-prod-05-eu; Sun, 14 Sep 2025 10:16:19 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCU+DvW3JIPDpLVg4CWgMKYl1OQXfeJQgSd41dz5X3wam5ylRo4Z1OBkeEbSgva1O/3XxJEPELpsN5OIpEc3@amarulasolutions.com X-Received: by 2002:a17:907:d90:b0:b04:858e:c200 with SMTP id a640c23a62f3a-b07c37e11cfmr940579566b.32.1757870179264; Sun, 14 Sep 2025 10:16:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1757870179; cv=none; d=google.com; s=arc-20240605; b=ij9Hu5pnEJibwkW1NSL1UUNW/fLVC/e0sg/0b4b87sVGFwRF4xVqk2VwonmJWnkuHR c/urCcseAVyxq+WlwukGYNg5HS6RYiKJ/6ctuVngoMRPP/pa0IuyVCLVPvOjjIG7jm81 C8tXJO2BupWJNYEYAGHVXwq4BMORtNIJHLQ/ZadmC4ZrmtElN/JT5pTG+8GT5kOP0pQb MYwB1v+oPHbdFlIKpxSH05cSZg7EKrRY8+o+JKssvcv6IlRjLgkyHTirJL5UiMIiTNlg jruLxDSJvaO733ihR//9R8y0g1G6tFO7OedaZVhieHmKvMtSpYxXFD1qLyjIbEJleNvQ TTbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=VnBZKBOJmiN67eQQM1Bf1khwvZJgal4hwMc9eP3h39w=; fh=gLSIshb9VzFk3mkgfXzx0b00rwFxwO/rjRKjOCeSzDQ=; b=k24BDbLDNSyaIVAwa4we85Bi++Ffxsnd029gPtyQtUo+B1WPOVdQ06CBdLJU4ZYR8q dJOMrIA+dI2jV0c1A3/zdD4mNs8mHhIDpC6LAC2ougi3XZUDabgj2Ad285X/PexhIRoE MyxLIXHc55mCQjv3xCKRBP5qOb+TCA0R0JVIHMmHqyjOsf9WKzvbhGUqTl2fUOoOyhb8 Ojrbu9/bpo90XHhCyD2iXx7MvzCosYaEvuIiRw9vHtPw/8M9zpOI6ft0kYDmj5fjGk+A C0BAGx/i9tqFNvw55VBhviMlr3cz2YuKtSUppzz3diUwlxcjpZSCao2G1oUSapIyU63w 3l8g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=h26Ojo3O; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b07b31280c7sor284169766b.5.2025.09.14.10.16.18 for (Google Transport Security); Sun, 14 Sep 2025 10:16:18 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCUkmyBFGQNP2tUlcctrPaf0AV+Z7rYgM2MXIQlyAo5w1KrVfjUJvGgwIya0ejqrO5CO2lcUQX88lOTq1Hhm@amarulasolutions.com X-Gm-Gg: ASbGncsz2E0+2SBUWKXtXMLv6emVSvxI1WvWNpGy+STqmmVd3azuu+rBcCY/tQGKeZ5 oZSiXJAF9HtbY9VwaVHe1Lpdftm1hZeJejzGt+T5NFNg6rMkOgnA1JDi0p+xIkFLV0Yl66p89T4 E3xpH/15YxkA2FWPTZKxLCQ5AVX6+zwRErSbDYopI3dU7vMNBZmYswB9YDdVV96qykpu6XhvTmW Hbrq8FHq12Na11Rqetcbt3Tj9bLEaybRLLEtAM0ipkpYddNV8BG/0fJT6gsA5YwvXezc9pFhi9H xALmL1x5V3Mw0ou0uRqLp+CIh210ZdNgUL59CjRaSOn4pjLGluFpI3fdHMuxMAZyG/Qi7vS1rTb HYyHWVZJjXLrqG8DZ6ZM2EtTv1Bz4LcbRIWvTTBPiBnfEPeabsqKbYD7aL/aXl+5rxqOX8hkDls um3XZW71hI0TZ68+8ZTlVoxa5eD9xppTMBRz59n1wiZJBI52Av642qayzeqCAJ+agP X-Received: by 2002:a17:907:2da2:b0:afd:d94b:830d with SMTP id a640c23a62f3a-b07c3a7b887mr976251766b.62.1757870178516; Sun, 14 Sep 2025 10:16:18 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07b334e76dsm776980466b.102.2025.09.14.10.16.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Sep 2025 10:16:18 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v2 2/6] Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros Date: Sun, 14 Sep 2025 19:15:59 +0200 Message-ID: <20250914171608.1050401-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250914171608.1050401-1-dario.binacchi@amarulasolutions.com> References: <20250914171608.1050401-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=h26Ojo3O; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Replace opencoded masking and shifting, with BIT(), GENMASK(), FIELD_GET() and FIELD_PREP() macros. Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- Changes in v2: - Add Reviewed-by tag of Frank Li. - Move the patch right after the one fixing the typo according to Frank Li's suggestions. drivers/input/touchscreen/imx6ul_tsc.c | 96 +++++++++++++++----------- 1 file changed, 54 insertions(+), 42 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index c2c6e50efc54..e2c59cc7c82c 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -20,25 +21,23 @@ #include /* ADC configuration registers field define */ -#define ADC_AIEN (0x1 << 7) +#define ADC_AIEN BIT(7) +#define ADC_ADCH_MASK GENMASK(4, 0) #define ADC_CONV_DISABLE 0x1F -#define ADC_AVGE (0x1 << 5) -#define ADC_CAL (0x1 << 7) -#define ADC_CALF 0x2 -#define ADC_12BIT_MODE (0x2 << 2) -#define ADC_CONV_MODE_MASK (0x3 << 2) +#define ADC_AVGE BIT(5) +#define ADC_CAL BIT(7) +#define ADC_CALF BIT(1) +#define ADC_CONV_MODE_MASK GENMASK(3, 2) +#define ADC_12BIT_MODE 0x2 #define ADC_IPG_CLK 0x00 -#define ADC_INPUT_CLK_MASK 0x3 -#define ADC_CLK_DIV_8 (0x03 << 5) -#define ADC_CLK_DIV_MASK (0x3 << 5) -#define ADC_SHORT_SAMPLE_MODE (0x0 << 4) -#define ADC_SAMPLE_MODE_MASK (0x1 << 4) -#define ADC_HARDWARE_TRIGGER (0x1 << 13) -#define ADC_AVGS_SHIFT 14 -#define ADC_AVGS_MASK (0x3 << 14) +#define ADC_INPUT_CLK_MASK GENMASK(1, 0) +#define ADC_CLK_DIV_8 0x03 +#define ADC_CLK_DIV_MASK GENMASK(6, 5) +#define ADC_SAMPLE_MODE BIT(4) +#define ADC_HARDWARE_TRIGGER BIT(13) +#define ADC_AVGS_MASK GENMASK(15, 14) #define SELECT_CHANNEL_4 0x04 #define SELECT_CHANNEL_1 0x01 -#define DISABLE_CONVERSION_INT (0x0 << 7) /* ADC registers */ #define REG_ADC_HC0 0x00 @@ -65,19 +64,26 @@ #define REG_TSC_DEBUG_MODE 0x70 #define REG_TSC_DEBUG_MODE2 0x80 +/* TSC_MEASURE_VALUE register field define */ +#define X_VALUE_MASK GENMASK(27, 16) +#define Y_VALUE_MASK GENMASK(11, 0) + /* TSC configuration registers field define */ -#define DETECT_4_WIRE_MODE (0x0 << 4) -#define AUTO_MEASURE 0x1 -#define MEASURE_SIGNAL 0x1 -#define DETECT_SIGNAL (0x1 << 4) -#define VALID_SIGNAL (0x1 << 8) -#define MEASURE_INT_EN 0x1 -#define MEASURE_SIG_EN 0x1 -#define VALID_SIG_EN (0x1 << 8) -#define DE_GLITCH_2 (0x2 << 29) -#define START_SENSE (0x1 << 12) -#define TSC_DISABLE (0x1 << 16) +#define MEASURE_DELAY_TIME_MASK GENMASK(31, 8) +#define DETECT_5_WIRE_MODE BIT(4) +#define AUTO_MEASURE BIT(0) +#define MEASURE_SIGNAL BIT(0) +#define DETECT_SIGNAL BIT(4) +#define VALID_SIGNAL BIT(8) +#define MEASURE_INT_EN BIT(0) +#define MEASURE_SIG_EN BIT(0) +#define VALID_SIG_EN BIT(8) +#define DE_GLITCH_MASK GENMASK(30, 29) +#define DE_GLITCH_2 0x02 +#define START_SENSE BIT(12) +#define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 +#define STATE_MACHINE_MASK GENMASK(22, 20) struct imx6ul_tsc { struct device *dev; @@ -112,19 +118,20 @@ static int imx6ul_adc_init(struct imx6ul_tsc *tsc) adc_cfg = readl(tsc->adc_regs + REG_ADC_CFG); adc_cfg &= ~(ADC_CONV_MODE_MASK | ADC_INPUT_CLK_MASK); - adc_cfg |= ADC_12BIT_MODE | ADC_IPG_CLK; - adc_cfg &= ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE_MASK); - adc_cfg |= ADC_CLK_DIV_8 | ADC_SHORT_SAMPLE_MODE; + adc_cfg |= FIELD_PREP(ADC_CONV_MODE_MASK, ADC_12BIT_MODE) | + FIELD_PREP(ADC_INPUT_CLK_MASK, ADC_IPG_CLK); + adc_cfg &= ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE); + adc_cfg |= FIELD_PREP(ADC_CLK_DIV_MASK, ADC_CLK_DIV_8); if (tsc->average_enable) { adc_cfg &= ~ADC_AVGS_MASK; - adc_cfg |= (tsc->average_select) << ADC_AVGS_SHIFT; + adc_cfg |= FIELD_PREP(ADC_AVGS_MASK, tsc->average_select); } adc_cfg &= ~ADC_HARDWARE_TRIGGER; writel(adc_cfg, tsc->adc_regs + REG_ADC_CFG); /* enable calibration interrupt */ adc_hc |= ADC_AIEN; - adc_hc |= ADC_CONV_DISABLE; + adc_hc |= FIELD_PREP(ADC_ADCH_MASK, ADC_CONV_DISABLE); writel(adc_hc, tsc->adc_regs + REG_ADC_HC0); /* start ADC calibration */ @@ -164,19 +171,21 @@ static void imx6ul_tsc_channel_config(struct imx6ul_tsc *tsc) { u32 adc_hc0, adc_hc1, adc_hc2, adc_hc3, adc_hc4; - adc_hc0 = DISABLE_CONVERSION_INT; + adc_hc0 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc0, tsc->adc_regs + REG_ADC_HC0); - adc_hc1 = DISABLE_CONVERSION_INT | SELECT_CHANNEL_4; + adc_hc1 = FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_4); writel(adc_hc1, tsc->adc_regs + REG_ADC_HC1); - adc_hc2 = DISABLE_CONVERSION_INT; + adc_hc2 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc2, tsc->adc_regs + REG_ADC_HC2); - adc_hc3 = DISABLE_CONVERSION_INT | SELECT_CHANNEL_1; + adc_hc3 = FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_1); writel(adc_hc3, tsc->adc_regs + REG_ADC_HC3); - adc_hc4 = DISABLE_CONVERSION_INT; + adc_hc4 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc4, tsc->adc_regs + REG_ADC_HC4); } @@ -188,13 +197,16 @@ static void imx6ul_tsc_channel_config(struct imx6ul_tsc *tsc) static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) { u32 basic_setting = 0; + u32 debug_mode2; u32 start; - basic_setting |= tsc->measure_delay_time << 8; - basic_setting |= DETECT_4_WIRE_MODE | AUTO_MEASURE; + basic_setting |= FIELD_PREP(MEASURE_DELAY_TIME_MASK, + tsc->measure_delay_time); + basic_setting |= AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); - writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); + debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, DE_GLITCH_2); + writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); writel(MEASURE_INT_EN, tsc->tsc_regs + REG_TSC_INT_EN); @@ -250,7 +262,7 @@ static bool tsc_wait_detect_mode(struct imx6ul_tsc *tsc) usleep_range(200, 400); debug_mode2 = readl(tsc->tsc_regs + REG_TSC_DEBUG_MODE2); - state_machine = (debug_mode2 >> 20) & 0x7; + state_machine = FIELD_GET(STATE_MACHINE_MASK, debug_mode2); } while (state_machine != DETECT_MODE); usleep_range(200, 400); @@ -278,8 +290,8 @@ static irqreturn_t tsc_irq_fn(int irq, void *dev_id) if (status & MEASURE_SIGNAL) { value = readl(tsc->tsc_regs + REG_TSC_MEASURE_VALUE); - x = (value >> 16) & 0x0fff; - y = value & 0x0fff; + x = FIELD_GET(X_VALUE_MASK, value); + y = FIELD_GET(Y_VALUE_MASK, value); /* * In detect mode, we can get the xnur gpio value, From patchwork Sun Sep 14 17:16:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4285 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 1BDCD3FA4F for ; Sun, 14 Sep 2025 19:16:23 +0200 (CEST) Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-629f069572esf3650397a12.1 for ; Sun, 14 Sep 2025 10:16:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1757870183; cv=pass; d=google.com; s=arc-20240605; b=E6+FrKgLfxrwhADncfIik4dQsx15DIkV8fUeK/8e52A5yEyoP7iQv1NU/Jj7SUVDGR B/JO5EpYaFJiYYW7x/+io0nL/zj4xuoy7oCkU9iIXMWNDWus3cABS6LAgaqCr/IJ9JOl lkAlRWhy9u4yaPNB+tHdmmK3jwuzIttsz+byWWcKKyoiGUGGhvRBSNOhj9/3eNx10cfK X5L4b3sUBq1vh1/ZKKEgLNSsxTJRM6jmj4mkp2DvY7NPoxRiy7R0gBJJmPrGhZI9a0K6 cBhx7CEcKmzH/brU0B2mMl48lqGHC/d4siwxR4WhI7FRWNO7wxXjCFPQkRG63WmPM+DB FS1Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=sTHBit+RJ8lLRUPz1dTMVjXQJk3fNzlOIPorGOXIg/g=; fh=744Suq3kcXLPjTtlaJnZAi6+VTuTvGJVvPW57cQsoUg=; b=O1GsiQuImgkLxSJEBENMZk6rChxPJ2L5J/f3ZJqo6DlpDljKnwaOUZhcYqy59l6ijp EuBK+BXsHp6nWONVoryPiqLICFGfyscNeCXav6HYZN683tByZKQdQZWaBYQ4tTsgSsxw Kxlakxsi6q6fYrUAMHASflPwe84FADARgSxT3HLenmZrrmXnZcQmgod5snL3Kc+H5zb1 NXn/PpRJ5BldnLBLSwqp8aMr3nvgktomEo95QNs/PJVGPzONh7QsweO8C8PeLV243HSP pyjTJpJwyqHQKX68wlHmhkQBdKznba83NjbNhhCYDIKlUR/CfCet8/G9K2BYEJnbTAMC LXvQ==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=EI7kaw5Z; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1757870183; x=1758474983; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=sTHBit+RJ8lLRUPz1dTMVjXQJk3fNzlOIPorGOXIg/g=; b=jb9SGpzUTkxQeEzrtlJrIZrh82zKj0d5vj9qD6ml2KnakWtFgE2oM3Tg2nALGHgfm3 802+bZ7RQbWZ8g+3A6oLxmRltxKkPn6rXkJMyXRhhH77Jy+adeOmuhVFCyCiaiGXuKQe s2vtvWjZ5pEc/CZWB70SD/iNphSmOblnFq5U4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757870183; x=1758474983; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sTHBit+RJ8lLRUPz1dTMVjXQJk3fNzlOIPorGOXIg/g=; b=EnYHyghRSrrd6p2Fg0lo6QisBnKplP0SBhTMIoG0yDlG//eKgCCYAOV7n6okLdkgTd h8L48Wlvpi1ioEmjhuTA7YNg5sk80TC656NNPo+q+XJx24ooxu2knRrEWk5ojURFT1Uu 0zjsw0sNvmdjvGU4CsGyM94rBhVETS8jaCNkz8U/aKb3CJeDWaHn4MIVEIks5yLc+0yE NgkrqGx9bf6e9iTUe7MfNXF6FF1GHIPIqaKeHXmJiAHbey2h+pERbPfRZFh+oMp+BJse lqgR4Raeg5FUYxZDDwfPkIQEXy09CdPNgLaom6ph+iAS6y3gF1+VqTTkHKep6P+G6IH+ QcLw== X-Forwarded-Encrypted: i=2; AJvYcCXmhYtFHwoqjaDb73EFaPXFI3EB5hUVcTmngLwONivQkfyfpdpjDBd1dpFjeI4au+PtprxbRJf2m2DZ/KR9@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Yy/3VWEWgOGMBn95flWSgQiJfFA2fcKQ9kWVrPn/VR0WrykJS15 39jw7ZrJKUk0VBfWxALfPCM5VCiT7tdlWuSEz1LHMjdKmJzPd/jwbbTPOzJhYHdNsVW4qg== X-Google-Smtp-Source: AGHT+IHXeW0oz22l48Gj7Y8WG/T+lVmezSaTEPav7laubYJnVM5ueeHs76HXvA7Jf35gkmaBD0xxeA== X-Received: by 2002:a05:6402:354e:b0:61c:db49:aec0 with SMTP id 4fb4d7f45d1cf-62ed97f06c9mr9799138a12.5.1757870182730; Sun, 14 Sep 2025 10:16:22 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd5ggZtlRP3UCyPABKJ1s0nJUrNgjujxcDRc9t7KPOM83Q== Received: by 2002:a50:d69c:0:b0:62f:36ff:5232 with SMTP id 4fb4d7f45d1cf-62f36ff54bals87695a12.1.-pod-prod-00-eu-canary; Sun, 14 Sep 2025 10:16:20 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWvv+ZJEGFzs5OpRgZF7q90V+La8twybB/SECkp3vBMc5WPTFCevzf+nxhuJv3nZniDmzraAinFX/O7MmBH@amarulasolutions.com X-Received: by 2002:a17:907:3e8d:b0:b04:16fd:9539 with SMTP id a640c23a62f3a-b07a69272b3mr1409866766b.29.1757870180272; Sun, 14 Sep 2025 10:16:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1757870180; cv=none; d=google.com; s=arc-20240605; b=FdBvx63bIilWOdTKd9R3ZU9U15wqw6Vm8ZGD/9lJ0nR7cS2bm3QEDNttasqycKOxKD +6IPnYHPR/d81FNbUcF0NXy6HTw+ji3gs9VYZTf34AJcp6gih6W7Rut+tOQ7eD3ocyVr PqxXQLv2EIcjLWudgZcgr3hMjaZZDPJWVWkAaOTSXJxZW/4cK1Adi722abeSvab+Rj+e P+wVT7waTZalRKAyWB4X8uR0eU0bDzzkuR7qT804zaGBGPFslZwRs72xtpUmmxK5fImf ZBN1YsMexaccOD1+/bUMb5hddVGZqLKnsT2aG4rZ3O1lP7xCkbzrrhJWq3lBB264sHnL 3hAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=Sx0EwU0te/usZ13a8MurPgLe0A2g8omNenFnNxHAiqE=; fh=c28QrtMEck3oinslt3uvX9SQiE6QAcF8lhYd3C4gbeM=; b=UDm06mrt1LIS1O/eocnIZi9WU9rteBPansMFSE5cFishCOiVYaHXupvWojGb1AxLyO 62QGlH90f5mH4JdzYJW5IXXNmSsyorgBRMn1l3p8YN1o58FdM0gX6hDYuKRrTsTgOtcE nfiFw8dCeAZpT3b0LXhU4EM4zSPmbzE60L9ProgPlDJLmk+sf1+mPNL9IwGI0tv5aQHd 96kvcNaDbEvgcvmchuTRw/MjNZl4J9ysVFeqK02Xg0CWbhvskBIMvBBtExZFRAldCPGB pSQaTuaB7c98weueDr0oXS5Ds0U/v9zT2VW5gBROm70GVqov+ZAp/QRa8zWuoD5Kuch6 7Npg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=EI7kaw5Z; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b07b32f2a62sor401306666b.8.2025.09.14.10.16.20 for (Google Transport Security); Sun, 14 Sep 2025 10:16:20 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCWcVVBoFRNM4IU0zkcsVkdiKgRJ6pn50owAYXFiL+oA2G9fzBGJz/3oEOPHArCtyO1ERBgSZercSoDNRgGR@amarulasolutions.com X-Gm-Gg: ASbGnctZ4SZQdiODPGWmmdMWZ9JqcDMorskMc53dAJ6eQAuQ4PYnZ9KNXu7NQO/lBjy eANGH7BERSnDyVcsAt67jAZN4LPKPKib0rEQ4PBVSlUTr0OR0XCCGOEqFETunHAwBW1xzmcQoj4 eNd0sMxu6eIg4Xwlo/WXLYzmfyvFqfzhw1Vl/afkc/O4ffeni8KuVSs1ReHZikbuabvri3DzFQS g9CG6xuJbsFtlHZ4domU2e2bcPhCc4GCKwpvYDKVoW5ZFolA/Gj9lMEjprYnBAozA1gMDPaEbA7 RsYBbynbcqRO5YrD91q0hYmSpkp20sNN+VyomkC8s6MFTes5hXC0UNZqwysbqqoqO3nIppd6mZO iEWYUVyIsHzHi+gCn9vWO1MtmXWHzS1rSV/surXZnImvkpsqK53yl/2woYZl9e0sLc74+fZc/ss fcsmOVn1AFS8+0Cb4iqn3hNMtfloMutpR09eq6c7firWWMqJc3pwu2ETN3ottUPyGUXmwBzdV9T zg= X-Received: by 2002:a17:907:d8b:b0:afe:8de8:290d with SMTP id a640c23a62f3a-b07a629945emr1504682966b.6.1757870179840; Sun, 14 Sep 2025 10:16:19 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07b334e76dsm776980466b.102.2025.09.14.10.16.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Sep 2025 10:16:19 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Conor Dooley , Dmitry Torokhov , Javier Carrasco , Jeff LaBundy , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH v2 3/6] dt-bindings: touchscreen: add touchscreen-glitch-threshold-ns property Date: Sun, 14 Sep 2025 19:16:00 +0200 Message-ID: <20250914171608.1050401-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250914171608.1050401-1-dario.binacchi@amarulasolutions.com> References: <20250914171608.1050401-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=EI7kaw5Z; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Add support for glitch threshold configuration. A detected signal is valid only if it lasts longer than the set threshold; otherwise, it is regarded as a glitch. Signed-off-by: Dario Binacchi --- Changes in v2: - Added in v2. .../devicetree/bindings/input/touchscreen/touchscreen.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml index 3e3572aa483a..a60b4d08620d 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml @@ -206,6 +206,10 @@ properties: unevaluatedProperties: false + touchscreen-glitch-threshold-ns: + description: Minimum duration in nanoseconds a signal must remain stable + to be considered valid. + dependencies: touchscreen-size-x: [ touchscreen-size-y ] touchscreen-size-y: [ touchscreen-size-x ] From patchwork Sun Sep 14 17:16:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4286 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 7CE1A3FA44 for ; Sun, 14 Sep 2025 19:16:24 +0200 (CEST) Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-62a3d0ff34asf2785134a12.2 for ; Sun, 14 Sep 2025 10:16:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1757870184; cv=pass; d=google.com; s=arc-20240605; b=c09oBTaLfl3hYsJazS18FaC2AKE5nVbHmorsto+geB1E0rb8STrv4akcWEh+spHHQH g+amHIhTLY3iGG92adweIJed2FdR9vvb5zqxb19YKoYmHX3l9iLKYeLph9rL07vlrLDL YSDZ5ktmSxyZOlC4zBxbp2MCNkaRDturCDNZ0j7QEOZevVNwPMDWikHSrVsppfQ8gzhA DOatUPsprbQ0N/gFJWNhxk7S8sEmgk30eT/Y/5ALSa67BoDmcqp991QZ1mEyqCU6Xer0 KfkDBLPkCmSugXCekIt7AJcxO9tsQ9A1TOKHrEyxiqeqBAVMGqXzzQlam25AcpdjVARx MMZw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=ljMWxV5yQ0pEaBLmWO5AZkWHkxxyruQy+uSMjUwpJYM=; fh=yOPhSgEwBWYlCPS//kgdZqqSP8Yd7gqgnCGpCC7nHlE=; b=bAcrPOgk2U4DBPVP7RiBJaTl4JObXh9YduhEX8CifDg3yikI92ggDrCE0LKCQhF0DL Np6aOPtUNaL5g3mY6yrcsCD+t0y2AgdWRFhA0GeL2FvPkdz/gVsnA33KTX9Z4YhEv7Td khS73dwPNlCKRZ9nhqO8ueYu/vZEJURfHXd+7+mRjtGsERQiPZCh6MjOoOfUpvfJ5+Ys tcFiy6W5u8yPc5w+c6X/SfU6UjmYkPXHcbCUkNCH9RD1BbQsxMvydHmY4LlaiLQYAH/v dQRzApm43CTLxTeBP2t18WHmDqFCdFAI0OVUeqGRCQ4CDpU0Hs+MxQqXGqbTax9rl2Ui kcPQ==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=FFAn+Yjw; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1757870184; x=1758474984; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ljMWxV5yQ0pEaBLmWO5AZkWHkxxyruQy+uSMjUwpJYM=; b=GAOh4jvo9KuweBIHu0lSCRmJpjEAbStp4E3+dCK9gVBOfoN5nejULIxITpozsRxekc XVi/EOOz6yh7thJ1hB8oCy9xhw40M+rjcY19YgiMP/W9MpEwUtrxYLeorfSoosSmA6ER wn+bJRPGJZOBoNfcfjzN7sgxF7PYbRzcyeJqA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757870184; x=1758474984; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ljMWxV5yQ0pEaBLmWO5AZkWHkxxyruQy+uSMjUwpJYM=; b=qW15nSn/z0YG6d1QE+ljoYG5FyAVJj4XTVehM8rbiLwC9b5v/xJhbuIFD0mQ6N1f5A Zc6orrG4bjLCvl6a5ETf7dAT9wMaMI6HMZpCV20lOQxRgaM/kNGSSqMZKisBR1whjsmx yKftPafKHCp+ZPRpoOHslBLJdiUU1daweD8+C+kxekzBFL1AIx7tHtr+Q8oquZXa32bf 5yDHUMMYobMOMVvdwcUFw9++KF/LdnTI3Q3/7tWhy2pM2IYuy4y5eizsQ04Z13W3wj2h PWIq/fa1RzQrWS7AIZmxaksPAy/RepBY3HlwcdLU2gILDucX7jdOSUogNtlyLs5BTKMV tzxA== X-Forwarded-Encrypted: i=2; AJvYcCU7WKjobzjlPWC2juVoEk+Nbp/qKkoZy7JECyCDSNXJ9je5TIEJphf495dLSaappfw2WmC4GfZDun3ny67r@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Yxu72mkXmjodibdEdJ1C2WHtVM3IaxcQ2jv6xoj3QrEh5guIyLX ZdyN12MXAikquUxaz5HYS80U2hS/dgDeDUihXlJUQl+ZudOUxccDREgOLCPFoypE0X3Ryg== X-Google-Smtp-Source: AGHT+IHgB/IMtjEqZNlAc5Y4SyRFgTPCTyTzHmg7cKqN42qi6BiuPNeRoT2+oyBQvl9ccFAcY2yzhQ== X-Received: by 2002:a05:6402:34cd:b0:62f:2c1a:920e with SMTP id 4fb4d7f45d1cf-62f2c1a94cfmr2728706a12.28.1757870184153; Sun, 14 Sep 2025 10:16:24 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd4V88kDEdqign4uDNxtPih63epsB0P1qlW59UgBjIVGVA== Received: by 2002:a05:6402:a0cf:b0:61c:ef7f:7d32 with SMTP id 4fb4d7f45d1cf-62ec03bacf3ls2795619a12.2.-pod-prod-05-eu; Sun, 14 Sep 2025 10:16:22 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWo14R161SelUkbVBtR9mEaaAyBXGMyEdWJVcLkF88VbvTfPW71gM3E2miKj9ab3vb9ptZvMP9DU/yJFMub@amarulasolutions.com X-Received: by 2002:a17:907:86a0:b0:b04:e44:4598 with SMTP id a640c23a62f3a-b07c356d2e6mr945939566b.14.1757870181854; Sun, 14 Sep 2025 10:16:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1757870181; cv=none; d=google.com; s=arc-20240605; b=NYt6t65LjMJ2D09wpyW49SbM9PDEqI4v253Wg3knFPsnkbjVbR2LRAnDHPgux70w/M 2ydizkIMBlYm7y21Lte5bzgFdiHDwyHjZAsCFhxOz7jAKqqGf6+Pxq3D2MXlvDzMNMtb O5DWOBRw1KiFY3dcqMYdW+dhkIXyL98T6v/zstSYAHq1GBElB+QplDd9vjx76+4OvIO4 ZhCQ1oFvU7t1gCCRKYMNq/a7inueLdcPsk28gKBZoyTcs95wBndXCAJZKd03HL24oWWI Z/uIxLdx31KXssa/K9OcAnMZ5eO8TxH55tpH3OhtkF/DUvDF9OrBEcwozNQmYoEzvX5U 3oqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=WMdgI0iZ2TvocV4JZ7DyZgorR1pQL3heQi0CeqfMARw=; fh=rlEYMGw5lUiynce/DefRP1bvHhZA5MmcoOnRNsNUCWs=; b=hYfvDKPYFdrFKbfbLN3eFziKUXkjCawu+IS6KaZmiJHpjE/axWDdBz5lWKds1362Ym hbtQeh/nk93JUhHfqEXGMpeKpSKHLvPsf3k3/k6kVMejimalzg68Sjhv/DOXzGBNMvLl 026v0nLfRqqI8Wmtb5h2GaPn+zyZ7psd1IVOQa7YFT/0Amn0S+Gs7sN2YdzcoU0B8AVE l3jCrdyztszZfKABLdwerWM6+lYdUhyrXAml83wbmZ8gLAQLkzxom83YVGt84qYXDasR Bs5kYZWzxYWba5n1wPwQulzTSEWlzuKj6vaU6MYK5Cfua2l6MyxDlFVFwvWi+jKZWZPE 6suw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=FFAn+Yjw; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b07b3128799sor320707966b.7.2025.09.14.10.16.21 for (Google Transport Security); Sun, 14 Sep 2025 10:16:21 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCUYILBuntb7hcow5Ov9TmxoB3m0aQpfRom8JwOGj9PYYSkjPqi7yb+A2m9ULKXmT4bGmoPIY5WIwF+SF6LL@amarulasolutions.com X-Gm-Gg: ASbGnctypQSzT2oOBTgZrh++UatsSN/YbnQA44BScqFmL8qyRW7vBcJRmJK/lXx2k1K sotY70CIVwAb74nxPFH7sxWwuME/PB9uJZPFmqv1EI4tDd+uiOC/ZtTfAyIadf0jnSEr+xpSuZa FFuTwVsVyEcYWcd7LQOwAi1VHJklkCmfr6PYwC+5kLckK6CLDmlmTCBxjk0+Ud2Ev4lu2C+hx/8 oS6Uws4qEg2SmZPHxFAgYIADk0iFlSrKu46fbpCiWGu91O2oPOCrz+/S0MqnZCokNjXS3o/9evB Qf1tiEfQy/B1PiXH05Euw6vXjzCSNOXSUBE4NTV6wS4oe87KT5BQPGmqHYJ5/UA/zKTa19J9iN8 vMBSbb5L3Pt0FAxYqCd4EVeK9xPptZTrFIwgCFRunI3bsvWAvjcn/FgkM0edMPPrW/0C9TgKIRa ui6CABdKWlSDOmKsFQ6sJ9UX5JRlQnOdCH7wIqlta5zvh8OfkLC6uKGvd0BzaOJE0h X-Received: by 2002:a17:907:c08:b0:b04:3a46:c4f2 with SMTP id a640c23a62f3a-b07c383f1bemr990265066b.48.1757870181371; Sun, 14 Sep 2025 10:16:21 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07b334e76dsm776980466b.102.2025.09.14.10.16.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Sep 2025 10:16:21 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Conor Dooley , Dmitry Torokhov , Fabio Estevam , Haibo Chen , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v2 4/6] dt-bindings: touchscreen: fsl,imx6ul-tsc: support glitch thresold Date: Sun, 14 Sep 2025 19:16:01 +0200 Message-ID: <20250914171608.1050401-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250914171608.1050401-1-dario.binacchi@amarulasolutions.com> References: <20250914171608.1050401-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=FFAn+Yjw; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Support the touchscreen-glitch-threshold-ns property. Unlike the generic description in touchscreen.yaml, this controller maps the provided value to one of four discrete thresholds internally. Signed-off-by: Dario Binacchi --- (no changes since v1) .../input/touchscreen/fsl,imx6ul-tsc.yaml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml index 678756ad0f92..310af56a0be6 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml @@ -62,6 +62,21 @@ properties: description: Number of data samples which are averaged for each read. enum: [ 1, 4, 8, 16, 32 ] + touchscreen-glitch-threshold-ns: + description: | + Unlike the generic property defined in touchscreen.yaml, this + controller does not allow arbitrary values. Internally the value is + converted to IPG clock cycles and mapped to one of four discrete + thresholds exposed by the TSC_DEBUG_MODE2 register: + + 0: 8191 IPG cycles + 1: 4095 IPG cycles + 2: 2047 IPG cycles + 3: 1023 IPG cycles + + Any value provided in device tree is converted to cycles and rounded + up to the next supported threshold, or to 8191 if above 4095. + required: - compatible - reg From patchwork Sun Sep 14 17:16:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4287 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id F20DE3FA44 for ; Sun, 14 Sep 2025 19:16:25 +0200 (CEST) Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-b0c1a67399asf79806366b.2 for ; Sun, 14 Sep 2025 10:16:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1757870185; cv=pass; d=google.com; s=arc-20240605; b=aOxNRUqB+l5ks07UJJbYvu5ZHYTY4ox6yE5NsxJnsfmS22fRMbmPZheZ0PxzyznN62 GI0IwZHwB9STit7bA+5opF8cYq83FGWoMEuZBp4S8a/HduOCeWA5hgV5M7K3jVYblGoV no1Ad1VHOU2SxI7h4fqbQYmn4UOkW0BP5b/cZdhdMZfZ8jqUny/YErn9yAHNkIc2jVcG GzuWiDfDYCSDNUvYDq0k/VUrA5p8RYfQiC6JcCQ6pQ2SPt06L/BL8UV0wl8LImd2dAdD 3nxSZS7idq8pjwdAXgj8QuE0rNmPNYrmG+CyXs5BMVByJq5gZT76zjXU2szOF4/ubaWD Mwtw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ibFiH3EINui4hNoiNru2OJ9fP9FHYadsKNh2Up2Gt/0=; fh=pw02VP/3Pt1/iSSAOkOtpIJkBaB2UM8Uu1C9PwXkgy8=; b=HrJjiAUy5dljnw42HDVIQqI1Nbq5OrcUfwwPjzEOpYFVPf2PM7LnbhRAahdBcyqabx IpJ6ma0lswN5a6eJERJQSj/m/o6EyvZR9DNDTjqmVQKX2lkwI1is8M9VaoZJj63BOaLO KuWcYJT0sPPk8gO11+Lmkx2Kfr8VN/9nnkAT21WUtZSJ4x/afUpGTR3nOVe/PsB07/iq yyj8Y2tcI4dvAoy6vUk3/e8OvpmNufoZaqB3GTqfAyELAwMObCihnFMWhynGa4T6H2uI Ga3xAdSVmDESXvswmtU9E/bUUuzjDLePF4cZctErYL9r3mGeCxWOz5z23yrX6DG6Ab4z c3NQ==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="eV/powzs"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1757870185; x=1758474985; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=ibFiH3EINui4hNoiNru2OJ9fP9FHYadsKNh2Up2Gt/0=; b=czoZ3WvaSiGS2elky5+dh1OzT0dHj1oksr961vMboyhdCoDsvo8lOOoxeX5+a6tFqc yIHpE0PO17eaDbAoPA92AD4Y0cI+XTYN/EUznNAXtSWwuY7KRoQ8qEgSsg3bmkRt3HId Upq2BvIbF2cI7gQ2QzjRn3sdCxoiUJdbapo1c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757870185; x=1758474985; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ibFiH3EINui4hNoiNru2OJ9fP9FHYadsKNh2Up2Gt/0=; b=LEe6cXYgkO7YXZlEcP2VEdL8Y9dsusovH2Gcn5wqT6WH4tVf10p4umkysMWrFBwsmU Q7JZUmCf1Zjj0Vjd0yfKDKKbfswQ5rp+qJ5fPZ6ZACGW4n0Cynh2j4etrtmy2FWwNPQZ L+5fjxppJ7oQCD5X/lVb3mN478OgA1G+PtxiYN7FZUnPm1rRyYhanG4/hiZVHKBEyV1F fX2QQRAvG1a4Sd4kUKVVvsvXbgyPHg6Qkc2MAh2xEEUWqAV10Efqp2VWkwVnDpMhke5v E77WGlq2RmPrgQn/1mA7nG+ai+M+8LC5QJR6BzRJq6Sg+Z+LJVSf0yptcvqdPcEVe4Mb AXQg== X-Forwarded-Encrypted: i=2; AJvYcCXWGpXZlz6zl7nVXnWcZrXZ2VJkbuWZKrH/LAnbgzi6E6TSu9mpJbcka+3X1VoQPAt5RtCRlROw6cgsIPHM@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YxUsDlTEECWx+9yvIU7QlkqtuX+3p9Ne40b+YlTswc4G/q9QDf4 vp2vvLzpkPVIN0yFwgyWfpm1OwqRW4jkC3MdKSfqB4t95avxZWzkrh7tEAvydLen5ZR9gg== X-Google-Smtp-Source: AGHT+IF6g7LCuV+ap3ip78jh5DRKPqkbgYumNNMItQCfEfgiKou9ZmNClEttmr81JvAxBS7NGOh1WQ== X-Received: by 2002:a17:907:3d8e:b0:b04:706a:bcfc with SMTP id a640c23a62f3a-b07c37fd45cmr1072238766b.33.1757870185549; Sun, 14 Sep 2025 10:16:25 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd7HBjbp6qtvUHyxI3FHAKACzT5nbScPlh+iE/5R49zL4Q== Received: by 2002:a05:6402:520f:b0:61c:3723:1d24 with SMTP id 4fb4d7f45d1cf-62ec03bab54ls3663257a12.2.-pod-prod-08-eu; Sun, 14 Sep 2025 10:16:23 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUM+v94VatK4B29226F93hqE9AgHaLzZQH6ujwJ3+rwtT0ICV2H3u+KBwruf0sQoM4L79RYDwq+VFAMZjm8@amarulasolutions.com X-Received: by 2002:a05:6402:4412:b0:62b:2f0:974f with SMTP id 4fb4d7f45d1cf-62ed8240e06mr9544201a12.15.1757870183250; Sun, 14 Sep 2025 10:16:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1757870183; cv=none; d=google.com; s=arc-20240605; b=iD/2Qi6mZOm3naI9+zJQ9ffmmvRwnCRyZfreNC/dRprufM4OcvwH8BN2HrOk+YNfp+ JMFnAQavT6Q9+BJBTpdJO96fqTJ/7E7H2NqVT/9IGCLmTT3dfSd0xAKopZqVPFS4VROD HQx8qKAvFeDkDYoP5Sq7bxvqfyMnQI5lCzxLbY9yuovwqJItvKt1do21UkfiRtFH8WgE Dc9+QoKdDnTShkdpVKYKmgEXU6DGJWTGDOghxeLbHB5Ti2CDdxBWkch6sSQXjQi1ancm +bcC4mdyXDD8vU6WpJb6NbLfLrJhDlQ5+ZcJHL2nSfQDM1ILpHkdJzji5iaKEFyIEILZ o5RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=AJ9ovkCr6DqOwPekQL9mbbfb8pXGwCeM0TnyH7IdLxU=; fh=qimi5Cr/O8vZ03/E8Wd3B9TSO34bHpIvKaJRcL7aFwQ=; b=b4I3YuhVqq2PLA/td5EQ0IGVMruAilkO1/3ca26/rJOcT6+FTQhIATNjmkUhi8AZfh BK0sDwJtyMaxH/y8eiohEMHto5+7P22QtEqe3BxotaYpNvYjthojdQ4VMhKXI2CXo+uH jXMD7EOORYJpX2q82da5c9O40aoVsPZ/o8t5jrY1ABJd9PrMyzGKb5TVWF9RlwNO0b/4 uOtBkuVqGoPD0rilG1WltWqzYXXxG9YYzS+F0RWZCa/R1BAHaL2yfFgMVWEdfCLVBAqt jEF2BbfyXD/LCwxWU+vLaHWiC4pKeG4vL7DftffIVDjT6p8rckOiqh1y0Uuoc+KYC2xy arVQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="eV/powzs"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 4fb4d7f45d1cf-62ec340b382sor3203505a12.8.2025.09.14.10.16.23 for (Google Transport Security); Sun, 14 Sep 2025 10:16:23 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCV6w4Z26Z4yoB+3VyUPKaDO4gXQOiRWcoSNeJLnbR2WalKQkHAk4eb5/Gk3v15omKrGIR9v63QyU+hukYa0@amarulasolutions.com X-Gm-Gg: ASbGncvT1KNC126BthXzeeieMyx4hKIQzOsb4g+dzyj3NHjGUnppaI85uZ2vjbbbyao EzoPD0HM8RZjzSL2sKkbYpKV5VysdpJPVsFCe1SrDNkJTDcjQy7tQe0l9xuRBsrn063R3Hg8yZa +OYBcnSw15fRPFjkcNa2q4KY35aScCKD7GOrCQWQQ6QvP6ArE2gvJDqM6RGVhGyORyQaJ995RU4 VZW4wrndJ3Ci17DpSNNvx03t1bMtRxrjoCW2C1H083SrhH9tqDo4LfiUvXTbrdbWhh9gkQjkNRn g2uHpOY+J/14QgS+T5+iuuRvDMMGWqFPEsuE2TEhh7RdfnGm02KIbfLJthOD0LLLiy8DaeYcnVv 5wyy3mFvmU/h83LGwv7NGaLysOKhPD+sFMExdWtkLNP5w7b+mr0a0PjcH64T1omv2bDml0ftKnb Fr2WKDDPFrJdbTvsr2VQLAnKYoXjPRuGOA9I37ffKBqWC0bcdMIBgvR+plsaSJxiMv X-Received: by 2002:a05:6402:1d51:b0:628:62d0:fdaa with SMTP id 4fb4d7f45d1cf-62ed82c5a2dmr9785589a12.23.1757870182851; Sun, 14 Sep 2025 10:16:22 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07b334e76dsm776980466b.102.2025.09.14.10.16.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Sep 2025 10:16:22 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 5/6] ARM: dts: imx6ull-engicam-microgea-bmm: set touchscreen glitch threshold Date: Sun, 14 Sep 2025 19:16:02 +0200 Message-ID: <20250914171608.1050401-6-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250914171608.1050401-1-dario.binacchi@amarulasolutions.com> References: <20250914171608.1050401-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="eV/powzs"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This way the detected signal is valid only if it lasts longer than 62 µs, otherwise it is not sampled. Signed-off-by: Dario Binacchi --- (no changes since v1) arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts index 279d46c22cd7..f12084d8f2a0 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts @@ -154,6 +154,7 @@ &tsc { pinctrl-0 = <&pinctrl_tsc>; measure-delay-time = <0x9ffff>; pre-charge-time = <0xfff>; + touchscreen-glitch-threshold-ns = <62000>; xnur-gpios = <&gpio1 3 GPIO_ACTIVE_LOW>; status = "okay"; }; From patchwork Sun Sep 14 17:16:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4288 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 729893FA44 for ; Sun, 14 Sep 2025 19:16:27 +0200 (CEST) Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-61ec9b48225sf520079a12.0 for ; Sun, 14 Sep 2025 10:16:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1757870187; cv=pass; d=google.com; s=arc-20240605; b=YIxiEkVTiE8yo70APHWduSaBInsCbVpbQ1loJAc551XrecfLtR3T+RnrQn0nkCsmFn fav+MlupqozeHHcK+yjDD/aITuOv2qK2uW3NlVW8hyFH2YBcl5xio2tPAmQ8zOMn8cVu nkJDizz3zxjjtbmobDmQtDJ4UlyymmhE3LRlcQj8JlQiuzkwQqvjYnzCD6UtYNV5vYEd tb//x9rxTq2yGuEXzxjY2Q1JJdNS6tGQy9Ip4sWxMgmMyo8IjAd10HXbPL7I8cuEQ0zD 01AffIsYurxYgCcbVkfyOAd4uIjohpz/0BtXtGkisk164zHQ7hNFt0sxVqAgxB735CyW VMgw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=9htcS0XI4ZVUOslNeh29BCh0vYUNMn0q1GDj+Xr/DJE=; fh=n2Vdyw4HBsjhz4qesH9jhHOwop6KAi9661iQcPoIoU4=; b=HT8fo3HQifxGeOYN6CH6fsblbGLAcjIdIPC/589t2VNcN/Kzwu16HNua7FsTBawVTj 9w7+lAdwfl4gvVzqyqfwqX3PVdccIec0WQ8NPfiKGt7NLFL2t/7i77RwQHzk0/mxSjzO 2h9/iff5sslOARqfwhSQ6b4PlENRkkNoj5GAnExu8IUgnqxJlLPJjymN+hUlBBR/0Q2w ZPHt5VZiUmrFmFglRpX1XpmGbYfIBp1qEGo7dM3RqKKS69+BcYW7DBg1cRgOMh0sVlt3 Gmqg5pfBPW+kuEZF3+K4UqHdmjEuNaWL5HikMczovZUfABaYjWM+xAUo0TP69qfO4vad HIKQ==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=lNekeq6m; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1757870187; x=1758474987; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=9htcS0XI4ZVUOslNeh29BCh0vYUNMn0q1GDj+Xr/DJE=; b=AmeU1HMORpZQn4EI9D53cUT1vwwMrXr+50a79qQOfOYJ8tstQin/yjYAlp+SuWvAup yUDgJVeF31WQUprMG7pmpLWf2Cmei7UMjRIZtoomNma4XvLrpEqmnj+BLgphslgj/4eV E9HAeCLiVDJGWyMLwWOBMdXTVce0l+a557Tyg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757870187; x=1758474987; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9htcS0XI4ZVUOslNeh29BCh0vYUNMn0q1GDj+Xr/DJE=; b=HG6stZKpfouglQEV9a0gUUX3zSiKj4H0qgMr81U77xtHUivSubO9mRmxg7EFh5moZ1 UD8Z3sgaktwRaim5FmcVy1Y+e4CYjiTbK00Hd6tIh7/f6vlDaEp0txl/ESi4SWWUQo9S dMJ8WeX8UQLMK+5nJldDFCsA3/e91xc90g5BbZiEt7EYoqX10fIbl7RmvJFoAXJxUtSc sLkKpM/2Wp+n7NxOfdLauIhaegQUARIHlR4MkzQzPCBInETezq+EhlGT0Gab1hWXUIHB 5AElFIzPm7AGK4AFNDcIOfX9uFCqw9r7rG4puegzIzJ83k46XhCtrjS9Ay2Xc0hwZvYQ 4fyA== X-Forwarded-Encrypted: i=2; AJvYcCX8G7mg7dGulp1vLJsBmMNZuNQECPtniqkhCtjkL1njifUnqTukfz8q9Q2CdXATrQzBNay8YM5PpiqPaTxb@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YxPehHoQcoPSWhXpO2eclUTe65BwfMrfdcBAMMzA660F1t5ey7U wWbW6TINK6dpNg51gwRJi0CszW2gjB9e4kCUAW844CtxEJWYCpW3DTnnAus4Dw7X+8O5Tw== X-Google-Smtp-Source: AGHT+IE/aECZWBlYiFMVmRUMHn94YVJOTYxK96KTaA8WzdobpKZC5Q5dQl9IbZteajN8Yhdw5ftsjA== X-Received: by 2002:a05:6402:5211:b0:61f:2ad5:50d7 with SMTP id 4fb4d7f45d1cf-62ed82fed26mr4983383a12.3.1757870187023; Sun, 14 Sep 2025 10:16:27 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd6X7klKyG5DH+G9K4eaeGa7ZO/rl1OADVC7vsDz6yuWKw== Received: by 2002:a05:6402:505b:b0:61c:bbda:af7f with SMTP id 4fb4d7f45d1cf-62ebab26cedls3849224a12.0.-pod-prod-03-eu; Sun, 14 Sep 2025 10:16:25 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUyRgPiEtBfa4KQb0pez4neI5lKAaMqND3hIkHa8GFceYbdUkaBV7XYo3/TKMFkK0/uYTONzPqEHtTLjD1/@amarulasolutions.com X-Received: by 2002:a17:906:478c:b0:b04:2533:e8dd with SMTP id a640c23a62f3a-b07c3a8c7a9mr961644566b.60.1757870184711; Sun, 14 Sep 2025 10:16:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1757870184; cv=none; d=google.com; s=arc-20240605; b=eoUxY+zjJys9pY9iCzWq98J97w/Jwn8ExcjMBdClzzLkflyy/EejvVcrFkSf1/qMDO lE5HtvadpR0c1iv09NWijU7PgsNetRGH5I4NrZlHGQ4x2yRS31IgIlCfOJKtNHyZTh0G vvK0fbq3vEamU9T/poR8REwJWrRHJH7sHIgeXEioSJrd/74j/vdkUSFu5IRBwi1kJXMH pzFxYzO4AnYdUlUjZXAZUd6YRUssHHdWWZYh61zkgGUDpCJRr8A+QDHsnVO4Y9hnfQ0D 9UpZLFXlIx/sUYOYL74pDDg9GLokuKaYfh5t3wDryJ6PwJuqYBeeZ9XOPIdp1ib5czqf SWnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=VeIUZQnFQ6a6zAGoQDZv+bvlaQadCTCZH0QLhkeT9NE=; fh=tdX/A93tEDTqpHwtJ8vEVRZXOehiaNB/m5tTixCHvio=; b=AwbSlB5kzZIKFm6BE4gM8I0zsLwjPI0lkJIAnRVGc6tQRvyL+FODRtNRqf62jy9TOf F/MdOq9gH2Y1GsxuZUbr2DLVBUZiUm8zAJT0f6G+2XIHLx351zB685V0OnJa86IhFz2z YUkddnvVCOmS2/Nc8n19Kx5touPGAjk5NoPlznELLDlWsf5mqrVC8XzkTHxZ+pkrZrTr 9WTU/Yd7pyE6vHjFWkQIRYECeRUQvdp32d2kuFh7UBWZ6b24RzzgzmD0YpUCqDotQ7tB Eye/HFz0pjXUE/qMAL9KkE2wg5VZqdUDx5T9eGGMcFt6Sx6xlF+JhFLfcBD2nC388mWd 267A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=lNekeq6m; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b0b77347d49sor107573866b.7.2025.09.14.10.16.24 for (Google Transport Security); Sun, 14 Sep 2025 10:16:24 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCWixTo3LEFitPXiUbAgxpWIaSDu7SzDQJJx2u8C5BiVdJwUf0lP56oQei4/Sdu+gdh0Hc8g3bjPIcWilofw@amarulasolutions.com X-Gm-Gg: ASbGncsIkdZdPGbQtTxZliBFXyH3L3tK6+MRpx7/TmorVIggErSN60MmvCrkSqVr3XI M4c055Tl9bJuw17P9e2Ll0F/l2LuiHDo0LwfHZU4RdOp0p7YIy/+EqWFpDphCVTam2Zb/maHSNs HeCy+7kCHxROzlfysaiieNY32BPADOt+kIdmUKRlOa2uH2KEIR7z440k97uBzOmmjC48VI1nsr6 uSd6S+av9G3BmalohDNuDOyaUKYV+z2C9bCzpNS+agKhcgY26gABQwE1TU6tNdDSOm+3McJtSW5 mSAJlr76qGBrU2Bt/7vUZupMl1i6YmUFEekDCoCZIxyU/2SckUsIcEhExUBPJYjycUHUM+UuW9u oFZEKIMWbDdHqK7ZLCjeKxRAXKpCEOHuQ3GX/DcaQCD6LnXWv8Qp/Qvpekm5k1ZIr2RNO7T4tsg dMSa6/cCuPp688ggJfEuv7U420YjDMsjnvD3RrBov2d66/a/hrztsGKacKNAzjyTOW X-Received: by 2002:a17:907:78b:b0:b10:aab8:3816 with SMTP id a640c23a62f3a-b10aab8432amr71331666b.32.1757870184256; Sun, 14 Sep 2025 10:16:24 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07b334e76dsm776980466b.102.2025.09.14.10.16.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Sep 2025 10:16:23 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v2 6/6] Input: imx6ul_tsc - set glitch threshold by DTS property Date: Sun, 14 Sep 2025 19:16:03 +0200 Message-ID: <20250914171608.1050401-7-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250914171608.1050401-1-dario.binacchi@amarulasolutions.com> References: <20250914171608.1050401-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=lNekeq6m; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Set the glitch threshold previously hardcoded in the driver. The change is backward compatible. Signed-off-by: Dario Binacchi --- Changes in v2: - Replace patch ("dt-bindings: input: touchscreen: fsl,imx6ul-tsc: add fsl,glitch-threshold") with ("dt-bindings: touchscreen: add touchscreen-glitch-threshold-ns property"), making the previous property general by moving it to touchscreen.yaml. - Rework "Input: imx6ul_tsc - set glitch threshold by DTS property" patch to match changes made to the DTS property. - Move "Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros" patch right after the patch fixing the typo. - Rework to match changes made to the DTS property. drivers/input/touchscreen/imx6ul_tsc.c | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index e2c59cc7c82c..0d753aa05fbf 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -79,7 +79,7 @@ #define MEASURE_SIG_EN BIT(0) #define VALID_SIG_EN BIT(8) #define DE_GLITCH_MASK GENMASK(30, 29) -#define DE_GLITCH_2 0x02 +#define DE_GLITCH_DEF 0x02 #define START_SENSE BIT(12) #define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 @@ -98,6 +98,7 @@ struct imx6ul_tsc { u32 pre_charge_time; bool average_enable; u32 average_select; + u32 de_glitch; struct completion completion; }; @@ -205,7 +206,7 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) basic_setting |= AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); - debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, DE_GLITCH_2); + debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, tsc->de_glitch); writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); @@ -391,6 +392,7 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) int tsc_irq; int adc_irq; u32 average_samples; + u32 de_glitch; tsc = devm_kzalloc(&pdev->dev, sizeof(*tsc), GFP_KERNEL); if (!tsc) @@ -513,6 +515,26 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) return -EINVAL; } + err = of_property_read_u32(np, "touchscreen-glitch-threshold-ns", + &de_glitch); + if (err) { + tsc->de_glitch = DE_GLITCH_DEF; + } else { + u64 cycles; + unsigned long rate = clk_get_rate(tsc->tsc_clk); + + cycles = DIV64_U64_ROUND_UP((u64)de_glitch * rate, NSEC_PER_SEC); + + if (cycles <= 0x3ff) + tsc->de_glitch = 3; + else if (cycles <= 0x7ff) + tsc->de_glitch = 2; + else if (cycles <= 0xfff) + tsc->de_glitch = 1; + else + tsc->de_glitch = 0; + } + err = input_register_device(tsc->input); if (err) { dev_err(&pdev->dev,