From patchwork Mon Sep 15 19:53:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4295 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 9A8473F39F for ; Mon, 15 Sep 2025 21:53:55 +0200 (CEST) Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-45f2a1660fcsf16105235e9.1 for ; Mon, 15 Sep 2025 12:53:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1757966035; cv=pass; d=google.com; s=arc-20240605; b=azQs0E4InUHTLv7CNs2M/dW34dBZRI2W2I62RYOk0Igs0Kudji7tysOkmiy/TUTjTj JdREi/y3fscrRfvjN+vQXpBcjk+KlI0na2KBGMhrAcsBM2FmwhhOG2GCAheH2u9ImtWt mv7BWtJz57aIPvdm+ZLlIxcifcyndSQXB0XQnbhZCVwwL2FSNC0vy0EXe4K/w35TmnQz Za9m1keIEkXvx+TklGrftbBrsdjVYgs0T+hOuA/yiwUtiAc4AGkGW+qpHyGnl2hOOiIS diZ0Tk2N2sZL77tI9q9NoieGqYR4B2LJO/MF7BooKmE5WZ94dazi7few7pMncQKejsCD jGzw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=AJw/KVeM/9UkkwWlvFohsCzG0+Dz0KgdRZgm5UOIRVc=; fh=pIgUDE9FUdF/dpAhOy5sbpwOQDipVzAoxP1uJF3nvbg=; b=Eh8WLNTVUEBX/jqD8TyElgECqJPx3aym55MHFipLZpvGB0iuzY9MjjHIaPuosXlNZa A19QKVReSmEfvFDEJ6HYpyif0qplRWXdXaoqW9sPemfUa7zK6PaZAgPmZRd1EYo01Sjz M/zUvf0qPLTE8i7qhQrN05lBlyyMxHeeuuprMnQOnqOBXKo1mQ6UeBy5S9rltaMo4h+s X/j5pZS2Jj5rahADzCmuQWGVkdizfksFCOYFE/pBXgIWEgswwQduvKLPzYt8MKaBQcy/ g2EuaB12QwfRJuojjP3AhAJcSOT3fjoxXYKfKYjZwWHF2qivDq/PDk/7sAW21IJWc0Gr DfMQ==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=EnI2yPn4; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1757966035; x=1758570835; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=AJw/KVeM/9UkkwWlvFohsCzG0+Dz0KgdRZgm5UOIRVc=; b=jHQrEYwYgU8ecLlErh5oE2NWpzmhpCZtwRwh0L1tlHawbIqYC6Qh0tYS1fD+dHDY2h c6XtLgRKn4cH74uU4bvqOExzJDHGZMnLS+UlV+QNl26yDqs5JPyq2IBWgZ+C3ByMcUFi BFnr06cbXGaRVh++B46utS78fR25A64BD/VE0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757966035; x=1758570835; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AJw/KVeM/9UkkwWlvFohsCzG0+Dz0KgdRZgm5UOIRVc=; b=OHuITJAGRgLCtXW4lTToypAvKrqvbpjJsCjtscC8RRz+2TzdS43xa+B6g2p8cA+S+/ 0ztP8miZ+6ERnLfI6jMs86jb/u1UFlrVD9K4iZxCSQUJunWyzwAn6t2KQWLrJqMXX7hp UQP5AhFRq1Mlam/OMUa30BMErtkVjsYVKL3TCtSxsqOFwtHpmn+7DYe3xtNVGHRFxgWD wH+M5k/Ma34zos3wl58g1rsGW50fqI/i6DvqWUZjQbg8mIzQNLFm1wG5w/ItBOyKH2br nVsEigZaAiCuVtpd7dSVcg/Uvt42WY3Mo5uj3jLpabG22cgvaLkOM+qM32DU8RW0/cT0 iEIg== X-Forwarded-Encrypted: i=2; AJvYcCW8kfSnQkpgp0ldVQjnZVA4wmIcouRWpeqQlNUb8jCDmFTLOpfpvXeZdawEj2EjaQqxcxPLcY1gQNAYQDL7@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YwuWiU3wAUXmdYxSQSfehq4lAF+f4457DlLPVVrm55InY8WiJIe XP2uVstsErmqIaNmA/Ss9kwGNr9j3MO878/7ZK1g345+v9HWkcInJaN8/sxQLKBBJe36oA== X-Google-Smtp-Source: AGHT+IFly5trQZtn0Snmk9UK1xT7HYKQnMbcf2wWKaELEdCuC2GLYluf7exwxrbKhGw+K1+oj/zQqg== X-Received: by 2002:a5d:5f82:0:b0:3d1:c805:822 with SMTP id ffacd0b85a97d-3e765a04878mr10849949f8f.57.1757966035226; Mon, 15 Sep 2025 12:53:55 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=AZMbMZdAUYSrXNeSFZIVdWSaJz+yu44B4RaZoS/aL7ZkPVyxgw== Received: by 2002:a05:600c:1f11:b0:459:d42f:7dd5 with SMTP id 5b1f17b1804b1-45e05bb0947ls26676775e9.0.-pod-prod-09-eu; Mon, 15 Sep 2025 12:53:53 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUINVRAmMPTlprdmZhrnYOt6948E25YYzojsr/d7pSVyREoU13XxI3poBSiZoYo+w4dcWC2oc0Xf/mnV2hb@amarulasolutions.com X-Received: by 2002:a05:600c:1c0c:b0:45f:2bdd:c959 with SMTP id 5b1f17b1804b1-45f2bddcbf2mr60679155e9.8.1757966032799; Mon, 15 Sep 2025 12:53:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1757966032; cv=none; d=google.com; s=arc-20240605; b=XcbTXoPrNSAvDl1nBwgHvS2e9LcciTHNtmjoVtfCkKJq3FZByjKKSzl5ogSdTJ/IIB zGyT9XH5qha+U0x2Pjx7Vpd8DJ+deL/olJElyBi+844cmZGt6JOvwvsjLFVGif67cnDQ aOYqTkQrPeCYBA8NatkMGZYXm+w2nJMmrq+K0ZdP6KhSVftIRTf8ckK6i6kZwC3/g98s AvUS1UuTXUG4YaYFkBTyJtSZJP76D3hzHGgxTA/xy4mkdNcSkUXoPTlQ/6JscwanUQ8B CK9LSe1GMACHgyy3KuCDO/6eSPZoJM9EF8dLoM70dk2UoQ9j+l2LTwH7qEJYJFfV2lU6 IHsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=JAYdvSVQgA1h0haeD8J+mH93pNUjVxDxBFzkQXHtMmU=; fh=K5GdHYPXCTYcIgy46mYEZfcORwXyzpa7VSLQcZiInrw=; b=U0r+PUtGUy2W3squPFhiAQWRbpl3cN7IKLn5hkUFNHTny3vkDzycX8dtjPgsteLdZu y6GUSJuIvfv2RKgqJJKLOsUr0fFCGnDnA4ht4XmCBxTgZXA5F6tCV9B6vvlOh9nvhyXG /5g0OUxd8E5Cg0YG8CIpjbxqONNU+RBxWY134ulIzj9GXCpzihmp+eikr2IDqtlmOx7V YbAfQkuWhA6QDFSq75B1Xy3uKWitiuqs0eqUajPPHnQViBNpn5lPwHNdaimJki93lZLP TbF6viEF99MtYWxGMtFNIQHVPtcYEyHZ4uACffDNwXM0qOikD8xwe0OnrD5iC65NBtGb 89Vg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=EnI2yPn4; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 5b1f17b1804b1-45e0418995bsor29061965e9.10.2025.09.15.12.53.52 for (Google Transport Security); Mon, 15 Sep 2025 12:53:52 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCWK0CZ1nSZGebJn/9NGP5A9s9eTXzzC57ESKyYNG1ZnMTSPlD6zC9RuM2eOR4/5rsWZb3hMvQEDzSYmf8g9@amarulasolutions.com X-Gm-Gg: ASbGncsXEN1xV7QUKLwpqD4vPliUCFfZ64lqKgmkE4mRe+Pxzc0sNM71R88WxJbN7fC BvyWMwVWj8Rh2/l1JYIG+pDt2jZYRZNwEtW4s67D6YtXSTKNjYNkWHwkq6K9QMqhdPTG804ZQ4D qr1+pi0Sg6ZAYvLKKgQMtmNvgIbOD9W/0dr+AONvJKF/DkUn41Dh+sAu//ROX3Mb/dxUfHyvtgi F9FQ82tLXvSYT0JmcgTMMoUAI93kaOnImtxnZk49OliSxOHZJNVShjK6gMJ0jLf+87uW9s8TJEQ ipkW/GBrwpkZYDiCwxknvdyE2uYtGKjlvfCT/Mf7DAyKfAbdyRrQx3fzO63eMHIKNMWQpUeO0HX yXZYeeqtC5eN42hxo2oIttpS1PMi9k78xrsMBdOq+EbxPg4HcF+1mQ3wyao0MhPqSfZ6/ZMn0UW zRNQU0sK+j X-Received: by 2002:a05:600c:6a0d:b0:45d:5c71:76a9 with SMTP id 5b1f17b1804b1-45f211f6b70mr128799385e9.24.1757966032348; Mon, 15 Sep 2025 12:53:52 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.. ([2.196.40.230]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45f32640f49sm530985e9.9.2025.09.15.12.53.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 12:53:52 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Michael Trimarchi , Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v3 1/6] Input: imx6ul_tsc - fix typo in register name Date: Mon, 15 Sep 2025 21:53:03 +0200 Message-ID: <20250915195335.1710780-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250915195335.1710780-1-dario.binacchi@amarulasolutions.com> References: <20250915195335.1710780-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=EnI2yPn4; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Michael Trimarchi Replace 'SETING' with 'SETTING'. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- (no changes since v2) Changes in v2: - Add Reviewed-by tag of Frank Li. drivers/input/touchscreen/imx6ul_tsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index 6ac8fa84ed9f..c2c6e50efc54 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -55,7 +55,7 @@ #define ADC_TIMEOUT msecs_to_jiffies(100) /* TSC registers */ -#define REG_TSC_BASIC_SETING 0x00 +#define REG_TSC_BASIC_SETTING 0x00 #define REG_TSC_PRE_CHARGE_TIME 0x10 #define REG_TSC_FLOW_CONTROL 0x20 #define REG_TSC_MEASURE_VALUE 0x30 @@ -192,7 +192,7 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) basic_setting |= tsc->measure_delay_time << 8; basic_setting |= DETECT_4_WIRE_MODE | AUTO_MEASURE; - writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETING); + writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); From patchwork Mon Sep 15 19:53:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4296 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 282FC3F080 for ; Mon, 15 Sep 2025 21:53:57 +0200 (CEST) Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-45b9a856d58sf3788205e9.0 for ; Mon, 15 Sep 2025 12:53:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1757966037; cv=pass; d=google.com; s=arc-20240605; b=LUQnAi89nlOx9fXpAooamY0rgyyJUJzWxkrzRjWTNNCi+EWhqCrBqj2xS9r91kdOQV HC5iZlovrNkKVqJc3s58PURdA6PzVeOcF3Ry8LuZPdIZrGPUy8oh2Asbx2kpN9TtK4AJ /3mkC/JoWylUwyh995jBl1ha+0hbcpHtYC7nqeFGPAGmCzfPnscr6gLeyaae596rvwtT aHYo7/AC+XcxsmLtP7Ekd/HX+BhWbyjghnCy5Cm1SdVE+eJiHDBHUaz2CbDsI8UeglEz O3CIR5ZW0DG/0mDOcdbmlaFdtmhTSvwcSydyVGIK07OD/fHXrxyCjgO/kZnYiZI6KRRq oxUw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=qN+uwctul0mboouksWJmgzE4mbbYiYLV+2AkFXHilkY=; fh=P3JVgG4mAYCIQrkn29lsYs2z8mBCszPZpnMQqZIN2C8=; b=bb+WRIP4WIMS/bVy0S2vpNhi41OK6L0R3Kp/0QJrgA+xJPZCDK14Sqpdgl0wfeK/Cr PDNc/iC8ulm4pESKmOpnHH705HO7UxHIz7XYR9PvuQ1/d8LofPLMpExDpSd9RHVJ3/vK ZgYbObMRA7Ft5cvxNIQsm4o8F/NsdQlWK7RHyQPt0ycmyjHel37wvMeMH4OT8A8KC0vB Dk8ZXGB8EAlMkURmdlo+2SXEkMwx2lZHV1uXU206OPDeuCbQ2iALQv08UmNGq0XYmNgc bnvUbLmiViSGE9SQJ246nPPclmrPvpFWXrlqdtBypwjqJWriOmLEwTt8T2X5bnWvsHaR gg7g==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=oXbkOeC3; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1757966037; x=1758570837; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=qN+uwctul0mboouksWJmgzE4mbbYiYLV+2AkFXHilkY=; b=aNm5CAvmg6sKm4dVjV1MSTnCd7MMCnhmDf0zGTwUixuNhkUkQvomH5clXsDRCdB6vz vEA3E2gFpLZW8HIxhn8CpIiVdxPmB8GyxI9qa6129jeddDA9HCEMQImwIGBTyQj4pdtE xPvf33s6lbnjGRP6Dk9r6BGItBTjR833DUYK4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757966037; x=1758570837; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qN+uwctul0mboouksWJmgzE4mbbYiYLV+2AkFXHilkY=; b=nyH+3jTb7pZjocRYk/CUweLbmIGDHPCdZJVeP0MAX6h7fHHhF4JHA7osLUaQaS+8J0 jiyv7Yo0O/OzuPRf57fARqmrGoXtV+Z9vwGC5q9aXQTv15OaGTfOhSfq3nyHeJ11Gtgy 5jUefVgf5laIQ/H985aLXTO/35ont4xVYUSrwdnlYKri/GMEiRGiQn9XFGfbJ+TCidhU OmBTA73bKafxGJsgZbiRQSgGUpLdk+xiSdBJnyFfDT4J1iUrkKr2VJz3mEBCJ9oka7AW ucIo/zr62ZBc910bRPAVvK3cqxox00hl7nF/TuLmtVDA9phukmynhxWa9KvRpjWmoKBg rVeg== X-Forwarded-Encrypted: i=2; AJvYcCUa0CxFNtNxeQs5ZPaA7tV8GSBhnLds3p0/5xcOWaE9dmQ9sLZ2FlFDwWdw+9Nc6BaaHnJMKk5dGU2CMgGc@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Ywa0lDjj4Y5MJcRMy235I4XoL/F+bfSfzqRZboidRVt1VuiKBey yHyuADqu/dZkuM1RV65W+/qovP7RCwXzyu+W1nHr5KOptsxRaJmjXv43aGeKRCxiiFHxbw== X-Google-Smtp-Source: AGHT+IFdyD2ZQ23bUJEqE3SOzT2qYkksKKhf2KwU7UYnO/tbc4Nw2uQqiyWVubbteI9mIoRJn+98KQ== X-Received: by 2002:a05:6000:430c:b0:3ea:87f8:da54 with SMTP id ffacd0b85a97d-3ea87f8de98mr4354809f8f.33.1757966036713; Mon, 15 Sep 2025 12:53:56 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=AZMbMZeD7aQyUTq0QltHTnbx+IXrBYggVPcfohSjUqxBkvQmMQ== Received: by 2002:a05:600c:1e22:b0:45b:4b3a:86f0 with SMTP id 5b1f17b1804b1-45f28dc3b29ls14854645e9.1.-pod-prod-07-eu; Mon, 15 Sep 2025 12:53:54 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWcbiyIX1nmCRApn5XDOkh+yN97p/3ZqrjL7lBzIuWq4arWcYD2RNjWvU8QaCYZTacEbYhfLwKTWn0SxNkt@amarulasolutions.com X-Received: by 2002:a05:600c:a47:b0:45b:47e1:ef69 with SMTP id 5b1f17b1804b1-45f212089a5mr129527125e9.36.1757966034370; Mon, 15 Sep 2025 12:53:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1757966034; cv=none; d=google.com; s=arc-20240605; b=OvFXbfmxFVtyz0EMO5Mz20JJD8dQBNxgPEUJ6uyfb9lPlov9OqhBMst8VKS+4k3QI6 7wk7b0CzbQ3su5nfDrd3ZFgE7RrTtVTLsZsA15UW+eTYXstXPzOvHCBenU/99nv1eaeL 1lqyQ0hI9r8eKgXVee9JMKS1MR/1bOsRKlap6GsKM5vAwn+0kejHGLtXpFzCWcca0BzW yiR/GSl25rYOkHBT/XgbZrmpI9N3luRm8onNSmB5er6j6ScC+aNRdDnqKR5gdtbSI1RC 1O/huP7uVHGTPkPPoTAbjAg59WTdj5iGLDBsqGsywi57bF9HprWEaGynXom9xMY26Xwy XNNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=kDNPkG1BJO1AhX7f67y0O0jm17yTyZBB5A5XJjEod98=; fh=4r2FKoJYVAAk1ErAKinVOvyBq9BIubAQXF71UbBHRlQ=; b=J2K+l+z9d49g1r5lYkweYlBFUWfS8hhhxZjmgLxfjxf29w4+LhjMyO9fS0J3vhuZVx SRYotgNfHXXQd5WG9YLelRqzTXHJfQ6U93g4OqMs8r01e68yCMLMtXSlOegU2ZiRgMah b8P7yrQpFH01XrImXl4pD8rR7MGlSE8tqrcz9zFhVJDPsmEj/l/7yVjVU6iMgijNJuIU EUEloX4oY9gKikMkZEQCf22CsK92k/CsVuskZI5twfbg6UoRvY3c7fAuQ53hYjjumaM4 AW6scF4b8ZZeSQZO+TAs5QuvisFh26mhlECKdZn3sAUqdmp0TBTxUt9FWqOCh/KUeDck OUdQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=oXbkOeC3; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ffacd0b85a97d-3e93267259asor1324517f8f.11.2025.09.15.12.53.54 for (Google Transport Security); Mon, 15 Sep 2025 12:53:54 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCWffJak1S/idT9K5xpwhBt15wU83u6JGt/MgIbpMpjKInONCLfjXuwbj2gY22PW+1ZLsB4qTxfGNSZOE8E9@amarulasolutions.com X-Gm-Gg: ASbGncucT4os3hMGfgLhkwdvvpKcY8s1vIcNNcLpO2Y/ZeRRhkf9TNFmRed3s7FVBvI vRx4yyBfEqzxcaj0W9f3f67TjfOP6cQUmedOyqYTlXQIfprF9aJUMzuZeAMJlvYNEbiLao1t4Wo odKVRrmB3Qwq5QxSJs1R79HeQ01x7cMWQwAEPJTtL5P3XdGAi7CzIXA/ptimiA99I0SgV1JM7eC EGBIvOk+OM3aWTSY19Di9vRo2RFBhILl4BB2MsgV0gzTBhSubwgoPngw+j4CNt7C/0JHZ8WfmbJ oI56NkAdVGegum6C8I0Lg1ekDAPXfD6P3pHUWRXKH5HacSQZm8a2j/3JU+Xkpsvm5IcG1yXIK4y Xvvl7Q1gkiQy+NoBTnp9DK8EuIILP+K8AadFCQesqEZ08iiJAbhdVNX4z0cK1T10nEWQ1FNf1Tw == X-Received: by 2002:a5d:588f:0:b0:3ec:1b42:1f8d with SMTP id ffacd0b85a97d-3ec1b422172mr1270888f8f.10.1757966033866; Mon, 15 Sep 2025 12:53:53 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.. ([2.196.40.230]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45f32640f49sm530985e9.9.2025.09.15.12.53.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 12:53:53 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v3 2/6] Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros Date: Mon, 15 Sep 2025 21:53:04 +0200 Message-ID: <20250915195335.1710780-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250915195335.1710780-1-dario.binacchi@amarulasolutions.com> References: <20250915195335.1710780-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=oXbkOeC3; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Replace opencoded masking and shifting, with BIT(), GENMASK(), FIELD_GET() and FIELD_PREP() macros. Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- (no changes since v2) Changes in v2: - Add Reviewed-by tag of Frank Li. - Move the patch right after the one fixing the typo according to Frank Li's suggestions. drivers/input/touchscreen/imx6ul_tsc.c | 96 +++++++++++++++----------- 1 file changed, 54 insertions(+), 42 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index c2c6e50efc54..e2c59cc7c82c 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -20,25 +21,23 @@ #include /* ADC configuration registers field define */ -#define ADC_AIEN (0x1 << 7) +#define ADC_AIEN BIT(7) +#define ADC_ADCH_MASK GENMASK(4, 0) #define ADC_CONV_DISABLE 0x1F -#define ADC_AVGE (0x1 << 5) -#define ADC_CAL (0x1 << 7) -#define ADC_CALF 0x2 -#define ADC_12BIT_MODE (0x2 << 2) -#define ADC_CONV_MODE_MASK (0x3 << 2) +#define ADC_AVGE BIT(5) +#define ADC_CAL BIT(7) +#define ADC_CALF BIT(1) +#define ADC_CONV_MODE_MASK GENMASK(3, 2) +#define ADC_12BIT_MODE 0x2 #define ADC_IPG_CLK 0x00 -#define ADC_INPUT_CLK_MASK 0x3 -#define ADC_CLK_DIV_8 (0x03 << 5) -#define ADC_CLK_DIV_MASK (0x3 << 5) -#define ADC_SHORT_SAMPLE_MODE (0x0 << 4) -#define ADC_SAMPLE_MODE_MASK (0x1 << 4) -#define ADC_HARDWARE_TRIGGER (0x1 << 13) -#define ADC_AVGS_SHIFT 14 -#define ADC_AVGS_MASK (0x3 << 14) +#define ADC_INPUT_CLK_MASK GENMASK(1, 0) +#define ADC_CLK_DIV_8 0x03 +#define ADC_CLK_DIV_MASK GENMASK(6, 5) +#define ADC_SAMPLE_MODE BIT(4) +#define ADC_HARDWARE_TRIGGER BIT(13) +#define ADC_AVGS_MASK GENMASK(15, 14) #define SELECT_CHANNEL_4 0x04 #define SELECT_CHANNEL_1 0x01 -#define DISABLE_CONVERSION_INT (0x0 << 7) /* ADC registers */ #define REG_ADC_HC0 0x00 @@ -65,19 +64,26 @@ #define REG_TSC_DEBUG_MODE 0x70 #define REG_TSC_DEBUG_MODE2 0x80 +/* TSC_MEASURE_VALUE register field define */ +#define X_VALUE_MASK GENMASK(27, 16) +#define Y_VALUE_MASK GENMASK(11, 0) + /* TSC configuration registers field define */ -#define DETECT_4_WIRE_MODE (0x0 << 4) -#define AUTO_MEASURE 0x1 -#define MEASURE_SIGNAL 0x1 -#define DETECT_SIGNAL (0x1 << 4) -#define VALID_SIGNAL (0x1 << 8) -#define MEASURE_INT_EN 0x1 -#define MEASURE_SIG_EN 0x1 -#define VALID_SIG_EN (0x1 << 8) -#define DE_GLITCH_2 (0x2 << 29) -#define START_SENSE (0x1 << 12) -#define TSC_DISABLE (0x1 << 16) +#define MEASURE_DELAY_TIME_MASK GENMASK(31, 8) +#define DETECT_5_WIRE_MODE BIT(4) +#define AUTO_MEASURE BIT(0) +#define MEASURE_SIGNAL BIT(0) +#define DETECT_SIGNAL BIT(4) +#define VALID_SIGNAL BIT(8) +#define MEASURE_INT_EN BIT(0) +#define MEASURE_SIG_EN BIT(0) +#define VALID_SIG_EN BIT(8) +#define DE_GLITCH_MASK GENMASK(30, 29) +#define DE_GLITCH_2 0x02 +#define START_SENSE BIT(12) +#define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 +#define STATE_MACHINE_MASK GENMASK(22, 20) struct imx6ul_tsc { struct device *dev; @@ -112,19 +118,20 @@ static int imx6ul_adc_init(struct imx6ul_tsc *tsc) adc_cfg = readl(tsc->adc_regs + REG_ADC_CFG); adc_cfg &= ~(ADC_CONV_MODE_MASK | ADC_INPUT_CLK_MASK); - adc_cfg |= ADC_12BIT_MODE | ADC_IPG_CLK; - adc_cfg &= ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE_MASK); - adc_cfg |= ADC_CLK_DIV_8 | ADC_SHORT_SAMPLE_MODE; + adc_cfg |= FIELD_PREP(ADC_CONV_MODE_MASK, ADC_12BIT_MODE) | + FIELD_PREP(ADC_INPUT_CLK_MASK, ADC_IPG_CLK); + adc_cfg &= ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE); + adc_cfg |= FIELD_PREP(ADC_CLK_DIV_MASK, ADC_CLK_DIV_8); if (tsc->average_enable) { adc_cfg &= ~ADC_AVGS_MASK; - adc_cfg |= (tsc->average_select) << ADC_AVGS_SHIFT; + adc_cfg |= FIELD_PREP(ADC_AVGS_MASK, tsc->average_select); } adc_cfg &= ~ADC_HARDWARE_TRIGGER; writel(adc_cfg, tsc->adc_regs + REG_ADC_CFG); /* enable calibration interrupt */ adc_hc |= ADC_AIEN; - adc_hc |= ADC_CONV_DISABLE; + adc_hc |= FIELD_PREP(ADC_ADCH_MASK, ADC_CONV_DISABLE); writel(adc_hc, tsc->adc_regs + REG_ADC_HC0); /* start ADC calibration */ @@ -164,19 +171,21 @@ static void imx6ul_tsc_channel_config(struct imx6ul_tsc *tsc) { u32 adc_hc0, adc_hc1, adc_hc2, adc_hc3, adc_hc4; - adc_hc0 = DISABLE_CONVERSION_INT; + adc_hc0 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc0, tsc->adc_regs + REG_ADC_HC0); - adc_hc1 = DISABLE_CONVERSION_INT | SELECT_CHANNEL_4; + adc_hc1 = FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_4); writel(adc_hc1, tsc->adc_regs + REG_ADC_HC1); - adc_hc2 = DISABLE_CONVERSION_INT; + adc_hc2 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc2, tsc->adc_regs + REG_ADC_HC2); - adc_hc3 = DISABLE_CONVERSION_INT | SELECT_CHANNEL_1; + adc_hc3 = FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_1); writel(adc_hc3, tsc->adc_regs + REG_ADC_HC3); - adc_hc4 = DISABLE_CONVERSION_INT; + adc_hc4 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc4, tsc->adc_regs + REG_ADC_HC4); } @@ -188,13 +197,16 @@ static void imx6ul_tsc_channel_config(struct imx6ul_tsc *tsc) static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) { u32 basic_setting = 0; + u32 debug_mode2; u32 start; - basic_setting |= tsc->measure_delay_time << 8; - basic_setting |= DETECT_4_WIRE_MODE | AUTO_MEASURE; + basic_setting |= FIELD_PREP(MEASURE_DELAY_TIME_MASK, + tsc->measure_delay_time); + basic_setting |= AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); - writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); + debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, DE_GLITCH_2); + writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); writel(MEASURE_INT_EN, tsc->tsc_regs + REG_TSC_INT_EN); @@ -250,7 +262,7 @@ static bool tsc_wait_detect_mode(struct imx6ul_tsc *tsc) usleep_range(200, 400); debug_mode2 = readl(tsc->tsc_regs + REG_TSC_DEBUG_MODE2); - state_machine = (debug_mode2 >> 20) & 0x7; + state_machine = FIELD_GET(STATE_MACHINE_MASK, debug_mode2); } while (state_machine != DETECT_MODE); usleep_range(200, 400); @@ -278,8 +290,8 @@ static irqreturn_t tsc_irq_fn(int irq, void *dev_id) if (status & MEASURE_SIGNAL) { value = readl(tsc->tsc_regs + REG_TSC_MEASURE_VALUE); - x = (value >> 16) & 0x0fff; - y = value & 0x0fff; + x = FIELD_GET(X_VALUE_MASK, value); + y = FIELD_GET(Y_VALUE_MASK, value); /* * In detect mode, we can get the xnur gpio value, From patchwork Mon Sep 15 19:53:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4297 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 5870F3F39F for ; Mon, 15 Sep 2025 21:53:58 +0200 (CEST) Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3eb2c65e0d6sf617272f8f.3 for ; Mon, 15 Sep 2025 12:53:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1757966038; cv=pass; d=google.com; s=arc-20240605; b=hN4aVaadH6OtI5GtP1Y/n2UJ1ozZBYH+cN1iJVvzB5cuiHzZYH9Y42nO85YpAnQV3z V6AZxQ05nx1rxzg+YHPZc+esSHvuVgyfka6BDlXyF1wg5/wFJ8J1BCndoIxTdOo+l8PX /tyh8Gzdg9sw5Ued0pzUlFUgArWm4Plzv1XPiHYVhz93DGUmsxRZV9FCAGBuNG6/yG8Z 8yO4W+NGs4i9fK8B7qTpCOY5hftEVxBk52auOqAqx8rlbJZr7c+S9kM8OS/8rvU3NLte yoOzzT1hONrGcV91TDjeZ2XHwdWT8K18kocjbRF7w0rocselgo4f9yU1lhiPJbHR3r7M 4fCA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=6evFeQUeKw/933XJp4E+z0XuooDxFukxYebmxTNjY5U=; fh=544RapqyyLSqAzz94NCebkFVkQ8ka1DO4eU4TCZTP0w=; b=IJ5ZU9lQ+72cFXwUAQwGnaiEDwnklYJ+5cLVnf+wAotyMUqN/a18IhIlD8cYniWy1q XOzkNYlsT8LBusPSzteciTUAhRxM+aUwwqtQqbwBllQPIvYk//PsYGLvxXLUCsAeKSr6 FIn/ij91pM7vZjiLWvS1TVr8N6jUiO53ejk0u14Bs69wRSLceVcdYDQNYlMjBknx5ZVY iWRjllS8AnjQ12laPXJ3lW9FTLHQF56kbv0LvHFh49ZEYn74s8KP4gQD06hLIjdsNYuo htJEtznw1CspzZqiP/SEVGmCxHGbsp0RZKgWKHE9mfclWmQ1Xdj+Oxdk9084KrmxBu+s z1Hw==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=OPBU45vp; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1757966038; x=1758570838; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=6evFeQUeKw/933XJp4E+z0XuooDxFukxYebmxTNjY5U=; b=P6jKf63d/zfnwt16iLIFOW+bbEwedmucYWd5TliLU3voux7Y6M+Tr/UTyTkkskfONc sgOq618oAMkujkvAonVFE/k1M3b2VU6tic4uFXyifwzm/AEJ/fi9KaNyDRIqWpc7AJ7H v5tzo/SVTYhdG23UZJZkVDzubTwTiSnh8no0g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757966038; x=1758570838; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6evFeQUeKw/933XJp4E+z0XuooDxFukxYebmxTNjY5U=; b=Us83v6KEfGAiZ9dis3MkAqztVdg9T81j83wAsMYitkUHYewSclbF31F7Ab2zSEKvTR 58zn4EyPJHxH32yMVv7/L0WXJ62PsDi4qDjo7fjI/40PKprRGwUKJ1xbXXGyaYbwEUjM xg2iXnoSPK1SSogz+1PIx0/SR/6Vaz6L2bjsduLm562e41XKfx3OPcNDKsz0Gx4ukQiP 9Czc8FAl080ERXDJ0mGhAObv8YscaQXY/IAZUb8MD9MaqIZn1XX/J/NWVBySLbKJdZCO aKkSsxYon6YMw+FY+oAVVA73TtPeTr7bhlrafjefrdg06XZrQkBAEMdYGAyli7BUSvcB T8Cg== X-Forwarded-Encrypted: i=2; AJvYcCUCV7geMU9TTiJgoZusBLoGADeBPU0sYXTtdB3+OApIFPSCXMDQ8U1gw4cW1guwHr7TtuapI9tlqVoe5cGo@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Yw1CWzOGaqOA/SFtYcr6A1maOSo7sDRKTAgOB+Llr2Hc3OsPzoY cwF9GAXuZOEzvOPac0FROWaJWZeX6+kPtVxz1Q7P9PmcdlZlZ7MKGAbYkm4STNKKqr6uFA== X-Google-Smtp-Source: AGHT+IGfz3bvlHtTvrLFGEBG7v+tLTEyPa4g/XU7jrKOCZ+QdpSdWJ10F2vZrYk/EBFkNoeD2MV7ZA== X-Received: by 2002:a05:6000:40c9:b0:3cf:74e0:55b9 with SMTP id ffacd0b85a97d-3e765a57c1emr11807343f8f.63.1757966037913; Mon, 15 Sep 2025 12:53:57 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd49cpD/PAmeDlZ/cGsFIx+7Yudlqz28fmgLzhrTMU8XvQ== Received: by 2002:a05:6000:2387:b0:3c4:2ce9:6ac0 with SMTP id ffacd0b85a97d-3e75ef5719cls2190038f8f.0.-pod-prod-02-eu; Mon, 15 Sep 2025 12:53:55 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVdVRR7KnxOmVFUjBr/phdP50kJq/DeSb8jfpEq7jqrbVrLqEgqhK9MnJ8A4bwT8BpEeaLplPVt62NxdV0J@amarulasolutions.com X-Received: by 2002:a5d:64c9:0:b0:3e9:3647:baf0 with SMTP id ffacd0b85a97d-3e93647f7a5mr6656165f8f.50.1757966035620; Mon, 15 Sep 2025 12:53:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1757966035; cv=none; d=google.com; s=arc-20240605; b=H1GxKVY0EVNFwUZbrhBlYV46jJxa0cEzOCU9MfPG3y3GgSzC2oISrXFAxtC2Du2QVB 4IR3T6O33tx4AmtynoxnHDOjfl3fgRS5+VArRdgrSUDEkJlVN5m7RArLx7Rb1BOoM2Pd o8Yhd1InkHyOtjdwzY1/6PRUm/jp7BIiJJMpiXh1JgYAT7wdJqgCJugnEgBJNdsdRgJ/ 0A80b0femkKmULOClP2ZCybGFaYFQOusQ60xXTxPq1Wy655fdezgrQSXV4EomrqlxiyC BrM4XNlIbacLp12Rg4fYBLntelPKfG2qfCjgVMqaaHYvAQWymFsZuHMs4YCJm+dtktK6 g+SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=dmFa+COnAgPwES0uM9A7F5hfXb6EgxmAXNl0CdhTVj8=; fh=/Zyt1WPI8W+vzHwsVmgLWkxqWVFVlaLe/9P2vA4JdfI=; b=Qk/IaUxbR6DriGYT3Ua2UPJktsbBcsru3UPOM0QJ94cO9+1XSbbmZntYoS4qDbK+wy QgsxckA31uVM2C6r/IjKy0THaGwL3lA8up1rFpLCryrTpLvZDP9dAx2KVzHiguK/tzi1 AzGjfbFf/Lx4BYPdbp1Kd3ug85hDwcmH4JU1cmKlu4KhXgDS0Schq47/dR+IUu5VLt0/ VFrbMtSMhmFvrURyFKH5xmZvc531FxfidAegYMHagLvozFxNCYmXMidr5eXNkFKhsVND SXVOYhmf00ofuinAuzEl+4d7TwtfySmq7gM6yGMaJPSIp6Gq6d+5pTd1HU/iG4gzOZ7c jBMw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=OPBU45vp; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ffacd0b85a97d-3e760917c75sor3225927f8f.14.2025.09.15.12.53.55 for (Google Transport Security); Mon, 15 Sep 2025 12:53:55 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCVRztreStlYrillFhoJvh2uDaZ/f7V7vIKzzZq9WZ8kWpE1GqH4ZoK3SuF5Bu2pZo/TAsHPCF8jngaO/p8n@amarulasolutions.com X-Gm-Gg: ASbGncsXjAavYuC2BRME6zvTLkzrKVmHiqmuCuMRP/ArgBMRQVGiG8HFwUjm3PIbRp7 GPx+uc/JIqOB97aBG4yNJHYfV9BzuNAXyG8X54wwc2OlKUZ7p8jM81nmnvp5sxITx4V/Ur/jAKA AUl0Y6gd/Kks7jtP91NUPYiqlOnFvDx76Lty3ye2ibjhTmF8v6ZQAJdqbZv4yKVuqIxmi4qfkHa xJVVQNkXTcujzKXWFCLpUgPEyL9qVxSV3kQk21WtMiSMX1J1xnPB0iBQdxIlNja994EuJ50B5hM H50/eGjzjgNUEzJVXqPJHExFWpEsynAr+CBV3ZcYlv13s7i1dFOZM/xN0vVWOAYMiQP6tf8VT35 RqrBXgK1A+SDQ1+W3K+KWkj8xYx9y93c9FWvPSyjggsMlmybox/lxsRhSU+s/l+TgE2cCegl7Z7 PKyy9C14m/ X-Received: by 2002:a5d:64c9:0:b0:3e9:3647:baf0 with SMTP id ffacd0b85a97d-3e93647f7a5mr6656144f8f.50.1757966035186; Mon, 15 Sep 2025 12:53:55 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.. ([2.196.40.230]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45f32640f49sm530985e9.9.2025.09.15.12.53.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 12:53:54 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Conor Dooley , Dmitry Torokhov , Javier Carrasco , Jeff LaBundy , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH v3 3/6] dt-bindings: touchscreen: add touchscreen-glitch-threshold-ns property Date: Mon, 15 Sep 2025 21:53:05 +0200 Message-ID: <20250915195335.1710780-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250915195335.1710780-1-dario.binacchi@amarulasolutions.com> References: <20250915195335.1710780-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=OPBU45vp; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Add support for glitch threshold configuration. A detected signal is valid only if it lasts longer than the set threshold; otherwise, it is regarded as a glitch. Signed-off-by: Dario Binacchi --- (no changes since v2) Changes in v2: - Added in v2. .../devicetree/bindings/input/touchscreen/touchscreen.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml index 3e3572aa483a..a60b4d08620d 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml @@ -206,6 +206,10 @@ properties: unevaluatedProperties: false + touchscreen-glitch-threshold-ns: + description: Minimum duration in nanoseconds a signal must remain stable + to be considered valid. + dependencies: touchscreen-size-x: [ touchscreen-size-y ] touchscreen-size-y: [ touchscreen-size-x ] From patchwork Mon Sep 15 19:53:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4298 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id DF9E63F080 for ; Mon, 15 Sep 2025 21:53:59 +0200 (CEST) Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45b990eb77csf30921375e9.0 for ; Mon, 15 Sep 2025 12:53:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1757966039; cv=pass; d=google.com; s=arc-20240605; b=UJbd+Iq3RmukssgqjC6QWVR6mF05C6wfAF/ukDPqnxBPDWbHlTD3WcUIcsjIMMUCCs +Z+g3LmYT3+aG4JK8PWT7k0qRBbVbB1x/fF0HMiiuOqEp9H+3Wgx8i1dPTmwu+HWS2vs N9v9aqx+lAtII4MZ81NsUNNTAp5s86SAR3O0BGi52DEmX5phm+XQ0GHHFHzkeooTiPJ5 LtLjTxN8kPDIBmP0lt0zN86dzaA4jqoti6L58z6Kf7VogbISrVw5VWqerB4jpFWo7W4a Lmjic/lkH2O0FTZbbUPk0xD6Cg8B/kxmDzqDPXfeqEVmUfNAlMHV/dafbBnuJh7UCCr/ KKzw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=ksdT+D/KflgRfkgWPSL+eKzorqDkNX49umlQl4N5aGI=; fh=Enc+8bvKJ28eZBioRbghwjXsuk/EawnJaZ2Glq3Lcjg=; b=gtytjilqEB0MCuXOmyWfea8ws35dFYoExTIixxUfzSGYy0V2sUXWrEeACNjOfrVy0O N7x964MGkPKP3NcMahamejk3ZVlrivV7oyWPYbS8lQIArBjnPAC0DRMRpt35HLsqjKD7 huqAfvH8dW2c0R6yemndx+OlASL/pEH4YdkY3Ehgh1zxGVfRS1LcPlBc2xz1FyQX8H6f lVSg7xV9U9fT4kf3tBgOKrQjJqMhg0+oY+i3e5Ah+vFmPa1qbDe5N08E/ZxBNjCiTrrS ymdeLdMb/k7MF4PB8ujS0r50kIhotxWn5ZoYnPtOM6a0hVl+bCIjAc/dDYQS7W5tDIPG Z9UQ==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=YIBSi2Il; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1757966039; x=1758570839; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ksdT+D/KflgRfkgWPSL+eKzorqDkNX49umlQl4N5aGI=; b=kmcm5BYM/4clHk1xnWS72q70c26lASQTl2NyC9eyu2NVpNizYvOuNT6MZXmkIV4chE agtOZVY04YPLL8IsWKhozmGXrPBqNKtay8Wl4EjFe2M5Tvyt+QgJ5SEnMi2AK1o5ih2j t7vbYUROcUROcHXOZD5JjS+HxDVNHovpR8yps= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757966039; x=1758570839; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ksdT+D/KflgRfkgWPSL+eKzorqDkNX49umlQl4N5aGI=; b=ng8itfaB+UfEplz26/eCZg104JyHtLXo7st7tC7/ufbMlIcCV7UiCkvXxAclZQ+/tY zNnWQ32HEtWrhpqmaEtEVTwbue1siWCUVtsnYACk9aI/8fHSDK2EchWSZ8rRFsPrOtJu fL3zf2dB/r5E0gqzKAp9nY1a3GjpEN7YYXuKlGIDF3KAdYcWcDoPBHekDRP7zyCGl8xf h9igj8Eq1TrYq+sbt04ywV3L0ym8zcIHHYzAZ1pokmtPcxRk+7NZQvIiTzvvPMZEVe+0 ++AMDMAEMGvIyigmL+ZMDvLNMMyoHzB+kPNUBmwrYapit/6ieTc613IAAUaWQZqGWZAI M6Pg== X-Forwarded-Encrypted: i=2; AJvYcCVJt2e6lfvfPdGC9NqR2vpdtksAYfTx+HOvaIfG0f2/u3uXucjYXdYvlkHKv/R4KnQ8aTIY1Wi7s9iR/M0Q@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YwVi1qu6XE2isRSppjHfrfhhcL6uqchZO7Q/MTkMxSLT7yEJxFV yq7CDblxtm5NMVIF40b6NSdl89Wcuw+a2huv7Cnreu11/ref1X9bUUR+oFSCn2VOPsEM0A== X-Google-Smtp-Source: AGHT+IEfOtIUF8s3MqGQNFcaQuvKTpL/sCpcDGnWSaoHmigFvnknmn92gkqD15nAgSZAU7h5YeCCyQ== X-Received: by 2002:a05:6000:2203:b0:3ea:c893:95b6 with SMTP id ffacd0b85a97d-3eac89399f3mr3783089f8f.27.1757966039478; Mon, 15 Sep 2025 12:53:59 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=AZMbMZc5HOjZYq1Emch4u2fPbOPk2Tl3wcawfVIr8grAgOVhJQ== Received: by 2002:a05:600c:34ce:b0:45b:990e:8532 with SMTP id 5b1f17b1804b1-45e0514a8afls16304555e9.1.-pod-prod-00-eu; Mon, 15 Sep 2025 12:53:57 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXgYKHxkkwb2AepqiuVvUfn4DT71Vfae6hH2oomIiBBWRhyXi1c3g4M5t0FcvwfIG12kLBTif2cmLnC82cW@amarulasolutions.com X-Received: by 2002:a05:600c:3e1a:b0:45d:e4d6:a7db with SMTP id 5b1f17b1804b1-45dfe9c6a1fmr151942025e9.5.1757966037193; Mon, 15 Sep 2025 12:53:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1757966037; cv=none; d=google.com; s=arc-20240605; b=SObptx11XcSz7SplS5TusIPKV07lqG3Mph3SfpEaQ5Z7DWqPkj15fEyX4A3CAbgTRN JRaAuGDS+uJX2bYujtUJf/ekr4+CMEuZfknemhW7+1BHUPqjgmy96Mxd5u784oSI5/4b wFgCuw+bVqc5ojknxWvOgLivCFOZeY2RT6wxZCp/LWX5TQh71eag3LgZD6Nz5yXyA92n k6x+i82igx/IBXDGIOiEELEc0pA+q6ZQHosha6qXJu82MdIvuwGO7wxXCMgE3rgUMUBi sjoUkIMEXw3RAclt7Oy5TaBM4WE1bmdjzkp5O08TNQZYNQmLo8fZyT0Kygf5q+N6fyVz pKzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=JYpBInbhYba1I5IFzkBXif3pXoZfr9uL09LB08J1+iU=; fh=sko6cyaOXwqHYpjya0hh5v5kDBiSUxNdriqG3hji6ko=; b=CV3pPj0RLkoEf3dTMmxCpjYHtKLi6YZL49x1guRKYbyUeWB2V1+nScrdJnucvAY7KC YKcmpUzjCo3nKBQ8/VzymmhY91SyQ8o0EEjwIz4dUBo1E0ZCmbRJoemlbiGvUIr2Rc8D bSvo6SAHqGEEn0fJ35cjRU7PbKpChj7oAPuy/xa541ep4ce3Ehki9/EJBiymW2pWg5i2 iuzCryYN5wnZgUFVtNAz+JZIspghJVWkoQapHmt/ZcT+u/0X4EdTZCu3fbeOTwpQEg/g 4b5IeLTVjm1OX6hDtiFEjv6d0bUgYLe02Akkwrd6EXbBSXuI2XTJ/ZokX0MLTDhtppWL yc7A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=YIBSi2Il; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 5b1f17b1804b1-45f2af2201asor13219925e9.0.2025.09.15.12.53.57 for (Google Transport Security); Mon, 15 Sep 2025 12:53:57 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCV40//zRimiXz/LYM+W9MU2xV0UhkJjbuENRiMihDZepSw+HaWjA8cp6FjmRkAuz7JiAkapqXcxUFWoQ/Rg@amarulasolutions.com X-Gm-Gg: ASbGncsuBNcAvEoJNsNUo8lcchZl8GoEUQE+8khIeskHdRU0AqaPQBYluuKY7fK+nrT o5LlaT6MTxQ6qNok/TZyQMcXB7Q90l+5t9rr3a6G+INm3BDlzytm/j8KnkHLm3sKdJynmBngAML xjZZoxHP/1bXQa9oyyqyp+NeQfNBAUOZzZUqsm7X47fYHoaTElVRVGxv5Zhkr+ETXm+jyCgjlBZ Yf1zx3+ap1gmhyeKhcArq9mhdCv1F9DwKX6vzBJdrMMT0eK9wUldNYCeDUd/NXi3X6sysjiyqDQ 8DF7uzNU56VfTIWOyTrr3hiW8xKlGcx/X2Jr8gpRaXo6Wc0AUBHAgJY4yY05FpKl1PmwDErtUhL xFZsGMSXCktbt5mZxoKaF+ik3Wn8oZRcO8QhO2NSqCPNlHjvFfNIw8tyU56pPhx8= X-Received: by 2002:a05:600c:c8d:b0:458:b8b0:6338 with SMTP id 5b1f17b1804b1-45f24060698mr116466355e9.6.1757966036748; Mon, 15 Sep 2025 12:53:56 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.. ([2.196.40.230]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45f32640f49sm530985e9.9.2025.09.15.12.53.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 12:53:56 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Conor Dooley , Dmitry Torokhov , Fabio Estevam , Haibo Chen , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v3 4/6] dt-bindings: touchscreen: fsl,imx6ul-tsc: support glitch thresold Date: Mon, 15 Sep 2025 21:53:06 +0200 Message-ID: <20250915195335.1710780-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250915195335.1710780-1-dario.binacchi@amarulasolutions.com> References: <20250915195335.1710780-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=YIBSi2Il; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Support the touchscreen-glitch-threshold-ns property. Unlike the generic description in touchscreen.yaml, this controller maps the provided value to one of four discrete thresholds internally. Signed-off-by: Dario Binacchi --- Changes in v3: - Remove the final part of the description that refers to implementation details. .../bindings/input/touchscreen/fsl,imx6ul-tsc.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml index 678756ad0f92..6214d8be5a99 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml @@ -62,6 +62,18 @@ properties: description: Number of data samples which are averaged for each read. enum: [ 1, 4, 8, 16, 32 ] + touchscreen-glitch-threshold-ns: + description: | + Unlike the generic property defined in touchscreen.yaml, this + controller does not allow arbitrary values. Internally the value is + converted to IPG clock cycles and mapped to one of four discrete + thresholds exposed by the TSC_DEBUG_MODE2 register: + + 0: 8191 IPG cycles + 1: 4095 IPG cycles + 2: 2047 IPG cycles + 3: 1023 IPG cycles + required: - compatible - reg From patchwork Mon Sep 15 19:53:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4299 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 723D540C92 for ; Mon, 15 Sep 2025 21:54:01 +0200 (CEST) Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3ea35489002sf1271812f8f.0 for ; Mon, 15 Sep 2025 12:54:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1757966041; cv=pass; d=google.com; s=arc-20240605; b=jXIQtKYfijmx2wH5emghe6kviZg3qmHUdpFR3cCAxLctaa7GyMILigdCDlM2wr8k0R Gzap9aq3aCldAS/hsWwNq0VFkN7SLySLCcs22R5ewr62ctZZOBMhc0U/iCKATAaKIzFN iqvjPaOuzn5tCZ2UNoed8Oj7pBD3VxLRkdLaoIupKewr9xTzQVCyZIlC7QXEuSDQ6Ajq M1Wbdf1wrhBkbeS1sh40ItC1zPBfkPjpXF+mefEkwhwKKY8da34UAwKXT9bO4L69Awam 6/2aFuMDpnFecAGeieBrKe8p9+/HfdL9xia5LiLV5C2iNJkb+yTLdE2WZGdWEJomjnfp JPaw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ibFiH3EINui4hNoiNru2OJ9fP9FHYadsKNh2Up2Gt/0=; fh=K+dPu/NOZS04UUzkVQE25r38jw4bMt7Uspe/34yD3TM=; b=PMGYbKFPveh2Pb96vxvjSvIvVWa2zcFEdboyjke4rncOvm+pY6K9SwnRFGADZxdw39 1Vfw0cljYncGtBeFJ5e3Fv6dN544tcUNAI4jJlOvfbVYHo0YSlcKaLCyuKnEOmbJWCWx NCMjoDbF4sS2+F4hxqhFnHL9CfaJVuBMgCwDXhyhC1nQmNzVFOsnkcufoa0vXK/jN1pA SmFbxkjU3X9g9p8aawdPtQE33FwqV6HJsk8ZVkGH2fV7sWFT2/+ns9N197qIzBjb3eQn ajw37yTfxfK9LyPRUcrP9wbRMs+sOyeT++FzBdYW4IfY6VcTEPq7Do+6ovCuON4wdbze tjrA==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=h2FMRFTN; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1757966041; x=1758570841; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=ibFiH3EINui4hNoiNru2OJ9fP9FHYadsKNh2Up2Gt/0=; b=DzXMlLZ/fk/xe6ncC7VJgp7xb8OSIUs3Wa25YGTgtR3awsJt2OzaT/sjf+phjnlyWn ARVghijrWoTT/sIF/8p5+rOdcP8rxUc8xt5qUlzsSUeOMjwSLouQwe/pJwJz3u/OokY8 fZLxfesKivX5RCltq6G7oQzHnr2ToT7U4AQqk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757966041; x=1758570841; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ibFiH3EINui4hNoiNru2OJ9fP9FHYadsKNh2Up2Gt/0=; b=j6epVgAiwIrb9R33IKVxPtf3PQmQhfB9hiAtEUAHI5yGSX7T+199tkhuwr/4K5he6q gOKQHVLJNd/zpNPObAjeJbLxEeg3IDHuGU9Z5AVrnLj4szQuHDYrLhZhLIyki4mwvHLp aymqqhX/v/CKqY1mnXvlyFdwU5IT0C0iT3wb5Kf+ETUDYsALFEbK5qtY1YmWy+jgCqBk n6fkFP/Mji1aCM5IQedI7YeapAgaV2zp7L9KcAOAcuvIOyMsUSfX65cGTJJcJtyOXdng H+nipBf6Dz+WkS+6qzJAw8glMvb7PcA8TaX+8/Dx7BBKxknWSOPSUPGOEu/zmhKEWenc +LRw== X-Forwarded-Encrypted: i=2; AJvYcCWP+NmfSB9myhqITP5Oz1XFXNUx27FlZLMOpzt9n1UnwQOuyW320anFwH1Awt4T3H0xv2zPr14NoLUyDQ1V@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Ywf1EO7ZiagIdiDsM+nJBhSOldA4OTFWP0P3nXxlQyEEBvIVfFp ByB2G3JCLRJS9Ay6WL49NG820YIhf35ByZsa4ILqL1CYzwfc/7l9lNbLmqRIZaB49xxKtg== X-Google-Smtp-Source: AGHT+IEm/hys7WjV6L+EHor9m8oj8KG7C8Qa4vw+Kv98w0tdEIkSlyRhDObXSF+M+IJ46iOYtp5CfQ== X-Received: by 2002:a5d:4e91:0:b0:3e8:e7a6:e5a9 with SMTP id ffacd0b85a97d-3e8e7a6e869mr5197232f8f.48.1757966041033; Mon, 15 Sep 2025 12:54:01 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd4pMBtznO0EhITyR/FW7LQ4bD9rgu/1bEvp3NAKV8H6hw== Received: by 2002:adf:f58d:0:b0:3ec:6c71:7c9e with SMTP id ffacd0b85a97d-3ec6c717da5ls26147f8f.2.-pod-prod-02-eu; Mon, 15 Sep 2025 12:53:58 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUcssGqhl7lLAdAs2s/M9L16+wc/FZLocpuwVsw8RUw9t9T4ckM9nqUxaQ8PY2ck4BrqFYMQ+a7MQtlTqVB@amarulasolutions.com X-Received: by 2002:a5d:4e91:0:b0:3e8:e7a6:e5a9 with SMTP id ffacd0b85a97d-3e8e7a6e869mr5197169f8f.48.1757966038642; Mon, 15 Sep 2025 12:53:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1757966038; cv=none; d=google.com; s=arc-20240605; b=JjFJYI9R+U5oyK/sRktScPjYwXduJugGpFkkZdZYDPuPsPZpM3AHnV2f4VlVcKVrbG 24NmOZJyt7AHvGpFsY0wa75/p1NCWVU1TL8NJNCsF6nDmjW9j7GzPHh4avJbUbHN1lGW zkGhJ0rQk9judjCxtaYut2Ska1Eszdy8UbOWVgTqFJHQFae+Kakvmi3Mtmofy/++kfG4 NSSGTWrpAssW1WmeGnzOSwTuqZ/UqQi0l9wVeG1PHPYw3f98M5os03QwCFXl1XnxQHgv jN1aDQWvHhssRv+N27u+NAPyMwgWVscJ1uqjTpGb4twNb3EBDpEWxeL7KJUK8rZNZbLN IXDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=AJ9ovkCr6DqOwPekQL9mbbfb8pXGwCeM0TnyH7IdLxU=; fh=P3bkFKGO69JBoWSVUyJRi7ja34Q7AT7u8VVbuWzKb6k=; b=a5LVSk7ndhBfJJ0yLIRMbFWq4LgyJQwX4I4v8+0u0UQE53YyXUR6vdKsPzg8c+n281 maZ4B3TT1AjVdCD+0Z+iP5S1AZUKjWaYB1fCEaxw0Z/YvY4aca9P5ZpsH5rpkElOvrOc o75cGqpyqc57p8zHA1oItTLAp61qtKhhCFmCWNE/0YfACvCi3Q0UXsVpMpDmnXdPls4d xkxZBrpzyYaBK41prD6ZJ4PWqKlsnFTXJJNhYDM4qFgUVgiSv9n1NdWPM9Uw1mfa08oi plzNx4uA2leJUZ8lz64MURPS1tHYBNgtxhFaa6C8bkNJ/sn65VAFHCwpnRkqaR3tO/Nl GmKA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=h2FMRFTN; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 5b1f17b1804b1-45f2844a74bsor10925505e9.3.2025.09.15.12.53.58 for (Google Transport Security); Mon, 15 Sep 2025 12:53:58 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCUYTkI45kbJx/eTmkD0cGUxpfeirtINcQMRtX2xMWzzy05RLjtMZL4ZuvJAj8n3siPjDDRTMgb2b0Ojwy6D@amarulasolutions.com X-Gm-Gg: ASbGncvarqqYKwsSCFPL2eaIpV4tHOYgaLjnr1kqzUcbDhBKzjF99ksIMpuqpi9Wd0U Km0FIw1fNnC58GGVQNeDa5I8AbVY0FOO7sU1pSy1UQJ2kj163ZIUKkT/X1MG8oUd2mmeLCpeORr 7tNwO0+UmsceQY2rps9QD4B51d66ZHgeB1aPvouGSsiRNBF6Ep5xODX0oWfwds3WWMeUA3u/MsH bymUM/tnXdDCvhYk4nHw5d5YmsOi4Hr2xKu6CLJNLO6+28Y94QcDF7uLHK3rgHaSxCbmzFQWTLn l7pWEyuiNTExM5InEpE6uOwf4ztSNRM2NeNsZeN5pjpA6JI0RqzC4TAhMqOe7nzAcYNke/p7Utp cX6CRmHgPkn9GepWsOMc2inB1rGAxeJquqBIvRtt3H5Y58uWwzVjKA88oa++/IdepB+fHFKpjXg == X-Received: by 2002:a05:600c:6a06:b0:45b:8f5e:529a with SMTP id 5b1f17b1804b1-45f211d660bmr96982405e9.14.1757966038162; Mon, 15 Sep 2025 12:53:58 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.. ([2.196.40.230]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45f32640f49sm530985e9.9.2025.09.15.12.53.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 12:53:57 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 5/6] ARM: dts: imx6ull-engicam-microgea-bmm: set touchscreen glitch threshold Date: Mon, 15 Sep 2025 21:53:07 +0200 Message-ID: <20250915195335.1710780-6-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250915195335.1710780-1-dario.binacchi@amarulasolutions.com> References: <20250915195335.1710780-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=h2FMRFTN; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This way the detected signal is valid only if it lasts longer than 62 µs, otherwise it is not sampled. Signed-off-by: Dario Binacchi --- (no changes since v1) arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts index 279d46c22cd7..f12084d8f2a0 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts @@ -154,6 +154,7 @@ &tsc { pinctrl-0 = <&pinctrl_tsc>; measure-delay-time = <0x9ffff>; pre-charge-time = <0xfff>; + touchscreen-glitch-threshold-ns = <62000>; xnur-gpios = <&gpio1 3 GPIO_ACTIVE_LOW>; status = "okay"; }; From patchwork Mon Sep 15 19:53:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4300 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id A05D73F39F for ; Mon, 15 Sep 2025 21:54:02 +0200 (CEST) Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3e9c932a4dfsf834417f8f.0 for ; Mon, 15 Sep 2025 12:54:02 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1757966042; cv=pass; d=google.com; s=arc-20240605; b=PW+xMDjMMlcPFMdbbny2TEw8OBwe6KpQ5C+s4e92if7x3iBObg3i1igoYiDzJKIrNk KbXUZ8aDZHGzBLrSQIO1iVtgn964xYN7Xgbhcm0r7vBUPFjK8sii2I0ILPZt2eWrf/U0 vGHpi+Gj0NJVZoUu42OtMMN4aR8eZkiod1xxPOD/2fnsxVsyQG1UVoh7i6f/fyzHhQ+h d2O2i8TKJa3C2nZBIW9qVH4PcA9MNwvGnibGFZzDEoT6onlnh7Z7yzmdbHN5mbuvybPu 9z5qcN8AzEBCJiYL9wAVZj6XhEOssJCmX0p7W1YkncE+aihPTL4gbWIm864GYu4KHB9g noCw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=xho2GEbVJ6t7/hhJagNPkmIHSDQbTt5cIW6Z3kRphwY=; fh=rQ+G7i08TgUCcMxUhfb51mOPtiyasUExrYokvbZwOrM=; b=Y4U5xHsXolcz+nfx63RkWShk6b5zF/uZxID/K0QV4hup4dbwoM1+yvohnYyjkDXXPP VJT8cDs9VxwCGbUHyMGnfzyXkhMstl02Rd5ID6FXxCNegQLLMmNjlzO4nvwNJSTIdK/U lgg0Qp/0xuF+GFj9U5w4bv6gGVFMU1aA+acB1bSPsL03lqVJ3okB2aknPUE31BSVrUSh taJs6H1BE1PE/kRKaMg6jeJIRTOWgePLHkY1MhkyzkRr5hw7qXKuUBa0SR048jMs2ZrP QH9EDybaX9t9WjpCHLumhFOuJ420FO5yv/HctVpsCOwwkvZ7gdGK8M+MW5Rw/Mnly6in 3+Hg==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=hsgyD6g8; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1757966042; x=1758570842; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=xho2GEbVJ6t7/hhJagNPkmIHSDQbTt5cIW6Z3kRphwY=; b=HH8+6fvBVDphrorb9r0YmLLqW6+rF+iVWBHS/qPYvRu7DaLXS6hGShdv+AxqqEfbI9 +rdt2ef2gEkG9tsNLcgi9OVUMXkuu/2I1wEvo417u5hz18udfp2Uk8GsYbAV99qtZko2 DNuAjSS8HxvlfcZO9hgJUoeAtcIyGrR57fbV0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757966042; x=1758570842; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xho2GEbVJ6t7/hhJagNPkmIHSDQbTt5cIW6Z3kRphwY=; b=u3tzJ5/uyhV1UO9fGqNCIxiMvtaM2u7pT5OOZZ2Ik1wK9Jy4rAdGlCSNWWLTSJmeZK /fmjkg6OR06u75p7DwpFDn2e9oAfYlnnvVNbRf2tqXO56FwUvettxUX1KIvkcudAHbJE Mg7JBG0gT3s/pyzHCrONOqh+iv6QSApCsZxMsle0SRkY5G6AtpNoYrieupSio6qe9tF8 DgcTDTAVad7MEy+Wx1vYoUe2YB75NCTS6vddVf9ZQpALLjd+JKOnRigKsukSN/47+Jh2 v+4YSWznws+jcXHjdeOk0AaVuGOaaDBKSgPNG6RB/DLq4YjgeWNly4hxaxJWV50BD4aY xDqw== X-Forwarded-Encrypted: i=2; AJvYcCWRSJzgSxLDZzI2uYZ5aRoeebFYDZR4aSernC/AABteJI65hhjpkISkGSbp2v27kQTmbQ5QaAEZnCyIzV4P@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Yy9F53pzQWyNscDtdSyXLxqx5jeIwefmXE4Ksj8PFKtnLPwILL4 /iruNFPeIMU4yUD7b66GZHgtoR9/82PyzzABScPCZaoHZA9Eg1a4hrxKpMR+6X5QiCphTQ== X-Google-Smtp-Source: AGHT+IEcYo1DzoXhBV9H2RahdCjMWMkHCMKoH4SulS3CBFpXHGRKiVa0BkJWB6QrZyTGd2oM5ojWoA== X-Received: by 2002:a5d:64e8:0:b0:3e7:6474:1b63 with SMTP id ffacd0b85a97d-3e765a36129mr12880659f8f.63.1757966042230; Mon, 15 Sep 2025 12:54:02 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd4+Ye9temeUK/X3LcG5yuS0itGWgDTB6V2X6z0cr6VwcQ== Received: by 2002:a05:6000:1acf:b0:3e9:4a9a:eead with SMTP id ffacd0b85a97d-3e94a9aeffcls1010935f8f.0.-pod-prod-01-eu; Mon, 15 Sep 2025 12:54:00 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWawaV2tu4qxzYWwuHBKLCxoqbItIxrb53u2bwBB8Cad93zqfmK5FISnMoCTM4QrOmiXjOj0O8Qt9B/dBGM@amarulasolutions.com X-Received: by 2002:a05:6000:2f88:b0:3e4:74dc:a3bb with SMTP id ffacd0b85a97d-3e765a05168mr12528894f8f.40.1757966040043; Mon, 15 Sep 2025 12:54:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1757966040; cv=none; d=google.com; s=arc-20240605; b=NBg0mhtbYwxRCkoQomL9UlDhkEsNdou/cXAWYzapxPKLBO1PC//5VxbauZIZf+2Hrn yazv9gkLTjlGvJs3YRuw4R/uWhOclu3lJrTBsPp8NsbyWuDnD+mGFMz3r9l4L+cmLhxR byq0E38h4yqfMOwNsqPT0+b8MtEbH7wVMl7Dgu1gUrErDXjYupKk3Vte3UZGfh+jPr1Z WtR+/56UlGMOQVEj46/TrggUmdLS3XRmvRaDIYwa1FJ9+ilmS8PwimEcCOtBh/E6Gp27 f9GCWyzvfzFZvY1titgmJysOLt/AjsM2I1UfbWadhlFI/2zRyhFIeWcoy2BGrpzU2RKN clcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=GqadXdSW1D0YdX9y/VYCHcP9OLLjsnrvbDdXfqIeuyU=; fh=ZbSWFubu2e88LXFQlJ3UJoPbPBgq8ymXR2bgFVSTM2M=; b=Lo0jQYGCJsvejs6UXdiG7uXhaxzCJpAghQhtGZDq8+tNz7ElncRJNlnlei0MRbSf3I IBFoGJvE3hTJFiV4bEzt+0Aq4iAwclMKnNAvxZGoVpZsp4qDqa73td37Sb8xDxXB41/U 1lzhDyOhHJEX7Cyhk7LomyEJYF7KFIwK8Z6ozbqQQQqjk5Zh3pQ6xRs8iGbrNWVwTSHc 6jpbiFAlrS698xWMiaC4nw5wTxS3pabRWky6c7H67TSWJXFJaGnYHJQsauC/EPPFMbpp 7eVqKSarcNE8/irXrAsidi9HaZRgGaeeqIyWQrm+q4Q0yZ1RrSRKXLmK3/XF1F/bSrsv iRkg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=hsgyD6g8; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 5b1f17b1804b1-45f28db0ed9sor12671695e9.2.2025.09.15.12.54.00 for (Google Transport Security); Mon, 15 Sep 2025 12:54:00 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCUOwb4UzdDGz6Dced/aFN7m+H0p87K3pk9Zz5Z8+nK3VNAEQKKCisJhhBqwqxwNq9lt72le4RRAOv7XND3P@amarulasolutions.com X-Gm-Gg: ASbGncuLzSppcvO1puKn5oosyxw1fxKjDKljGi/3F5u8wJrlNu6XrV8AVlDQlm/KedY fQPBfSuuntE/BjXxpb+qzM8cuYwbaqsjpCdY4GsXqb+lRWyZ9E4TyAsoRl3CmJykV680h0I6TiN A5lMskbVyQ3DJPQ9FTetQCG6T4A2NPuaIOkOYZjCWojQjylmYXQjtMqjI05uTRE4kuEH6fDTNPX 6CAiD+pUY6ILdv4enFzW1P8KdPpKqmEi/9ZQAzxKrY6+iw72R6uM9N5Tp5AfRU7N0Nb7clDOJ4k +jBxPTDFFhse/GPZ5NZ2KJlDoblnxaYfOhtnxx5y80a5ucWRqZZVAzTDw0Ab8twtOjskCJnZ9VJ K3XrPIpJtk55ectzIKMOBj2bFOBfFsQhur8EPZDAse89Ug3hWwLg2udj1ZaRmli0= X-Received: by 2002:a05:600c:4453:b0:459:dde3:1a55 with SMTP id 5b1f17b1804b1-45f211f2fbemr160469475e9.24.1757966039580; Mon, 15 Sep 2025 12:53:59 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.. ([2.196.40.230]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45f32640f49sm530985e9.9.2025.09.15.12.53.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 12:53:59 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v3 6/6] Input: imx6ul_tsc - set glitch threshold by DTS property Date: Mon, 15 Sep 2025 21:53:08 +0200 Message-ID: <20250915195335.1710780-7-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250915195335.1710780-1-dario.binacchi@amarulasolutions.com> References: <20250915195335.1710780-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=hsgyD6g8; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Set the glitch threshold previously hardcoded in the driver. The change is backward compatible. Signed-off-by: Dario Binacchi --- Changes in v3: - Remove the final part of the description that refers to implementation details in fsl,imx6ul-tsc.yaml. Changes in v2: - Replace patch ("dt-bindings: input: touchscreen: fsl,imx6ul-tsc: add fsl,glitch-threshold") with ("dt-bindings: touchscreen: add touchscreen-glitch-threshold-ns property"), making the previous property general by moving it to touchscreen.yaml. - Rework "Input: imx6ul_tsc - set glitch threshold by DTS property" patch to match changes made to the DTS property. - Move "Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros" patch right after the patch fixing the typo. - Rework to match changes made to the DTS property. drivers/input/touchscreen/imx6ul_tsc.c | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index e2c59cc7c82c..0d753aa05fbf 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -79,7 +79,7 @@ #define MEASURE_SIG_EN BIT(0) #define VALID_SIG_EN BIT(8) #define DE_GLITCH_MASK GENMASK(30, 29) -#define DE_GLITCH_2 0x02 +#define DE_GLITCH_DEF 0x02 #define START_SENSE BIT(12) #define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 @@ -98,6 +98,7 @@ struct imx6ul_tsc { u32 pre_charge_time; bool average_enable; u32 average_select; + u32 de_glitch; struct completion completion; }; @@ -205,7 +206,7 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) basic_setting |= AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); - debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, DE_GLITCH_2); + debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, tsc->de_glitch); writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); @@ -391,6 +392,7 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) int tsc_irq; int adc_irq; u32 average_samples; + u32 de_glitch; tsc = devm_kzalloc(&pdev->dev, sizeof(*tsc), GFP_KERNEL); if (!tsc) @@ -513,6 +515,26 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) return -EINVAL; } + err = of_property_read_u32(np, "touchscreen-glitch-threshold-ns", + &de_glitch); + if (err) { + tsc->de_glitch = DE_GLITCH_DEF; + } else { + u64 cycles; + unsigned long rate = clk_get_rate(tsc->tsc_clk); + + cycles = DIV64_U64_ROUND_UP((u64)de_glitch * rate, NSEC_PER_SEC); + + if (cycles <= 0x3ff) + tsc->de_glitch = 3; + else if (cycles <= 0x7ff) + tsc->de_glitch = 2; + else if (cycles <= 0xfff) + tsc->de_glitch = 1; + else + tsc->de_glitch = 0; + } + err = input_register_device(tsc->input); if (err) { dev_err(&pdev->dev,