From patchwork Wed Sep 17 08:05:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4306 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id CB86B3F168 for ; Wed, 17 Sep 2025 10:05:42 +0200 (CEST) Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-b0424d27c25sf51074666b.3 for ; Wed, 17 Sep 2025 01:05:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1758096342; cv=pass; d=google.com; s=arc-20240605; b=aERiuiwNBKCzsPkOJAAl+BXwFtkolMQ5JdMmDp52b+r3KvO2WomtQHArZVrpGbajpK a982c2RplquI7+WeaOJK1uhTjJBOo27zzt0FTlxjXZPvjdo7op+crSeihnlFg10fDJB0 K7J5Pkto7O335r5kzsNdw0/+rByb9lOKs8sfDNq4rjINZ/s0GII75UL75Ar4k80QEZr8 3yQQ4u0vwbCPcD+NyExGkPy4bDbr9hh2/vhLjbYEY7obj7Zf9kx/6CFcqKs+V5yRry2R BkTwUzepAl+dMZOFWo1+Vq5MeJH4oAbYNdc0OilU2d4fuv2Ll72bohxfmrQEcKfxc3Lb VbWg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=AJw/KVeM/9UkkwWlvFohsCzG0+Dz0KgdRZgm5UOIRVc=; fh=5fH1XcGLE+wrKlZlrG5ZlDoyS3Pq/r9Yf1DkvIXdq8s=; b=dd6tBy3f0EuVRfWopOzhql4MYco67SwXIUbZUOJpQ4ND9WJXDXGtGJrky8lNn6SdbH PixR6uMJRz7JkdrnJDtReXhZUrUeuARZz0GemD6Ioq7kvuMypGC72l7wqeJpu0Cr1rGx c3ooG79x2CLvNXnLz+V7nd3GPHHKKMrupzN2QjblYgb/3RK8hZxzummT1Zggj1Kv1PGN oxiY98qcuskgaXvTI/KiA4RpjXQnPXzvk4g2g0HIQKDiMp5TFekTIeWM/M0iTra9ySBN VBMS9TTa7A2+RDxei7vBUT72jU5td4oOK5I8TAL0KK8tzGKlApT1JFGy4KYYC7ZVXvZ0 9VBA==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=WIoUa3S7; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758096342; x=1758701142; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=AJw/KVeM/9UkkwWlvFohsCzG0+Dz0KgdRZgm5UOIRVc=; b=IqicyMHX3DWrgC8Y0VOWIEcamkQFyM97LD98erfWVbIfTN0Za4KV4o8L/exYqZsib6 EHbtIk3x8Jnh8F0B+oHJb3rtCWV3nwR+QSmpXeMpk8twwbRB5f9lQT6r4oeq7yF+ffCN Y7xZf5oLojcqCwH5M5gEnD2G1AQao+mHLl5gg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758096342; x=1758701142; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AJw/KVeM/9UkkwWlvFohsCzG0+Dz0KgdRZgm5UOIRVc=; b=G6Z8qy+ZIYbSvc3zasw6zlWOS4Asa+fE13Cv1hlXa8A1f0Or+eHOwqgGmXyS6x5Irw 0NT/SSoJr98rAxSBYp9dLDQtcLL8dRTyYyE2Hkn64fqPtav2RZFmMRSUmFQyfoN95rrA JfoIE4xuFlrcP+zhm4++6dkJWq8BcZaOjccJjaGNky00eUDRK+38xjt7BgDcPam2RVRs Rsh7epbgTcBbHRiYuWZa1nygsRJmg8tUGHDa2278CeyVU69T1Aik1Nvdxz1qHzviarX8 7F1Ka/uE0hkPckVNVl9SyD7aSID0/fFvCGzJ7HLsk3komiJa4w4FMR+K+J5E9AU8aTQ7 CDjA== X-Forwarded-Encrypted: i=2; AJvYcCXP4V3can3baFzxz3ov2rbKMeY8y7cr1EKyebgAKVEJ2lwt8tXLxZt6dEfSwnUXJDovN1tZy2FmsriGWwA0@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YzapRSXCNq1ZaFsWwkmhBcchetimVBzYY4dlpeaJAjpDLO4nfjA jm7Y+0oov3phq+d72ViMJqTIscn4cPivHrdKDfjS7Le00O+8/k88/6TvMmc/STMhDMrR0w== X-Google-Smtp-Source: AGHT+IE5NQI4M93SQA1gYz0Nf3+YeSxxIRn5yNvf5dTFuUR6l1bhs2z5dZ10qv8+4VDqfQjtJ9OGPQ== X-Received: by 2002:a50:baa3:0:b0:62f:935e:5f56 with SMTP id 4fb4d7f45d1cf-62f935e61f4mr111606a12.7.1758096342124; Wed, 17 Sep 2025 01:05:42 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd4llFOF+lW+F3Xxjt0bM+5CW9tBcvrcFgmx+1DqIT/BkA== Received: by 2002:a05:6402:24db:b0:62f:8e07:1494 with SMTP id 4fb4d7f45d1cf-62f8e0716a9ls220021a12.0.-pod-prod-09-eu; Wed, 17 Sep 2025 01:05:39 -0700 (PDT) X-Received: by 2002:a17:907:2d1e:b0:af9:add3:6bbb with SMTP id a640c23a62f3a-b1bb680365fmr143993566b.29.1758096339541; Wed, 17 Sep 2025 01:05:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758096339; cv=none; d=google.com; s=arc-20240605; b=TOt4/qbAbOja/sgiGYWU/z+nG/zbQy4cBE1GRzJmEHz6lVoTRwYoo82YUJiBs9HjSa weo3oqId+AuVKr1i67IScG5eaeJ5ZxUqw0BfzvgIxq0cPXaWaEDjQn3reRWEOwIOXVA4 ZnglFAKxtUbKBJQVKmEW8r+3pcLyYefeyCh0x8ZkdX6VQRroJzS2HFv1M5pBl2ME+CMR bWa7efgKvlMjBU/VZS3LpgW+UN63HRdZACgo8jZ44Ttfq+GNfC7tWd4up1/d0meU4bGu F68iOvoe38smjtezq7z+2kolzs6bGiI4OERrOKbwUMf6yejU+uYmQG32sLdRNLrRhEPh FHrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=JAYdvSVQgA1h0haeD8J+mH93pNUjVxDxBFzkQXHtMmU=; fh=2tTJ+Wz6s7lJCOQoemphz9aUXTAmngcJh3FcTDreg/8=; b=lRxnEA+P+qAhbH5H8jEt7cxNhe5b/cEJpXq5Kkal33HAWoDvNL5Mq5PKeFVYY4aBwP R52d2wMkRax7vfZKkIeJ9QVn60UQZzn/jtKFMYe+nOpgjKza4u2JCeLz1eS91vrWMJYN xR48Wrl0WIXzco/rqjNyIxDfqd/8rhOmV/+3ix85b7ZsPYPA/MsPTgm8ICU7+6Nn0FYj eGuR4sZhV+0WxQsel4MFRuHV7CscxUSrAj8GreREXH2TaPcuN1IQP4457fQ7YOab91rf 9B7/wDxzh+GR1vz4AiFsGZtvXi8GD73N66EG3afPnExC2N/74u9JGX2xmZP/wuCMXuGU 9lFQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=WIoUa3S7; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b07b32ddc06sor574869266b.10.2025.09.17.01.05.39 for (Google Transport Security); Wed, 17 Sep 2025 01:05:39 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGncsNI2gAXtszL8zZN8Y4MDwjAqPPPHYCrJy2sQe1mwknM+ZFjxHwG73BQRrtcfB 8MGMejF7sKG79/vJoyFE4/3hWo3ARNAeZt8498F6NZWlGs0TOjdFZ+XM/gfwNhTuqLXMlxqwyII lXhlVjHfwDRXBh5JyTDNHgMFg5n247Lek11iLhytUlaPp9EFt3KDpiTpvXsXR8p2LbiKstvuuz4 STg7Qdh+zESsda/ahiljqXBLmHBihKJrWvf9sFy8OJxNJ1KI2tGkEhINre3+f1jCWXhvdTeYI4w qiDjkATRoWafExZJ68T2uAW1rp2CYw7O+1crs/65IIQ4BijTkQZaDANt+6dRSyrosYo/bsOR8k7 3S4479GMHBzmsPKlgPEfdtM30Z5MiDjZBC+HTobiWk4oEJBQCUQVAoyZtU1s= X-Received: by 2002:a17:907:97ce:b0:b0a:aa7e:a193 with SMTP id a640c23a62f3a-b1bb559965emr139686566b.21.1758096339059; Wed, 17 Sep 2025 01:05:39 -0700 (PDT) Received: from localhost.localdomain ([2001:b07:6474:ebbf:1215:4a13:8ee5:da2a]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07e1aed5ffsm924936766b.81.2025.09.17.01.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Sep 2025 01:05:38 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Frank Li , Michael Trimarchi , Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v4 1/6] Input: imx6ul_tsc - fix typo in register name Date: Wed, 17 Sep 2025 10:05:06 +0200 Message-ID: <20250917080534.1772202-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250917080534.1772202-1-dario.binacchi@amarulasolutions.com> References: <20250917080534.1772202-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=WIoUa3S7; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Michael Trimarchi Replace 'SETING' with 'SETTING'. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- (no changes since v2) Changes in v2: - Add Reviewed-by tag of Frank Li. drivers/input/touchscreen/imx6ul_tsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index 6ac8fa84ed9f..c2c6e50efc54 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -55,7 +55,7 @@ #define ADC_TIMEOUT msecs_to_jiffies(100) /* TSC registers */ -#define REG_TSC_BASIC_SETING 0x00 +#define REG_TSC_BASIC_SETTING 0x00 #define REG_TSC_PRE_CHARGE_TIME 0x10 #define REG_TSC_FLOW_CONTROL 0x20 #define REG_TSC_MEASURE_VALUE 0x30 @@ -192,7 +192,7 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) basic_setting |= tsc->measure_delay_time << 8; basic_setting |= DETECT_4_WIRE_MODE | AUTO_MEASURE; - writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETING); + writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); From patchwork Wed Sep 17 08:05:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4307 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 19DC83F14F for ; Wed, 17 Sep 2025 10:05:45 +0200 (CEST) Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-62f760c363esf671351a12.0 for ; Wed, 17 Sep 2025 01:05:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1758096345; cv=pass; d=google.com; s=arc-20240605; b=VA88ZR0HoWESvfqXgcF4ZWWAArs1U+y7gPFBjH9wkOfJrgwUTdOhzU2GxmoG9J5PU8 71tJT3eUW/vbJJQEbqHDxWYWNzYLCeN9QlsXKzKc5Y9sSJeKWoJotZVtgkYxQV9Pvdpt T4h+McmXWksAHpxjQiWzTaOTxdfIVAAcUnN+kuCXLUIOLkm3sja2fmEO/6VNcsjFYyyO KIxOMf8r4vIS9DmG9Z41bMyEDMBCZlZCImjkEN7XIA2h7TB1Xtu1ppIE7dyMyxBBNFUN vNtScNDu0MDtf9ATLDWT2oFGOiHoq/yTEt3LYyCQmjAS6hsWAlAFzJ+fInq9NbQlm7wA I8Cw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=qN+uwctul0mboouksWJmgzE4mbbYiYLV+2AkFXHilkY=; fh=tZGGOQim6KuJuSGg81kcLk2VbyZcnc5aBMsIgJizInE=; b=YLTCxY/YLvirkkYKdnvpKOPLZHeKbDPSD7FadZm5MceQ00tsS+qaBwt2mcYAsD/aoa uBEe/6x5gcRxTO7X4VJEfwxiWrGWdAZgZQvNZs4U118uCChVr0n2mbYnbHYWNpAnIHG1 JXCPYkjD15HGahyVK0PGWYqeOtxHvpg3WeOrFFM9VeZgW8lHJeOFhIxQ7HKa96P04BrH 4YqjxY/BmiHdP7HXQRCLyKLYnQ/BjC2mo1mlu4X+z+Ze921xhfN0zlyjj0ppfSxkBAAe tRv46dLmjmdpVdSlAg9GDErU4/yPcwzNVBPr6qxpirRU9+YT+abZX41Ti0A7x3N5rrfM a8Tw==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=NEiYpycQ; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758096345; x=1758701145; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=qN+uwctul0mboouksWJmgzE4mbbYiYLV+2AkFXHilkY=; b=pZCODlO9/XUtiO0h2jrh1c8US1sA0y5z39mhcn7PpcW73j/K4iR4PySEXrBf3wPPs9 6xlvSNzaSXUyhopwiZYmzX95QHlcxerrL1U2Q92McVEBXkkkJ1Lz+3zNR/uC9esZY+lM Q2jO/lnh1uRWhHxxMoYfOXfnKfGJFmdhFUCoo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758096345; x=1758701145; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qN+uwctul0mboouksWJmgzE4mbbYiYLV+2AkFXHilkY=; b=St8r3Mt93TRnOF0ScL5xoZaEOpUTgBQ5RCda3bz/wY0n//M9dkmmcIwYxiZgIToXGR GqqzSrndHp8ok36pp40qlaKCsX3T+rHM0xH8i2tWr+3Ktuk8cWnL9xJ1NAYei8nAgzJC Th7Gb9nhv+MG8s2nFYvdbAb3Kb8gVvz0KoKh3qKoOBHKMEkMpcAhxTV01tcecgHj0+7n vPrtYnynSYDwRYiccgl6Ri4ywR3UwdV7HUAxvSRRxVd1BUhLvcOx1Wy6MezV7VB8t7uV FUny2TenarrZBB7RGvCR79QXdUoAUVzlwTqHP4+YbaeOCFEJvNXbMFvlPyTxhaOBC7KA NoiA== X-Forwarded-Encrypted: i=2; AJvYcCVIuEGXg51B2JN41tJQHL761upWD8QmwAEqHwVIcC+wEd2cIxjiAV1jQd/RwVOOmkhj3aVqG1Iii+t4fy3V@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YwI+m/6FNo0DBq+Yr39/psNn+N71VwRkswGUQTVFDDMWMgOl1hR uywrHRLaSbygrVnvjn32J1sYSRNL9Zt1N53TfvjLNmRC0h8GmuufFFpteTG5jW83Xj+g9g== X-Google-Smtp-Source: AGHT+IFL/ETWOyozNwm9dYuFzAHpPSYHknoIc03uJ7D3WJ+eDw5q2hHiyggf0GTYCJOA3IUt2JwvjQ== X-Received: by 2002:a05:6402:2695:b0:61c:35c0:87c6 with SMTP id 4fb4d7f45d1cf-62f83e2ee22mr1569995a12.12.1758096343898; Wed, 17 Sep 2025 01:05:43 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd7zU/lSTKh+Vp6o0qh0cWtXiAEVOXVICS82Po3hzhcYUA== Received: by 2002:a05:6402:30b4:b0:62f:30fd:30e5 with SMTP id 4fb4d7f45d1cf-62f30fd31e4ls2296568a12.2.-pod-prod-09-eu; Wed, 17 Sep 2025 01:05:41 -0700 (PDT) X-Received: by 2002:a17:907:7ba3:b0:b04:2b56:c43c with SMTP id a640c23a62f3a-b1bbda5a8edmr166659566b.56.1758096340917; Wed, 17 Sep 2025 01:05:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758096340; cv=none; d=google.com; s=arc-20240605; b=YNP9vzDyYN+nScnEpWwZaPCdigpb9HDdIPRa4scsmz/F/DOdnTOyLc/XzNOG7fg/q/ K8fkwl0Gd1OWUMGwQ/Pq2C5o1mfvBAURWyaJBV+nWIUydk3OnCk6cEgkYm1MEg1koAfM oWrlCsePZmVK6dvDlURX/GHTV8WBaU7I4LcH9DlH1wnkTP994wURe6H9MByoSEigK1IP jBd4b9piHpzl8BAohfj5tdpRcdeLYsevGvYQIjpwsT28HTpqx99QcwtYf5cxx62vM+Lu 6ewIboPKyZjQ+7NQeDBYAQ/aG2sTFPj5rHAwkRJK9BIz2n42wjONmk6oeRzb0ckgj2EQ MoMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=kDNPkG1BJO1AhX7f67y0O0jm17yTyZBB5A5XJjEod98=; fh=07XXofEZG9d+QeVy8dz+2QB2lNQ+zt329x24x7giHEI=; b=iWpciLxbdoSZFIvYMN8AlqiBBEQ4FXBGmWUiHlcXIa9iyen7n1MCL1r+lSIVwgJ4JI pnm1n8IfOKxKjSOTuTM/CH5iuLXwxTjB5xeY8DE27aw+zSqfBaYCGDYf/eyj9Qqs6Bgy 9VkU0kTePBe00jXr0Kk+vSkZdigwLFHhP7dPEsKf3F1IbuR4c8nc539YWp6VgaWuQQeb NsaGEXc0XLOjd1cfdfA3TkoGh/4VqPsYBoaLbWvamAhLpsNHsImzVY3SenwPKwC5cJ/x AkD2x4dObtO2okD6MmRcJwVOsKoOo+alkMe27zYN1lFpG+gmCKoIYp5L3GH3fl2suArM VSFQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=NEiYpycQ; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b07b32dcf3csor522261066b.9.2025.09.17.01.05.40 for (Google Transport Security); Wed, 17 Sep 2025 01:05:40 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGncuHeFU2xzPkUmgkloCPxtmZHYVlcd4q4jGLfAIpHrlzOP+rWFXQgpnh6C1kw4+ HFFGeneuOycytzxHFAt9gC//Betk3RLEQt0vCB2Ezk9CYMKDfae8Nrd6dgZKBycDsfULqpG0UbN mjhKSTXnmLnQWmdl7/C2T/3PoMzkHLEbvPh14vyGcb7nqSclo4ein5pQENFOrFvNOpY/ideXHnW gPKhu6MKxVZLD49BKxIwEywajG+Egff8YVkb4ftyJz6jkdj2Ep7Xa4rlv6RGPbWacQgxz2kwFB5 78Nkr7OlfOwmTrU1Szi9ngtf/rwELv+ENcvFzPxHRmXKVqqLfs9V4Gmt2ktQsrJ1TppkxJ80oG6 UB+KhwwXUruTg/9YQshgC+62cfaP3R1odORgBnxEC/fcDE+c+0MSufOA76Ag= X-Received: by 2002:a17:907:7b8c:b0:b04:6338:c95a with SMTP id a640c23a62f3a-b1bbc5490a6mr145293166b.45.1758096340361; Wed, 17 Sep 2025 01:05:40 -0700 (PDT) Received: from localhost.localdomain ([2001:b07:6474:ebbf:1215:4a13:8ee5:da2a]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07e1aed5ffsm924936766b.81.2025.09.17.01.05.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Sep 2025 01:05:40 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Frank Li , Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v4 2/6] Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros Date: Wed, 17 Sep 2025 10:05:07 +0200 Message-ID: <20250917080534.1772202-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250917080534.1772202-1-dario.binacchi@amarulasolutions.com> References: <20250917080534.1772202-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=NEiYpycQ; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Replace opencoded masking and shifting, with BIT(), GENMASK(), FIELD_GET() and FIELD_PREP() macros. Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- (no changes since v2) Changes in v2: - Add Reviewed-by tag of Frank Li. - Move the patch right after the one fixing the typo according to Frank Li's suggestions. drivers/input/touchscreen/imx6ul_tsc.c | 96 +++++++++++++++----------- 1 file changed, 54 insertions(+), 42 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index c2c6e50efc54..e2c59cc7c82c 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -20,25 +21,23 @@ #include /* ADC configuration registers field define */ -#define ADC_AIEN (0x1 << 7) +#define ADC_AIEN BIT(7) +#define ADC_ADCH_MASK GENMASK(4, 0) #define ADC_CONV_DISABLE 0x1F -#define ADC_AVGE (0x1 << 5) -#define ADC_CAL (0x1 << 7) -#define ADC_CALF 0x2 -#define ADC_12BIT_MODE (0x2 << 2) -#define ADC_CONV_MODE_MASK (0x3 << 2) +#define ADC_AVGE BIT(5) +#define ADC_CAL BIT(7) +#define ADC_CALF BIT(1) +#define ADC_CONV_MODE_MASK GENMASK(3, 2) +#define ADC_12BIT_MODE 0x2 #define ADC_IPG_CLK 0x00 -#define ADC_INPUT_CLK_MASK 0x3 -#define ADC_CLK_DIV_8 (0x03 << 5) -#define ADC_CLK_DIV_MASK (0x3 << 5) -#define ADC_SHORT_SAMPLE_MODE (0x0 << 4) -#define ADC_SAMPLE_MODE_MASK (0x1 << 4) -#define ADC_HARDWARE_TRIGGER (0x1 << 13) -#define ADC_AVGS_SHIFT 14 -#define ADC_AVGS_MASK (0x3 << 14) +#define ADC_INPUT_CLK_MASK GENMASK(1, 0) +#define ADC_CLK_DIV_8 0x03 +#define ADC_CLK_DIV_MASK GENMASK(6, 5) +#define ADC_SAMPLE_MODE BIT(4) +#define ADC_HARDWARE_TRIGGER BIT(13) +#define ADC_AVGS_MASK GENMASK(15, 14) #define SELECT_CHANNEL_4 0x04 #define SELECT_CHANNEL_1 0x01 -#define DISABLE_CONVERSION_INT (0x0 << 7) /* ADC registers */ #define REG_ADC_HC0 0x00 @@ -65,19 +64,26 @@ #define REG_TSC_DEBUG_MODE 0x70 #define REG_TSC_DEBUG_MODE2 0x80 +/* TSC_MEASURE_VALUE register field define */ +#define X_VALUE_MASK GENMASK(27, 16) +#define Y_VALUE_MASK GENMASK(11, 0) + /* TSC configuration registers field define */ -#define DETECT_4_WIRE_MODE (0x0 << 4) -#define AUTO_MEASURE 0x1 -#define MEASURE_SIGNAL 0x1 -#define DETECT_SIGNAL (0x1 << 4) -#define VALID_SIGNAL (0x1 << 8) -#define MEASURE_INT_EN 0x1 -#define MEASURE_SIG_EN 0x1 -#define VALID_SIG_EN (0x1 << 8) -#define DE_GLITCH_2 (0x2 << 29) -#define START_SENSE (0x1 << 12) -#define TSC_DISABLE (0x1 << 16) +#define MEASURE_DELAY_TIME_MASK GENMASK(31, 8) +#define DETECT_5_WIRE_MODE BIT(4) +#define AUTO_MEASURE BIT(0) +#define MEASURE_SIGNAL BIT(0) +#define DETECT_SIGNAL BIT(4) +#define VALID_SIGNAL BIT(8) +#define MEASURE_INT_EN BIT(0) +#define MEASURE_SIG_EN BIT(0) +#define VALID_SIG_EN BIT(8) +#define DE_GLITCH_MASK GENMASK(30, 29) +#define DE_GLITCH_2 0x02 +#define START_SENSE BIT(12) +#define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 +#define STATE_MACHINE_MASK GENMASK(22, 20) struct imx6ul_tsc { struct device *dev; @@ -112,19 +118,20 @@ static int imx6ul_adc_init(struct imx6ul_tsc *tsc) adc_cfg = readl(tsc->adc_regs + REG_ADC_CFG); adc_cfg &= ~(ADC_CONV_MODE_MASK | ADC_INPUT_CLK_MASK); - adc_cfg |= ADC_12BIT_MODE | ADC_IPG_CLK; - adc_cfg &= ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE_MASK); - adc_cfg |= ADC_CLK_DIV_8 | ADC_SHORT_SAMPLE_MODE; + adc_cfg |= FIELD_PREP(ADC_CONV_MODE_MASK, ADC_12BIT_MODE) | + FIELD_PREP(ADC_INPUT_CLK_MASK, ADC_IPG_CLK); + adc_cfg &= ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE); + adc_cfg |= FIELD_PREP(ADC_CLK_DIV_MASK, ADC_CLK_DIV_8); if (tsc->average_enable) { adc_cfg &= ~ADC_AVGS_MASK; - adc_cfg |= (tsc->average_select) << ADC_AVGS_SHIFT; + adc_cfg |= FIELD_PREP(ADC_AVGS_MASK, tsc->average_select); } adc_cfg &= ~ADC_HARDWARE_TRIGGER; writel(adc_cfg, tsc->adc_regs + REG_ADC_CFG); /* enable calibration interrupt */ adc_hc |= ADC_AIEN; - adc_hc |= ADC_CONV_DISABLE; + adc_hc |= FIELD_PREP(ADC_ADCH_MASK, ADC_CONV_DISABLE); writel(adc_hc, tsc->adc_regs + REG_ADC_HC0); /* start ADC calibration */ @@ -164,19 +171,21 @@ static void imx6ul_tsc_channel_config(struct imx6ul_tsc *tsc) { u32 adc_hc0, adc_hc1, adc_hc2, adc_hc3, adc_hc4; - adc_hc0 = DISABLE_CONVERSION_INT; + adc_hc0 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc0, tsc->adc_regs + REG_ADC_HC0); - adc_hc1 = DISABLE_CONVERSION_INT | SELECT_CHANNEL_4; + adc_hc1 = FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_4); writel(adc_hc1, tsc->adc_regs + REG_ADC_HC1); - adc_hc2 = DISABLE_CONVERSION_INT; + adc_hc2 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc2, tsc->adc_regs + REG_ADC_HC2); - adc_hc3 = DISABLE_CONVERSION_INT | SELECT_CHANNEL_1; + adc_hc3 = FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_1); writel(adc_hc3, tsc->adc_regs + REG_ADC_HC3); - adc_hc4 = DISABLE_CONVERSION_INT; + adc_hc4 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc4, tsc->adc_regs + REG_ADC_HC4); } @@ -188,13 +197,16 @@ static void imx6ul_tsc_channel_config(struct imx6ul_tsc *tsc) static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) { u32 basic_setting = 0; + u32 debug_mode2; u32 start; - basic_setting |= tsc->measure_delay_time << 8; - basic_setting |= DETECT_4_WIRE_MODE | AUTO_MEASURE; + basic_setting |= FIELD_PREP(MEASURE_DELAY_TIME_MASK, + tsc->measure_delay_time); + basic_setting |= AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); - writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); + debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, DE_GLITCH_2); + writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); writel(MEASURE_INT_EN, tsc->tsc_regs + REG_TSC_INT_EN); @@ -250,7 +262,7 @@ static bool tsc_wait_detect_mode(struct imx6ul_tsc *tsc) usleep_range(200, 400); debug_mode2 = readl(tsc->tsc_regs + REG_TSC_DEBUG_MODE2); - state_machine = (debug_mode2 >> 20) & 0x7; + state_machine = FIELD_GET(STATE_MACHINE_MASK, debug_mode2); } while (state_machine != DETECT_MODE); usleep_range(200, 400); @@ -278,8 +290,8 @@ static irqreturn_t tsc_irq_fn(int irq, void *dev_id) if (status & MEASURE_SIGNAL) { value = readl(tsc->tsc_regs + REG_TSC_MEASURE_VALUE); - x = (value >> 16) & 0x0fff; - y = value & 0x0fff; + x = FIELD_GET(X_VALUE_MASK, value); + y = FIELD_GET(Y_VALUE_MASK, value); /* * In detect mode, we can get the xnur gpio value, From patchwork Wed Sep 17 08:05:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4311 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id DA3E63F14F for ; Wed, 17 Sep 2025 10:06:03 +0200 (CEST) Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-aff11a3e5fasf91202066b.1 for ; Wed, 17 Sep 2025 01:06:03 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1758096363; cv=pass; d=google.com; s=arc-20240605; b=iNo3Wej1W1SQfzJZ4gOk7feS2Stl95u3lxi4EIIVBwSSttypHoVq3qgET515/57pFi mR57EuqQQcIcsHfiBWU6p4nt2qR1TgpR4LFG7EKTB5dTV64rDFHP+BmGPDXNli0mR8Ys H1XgVBq9l91c67ssPMiS2l5KeyNU6mIfJmT7NXk29hqv9luCSrRF4HqOtiQ2IOSYKDsa WwaG7da2R41LlNr4Umk7hGg5E2zXFxGPWHF0+wPkHO9v9umEt0v4hfJ9N0FbqlinbJ/Y wvZWqSbOO9AlEOlJbzLLxr+F/iEAT6MIMM3tWAWpSM1jB1Lzd7DNA4B0MQqtPVIPckh1 bo2g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=6evFeQUeKw/933XJp4E+z0XuooDxFukxYebmxTNjY5U=; fh=bkKoY/FhQkaz4QOP/TaecUM/nT0iuJ3ifKVwNv/xt8I=; b=HoR5zKRKsW6NLt7hAvLu93jNnV3tiJUWXfZZNF4KQdXbPGxiKbiS0+vd6qbrCbz2Jv KMfGeOK0xXd418Qn1Mtl7xMwh4pSMnFa+wmAKu25w/XMp2In/4tUOfn+ySrXsMFwAB/W f0eq12Wvod39VbHCidcXFJa+X7/PEZ6CBFHjkWS7kKw5qY5vR9RMFA3F8JsGJkCAj8Zb OQahePqwnkFFfq2fCQWZ3PwZ3hAwY2691q/NTX0pAM+3pXmVvlMitoyXf52AzfcRxFRU s6GBFNQ1mHJ9RpFc3pA4ppBZBxPdGsbr/pc/ogXWLqcdhNcRcnvMMLaPj1MiLAKWRRSX iWuQ==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=SmLv9aXh; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758096363; x=1758701163; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=6evFeQUeKw/933XJp4E+z0XuooDxFukxYebmxTNjY5U=; b=ckiLQezfi066hn9YZ8UqRRti6Cd3KeO/Jb5fKRFenM/RbNFgpW3gvJywAuWakeXtGC KVzDlHYPfzukXLhQd6e+whD9HICWA9S3SaCBHIFNYC00Uv4tYuJWzCtnaCySn63+a1WG tGhFgniFrhvPYzk4YJobuOTWwknXdgnnqcVDU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758096363; x=1758701163; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6evFeQUeKw/933XJp4E+z0XuooDxFukxYebmxTNjY5U=; b=od793hm82WcnLL1VA3fztd1VoHuOhN2h7UIzi1E8qk43Cum2+q+8S2dKiiTpJy9mYq uTx7R2KIzUuLLXrox+Tt5KxxpCUjX6nP2Z/1jvyBQrXmK2dtDivj5rThHcusumqxy2Fz zftHF7zyLnoILc9n8n09RgVHo7JBhkmPgwssVeXQKSMssD77jfcav1eK3USdAoQQqDLK 8xH0izPFFOvx7oq3ety+98qh2V8MjEJuyZ3LrM3ge1QY2TeBbSyP62lJyavXJHQCreKg R/ulTaRssl/WmFIxqI1Yp1CUATI7N2w8SWCOZ9smoXWBVsNoPBAiYs4Veptm4NV/CVSo ydmg== X-Forwarded-Encrypted: i=2; AJvYcCWZ9fngJ7Rt9ZeFQ4VQxQO1zrmkMlH9T0fkQ28UoJlfcAVXi4Me5dU8k7c7Vxbc64omKbeb+TJIP5/FbnMD@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Ywv+ZBPlcIRgq6B1njdh3XWXDcYK/oePW+TfN9cUrBN2Cz1Wfz2 TOpab6gbc9SIwe6Tkda5n4loQ+yTUD1X7Iq8dVWC/VwXpjE9fawJ3f36zksW7uxOeOmjfg== X-Google-Smtp-Source: AGHT+IGmO7ApQ6Wd6vRVc1E0Y9LSh8vA9psbNF3ZZyGnQASCOJEviveo/jy3+I+yOGo6uFINkeJNMA== X-Received: by 2002:a05:6402:13c3:b0:62c:dfae:ab96 with SMTP id 4fb4d7f45d1cf-62f84687d17mr779800a12.7.1758096363456; Wed, 17 Sep 2025 01:06:03 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd7tUPQMEe22AKq6WSoK4IiTscTtW+0NouRGAercMmybSQ== Received: by 2002:a05:6402:23ca:b0:628:46e0:3cd8 with SMTP id 4fb4d7f45d1cf-62ebad1bc7dls4476264a12.0.-pod-prod-02-eu; Wed, 17 Sep 2025 01:06:01 -0700 (PDT) X-Received: by 2002:a17:907:1c94:b0:afe:85d5:a318 with SMTP id a640c23a62f3a-b1bb7f2a2a6mr135084966b.36.1758096348930; Wed, 17 Sep 2025 01:05:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758096348; cv=none; d=google.com; s=arc-20240605; b=LCSntB/aSahevzClg8pNcR8GWyBHTRudf5arKFS+kyzkEeWB4W5hPvYd3UU7eGracP xeo1Y0Dv7v+iZFJr9CJBAq6W0rfLlKm+XeZFk/pBcqzAAIGNdhHBrUDl6FAXG4QgjScY DFYQOLvVrpV+KDz9OcV5NbuwPScrGDUI29f88+RRy7n5yYB1DNdbafm3kD0By6zv22Dh zHfisBUZYPSY+7TajQlzuepWJAYS+kL7kNsYZjdNUoZ60/9Ha2uDB4ISG/AYddeJyjeP Xtmfr2+RJpjpyjoGrOnV9XhcJ/9fGd1kc/5cuKIGbnyEcQjWz4Jwh2cweFOyIhnP5qPY Ar2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=dmFa+COnAgPwES0uM9A7F5hfXb6EgxmAXNl0CdhTVj8=; fh=YeMPEy5+xPDaEG4ufh2pKMN7VGvM8L32EvuJRe72GEs=; b=aTPwgtgXAP+DRETl9wOr5A1mKYj+1Vuy3+qFAipe0lunDjcvzrirU3mqdgUyY8+S2m wl8Vkm/wD61aNnTMg/gL/awIyYMibmiqrlDSFXo6fhDTTEsUd7h1attvv9/+N0uVbUgU JCkNzpcXV3tezghDJmQ84PJMEw+tyP9MZVd09cHke9XBiu8fz97qTR9qZ3jKQk6HNJ7C BrOmrHlof0su8EUigELJjl8U++nA2qsq0mPrZezZ9cXXur4hFmWDmVa+GVZgukgaEC9D 0aKVY4HBJ0pDubJDmCVK9h+7Ql+44GvxO05+CMqtZ0D7DSnCfYJm91YorLrgs2SWNbnZ qwfw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=SmLv9aXh; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b07b30fd0dcsor531951366b.1.2025.09.17.01.05.48 for (Google Transport Security); Wed, 17 Sep 2025 01:05:48 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGncsdO703l59a/Q2xAzqDnxp8aG6XO/cQE+aoPELBWVBojZma/zo5GLdK+/uHw0J m75Sx/9bk5TNDifne4Fm+dxu9BUYM0yT8HxmYoIDZj2UWjRCOyBTeERG+4LlX8QB3/rfuKSo17M N/AM3CMAzNNP8Yq8wAbYHWi56waYX4hV3yQjjYPl+dPmIPINWIzLmbdTY1K7zTts/D5qmRVG09o /JsOh+dY7450bmUtvriWm45yFRVIFoqlQUFNy4qHIQ8nhZii9KInmRlE1q2uerPWVaOgltrVvRV 71lezAboumvEXDuugkOxZQMy5er7dvfYdyxjdVLVkJ94JQcBtXhf73EsxgaB5HVzcZ/n1Q4cH0c o44knNOipkRdRbjKSoZ9fXs9jm70VFglAWq3VOj5Wm3T0XQypfWD8ffaHZEo= X-Received: by 2002:a17:907:7ba1:b0:b04:9854:981f with SMTP id a640c23a62f3a-b1bb9268e9cmr163419366b.43.1758096341586; Wed, 17 Sep 2025 01:05:41 -0700 (PDT) Received: from localhost.localdomain ([2001:b07:6474:ebbf:1215:4a13:8ee5:da2a]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07e1aed5ffsm924936766b.81.2025.09.17.01.05.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Sep 2025 01:05:41 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Frank Li , Dario Binacchi , Conor Dooley , Dmitry Torokhov , Javier Carrasco , Jeff LaBundy , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH v4 3/6] dt-bindings: touchscreen: add touchscreen-glitch-threshold-ns property Date: Wed, 17 Sep 2025 10:05:08 +0200 Message-ID: <20250917080534.1772202-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250917080534.1772202-1-dario.binacchi@amarulasolutions.com> References: <20250917080534.1772202-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=SmLv9aXh; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Add support for glitch threshold configuration. A detected signal is valid only if it lasts longer than the set threshold; otherwise, it is regarded as a glitch. Signed-off-by: Dario Binacchi Acked-by: Conor Dooley --- (no changes since v2) Changes in v2: - Added in v2. .../devicetree/bindings/input/touchscreen/touchscreen.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml index 3e3572aa483a..a60b4d08620d 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml @@ -206,6 +206,10 @@ properties: unevaluatedProperties: false + touchscreen-glitch-threshold-ns: + description: Minimum duration in nanoseconds a signal must remain stable + to be considered valid. + dependencies: touchscreen-size-x: [ touchscreen-size-y ] touchscreen-size-y: [ touchscreen-size-x ] From patchwork Wed Sep 17 08:05:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4309 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id A5E603F14F for ; Wed, 17 Sep 2025 10:05:49 +0200 (CEST) Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-62857c0a375sf6059881a12.3 for ; Wed, 17 Sep 2025 01:05:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1758096349; cv=pass; d=google.com; s=arc-20240605; b=hIyFAnCLkYr+/iXiJGcShb8AAKl3ZdM+/yQrhYF0xb4Qy8pahuOGO3tDgJJ/Ys8Mlj OB839/NL4RpBdbxtASUT3uofdY2s5syDvabDTlX/vHT+S0m1pIkhO0HQ/FTY4B/rsmqa ejFy1pEMJa5bBoqhKaHi9EBp8ZJE8nqraMtGf55R080yK9Buk9gPCI8mPekG9sHca1vc ADflf+PhxNwAcHR97aDWxY4cye75xqtWU9GszNIkQU04BH02AK/DfBzOqKccniv4b+su W/USrU3UmRyuYYbSsUSn7cp5MWHYh19XHE3No8sMaBo8jr0imAN69KWQM/xC0Ak5Skxp mj/A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=HVciGDsDAmamgiAE3MKccHpZY09CYsIPDOzQLmQjwjY=; fh=Eu4PJHOrmpAh99MpM7H0TbGLmAHQoHfm8er8uxiQwCM=; b=jKAUFYWJq/jSweYFVdGqnwMOSygnBqD65tm8qv4cnHQw0VWuHZnMaQ/RPx4qWV9wqs 1RHs1eAN1vNH0t9XHYcVDxJDKMmCL2joVV/bnJ1eWXqUXOXVSjOa4r1BHUbuiMon/PmI 274eLRezWn6lMqHR6CHH/hE4xsBouFlrN0WUcsnmTUO4sNqSMlvm86teGrwdIN8c8rqw IERJAUwdu+yRhg1HiUF2+3sLliRb/xzVKx+UEPeBXQEkwCrBm7vGmu04Cqk0ulZCPywk HsBFOuOygdpz1NxCPsItngIoJ7QqzjDkZp5YI8uRn1/KR8l2b7pf6G2CSW0f8IwafWGj 28DA==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Cx+nGiux; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758096349; x=1758701149; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=HVciGDsDAmamgiAE3MKccHpZY09CYsIPDOzQLmQjwjY=; b=OxSCB6tREpfJliwd5no1gisVVnMnzNEY/uCoS+P2ddQHk2jKweTjHcneFgxoGMU+je AclvhT1qOxMCEonL9pnH0UbCQHS530E1xTyvT3J1B00W4eMZoNvQgFzaWoV8nTmUkuW5 dZcURrIfNh8TmYVn3+XOvZwUnnq3isBp99A/A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758096349; x=1758701149; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HVciGDsDAmamgiAE3MKccHpZY09CYsIPDOzQLmQjwjY=; b=WttR6eNIhHalj/LozQM1q2We06ehZtMD197DZ3x3z7D/bnUGEwuDj2CGi54T1CtOc2 I6ilqhYIf/wi3VO88IFmhc8CRiXYyEz6iguXMTdGOe38Yq+NEwE3C+D9RrcojT5m8bHQ 1jRozku5nWmmgU2+4t3OGNKFTaIEfAd3c7rnMjEx2uDvGBbF578u00hSVCSANQ/crRav uWjlVJF8IloFWXXT0J7p2L8+HJelEbaiDNG6WYQDPyyOLQi+qgvfDKg3QpHCsDw9MZUi 4Ak5ZiuB0T8zz3QXBgpHk8n909IE5wR3tZc1Xre9yDZfFCJ9bePPd0+eLe/xxZnbc05s MSCA== X-Forwarded-Encrypted: i=2; AJvYcCWR3xeoG606RXvcgpGBqQDQEUmgWaEdkMNh9pWCOmerbNWi6c8kdQ3ZCGD1bkM+1iY9frPCZpwyYA0XssbJ@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YyEndH7TKXzbSzzZlGBZBcoC2hDUde5VCG24NRE/3YKrYlUqKI2 6DLqPQWNYR6gXS+d7gFAh9PMC+v729aHXk9IWkenjhOqD5DoxLYgD7DfjU9aJkujpQ/0hQ== X-Google-Smtp-Source: AGHT+IGHwuvkcl08Vf+ZXG+tL+R1fHN0LDJRBCVSrHPy1d4QZ+5Kb1l5BVmJBOq698s8CUf+L/8KWQ== X-Received: by 2002:a05:6402:34c9:b0:622:dccd:5bc4 with SMTP id 4fb4d7f45d1cf-62f83c2da29mr1332429a12.11.1758096349310; Wed, 17 Sep 2025 01:05:49 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd40H2QmRtjlbV9AEQVPiJCyZwfmHzecpBSec7rSR9O8jQ== Received: by 2002:a05:6402:52c1:b0:61c:38df:202f with SMTP id 4fb4d7f45d1cf-62eba65972bls5948567a12.0.-pod-prod-06-eu; Wed, 17 Sep 2025 01:05:47 -0700 (PDT) X-Received: by 2002:a17:907:97c7:b0:b0b:8d02:f350 with SMTP id a640c23a62f3a-b1bb2366975mr151111166b.28.1758096344062; Wed, 17 Sep 2025 01:05:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758096344; cv=none; d=google.com; s=arc-20240605; b=IzMYENeNUiEpeebITYLXVcxklbGvWSKwOjKhgI+nQZPKnH3r+h+B0r01rVgjqaed7M dmGjPtG/Aytj/Ey7kqsB7M5a+iIwoe+EKEnlx+5f2sLMAylOLDK4P7NG8ZHJxSDZMluo SXCF5OOOLps2bGk9I5aaVSLlIDUFGPW6r5k+hMgM/PYr0gF9jTtvF4eu1DtUq8Rs5P/R uhmmuFUuq312A0sXD0gZKZK7wfiF+vI/9BZR+tASfMvxHPMEE7+TP7mvWHwywp3obhH/ 8LWIA8NjLxyOvHlmNspN4UMppCgCNTcNtdrRPvJh+WpOO3g2Bt3tGQIUeDElVpBs/tC9 E1JA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=lA/la65cC0J/yoE9Qt381Ko1XSyZ3tw4GtydE8nU3zI=; fh=C/eAVD10NeJkhxy8axdQG0kbCKLcVsvEXdenspgcTPQ=; b=XAEAt4+3HPWtrrMbUWuZSMeJyY9VK7Yjt4csuP932lx0UqsrRcbujmmTNLgybVGWxJ 9+vuSZgjgJn25v9Hap5Ssvb0ZYv+Ho1LHssC0OtS3GDAN39zfz/Wey/wCgs2j+VipSBN Ppr8pHqpJ4Rp1J1XE8yn1sEwoZ+hdXn26wAs02csmFLJ3yFWQraSN6VNOsqH/w3JdI6r Yc94ifkvzWnzCcg2LkWh9sxEyueazzaHg60AyGaq3jJ61x8cqKgWSaFVAzybjWn2juph e5u0ZCncxqjfIEGJZVBjadF9Bt2ioKP3zD1PZVs4vvwbMu2///J90g39P4D4XjY1NASZ p7WA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Cx+nGiux; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b07b32995eesor753832066b.11.2025.09.17.01.05.44 for (Google Transport Security); Wed, 17 Sep 2025 01:05:44 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGnctQ7Y0rlPwVs+zPNRyF5VHG2Ivz1rP5K30kNddwDndlG/K51GBY2u6arK9/le1 tWGFzSYcHjhHQQxDrTRHmSt1LutCjv3fst1Ye/nV6a55Xabc+lxUMvWQKqRcM1w8CpSZg03rpKt bQ/4f/aOxYDrtSuO98pdJkYAXbxznzN4cY0VxxLnKFj8JL43w9jkT7mchwCAt2Yq4hEMhoUrLgo QlWbrAxRVHb3cHYNfh08NpkzP6hXO1RuNWC/FciostKQq2f8T6Ae+Vv5XIUxfWrNJAolQU67i0g 2o95nRx5o1fBCgnfGEY5F18XfETIuUXzbZQO0+dfpMuym2WBtScfwfayvTTMhJlGYlGetYB/jaF 2zDihfXMKW1vYB8c1KL12Y/vvT+qR6lWNuMvCkPS1Yc5iv67lTopJfJuN34I= X-Received: by 2002:a17:906:d555:b0:afe:ef8a:ac69 with SMTP id a640c23a62f3a-b1bb7d419ddmr158716766b.43.1758096343566; Wed, 17 Sep 2025 01:05:43 -0700 (PDT) Received: from localhost.localdomain ([2001:b07:6474:ebbf:1215:4a13:8ee5:da2a]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07e1aed5ffsm924936766b.81.2025.09.17.01.05.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Sep 2025 01:05:43 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Frank Li , Dario Binacchi , Conor Dooley , Dmitry Torokhov , Fabio Estevam , Haibo Chen , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v4 4/6] dt-bindings: touchscreen: fsl,imx6ul-tsc: support glitch thresold Date: Wed, 17 Sep 2025 10:05:09 +0200 Message-ID: <20250917080534.1772202-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250917080534.1772202-1-dario.binacchi@amarulasolutions.com> References: <20250917080534.1772202-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Cx+nGiux; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Support the touchscreen-glitch-threshold-ns property. Drivers must convert this value to IPG clock cycles and map it to one of the four discrete thresholds exposed by the TSC_DEBUG_MODE2 register: 0: 8191 IPG cycles 1: 4095 IPG cycles 2: 2047 IPG cycles 3: 1023 IPG cycles Signed-off-by: Dario Binacchi Reviewed-by: Conor Dooley --- Changes in v4: - Adjust property description following the suggestions of Conor Dooley and Frank Li. - Update the commit description. Changes in v3: - Remove the final part of the description that refers to implementation details. .../bindings/input/touchscreen/fsl,imx6ul-tsc.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml index 678756ad0f92..1975f741cf3d 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml @@ -62,6 +62,20 @@ properties: description: Number of data samples which are averaged for each read. enum: [ 1, 4, 8, 16, 32 ] + touchscreen-glitch-threshold-ns: + description: | + Minimum duration in nanoseconds a signal must remain stable + to be considered valid. + + Drivers must convert this value to IPG clock cycles and map + it to one of the four discrete thresholds exposed by the + TSC_DEBUG_MODE2 register: + + 0: 8191 IPG cycles + 1: 4095 IPG cycles + 2: 2047 IPG cycles + 3: 1023 IPG cycles + required: - compatible - reg From patchwork Wed Sep 17 08:05:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4308 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 5215C3F14F for ; Wed, 17 Sep 2025 10:05:48 +0200 (CEST) Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-62b77ca3f64sf6257944a12.3 for ; Wed, 17 Sep 2025 01:05:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1758096348; cv=pass; d=google.com; s=arc-20240605; b=LIPAhYMDNpOkD/In9P++2aEdZgVGuYJmAwh8yA7ZCqTjlrO7aZoGn3gXgH/YiVzL8c NlW7ziEhVe+5e6yEPLsQsrN4/uBPTCKuCAE+2tBRzbGWUw5mlDPm7YQbd4gO5TuOuRa+ Spq3jAp+YwdmAv6Z98ruyrWOWa3Co6HJSEmMXPh0uGseulP6IDMlA4ihpx5p5PUmqhHm iOpMDJ9YoRRHcgpox+1UzoVrdonrt99QVse5r32MgwFrVdPH6A0qP8YOhuEgmVgLQkrG VwP3bcUQbCCpCC6rggYYdC9Lfa+QF0KpkRY6URg0ioBFKg5ctbNQTQ0jVpFsiZGFLTI3 /2Nw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ibFiH3EINui4hNoiNru2OJ9fP9FHYadsKNh2Up2Gt/0=; fh=F0AWuBH+i3zAGswm+Dm3iw63Okr0VR/FNT7BTOKsi60=; b=Bi0VehBKezyLfxtxBq11qHDQ3o5k3DaSko2cbNKa9AkX5+PiPP3SI2BfKtGZny5GFE f/DO871OmSRrsqyDNzp04Ct3P2Fvur0vx1dBpRHn5LNZfmDwNtVn/VQNjHKao0ScJNTK PvtDYIr0icAfvUmz2dJVE6cP5mpoZXt9K7oSFpt6waAikRPLUUfNWKUNtxP2vi1R6iHh Exb/sWwul0Zg5CaRq75KsVbvOHAcoq2N7b1ko3zkPFMq7rX/VfMZdiiw1cQ1HFWmQmPk HSaSRVJsvNPeHP55EC1kp0n30OE1Qaoj6ZE+WPdObh2tDoRavzh4YS0oNyy5UNxOxYaq yzeg==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=G4JrZzIb; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758096348; x=1758701148; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=ibFiH3EINui4hNoiNru2OJ9fP9FHYadsKNh2Up2Gt/0=; b=YOzKtKytLmzL16inWAZBls+DaQGy9WssZ2Hx++2hB1Yq8fSRkkIvARswW+U7PfrpUe VrK5TLepSPsFFH04yLtsNeqUFQIloAorDfIzjYt+QuSaE1yvv1s2SeitGlJAtO0EKogj Z1GPSoq+Oy9dZ4QVBjvJkIbXthqR2edY10HRk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758096348; x=1758701148; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ibFiH3EINui4hNoiNru2OJ9fP9FHYadsKNh2Up2Gt/0=; b=PCA+PErNmX4icvPNlNtbbMnape5oRPaEDJ7wY76VsdV0pOS6gGZfpTmnvidJEpq2sn b2vYGqQ3Xbk5a4qg52sxIGrwjrirko8xZFZKXqZG5FrKEj1gVy3liDdPT9iQ2WxJTI7F shTnL0xFJJx+8XW1uWjr/MZRdjUpQ0T4MDjpf2nmc++gZDiGM1sYJyHJdgG19kudjlPT YNcmE/tq+Lpbt6I6AO3dqf7JfIptFkxV4gLTZq6q+tJI9d5QLJAry3EgTkB074UO/vVC lS0J68wAsT95e7OaIepNRXsAQEPxTnpzPZBJOGJVibQIR3t7y7uXFHvZxj8MJ5zmSD7S Tbfg== X-Forwarded-Encrypted: i=2; AJvYcCU69TmwXCPlG0bNRj5YoW1dBmA0xPlcleST/M05aqubVEfQf4DQPNkohkhVGHVgQEZzW2hD1u3G4K7WA7wM@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Yzzmq16eDpggd6gGasAK7esLl84gIrmRV2oNFDvkPabBR5pxAo/ tJ+dT+9BLbwN6hazzpyBOSH3AOK0x9GykQv9s67oqwZIWlKvovudOfdAy12Gd4PtRYMGUQ== X-Google-Smtp-Source: AGHT+IExG0IFfu0CASIN7HaJdTIfuLPf4JlCGDUOc1fTsywUf+uNvaPHhqb/mCpUKjUcCHjacTgoOw== X-Received: by 2002:a05:6402:35d5:b0:62f:5995:3c4d with SMTP id 4fb4d7f45d1cf-62f8422e360mr1435381a12.17.1758096347884; Wed, 17 Sep 2025 01:05:47 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd6MgTy8wHYzxmRnDLIBTR4JjRWN+Lf+ZSM5eYfIB3VjtA== Received: by 2002:a05:6402:51d2:b0:62f:4bd0:6c60 with SMTP id 4fb4d7f45d1cf-62f4bd07015ls3191074a12.1.-pod-prod-01-eu; Wed, 17 Sep 2025 01:05:45 -0700 (PDT) X-Received: by 2002:a17:907:9691:b0:b04:3b97:f965 with SMTP id a640c23a62f3a-b1bc1168641mr151577666b.49.1758096345375; Wed, 17 Sep 2025 01:05:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758096345; cv=none; d=google.com; s=arc-20240605; b=aQNJn3YsMXgk4aeJ0S31NzLc69O6FVRlUY2lwNVbnh0S2gVGY8qbrSf9QHkzGBIusC 5hpG+dhfHtlPyvfak5PsWQf052rfEA8vSrHfGy9nT/earxAaeWTQ5hSGqkfe7hLVtFxG 0tZnJeAGyl9yG75hKhxUoR0lWwxAsTPFEg4+6ZfpxxJrn/l6u9ItZz+gp7/7g9FbfjA8 7CeZdVOomcc7LHoRbBNezQBiO4RIolkFlefcV5baqGYyrtZKDBqaCq4r6bmXr/gEcF5E MHzg6m+FouZAsQRUVsvfIVkO7m5kRA/ASMHPYEptqK86fcGpw/LAgb4o/opIHjAplXeT YTyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=AJ9ovkCr6DqOwPekQL9mbbfb8pXGwCeM0TnyH7IdLxU=; fh=BLUu4vzhSFQ/g+W24ynG+c/M/OQU2SvfvOLguGx/1OY=; b=UFpewAIqdK7Sx229d5hJB7WKxohLJuf0taJsuQagvDymnKZg5uP+aMQRBazdkJ8Eed H4Ywtphix0JhrDCdoYQEFjkRa0a8IxX1gnYvGhWcXg2weA5fV3rkCY4+8wp4lE4PPf3K ol2R/FsmO9JD16CMtY84f8LO8c9vm8geRvh0oCAmp+B/nYTQgdC1L9wFyuVhj7f29e2H qhdX8Qz9RRp8Ae4E/rDumnW2/XnjY2/RBlnPfQ64K7p7ScXnnDSfawdKSwquZxe/QXrd E2Vb5hGMPRMRafZYhFBfKq6COoy9pKJLvkVIUd3icB2d0Mvr9hiTMkf56yePjZM9uyXR m77Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=G4JrZzIb; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b0d05852f15sor415796666b.5.2025.09.17.01.05.45 for (Google Transport Security); Wed, 17 Sep 2025 01:05:45 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGnctQOE8POw7NZNgQP/izddrwYipgsWH4ehC2Tp1Zbao2bSngCX3PztY7VRfxTQQ 5x2wIOgR+qUmjaEVQiPV37H8Uo0hnEXUH7fJqgVCNlC0/ujC462WPESvuS1A4jrTY/2Lf6LR86J 63D4gWTiKPR3RzUbc9wpm4YnDAe2YtdPKMnv9p4YHVQjFh83+DZlA2taN6efcIy24v/+bmEb7qW q+4GZRziro2t2SuVbSzuAK+OvuTc2PVErHYjMKw5EhqP9jsobTw7ZhKZ0rA3Q7hrCKQ48DZ2+8j /PksegSFrV2Oc+GUd4/PLdFmPeRGgz3HQipRznApv2p/mWF79kDWqu9DRfkuSsQyCrbbXXs/ihy ff0k6+QsYKo8RptHdquxglc5Xv5vIm1YpKtMKRHNYaiMbdlsnr0KPXCul07c= X-Received: by 2002:a17:907:3f1a:b0:b04:7107:9758 with SMTP id a640c23a62f3a-b1bc0e86595mr153107166b.43.1758096344821; Wed, 17 Sep 2025 01:05:44 -0700 (PDT) Received: from localhost.localdomain ([2001:b07:6474:ebbf:1215:4a13:8ee5:da2a]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07e1aed5ffsm924936766b.81.2025.09.17.01.05.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Sep 2025 01:05:44 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Frank Li , Dario Binacchi , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 5/6] ARM: dts: imx6ull-engicam-microgea-bmm: set touchscreen glitch threshold Date: Wed, 17 Sep 2025 10:05:10 +0200 Message-ID: <20250917080534.1772202-6-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250917080534.1772202-1-dario.binacchi@amarulasolutions.com> References: <20250917080534.1772202-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=G4JrZzIb; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This way the detected signal is valid only if it lasts longer than 62 µs, otherwise it is not sampled. Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- (no changes since v1) arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts index 279d46c22cd7..f12084d8f2a0 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts @@ -154,6 +154,7 @@ &tsc { pinctrl-0 = <&pinctrl_tsc>; measure-delay-time = <0x9ffff>; pre-charge-time = <0xfff>; + touchscreen-glitch-threshold-ns = <62000>; xnur-gpios = <&gpio1 3 GPIO_ACTIVE_LOW>; status = "okay"; }; From patchwork Wed Sep 17 08:05:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4310 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 56E6E3F168 for ; Wed, 17 Sep 2025 10:05:50 +0200 (CEST) Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-629f069572esf848957a12.1 for ; Wed, 17 Sep 2025 01:05:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1758096350; cv=pass; d=google.com; s=arc-20240605; b=Y51JDDcx6DjxnW92ynWMYmwmu43/atqIgY6fqsumE83jmZuuCeRUSBsJwU/tRHax59 UTtSaZVaBJBtyTt3OesUqjeddQgdwJVHgerkxJGbksoS8n7BubIA1g7lZ25W9dh45Cah VsAYKYKjqK1OM+2+bhxKaCoiYT3cYxf537GzEU+yQaOduWHdXfbv2mcN/lJ0o7M02zlW HJA5mjXhh9de2gyLfaMHK5yxhJUKQqztGIkPUviIc0pVTSyb36qCZ0DDAJGFsJCp/rmD 1z7Mb0wTdSRuJnWUWju2HVBJTUB4ehRuqAHZ/Y2FnG1IxZvxDSIZXxZMNcJ6UmkxPjXo etag== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=3OpV/8YYKfKSwjz5eOuDaLDFik+85aneEAXjQ7oNeYE=; fh=iTm6jI8g6+Nr1lSlgnx1wWWzN+FjXp1d4mQVVBl301M=; b=EpR7Sy6iiPOgPwt0lAc0vvrLpY9E4uWOIzV34/ttM1/r/vnADwL51kh7kT43CIbfHY fAdI+ARlmgdgTf22f+/6EW976Z98cizTfXjAOGwoSlDRma3M5fRar71toMo4YCc4X40s tb/5AifNMCWlYiAa3N7cQdw7KeO7UX7+H5Hdia0AI6FCrd0KKnUsvnn+k+sVSw2MJzNi NxYJsZ6eARChzk/K2SnFzin9KTcISbHc5ef34D36VkAxVCAgOsqOfLfZyKZtmbp8a0FT soV6+pz2goFDKa5SJ2N7ztzx6N3STuelhWkEKXqdSZqwtVNEpWZMm2QTUTw7Z9li7flI oq4A==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=qUXICK9r; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758096350; x=1758701150; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=3OpV/8YYKfKSwjz5eOuDaLDFik+85aneEAXjQ7oNeYE=; b=Se0HRCrM8DFKyT7mY/XRKI6CE/hsZSwjtWAHK8dY8t4RNgGqKdYbwIGIUoPZOISDUk kep3UV2m3rH/EB5F6PpOsUxsJI+OtnrXZ1L9UyJ1Tlo1m2qReqEiwaTHO8o5bhpLTfW7 HGftbxteuSxpCA5xmki9L3SRHY4x5xWZfcFWA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758096350; x=1758701150; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3OpV/8YYKfKSwjz5eOuDaLDFik+85aneEAXjQ7oNeYE=; b=EKi41grVUUMyus4tjtgAxLFUf3cJT34ns2ohdkPA8Bkxr8LtDFOPmnYQ0jraLm5AHv 71aSt5PQUkd4AscFQjHIwlVAzxkUTUvYHoPv2YJA5WH/BQ1qZp1KrzYez9i9CdR8Top6 nXbWiVM0G0f8w60raBbdEgNlvWUhe/ro6nmChsXxT7VDXEmpd1mrFJ2bhD6vkdwtgonM lq0AIuUKwOkPkKlLRpRcjHHYgUHpcwbXN+n4ek+EF+e7ciEekSK05JvkX7w6nHNtDYt3 xBq1Yk1xQXkjMsTj+P9DWhuQM8vEoY0PZcB42x+r9OAwy20T5KXlsDZASAzuLa/8Ttkm 05fA== X-Forwarded-Encrypted: i=2; AJvYcCULHbYilt8bQzevqduErXLrDok54/pUp9DzeMmjd0HJns0vDafbTf2R1g2IYDdrXJW5rSRYVdfe+uhtht6N@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YwbhLmkFBVAbq9q2ZWY+oDhjlHRO6gKGmP6pRmAXQaSUsEdirEQ b6ZyLlla5PbeD/pVFcrweg0SHVDdEv2J1bdiosAZ5Y0KIeEz97nXYEoe/e9nXJTzBPpZLg== X-Google-Smtp-Source: AGHT+IE3nycBZ0ucroUuLv7Zz9eO39kTbeyo96Iklt33MYMR+4hthNwec1YrOWS5mbagofj2RNjxXg== X-Received: by 2002:a05:6402:35d1:b0:62f:45f6:13b5 with SMTP id 4fb4d7f45d1cf-62f65f67e1fmr5234796a12.17.1758096349896; Wed, 17 Sep 2025 01:05:49 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd6EAxrlk29AzyfbthqUZuX5nt870hDNXDCNRoFNTXBUmA== Received: by 2002:a05:6402:3905:b0:62f:36ff:5232 with SMTP id 4fb4d7f45d1cf-62f7c36e560ls361257a12.1.-pod-prod-00-eu-canary; Wed, 17 Sep 2025 01:05:47 -0700 (PDT) X-Received: by 2002:a17:906:4fce:b0:b04:6546:3475 with SMTP id a640c23a62f3a-b1be32837b9mr138662066b.6.1758096347241; Wed, 17 Sep 2025 01:05:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758096347; cv=none; d=google.com; s=arc-20240605; b=hX5ien1lFpOrE2LUxE6hl5Q3LRDhMjVUdtRyfJXigdXfybKhJIOKbn1xMMI8oOF/8b AD5oxo7qo1TDRTWxmCAjiBjBwzCRxJvE5EXY1ek4yKFpziMptlA3loFr+657pDrt3HaC RDhYiMi2WBOptNAyj87o1xTNCmXWDQyKSb38TRlff1SzkMWDYZfd0bEEwLRjYG3P6KY/ iG+kGspZ/evqapzFcV0ZtrSk7rtArhzx/Dmzc8q/i1hH8lb8U1Y7f+Q3TTBmcU3cM3NG aAg9UcgZxDfxY1F0vZpB11xN15xpQJvYSvQv0+5Qx7DTgisYE0sojt2AQ7SIu7Z175Ag jtBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=I/q3PAqpa8JFRI5D9goTpJtfgHgbqQ+Qd/SJYCaxuYg=; fh=07XXofEZG9d+QeVy8dz+2QB2lNQ+zt329x24x7giHEI=; b=XUx2B3p47rFhKSpJ8oZTW1r8cLL+p5XcLmJu2oKRlHPb20TZr+CQQrZPFe29i4yczC f2YP05mgpiqXU1dBMntp+4qJ03bHnVVAHNeFct7yMZhQrUzaqi+rEnC5dvUYMymLTJBe t9oQHdql+hNxHXEpgjRCHKng4HFbHKD2p/uCni9CXjDUpu7EJFsqp93V5LTJUOti/026 3I3f3jaYo8WK4d5axfmnLaI/vpFIV5r/pCUwPSsr6rpIvuN2NGWwLThr1HrkDQ6pAGy6 VTdLSEEvaOkk62nCXRM9ksQp/2ybJG+opyI2KfguJNRl36h59nnx10UIUtVeQZeWHZbz dhhg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=qUXICK9r; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b1a6f9bae00sor51638466b.5.2025.09.17.01.05.47 for (Google Transport Security); Wed, 17 Sep 2025 01:05:47 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGncs/bEjI7S7H+xova+Utn4HtQXCGEFoCO/hyXOQ6pgUF6TgPnlXC9uYqiJCWZuj 2HH2IhaRm5PIzHpjLFDr8G7pAoZhKtH+m9IE5qkRgp+a571vMYpLBACy5Kb7rbxBqfKwCZEOLox xsyRs7dDaX13ICWthBMA0QTmo7v4nUe58RtfzIv/JewHNsmLydawlggXmFOfggQninAqozr1Eww D6Ks0NelcelAL7yvLi0h90kR5QfUe3QRWg5oYC8jsZZMdlEhYKo5I7MzwaMSRoUQJk8Ec8UJ2xi 8HSG9OX6LtEHYKIBdMEyNyyJDCwF6t1oKkut5K6jIgus7ZEiut+gjoWkXzrgnRisjkZQ5LKNfqs +mRBdbxULuyhNZiUTSPX66adw/vM1C2ghRhnuGq92GHFamBhDKAZHlA2LAZPgMRiGCm2yyA== X-Received: by 2002:a17:906:c14c:b0:b07:c383:8104 with SMTP id a640c23a62f3a-b167ea6334emr662752366b.13.1758096346480; Wed, 17 Sep 2025 01:05:46 -0700 (PDT) Received: from localhost.localdomain ([2001:b07:6474:ebbf:1215:4a13:8ee5:da2a]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07e1aed5ffsm924936766b.81.2025.09.17.01.05.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Sep 2025 01:05:46 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Frank Li , Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v4 6/6] Input: imx6ul_tsc - set glitch threshold by DTS property Date: Wed, 17 Sep 2025 10:05:11 +0200 Message-ID: <20250917080534.1772202-7-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250917080534.1772202-1-dario.binacchi@amarulasolutions.com> References: <20250917080534.1772202-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=qUXICK9r; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Set the glitch threshold previously hardcoded in the driver. The change is backward compatible. Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- Changes in v4: - Adjust property description fsl,imx6ul-tsc.yaml following the suggestions of Conor Dooley and Frank Li. Changes in v3: - Remove the final part of the description that refers to implementation details in fsl,imx6ul-tsc.yaml. Changes in v2: - Replace patch ("dt-bindings: input: touchscreen: fsl,imx6ul-tsc: add fsl,glitch-threshold") with ("dt-bindings: touchscreen: add touchscreen-glitch-threshold-ns property"), making the previous property general by moving it to touchscreen.yaml. - Rework "Input: imx6ul_tsc - set glitch threshold by DTS property" patch to match changes made to the DTS property. - Move "Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros" patch right after the patch fixing the typo. - Rework to match changes made to the DTS property. drivers/input/touchscreen/imx6ul_tsc.c | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index e2c59cc7c82c..0d753aa05fbf 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -79,7 +79,7 @@ #define MEASURE_SIG_EN BIT(0) #define VALID_SIG_EN BIT(8) #define DE_GLITCH_MASK GENMASK(30, 29) -#define DE_GLITCH_2 0x02 +#define DE_GLITCH_DEF 0x02 #define START_SENSE BIT(12) #define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 @@ -98,6 +98,7 @@ struct imx6ul_tsc { u32 pre_charge_time; bool average_enable; u32 average_select; + u32 de_glitch; struct completion completion; }; @@ -205,7 +206,7 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) basic_setting |= AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); - debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, DE_GLITCH_2); + debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, tsc->de_glitch); writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); @@ -391,6 +392,7 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) int tsc_irq; int adc_irq; u32 average_samples; + u32 de_glitch; tsc = devm_kzalloc(&pdev->dev, sizeof(*tsc), GFP_KERNEL); if (!tsc) @@ -513,6 +515,26 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) return -EINVAL; } + err = of_property_read_u32(np, "touchscreen-glitch-threshold-ns", + &de_glitch); + if (err) { + tsc->de_glitch = DE_GLITCH_DEF; + } else { + u64 cycles; + unsigned long rate = clk_get_rate(tsc->tsc_clk); + + cycles = DIV64_U64_ROUND_UP((u64)de_glitch * rate, NSEC_PER_SEC); + + if (cycles <= 0x3ff) + tsc->de_glitch = 3; + else if (cycles <= 0x7ff) + tsc->de_glitch = 2; + else if (cycles <= 0xfff) + tsc->de_glitch = 1; + else + tsc->de_glitch = 0; + } + err = input_register_device(tsc->input); if (err) { dev_err(&pdev->dev,