From patchwork Thu Sep 18 15:52:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4318 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 557433F14F for ; Thu, 18 Sep 2025 17:52:48 +0200 (CEST) Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-b07d487c9fesf10196866b.2 for ; Thu, 18 Sep 2025 08:52:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1758210768; cv=pass; d=google.com; s=arc-20240605; b=CciOgaNGzTHU70jFnqTdGsiHICBVgQ/bDz+f56Xe4GujORZfySwaL749ya5k1ZAvk4 LmVo3X4X81Nk7+k8tyKAg6ifObjIIewZCCRnbVliKNb5UkDYYrgIkFbKBU7wKZ8RQWti A7NSLiaSr5ltwVoEL8k1MWX4K6C+wcuOkqOC9t9PM1GXs+mtIlbbWCesDFqkjAgGwYph MHES46LUrKHO7sejYsxTI2zsBSYGrfcyAUqByFUJcnFnN9T9DZIv/ExguxjMkmXwWfRt vXJnHNCWHOGOO6Mrq/+2gqJCPeqAeBfxdf/C3G/xMRefNtJ0JX/+qOYGUj73Ivu6sB4i 3pgg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=AJw/KVeM/9UkkwWlvFohsCzG0+Dz0KgdRZgm5UOIRVc=; fh=uku4ZWUAy2He8YO7acOm+G8drjfh5mx/3UvjkL+aI/U=; b=OMa+8g0IXfia3AWhBIRKwg3alV8EwSG2e79awEDmzvP8r7ItlVAJQ49EOFK7wXmjAP MjEflJCGC5Xr9GMK2yD8MU3uRZbEQzf508kJggNq1OrLhsZkD+T/htKQWyb42ejvxbqw ADpvBQKdUzwR8oCXaEvpUfHZxgzHq5zyEuuBcshINkvQnHAOkBfQnLveBfNMgmjFEsLH +CIfM7T1fjhxwHSeFSi/3tjgCN/vc5yXfZmu1pTTFMj9H+R6U/SNRqUbLh4RPdf/vrb9 0S8ubLyR8IAs7i/s5lBlTB2xfm31S4ZXiN/aX59akGfafgXyFQV4MDq3+9SR3cEsBZKo vpwA==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=PHQjFpKe; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758210768; x=1758815568; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=AJw/KVeM/9UkkwWlvFohsCzG0+Dz0KgdRZgm5UOIRVc=; b=kI33SM2P+JUKgxZ+cs3WPf0gXa2B5NSncdiSkRInZzEfqdiA+w2QR2V/Dme99gDLXw ToTEUW4xL08uABXrjF5M0xqRy39xSqsH4bjMADt+vGnBkjWVosDVfGZCWr5CdQpQ4PuG hjfGkPH4fKrIPMKsqaHuJn/VESIXzArTE6tOE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758210768; x=1758815568; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AJw/KVeM/9UkkwWlvFohsCzG0+Dz0KgdRZgm5UOIRVc=; b=CEL2CG1ia16qlfnpvkJfTJi72er3O+4dvlKmKgCig8VtIYa16zLaPDkpYpjxmtcIzf Ob2jTd3ExQSWKikkE+JhjAUm3VWBK3qOoVw+IkrThA2Ajk4anoJB/53nbkDX/bak1s6O ToOK/pR8KwGRhfk35PFHI5EmG0dCdunVsMy36ARMlx8fofCxwD+WLsy2nnQ2bLC6ITCf 3ldbaSXyMEDwgoo0u+UKUGMxtr2EWL4CseL8W5Ebstr8x012qVCdMKXgDKRWVQLXLyz5 0ZfW6NOOQfOFQXEmGHSN0RcP/gql3yOG7Ei7U/6LpnDSPXZNGelVa77Uv0/yS+RsWjBF TiMQ== X-Forwarded-Encrypted: i=2; AJvYcCWTlZDebQbh98EMsXcre3yYqKRYs8HeASBfQhMf2UFqO5NYKzITf9KKL12vsXy5/QzwfghGmUEM606j+owb@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YyBEDW5rNXAzqdUWF1cjdWwBxNVHsclLS4d50KZ6sKzVgbLLjf0 m671QLNuxBdjRbLzEA7GNnet5MgIqk4z2UwvZEv/Pj2W3MYE+hvu9dQpsZz8FJbhkESK/A== X-Google-Smtp-Source: AGHT+IHUpi1l7Wltdnn0sOvGUqr8L0sDKjprf84+sQZuqc290tkwhKmdhnWU2/Ix+4Ia5rrPtCyWPg== X-Received: by 2002:a05:6402:4308:b0:62f:b5cb:b240 with SMTP id 4fb4d7f45d1cf-62fb5cbb5b2mr359650a12.5.1758210767767; Thu, 18 Sep 2025 08:52:47 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd5TGQeVIKPHmm0r8//DBvxA9H4i+463JSzqAZ0jmDyDBw== Received: by 2002:a50:baef:0:b0:62f:b0fb:73cc with SMTP id 4fb4d7f45d1cf-62fb0fb7551ls294779a12.2.-pod-prod-00-eu-canary; Thu, 18 Sep 2025 08:52:45 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVrkX0uf6smLI1XkxLWpeZBLG2bmeqWa6t2A9kJcjyn4RYKDy2AOKgMQSPcCRV+aCSt/KifrvOv2nvebCTj@amarulasolutions.com X-Received: by 2002:a17:906:7953:b0:b23:20e7:b480 with SMTP id a640c23a62f3a-b248e0faec0mr20760266b.18.1758210765393; Thu, 18 Sep 2025 08:52:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758210765; cv=none; d=google.com; s=arc-20240605; b=jHEDc7ZeVo7K2fNiVmo99dzvZ6YbEM5s6wSnuPsgbFZ3ircn2tSED5NsC5gl9cqrrx LmtWPISFzy9zHe7tMcYokHepdCV5w/ssJO/ha/OUrFIpvW9w5RHSeMxQKN5E9bb+65j9 DimJxTkND1ryT++anVXEIKZeuarlqRf/bPaWHM51HV2UvWLANEGq6J87ZbGARUMuZTj3 uz5vhDs1MruPeXoIV8qDkl7JXktF753u8uZA9+tc4mqPudEWsg/b3aTuefdHzuB9A/C5 5JzwD7M8FKTIPdz5d0hOX00TwS1MgUuIZg/P7cZREKIXNCX67AECnvN2EGsesUk6q9ZX Z5pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=JAYdvSVQgA1h0haeD8J+mH93pNUjVxDxBFzkQXHtMmU=; fh=aGk4SnbltE/P6yxRx9VlPc6GoY1AIOrOuINVAxaHsTI=; b=eP0wPD2LInl8gbnDlGa07cBvMos742Z87i/WPq+btFMkfU3N5Cf7V10b15dJCB+noM SBTGCJy2IxjtK3BXC+KjYg72JfFKlJQVFEKYHxBmabllhOT2hqQqx5iPGj76Lymd/v0o TCGcr7R4xs2v9d0rhaCO8JBLztXhoSwmDV+u1EculzbKecmULap+sOFAtvvu9odZy/BC HgooNAdYICVUsyqt3dgcsw/2Bu14avluSOmH3jYnmD3cQNLHOSfyaOffxQBNTXs8bsis VCkSsw8pD3CZuKDUfnX4H82qiDHgbYrWUSQy9Y8W6LEgLxuy3M/17dV7uPgTx1/E9pzQ UssA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=PHQjFpKe; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b1fce787e14sor171509766b.6.2025.09.18.08.52.45 for (Google Transport Security); Thu, 18 Sep 2025 08:52:45 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCWMvgmbKdbEfCZNSmWYzFCtezBvn8coKeDdZef9zg2uayOHVgaN18/xO+a4bbtuY4LNNIzdUlKVWbXh49N7@amarulasolutions.com X-Gm-Gg: ASbGncsRnZm9VZdq15xrkY1LZkXZBG2pQ2dwd4QDNXRQ7IE48HlSCy1m2tCVlKUaF+F /G+Yr91w4XGXwXY/9p+L7Px4/LWymSq5WMFOVJWb4ZgFvcwDwEmmGKetQCUUEbC9yfvYE8FQtsx FanUKt5GSqqyZumVc1uffVDKsS3OtcPdRBZwiRPhYyUjx9ho9fWHwN7rS71sLD7CTHyyUBARnj+ eK6zfTqsOr7IrYZLbBazNCM9SJWOtDM2GIiiyPOiLvSkUPnWwp/9M1sSz9AJqqHO3+gGktsuPHP kLU9nORcSAnczhOjIp7W628vGjY/GrvRBvX13pLRXV857IfCck5LwHrLBcbC9kOM3hV9vHne3Gd 6fE9mGkUH6PLjavslDn48v1qZFqOQ7ZK9xvtr4Zd8TSZ+gGjJYQnCsa1DpXkyAgsbie8NtzCfou jc3hhNWYSrjgiqygjVyma7VlwGKCHuy+bU81i3MRViAY90HRvCVEM6dVEUk6Qp8bL3sRO9D+rwN 1v0V2cl7Lg= X-Received: by 2002:a17:907:d7cb:b0:b04:1d85:7106 with SMTP id a640c23a62f3a-b1fab24299cmr333418466b.21.1758210764801; Thu, 18 Sep 2025 08:52:44 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b23a1227bacsm60449766b.41.2025.09.18.08.52.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Sep 2025 08:52:44 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Michael Trimarchi , Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v5 1/6] Input: imx6ul_tsc - fix typo in register name Date: Thu, 18 Sep 2025 17:52:29 +0200 Message-ID: <20250918155240.2536852-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> References: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=PHQjFpKe; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Michael Trimarchi Replace 'SETING' with 'SETTING'. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- (no changes since v2) Changes in v2: - Add Reviewed-by tag of Frank Li. drivers/input/touchscreen/imx6ul_tsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index 6ac8fa84ed9f..c2c6e50efc54 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -55,7 +55,7 @@ #define ADC_TIMEOUT msecs_to_jiffies(100) /* TSC registers */ -#define REG_TSC_BASIC_SETING 0x00 +#define REG_TSC_BASIC_SETTING 0x00 #define REG_TSC_PRE_CHARGE_TIME 0x10 #define REG_TSC_FLOW_CONTROL 0x20 #define REG_TSC_MEASURE_VALUE 0x30 @@ -192,7 +192,7 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) basic_setting |= tsc->measure_delay_time << 8; basic_setting |= DETECT_4_WIRE_MODE | AUTO_MEASURE; - writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETING); + writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); From patchwork Thu Sep 18 15:52:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4323 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 698523F14F for ; Thu, 18 Sep 2025 17:53:04 +0200 (CEST) Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-62f935e6221sf979594a12.2 for ; Thu, 18 Sep 2025 08:53:04 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1758210784; cv=pass; d=google.com; s=arc-20240605; b=ggUXAb9+ceXKwSWHe6egkgESwlNzpWlM9XIjYQ+c8/ondpM1jSed9BBCcc+APYqKCl WyZOaiDbulXg/kXchrWKQmyb2ofwKdeJ3W/PMMRC1oAH5KVrwdIR+pNxrrJIiWcx5Fww 35f0QywNieBSG1TQMB2izdMzeAbsxMiSm46Kw/Bd05bCu1CCxQ1QHM6Z3Kwd2CtFnZaG 5EhN7IB6TiD6zxXO7/VYFydO4Vl/kR8zAzbjWncy+I2hpDr8G1Q+03cP6MX7NsuApY5o MgMREz0n4JSLQQtzZw1vFTI4nHHX9xMBE2l10BpT/la69Ke6CzApmR1P2U0kNhBH6BLl 2gnA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=qN+uwctul0mboouksWJmgzE4mbbYiYLV+2AkFXHilkY=; fh=do7hA8OLA+/GJJ2FVXLP2+UzNKQ94S+4lgtg22U82Ds=; b=bVCXXPNKx/WZgUcspwBMtPAFT0EQxe1OtoVVIt1zFeJZPgdnjoh/nOHZJQqfvRoNtp sZzhAtIkN7k7C+uV0WlWHzfQl6N9jamq1QEf+LAyVSGz5JTTXeW9XhQod74s6h0YWpdz V2n/NDxowrR3T1o4Ra3o6oZdp3ehlYoc+iOVWL66ic8QSCrjFDqG0cuzqaHH8pWtu1Hn awin1CCQZjwHebA61/dy6VnZWlaX6spnYi/7ODKKP/OHiNPOWR20IAOXs90nwOvUBEMQ J3L631hweC8at0hX6TvDgxwcdhDjfbFQkuOw3xam/3StqMG7VKeVp+h+SuD8SUQHkXUB TSUQ==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="qFcXM7O/"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758210784; x=1758815584; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=qN+uwctul0mboouksWJmgzE4mbbYiYLV+2AkFXHilkY=; b=Gwjv6cs6e1OeuKI2WseDmm7FhmEG2w0U1sNorFfTXZIvYNGobX/ebR3k+MDghuE4vt ipfBWxXuxIcrzqMEWQ0O4GbYlRllJORuYP9s7gZqKbUGH9KET9nfvtdDLTMruBzQE49o 7s04KDt5qLbscnGDc703Y+3H+0JY32y5vDkR8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758210784; x=1758815584; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qN+uwctul0mboouksWJmgzE4mbbYiYLV+2AkFXHilkY=; b=va8tzsI8L2/bSWpMeV2F81nbEcAzVRkSDi4sUX+K9SK972ZlSzgrAiEVOeLCzTu5Oq CaXiu16W3Myu44jDf2PP+i4mv9b/B9p9tbiR0YXwa5VRy0HggXDCf4e9PgR/9E1t9F/w c5QyeN0MU5VXuS7y4mJudn7P2GK2STSvaraZpC/gqpkkJcN1BIDi4VWHhCXsyGIlJQCv N8bdrnCQqrxw2nCYA4OkPGczM9NR7Bb+fn4VmDzJvtJhjW5iKy3XdpZu+L2HqfwR+NHk pHenFovMIVpu4LC1zV8IodYZDHmLZNqVJ+xPo0RAdKPxC++le0Aa1sv9KxEaY+c7+Ypw eF5g== X-Forwarded-Encrypted: i=2; AJvYcCVwL8LDvZ3Ozf2JmR9tdpMj19B+c0TVoAuWK/LhGdcS6i2r5m4jgod/K9IS+vmwGfju9nai7Da4hXJuyahL@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Yx1AnP08z+oZSKFXceyRbLBQv9EyD9PLd5jllHnydeTyuxNs9R1 boOyfDCPvteUxmn0qH/r01k6v9A5bF9dfh+nJJkEMEfsnc44LZDsMvh9Dn3vQM57Ri/dQA== X-Google-Smtp-Source: AGHT+IE7SAMTHa3RCzbmr7vDhrt9w+XeG2YkmTdZqaRhowOmeflyiJKAVr2wZ/TCXFg9j29dAvQuvQ== X-Received: by 2002:a05:6402:5252:b0:62c:34ed:bbed with SMTP id 4fb4d7f45d1cf-62f844410ddmr5958647a12.19.1758210782001; Thu, 18 Sep 2025 08:53:02 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd5g3JQWcvQ1yb7CMwsv9mLoBNI16el9mdTQNgigBIrqXw== Received: by 2002:a05:6402:22e5:b0:61c:3fe3:ce7d with SMTP id 4fb4d7f45d1cf-62fa7702337ls805570a12.1.-pod-prod-07-eu; Thu, 18 Sep 2025 08:53:00 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVCHZqyQZjBh8jRjn+CRVe3TkOLP9Aaz+OVmYrJVR8+WZ1xoiZVZpfo7lA/yGjkPHDDXoje+BCnX8ibnPSs@amarulasolutions.com X-Received: by 2002:a17:907:3d8e:b0:b0c:8280:4f40 with SMTP id a640c23a62f3a-b1bb50c3e8bmr740977666b.4.1758210779608; Thu, 18 Sep 2025 08:52:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758210779; cv=none; d=google.com; s=arc-20240605; b=FQQp5AzTEqhtVR2pjPtmlvcn5LVn12V4ktPm3LgNrh8PP2c/V0a0+hSEuwwN4fuEMh D/Y8z1Zk07pwVlg5Uykij0n9W75/1qCoa8XXxLbLmbOZi01u2kSKfXHjXcURcW2IFoeD p/Gv89F4oGG/pd5BtA+ITC3XyaVGdaQyAWnryKmBG1XdJsovi5fyqgVtvYwOSbfAc+HG CQbSEwHLVBqTdU40rroBkxqF6yHZHYv5MQDQYjCk9T4SmRr2S4hp1ZgflcEO9oCvZyi7 7VW+Err9vbX3kyrKRHwZIskarC2ycTcCfx2PPK4BsRhXNjr/KvUGh/VNXbVVCUgHY2JT my8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=kDNPkG1BJO1AhX7f67y0O0jm17yTyZBB5A5XJjEod98=; fh=9ff2Lnp4RmPdL0SSeqgSCs/BOojzfbfU15RQLnaHb18=; b=RlCMle7siUNB61vqQkbhmNXEIbrXY3hOnd3Eqq4oCiU6QLIWYK6hXhtxh+t+85b/sI YnQ0SGvTNjACPet87T3AOu4OMELGM/bBsF/YcxOEIoX7LuXKD2AenmIIOYf28BGXUUFF CV/JrspVoIQudHLiIb6HIPm78Dg0ex98rhrLWweHAdyRDgofa3wiERF7JuLqaBMZqJIO 22DBS80nhhVmsdOv4303rKMdpRchq16XfB6X1u1rc8Pgeq6uknJdMwO10OFq4sLsqiVq gFlR24KcqnsrfeeLskvNIPBR3GVp5PqAIYe6gGuyDdWTQFN0ArxQ12O8Q31sB9inBhHm X3Ow==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="qFcXM7O/"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b1fd205a856sor123167366b.16.2025.09.18.08.52.46 for (Google Transport Security); Thu, 18 Sep 2025 08:52:59 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCXC6fTEQdAVNn9X9hZ972F4jBVvm/B3e5MjsrBWkFX1/wgnygNIIUtLRVRmF2t7EaIoskigiyLdgV/z4ivn@amarulasolutions.com X-Gm-Gg: ASbGncuHQuuLuuRCiMtutPEyaUnkx9w9TdIMBgDPt3UD08znE5DCji71rn1Q7MkN2l0 wV00sewVKCeptSyxvGHzdONEQeK3ROPR3yBGErx7ZNkyQR+evtB43450ikTPSCebqrr+ZT8+k0y pWh83kNQ6XhpBsiS7S8mCWS39AgSKPilRySkSvFSX0P7xekaSBX2VU9OEqySWv2aoscnd39w23G Snk4MhISd5VzMkOq6R0oejz0FAtbY8EJZKaZD1glFGncbSNuSb8LrNgYzC5QuT6iSrSzTSfOjJI TRLrsPtnXKBQOR81gZktcagGcIICYQampkwlLqMvDG4xzjkxw28dsVXtQQ19/xJhAoAyzWqeTkM zV1X3MJU/DDxnUE78FdHcqfqZ8IfzGaLMhpJH1VmZxMdUoEZYJq519U20iAqhW84VQZmy5zM2gC Dl/iuRmq2Xs3iJgyl202fNCO9eKXpZlgjP0+SIUYa2xSf2ToE2pEbr+ezkSXiEWi1Gdb0mCSgF/ zTVUJmRXas= X-Received: by 2002:a17:906:6a1e:b0:afe:ffb6:bfaf with SMTP id a640c23a62f3a-b1bb50c4058mr757196066b.3.1758210766182; Thu, 18 Sep 2025 08:52:46 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b23a1227bacsm60449766b.41.2025.09.18.08.52.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Sep 2025 08:52:45 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v5 2/6] Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros Date: Thu, 18 Sep 2025 17:52:30 +0200 Message-ID: <20250918155240.2536852-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> References: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="qFcXM7O/"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Replace opencoded masking and shifting, with BIT(), GENMASK(), FIELD_GET() and FIELD_PREP() macros. Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- (no changes since v2) Changes in v2: - Add Reviewed-by tag of Frank Li. - Move the patch right after the one fixing the typo according to Frank Li's suggestions. drivers/input/touchscreen/imx6ul_tsc.c | 96 +++++++++++++++----------- 1 file changed, 54 insertions(+), 42 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index c2c6e50efc54..e2c59cc7c82c 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -20,25 +21,23 @@ #include /* ADC configuration registers field define */ -#define ADC_AIEN (0x1 << 7) +#define ADC_AIEN BIT(7) +#define ADC_ADCH_MASK GENMASK(4, 0) #define ADC_CONV_DISABLE 0x1F -#define ADC_AVGE (0x1 << 5) -#define ADC_CAL (0x1 << 7) -#define ADC_CALF 0x2 -#define ADC_12BIT_MODE (0x2 << 2) -#define ADC_CONV_MODE_MASK (0x3 << 2) +#define ADC_AVGE BIT(5) +#define ADC_CAL BIT(7) +#define ADC_CALF BIT(1) +#define ADC_CONV_MODE_MASK GENMASK(3, 2) +#define ADC_12BIT_MODE 0x2 #define ADC_IPG_CLK 0x00 -#define ADC_INPUT_CLK_MASK 0x3 -#define ADC_CLK_DIV_8 (0x03 << 5) -#define ADC_CLK_DIV_MASK (0x3 << 5) -#define ADC_SHORT_SAMPLE_MODE (0x0 << 4) -#define ADC_SAMPLE_MODE_MASK (0x1 << 4) -#define ADC_HARDWARE_TRIGGER (0x1 << 13) -#define ADC_AVGS_SHIFT 14 -#define ADC_AVGS_MASK (0x3 << 14) +#define ADC_INPUT_CLK_MASK GENMASK(1, 0) +#define ADC_CLK_DIV_8 0x03 +#define ADC_CLK_DIV_MASK GENMASK(6, 5) +#define ADC_SAMPLE_MODE BIT(4) +#define ADC_HARDWARE_TRIGGER BIT(13) +#define ADC_AVGS_MASK GENMASK(15, 14) #define SELECT_CHANNEL_4 0x04 #define SELECT_CHANNEL_1 0x01 -#define DISABLE_CONVERSION_INT (0x0 << 7) /* ADC registers */ #define REG_ADC_HC0 0x00 @@ -65,19 +64,26 @@ #define REG_TSC_DEBUG_MODE 0x70 #define REG_TSC_DEBUG_MODE2 0x80 +/* TSC_MEASURE_VALUE register field define */ +#define X_VALUE_MASK GENMASK(27, 16) +#define Y_VALUE_MASK GENMASK(11, 0) + /* TSC configuration registers field define */ -#define DETECT_4_WIRE_MODE (0x0 << 4) -#define AUTO_MEASURE 0x1 -#define MEASURE_SIGNAL 0x1 -#define DETECT_SIGNAL (0x1 << 4) -#define VALID_SIGNAL (0x1 << 8) -#define MEASURE_INT_EN 0x1 -#define MEASURE_SIG_EN 0x1 -#define VALID_SIG_EN (0x1 << 8) -#define DE_GLITCH_2 (0x2 << 29) -#define START_SENSE (0x1 << 12) -#define TSC_DISABLE (0x1 << 16) +#define MEASURE_DELAY_TIME_MASK GENMASK(31, 8) +#define DETECT_5_WIRE_MODE BIT(4) +#define AUTO_MEASURE BIT(0) +#define MEASURE_SIGNAL BIT(0) +#define DETECT_SIGNAL BIT(4) +#define VALID_SIGNAL BIT(8) +#define MEASURE_INT_EN BIT(0) +#define MEASURE_SIG_EN BIT(0) +#define VALID_SIG_EN BIT(8) +#define DE_GLITCH_MASK GENMASK(30, 29) +#define DE_GLITCH_2 0x02 +#define START_SENSE BIT(12) +#define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 +#define STATE_MACHINE_MASK GENMASK(22, 20) struct imx6ul_tsc { struct device *dev; @@ -112,19 +118,20 @@ static int imx6ul_adc_init(struct imx6ul_tsc *tsc) adc_cfg = readl(tsc->adc_regs + REG_ADC_CFG); adc_cfg &= ~(ADC_CONV_MODE_MASK | ADC_INPUT_CLK_MASK); - adc_cfg |= ADC_12BIT_MODE | ADC_IPG_CLK; - adc_cfg &= ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE_MASK); - adc_cfg |= ADC_CLK_DIV_8 | ADC_SHORT_SAMPLE_MODE; + adc_cfg |= FIELD_PREP(ADC_CONV_MODE_MASK, ADC_12BIT_MODE) | + FIELD_PREP(ADC_INPUT_CLK_MASK, ADC_IPG_CLK); + adc_cfg &= ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE); + adc_cfg |= FIELD_PREP(ADC_CLK_DIV_MASK, ADC_CLK_DIV_8); if (tsc->average_enable) { adc_cfg &= ~ADC_AVGS_MASK; - adc_cfg |= (tsc->average_select) << ADC_AVGS_SHIFT; + adc_cfg |= FIELD_PREP(ADC_AVGS_MASK, tsc->average_select); } adc_cfg &= ~ADC_HARDWARE_TRIGGER; writel(adc_cfg, tsc->adc_regs + REG_ADC_CFG); /* enable calibration interrupt */ adc_hc |= ADC_AIEN; - adc_hc |= ADC_CONV_DISABLE; + adc_hc |= FIELD_PREP(ADC_ADCH_MASK, ADC_CONV_DISABLE); writel(adc_hc, tsc->adc_regs + REG_ADC_HC0); /* start ADC calibration */ @@ -164,19 +171,21 @@ static void imx6ul_tsc_channel_config(struct imx6ul_tsc *tsc) { u32 adc_hc0, adc_hc1, adc_hc2, adc_hc3, adc_hc4; - adc_hc0 = DISABLE_CONVERSION_INT; + adc_hc0 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc0, tsc->adc_regs + REG_ADC_HC0); - adc_hc1 = DISABLE_CONVERSION_INT | SELECT_CHANNEL_4; + adc_hc1 = FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_4); writel(adc_hc1, tsc->adc_regs + REG_ADC_HC1); - adc_hc2 = DISABLE_CONVERSION_INT; + adc_hc2 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc2, tsc->adc_regs + REG_ADC_HC2); - adc_hc3 = DISABLE_CONVERSION_INT | SELECT_CHANNEL_1; + adc_hc3 = FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_1); writel(adc_hc3, tsc->adc_regs + REG_ADC_HC3); - adc_hc4 = DISABLE_CONVERSION_INT; + adc_hc4 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc4, tsc->adc_regs + REG_ADC_HC4); } @@ -188,13 +197,16 @@ static void imx6ul_tsc_channel_config(struct imx6ul_tsc *tsc) static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) { u32 basic_setting = 0; + u32 debug_mode2; u32 start; - basic_setting |= tsc->measure_delay_time << 8; - basic_setting |= DETECT_4_WIRE_MODE | AUTO_MEASURE; + basic_setting |= FIELD_PREP(MEASURE_DELAY_TIME_MASK, + tsc->measure_delay_time); + basic_setting |= AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); - writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); + debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, DE_GLITCH_2); + writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); writel(MEASURE_INT_EN, tsc->tsc_regs + REG_TSC_INT_EN); @@ -250,7 +262,7 @@ static bool tsc_wait_detect_mode(struct imx6ul_tsc *tsc) usleep_range(200, 400); debug_mode2 = readl(tsc->tsc_regs + REG_TSC_DEBUG_MODE2); - state_machine = (debug_mode2 >> 20) & 0x7; + state_machine = FIELD_GET(STATE_MACHINE_MASK, debug_mode2); } while (state_machine != DETECT_MODE); usleep_range(200, 400); @@ -278,8 +290,8 @@ static irqreturn_t tsc_irq_fn(int irq, void *dev_id) if (status & MEASURE_SIGNAL) { value = readl(tsc->tsc_regs + REG_TSC_MEASURE_VALUE); - x = (value >> 16) & 0x0fff; - y = value & 0x0fff; + x = FIELD_GET(X_VALUE_MASK, value); + y = FIELD_GET(Y_VALUE_MASK, value); /* * In detect mode, we can get the xnur gpio value, From patchwork Thu Sep 18 15:52:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4319 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id A54323F14F for ; Thu, 18 Sep 2025 17:52:50 +0200 (CEST) Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-b0413074929sf16402066b.0 for ; Thu, 18 Sep 2025 08:52:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1758210770; cv=pass; d=google.com; s=arc-20240605; b=E408c77Q4vXL2tWhxqwZZCsLnMATEd2wfS+fjrZqkNlIbnu+JnttO7+o5afakA5SUb mYawA+2RgXwk6BuqIOh2DRE/X/jZVolTOwaXxwWiDk1tknCCdtYTRCLEixaZ2y5jNRJL fRlVr1lUUD8atEMYhf+0xZ50rpp6PItDH1bbr/uVFEYVRMuQLPjmWPUccESZM/dJXTqX KZlqSZS2cogeg/tGU72gVwQzQlHayIaWvCSpJaK8MIDO1Enu9k2H9eU0fxJyC0r2kwDX Hcik+O9bkSG2OrR7XjfWnici926s37ms9K9VlO5K4a3vh4IKe+tSCDtkuVNZmFLEXgSJ E1gA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=+CRg+0kN1di9Ed8gLahDsPdrHvKRQCEO59PNnWM+zDs=; fh=Rn6z5wMLDmFbOCxjAoclWZDtXUqyBmKJC+WpgQaREE8=; b=lY+SABeSbcznPJ6E1YGRsWYIpvafqci7qZ9nbJBHxT7dapJjySV4wQgwCaRTbLOzCF fa6+ZXW0VbPCGUDSGRnKkbAqAoF9i5B3v6L3yYQxzUJQYly1dDLc6bzD4RC+6h4OxgaL V9mdulxXScpV2YGZBUIyBCrQ7sisdtSsgn7+5CKzbh2kV61TCLqk3lv162ImvTC0VeFg b8yPeDgE6Nlb+HHMaASzjeMz2evz+nD+LejgLlcWoKVQv2ThWDlMr+SQMdRL0dx0rGyi iyOec1KoFmZfZV5+bqaPuii/Z+dky0dG3q3S1fF1FgG/RBtXdfkQi86IXwdV2KWCY3H/ Pw1w==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=rcdB4Uqq; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758210770; x=1758815570; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=+CRg+0kN1di9Ed8gLahDsPdrHvKRQCEO59PNnWM+zDs=; b=KFtwaBLuH351aPrrycmQP5SY+DXNOZkLJ9bg8tfIP5KKJFkk0pTWHhmKwIHHP2VaoO k85l9HLMgegglpGaPSsSADh6+gH1xTUcCpPFOlIwG/ytlmAlzoQsMtD8wZKXYiy2N1wT bpmwQnd8mMgm1k+BLY2Ayf1ioeokKRKjtGEwI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758210770; x=1758815570; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+CRg+0kN1di9Ed8gLahDsPdrHvKRQCEO59PNnWM+zDs=; b=l6ZAMsOuvhqoD2e4zmubTaZQa5KxOly/Awz3uVl+NwMAWaFJB8A6AEmwe96J8lOMeW EVFveNP8dzpum94ugejM2MjJcv8gsCug0TrZ74L3GKGeOKd+0XYeBhVGWh+19hNPn4AQ OrMNdglxCjnu0fyERaKBLRW+IcRJZoBu4SDw/eirmM+Gv/iyImBmzMUB+Bjom3omotBI iLq8NKp8Llt3wcNCAB47ywpPU5JaNXJYNO+ElAHYV8F8S9hfRWeGe0MOtnA1xzasgyL8 rvv0oIRooG7umblqqjrsuGHNcDLOetvZ+JGeKlflz44PYuEdAPjWcaDl+jzDFykZnPHr g8tQ== X-Forwarded-Encrypted: i=2; AJvYcCUR4g0FNj2p/tUFF+WJjM+rjMNf1Pjg7ZtMoF+/D61QFSg7xJOiZGHA34oRjk09Yw8WKHJiTOkfnOo7Ybon@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YzXPSWeAlFDDT9m7yXeM0kOrOYA6UAp7Z1Bz8ibAQiJDxUUwGVW QvlQS6vIYso7cLDijejjVVXqb49jviH7SFXGXe0QrYGhpfKp777M1dm7dCJzSNg5HT9SWg== X-Google-Smtp-Source: AGHT+IE32kJh7HUISvhkZr9Kkil/uRanmZMxXbYu3RV07Cls6H6ZHQsMhgD4Cv4g/rWMh5fsrXJktg== X-Received: by 2002:a05:6402:518b:b0:628:d1b5:d207 with SMTP id 4fb4d7f45d1cf-62f842191a2mr3049535a12.2.1758210770255; Thu, 18 Sep 2025 08:52:50 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd5E1U/UbwWt1Nap97FjPJm8SyU2vaak3q11OosKx9xbKQ== Received: by 2002:a05:6402:23c8:b0:61c:c9e2:e4c6 with SMTP id 4fb4d7f45d1cf-62fa73600f3ls1069910a12.0.-pod-prod-01-eu; Thu, 18 Sep 2025 08:52:48 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCU415k+TATcmmX/fcp3x/mHqH12eFKCRbQKMM63pvgXIL1j4M/L2NBM1lpDlu+SciEq+2G26EUOseB6l6ca@amarulasolutions.com X-Received: by 2002:a17:907:7e88:b0:b04:97a2:64f8 with SMTP id a640c23a62f3a-b1bb86d78famr689618366b.2.1758210767949; Thu, 18 Sep 2025 08:52:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758210767; cv=none; d=google.com; s=arc-20240605; b=bbqb7JOf+0DiOqBMQtOwmb65BC636vkiQ5+G9Whkigz1WVLSO8eRYp0sWg47IFAu/v /+b6PBJekn1B4ZFwhG5/MIFrOjclmzAKEwJnz3/wDAbJnWfO4Xna+vZVEHxhjwWkYE9w ZmHvRoV0DBKeuCGQQ9zEJMJ3EjMI7YADouRZnLgJmdwcnremNFQvZTicTJaiH3Tbc2Xu R362M9XdSCuMI60+YoYnbnsi6dIuoeA18QuTqzOqVICmTCxYirE7co6XilGxvf8KBCEG YBnQE22qe/8aj//uHuPrca4s/SJbDgfXCMJEmQ3ReWcna2+eDhN2Pud1oGWTZU1ccZV2 iYUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=b+LIVzIwJpub6PF+1VXdSXGpljd8+6HMYi55fOiXUgs=; fh=buOXKd2sY2sp1LDmIKlSFPT2tTZQvvnO46lwc5lPDeE=; b=S+feKylF3/FNqS6EF3P8bWy1MujMYRMtsBfMbtChWP1XA4QcAmzXmV81vn71/WUn41 Vhxw4/YOJ8c6lIxXnXo6Np1NrcRITett0H3SrggTU5O/jIhMcZDNCcYJ3l2KjxBJljw2 0q+SuxeSvzYoKsSRZBzLePXMMUDGunsdjfnHz7OAFDJ2iH3VlkmXk39Yt9n5YhS0Emv5 Z4Mj1k+JBL6NeJreaLnQ/QyZF6irKnZ6ech40CubnzQP+xbynGsUtierhRkH/sjorGwp CY29QfLRfQrV/2wXdMwDveLbWmD6lRGVRAJWGzQ74Fc8JpsgJeL64q2G8TW7Uo+boWfu N7iQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=rcdB4Uqq; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b1fd36bfd02sor131001466b.16.2025.09.18.08.52.47 for (Google Transport Security); Thu, 18 Sep 2025 08:52:47 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCV5uqWjCjKldmmoUjAtUIq7PxGACm4gngHRvJ+vB07BZsv5SZzqyj2hfRIyZeHcAEGJfk+FOXDFvTUeK7Ui@amarulasolutions.com X-Gm-Gg: ASbGncsfvAVB/aNmKun+C3HNSFSu95dPS+E4JoZRZ6U9BQSZH9TMrigL6406KarXlcY W/4cdilW996bcoDuCIO9+EHenLsr2U5BNpi3MKn3j+kq3uNJla3lymfJUvRz+J+DDS2NOjjl2kB 4twPuIlDZs4d6BbukpO7684W/8Fg0gwOH6JS3nYHIH6/1yK9BIAdmR8AVptU/yLvDos7JDGsrEr Ve+s4fahtruebDl1O349zmnXKEA4tprI66xN7SxkVHhbd92+G3im86NeLHIuMzFFjhbcAiXx0f2 ZSgiIUKS3XOZ2odnt3TwuoGtKLE5fmCkm8P2GoPiZgnN7NC5wW5Wmzt2PiU5GKI4paUSEI9dDw/ GvSr5+9o7C69inTiU8H8SfM/otFKH4BtA2cltdMOIgWjuJDIrJSH9dg9nFrOQG5A/qB7XlofpAG 1sHa/J6jyxDLwttBW5ZsXL85HDGr+H9NcppL7FYVR5D42YsdmCw0Qo/OJbavCFeij92GnJkrKO+ vCpy8BOfMU= X-Received: by 2002:a17:907:7e88:b0:b04:97a2:64f8 with SMTP id a640c23a62f3a-b1bb86d78famr689615266b.2.1758210767474; Thu, 18 Sep 2025 08:52:47 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b23a1227bacsm60449766b.41.2025.09.18.08.52.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Sep 2025 08:52:47 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Conor Dooley , Conor Dooley , Dmitry Torokhov , Javier Carrasco , Jeff LaBundy , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH v5 3/6] dt-bindings: touchscreen: add touchscreen-glitch-threshold-ns property Date: Thu, 18 Sep 2025 17:52:31 +0200 Message-ID: <20250918155240.2536852-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> References: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=rcdB4Uqq; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Add support for glitch threshold configuration. A detected signal is valid only if it lasts longer than the set threshold; otherwise, it is regarded as a glitch. Signed-off-by: Dario Binacchi Acked-by: Conor Dooley --- Changes in v5: - Add Acked-by tag of Conor Dooley Changes in v2: - Added in v2. .../devicetree/bindings/input/touchscreen/touchscreen.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml index 3e3572aa483a..a60b4d08620d 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml @@ -206,6 +206,10 @@ properties: unevaluatedProperties: false + touchscreen-glitch-threshold-ns: + description: Minimum duration in nanoseconds a signal must remain stable + to be considered valid. + dependencies: touchscreen-size-x: [ touchscreen-size-y ] touchscreen-size-y: [ touchscreen-size-x ] From patchwork Thu Sep 18 15:52:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4320 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 80DC33F14F for ; Thu, 18 Sep 2025 17:52:52 +0200 (CEST) Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-629f069572esf2112386a12.1 for ; Thu, 18 Sep 2025 08:52:52 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1758210772; cv=pass; d=google.com; s=arc-20240605; b=LiH3sAIvdhUfeXrYULkgPK1lsyvn69nuzbSlLNNioAwieylTHUF0co4Gk41IiWVZ9c p2JIJIdcW4gLhKImB5rm9nslWNyzR5ExOubLvuSIngc9LOklp7tbshRMiLJKZ3xF7AMp I/rTPV/yu63sCHs9ntVwO0v6V71VWbaE21i7pGaAj/2klnm6iV7fgVYvYbFczv2PzVNS XBebWCE5qa5jLFfQniyLIX2Ve+hLG6NGAVV4Uyd471ChwTL7B0BprODTuvdzIXobvWcl AfH9WtlHnaEMzj01qeBqRhpXLgpO/3lCGB/1iA8EfIRqw+Kz/VcdV1kqfscDQOVXM0kt Z4ag== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=I4/uRBIbG1E49oTnSskb+gVeFvs8bjE2NpBjkWl5QME=; fh=dtMMmhC27qGA+ABBbijJ02rywU7ZJjbNo+fykE7oitI=; b=bfvISkW+v3tb5LYZ4mFaxxr2UvrewF4/bxfFpGSHXzzMBDqTrFbadMlHKbJUhMHTSK j5HQgsXDAHgTMbbtpupV4MAQb1Z16CLkSFgDn8+/ZaJcN/AAttDEDzjtbDYkG1SmjDMP 8EFcU6nrFtQ8E9MPV9zyay0+DEDysz82cvrZeyDtFQM72+QqkhEnuA6ZQQZFO/9XcsKR R1ZVlvYxMRdhhxgyW5dSStYCnLt9BCCTOgMxWpRK7KBqLPWmX4slbleJbkIddXQqwwq1 R0r2MZrkfuHaTbfXZD08kQl+GwX48cPYiDhz7FuWDKyfGMYezaheUOFVfQEI7NGmMxBX /A8A==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=KGtGbmg9; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758210772; x=1758815572; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=I4/uRBIbG1E49oTnSskb+gVeFvs8bjE2NpBjkWl5QME=; b=PcQR0nJJ0s7kR3kHsSrUs47a0IrYOrc58TPmoD2k/B7UJA/q7x1LuJaP4rhBHsrT9U M+l+xWTvJXGdKlmKW+Bp4O7u8Rd8ejDnDb6Hl/QBxw3tDAGemBjIQnBspk5MbhuE00SK EZ2u+URlhYavJttGJsrko6B8kCs2MtZr6a/f4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758210772; x=1758815572; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=I4/uRBIbG1E49oTnSskb+gVeFvs8bjE2NpBjkWl5QME=; b=jlEFdho0t2Es2CLNRUgNaE152ZriX5GHwPCK1kYh5teyMF/fSyMAfy6sfIHGbcmB35 l39GC+yQlnJqkkbakCUYApsNhefE61qAlEjfnqKfKUoVj/ZPrQtECl5XQqkvJqYi1a5f RD8tYYZrdAY8U7jsjnppTW2fuv1RTPTDwQKWUcgqUPgRDACwQ8yD80B0QJEBsn85H+Hu 3t6JFcRSUlbZJsrEIQEoWRbuEcU8kSBZ/P1oKzSO+k7f9/9Ol7tpNNOHD385KcFXtNhY Qyx9VoM6At99+5pseQV4nEgZ6qyHGoNilZ3K8jrUZl9fqRaPfCjxPN+J3hoPeMfLNCBA B2tQ== X-Forwarded-Encrypted: i=2; AJvYcCWyQKhdakb+YS5ycWGopvoetNv3x06dn/+94XDXRaJDxrcBmo8es9bEzW7JHt0R2xPON0ZWXKscCpMdLlT8@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Yz7RhAleGPxfwIjEzkUI0XUkbbqYdsBfsBkhTXJ9AsDvfxl04AR ICVApi0597XMDlKUtQTp2t7wofFRpF4JLht/A73dT6JoouaXVV8B/vzMgp1obOORNNg9Nw== X-Google-Smtp-Source: AGHT+IF/Ovw0LcyLNz713LfiyDkT7wI+HJ3DZoRziKLqnCWa9lYGc3VbFmKmIaCBiwkq7LulglPK0w== X-Received: by 2002:a05:6402:504b:b0:62f:a4dd:8218 with SMTP id 4fb4d7f45d1cf-62fa4dd8526mr2626422a12.11.1758210772100; Thu, 18 Sep 2025 08:52:52 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd7gVIXf8N9HGZyrEaOyPlTMofDDB8rNLsd3g6kJ8Dxw3w== Received: by 2002:a50:9997:0:b0:61c:2aab:34f4 with SMTP id 4fb4d7f45d1cf-62fa7730f67ls683563a12.2.-pod-prod-00-eu; Thu, 18 Sep 2025 08:52:49 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXo46Ds9npr6FfxAfIh0FnAsEarWuPkStnfnqZk04fR20FKw+piqJY7x249FpHA6TSaISuPcjnejB8RVrQD@amarulasolutions.com X-Received: by 2002:a17:907:8689:b0:b07:880b:79d3 with SMTP id a640c23a62f3a-b247fe8c3e7mr31682566b.0.1758210769423; Thu, 18 Sep 2025 08:52:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758210769; cv=none; d=google.com; s=arc-20240605; b=cpgrQlmACdGggE5PZJpGqH5xeAJ7HY4KbQpSfYiIweFkxNXKGF19c+xkbHP+Th1uWg kkcv2MNH4oDuVZ1xm5maOUs7OtmjoAjd4uCAc+8t3+YxQhWDqeAR+X+q/ezpU283IS0v wWixSBtM5yZl8rQHQkoN2jiPRZTMDF3f9Pw/c1K2XCKFWIfg8iodnIJin4/Opalr7e9J utzk2t4RrDpHXwz0D6hVdFrqUw74NJii7t6W+8Ma+h03Ezf3ICV5iI6xRoHmD9hWvPWj SSumUcVw5dKDjpgm3wk4hE5QzhNS9cSM9Gp1mTwA22SNvxJtVjesPnusnJFX2qD71bIT u+gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=9lcdJmzD84uDfab79lyqxcqnmMvBiautmvBU6m3EhEI=; fh=/d4NCsSYIkBL/34fs8DT54LO1y8peFNA6Qrqj8ZaRPc=; b=UKZDOQC6e3fMoohleFv5RAqOX0ADa6ptjdfUJPQNwFDam1ZkCTvejvo88ILKk4BmOs 5y3Kv4AEfJEG77ACmVIzJ+Eg4CX4dqh+wOYa7RGY01guDmspunEeFCr47s2vK9555CAx mMTdsOfV1tO3zW2+35tR/Jc2BUT+Mktizj3088HdteMHvF9PpheDMpkQmlqZ93Hxu1WM AeEbS6N0W97ar28OV2UznOuDOaCY20gU78jqrGMq+MlRIJoUZ/3VAjrmbmEwb2lZeaSR pKEwNT/w7SVvx+HxceddBdK9qzqXpdRlRRuGufDE4YvO7NlnrgDECcg5kVjYfAyFocQR FA1A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=KGtGbmg9; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b1fbb27151asor143523066b.0.2025.09.18.08.52.49 for (Google Transport Security); Thu, 18 Sep 2025 08:52:49 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCVBjjkW6CCSwMCP4m4V83sgMPOJwCDN2SHEBGy9cPBEV7dGMf777wqWS5U1W83C7wgnHvSylTDV6um49AoO@amarulasolutions.com X-Gm-Gg: ASbGncvRuC/DwLe3lWdQ0Staum/MOe92maeQaAmjlDPium1ZkPfDQeGzYjytNAjxUW/ QZajDG151HNKsYPA3En8Cewh9WpAgsSfGwXu9mh5t06A83I796KgQJqSox/kb2XPSiXydlTkji7 VKSsHJZhsRQ1iGKJ2q73/u0ZH+B2VQAzUUlA671fNbgpxg/VfSzXUqS9IJS3edqZews5wjq8qIs cXuMw/6fICjinoLwSbcMU/+rJLXfSXHgqWbAineRFw+cXxu5p4S5/E5bwaBeE5ZpgWxcDE7V9tI Y8Yij0Kg53yqu75q+/DENJZyVGUInqWESi6aQ4o1ijWHAfd41m+XSl+iT1DhGan/gRmKv/BgyQl tJJnV1/WnmjJqHeI93lQcy8pwis93331VLb4VoLhs2HqtoXrF6ICy1zbhOj+56ZjtDf69IAtIH3 9w6BAjBKxKWbBI0K9qSpyYsh0YdRzSP0Gyl/Nb+hTopqP77VJePCk1OwT3tZdedqyxC0QpisyCa t9hM+w4Y8g= X-Received: by 2002:a17:907:934e:b0:afe:ef8a:a48b with SMTP id a640c23a62f3a-b1fae7a9b82mr410713866b.30.1758210768899; Thu, 18 Sep 2025 08:52:48 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b23a1227bacsm60449766b.41.2025.09.18.08.52.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Sep 2025 08:52:48 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Conor Dooley , Dmitry Torokhov , Fabio Estevam , Haibo Chen , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v5 4/6] dt-bindings: touchscreen: fsl,imx6ul-tsc: support glitch thresold Date: Thu, 18 Sep 2025 17:52:32 +0200 Message-ID: <20250918155240.2536852-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> References: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=KGtGbmg9; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Support the touchscreen-glitch-threshold-ns property. Drivers must convert this value to IPG clock cycles and map it to one of the four discrete thresholds exposed by the TSC_DEBUG_MODE2 register: 0: 8191 IPG cycles 1: 4095 IPG cycles 2: 2047 IPG cycles 3: 1023 IPG cycles Signed-off-by: Dario Binacchi --- (no changes since v4) Changes in v4: - Adjust property description following the suggestions of Conor Dooley and Frank Li. - Update the commit description. Changes in v3: - Remove the final part of the description that refers to implementation details. .../bindings/input/touchscreen/fsl,imx6ul-tsc.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml index 678756ad0f92..1975f741cf3d 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml @@ -62,6 +62,20 @@ properties: description: Number of data samples which are averaged for each read. enum: [ 1, 4, 8, 16, 32 ] + touchscreen-glitch-threshold-ns: + description: | + Minimum duration in nanoseconds a signal must remain stable + to be considered valid. + + Drivers must convert this value to IPG clock cycles and map + it to one of the four discrete thresholds exposed by the + TSC_DEBUG_MODE2 register: + + 0: 8191 IPG cycles + 1: 4095 IPG cycles + 2: 2047 IPG cycles + 3: 1023 IPG cycles + required: - compatible - reg From patchwork Thu Sep 18 15:52:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4321 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 99C663F14F for ; Thu, 18 Sep 2025 17:52:53 +0200 (CEST) Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-62f637d59bbsf1208676a12.1 for ; Thu, 18 Sep 2025 08:52:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1758210773; cv=pass; d=google.com; s=arc-20240605; b=ZpVpzZWD5yDYGjsuNUseGOr7XPhkZISKu/Lv7yncnCcudk008V1PGPRUhRd/XHM6Nh py9kY5GylErO7i3zTV3D/ywHcLkdnyDddLm3gOp9kV8H6bkpNMBc1TyIF4SgMkO+EpbJ f9ElaWu7ajxVayL0X7LQA8Kb/9X/P9J5tvULWiWGb70pp1MK3iXTlzz2PAUG2vWZFWm+ FnsYHf33Ge0snbrbAsm9ihyj3sxSs53e28zA1LZvsEsYLDmr71BQqV7TwiHs8WHXWQbh XP2FNNFwm3MeKKil++Gw1cS8zs+4yC8q7EDjDilRNpGE9Kakc/VXx6+jjyxHfEGrVuZI KaMQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KQ6SFU/zgJDyQkBmqLnlQFxXNi5N94TKURv98JXly1M=; fh=ehLDEzImIZxpsdhW3xS4ARFuRXwJo+gIEvsSwmyGyx0=; b=H9FI4PZfDboOj03RZnJX4+29zjYkD4o0IV2Sas3mODFIXAlY6LBvdMOM5m/yhr7FP+ 9gyVi1WpHt7wl5saE37WFGdL18etcqnhKF4sshwZfEsEUmbg3YZcJ91Mb8fIp2YRy1pe 5iAGeyD1bwyfSzb1KfBuWLrxjtpM8qJ+XPgKetuL4klk/f1/FK0V3PQjdh9yfJ5y7RDU Dvigl6Mfgiq2hyoIPr/c1tWkashvHFRqvceJTLjbAfoDD18fIaVf0cgsFZPg+2QcVW6F 2qBLs+NinKGpwgeoqjRLsgJSDZAhU+kVdniHNyAt5dFe3aGaifrj+ltedpV5b4lY0Sg0 Czfg==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=p6Zm46wB; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758210773; x=1758815573; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=KQ6SFU/zgJDyQkBmqLnlQFxXNi5N94TKURv98JXly1M=; b=GHPVU6EZ1rWt7WVXGeuyjKucWDsmF0XC6P02srs75KTtGfZEtCZiQUWxC9F3Odpwjl x/2yjimWWEbQIpEqOEHSWJuuZ66s/XmCEnrFM14QS/Gxr1gCqDHvJ8uut24hKCbo/YUn rUnEtp1tXxifr26gyaQvl37ZQ6TW/QLLtC17g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758210773; x=1758815573; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=KQ6SFU/zgJDyQkBmqLnlQFxXNi5N94TKURv98JXly1M=; b=k9GPG1/JKd6SFqR9RieGgAu8bzOtNiU3TEJh4buJLp3A/G26kCLduR8OQ7jZ2W5LqJ YhQIph7wev15LYyPUKryqS2gupatl+EUatx2FqQnZgaGRhswNh/FQuxE4N59JINUK6fY EC0t5wFR5vWURYZCuBHtgjtubVYQi1DYM49c7gMI2vusJSS6MyUOaRxKbVPWLjbo1SFx DsXopdCJ7JjgBI7T5WWlt+Nh39cWFa8wOIIxkaOI1OPKHPE08FLUTuB2Du9N3T20taIM 5ezUH94ICiypBEMJkixUf4zzZ+8SXjIDyJc2Uw3APyPrzR4Qw+ceG4nlK6beTsunt0Bc n07A== X-Forwarded-Encrypted: i=2; AJvYcCWfzqpXOfm9unLnZVg68CiFGwIc5BFflaBIX2FpTkIEFxqqHrzjLA+6G62kbP/gt6XjFoO55bUDnxWzamMN@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YxxKGp27FH6yiOl6RDP16GVoMZJdTjezpkH8tNf6nQx8ei8Oc5b CUC2hRdAyF7AYj8uAN6jbJbTqqW+wRvPOPbwpHzqkdHyazwBSymJX2bhPVhVaT8F/Q7orQ== X-Google-Smtp-Source: AGHT+IGeuEtyYJW3J4QjvqNlZefdHqS60qfFN4BwsxruN9akjqTXo+Sdkw5CGbt9IwPXOdPkMmzPJw== X-Received: by 2002:a05:6402:50cf:b0:62f:6759:3b09 with SMTP id 4fb4d7f45d1cf-62f84240612mr6245581a12.30.1758210773143; Thu, 18 Sep 2025 08:52:53 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd4kU0pBSSoLwSqVtYx0F1OHlEFzfW72uM7rr0zRX7ApoQ== Received: by 2002:a05:6402:52d7:b0:62f:481c:4939 with SMTP id 4fb4d7f45d1cf-62fa7730caels923242a12.2.-pod-prod-08-eu; Thu, 18 Sep 2025 08:52:51 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUKpOqrtHMOU7TYTzkBkRNDu2UYO/bWwE5YDfUYc0pAyc62mUbn5jIKe9cDgJaPri4jl9NuMRDeS6OHY9+e@amarulasolutions.com X-Received: by 2002:a17:907:d16:b0:b04:7f28:a2a1 with SMTP id a640c23a62f3a-b1bb73a6993mr775270566b.16.1758210770664; Thu, 18 Sep 2025 08:52:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758210770; cv=none; d=google.com; s=arc-20240605; b=Dca79x+JIIrAmDWNSCdPpVs+wViqMR8JhKOHk1tGhuK2bxCr2KoSIJiIa2Sds5pIIa VjvPYT+17ZsEqFNcpCyEC+e4a9qNmb90uY9Fs2j4Gxzz4DokKvJHwcroiYbuKZXggX7a xCOCCekoCUSYiJod3GXpPy2+U5drWwXTcb6TpPVnfcOGpLLlpmm1hW4nWLGwOdLA0bl4 h0l2CSBPIYo+SpercPWltgj5TjoNnZHM4dyLS4QQfkO1UFWqlA2ms6XvBnXw3YvcvrG9 MwFrHF2MSg39Pnl0gADpc7gLDpgnus3sbWBzH4M2OF5ZzSBvxnF6UTgCV5YB/PcJSEHv l91w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=KC1/Z5A4C1NKjQ4MKJ5mwlwDtHXXOD1eqAPkjlkCE6Q=; fh=MnZZHuGGHTBTAxXyFB8ZnXYI6eE/6EmmptiYg8XIps8=; b=ciiZ9AMhQ8FtWzDC1A6dpTw5O6IR4ERx2qmrEkeNMJVDEdrpi+r6hcLJ0y541pBH43 qdWSzXKuRYcePcGHdYkCp5WFVgK0Ci3AGBQgXjh7c+QZsRheqjr5GaYZ4Ij4U7ZTidcm WR31vz1HS6La6qNI2FZUglnt+HFcEACdJggcKFsKSfHCJCVWglSS2YCuLx7i7V6nIgzg Ox7WhM6PmghlU7RnaCqvSS+5rg2X/t8G/LCdX7bvyALXnHMQ1p5xRdc4Zj8VJ2FgquRR fkE26xiM6BmDvSU4CI92gRK0jEuygRfToWKliK78O9IisuGD2zmSGrljIRBLq3yFpneH fxMg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=p6Zm46wB; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b1fc7d61012sor132819866b.6.2025.09.18.08.52.50 for (Google Transport Security); Thu, 18 Sep 2025 08:52:50 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCV580SlG8EnAxccpJHjgjaRWld4LrqMuUJsMQ9RL9V1PQcYKnFFpOKP/AOMjqeiuxkcSeXHOyiUU3KDL80R@amarulasolutions.com X-Gm-Gg: ASbGnct/uEBRknKcGYuFiCgHFV81q2ZOGU7Ccn9Gu8TNgK1iveUWnIdYNHoBasmyw3w Xx3/lHL07e6qZl/XmOvpUP00DYyBu+9BmUjfn2mB5sqjec34is1Qwe0mCKvSEVGsMwhJYSjZDw3 PxMmTMLl/Obaq4fRLUxgs8UczYzbWdTvrYEMIy6Q/e905y6+4+Dn3j/GJOBTqmbSBv6dp0LhvQO iKxGP7mgd2G7oMWTv4UDgcOKTaI8zn5adqM6SsxDvmx80oKZMFuLbPNQu0rNfhmjKikKqrDTVEm ssRayPq8ShkCqfJCZL3LrrNaEqyuUa5G3f80F6qfJLycYCDl0OCEfZfl2rE8+SbvDc1IBwpMjU1 pU4ZFhtvVAbsQSCua4vUb/TKs+922vm2swHK+wP5wYdJnvnQ19wbaVtjVSGykwVRIzWvOiTRIXo xax3w85rVYhvqX/y1wDe1o4f8s03TexQ1OLDGvYdVmkNUiBn8eYqx+ln0x0vvttWSPWx30UtdOF t/4Y2IYowk= X-Received: by 2002:a17:906:7310:b0:b04:858e:c1ee with SMTP id a640c23a62f3a-b1bb5e56d90mr782962066b.2.1758210770121; Thu, 18 Sep 2025 08:52:50 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b23a1227bacsm60449766b.41.2025.09.18.08.52.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Sep 2025 08:52:49 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 5/6] ARM: dts: imx6ull-engicam-microgea-bmm: set touchscreen glitch threshold Date: Thu, 18 Sep 2025 17:52:33 +0200 Message-ID: <20250918155240.2536852-6-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> References: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=p6Zm46wB; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This way the detected signal is valid only if it lasts longer than 62 µs, otherwise it is not sampled. Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- Changes in v5: - Add Reviewed-by tag of Frank Li arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts index 279d46c22cd7..f12084d8f2a0 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts @@ -154,6 +154,7 @@ &tsc { pinctrl-0 = <&pinctrl_tsc>; measure-delay-time = <0x9ffff>; pre-charge-time = <0xfff>; + touchscreen-glitch-threshold-ns = <62000>; xnur-gpios = <&gpio1 3 GPIO_ACTIVE_LOW>; status = "okay"; }; From patchwork Thu Sep 18 15:52:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4322 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 960D83F14F for ; Thu, 18 Sep 2025 17:52:54 +0200 (CEST) Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-62f5029db58sf1697329a12.1 for ; Thu, 18 Sep 2025 08:52:54 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1758210774; cv=pass; d=google.com; s=arc-20240605; b=eumnsG40dvTJOOxhBNMD7y3LM6ECslK06x7dReRo8Xizm75wxwMqo5juZu23j7LRYm Mz/PSJyGW/KIeYIgj2aHqvA2cTv1xvjPrwuJ7JPkvH3zEGpllyyOjvPKKuuqh1NNfEHj DNeHaqxDapFJ6JEldpxaoKsitupUN5+nHc0/qg458+xHrIgEPasBLg2mKG1z7ZpGLjBY bkfx0Ng+zyViPi5fUB2UJYxYCzS0BCM3N5BxpzPOX8vPc8LYYB8wkvQ9qHmVRQlNW38N 1T38F38b+usiiE3hWUEqq/IDD2lP36z8jOeUezii6VaNV3YCQF5LNiItQVf8on8cIlkf pwAg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tqNe22f18JcOWw5HwGXv6PtxE18Ta+bkBWtGf2PAgus=; fh=baXrFyaUTt7kK446EkVwnUO9/g8dNXBKa1eLCY4iM/E=; b=SI2Wgo9SRgqlIR6WYuEN0gxkcTXqfA6qbjD0R9WFl1/IGDJKziXyTqMSB454X9e+mM +hBerh7xJ8AkZu3t9lkBfrdmLk4PZBSf8ma6qQhQz/DlvorU2yByo+uZzDsguPOKWe7t Nax5IGOnOaVx/yhHH9z6fcteeMyfAPfFfg/vJHptEgcbCJiMIUFJW3jHSdk4a2zNQpvj lcgLOsMwkjRgmfIj8GvKvHWc/3EMKuaKDdnTAldgsAL4Va1zqQ3Dt0ZZIwTJkXJBoCIO tckf90KD3CBng9CvNDYJ6w2JFKafEkQc21RLmzl9V4mpBE0eSNkHeqANs8EnnoW4em0f Ftvw==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=NyvH5KME; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758210774; x=1758815574; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=tqNe22f18JcOWw5HwGXv6PtxE18Ta+bkBWtGf2PAgus=; b=UCqIPWwXJSMYS77KQXbNDBa6DJ+0XP5Xa6Zp6vaT59Kz4b1+PSrT+e1TQfI3cHFYwj C9zFiHZh2NxSwfvzQOPPkDt1EiKePcpmJAfSryww/M3aRugCUWmD9fF3oegeRoz81INX 9Okr6MXaFY2WftqQMSDq3kK9NOBBhiP5dbFDA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758210774; x=1758815574; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=tqNe22f18JcOWw5HwGXv6PtxE18Ta+bkBWtGf2PAgus=; b=tDfXi1mXVa4Ih4n+wjzFYlJligsK0ez5IzRyyumfnMadqvRjbu82oA5qvnp777p/Ye Dd+bK4CZu8IaJmIjo1ajDqyviyr5LoDI4PK4/lW7wOE9vRZhgaFfkXRW3Lvwx2Gy0myj J8tDRHBC0SuBlDKhOTiLvrO/pRrr1gIx+WtGqglc3q/IWRrmyEBmaGa9CLZtkAtzV0+G pg6OaiaoFktIyocVI2SeeNsMJrCgOTPM1465seaqmzea5KNYLb2WA8TnVj3ChNJDtXUw vMUko6PNTM1MWBd+9a5LSwGM4IsOsFX7GcK8ELEO2hovOHbZK2YK3t/mGXLLf+pJapEF r/Sg== X-Forwarded-Encrypted: i=2; AJvYcCWJiBIAwCqeXmxmFFcDCrjnvV/nnEj2D7WggJ+Mv1TWtIrCTvhMsIV0gCxMMlLPISMXDjFCzuLxDqanSCOx@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YyOHl71WK6hlMTZI+WcgzgeGeQKCvLlYrQCdThQP9JK9MSqlaTe 8LP8+rF2JwSnH/sOlgTzwRLnc5RZ2MJ8opq9lgaRfcFb2X5lOoMF+lNQg5OI7RzkqOm4muEj5i3 vUA== X-Google-Smtp-Source: AGHT+IGB0AA2MH1QIr0ACNLpQanCWCcgAslecMwn4zax8xFmIgHGeWWw/SiJqevChnvUGvRWt/zJHw== X-Received: by 2002:a05:6402:2688:b0:62e:de67:6543 with SMTP id 4fb4d7f45d1cf-62f83c32bbdmr5132286a12.4.1758210774203; Thu, 18 Sep 2025 08:52:54 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd4/fG3gRD9qwjeYMfa0FDQeAscm8J09QvjInhxx4IC7GQ== Received: by 2002:a05:6402:a0d8:b0:61c:ef7f:7d32 with SMTP id 4fb4d7f45d1cf-62fa84c6973ls1105383a12.2.-pod-prod-05-eu; Thu, 18 Sep 2025 08:52:52 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCViTVYjBaBsJU/vMGR57eNaTQQr6lpEfWn6RSYg+kRH39WIgXcwC6X62bAkStn02us/6909CAvJfciGaEv2@amarulasolutions.com X-Received: by 2002:a17:907:3da1:b0:afe:87bd:da59 with SMTP id a640c23a62f3a-b1bc02f68a2mr671970766b.42.1758210771910; Thu, 18 Sep 2025 08:52:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758210771; cv=none; d=google.com; s=arc-20240605; b=cLMNn4tu4IcAT4rRLKF23JKdYDmRyoZVqQeM1oJNmgB86tn+B1/k0Qz6f2griYY7bn A/7vmanAc3y6jjanZlb2UC5KcbKvYbK0LdxCrMr1ynVSjAcGHAsqGLgSTE6V4U1cL7zS YY7rL6zoN5CWEi7sEkJvP2jpB11YxhSp7KJK3QyOdct/EWeiZpRJU9+LGA2knZuvu6XC NATXWQQm38ka83PROZ63Uy/pywKRgpYmVdXYJGX4+4EfsS0N3i04xBsqDkLmqUnnuPpt snWXdXr2panw95jw/SX6x86ybk2fsl79qKVNWmj4XC86zJvedTLVnG12SUCOV141/pwR MVUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=K/20C6aqh7jqDUANzEy0rtZwUuYaJgtco0TQqT9aNmo=; fh=+LGpNdgcWjfbiZPbIdTYx/3nW82HYLLCBTMUTe3oTdk=; b=J0WvRGYu/kdI1Q4rarO3QH/cAomcWvUKZ7s7+NBBSr5Q0mvM48JO23w6ukxWcYLWyY 9xA3GKWNO1o7Uw9vDLPXl+Eeb3BEWun4d/Y4VKxrrKCoFEqYeTF6iFtImRNJpJgMUtXb esfnROGfurwFVvCEzUCyYB0XjYEg3F7Mbyx1gYG5Gh1UM05+zIuwqIYyRZglsEpYCMRB DQZPaC0R79XErBNnu6k9gSCd8lk8FU7uNsuVc08x7AualYx6SZkokC1MGXkQdm4CH9MG 1j9zlIJ6QMH//TbfPFtYJeyn0WEKq0B9tGIgSf4D2D3GehkoT+80eHkDPnxRshnRMOjJ QS5A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=NyvH5KME; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b1fc68fc8b7sor121020666b.4.2025.09.18.08.52.51 for (Google Transport Security); Thu, 18 Sep 2025 08:52:51 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCW74SQMzwmClgZzrPFWezHBQZoPz89T95OgHzkmdFs6Q3XvJUJvrTaMqR3TJjSrBAmpJ5FQkOYaoetZ8jhe@amarulasolutions.com X-Gm-Gg: ASbGncvrlPLaIHSDtRlYnM/oEQhELX3xFsAE5XA3ZH0e8VV9pSR0wu8kCSVklp5I0z4 5MdrayOn5jBRfXqcguqMQUdeaWYuF4zJeOuJch42sfEHOgjP7StTchPgaz7a5gQjYkArGFad1Oy kpnF6tbXLhwBPe5T2frTCevKdxqqBHzZaDSMEGVmbjLw4vDjt0s2lDpLXixNWRPkg20mciJk9Zd pLE2Jr4Wh5yFE7qxYzGFSAy5Ri5urdcm4mnw9pONz+wAYkkOMeRBAlsXEoZ8s75OhKyQgW85gSX Wj+106FlZ03exLWTSH+yrlMHU6YKGDrUThN6DlEjuqe79fok3nmB/Rp/Q9N3Ih93gZeCiTQSA1R fo+AWGMFPToMjIhyWzQH/FMZdVWjJUlatoxFerssZpYt3mLamfgPl3XTBwMIvzG2rtrPP+Je8JF 9cHch/p8hrkMp5pFXsj6GkEHL4zvSADyfCBbJLhF7KUVAmvT8WjUJjaK+HfQVnhSEGJpn0KNVdt 4Pp8lfyq6I= X-Received: by 2002:a17:906:730e:b0:b07:de95:1c70 with SMTP id a640c23a62f3a-b1bc02f66d5mr759256666b.31.1758210771452; Thu, 18 Sep 2025 08:52:51 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b23a1227bacsm60449766b.41.2025.09.18.08.52.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Sep 2025 08:52:51 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v5 6/6] Input: imx6ul_tsc - set glitch threshold by DTS property Date: Thu, 18 Sep 2025 17:52:34 +0200 Message-ID: <20250918155240.2536852-7-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> References: <20250918155240.2536852-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=NyvH5KME; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Set the glitch threshold by DTS property and keep the existing default behavior if the 'touchscreen-glitch-threshold-ns' is not present. Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- Changes in v5: - I didn’t remove patches: - 2/6 Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros - 1/6 Input: imx6ul_tsc - fix typo in register name even though they were accepted, to avoid generating conflicts detected by the kernel test robot. - Re-work the commit message - Add Reviewed-by tag of Frank Li Changes in v4: - Adjust property description fsl,imx6ul-tsc.yaml following the suggestions of Conor Dooley and Frank Li. Changes in v3: - Remove the final part of the description that refers to implementation details in fsl,imx6ul-tsc.yaml. Changes in v2: - Replace patch ("dt-bindings: input: touchscreen: fsl,imx6ul-tsc: add fsl,glitch-threshold") with ("dt-bindings: touchscreen: add touchscreen-glitch-threshold-ns property"), making the previous property general by moving it to touchscreen.yaml. - Rework "Input: imx6ul_tsc - set glitch threshold by DTS property" patch to match changes made to the DTS property. - Move "Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros" patch right after the patch fixing the typo. - Rework to match changes made to the DTS property. drivers/input/touchscreen/imx6ul_tsc.c | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index e2c59cc7c82c..0d753aa05fbf 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -79,7 +79,7 @@ #define MEASURE_SIG_EN BIT(0) #define VALID_SIG_EN BIT(8) #define DE_GLITCH_MASK GENMASK(30, 29) -#define DE_GLITCH_2 0x02 +#define DE_GLITCH_DEF 0x02 #define START_SENSE BIT(12) #define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 @@ -98,6 +98,7 @@ struct imx6ul_tsc { u32 pre_charge_time; bool average_enable; u32 average_select; + u32 de_glitch; struct completion completion; }; @@ -205,7 +206,7 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) basic_setting |= AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); - debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, DE_GLITCH_2); + debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, tsc->de_glitch); writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); @@ -391,6 +392,7 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) int tsc_irq; int adc_irq; u32 average_samples; + u32 de_glitch; tsc = devm_kzalloc(&pdev->dev, sizeof(*tsc), GFP_KERNEL); if (!tsc) @@ -513,6 +515,26 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) return -EINVAL; } + err = of_property_read_u32(np, "touchscreen-glitch-threshold-ns", + &de_glitch); + if (err) { + tsc->de_glitch = DE_GLITCH_DEF; + } else { + u64 cycles; + unsigned long rate = clk_get_rate(tsc->tsc_clk); + + cycles = DIV64_U64_ROUND_UP((u64)de_glitch * rate, NSEC_PER_SEC); + + if (cycles <= 0x3ff) + tsc->de_glitch = 3; + else if (cycles <= 0x7ff) + tsc->de_glitch = 2; + else if (cycles <= 0xfff) + tsc->de_glitch = 1; + else + tsc->de_glitch = 0; + } + err = input_register_device(tsc->input); if (err) { dev_err(&pdev->dev,