From patchwork Tue Sep 23 14:37:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4348 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 4F3793F143 for ; Tue, 23 Sep 2025 16:37:55 +0200 (CEST) Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-61d31626b01sf5846126a12.0 for ; Tue, 23 Sep 2025 07:37:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1758638275; cv=pass; d=google.com; s=arc-20240605; b=A08tTyl/11qq6TRdIMcvofRg7Wc83jY9RI7EqH6CvneMmHNPOu25NbWvLsnKRs2z3u 2hn0eOPvgKV6rmKxDi19cjQwbXpO1L6lA/oRc+OHIdGOHj1ghc2Cc03xr6E4bMrmklOE ITcKSUiuKe9yCVAVBqWzMp2XLBeJj25m2ZHV/0nYRJuRGvraf8DgymrQvvsm1n6tBFfM 7VsqwojHPm1wjXUlazE4vjrogTCS/JfygWttm3/raEoDmvwtm7qCR490AOZw/ANNz28s t8QFH/AR6IJvKObxRAxgiPCAcXe2WS60/non2Ybo9eVTXj5njuapwAWbdT2OU14a9mmG 8YEw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=AJw/KVeM/9UkkwWlvFohsCzG0+Dz0KgdRZgm5UOIRVc=; fh=KuTF5yoNJxHtEPve1yfvWGwqhCDCLNw6p8UJmpU9yRo=; b=EUxra5oWZR0V1kI2NRhaZ6epQo+ZKjP2uDq+DTtMSzhkF/vQ900iraoru3AvErxMJB SN2Zae66otV5xIYxDPThPEqRvJijIqHdCSZKv8N5fbWkNB1NSjsdsoIJeFhOl0ZY/COm zjE8OEQG4ajTReVGx4eh25yCBK0E16e0P4RqTN3lECy7ZDS4PCADVmryySYmk/rRwG9L 6SBi6K5dxONygDlNh9tRbhdZvuQtZspji8XTIyB/RrqTYyGNnK49Mswc0A683O7A8lrq 8LnEe9DyzALRYvhtEdE/qdVbAFwo5JzJ327v9m4eJeGxabJNvPkDiQeoU94tUT8OS9Dv aqbA==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=NakSWGWD; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758638275; x=1759243075; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=AJw/KVeM/9UkkwWlvFohsCzG0+Dz0KgdRZgm5UOIRVc=; b=q0N4uZgtLZyI5cZuQtWfFqqS/LVpM4fa8DSdoWqCR1bweuA9DG49Tal1U717XbC8JR 5FOY+qiubwWUxhUP6aPSjenfGhuVs+fiHW6gwgkfAhZXJEQtq8p7x5qsYDMEkXwBfEPT mVSo72jVUR+bCQvrzUQLEO26vdtSd8I1xklLk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758638275; x=1759243075; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AJw/KVeM/9UkkwWlvFohsCzG0+Dz0KgdRZgm5UOIRVc=; b=jgwsRDTvE6BRBWY0AK9DkrSdczuATMS6mvl37bH7lYRGtQtwA3SCGESOWaVFWeJFr0 K964UqOVfUNLJDbFvQB0cGw6XOw+LzbeCJmyoGfGvUUQDSGO0FyywCIh36OXX67AyqFA RqLHGK+JYcZZvvihy5kOdo0vFVWAdSvNR58//LqTQO3znHkmmo7vBXpXrNMA87vzshk0 mD2lkKDVpgpYxBgY6XgTb2D8S+qZMdmhtkvbrt4NolvIrRJ8YzKb5aV1lhreV/rJvOEI 5CciIFtro8ibrhwdGeEM6TJVtM1V1AUHdmNH9XO4PUwy0kik6PThA/+GD6yFNL28d0bK g4/g== X-Forwarded-Encrypted: i=2; AJvYcCWxPniK1Ye2B+JooD+9mx4EuYCupYx0Hs2QDCrjSsvlnZ0sdhdaAej0cUh5NYro9zwarpn21ZSiS0z/Gosg@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YwU1o8cCXXx7z4DJoGpnPYRugA66gkBjfdyPH/2uuZ/oHMafuNe t2/YWz4Iz8pOEPGhAkSMJf9UL36H41NHdFrme9rLB6uEV9vYRW0cYAgDUu/Te8pp9Q1ewA== X-Google-Smtp-Source: AGHT+IFOnTbgt67ZXzw+h8g/D1+xUUhoy+c7sPhSjqZETvaL4R2kupvihxDqNzorPWo4Mj8P7YXdjA== X-Received: by 2002:a05:6402:4398:b0:633:9367:58ff with SMTP id 4fb4d7f45d1cf-634677eb100mr2451049a12.19.1758638274927; Tue, 23 Sep 2025 07:37:54 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd4UzLNphuFCRppQXnQBvlaax/6dZ0ksNsCZOcuOPwhbVA== Received: by 2002:a05:6402:21d7:b0:62f:908e:11c9 with SMTP id 4fb4d7f45d1cf-62fa7557f8fls5278563a12.0.-pod-prod-04-eu; Tue, 23 Sep 2025 07:37:52 -0700 (PDT) X-Received: by 2002:a17:907:968a:b0:b20:bc1f:4474 with SMTP id a640c23a62f3a-b302ba11644mr293998866b.61.1758638271922; Tue, 23 Sep 2025 07:37:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758638271; cv=none; d=google.com; s=arc-20240605; b=O0+9WuUnGw0BbKCivpJxoYDLq2f6h99VrPByr8cVNhQ1G1sVdfMwVqSnDsh0Ns14l6 G709NwjcFBASGg2Jy7cnq5p5PY1bCPLlQfw9tvR4T2tZOHT92B7taeDY18Fzb3k2fG8v JaWiM2QXYLW0NbDrOwqhxMnTNuy1LMVDmta+3c6/lUncqKr5UVjci73PsDdTpoC0lzgv 7UQXBOyLa4gF90aTBqSJOV7jDQL3H5zA255aL55WFsCu73lGTVpWcsqCUZFzueENVKWw +RzfNs8A7dAdD4ezdekoxgzapmsbA2L7e1+pd7HBvISo68xPu3TwRrEXaR/pUPr113cN t3yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=JAYdvSVQgA1h0haeD8J+mH93pNUjVxDxBFzkQXHtMmU=; fh=2tTJ+Wz6s7lJCOQoemphz9aUXTAmngcJh3FcTDreg/8=; b=TEkMx6LAnq2JjVeFBEs7ajqb5mNT6LhUfrsxzlQXsz7+u9K8AzqdW4pUMbeu1yfhPl m+4H+1FavNDdIbRvNZwUWsXH4RTQ/ZGDXGmnPlTOGb4gDNU3muUcJ50XfYedh96CYunw 0K+cIAOfdfrhcKo++MyCEK+l0BXmZlWTDFlyyUK7CMpV9Cox1pk+5JUxN0XMGZA012vu G6ige0JpIecBJpmaKZRetT6yB+FpxKyW/Jbfyqi77Orgqn12E186QN08W1P70kQQA35V 7RnklzKNBik1ZNzqYpBBPNWk/2Z/w/xSKESJfACZyOC5wFrbeTPn45qWALQfCALo0/MK Llyw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=NakSWGWD; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b2aeda5d5e3sor267697066b.14.2025.09.23.07.37.51 for (Google Transport Security); Tue, 23 Sep 2025 07:37:51 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGnct88T/69Ry6GseBzuaaWhiPpOFrTQTD9kQQEooZO+aMABxs6BlFaRV8OCLxHlB Mhona/OFcRZ3ggBD3HKSP8Om7HmOFdby1eWWjSVvLJEugGBYk2oh1tsiVW8hO+zD3D2mbFJVmUk nZBohBDwXVLnzSLTHNZMIYULwt0+F2bdkFfCYQBEe2nzlzWc8AF9dzx4V2gTZAvqWyvYoQ5pi61 6mxDNLb6euRciqJd53gMg3AYTTzlx/ad8IxPf3JgtGmHkYJ/KGbE13G9Z0osq1HChGPuDXSHWjs SAlqbWc4AH5HQcD5Mg68plRiQ30x5l+WIrtOorb1ycrWbGwWQwDM63wx8+D9slXfjbESEn20qf0 KGfkS/Ohhz3FxK1DpaXlaE9uKOpMSyWR5PSuFGB5hEGScjxpi62WBpEpCzsiVSn1r2mCgVJKAZ0 Qd/q24BWZeRtgV7nFbcv/ugpoqGb+VEh2I+xa0Sgl85yY6WFFqdqvGa8nLBAn3lIDb X-Received: by 2002:a17:907:6d22:b0:aeb:3df1:2e75 with SMTP id a640c23a62f3a-b302af24e64mr265873166b.46.1758638271431; Tue, 23 Sep 2025 07:37:51 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2a2a5f6c7asm665204666b.28.2025.09.23.07.37.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Sep 2025 07:37:51 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Frank Li , Michael Trimarchi , Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v6 1/6] Input: imx6ul_tsc - fix typo in register name Date: Tue, 23 Sep 2025 16:37:32 +0200 Message-ID: <20250923143746.2857292-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> References: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=NakSWGWD; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Michael Trimarchi Replace 'SETING' with 'SETTING'. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- (no changes since v2) Changes in v2: - Add Reviewed-by tag of Frank Li. drivers/input/touchscreen/imx6ul_tsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index 6ac8fa84ed9f..c2c6e50efc54 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -55,7 +55,7 @@ #define ADC_TIMEOUT msecs_to_jiffies(100) /* TSC registers */ -#define REG_TSC_BASIC_SETING 0x00 +#define REG_TSC_BASIC_SETTING 0x00 #define REG_TSC_PRE_CHARGE_TIME 0x10 #define REG_TSC_FLOW_CONTROL 0x20 #define REG_TSC_MEASURE_VALUE 0x30 @@ -192,7 +192,7 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) basic_setting |= tsc->measure_delay_time << 8; basic_setting |= DETECT_4_WIRE_MODE | AUTO_MEASURE; - writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETING); + writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); From patchwork Tue Sep 23 14:37:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4349 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 266AC3F145 for ; Tue, 23 Sep 2025 16:37:56 +0200 (CEST) Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-6305c385adbsf4602624a12.1 for ; Tue, 23 Sep 2025 07:37:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1758638276; cv=pass; d=google.com; s=arc-20240605; b=k2GHGSVy0Zvu9ivMQ85aI2wrIFdZqIa0cAnxadDpgCK1wRX8BoK+iB4I4nU9hj5SiX lFxIkJ1yLC+wmeXtwUfu5mQyfyk1PgwHK4WYFz32bRt53QBAnwyOqCp1ONhyqkM2X/LF yC3GYzkr9N1X/2r0AAXgsVdOmde0eiY8vFi6Ku169pomz1voac1H4lL4wbUCpIDzPoR0 7XfFi/bmBrWz4MitaXeGlgmkGjoWr90dsmMe98SJI4idvfuRUCK0LQRFhpXFKjIQ1nzZ TN2eAVCdoI4LE6N3cFsVeUeGwJdlt/0TaPReEO69qNMROOv+FCEcSiyxKlFImRvbivw+ uB2w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=qN+uwctul0mboouksWJmgzE4mbbYiYLV+2AkFXHilkY=; fh=LMcfyYZfqnSYE4zkA9foMWrHwUiJl0pVfyN4e9YOJj8=; b=kemqp0bzz1L54KCGygYH0/wSYgTSgLe9qpGSpWE8Cc/dE3hIFJ9QM6UlKq4ODKs7P6 xJBj5gxakTFNzxSumOezaU0vvG1clFYJ3TaBLgs9tLsX8JUZ6EOSnTDlqMPP1SEZUk8Y niqspBD6NM2aY5kvvFVjwWRNSZeigw9Qq0mbDT9EsrpengINA2LrP+0q7ZMkEVcCLJjg LoY54s3jnfOfll7JKLcyJ1I0ODz1ODrKe1c8oCtSjNwBDnsJ2anHrC0ToUStT0P1b7kN 2ZKnx5O7TuyW3SV8fZZCW04l5+itlabi7xT/Vpupjqwmf7M1JnWviXESY0HXXrIEOi1I JAvw==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="A0/o/P7H"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758638276; x=1759243076; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=qN+uwctul0mboouksWJmgzE4mbbYiYLV+2AkFXHilkY=; b=DMhQmi1AynOlRVbVvUUnJ0bRajqYrDagt33QhmczvBc5nXDMNO3hbBivrArmUWb+px 6/yuh7c1gJ+kEalcpOLfK6WS9uN7KYyLf+8im5fNzqXZPbwsXkj0lpLoWFXMyXIxnuDJ +0axtRMLEdBhVWyH5Pq04w7wUra5SQ+INOuSg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758638276; x=1759243076; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qN+uwctul0mboouksWJmgzE4mbbYiYLV+2AkFXHilkY=; b=Ye9UXYisLrOkJoJXoGSQ95jzwp6Da3ehk4UiLcRM0y5NK1PlemUjAf+h1N5EYwB2NE B0PbkneoaGIYYEVdDtkq80z8XcOKkHYd4X8JPPryL+HTOcpKnxFvAEbmzUVqruwOBZoS WAv2ovX2c94vTBL90FZKS9bq3v/EuxYy3sYbas2KmlCWVkCCyRNTO1daezB1FIM3am8Y fRCX24vVzwJvSlTA2WVthRUSee5HJkcT3yNjNcMi5VDgALxlSJJJaHZk4bZRyz+zSi9+ NHWA3ko+UmYjLS/hRUL4KGgQ8/ngvPD62vvwCec0jQJxS6IdUn7FQ9ZCaURvaz47POWV Zu5A== X-Forwarded-Encrypted: i=2; AJvYcCVY1NTG28dU/IWSFK6wIPAxN+ukCzos6p5K97arWo/SF2uZR9xOn+CaCx5ZSi+jmMqrDk8y9x5Yvzb6yXue@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YwjXi+nTu+GWA5SLis6eYGCjt2Q/eySSyxwdxMF6iof57haTYWH pbu+ez6bg+/kwkiEZdzAIoMT99zPCvV2btZpEPpMzgZachZFC5ZJucVMH5+h4BuSMXuzQg== X-Google-Smtp-Source: AGHT+IE3x63fdjHZ8wEtAeIZahM7cfKzKTVqbOZ7qGqRsDuHLqQYOdsHqgPqPBuzKCl6+JZSiXQTtg== X-Received: by 2002:a05:6402:4557:b0:62f:569d:41ce with SMTP id 4fb4d7f45d1cf-63467804d72mr2061897a12.36.1758638275682; Tue, 23 Sep 2025 07:37:55 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd5qENMesAc5MHvavhP7TpOT/ah1Jyw0wYD0MwNICMEAmA== Received: by 2002:a05:6402:3789:b0:62f:4bd0:6c60 with SMTP id 4fb4d7f45d1cf-62fa77200a7ls4626148a12.1.-pod-prod-01-eu; Tue, 23 Sep 2025 07:37:53 -0700 (PDT) X-Received: by 2002:a17:907:961b:b0:ade:198c:4b6f with SMTP id a640c23a62f3a-b30264adb9cmr269101166b.1.1758638273246; Tue, 23 Sep 2025 07:37:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758638273; cv=none; d=google.com; s=arc-20240605; b=EXxwgr8Crz+f2bh0gihih5vp01aYs8AyGAabzAA8AThva49whmFZViepBgIdIrEWcc 4zDpK02VAEbbRLDq+t+qpsuEASK62HwqW7rxnzTkCa90u+BcoRfjSI9H+h6q5JeFWhK/ 1QnSdqR8GUoE28o2aTObEl2W08kH/JNx+5iZAzgrxDqbArnzWVSghuoaXuSeEClUFf3F 7El/L2Hb8Ef79ppgvleqIfzekBbB3iri2+xWgEUQIRwbIV5jIYEzNvSFX2H0ZqqOUcTU drRVGTRTnI80V+lgj29PobfL4//2lyMN3B473iNQOqzRruvWxvmTceblseZfmRL6FZ81 CgNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=kDNPkG1BJO1AhX7f67y0O0jm17yTyZBB5A5XJjEod98=; fh=07XXofEZG9d+QeVy8dz+2QB2lNQ+zt329x24x7giHEI=; b=TEMmbt+EFO61I608n6JkNNzttnnD8zQRMZoxiqkawUFrioAvdGEdblN1grNjFKDPRr iy5f60wWZQ19mUOqqoPK34Dp3NuIOCjEuRBKY4ia6buCH1UXJlSWLRCjWhvjElzyg0Tl rsbtYjtNDX3nhFtsK4AQfrsLUzCZY0kqClr4a4PpUZ8KaJcZhmXU9fZ8YCwIpllSRWqU nOew8FS4ca2SErVmokToPkhat0DxkPwPIQoFGdh+9Hf87Rta5lncOz9Ih8Yd/xL6SHuj soQh8TYZwScsiM3t8NwYFxNHye7555v0SrRuQl5/D7qvCDF/U/DGV90DEnIW2+kSGMEC QQ0A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="A0/o/P7H"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b2cedc31147sor243914466b.5.2025.09.23.07.37.53 for (Google Transport Security); Tue, 23 Sep 2025 07:37:53 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGncvuMKObGLKAJXEiRaJ/Jy/EahlcrP3mjL43wGrUIXfeMvjgoKDQaYTL9DpDNBl HuatnRBuE9EFLVrm7MC+E4Wvo0vLIKF8tbjIPaJhd825m/HB8AvbXKE4F75qvhynpyH2a286aEn 4ksLw1r9bLfYXSw52hMQ7eoW3QRpb5I0r5FpBnrahHxrTppr48K6UAjagKskl8FvH2Xkb0Q7KlI jV2K647OMRSlKRFR6xvbcY8WrjkiH65yfQ+5PFKZlPpbwZW0CSxucK+606V4zDneCnf0/Hd5aXK RVML68dNeJ1HX4ydnAthKEf7ZbFX5c62cSS3ic+/D0li+yWjPnOhFAUlJzqE9oWgHqPHQ0DTveW EikqpOdJAOU1Meg5yeNoSeNFgo1CTlIg+XH/oLBq3tLFLs3GY+0G5puuDRHYEIekRoGDcUC8U7O aiQhBiFi+oWseH2vS1JPDE1uxFMas5+ufjva+DtkpmuzliijuRAH8QYDoooUKHuwV5 X-Received: by 2002:a17:907:3d91:b0:b07:e212:4bf0 with SMTP id a640c23a62f3a-b3027262001mr277390666b.20.1758638272754; Tue, 23 Sep 2025 07:37:52 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2a2a5f6c7asm665204666b.28.2025.09.23.07.37.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Sep 2025 07:37:52 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Frank Li , Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v6 2/6] Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros Date: Tue, 23 Sep 2025 16:37:33 +0200 Message-ID: <20250923143746.2857292-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> References: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="A0/o/P7H"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Replace opencoded masking and shifting, with BIT(), GENMASK(), FIELD_GET() and FIELD_PREP() macros. Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- (no changes since v2) Changes in v2: - Add Reviewed-by tag of Frank Li. - Move the patch right after the one fixing the typo according to Frank Li's suggestions. drivers/input/touchscreen/imx6ul_tsc.c | 96 +++++++++++++++----------- 1 file changed, 54 insertions(+), 42 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index c2c6e50efc54..e2c59cc7c82c 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -20,25 +21,23 @@ #include /* ADC configuration registers field define */ -#define ADC_AIEN (0x1 << 7) +#define ADC_AIEN BIT(7) +#define ADC_ADCH_MASK GENMASK(4, 0) #define ADC_CONV_DISABLE 0x1F -#define ADC_AVGE (0x1 << 5) -#define ADC_CAL (0x1 << 7) -#define ADC_CALF 0x2 -#define ADC_12BIT_MODE (0x2 << 2) -#define ADC_CONV_MODE_MASK (0x3 << 2) +#define ADC_AVGE BIT(5) +#define ADC_CAL BIT(7) +#define ADC_CALF BIT(1) +#define ADC_CONV_MODE_MASK GENMASK(3, 2) +#define ADC_12BIT_MODE 0x2 #define ADC_IPG_CLK 0x00 -#define ADC_INPUT_CLK_MASK 0x3 -#define ADC_CLK_DIV_8 (0x03 << 5) -#define ADC_CLK_DIV_MASK (0x3 << 5) -#define ADC_SHORT_SAMPLE_MODE (0x0 << 4) -#define ADC_SAMPLE_MODE_MASK (0x1 << 4) -#define ADC_HARDWARE_TRIGGER (0x1 << 13) -#define ADC_AVGS_SHIFT 14 -#define ADC_AVGS_MASK (0x3 << 14) +#define ADC_INPUT_CLK_MASK GENMASK(1, 0) +#define ADC_CLK_DIV_8 0x03 +#define ADC_CLK_DIV_MASK GENMASK(6, 5) +#define ADC_SAMPLE_MODE BIT(4) +#define ADC_HARDWARE_TRIGGER BIT(13) +#define ADC_AVGS_MASK GENMASK(15, 14) #define SELECT_CHANNEL_4 0x04 #define SELECT_CHANNEL_1 0x01 -#define DISABLE_CONVERSION_INT (0x0 << 7) /* ADC registers */ #define REG_ADC_HC0 0x00 @@ -65,19 +64,26 @@ #define REG_TSC_DEBUG_MODE 0x70 #define REG_TSC_DEBUG_MODE2 0x80 +/* TSC_MEASURE_VALUE register field define */ +#define X_VALUE_MASK GENMASK(27, 16) +#define Y_VALUE_MASK GENMASK(11, 0) + /* TSC configuration registers field define */ -#define DETECT_4_WIRE_MODE (0x0 << 4) -#define AUTO_MEASURE 0x1 -#define MEASURE_SIGNAL 0x1 -#define DETECT_SIGNAL (0x1 << 4) -#define VALID_SIGNAL (0x1 << 8) -#define MEASURE_INT_EN 0x1 -#define MEASURE_SIG_EN 0x1 -#define VALID_SIG_EN (0x1 << 8) -#define DE_GLITCH_2 (0x2 << 29) -#define START_SENSE (0x1 << 12) -#define TSC_DISABLE (0x1 << 16) +#define MEASURE_DELAY_TIME_MASK GENMASK(31, 8) +#define DETECT_5_WIRE_MODE BIT(4) +#define AUTO_MEASURE BIT(0) +#define MEASURE_SIGNAL BIT(0) +#define DETECT_SIGNAL BIT(4) +#define VALID_SIGNAL BIT(8) +#define MEASURE_INT_EN BIT(0) +#define MEASURE_SIG_EN BIT(0) +#define VALID_SIG_EN BIT(8) +#define DE_GLITCH_MASK GENMASK(30, 29) +#define DE_GLITCH_2 0x02 +#define START_SENSE BIT(12) +#define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 +#define STATE_MACHINE_MASK GENMASK(22, 20) struct imx6ul_tsc { struct device *dev; @@ -112,19 +118,20 @@ static int imx6ul_adc_init(struct imx6ul_tsc *tsc) adc_cfg = readl(tsc->adc_regs + REG_ADC_CFG); adc_cfg &= ~(ADC_CONV_MODE_MASK | ADC_INPUT_CLK_MASK); - adc_cfg |= ADC_12BIT_MODE | ADC_IPG_CLK; - adc_cfg &= ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE_MASK); - adc_cfg |= ADC_CLK_DIV_8 | ADC_SHORT_SAMPLE_MODE; + adc_cfg |= FIELD_PREP(ADC_CONV_MODE_MASK, ADC_12BIT_MODE) | + FIELD_PREP(ADC_INPUT_CLK_MASK, ADC_IPG_CLK); + adc_cfg &= ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE); + adc_cfg |= FIELD_PREP(ADC_CLK_DIV_MASK, ADC_CLK_DIV_8); if (tsc->average_enable) { adc_cfg &= ~ADC_AVGS_MASK; - adc_cfg |= (tsc->average_select) << ADC_AVGS_SHIFT; + adc_cfg |= FIELD_PREP(ADC_AVGS_MASK, tsc->average_select); } adc_cfg &= ~ADC_HARDWARE_TRIGGER; writel(adc_cfg, tsc->adc_regs + REG_ADC_CFG); /* enable calibration interrupt */ adc_hc |= ADC_AIEN; - adc_hc |= ADC_CONV_DISABLE; + adc_hc |= FIELD_PREP(ADC_ADCH_MASK, ADC_CONV_DISABLE); writel(adc_hc, tsc->adc_regs + REG_ADC_HC0); /* start ADC calibration */ @@ -164,19 +171,21 @@ static void imx6ul_tsc_channel_config(struct imx6ul_tsc *tsc) { u32 adc_hc0, adc_hc1, adc_hc2, adc_hc3, adc_hc4; - adc_hc0 = DISABLE_CONVERSION_INT; + adc_hc0 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc0, tsc->adc_regs + REG_ADC_HC0); - adc_hc1 = DISABLE_CONVERSION_INT | SELECT_CHANNEL_4; + adc_hc1 = FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_4); writel(adc_hc1, tsc->adc_regs + REG_ADC_HC1); - adc_hc2 = DISABLE_CONVERSION_INT; + adc_hc2 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc2, tsc->adc_regs + REG_ADC_HC2); - adc_hc3 = DISABLE_CONVERSION_INT | SELECT_CHANNEL_1; + adc_hc3 = FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_1); writel(adc_hc3, tsc->adc_regs + REG_ADC_HC3); - adc_hc4 = DISABLE_CONVERSION_INT; + adc_hc4 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc4, tsc->adc_regs + REG_ADC_HC4); } @@ -188,13 +197,16 @@ static void imx6ul_tsc_channel_config(struct imx6ul_tsc *tsc) static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) { u32 basic_setting = 0; + u32 debug_mode2; u32 start; - basic_setting |= tsc->measure_delay_time << 8; - basic_setting |= DETECT_4_WIRE_MODE | AUTO_MEASURE; + basic_setting |= FIELD_PREP(MEASURE_DELAY_TIME_MASK, + tsc->measure_delay_time); + basic_setting |= AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); - writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); + debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, DE_GLITCH_2); + writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); writel(MEASURE_INT_EN, tsc->tsc_regs + REG_TSC_INT_EN); @@ -250,7 +262,7 @@ static bool tsc_wait_detect_mode(struct imx6ul_tsc *tsc) usleep_range(200, 400); debug_mode2 = readl(tsc->tsc_regs + REG_TSC_DEBUG_MODE2); - state_machine = (debug_mode2 >> 20) & 0x7; + state_machine = FIELD_GET(STATE_MACHINE_MASK, debug_mode2); } while (state_machine != DETECT_MODE); usleep_range(200, 400); @@ -278,8 +290,8 @@ static irqreturn_t tsc_irq_fn(int irq, void *dev_id) if (status & MEASURE_SIGNAL) { value = readl(tsc->tsc_regs + REG_TSC_MEASURE_VALUE); - x = (value >> 16) & 0x0fff; - y = value & 0x0fff; + x = FIELD_GET(X_VALUE_MASK, value); + y = FIELD_GET(Y_VALUE_MASK, value); /* * In detect mode, we can get the xnur gpio value, From patchwork Tue Sep 23 14:37:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4350 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id C9BFB3F143 for ; Tue, 23 Sep 2025 16:37:57 +0200 (CEST) Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-b2803556944sf45003266b.1 for ; Tue, 23 Sep 2025 07:37:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1758638277; cv=pass; d=google.com; s=arc-20240605; b=P7SuF/LbStu/6VZFseXRSRBs1BVIx0Wl/Y3Ul95geYfP5DQb036/lhYaz6aodJtg16 yS5ygkOp3sf1Xw/6cuy8luPecnQjmpBhzbTGOhBxX+3Y6jzaA6JqaLoirHHFQ8IhvTkm 1tCW2ICy14PL3VPbLgyFEmKAjOkpTuYtflhN8xssj9yNZBqsEFWoc1yxlW15ZakLz2WM E0nbO/TP3LxAGu2ymb1QlHDwXg695Ufz6N0Fa3Qd4NaXpKXGssTRPb/6v8sQYs4DzAA6 /0x7rv0VbfVMhAQxlaynRrPplhnLRRLGkVuRpX/FSnOF6MNmu2+O36MSa6thpnGsTNpb /QYg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/sESLkapVHkO+lTMMi+OUiIhwLqYQUoOOIsVVTpVzN8=; fh=w083/IBTxLRYCOCpmCF1Xc2PP8wCagSW9/w9jFEip1s=; b=cbS87XF1vFfn/vvSkXi4f9zsVtVIkxZrbT8/NcAEjzzRQjuHM7jbLxh4kt6sfVTZ2N glgNSyHuxeSimLL91tCPGBNpoxD4I4iMaAz4vCPo5/jOjT6EW0v9fE5qVOP5C3Bjybd0 xTTGRvOYWbBDtCMHIWf85L59UdNS5LHGz9mVT/KAgJ1/hdpZ6Jsn/IBnxCcCAl1N+ewz OwGIw95SM84mWSeCa0pcBH4FCCk3HsxxMJOSvBZT0O/prwzU4uiGHFOC7bonLA1MdQfh STQZsg9gwNd8qr0NJgytHw+rwcMe7jtKJehFKvZ3hQHu8gatWk3BiDK7/6NKyXtV/cfZ BgwA==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=m54HPuAC; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758638277; x=1759243077; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=/sESLkapVHkO+lTMMi+OUiIhwLqYQUoOOIsVVTpVzN8=; b=a9Otl3y8tkxQtNdLol4xl+gAZXEYXHkmTvQgbxT7PLyooLAFkcyorQhDNbHqEjYZUs 5v9ffdfJv5FjJ/5Yf4j4OPY9XIgQj0w6nH/I2Zc6sATG7P+vJdeFM1T/Lvvyx1ji4iSy YD4PaWqNLGspAxTRecYc+mWjbFrnC4rZhCt34= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758638277; x=1759243077; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/sESLkapVHkO+lTMMi+OUiIhwLqYQUoOOIsVVTpVzN8=; b=kVbem8d5HlY1lanScBPY3YLuGZBu7B+JjoyzwZ5Ic6//eo6PHdgcJPDesymOgaTy1B aXBIRmCOC2SaXk+Qt0CAPupmBIh3pbze/Vh99GxKi2WAjcwupPCf319Peent0/Ts8ccs MnK8V36Ss+S7T+C8Wm2nh50oL+4Ax1X50zN4zmDqXiVJBUFrBCn4EaUy1aF9b7dqbVAg 1DA9/VraTRu9ACG0MK8ATnmhAjSouvonrtaHvxwAyWSsC6zNHaWUMXNm1+nIEswBSJ3/ 0d5ZqrV42XcZaW3gVs2xSW43n0dqedFQrJOUUOeq/4HXr/gXzRgegLHGt20z1GzYdly0 XPLA== X-Forwarded-Encrypted: i=2; AJvYcCWaItKVJ63Z+lCsBFEvuSGZHDQbP+jkvHOm2mk8qv0C2BrgtcFaYNGGpnRBquIzu/oDE/bVfUvLSWgbK1I/@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YynFEnQ7WqkpSzDPRdAAWQApeAztDFFVJvWV0MrONzk+yNCkXJO ID4F+60sMHq9RqKQFRFwQSeR33/LbFVNvoqMrOOMouzuYp1VGtuUyxUrsBNF1VFNecKXAw== X-Google-Smtp-Source: AGHT+IFoniyT9kpVsELH5oNRmeeFptjPLIbihG7mTdGF5tL27Oxit4I51snehGSFFVqP7dow+cDHNw== X-Received: by 2002:a05:6402:35d2:b0:632:ac4f:d656 with SMTP id 4fb4d7f45d1cf-63467796bf5mr1239839a12.2.1758638277274; Tue, 23 Sep 2025 07:37:57 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd5v6nrHK6MI3Jr/XpPMqMhFVFyjM4Y+KtqzYu+Ry5mfFA== Received: by 2002:a05:6402:311c:b0:627:95b9:e197 with SMTP id 4fb4d7f45d1cf-62fa7550920ls4629504a12.0.-pod-prod-08-eu; Tue, 23 Sep 2025 07:37:55 -0700 (PDT) X-Received: by 2002:a17:907:6e8d:b0:afe:b92b:28e9 with SMTP id a640c23a62f3a-b302b21d45cmr263359266b.49.1758638274774; Tue, 23 Sep 2025 07:37:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758638274; cv=none; d=google.com; s=arc-20240605; b=JQ2z0LW/2GlykmsOMcTA80Ppmb//1YcgM38l1SCBHOBqTjV9lYrpBj58DN9V8Ecwis S26EslvkzVZLBnjt11wI4WCP28y6EEt/oCQF8r8Xuu+wp75npfJ4+Z14J6MJpjANr5GZ 1dFFG/KyQf/c6FJ0Bs0VAu9juT99BS/+wLvElzRxi2i2Mr5Ck/ESyX0WCXt03YVYldGJ 4pLXhQJTxYxtTIK5eFXLbpID8fvgTgCtqmLEd35QS9Oc2l81FAlPA+pr/J/ccRgYgrvW ObWcnbx+XalhZ/yKia/SKsnoP9xURXyx+UvsMw+14H2Auj7lxNs1sLo3nolqst8Z1Y5j RkBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=LqtR7I2mLZ8IDYwsm1m36JqptxBkiaofBPM08P2A3KM=; fh=e7Ao8x3Y6/URV/sMeUZdzWQxxULoqoBJgfQgBzaYc3o=; b=WZ22SWLyu6bYfCcIow4xyGJT56lHBEVDpH39FdcXnfHzys+gjwXyI/nhxKx45s986i 12pQkwsZMiMyblV5VI3KgKwEPyRBmR+sxEpE2n6mlEiVn/o6sdpKOHsleOKXjqG2GdaA G6LhvaDr+grV5ajrTt1TzEVaGSwV0SodI4fH7TlpjwYePVkyGgA8LYnp0phne0ZPNKV3 p1JAwFAd1HKlGOdSuVIOFtt5/4UA6M6G4wFJ/baoLuejQ6+bFrmtjbftERyHwZakL6DA YaR0AGqVXtMtEPAtkk6TCSM871YVrF2yLxmA4bCcWlsNbYqbjY5ea5R8nUvtTCwx3Fkv H68A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=m54HPuAC; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b2938f81e70sor363363366b.6.2025.09.23.07.37.54 for (Google Transport Security); Tue, 23 Sep 2025 07:37:54 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGncuLc2on3UzuzUuWCcQ/lnS9OCHjw623ErW/xJq7w0VxDccrU8tyoUsjvSXymw0 vwp7K5KnC3wUAkR8CUSyVTaghmciVYp08GddRct4G5ebxi+bSby1OlEmyA4AEqzs5pY+/m+hTs2 wrL6chIrR3PuXPS+iNyl0dneSAoxIPKAYQmHlSlprEI/HfwkXiQOZ9QrTM9eAC3eixshdzcoaUX D1P/LT/kTAwgQR1fzohLcLn84UQx8ipfwmsuegVNLSJURZwxXveZKBJzkpOl8sLUAh25WCiczEY pTN6quaj6F3RC1WLApWOsC5UdaJUZFfR1twz737I9BreQOxMyjsBTbdgl40m/D8fjFJGd3tnXvd b14qXiOVs6Eysyky6/HPF4IoE8qcQ940jywUzuQUboEx2c3ipEpoxE1qxE7P4H3b0MirpthZdkE zXQOKy9nS5fBuxnO8vYZJv2hcAk3bFXlB0AOtyGNbAAEJ6LFUnCzK161Jnw9pgpHr4 X-Received: by 2002:a17:907:980c:b0:b04:760d:1162 with SMTP id a640c23a62f3a-b302ac40ba3mr251539866b.47.1758638274273; Tue, 23 Sep 2025 07:37:54 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2a2a5f6c7asm665204666b.28.2025.09.23.07.37.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Sep 2025 07:37:53 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Frank Li , Dario Binacchi , Conor Dooley , Conor Dooley , Dmitry Torokhov , Javier Carrasco , Jeff LaBundy , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH v6 3/6] dt-bindings: touchscreen: add debounce-delay-us property Date: Tue, 23 Sep 2025 16:37:34 +0200 Message-ID: <20250923143746.2857292-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> References: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=m54HPuAC; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Add support for glitch delay configuration. A detected signal is valid only if it remains stable longer than the configured delay; otherwise, it is considered a glitch. This property was introduced for the i.MX6UL touchscreen controller (TSC), which provides a hardware deglitch filter with four thresholds depending on the IPG clock frequency. In this use case, the IPG clock rate is 66 MHz, resulting in thresholds of 124 µs, 62 µs, 31 µs, and 15 µs, which requires a property with microsecond-level resolution. Signed-off-by: Dario Binacchi Acked-by: Conor Dooley --- Changes in v6: - Rename touchscreen-glitch-threshold-ns to debounce-delay-us. - Update and improve the commit message Changes in v5: - Add Acked-by tag of Conor Dooley Changes in v2: - Added in v2. .../devicetree/bindings/input/touchscreen/touchscreen.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml index 3e3572aa483a..7023e8c73a7b 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml @@ -206,6 +206,10 @@ properties: unevaluatedProperties: false + debounce-delay-us: + description: Minimum duration in microseconds a signal must remain stable + to be considered valid. + dependencies: touchscreen-size-x: [ touchscreen-size-y ] touchscreen-size-y: [ touchscreen-size-x ] From patchwork Tue Sep 23 14:37:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4351 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 238CE3F143 for ; Tue, 23 Sep 2025 16:37:59 +0200 (CEST) Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-6232f49fc79sf5967125a12.2 for ; Tue, 23 Sep 2025 07:37:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1758638279; cv=pass; d=google.com; s=arc-20240605; b=gyKp4/egm2LAmYX7d1sCGDNf8TiyWVg9DeD5YMrNTeBgaKrpbu3T0x7Ez+9Exp7Wi0 22wQwcJzAs/dIS9AQaucZu7nfOuWAuBSswrFrMRvfk52zQQCjD+r/Q0dDojLp01RPfr7 evWggowIWIPsXEzOTZx/fY1z8AFB5U9Wnua+iertJnRxAdM+WykskkF1CDUoOGUC+yBa uKF5hEMbFbBlpmrKET44HgFUwytyg8RB9O9wwcWyR/rpKPqpOnLmklZgW3L62lrEkZn/ yWEXrl4sKt9NRKDWSzjDhsaCNDM7osWyNCk3R2E88Ma3D3ikw1pnPko8kCy14I9CTsPW e1ZA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=eLbzZA2mmta2wVH7vhkX9vdX80fsEt/sMDuiin9mqEM=; fh=S1QFzPWsnCFCIx5ZAqiPh8CddY0E/zyQGPVBsj/+npA=; b=arAsXpEH3aXWR/Sv0FKbf9yY2WpzssOXqHKzbHjdplwQrbCI/51Fm+dFKdNp9FRont H9uJRx2ohppyfmlAq9NLlKgukw3dxJYZWSlJsgaQ06UqbMEeuWPs7ofdH2SP4GAyb/GY ilHXyJv/MJW6QavV7QjuXtkofce9n7ABfkzftQQD9NDPgI9c2AKxCfBGjhXIsq915Yes +o80Ta9BIeQBe4uNLfJv8TwvWFgbrLeXbonpWby8Q6s6Ki1JH8Prfn4+ODdALZxNOlj1 8ccHcuSoRg6e7/24wMifGqOyModLY05dCDPIa2W3G1aeD3cgjdFidlHXZKifxPOiI1iA vFug==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="M+618u//"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758638279; x=1759243079; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=eLbzZA2mmta2wVH7vhkX9vdX80fsEt/sMDuiin9mqEM=; b=O1V12wauB/DatpzYN/jCnb9frABTSYLizud0AEkHlJ6pvyzrofwFe6o7hiexE4smoJ pmP7YHPTGpAeJWtcyq/EtxVdYD2K0hhtj3N1vVAif6zSWrZsWSKBWX41NErERay/t+Lx ie4yIERcITCvc80JX7WdC5AktXSsT/iFnEGc4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758638279; x=1759243079; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eLbzZA2mmta2wVH7vhkX9vdX80fsEt/sMDuiin9mqEM=; b=kCX9v4U4Xo3/QgOE8Ae49cIQRnDtPW8MUFoguka1bF3uKEj0LrzGsHETrGVDx2lDzC Ffdlv/YeuXvSGTFgegx9TcfcS/sfpv+ZvoZsMZBNNRaSGOVq/cJDpeH2SK8FwjtRS6dH h0+IUHVeprm2+LO7D9JoWeFjA1ZcpkJllbQ96GIR4qN9lxjicQx5dWqQQ1d6EFxUY8+D ixVB9fgWM1la6PaPSNcCwcpUYDGO/PILPbaMV3xKDRFT7ElQtsI0F6MZmxC5ExO6L1aH DrgKB4otL7kuVJ+yFOzcaTZEfZ0iLz/VRSrW99d5pKutN9Srw+3wG/FHpj9cW0hk0+LJ s41w== X-Forwarded-Encrypted: i=2; AJvYcCV6m88PTmQgXPMN/K7MZiLyvo/uVSrVDV/8isny5gfnixEm9mppkdco3f39jWbY0mCgQVmHW6SyKe6izqBe@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YzO1DvhUL5PWAzCGMRsdvy+2A2ZVGinKPffaLae2xCLK41EKbLM 7R7P6s6rDeIjYjVf9e3Fit6yVtXsXT9bR+/yhH6HwflzY4ozG1ASMSkbUMrYvOwtdg3sfg== X-Google-Smtp-Source: AGHT+IGyQGfDg2x0JCqQgStVsKttZgJxzxZY9oeodCt/g6qMXCTibEiF4lEpBtkS3ZXEmrecI1yYSQ== X-Received: by 2002:a05:6402:50c7:b0:634:5371:d713 with SMTP id 4fb4d7f45d1cf-63467783ec9mr2529901a12.14.1758638278772; Tue, 23 Sep 2025 07:37:58 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd5AlZBjWJqyzPieM7f3HEHmhSjLmrzN00B7i0IQUJXh2g== Received: by 2002:a05:6402:d4a:b0:61c:d171:4f48 with SMTP id 4fb4d7f45d1cf-62fa773b7afls4436589a12.2.-pod-prod-01-eu; Tue, 23 Sep 2025 07:37:56 -0700 (PDT) X-Received: by 2002:a17:906:d54f:b0:b04:36bb:545 with SMTP id a640c23a62f3a-b302b415c2cmr285988666b.48.1758638276261; Tue, 23 Sep 2025 07:37:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758638276; cv=none; d=google.com; s=arc-20240605; b=eeOci80NV0AcYBKCz2myeeDZX7FMNSKuXF4ieKvFYfe7/AfXwF55ejn0CERoP/e6W9 QdZT095kNpN2qOeNJ9iPcpvJqjmwVOXiRsyaPzNpsIQaToJ3n1GVPqjGf7ynS7xCWCbu dEoQdTsfvzmpdSk70x3GAUUYklApkLdjwtDaV4sqT/4fQ2fBbxR0OFNuZFyfhPqX/0VS 3M0QckTX9dQcHv7yWXTpzw1ewI9L3+FjTSCzBPDyZF0ayj8ptXWorM7afIQThZWUI3KV akgui7yhdUQx5+PLHwGUzRiLKXj/B7ltYhHMX+diDL7AGDQNVUSp/Wc407NPsYpOFDIj RpRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=OUcTQ2up2eOa5np9juHes8kBZBD61IeSVgwAmot8YUQ=; fh=C/eAVD10NeJkhxy8axdQG0kbCKLcVsvEXdenspgcTPQ=; b=btzge3Bo/tRaSJn2sSqDwbjYP9k2iq0Y8+73QVeuNj77rSb0pBHKwDvLxIjlfP1psc 218ksShHngTAyQgbieC69DgqOKxxk4OLdPXyycXbcG/AF7nPI5xp+2PlXkwlYwIiDM94 f0FCJFPlS8QZOkXB1wabGjSM+aS6K3NanQ/zMWR1RFM49k/dLVBIrVL65uYXbgxSCs4x rdIZLcMQ/2DKNxpNRvFeXQSpQj5xcibrAMBKrhY2z6AYdyltf9LRUtE6iwKLc+7HHajI ROklyGj/bhO2NZSyf8oPpgc0+ECM7kAbz1cdL35206NsPMAbhYSDY4JPlrpa+UC05M4g pfcw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="M+618u//"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b2f37167d39sor169512166b.9.2025.09.23.07.37.56 for (Google Transport Security); Tue, 23 Sep 2025 07:37:56 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGncvYrxATP9fANFs62Mu6Af6d9rY5VXcqwBIrb6tXxrwbA7N4VCDInxp7vARHw1t RziF52IQ8QLsBhIQ6l4A2hMU7dUUajRTqaw+LFsAZJxhpetxtE/3c6xjR64UKqIeOp7rY6BonJX jbhkmtcD32PXxwirlxqMp4VxUND72NvYYwXG7yMwmfU40AgJh7p7PSOexKZy5D888+oyukRcpaA 1eo9XR9sLsjJMtpNxg5n/wpZJry6M0sbsiGqqGO+xGicYBGLDx9wjd9/GIRevldLfJv6u2btRfS ga1snlSSquJpm8jOMicVNTfSb54rOpFOqk4x4cfSNaNNGaLgXYyqBdDHrvrw/sXS8UQy8DOMMgZ V39/4RfEKLcUpVLm9//TgzRief9WFKEySQ1ERn7AVYlocGNNnQJX95/p92zo8H0mTglwZFFfgkd ci22iXtMWt3FgO8G1KI6yCRGVRLSZ6cLzJZE93NU59/cG6H6WzWHnM95n9UJbb+B7u X-Received: by 2002:a17:906:f58a:b0:b2a:dc08:5914 with SMTP id a640c23a62f3a-b302ad3922bmr273199066b.45.1758638275808; Tue, 23 Sep 2025 07:37:55 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2a2a5f6c7asm665204666b.28.2025.09.23.07.37.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Sep 2025 07:37:55 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Frank Li , Dario Binacchi , Conor Dooley , Dmitry Torokhov , Fabio Estevam , Haibo Chen , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v6 4/6] dt-bindings: touchscreen: fsl,imx6ul-tsc: support glitch thresold Date: Tue, 23 Sep 2025 16:37:35 +0200 Message-ID: <20250923143746.2857292-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> References: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="M+618u//"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Support the debounce-delay-us property. Drivers must convert this value to IPG clock cycles and map it to one of the four discrete thresholds exposed by the TSC_DEBUG_MODE2 register: 0: 8191 IPG cycles 1: 4095 IPG cycles 2: 2047 IPG cycles 3: 1023 IPG cycles Signed-off-by: Dario Binacchi Acked-by: Conor Dooley --- Changes in v6: - Rename the property to debounce-delay-us. - Update the commit message Changes in v4: - Adjust property description following the suggestions of Conor Dooley and Frank Li. - Update the commit description. Changes in v3: - Remove the final part of the description that refers to implementation details. .../bindings/input/touchscreen/fsl,imx6ul-tsc.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml index 678756ad0f92..a99280aefcbe 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml @@ -62,6 +62,20 @@ properties: description: Number of data samples which are averaged for each read. enum: [ 1, 4, 8, 16, 32 ] + debounce-delay-us: + description: | + Minimum duration in microseconds a signal must remain stable + to be considered valid. + + Drivers must convert this value to IPG clock cycles and map + it to one of the four discrete thresholds exposed by the + TSC_DEBUG_MODE2 register: + + 0: 8191 IPG cycles + 1: 4095 IPG cycles + 2: 2047 IPG cycles + 3: 1023 IPG cycles + required: - compatible - reg From patchwork Tue Sep 23 14:37:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4352 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 3D47A3F143 for ; Tue, 23 Sep 2025 16:38:01 +0200 (CEST) Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-634700fe857sf488659a12.0 for ; Tue, 23 Sep 2025 07:38:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1758638281; cv=pass; d=google.com; s=arc-20240605; b=M0y2jlxi65EGbHvqYVOAOunShcEsN0TRZm8q6FTznx5xyP8SmiLlBV/ZYiH+SrTeV/ z/+8wSS5VoGQ//nX1cjAWANI6ABFQat9Te4lYJXnWNuf7KIpXUhx2trmx48OXVaQs0xt q+wo7tuWDaQXDigsm+ZnqCh7GZQaMsuWxOF3hWD4/YDQZCioaTrlZRkxuhUe9SQ+fXW8 a6fE7Zu2lyxMCwCkhhkNdaIa+r01rZuokg0FmDLNMRQrvW2HDP4YfFI0XvybPhDVqKfv 8YU39faTkmOf/fqBGJbXgabVU4UDagSB9F57/vqOc9bVqqlvoQdjj69JTdorPEN7SWCm fozg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gekStTEbMoVeLgomSTq16sN4MuUSXsSae5CQ1kINjYw=; fh=Lf1a7y/JfSW/8g4XnMrqy9YJYkA0+ApgWUeQFPq8u5Q=; b=lIeuaGZWR1IB4OrfOnX4+St4TAypSzkhAUXN4A8mULXX9ipPhLHEaolNcG9KwQaAr0 CzoEnXwe36oW0CPCnHJgzTghFUERzAPTPYEyCcLpYcTpsF5BrkCE6te1n+V8H7XBrmh2 bejln/ZuETJ0JZrBNX2j/fc8BGASSVFIazMi5QS6JsB5PrtCv5JxoUcDpDZAIFcvoBzj fyoJsIYN5pJEroLN/j3vuFvXn6xH3p5+g3pOrXfUYYUjE+TklM8V+aLr2iyX3okF3dis aiWEn2OenlwPZ+guxdFds0oEsNV+gDRuC3/9qEZLdR0vzioRgVMZWOxv9wTt6zPyLsqo fYFg==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=dd7CaquV; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758638281; x=1759243081; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=gekStTEbMoVeLgomSTq16sN4MuUSXsSae5CQ1kINjYw=; b=mTW2f7XuceVNlR7CO0L2NFeXCSBrjgU4v8pF+ff3TE28cjzcLTnYpuz1sjH21Gaade 6Zsw1EZXeWWeRQZSLQ8ozosCpyTRt+wk1+qD8FF6rTON3a5qlZuL6QxmyWhheWaMX7pd NJfyBQ5Fqsi/tE6UY0WBL+P3wDM87co98lnFc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758638281; x=1759243081; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=gekStTEbMoVeLgomSTq16sN4MuUSXsSae5CQ1kINjYw=; b=muGk39I86aN9FGIspYJPbJdMSe6sthb2rwDOhV+K+U6nctEO9w7lgMTbmxAOXpjw9U VKL0q5Het3qYFEsSjADgyCkOamsOhiSAwbWaWmnvg2ArYgikkBelMkOrgSUPD7D6VkKI /nF+VjWyeRNPaWpQys8aZ7a22B8ouU96gPlF8FQCy37WwF6a60tfVAvd3n0u2kMH2g3O sQEX3zEuO4POZOGi36Ic5S99HK4thW0OH5O6j9TmJ0WWmzEaRZhaufnoCuwN9i0mxr+4 2MGE2LLnDAgT2HoT870DENNUfBCC+fzNiezran3ERUqNLZxoN/Ml/knujua8uJVeQGGH dTdA== X-Forwarded-Encrypted: i=2; AJvYcCWtefBggJ8iVOJvui7iqkHjDjEamm5AdHlkI04kbpm2m/mECB1c8K6X3xJz1W0TGmKhIkD1S8lxyoOiY/zo@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Yxvp1h2b4NCjryIo2SxOiZL7+aBxzFLSp+OYrnyAiVRjkWwYWCL BuQnj2vnRUio92hD/HL9g5rKHfCzs9wvk5vjKarg1322hn0bFoN+27mesoDVPAnOjCNV2A== X-Google-Smtp-Source: AGHT+IHF0dJjCYFXvk8iP0HfkIhcSxUb3EhV5lsHHP3Qucpf8mGViIZy8psPw+gb6SSBJbFjyQz5rQ== X-Received: by 2002:a05:6402:27cb:b0:61e:d2f0:5875 with SMTP id 4fb4d7f45d1cf-63467bfb022mr2324233a12.1.1758638279995; Tue, 23 Sep 2025 07:37:59 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd7HxKvMmPVLnrC5NLKavrKRYhgdOax+U/JQ8noutHTYfA== Received: by 2002:a05:6402:ca5:b0:634:6990:b4ec with SMTP id 4fb4d7f45d1cf-6346990b51dls331061a12.2.-pod-prod-00-eu; Tue, 23 Sep 2025 07:37:57 -0700 (PDT) X-Received: by 2002:a17:907:3d44:b0:b2d:257a:4315 with SMTP id a640c23a62f3a-b301dfc4f58mr253964566b.26.1758638277618; Tue, 23 Sep 2025 07:37:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758638277; cv=none; d=google.com; s=arc-20240605; b=abqqpRKTHTIBJiesCqQMBdwBuoKS9u6cVx2ZIDhQ9THQlT9s3/jDY8BNe0z4pSRLZZ gm0wfAF5HJCghCpAn3xjy75oV3KKIvUI6Oj2BNDFLmxT7hBNhszEb1dReSmga+QS/A0s y90Ezw7I6bkD5HjepgVMs1y6qnub3NL8ZLZk4meefJs3P3AEB/AbrwYxSBAHujcaK1ua WEgv1OUlwNNk53thDmZ0W4xwi2l2JHl1Ll5vo8Qh6kHTquP/DbLO9iOU4CLVJUJB/tW9 XEEMb0zkstvKCjxIzw7uIvtL0beqX7jPtayatHtYQybmeIsEg0VeRDwQ22C1mlJnkpML anyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=BIxVfZFoAEsIwCtiKpIw9ltXsqh5nL/d8yl3mBu/8Nc=; fh=BLUu4vzhSFQ/g+W24ynG+c/M/OQU2SvfvOLguGx/1OY=; b=SNV/CBz284AFrETigkGePeTGpjzH3+ezz9UAEDiPaVPRB9NdpmdpoxklMKxXndBHto FuF46eATj/0TpxwMyGLkJlw1PZfTQeQ246xKVTKQJLaNQVKw+cEOmV8BAwgdbZgVQwo5 ahPqnZDumIIIQhG0Xk0YISJGJsR3issrRQIHY3KQZqG0RfiLCzgEWmjSmoKFas6+BdDm jBxe/c1t7trOSM/10jGbk1zGHt7Z5ZV+ndBn1jfmkSEiQ/GSIUAp0FQAodNKWbcq0yhU wGFZ2F3VSdJqICuylC/JSYnQI15jMvGEF6oheZTLo3v7BMRtmrKa1lAlvMeikh1hbKNm MWZQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=dd7CaquV; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b2b3442a1b0sor297088966b.8.2025.09.23.07.37.57 for (Google Transport Security); Tue, 23 Sep 2025 07:37:57 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGnctN2N/Jn6d9i+Li59t0St1z2RJxz0jSj5OtgvdDM0qudVCzzIrWdZ6qcpo8caZ ZwBmIZr0qnqcAHH5R5K9jBjTbn77QnXUINxMflPQK9y2j4I4W+x4i3w0NSsdakz3TXJ+S/oo/aF iA1Tx1Xy5uGp1B9xUz5YHr95z7fv8C4GuQeN3H7xB4wDDhqymIC3XXLb5Ob5H7L9bfzRul0k+JD 5vXGPNuxRZkyM5YWn/wltU5oLz0ozOpp8Iv/2W2Ir2p0Ogc2pTiSMQuvrhetNeHeOEHCJesuLyu RDkrn7Byf8oDhHtXJ58ITvVwx4GZMG9oFkjcAsewUl8MdxzbkW6ow0nVJOG0858RDlNdu17Im86 wVocDIErqan9BiiV1rnlTwS9AKJaTwRzUhFXv9ArMcBlqeJV5EGZCZMasyFE/zNLlx8KuFTRix0 UInZVgwzJA9brfb/iDXuAEjLPGSnOYOtEMEShpfATdTdzzI1Rscwb/bS/vpFAM22f2M6Q/oH2CV zQ= X-Received: by 2002:a17:907:3d8d:b0:afa:1d2c:bbd1 with SMTP id a640c23a62f3a-b301e5ad661mr314613866b.30.1758638277092; Tue, 23 Sep 2025 07:37:57 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2a2a5f6c7asm665204666b.28.2025.09.23.07.37.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Sep 2025 07:37:56 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Frank Li , Dario Binacchi , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH v6 5/6] ARM: dts: imx6ull-engicam-microgea-bmm: set touchscreen glitch threshold Date: Tue, 23 Sep 2025 16:37:36 +0200 Message-ID: <20250923143746.2857292-6-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> References: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=dd7CaquV; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This way the detected signal is valid only if it lasts longer than 62 µs, otherwise it is not sampled. Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- Changes in v6: - Rename touchscreen-glitch-threshold-ns to debounce-delay-us and update the value. Changes in v5: - Add Reviewed-by tag of Frank Li arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts index 279d46c22cd7..f251a1028355 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dts @@ -154,6 +154,7 @@ &tsc { pinctrl-0 = <&pinctrl_tsc>; measure-delay-time = <0x9ffff>; pre-charge-time = <0xfff>; + debounce-delay-us = <62>; xnur-gpios = <&gpio1 3 GPIO_ACTIVE_LOW>; status = "okay"; }; From patchwork Tue Sep 23 14:37:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4353 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id B58443F145 for ; Tue, 23 Sep 2025 16:38:01 +0200 (CEST) Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-62fc37713d8sf3105991a12.0 for ; Tue, 23 Sep 2025 07:38:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1758638281; cv=pass; d=google.com; s=arc-20240605; b=Zqe3YUjGAqNQT84bFNm0iJs4GgJmG5XMUeN7GnyqBn7HeK4e8cNE31hy5Ejtni95mc X3Jwto0EVK/cK2KrrCxh1y6iokjIw2lIyi5kez9DjIs0PijyRskcqhINOWhXwcIkp/5l QFPCh1I7+rqeQMDEO0RiuIYm0N1YYBwlET15L1lByt3AcG0sGhU462HVKvFYhXsJb+Gs HaiVLTrALhASNx06wJxy/v5hNgK8c7nze0zk+QaHb6oWLC6gXtUBjxDdr1b7qpEcE+Cf fMB8+p6OuKN7svB4IeX7RbIxfBHwcSLwWZyvdnS0xAoIVmOJprsvMS/2XcVoSpp1StYd bt7Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=grTnZqEdkVXS2oPt6FqFPLo+C/A98c59IIPzNcg6dKw=; fh=nomPcRPGcD8lZOogb+d8Fmp9BNj7/ImHa5CI5/HdG6k=; b=P5L+IZEr9TAzG1JEGEYHvmq06FMHi+g4mbZYPsJTbR3bfGhSkUANGDaU22qbXHAZtG dTPbw7g0hgZ72A4rWN4HgBn8h32eDZKed8XmmS6iEQS8x+t5fvyT/EoeUPRhKKNsHRXX 7B72jQl4rxruGC3Ek8BEMMNmgqjhHA86fJvt08gxTzzWLeo8cl/75V0w4KcBIum49Uxh ZbkPHFY8PWPBQtNJyO5p0XMN6Oz9b8KCyfRR0NjSFIgT366atuz6sj0Q5d8KG9bT08HV lsusM9ztJCYeLLtNAuFIYbaacpaof8Gf+t1yBPL40UUhXzoXfZsAUX0yGhxuTS2fmJyN wucw==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="kPaf/4xj"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758638281; x=1759243081; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=grTnZqEdkVXS2oPt6FqFPLo+C/A98c59IIPzNcg6dKw=; b=muQNtsUES8WWBBfKsvAHgeUi1PSU1OrKpMdEZlA8ZWPovZYrUztfs+HGrJ08qVi5gc Bpp4lJ7FqrfXUzO3SYLDOh6sQqJBEvIEtAk3UngfI9Vev5S48YKBV5eCaNZhwe7l+vaf 8H2h5k8Prp9YSj65Z/vViKq1vgjuxt6wI4oV8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758638281; x=1759243081; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=grTnZqEdkVXS2oPt6FqFPLo+C/A98c59IIPzNcg6dKw=; b=YsBzhRIajowndpxZhaAnaIfj8bsuAkua0ci1NIF3kp8uQ8Z2ymY8ihXs0hAcAuD5dC gHbFnKMGXDtWdCJlG+jqKis3AhKF3qVAolsClarzDhwFhsh9iQdMUFxDvcP+Zkg5qM81 7jOUkkrzxMI6qRYETuHt6FcWs5c0qfT8KbdDRNWCGnhSi/toFzAQ77NHdVMSk4SPyPP6 YoWmPQLg9q0sFjwpKKY2L8Scr2Q0WPiCHGyFUJFmaQ4tsDJc9g2rpINaQe4ROtzuzkLi eUSYYjrlF480/cRyLZghkSV2Bzh5IfYOHjQwRjm8TtZkyyOH7SaykdUQhhu3DcsPIXWy hhRw== X-Forwarded-Encrypted: i=2; AJvYcCVLnA030GCc4yfOAE/8aePgvvEXX8eN+IkVgbNWvIiLlm26BaBwfrU3nn2/dW50Sj4TVknv8FuU4mDVHBgR@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YyzjSQi0fKbIqbKx6+HDM205mtA73+hL6vMD1kXtGAu5iNJgQMw XZqPU49iq4xJiUj5cFQCqTF/wNeyQq9bu2ckpHVs9Vf9SGc2B3aPuRn+qo0w22V7NxLjzQ== X-Google-Smtp-Source: AGHT+IFvrGzeo89iqjfCbnNojItOITQHGw0H0xQ8fIKAuHSGztF7qsRRSRLHPF5yOIvQyoie/LFtrw== X-Received: by 2002:a05:6402:1003:b0:62f:386d:aec1 with SMTP id 4fb4d7f45d1cf-634677f71e2mr2356837a12.27.1758638281276; Tue, 23 Sep 2025 07:38:01 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd5v40oaslxDYmtozF+3qzPlsdNETLpQhrSnph84XcIjsw== Received: by 2002:a05:6402:21cb:b0:628:46e0:3cd8 with SMTP id 4fb4d7f45d1cf-62fa734db56ls4808065a12.0.-pod-prod-02-eu; Tue, 23 Sep 2025 07:37:59 -0700 (PDT) X-Received: by 2002:a17:907:60d3:b0:b1d:368e:3ae5 with SMTP id a640c23a62f3a-b3020f1e2a5mr262071566b.0.1758638278838; Tue, 23 Sep 2025 07:37:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758638278; cv=none; d=google.com; s=arc-20240605; b=XUhMAh+ogYc/H8pB0v3yVwJldAIQJMrWNRYDcvc46JQ1QRtwEFIQu0xDGtTBD2VbtQ v7CyEP6GEIPc49f1UL3V7nKv1cepujPDtYvSHKkpKCYLo2KqkH2iPW9gXG7lhphfUOZt FUqQZE2xNZrFZp0ugBE4aeeKPnUMvIyNHtGrcKf6Zg8d/LV5fdU3hjbO9E5aOEvYsmUf vZ01u+Tsbej0O9KXI/tsFTXdiNLXfOZD9MUb5uCwh/LFA/CrgX9OhwkWrcIMuSe7xEj8 m4aUpNrD37hXd3OGSBFOL3TvVgZy2csPvGwj2NgMRtqYpqKPmOvKm0RBgO9VAin/AOC1 NfJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=s1NZM4v8G7kVFRobZkkcSJXgVxob1GWmO5LhOiwNAgs=; fh=07XXofEZG9d+QeVy8dz+2QB2lNQ+zt329x24x7giHEI=; b=YdB6sI9AptiO1P3dCnzqbpZNuv/sLNb7E1UZqgnZt/A6eNozcDHkBGWPUvPFxjYA8b zWt/rhQKm4fCS5IAK3yGv/2pcQtCgJyXcQTpzjwuC02DYzjImmGZzFGWZnWCs+M4Alml Fpv59iTjgE6JnpnKHBVomLabmmDJvd0ecQylkPRNIcz05cngj8mLpSUry91sKlVZepXq zJxzXWxV/BTQJA075f2a5+eyAvGBnYhg5E0delZv6LEWzvfa3y08yrxfkCwKuTmD5WXD Jl8ZTfmpJIAr85t8QsuD5MAmO+Qo5HR1ZavYTbQztlK2f3o0412yQgYJeabqGnL190NI QkRQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="kPaf/4xj"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b27bb5ffce7sor301663266b.11.2025.09.23.07.37.58 for (Google Transport Security); Tue, 23 Sep 2025 07:37:58 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGncsscPZfKGT7QNElkP8RQYuxTC3cBatpqGpGgjK1seCFyeGcxtHjNLI/PctjW7M HW2I5ApG3uZVuxKRHZogZ4X5WICSDlN4L2ZCWqWQufDJW1yQ1PHsijb7A++hypbb9orz7m2pF/I M35SFmT8Bmi7RA29YATKAAZLnfim9KlJc/nESLdKu0jDzh4aWHRVZAFeTRWGkSs5JuBlL/ZoJ1K PKmpSxKzsAX7DXURmA+25vOpZ5SWL3DPFfGWLlf4GCQLWzG8Se6lYgl8V/W1T4WbvRuudL9ubA5 TnNUuDcY3gGzcEORexRSoQFCVpsimAVjQUEJgn+A1bRkmi5oZML6bDM5AVGjtQA8tpf/cbNrPoz ZbNF+5wMeGXdaMYvCkqjdiClhEryUK+nSJyc4YWxVLRhrYriEdXbS1LcNRlV3FY7aXQCTsmiUip NSqhG3gPP9G3WUKQxphdXmwX+jsXiD1HkU28OQ3MugKvKDnvoGCb5JgxMr91yyUEKv X-Received: by 2002:a17:907:7b91:b0:b2c:3967:eb71 with SMTP id a640c23a62f3a-b30268949e6mr298598066b.3.1758638278355; Tue, 23 Sep 2025 07:37:58 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2a2a5f6c7asm665204666b.28.2025.09.23.07.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Sep 2025 07:37:58 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Frank Li , Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v6 6/6] Input: imx6ul_tsc - set glitch threshold by DTS property Date: Tue, 23 Sep 2025 16:37:37 +0200 Message-ID: <20250923143746.2857292-7-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> References: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="kPaf/4xj"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Set the glitch threshold by DTS property and keep the existing default behavior if the 'debounce-delay-us' is not present. Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- Changes in v6: - Rename the deglitch property from touchscreen-glitch-threshold-ns to debounce-delay-us. - Read the DTS debounce-delay-us instead of touchscreen-glitch-threshold-ns. - Udpate the cycles calculation. Changes in v5: - I didn’t remove patches: - 2/6 Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros - 1/6 Input: imx6ul_tsc - fix typo in register name even though they were accepted, to avoid generating conflicts detected by the kernel test robot. - Re-work the commit message - Add Reviewed-by tag of Frank Li Changes in v4: - Adjust property description fsl,imx6ul-tsc.yaml following the suggestions of Conor Dooley and Frank Li. Changes in v3: - Remove the final part of the description that refers to implementation details in fsl,imx6ul-tsc.yaml. Changes in v2: - Replace patch ("dt-bindings: input: touchscreen: fsl,imx6ul-tsc: add fsl,glitch-threshold") with ("dt-bindings: touchscreen: add touchscreen-glitch-threshold-ns property"), making the previous property general by moving it to touchscreen.yaml. - Rework "Input: imx6ul_tsc - set glitch threshold by DTS property" patch to match changes made to the DTS property. - Move "Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros" patch right after the patch fixing the typo. - Rework to match changes made to the DTS property. drivers/input/touchscreen/imx6ul_tsc.c | 25 +++++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index e2c59cc7c82c..85f697de2b7e 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -79,7 +79,7 @@ #define MEASURE_SIG_EN BIT(0) #define VALID_SIG_EN BIT(8) #define DE_GLITCH_MASK GENMASK(30, 29) -#define DE_GLITCH_2 0x02 +#define DE_GLITCH_DEF 0x02 #define START_SENSE BIT(12) #define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 @@ -98,6 +98,7 @@ struct imx6ul_tsc { u32 pre_charge_time; bool average_enable; u32 average_select; + u32 de_glitch; struct completion completion; }; @@ -205,7 +206,7 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) basic_setting |= AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); - debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, DE_GLITCH_2); + debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, tsc->de_glitch); writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); @@ -391,6 +392,7 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) int tsc_irq; int adc_irq; u32 average_samples; + u32 de_glitch; tsc = devm_kzalloc(&pdev->dev, sizeof(*tsc), GFP_KERNEL); if (!tsc) @@ -513,6 +515,25 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) return -EINVAL; } + err = of_property_read_u32(np, "debounce-delay-us", &de_glitch); + if (err) { + tsc->de_glitch = DE_GLITCH_DEF; + } else { + u64 cycles; + unsigned long rate = clk_get_rate(tsc->tsc_clk); + + cycles = DIV64_U64_ROUND_UP((u64)de_glitch * rate, USEC_PER_SEC); + + if (cycles <= 0x3ff) + tsc->de_glitch = 3; + else if (cycles <= 0x7ff) + tsc->de_glitch = 2; + else if (cycles <= 0xfff) + tsc->de_glitch = 1; + else + tsc->de_glitch = 0; + } + err = input_register_device(tsc->input); if (err) { dev_err(&pdev->dev,