From patchwork Tue May 19 10:33:18 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrea Calabrese X-Patchwork-Id: 4636 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 61CE63F144 for ; Tue, 19 May 2026 12:40:35 +0200 (CEST) Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-6831e0c9285sf3515434a12.0 for ; Tue, 19 May 2026 03:40:35 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1779187235; cv=pass; d=google.com; s=arc-20240605; b=IOsfXtFU3FOfXcMStsyx2vFVhN5LK+K43ZMSOj9bUDGjZPj3s2bJAHA6r2NarTZ79e JUtpmp49wZKX3T751yZFgI/kQT9zmEn3hLBR8Nc2bne5ELSTmDxHpxPMRdcQqYfS+ypP jvvmU6o+nhnTi3dvJxvLIsrgcpgPGDFJmoB4kAEftupUqx0ZlHdxUdczVC86BRhPw4b/ XNUeIwZjxiNXyVnfN5jJ6wxf6//CVBYmmXEa8I1CAgiMLHkC/6kqoVTOStpbm/q73cM9 xsEkOn/lqDHu+i3yXyL6rUEk3V3m8CR4mdYCxe/klQl7KdJWhwwAtHVx07D50JSU2Leo tbOQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=pepwMbUYkLnE+3ebSDMD4I/ynNnGdOEUxt/VZlAffCI=; fh=3ri0d5SnMbapKANj3jfKGRLHganVxt/r6PpfuJ/dWVg=; b=ifFEk6myMCWVXLUobdapsEdZApoITUaW2S509hIlvWSYZlARxfWEKVVQanOa1tVkUo RjyyRIS0EIR40sI1WUbzTXUalkC5lR+KX6xPyxsvbMHUCdE2KFLtSJf89GvQvnyaL/Ar lk+CN1B8MpQgx5DXI2qG9b04LQOlN8XBSHBV7meHxh7RaeUzb0SvwJeuQLzxmMDO3RG+ baRVfO9ByW5uQPKxaXF2dnojr2/thNJXs6D5gk5PFJc1saOc8eFxnM9GEbNDDL8Gs4JX peddoOo6lWW+Mz+tgtFrkODJIDq7+1bnVjfGru9P0py3qNTBi4EKxsfqOpAKFgv8AeFI lk6Q==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=iJIBnrEx; spf=pass (google.com: domain of andrea.calabrese@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=andrea.calabrese@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1779187235; x=1779792035; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :from:to:cc:subject:date:message-id:reply-to; bh=pepwMbUYkLnE+3ebSDMD4I/ynNnGdOEUxt/VZlAffCI=; b=VwPHJ8ytx397uECVl2ZYbprmNou0GplZrv1qhqsDLxNx1Rw6wHIJW6meRN/gJvyzy6 2CHgH9c07k4fIMgcr4ek4k7Gv+amo5XllemR6jMG07kngSBnQSQCxFvvSCdQ/+/CrsMN ByJkziVyM+Qfw6FWma1LXsDdMWc03rD6fjI1Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779187235; x=1779792035; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-gm-gg:x-beenthere :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pepwMbUYkLnE+3ebSDMD4I/ynNnGdOEUxt/VZlAffCI=; b=Gk10xVqQoI2sS85U4aCHSpCQA+T2/xfILXkRNhs600rjk0nzgI1w0Rld6Nk1Zf+Fnf AXwfioeOgWLZKVyBZrzmWLabFsgNrr1uc2OQ0JNsJ5uY46WkHU6BMy5QiP4j9FWl8prc MH1KI/or5unxA8RLbtLeeeGGJD1Ka3Uqwz7Fwv0Wr3rOIhScH4VMOE8gcCjWhrYtBzpp Kmk26P5McUJVjWMMVOY2tAzh9PcD+W2feJYIF1lp2oYUjHPcXSyBhNKCI9lFrrDPdqgT QYjTCwIc5tXFoG3UkH2Uirme19IJbJ+XkqUSIWca6jrxhto1rvfFEiboMYae5l2cOlUP tIEQ== X-Forwarded-Encrypted: i=2; AFNElJ9llH06oLcNpzcmmMbl+OVfl4l+CKf+kv+YIOA4LxTVzg9nWFDv8NQ5RTIKGOrTQzmvS5vyaPrEpWqRu+zs@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YxInKCDTNf6xydZ4aPe07P9S9bbIlCBgM7vOBPYZuJI7iD7dHpF YTZD2IqJ9XUN5191XogTOrFGvQjtS0Bm4yVhtI/g35eSlFUf1uKbuAbIu9fj48JIQxX0CA== X-Received: by 2002:a05:6402:3583:b0:66f:2ea5:c269 with SMTP id 4fb4d7f45d1cf-683bcd9e4ddmr9912967a12.15.1779187234774; Tue, 19 May 2026 03:40:34 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h="AUV6zMPXJuyL4KvweZNKPAabIGqsW26sMtoY/QHIs+hxcJvALA==" Received: by 2002:a05:6402:5164:b0:683:8dc7:b93b with SMTP id 4fb4d7f45d1cf-6838dc7c10els5132899a12.0.-pod-prod-04-eu; Tue, 19 May 2026 03:40:33 -0700 (PDT) X-Received: by 2002:a17:907:70e:b0:bd8:5f38:beba with SMTP id a640c23a62f3a-bd85f38c732mr423916766b.45.1779187232964; Tue, 19 May 2026 03:40:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1779187232; cv=none; d=google.com; s=arc-20240605; b=WycRBwDZ3F1+W36e83hY4zueiEx6sC12A0LU4so2cBdK35V/BTsVrNPzs0eoLqwsWc eREfi9sZuE9QYTysqZifwaeD1lsiP0yK5jm//Ea7P+Qxcqck/tvilvoOTdPKX6bvxXqc wCGn2bwpFlZHW7l4mCXhWa5RRLPpJ6nHyM/dRTnzCztR8THoGEBzms8ShdJkFk5tKjwf zCqFSX1VkF1t5KOPFDxpeOwRYJPq5sj6QDHQHJmL46u35z4LeFIN7eW+7Vu//AubEJ5E olgQA1PldE5xkh34UmbiUXeRDrY80/VFgIEdipDPR4+Xd975+qZug0Rc1T1EB8r2Six1 OMIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=WEnY7ffzvIWGaANM2dU5Ty/yFE2of6zlzER9jhDIQeI=; fh=ykbBea1XW+IrdZde7E1qYXSEqdV7CGzzp6xgL7zWkEI=; b=QbAtIlGxejsnkI93McUXq+46xR6LbQphjpcAjZ1UKecKOoOlVTlCdwcxKmGoKx9BrU 9Rjd4n1IZiBBU0Qbzjv2MGCNesGgDRy20HVbClMuhF1G7xakBgvXy9pQrXCJ+xwWh7hm bfWyb0Pyt4CMAW2YvMVq5X9kBRT0lp9cIFXtNBz2usKhtpjZ+EbrfuQ22P1CDcgTu8iA FUfbUNchhrMXJDtnvkmVb3Gngm7+aXgqIDyaWjwXwSTRXTqUYznt8n5vdCdI1eiJ2qai hnIsQsI/G9NizYLTRgTw/h8ozYe75e4HKHy5H2kStGQb+XjFTkVsy/QK89Emmjb1Li1p nlug==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=iJIBnrEx; spf=pass (google.com: domain of andrea.calabrese@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=andrea.calabrese@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-bd714e381desor152660266b.17.2026.05.19.03.40.32 for (Google Transport Security); Tue, 19 May 2026 03:40:32 -0700 (PDT) Received-SPF: pass (google.com: domain of andrea.calabrese@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: Acq92OFEy6W2aLiV4uXJ5DnkxbZ/RHpLogtY8pwukY1neUyge+/OOqziqt94L62FgFc qc3bolMopJQoGuOKfUBXhAY9Sk8GIOIF4A8UnzFGBNqN+Yp/Ta0YeFy7mQgg2HKRazlW4nTYLwX EKYEfBmLWlZ9KEVv7OieHoCvhpV+i29NvVasz78dCDTL6Fv7qJIltYLXrtAloMBKU5pKzKS4swT 6ZEp/+6y5urGzJN7jTv57bNtcpd8K5s/uTpRRNOjnjkJN32bUfd+GNVDWUtsZvVzo8m17mZYn9a wgWWd4Av8oxqN1MwKXgls0naSfjbjJD3GM4Euh4z1lBi5ttg/0kzrklPo+lE4rm4MKzC72ljb1M TcD10P1hMvYCbhPrLkOizoTSyY6d2sXOhB8PpL6oImwlUTRyMkt9DHVe+TYTCFF5K8bb6SBOkjZ gKvqqlmzXIKko8wmN32vY2jDYgzUBJhwbGJ/DFHoE6J65QWRdpQ084n1ehJA6eycWySLTQSCasj Ra6St1jf12LtliWCQUWsl/moKQXBuIERbQvOJkKpPS7LTk= X-Received: by 2002:a17:907:ea8:b0:bd0:4f6e:9b2f with SMTP id a640c23a62f3a-bd51780c078mr1087512466b.1.1779187232495; Tue, 19 May 2026 03:40:32 -0700 (PDT) Received: from fedora.tail032493.ts.net (98-215-98-95.ftth.glasoperator.nl. [95.98.215.98]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bd4f4c31404sm691431166b.25.2026.05.19.03.40.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 03:40:31 -0700 (PDT) From: Andrea Calabrese To: brauner@kernel.org, oleg@redhat.com, akpm@linux-foundation.org, peterz@infradead.org, tglx@kernel.org, kexinsun@smail.nju.edu.cn, adrianhuang0701@gmail.com, elver@google.com, linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Andrea Calabrese Subject: [PATCH] kernel: refactor: shorten has_pending_signals Date: Tue, 19 May 2026 12:33:18 +0200 Message-ID: <20260519103316.122139-3-andrea.calabrese@amarulasolutions.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 X-Original-Sender: andrea.calabrese@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=iJIBnrEx; spf=pass (google.com: domain of andrea.calabrese@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=andrea.calabrese@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , In has_pending_signals there was a switch/case pattern that did not need to be there, as the default for loop also covers those cases. put i inside the for declaration so we do not risk its escape from the scope. Moreover, i starts now from 0 and counts up, as it is a more usual pattern. Signed-off-by: Andrea Calabrese --- This patch does not change the binary output of the file kernel/signal.o. A diff between the files gives shows (old -> new): 2072c2072 < case 1: ready = signal->sig[0] &~ blocked->sig[0]; --- > ready |= signal->sig[i] & ~blocked->sig[i]; 2149c2149 < case 1: ready = signal->sig[0] &~ blocked->sig[0]; --- > ready |= signal->sig[i] & ~blocked->sig[i]; 2155c2155 < case 1: ready = signal->sig[0] &~ blocked->sig[0]; --- > ready |= signal->sig[i] & ~blocked->sig[i]; 9799c9799 < case 1: ready = signal->sig[0] &~ blocked->sig[0]; --- > ready |= signal->sig[i] & ~blocked->sig[i]; 9805c9805 < case 1: ready = signal->sig[0] &~ blocked->sig[0]; --- > ready |= signal->sig[i] & ~blocked->sig[i]; kernel/signal.c | 26 ++++---------------------- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/kernel/signal.c b/kernel/signal.c index 2d102e025883..799ee98cf03e 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -130,28 +130,10 @@ static bool sig_ignored(struct task_struct *t, int sig, bool force) */ static inline bool has_pending_signals(sigset_t *signal, sigset_t *blocked) { - unsigned long ready; - long i; - - switch (_NSIG_WORDS) { - default: - for (i = _NSIG_WORDS, ready = 0; --i >= 0 ;) - ready |= signal->sig[i] &~ blocked->sig[i]; - break; - - case 4: ready = signal->sig[3] &~ blocked->sig[3]; - ready |= signal->sig[2] &~ blocked->sig[2]; - ready |= signal->sig[1] &~ blocked->sig[1]; - ready |= signal->sig[0] &~ blocked->sig[0]; - break; - - case 2: ready = signal->sig[1] &~ blocked->sig[1]; - ready |= signal->sig[0] &~ blocked->sig[0]; - break; - - case 1: ready = signal->sig[0] &~ blocked->sig[0]; - } - return ready != 0; + unsigned long ready = 0; + for (long i = 0; i < _NSIG_WORDS; i++) + ready |= signal->sig[i] & ~blocked->sig[i]; + return ready != 0; } #define PENDING(p,b) has_pending_signals(&(p)->signal, (b))