From patchwork Mon Aug 31 15:27:01 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4825 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id BAB0C3F262 for ; Mon, 31 Aug 2026 17:48:15 +0200 (CEST) Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-495474a5fbcsf30435145e9.1 for ; Mon, 31 Aug 2026 08:48:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1788191295; cv=pass; d=google.com; s=arc-20260327; b=BISS6kppJvQInLUjOJvAvEp2sq4mT9mkxKv8gdV0tThgFQFsF9BnusA1VrkFREkFbr YJV3wimM24UEOWDFz9d2Fuo/cKph+hW/Bt67QxPJHGKmuRBko81TC7kvTi2DttBdtJP/ bBwVvfVf/902pW7oWqHK9RVG1EEw8oT/Ef801KUy7Tk2ze6kxHCwTBDroW3KAEs7eUNy mZ9vfAV6hUpfx2d1GPoz/YeNQrZtvrzjq4iBpHDN4l1xDzcnlxNU1hWZoAfobU3yjJEH 7KnLuEFIM4t6ZLSdbEcSlhxh1Y81t+6yZkBByb6es23jAZud78tD1hxeWKVs3N1C+DGP 58kg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=CgoEqabf+zn78yixWkFiq7GtDWy4DCyz7SG7+DK3k1k=; fh=zWrAc/NpvNz3gmxPgDqIpgvWNBzZng6wfC2O+qj4b4Y=; b=GFOnM9Xpyqo1VGYCkTJKB8lbN5lFJUzDasHQIG0iiXKdkZ0K+d93BwUjJnRty8Yw0S ClDLsWiN+C/huPlwAUbyjdhVNmb1DpQKV9Cwce5zmAR7M0V+BaHStyMSH53JWXj+/7tk e4UAhnFRXLO+KBgXzph8ss2QUiZ17IVTCOMsHRuYDM6IOZe6ILjkXC2FBIIzvh0BdIOe RLWF3m4DIVjMhO7FZWF1g35ZycCwdiUFrIb8pHGu772Jfilv70Jnit2B7FxQDPkcbLta UTDUkdUejVBv7FXZq5hxGIfEMESUiMSfstxH7Rg+KDdEGAEdpVQrkEbgH9dZzEy9UrM4 BMGQ==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=b7sJaDq6; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1788191295; x=1788796095; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:content-type :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=CgoEqabf+zn78yixWkFiq7GtDWy4DCyz7SG7+DK3k1k=; b=nfaUZJGhx9qcKBu8Mpwiu2r7wAAf+MmioPmXKv5igStw0ieSPqYpjQponBy/TPAb4G XnhHsVj1uzCN5S6EU0OJN+SEQixNLsTq67KTWQ9p6mq/M60f9O6f5rWM9BvkyTLFG0Hm GQ62eRhjt71+wB7K8eZM8HaVeoGv/4M99e2pA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788191295; x=1788796095; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :content-type:x-original-authentication-results:x-original-sender :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-gg:x-beenthere:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CgoEqabf+zn78yixWkFiq7GtDWy4DCyz7SG7+DK3k1k=; b=f3mNeZvrz7R7iG8IPoen47tOYzc/nbiP6XHH94BmsiVZIanJvXRPSqzYwbqMwB5dTD NydP3Qft4qBoj+i4CWBETxO/RFKajYDgLGTRcIlSBDCsVmH+t9gaFHu16ktw7iGFAzBp Cd7ojRLw/VpQguOHBm7X5wZGugmcdVNjXoiIC7kGRpFd67z5orGem8zlztq6l2pO3Edj e4YJ2uxRvIDy++28nGWnKfRtwXDDTlzbZJrYteqKQHbAAk2tpkomTo9mola8JaEpOqVv wFJucUs8XU6ZwxcWZMAScke5hfh+kygJrZ1aKmSMjlcKu/zrwOFJQHA0Fl0OSnQaVt5F EaCw== X-Forwarded-Encrypted: i=2; AHgh+Rpi1fom4yz593St/2Csv36hc4zVDGZVfnguOOI1SY1oJqIaAYYAIdPZJuP2EifGqZsU7xd2Hm1FZNCbmC3M@patchwork.amarulasolutions.com X-Gm-Message-State: AFuF++lyiIT56mD6VSnEeOooJOms0be7c6K7JRvMoUfZQ8UuFH8MxVid g6ahfiHMUqGOzjA+vwKmmcl7oJsM0ZeZvi2JNvVHEXoOY2/XV6OGv0XEwgG7pHyPV7yveQ== X-Received: by 2002:a05:600c:4704:b0:493:cefc:d113 with SMTP id 5b1f17b1804b1-49b91c2d8femr411016605e9.5.1788191295329; Mon, 31 Aug 2026 08:48:15 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h="ATskLdeCxWoEhxQsjzK3aWPkXodbgBds2APKDUxT4AZJStHyPA==" Received: by 2002:a05:600c:3b9c:b0:495:5919:e704 with SMTP id 5b1f17b1804b1-49b1cd8e90cls43654305e9.0.-pod-prod-07-eu; Mon, 31 Aug 2026 08:48:14 -0700 (PDT) X-Received: by 2002:a05:600c:354b:b0:495:4d88:e630 with SMTP id 5b1f17b1804b1-49b91c4fb4amr398253135e9.10.1788191293732; Mon, 31 Aug 2026 08:48:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1788191293; cv=none; d=google.com; s=arc-20260327; b=kTz7Nk0FPzE3PdkdSii+LcpPsG1FJG//wYf87f+1Uu531BV8fclrdXtshpId+80i0f LFqf9pxYRY0lsndTUYGghiBlE3XhZXtATq+62K8p3o2oCSdYmeL2+wbkp/LrQvIlrDWI wGnkYIpdNcisKdHvY3Vki/iP7qh2OZawnFkquA2jLGFInGc/I/RaKhGw99xlTolvlWwv PUNdCFvuEoU/5rwM1xFAPWT++rGb6zsfxnjK+s50DS8Wxa+nEdwjco8KYxpeKjUgE8dF D1GvEsOfVisUAgzFXS9gN6Dyrhnfbt1/dvVvJDm75DdWTFDVnnMA0Qdb3ts/XSToWUiK OFEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=N/h+0+I7fXQ52AgonO29/UsUwGiBzhMLYBL0Aiheh2c=; fh=zuTFvgUbDA4p+duRUtqF1kHsKgia+Oibpqem6QzXfB0=; b=h/19ya/5BX5XxuoPEpfph2YE0fjWkHKLGCFL+/rDVH1MpA6oosm4i6Enct/UYUP4Lo dzMo4fira3FyDcSkV6s6daKhgpLZlTFBuGq23msW4GsvuYW7iSIjW17V3cTbvLqlOp9K q49QbxrpAUpQ53W28mPr5Mh5dUbkuMO4AlaXTlpVZ8diR/2zwKVkpk69UPAbDo1EHB3d /vFeuHSodEYViwkT1myvlXgeAV0HlJBwgfcHrQAUiJMjRdXH2vStFQ6YiujQ9qKuJ4F+ 2397C6WqcePewbl1zz4MJ5kXNih4AzUzBbiW1QB7LxqQfoR3LtZ0oPDitYYBRA5wm3ap LB2g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=b7sJaDq6; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 5b1f17b1804b1-49b95056b8csor13461495e9.5.2026.08.31.08.48.13 for (Google Transport Security); Mon, 31 Aug 2026 08:48:13 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: AR+sD11R73rq8/osiQXSdJEsxj3B9FF8TxGZCl+bWYskJL4GknujBhbSswCmWuerSYs /fUCcZAdyrJK9VmbWh2llkGTCU9q+g2elY9X5D3QGxDNn0k++YVcmf7kRB3hzas8y/bhkESOAGC kCPOom8Dg3JYKev3RsqN7Bu+QDEIubXo+H7pb1WZRqzLyuNwSkkXZYvg6+pTX2PU72qf4+XMGMa lJFsiXvwK3tpVJaujjpJTidq/YBT/zn+aLjP0NghUg030U5KiSda5+ysK8/zd9+auw/TwD2Ln2j 2dnHO1tiH1HSDnwnfonvITN92H5MzDfn7bk0I72gPQHUd/Xp0hvdpvp45VLmHk9VxV/K8R17FoD IVRA1wKSE60pqnl/SpZOLu5IYN1Nmzt6V+d0zq0viTk0mguEDsg7RSyHtgdwfeD7pl9eAKCt+ha ks4QhWOxzznR2b6tdBS5kZxaKBcKwSRf+496tqMGBewvIfBZ0qglGMY2BMu9mtnk2AIUJTF7AIR VGA9ZTRRj2bczEfOzPjZErfJDzcJyDjXr2YPgcyZH65dxZ0ICmYl6Mh9+aQg16qZeV3N2wNb+6G KDsW8EM9DDhyx5FHEFwY2Q9vZFdoW56kNQZZDZHtHc0kVhxbjU9OhIp7E6DN X-Received: by 2002:a05:600c:4e01:b0:49c:cedc:768a with SMTP id 5b1f17b1804b1-49ccedc76a1mr324658675e9.16.1788191293295; Mon, 31 Aug 2026 08:48:13 -0700 (PDT) Received: from dario-ThinkPad-P14s-Gen-5.homenet.telecomitalia.it (host-87-9-102-148.retail.telecomitalia.it. [87.9.102.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49b9269f1b6sm220191845e9.4.2026.08.31.08.48.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Aug 2026 08:48:11 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Abel Vesa , Brian Masney , Fabio Estevam , Frank Li , Jerome Brunet , Peng Fan , Pengutronix Kernel Team , Sascha Hauer , Stephen Boyd , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: [PATCH v10 1/1] clk: imx: pll14xx: support spread spectrum clock generation Date: Mon, 31 Aug 2026 17:27:01 +0200 Message-ID: <20260831154752.15401-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260831154752.15401-1-dario.binacchi@amarulasolutions.com> References: <20260831154752.15401-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=b7sJaDq6; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Add support for spread spectrum clock (SSC) generation to the pll14xx driver. Tested on the video PLL of i.MX8MN and i.MX8MP based boards. Signed-off-by: Dario Binacchi --- Changes in v10: - Drop 'Reviewed-by' tag of Peng Fan. - Adapt the driver to the new infrastructure. Implement the set_spread_spectrum() and get the modulation parameters from struct clk_spread_spectrum. Changes in v9: - Add 'Reviewed-by' tag of Peng Fan. drivers/clk/imx/clk-pll14xx.c | 58 +++++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.c index b6f1cc9f5700..27a637847f57 100644 --- a/drivers/clk/imx/clk-pll14xx.c +++ b/drivers/clk/imx/clk-pll14xx.c @@ -5,6 +5,7 @@ #define pr_fmt(fmt) "pll14xx: " fmt +#include #include #include #include @@ -22,6 +23,8 @@ #define GNRL_CTL 0x0 #define DIV_CTL0 0x4 #define DIV_CTL1 0x8 +#define SSCG_CTRL 0xc + #define LOCK_STATUS BIT(31) #define LOCK_SEL_MASK BIT(29) #define CLKE_MASK BIT(11) @@ -33,6 +36,13 @@ #define KDIV_MASK GENMASK(15, 0) #define KDIV_MIN SHRT_MIN #define KDIV_MAX SHRT_MAX +#define SSCG_ENABLE BIT(31) +#define MFREQ_CTL_MASK GENMASK(19, 12) +#define MRAT_CTL_MASK GENMASK(9, 4) +#define SEL_PF_DOWN_SPREAD 0 +#define SEL_PF_UP_SPREAD 1 +#define SEL_PF_CENTER_SPREAD 2 +#define SEL_PF_MASK GENMASK(1, 0) #define LOCK_TIMEOUT_US 10000 @@ -44,6 +54,7 @@ struct clk_pll14xx { int rate_count; s16 delta_k; spinlock_t lock; + struct clk_spread_spectrum ss_conf; }; #define to_clk_pll14xx(_hw) container_of(_hw, struct clk_pll14xx, hw) @@ -366,6 +377,37 @@ static int clk_pll1416x_set_rate(struct clk_hw *hw, unsigned long drate, return 0; } +static void __clk_pll1443x_set_spread_spectrum(struct clk_hw *hw, + unsigned long parent_rate, + unsigned int pdiv, + unsigned int mdiv) +{ + struct clk_pll14xx *pll = to_clk_pll14xx(hw); + struct clk_spread_spectrum *conf = &pll->ss_conf; + u32 sscg_ctrl, mfr, mrr, sel_pf; + + if (conf->method == CLK_SSC_CENTER_SPREAD) + sel_pf = SEL_PF_CENTER_SPREAD; + else if (conf->method == CLK_SSC_UP_SPREAD) + sel_pf = SEL_PF_UP_SPREAD; + else if (conf->method == CLK_SSC_DOWN_SPREAD) + sel_pf = SEL_PF_DOWN_SPREAD; + else + return; + + sscg_ctrl = readl_relaxed(pll->base + SSCG_CTRL); + sscg_ctrl &= ~(SSCG_ENABLE | MFREQ_CTL_MASK | MRAT_CTL_MASK | SEL_PF_MASK); + + mfr = parent_rate / (conf->modfreq_hz * pdiv * BIT(5)); + mrr = (conf->spread_bp * mdiv * BIT(6)) / (10000 * mfr); + + sscg_ctrl |= SSCG_ENABLE | FIELD_PREP(MFREQ_CTL_MASK, mfr) | + FIELD_PREP(MRAT_CTL_MASK, mrr) | + FIELD_PREP(SEL_PF_MASK, sel_pf); + + writel_relaxed(sscg_ctrl, pll->base + SSCG_CTRL); +} + static int clk_pll1443x_set_rate(struct clk_hw *hw, unsigned long drate, unsigned long prate) { @@ -390,6 +432,9 @@ static int clk_pll1443x_set_rate(struct clk_hw *hw, unsigned long drate, writel_relaxed(FIELD_PREP(KDIV_MASK, rate.kdiv), pll->base + DIV_CTL1); + __clk_pll1443x_set_spread_spectrum(hw, prate, rate.pdiv, + rate.mdiv); + spin_unlock_irqrestore(&pll->lock, flags); return 0; @@ -411,6 +456,8 @@ static int clk_pll1443x_set_rate(struct clk_hw *hw, unsigned long drate, writel_relaxed(FIELD_PREP(KDIV_MASK, rate.kdiv), pll->base + DIV_CTL1); + __clk_pll1443x_set_spread_spectrum(hw, prate, rate.pdiv, rate.mdiv); + spin_unlock_irqrestore(&pll->lock, flags); /* @@ -437,6 +484,16 @@ static int clk_pll1443x_set_rate(struct clk_hw *hw, unsigned long drate, return 0; } +static int clk_pll1443x_set_spread_spectrum(struct clk_hw *hw, + const struct clk_spread_spectrum *ss_conf) +{ + struct clk_pll14xx *pll = to_clk_pll14xx(hw); + + memcpy(&pll->ss_conf, ss_conf, sizeof(pll->ss_conf)); + + return 0; +} + static int clk_pll14xx_prepare(struct clk_hw *hw) { struct clk_pll14xx *pll = to_clk_pll14xx(hw); @@ -509,6 +566,7 @@ static const struct clk_ops clk_pll1443x_ops = { .recalc_rate = clk_pll14xx_recalc_rate, .determine_rate = clk_pll1443x_determine_rate, .set_rate = clk_pll1443x_set_rate, + .set_spread_spectrum = clk_pll1443x_set_spread_spectrum, }; struct clk_hw *imx_dev_clk_hw_pll14xx(struct device *dev, const char *name,