From patchwork Fri Jul 17 08:03:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suniel Mahesh X-Patchwork-Id: 1507 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id AD5553F086 for ; Fri, 17 Jul 2020 10:04:10 +0200 (CEST) Received: by mail-pf1-f198.google.com with SMTP id y73sf6349659pfb.8 for ; Fri, 17 Jul 2020 01:04:10 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1594973048; cv=pass; d=google.com; s=arc-20160816; b=xHR8YvC3Bgt9yN9epxsO3bNy+zHRDRkLHm7CTrBdpHLar0N9fu6sPXF6uEYuG0npAw xlF3+JG4sE8Yo+l5QnpkLNMAClpq9cRnTI7L43fQezi+3renNsL2pIW90acJuXB9ko4X iaRi6aBjlWpIlmAHi7GYleYg2FQgw6sqLda8oO1tfHlvU/ct29XcIVbZwlH+e2KZRtgB 3MlPWIKwRISahNRfCusx7Ln+jWR4ikt5oLEJkKQMsm7a/NpRwWgCIe5fHBwwTroXYaRx akehNWsq4jTccYovwmb8OAEkxQPDxSXl/BFm3luGB3Boka+TpmPvVGL9vzNY6RhCEHNv 7Nyw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:references:in-reply-to:message-id:date :subject:cc:to:from:mime-version:dkim-signature; bh=BVU0Ss+rpRvKHPe3YhaJVRCma+qXqB1wRh6VhgnrXG8=; b=Y2K5gRTLyYM9iCTTavoYLTqBuJ0AamtbJZE5tVFgruN2xANWYYJKQbV+p5TQFRDqPT 4CuLRImxzlT5oHw4BGyKaejjByWaktIZ5uasKOaX02nKjQbMk9GtTQaJYA1+qldCHacP 7L3VBxMxK7GmBU0zOASVeURNHW2voMPHE7frp3fXJkhqRn1ltT8EdYHJcbNDsSbk449S /7NT7b0G+0SFuihxOj0j35tuxwxQFTRvRWEDu4uTnkYE4ADom2Aoo/IyBmF3Stz8Rnw6 AcRcZDZ92eR6ybfiXym8pJwhQdTcl8BEG38vKAe2gc1+W04a/24eY2FB2E8lzt3CLj+W eb5A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=C6S1AvtT; spf=pass (google.com: domain of sunil@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=sunil@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:from:to:cc:subject:date:message-id:in-reply-to :references:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=BVU0Ss+rpRvKHPe3YhaJVRCma+qXqB1wRh6VhgnrXG8=; b=RC3Ymev+xc8AVNQyRm1OwTbZ30TYBXIifakrJfkShjNFoZKKUYkRt2eFQx+A3tWwVw ceYW6B8h5iV5os0T1vwmxMyGQ9lMQ1HnZm/j9DgIclEV0YXLR5Oy2kau74A4KjtJ0k9k znbJLdRBp2FoOi/WAftnSrP8bMaof0x6fa+Vg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:to:cc:subject:date:message-id :in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=BVU0Ss+rpRvKHPe3YhaJVRCma+qXqB1wRh6VhgnrXG8=; b=hRBD+VhQ1KwujkhkOzlGrLk168nCnxZPoR0q1olY6cI4wVYxsOw3DMR3CMpzCA13Zt RVUJro3YjG4YNwxr3bqSB15851qTmcTHkd+V2uksyFGJry7wfRe2ZXI751N21yso3pnP VTf1tDoJmSYzNei9XeS4YIhIokZi6sM2Te0Uof1LNuR7Chr/ZuRiXlt7Op5IRkwOH6Sf M+l+I1xAkgPIFs9OjTyqB7V8nPnzR9a/eYuawbrt2fh5yxNguXb61ewhUn71KcOZcGvh 2zv72Lbsim9avYfiSp3lBzcgeFxssIrhoWJeuIcAHXp4TsVTG07ydbG78fbg2TpHiLGX eTFA== X-Gm-Message-State: AOAM532Oqh6C9RRIFvsKOHWi61Y+AGaheLSBXK1olW8o2W2l02S7JelC q7XUCCrhJVohYW+ayiBPPFfvqKVz X-Google-Smtp-Source: ABdhPJwdyZksoVdHWj+vdBkBUKs/Rs1q33GJLvLNbxOMT2n5oU+S174T3jlsuS/QtGz8/7+OPiS9Zg== X-Received: by 2002:a17:902:c402:: with SMTP id k2mr6452191plk.185.1594973048354; Fri, 17 Jul 2020 01:04:08 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:90a:4b04:: with SMTP id g4ls369858pjh.3.gmail; Fri, 17 Jul 2020 01:04:08 -0700 (PDT) X-Received: by 2002:a17:90a:2427:: with SMTP id h36mr8573706pje.229.1594973047452; Fri, 17 Jul 2020 01:04:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594973047; cv=none; d=google.com; s=arc-20160816; b=Fid77P9u2biDhQ99ImLUjkrUBBXqbyMEzWChBko2GwhG3+Xu1GLsU6WCpXcz6BWpb9 kFWSo+7+8wiI1Nktsb00D9epqn/IjTmxevERPJErCFmtWaX7525+hIxA9D52kS5Axn/S bfgsUx0cgMsT0N5T+99tx5vSb3YgK1IpjQAEdnqPpkI5xmPiDu6hcBstRP0eBOxEFXtk 4FnlGDwNwlMrPh8jh4eoWOrOKomrgIZO9uJr7pt+9LwQ2q6EVgG9LYEucMWVUIhB2aTN nOKDBSF5VD+ChWwwGJR1t+lJmqUkd87fhk60fRVSOA8z0Qq5DejyrNfXSFbKi+Q15Iyx fDHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KEvi0NuPU1IP8yO4PAQchnjzLd/x6LQsk0i3r7vHyn8=; b=hGtuTswxf3XXspWiO06rxT5eAY47bMuGYJiQZ5DzJuztkOGNwA81Se+QEDpWyav5sL X0K2lDEDJDxseQRoJAqMrHtQAsFXAs1G81gelKBxqKJBBBbK/BcLqGPIRE39DJVjpDWk ytmPmynpCaKdZ5mC2+HTJqqR33oZFH6o1S7Af89kVqMaWZek4kF7Rs+fubJ/4WeHZiwp WX5N8Q1tLFXplpwz//xmjXqCFRH/v27W71y+aVoPEaMSDDRO8+WZhzvfdYj5Q2HdLBmu 19feile91PEm7NMw2cJzx33AquncNrImbg46FJp9S/LasjsMc5WBavC9fw/t/63aIykY EVtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=C6S1AvtT; spf=pass (google.com: domain of sunil@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=sunil@amarulasolutions.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id g1sor9873125plg.14.2020.07.17.01.04.06 for (Google Transport Security); Fri, 17 Jul 2020 01:04:06 -0700 (PDT) Received-SPF: pass (google.com: domain of sunil@amarulasolutions.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; X-Received: by 2002:a17:902:6b08:: with SMTP id o8mr6813081plk.104.1594973046370; Fri, 17 Jul 2020 01:04:06 -0700 (PDT) Received: from localhost.localdomain ([183.83.226.37]) by smtp.gmail.com with ESMTPSA id y7sm1933330pjp.47.2020.07.17.01.04.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Jul 2020 01:04:05 -0700 (PDT) From: Suniel Mahesh To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, gregkh@linuxfoundation.org, sashal@kernel.org Cc: jagan@amarulasolutions.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com, Michael Trimarchi , stable@vger.kernel.org Subject: [PATCH v3] ARM: dts: imx6qdl-icore: Fix OTG_ID pin and sdcard detect Date: Fri, 17 Jul 2020 13:33:52 +0530 Message-Id: <1594973032-29671-1-git-send-email-sunil@amarulasolutions.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <20200711135925.GG21277@dragon> References: <20200711135925.GG21277@dragon> X-Original-Sender: sunil@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=C6S1AvtT; spf=pass (google.com: domain of sunil@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=sunil@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Michael Trimarchi The current pin muxing scheme muxes GPIO_1 pad for USB_OTG_ID because of which when card is inserted, usb otg is enumerated and the card is never detected. [ 64.492645] cfg80211: failed to load regulatory.db [ 64.492657] imx-sdma 20ec000.sdma: external firmware not found, using ROM firmware [ 76.343711] ci_hdrc ci_hdrc.0: EHCI Host Controller [ 76.349742] ci_hdrc ci_hdrc.0: new USB bus registered, assigned bus number 2 [ 76.388862] ci_hdrc ci_hdrc.0: USB 2.0 started, EHCI 1.00 [ 76.396650] usb usb2: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 5.08 [ 76.405412] usb usb2: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 76.412763] usb usb2: Product: EHCI Host Controller [ 76.417666] usb usb2: Manufacturer: Linux 5.8.0-rc1-next-20200618 ehci_hcd [ 76.424623] usb usb2: SerialNumber: ci_hdrc.0 [ 76.431755] hub 2-0:1.0: USB hub found [ 76.435862] hub 2-0:1.0: 1 port detected The TRM mentions GPIO_1 pad should be muxed/assigned for card detect and ENET_RX_ER pad for USB_OTG_ID for proper operation. This patch fixes pin muxing as per TRM and is tested on a i.Core 1.5 MX6 DL SOM. [ 22.449165] mmc0: host does not support reading read-only switch, assuming write-enable [ 22.459992] mmc0: new high speed SDHC card at address 0001 [ 22.469725] mmcblk0: mmc0:0001 EB1QT 29.8 GiB [ 22.478856] mmcblk0: p1 p2 Fixes: 6df11287f7c9 ("ARM: dts: imx6q: Add Engicam i.CoreM6 Quad/Dual initial support") Cc: stable@vger.kernel.org Signed-off-by: Michael Trimarchi Signed-off-by: Suniel Mahesh --- Changes for v3: - Changed subject of the patch, added fixes tag and copied stable kernel as suggested by Shawn Guo. Changes for v2: - Changed patch description as suggested by Michael Trimarchi to make it more readable/understandable. NOTE: - patch tested on i.Core 1.5 MX6 DL --- arch/arm/boot/dts/imx6qdl-icore.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6qdl-icore.dtsi b/arch/arm/boot/dts/imx6qdl-icore.dtsi index f2f475e..23c318d 100644 --- a/arch/arm/boot/dts/imx6qdl-icore.dtsi +++ b/arch/arm/boot/dts/imx6qdl-icore.dtsi @@ -398,7 +398,7 @@ pinctrl_usbotg: usbotggrp { fsl,pins = < - MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059 + MX6QDL_PAD_ENET_RX_ER__USB_OTG_ID 0x17059 >; }; @@ -410,6 +410,7 @@ MX6QDL_PAD_SD1_DAT1__SD1_DATA1 0x17070 MX6QDL_PAD_SD1_DAT2__SD1_DATA2 0x17070 MX6QDL_PAD_SD1_DAT3__SD1_DATA3 0x17070 + MX6QDL_PAD_GPIO_1__GPIO1_IO01 0x1b0b0 >; };