From patchwork Thu Mar  3 16:36:49 2022
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Jagan Teki <jagan@amarulasolutions.com>
X-Patchwork-Id: 1855
Return-Path: 
 <linux-amarula+bncBD7MFH7A7EEBBUO5QOIQMGQEPUNE2FY@amarulasolutions.com>
X-Original-To: linux-amarula@patchwork.amarulasolutions.com
Delivered-To: linux-amarula@patchwork.amarulasolutions.com
Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com
	[209.85.214.199])
	by ganimede.amarulasolutions.com (Postfix) with ESMTPS id E3C7A3F236
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Thu,  3 Mar 2022 17:37:38 +0100 (CET)
Received: by mail-pl1-f199.google.com with SMTP id
	d4-20020a170902f14400b001518350e5c7sf3186259plb.13
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Thu, 03 Mar 2022 08:37:38 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1646325457; cv=pass;
	d=google.com; s=arc-20160816;
	b=sRu24LNCLmgmPuS1XMSVT0RHG7vJ/nZe5jGjRDmkawGDBXN3ORsAs5U91qPmNclYBr
	lt/GlkMBNmX4NeQN03BXyMwbqucgh/AMvOKm75d3df+xsgZ62JOLv4tROAfObUvhZOWq
	uCp5YbjdTAo14mBoXfboSGBRcro7hbvA+gS5MnRYZW+Gn4hjEYUB73G6qxIhXp+AH6F2
	H6lSJi80BFqmdclvaISTUlPa4D6sIvnSip0+K1pII6oLTfDNA06607wlZiI30zBojKA9
	QE5Zwo+lVmi4hOgwJ0KKM2fGJQ+13JQaUWpnlsHxhJYlWEaIkJSS5dqQzxdayTuvhN5W
	AqUw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=nyeCj5KHl397Eda2H1VRMjkcJ2cXCmB6yxH9NgEZQjA=;
	b=LA1T1+TRezfDVZafHAGY/VHyv5V9rkA9DqK4FI34kiraHK656mU17GjtVO/zqwjgQH
	fXJ2KtdC/JAQyBjjj1umQEjkG/KdwAiP9uS7zK0vwGafgUCjkcX9ba8Xbv43n6CnL5Zb
	gYMq8irxPxytOmbckng0Bdbo6R3iZhsNKZ6H+0KWV8wWzbIxX0eTnyoGfi9rZ//EUtrD
	TnXt+CsPPCL8H+FWFPs/j5p9SeBF7UiExpxzoBMkpxpxL9yYkTkDbu1EqIrDB/o3EQU3
	uLa6qbLSJPPDFcpK4TCKOFOCfr8vNcHwgjdyBo9tK3dnKI+gzYseZKNRdNl8A7zbH3mt
	Wu8A==
ARC-Authentication-Results: i=2; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=J2A6xeb0;
	spf=pass (google.com: domain of jagan@amarulasolutions.com designates
	209.85.220.41 as permitted sender)
	smtp.mailfrom=jagan@amarulasolutions.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=amarulasolutions.com; s=google;
	h=from:to:cc:subject:date:message-id:in-reply-to:references
	:mime-version:x-original-sender:x-original-authentication-results
	:precedence:mailing-list:list-id:list-post:list-help:list-archive
	:list-unsubscribe;
	bh=nyeCj5KHl397Eda2H1VRMjkcJ2cXCmB6yxH9NgEZQjA=;
	b=M4kH+QD64CbPsZRXU8LN+ttNgmtQRaC+3aaHGu7EdHMGK9rMsrLYseK8Rv7qzgHCdy
	tHG5T9laWoD8vMWVcw1unfdNAqiuZM+mvsnOYuNNz8J9ewnjeyaMRmtLR34s3JvkPfTq
	KvrAUrc0rqAdZZOdw0y68yxUc1NNEfHUmEqoc=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20210112;
	h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
	:references:mime-version:x-original-sender
	:x-original-authentication-results:precedence:mailing-list:list-id
	:x-spam-checked-in-group:list-post:list-help:list-archive
	:list-unsubscribe;
	bh=nyeCj5KHl397Eda2H1VRMjkcJ2cXCmB6yxH9NgEZQjA=;
	b=6GKsjDFt6+j0ZoEXvDAPL+CRAzXZmdC3CwkuPE24h+BheWvS1xNp86vRX3fxsXCy7+
	KIRXigLi1aFWqvNs6HzluX2YOLTMqTpsUdF76gmFtqTm1zrKlzoX4L50kszpc9FDx7rs
	ENgOuVn31d2wWPW6GKRipU7jolUCdgJ0Jpmm5PGcUdd1MViFLYWpX2s0XbbI1bi9YBNm
	edDfeZjL1Lgh+8eJFTqhotwzRC3/ckQe2XMX2Wk07E3UE3ldj3BrZf2K1NwUHWwxs5TE
	RRxxH4ZgWv3FAg1M3L8U22GGaRkXBZm8tDlAhbZgkuQAB8XLV1E7Cup4WunwrSeLlpIp
	IqiA==
X-Gm-Message-State: AOAM532J1VdemezqFyLbSHwU1XfJeJAZzOp1QTDONGsWAWfAOpVOb+iL
	/yuG7DfS4o9p33vmeCUE6ihrG/Ta
X-Google-Smtp-Source: 
 ABdhPJwOYWP6laAau4mYuZGDeA2GLTQRsmEGg80CYljCruTKh3DGlG4ggxE7C4CE+aeP24qXAM/q/Q==
X-Received: by 2002:a17:90a:a78f:b0:1bc:8042:9330 with SMTP id
	f15-20020a17090aa78f00b001bc80429330mr6074515pjq.229.1646325457710;
	Thu, 03 Mar 2022 08:37:37 -0800 (PST)
X-BeenThere: linux-amarula@amarulasolutions.com
Received: by 2002:a17:902:e546:b0:151:3f2d:8b25 with SMTP id
	n6-20020a170902e54600b001513f2d8b25ls2513108plf.1.gmail;
	Thu, 03 Mar 2022 08:37:37 -0800 (PST)
X-Received: by 2002:a17:90b:314:b0:1be:dc22:62f2 with SMTP id
	ay20-20020a17090b031400b001bedc2262f2mr6210159pjb.102.1646325456870;
	Thu, 03 Mar 2022 08:37:36 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1646325456; cv=none;
	d=google.com; s=arc-20160816;
	b=C9vHHvgL+wbRKw/In1TOrYWEm1f2i99jSsJpveO3OU9GFLG0vJil48zR8iy2gul192
	QZw0soSplCLq+sQSFVTB1raJ8dmcHzG5WSKpsZJyrS4pG7e2lgp2l2PRt7F8g/90/lQs
	nonv5TaQeSBtxkCyO7ayxyOIV2/b56MsNYHecZlx5/fZaYdETQhlU5IaN26cRgXafZIi
	yi2YHNjWVv/CRLDETNiS2g9A5/M+dwzURgp2YADz+9TnEI3Ecq1J4ADp3ak4nlH0CfcY
	PfUfwnyko96yPUB9LHx0EfXhu4H5VHshzHvC11HWNtvxy0XBYUPnKcO9FhrgWSfSJtbI
	nN5A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=content-transfer-encoding:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=Dias74Svt+6TABOfyKPB5h5wnbwc964CIcS14g2KvKI=;
	b=F/NcO52R1SIdLkq3zyx0ORWnFRhKLU2onDLbxLAehvTUZK9ZgkNa3GW1BS1xG9qwVD
	Q6Rv3ODU+Knu4fN96SYVxG/4bdXStAjEe1Ozs9dGy54KdEg9hNkSrzJEaVRjyh1998P5
	vCkWGOoU5tm2Z2Hp8HEwpDtJyOGtYemHFAyxl3tmeMSkhQtUcFM4jLio5ZoySoo2SKbL
	+UYOUAjOn46cBhx4ngkIxMCVOVKp9qxNq++cpebsflkFl+izcSJudY8ZhVOqM8zjhlbA
	pYa7vL8BeZzjl3jQkXb4GEGLPudVuO5rgBSUKRl+4uaCYUd2jMQryvB8eGdZxM3cgVNN
	TC7Q==
ARC-Authentication-Results: i=1; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=J2A6xeb0;
	spf=pass (google.com: domain of jagan@amarulasolutions.com designates
	209.85.220.41 as permitted sender)
	smtp.mailfrom=jagan@amarulasolutions.com
Received: from mail-sor-f41.google.com (mail-sor-f41.google.com.
	[209.85.220.41]) by mx.google.com with SMTPS id
	d128-20020a621d86000000b004f3bc62a6absor10566893pfd.90.2022.03.03.08.37.36
	for <linux-amarula@amarulasolutions.com>
	(Google Transport Security); Thu, 03 Mar 2022 08:37:36 -0800 (PST)
Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	client-ip=209.85.220.41;
X-Received: by 2002:aa7:9253:0:b0:4e1:53d4:c2c6 with SMTP id
	19-20020aa79253000000b004e153d4c2c6mr39231339pfp.62.1646325456504;
	Thu, 03 Mar 2022 08:37:36 -0800 (PST)
Received: from localhost.localdomain
	([2405:201:c00a:a0a9:4526:5253:a010:63f4])
	by smtp.gmail.com with ESMTPSA id
	j20-20020a056a00235400b004e192221ec2sm3220983pfj.14.2022.03.03.08.37.21
	(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
	Thu, 03 Mar 2022 08:37:36 -0800 (PST)
From: Jagan Teki <jagan@amarulasolutions.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Robert Foss <robert.foss@linaro.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	Inki Dae <inki.dae@samsung.com>
Cc: dri-devel@lists.freedesktop.org, linux-amarula@amarulasolutions.com,
	Jagan Teki <jagan@amarulasolutions.com>
Subject: [PATCH v6 1/6] drm: bridge: tc358764: Use drm panel_bridge API
Date: Thu,  3 Mar 2022 22:06:49 +0530
Message-Id: <20220303163654.3381470-2-jagan@amarulasolutions.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220303163654.3381470-1-jagan@amarulasolutions.com>
References: <20220303163654.3381470-1-jagan@amarulasolutions.com>
MIME-Version: 1.0
X-Original-Sender: jagan@amarulasolutions.com
X-Original-Authentication-Results: mx.google.com;       dkim=pass
	header.i=@amarulasolutions.com header.s=google header.b=J2A6xeb0;
	spf=pass (google.com: domain of jagan@amarulasolutions.com designates
	209.85.220.41 as permitted sender)
	smtp.mailfrom=jagan@amarulasolutions.com
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Mailing-list: list linux-amarula@amarulasolutions.com;
	contact linux-amarula+owners@amarulasolutions.com
List-ID: <linux-amarula.amarulasolutions.com>
X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com
X-Google-Group-Id: 476853432473
List-Post: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>,
	<mailto:linux-amarula@amarulasolutions.com>
List-Help: 
 <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>,
	<mailto:linux-amarula+help@amarulasolutions.com>
List-Archive: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/>
List-Unsubscribe: 
 <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>,
	<https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe>

Replace the manual panel handling code by a drm panel_bridge via
devm_drm_of_get_bridge().

Adding panel_bridge handling,

- Drops drm_connector and related operations as drm_bridge_attach
  creates connector during attachment.

- Drops panel pointer and panel healpers.

This simplifies the driver and allows all components in the display
pipeline to be treated as bridges.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
Changes for v6:
- none
Changes for v2:
- s/panel_bridge/next_bridge
- drop unneeded headers

 drivers/gpu/drm/bridge/tc358764.c | 104 ++----------------------------
 1 file changed, 6 insertions(+), 98 deletions(-)

diff --git a/drivers/gpu/drm/bridge/tc358764.c b/drivers/gpu/drm/bridge/tc358764.c
index c1e35bdf9232..dca41ed32f8a 100644
--- a/drivers/gpu/drm/bridge/tc358764.c
+++ b/drivers/gpu/drm/bridge/tc358764.c
@@ -16,14 +16,9 @@
 #include <video/mipi_display.h>
 
 #include <drm/drm_atomic_helper.h>
-#include <drm/drm_bridge.h>
-#include <drm/drm_crtc.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_mipi_dsi.h>
 #include <drm/drm_of.h>
-#include <drm/drm_panel.h>
 #include <drm/drm_print.h>
-#include <drm/drm_probe_helper.h>
 
 #define FLD_MASK(start, end)    (((1 << ((start) - (end) + 1)) - 1) << (end))
 #define FLD_VAL(val, start, end) (((val) << (end)) & FLD_MASK(start, end))
@@ -153,10 +148,9 @@ static const char * const tc358764_supplies[] = {
 struct tc358764 {
 	struct device *dev;
 	struct drm_bridge bridge;
-	struct drm_connector connector;
+	struct drm_bridge *next_bridge;
 	struct regulator_bulk_data supplies[ARRAY_SIZE(tc358764_supplies)];
 	struct gpio_desc *gpio_reset;
-	struct drm_panel *panel;
 	int error;
 };
 
@@ -210,12 +204,6 @@ static inline struct tc358764 *bridge_to_tc358764(struct drm_bridge *bridge)
 	return container_of(bridge, struct tc358764, bridge);
 }
 
-static inline
-struct tc358764 *connector_to_tc358764(struct drm_connector *connector)
-{
-	return container_of(connector, struct tc358764, connector);
-}
-
 static int tc358764_init(struct tc358764 *ctx)
 {
 	u32 v = 0;
@@ -278,43 +266,11 @@ static void tc358764_reset(struct tc358764 *ctx)
 	usleep_range(1000, 2000);
 }
 
-static int tc358764_get_modes(struct drm_connector *connector)
-{
-	struct tc358764 *ctx = connector_to_tc358764(connector);
-
-	return drm_panel_get_modes(ctx->panel, connector);
-}
-
-static const
-struct drm_connector_helper_funcs tc358764_connector_helper_funcs = {
-	.get_modes = tc358764_get_modes,
-};
-
-static const struct drm_connector_funcs tc358764_connector_funcs = {
-	.fill_modes = drm_helper_probe_single_connector_modes,
-	.destroy = drm_connector_cleanup,
-	.reset = drm_atomic_helper_connector_reset,
-	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
-	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
-};
-
-static void tc358764_disable(struct drm_bridge *bridge)
-{
-	struct tc358764 *ctx = bridge_to_tc358764(bridge);
-	int ret = drm_panel_disable(bridge_to_tc358764(bridge)->panel);
-
-	if (ret < 0)
-		dev_err(ctx->dev, "error disabling panel (%d)\n", ret);
-}
-
 static void tc358764_post_disable(struct drm_bridge *bridge)
 {
 	struct tc358764 *ctx = bridge_to_tc358764(bridge);
 	int ret;
 
-	ret = drm_panel_unprepare(ctx->panel);
-	if (ret < 0)
-		dev_err(ctx->dev, "error unpreparing panel (%d)\n", ret);
 	tc358764_reset(ctx);
 	usleep_range(10000, 15000);
 	ret = regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies);
@@ -335,72 +291,25 @@ static void tc358764_pre_enable(struct drm_bridge *bridge)
 	ret = tc358764_init(ctx);
 	if (ret < 0)
 		dev_err(ctx->dev, "error initializing bridge (%d)\n", ret);
-	ret = drm_panel_prepare(ctx->panel);
-	if (ret < 0)
-		dev_err(ctx->dev, "error preparing panel (%d)\n", ret);
-}
-
-static void tc358764_enable(struct drm_bridge *bridge)
-{
-	struct tc358764 *ctx = bridge_to_tc358764(bridge);
-	int ret = drm_panel_enable(ctx->panel);
-
-	if (ret < 0)
-		dev_err(ctx->dev, "error enabling panel (%d)\n", ret);
 }
 
 static int tc358764_attach(struct drm_bridge *bridge,
 			   enum drm_bridge_attach_flags flags)
-{
-	struct tc358764 *ctx = bridge_to_tc358764(bridge);
-	struct drm_device *drm = bridge->dev;
-	int ret;
-
-	if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) {
-		DRM_ERROR("Fix bridge driver to make connector optional!");
-		return -EINVAL;
-	}
-
-	ctx->connector.polled = DRM_CONNECTOR_POLL_HPD;
-	ret = drm_connector_init(drm, &ctx->connector,
-				 &tc358764_connector_funcs,
-				 DRM_MODE_CONNECTOR_LVDS);
-	if (ret) {
-		DRM_ERROR("Failed to initialize connector\n");
-		return ret;
-	}
-
-	drm_connector_helper_add(&ctx->connector,
-				 &tc358764_connector_helper_funcs);
-	drm_connector_attach_encoder(&ctx->connector, bridge->encoder);
-	ctx->connector.funcs->reset(&ctx->connector);
-	drm_connector_register(&ctx->connector);
-
-	return 0;
-}
-
-static void tc358764_detach(struct drm_bridge *bridge)
 {
 	struct tc358764 *ctx = bridge_to_tc358764(bridge);
 
-	drm_connector_unregister(&ctx->connector);
-	ctx->panel = NULL;
-	drm_connector_put(&ctx->connector);
+	return drm_bridge_attach(bridge->encoder, ctx->next_bridge, bridge, flags);
 }
 
 static const struct drm_bridge_funcs tc358764_bridge_funcs = {
-	.disable = tc358764_disable,
 	.post_disable = tc358764_post_disable,
-	.enable = tc358764_enable,
 	.pre_enable = tc358764_pre_enable,
 	.attach = tc358764_attach,
-	.detach = tc358764_detach,
 };
 
 static int tc358764_parse_dt(struct tc358764 *ctx)
 {
 	struct device *dev = ctx->dev;
-	int ret;
 
 	ctx->gpio_reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
 	if (IS_ERR(ctx->gpio_reset)) {
@@ -408,12 +317,11 @@ static int tc358764_parse_dt(struct tc358764 *ctx)
 		return PTR_ERR(ctx->gpio_reset);
 	}
 
-	ret = drm_of_find_panel_or_bridge(ctx->dev->of_node, 1, 0, &ctx->panel,
-					  NULL);
-	if (ret && ret != -EPROBE_DEFER)
-		dev_err(dev, "cannot find panel (%d)\n", ret);
+	ctx->next_bridge = devm_drm_of_get_bridge(dev, dev->of_node, 1, 0);
+	if (IS_ERR(ctx->next_bridge))
+		return PTR_ERR(ctx->next_bridge);
 
-	return ret;
+	return 0;
 }
 
 static int tc358764_configure_regulators(struct tc358764 *ctx)

From patchwork Thu Mar  3 16:36:50 2022
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Jagan Teki <jagan@amarulasolutions.com>
X-Patchwork-Id: 1856
Return-Path: 
 <linux-amarula+bncBD7MFH7A7EEBBWW5QOIQMGQEEN5S6JQ@amarulasolutions.com>
X-Original-To: linux-amarula@patchwork.amarulasolutions.com
Delivered-To: linux-amarula@patchwork.amarulasolutions.com
Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com
	[209.85.214.199])
	by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 46D4B3F236
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Thu,  3 Mar 2022 17:37:47 +0100 (CET)
Received: by mail-pl1-f199.google.com with SMTP id
	b7-20020a170902a9c700b0014fda723ad4sf3189827plr.15
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Thu, 03 Mar 2022 08:37:47 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1646325466; cv=pass;
	d=google.com; s=arc-20160816;
	b=BM0ca2Cn5rdw8jGn5c0CSlkpLLKIgxfToWSYB3CtYK/xVh1p7VLPE9l0kJGz1xlUpi
	RZuaolU8sVtOQQvQ8Sb83IAYzzp7YyVynbpnR2AMiaih+xrcevd26gn1R3dW/lSrOckb
	goWrxofev2I43do0fNEVPQDiUXIaUopAtsgTPavtu2kR+vyX9q+7qk2u9fnJS44d9Y+g
	VlkD8AFdFA6c5OHs6ZbTCmLSs/aVCYYIgtGio8NJHrrMa4vZL0EJ0VJZe9N0hd1OIvG+
	fqCnt+0gKsn3RZK8nFLB9PYdUJHb8A9KdFAG9GD+4KhdpbvfuJ2o6ReTMC6oZnGCVjco
	Z7Lg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=p9X/g6eGuEQukGQfTMG23G4ShEG/rWP+t2/EFrUVB6M=;
	b=qKJ/bdNOnK1qb+uEnvzPIGgRK8IR3vR+wGmEeBd9kJIl5dMIAoLGSs2oCUJcz9y4+7
	5dQO/TLp64EE2j2ce6NrcRr9KgdqB7JawQT5sGdspd692hmG1pjkUb/Cn+XtE0S2/OGA
	4OlBRTs/cssEuPHqlE8Ew77ferCsndL94ecsr+SpieIC/zxiQmD7aNeCtKJtcYGoAPR2
	P/KbOZ1Ntorz+8dRI4aA3aP9kQuvzVk4XEsa7K/Tn870gDj5E/dEkaLyySIc2p3K2kZ0
	XSJE14XrJmId+R1qgBxg2mx3wVgRB4kX7R61B4LIsaBapdCmgRuO8bC+ZWJSg+a7OaDO
	/VZw==
ARC-Authentication-Results: i=2; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=gVrdwHfK;
	spf=pass (google.com: domain of jagan@amarulasolutions.com designates
	209.85.220.41 as permitted sender)
	smtp.mailfrom=jagan@amarulasolutions.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=amarulasolutions.com; s=google;
	h=from:to:cc:subject:date:message-id:in-reply-to:references
	:mime-version:x-original-sender:x-original-authentication-results
	:precedence:mailing-list:list-id:list-post:list-help:list-archive
	:list-unsubscribe;
	bh=p9X/g6eGuEQukGQfTMG23G4ShEG/rWP+t2/EFrUVB6M=;
	b=i5uVRr8dn2nXS4gzsijgENh5xwXLcBl3YQ72iDOLf6dTfWg57ciGa78hyQgtlXhswZ
	MngvFcTfq/2Sr++dAv7fNc0ru9+DY2Yr7yu5a50yyMRO4Hr2g5gStIKeoAnEicWO+B72
	3XtDcd+TeJpOCj3dM3JOoJGpPvQepHLHD31Vs=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20210112;
	h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
	:references:mime-version:x-original-sender
	:x-original-authentication-results:precedence:mailing-list:list-id
	:x-spam-checked-in-group:list-post:list-help:list-archive
	:list-unsubscribe;
	bh=p9X/g6eGuEQukGQfTMG23G4ShEG/rWP+t2/EFrUVB6M=;
	b=ueu+yipVXdsJ8X5cHavUxFskYydp7qEUcVNYv5k6xHteUNShdvwHIH34XE7WQijnx9
	Bv6FKyEgwRfvKi0Wcvv5AV+TPW4tZowxb2ei1GroGYptJjOVcah/aR6ElQXYYPZeGyNg
	8i+K1lyZ2oID/sYSPo2iFrBIK3alBCppQWplCHYbMruYOstwSaZi7xSRWvjhD09yeK6m
	8DG+5D6BevZzdE5HEZ+rWRLjPBu9naTwceziJQ+M/k+Rf5sbyPkeQ90vd7NZAx4GPFi0
	nE2mO4XjRgGe3y/2CBDTYBxDeXBiqDbsXcZkXOb/A0S+znf2UbNu7CuzMqaThKibaIWl
	60vg==
X-Gm-Message-State: AOAM533pXgcfwZRaHZ3Uxuq3NE6LFiezmU77RBTs+fk2+uAKx174nSnI
	x4GOPtO3X4iI/MLFcY481SAmzmN7
X-Google-Smtp-Source: 
 ABdhPJzIIqDD5ezG3T1lQ7G6L+j99YdBktPXbDtCtzksFSSAXIPB6crwazKMtKaXyp68L/qIqJaMcw==
X-Received: by 2002:a17:902:8a97:b0:14a:c625:eb2d with SMTP id
	p23-20020a1709028a9700b0014ac625eb2dmr37451379plo.26.1646325466107;
	Thu, 03 Mar 2022 08:37:46 -0800 (PST)
X-BeenThere: linux-amarula@amarulasolutions.com
Received: by 2002:a17:902:bb8c:b0:14d:d65a:dbdb with SMTP id
	m12-20020a170902bb8c00b0014dd65adbdbls2500648pls.6.gmail;
	Thu, 03 Mar 2022 08:37:45 -0800 (PST)
X-Received: by 2002:a17:902:f712:b0:149:d41a:baa8 with SMTP id
	h18-20020a170902f71200b00149d41abaa8mr36538475plo.115.1646325465338;
	Thu, 03 Mar 2022 08:37:45 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1646325465; cv=none;
	d=google.com; s=arc-20160816;
	b=gsyu3MWR0SAy/uxHPhG91cAHl9/+rPoAG5omEyUZ7Gzik/6WptQOiZYPeTMemmk9sB
	Pv+fzmTyADOe1lOo8A2TATDTCNrRYEKBqe342aR/2JT3mFA2plR065toysgy5F4B8g/7
	fMzYEUd/OTJedQJwKTo8Rs3X+nZxaMb6UsLyDk5tMMY96hfsKtoI+Ou9ALzQb/uWRG03
	Ms6ymfsUJa1eytXRF4nXo+D34DRIatkV2aRJP4sdRDr1AyRh242FbYOqEPtuC3Fwf/iK
	1RuZFjFTNUelfkPc6NPlizlGhbq1lsuzwcPQvGXkO04ryEdzuECICPoUi9aAPu7aylyD
	tYfQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=content-transfer-encoding:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=uLbgWPGTvslOBS5UpaKI0SJIKPvPO+ELrEhMx1Q0zDM=;
	b=ESLsWIc3/k2SV8OwB8xMxud81336ECmTtYCtIl0uvd25dj4gkv7+Tvy1KJiiYi1mkG
	6Lv5UdQomdE9LCwBp/xBZNZ6TSmjlZyHP1qm98lI8faLKyLinvujhvSEijIpldPQ23Aj
	mTu/teXkmCH+muc1+LlXsIaXWCN+lMnxRh5LvYlXtDYjVvUQGr0tYhcdnSPwOjoBKhjT
	G0CGFqrP+QnL62MDJHyrgTzAmIfpXK6maj6dqaHWhqeAH4KjboMToiL4bRL8hiugcyuh
	3551vpyg5BMZ8hy0wFo3lY+BWnQtGWBY4ifGfDn18uJG5JI764/wxFU4PsC5CTY1p7j9
	YfLw==
ARC-Authentication-Results: i=1; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=gVrdwHfK;
	spf=pass (google.com: domain of jagan@amarulasolutions.com designates
	209.85.220.41 as permitted sender)
	smtp.mailfrom=jagan@amarulasolutions.com
Received: from mail-sor-f41.google.com (mail-sor-f41.google.com.
	[209.85.220.41]) by mx.google.com with SMTPS id
	y14-20020a17090322ce00b0014fe92899ebsor3198815plg.155.2022.03.03.08.37.45
	for <linux-amarula@amarulasolutions.com>
	(Google Transport Security); Thu, 03 Mar 2022 08:37:45 -0800 (PST)
Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	client-ip=209.85.220.41;
X-Received: by 2002:a17:902:7041:b0:14f:c724:42c7 with SMTP id
	h1-20020a170902704100b0014fc72442c7mr36866699plt.11.1646325465047;
	Thu, 03 Mar 2022 08:37:45 -0800 (PST)
Received: from localhost.localdomain
	([2405:201:c00a:a0a9:4526:5253:a010:63f4])
	by smtp.gmail.com with ESMTPSA id
	j20-20020a056a00235400b004e192221ec2sm3220983pfj.14.2022.03.03.08.37.37
	(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
	Thu, 03 Mar 2022 08:37:44 -0800 (PST)
From: Jagan Teki <jagan@amarulasolutions.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Robert Foss <robert.foss@linaro.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	Inki Dae <inki.dae@samsung.com>
Cc: dri-devel@lists.freedesktop.org, linux-amarula@amarulasolutions.com,
	Jagan Teki <jagan@amarulasolutions.com>
Subject: [PATCH v6 2/6] drm: bridge: panel: Reset the connector state pointer
Date: Thu,  3 Mar 2022 22:06:50 +0530
Message-Id: <20220303163654.3381470-3-jagan@amarulasolutions.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220303163654.3381470-1-jagan@amarulasolutions.com>
References: <20220303163654.3381470-1-jagan@amarulasolutions.com>
MIME-Version: 1.0
X-Original-Sender: jagan@amarulasolutions.com
X-Original-Authentication-Results: mx.google.com;       dkim=pass
	header.i=@amarulasolutions.com header.s=google header.b=gVrdwHfK;
	spf=pass (google.com: domain of jagan@amarulasolutions.com designates
	209.85.220.41 as permitted sender)
	smtp.mailfrom=jagan@amarulasolutions.com
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Mailing-list: list linux-amarula@amarulasolutions.com;
	contact linux-amarula+owners@amarulasolutions.com
List-ID: <linux-amarula.amarulasolutions.com>
X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com
X-Google-Group-Id: 476853432473
List-Post: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>,
	<mailto:linux-amarula@amarulasolutions.com>
List-Help: 
 <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>,
	<mailto:linux-amarula+help@amarulasolutions.com>
List-Archive: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/>
List-Unsubscribe: 
 <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>,
	<https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe>

Trigger hotplug event with drm_kms_helper_hotplug_event might fail if the
connector state pointer is NULL.

BUG observed in exynos dsi driver where drm_bridge_attach is trying to register
a connector in panel_bridge before the hotplug event is triggered,

WARNING: CPU: 1 PID: 1 at drivers/gpu/drm/drm_atomic_state_helper.c:494 drm_atomic_helper_connector_duplicate_state+0x94/0x9c
Modules linked in:
CPU: 1 PID: 1 Comm: swapper/0 Tainted: G W 5.16.0-rc1-00009-g704b1dbfa4c2 #11058
Hardware name: Samsung Exynos (Flattened Device Tree)
[<c0110b30>] (unwind_backtrace) from [<c010c618>] (show_stack+0x10/0x14)
[<c010c618>] (show_stack) from [<c0b657d4>] (dump_stack_lvl+0x58/0x70)
[<c0b657d4>] (dump_stack_lvl) from [<c01261dc>] (__warn+0xd0/0x134)
[<c01261dc>] (__warn) from [<c0b5f628>] (warn_slowpath_fmt+0x5c/0xb4)
[<c0b5f628>] (warn_slowpath_fmt) from [<c064bce4>] (drm_atomic_helper_connector_duplicate_state+0x94/0x9c)
[<c064bce4>] (drm_atomic_helper_connector_duplicate_state) from [<c0666b64>] (drm_atomic_get_connector_state+0xd4/0x190)
[<c0666b64>] (drm_atomic_get_connector_state) from [<c0667928>] (__drm_atomic_helper_set_config+0x314/0x368)
[<c0667928>] (__drm_atomic_helper_set_config) from [<c067e628>] (drm_client_modeset_commit_atomic+0x170/0x278)
[<c067e628>] (drm_client_modeset_commit_atomic) from [<c067e800>] (drm_client_modeset_commit_locked+0x60/0x1c8)
[<c067e800>] (drm_client_modeset_commit_locked) from [<c067e98c>] (drm_client_modeset_commit+0x24/0x40)
[<c067e98c>] (drm_client_modeset_commit) from [<c06509c0>] (drm_fb_helper_set_par+0xb8/0xf8)
[<c06509c0>] (drm_fb_helper_set_par) from [<c05b86d0>] (fbcon_init+0x2c0/0x518)
[<c05b86d0>] (fbcon_init) from [<c060636c>] (visual_init+0xc0/0x108)
[<c060636c>] (visual_init) from [<c06085e4>] (do_bind_con_driver+0x1b8/0x3a4)
[<c06085e4>] (do_bind_con_driver) from [<c0608b40>] (do_take_over_console+0x13c/0x1e8)
[<c0608b40>] (do_take_over_console) from [<c05b6854>] (do_fbcon_takeover+0x78/0xd8)
[<c05b6854>] (do_fbcon_takeover) from [<c05b1154>] (register_framebuffer+0x208/0x2e0)
[<c05b1154>] (register_framebuffer) from [<c064ead0>] (__drm_fb_helper_initial_config_and_unlock+0x400/0x63c)
[<c064ead0>] (__drm_fb_helper_initial_config_and_unlock) from [<c063a718>] (drm_kms_helper_hotplug_event+0x24/0x30)
[<c063a718>] (drm_kms_helper_hotplug_event) from [<c068f668>] (exynos_dsi_host_attach+0x174/0x1fc)
[<c068f668>] (exynos_dsi_host_attach) from [<c0699354>] (s6e8aa0_probe+0x1b4/0x218)

So reset the atomic state for a given connector by freeing the state pointer
and allocate a new empty state object. This can be done using connector
funcs->reset helper and has to be done before the hotplug even calls.

This patch calls the connector->funcs->reset in panel_bridge_attach.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
Changes for v6, v5:
- none
Changes for v4:
- new patch

 drivers/gpu/drm/bridge/panel.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index b32295abd9e7..f6eea194482a 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -83,6 +83,9 @@ static int panel_bridge_attach(struct drm_bridge *bridge,
 	drm_connector_attach_encoder(&panel_bridge->connector,
 					  bridge->encoder);
 
+	if (connector->funcs->reset)
+		connector->funcs->reset(connector);
+
 	return 0;
 }
 

From patchwork Thu Mar  3 16:36:51 2022
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Jagan Teki <jagan@amarulasolutions.com>
X-Patchwork-Id: 1857
Return-Path: 
 <linux-amarula+bncBD7MFH7A7EEBBYW5QOIQMGQE233TPJY@amarulasolutions.com>
X-Original-To: linux-amarula@patchwork.amarulasolutions.com
Delivered-To: linux-amarula@patchwork.amarulasolutions.com
Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com
	[209.85.216.70])
	by ganimede.amarulasolutions.com (Postfix) with ESMTPS id CF11A3F236
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Thu,  3 Mar 2022 17:37:55 +0100 (CET)
Received: by mail-pj1-f70.google.com with SMTP id
	p5-20020a17090a748500b001bee6752974sf3299193pjk.8
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Thu, 03 Mar 2022 08:37:55 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1646325474; cv=pass;
	d=google.com; s=arc-20160816;
	b=icH8Ne4yG/2LL1cK7LPjq5waJ9dAON+sPJ3N2Qmaph9dfrBnDXy5uwOiAZBOG663kU
	oMoh6pxBvn24INC3usafhSCL6EEEBTQYmLa+1TeJSzEvBi/O87hsaCocsLMD7CY/V9fR
	mUghGX0tHvQXjFBZqe9mlxxgg2w8RhCKjjwSeKQk1I+yqEpQSr+dSSVoy94KjXBZiHEY
	a+xUisc+Z74nY5WUJggxYl3jkUKXAb8qMzlnk6k3hUerjgs/cRn4FqyCMTbh2qmh1w9/
	HD4IHT/eVJtxNmmMBkXmObLAR+6LYjR15O/oVg2VYPyeDbppZ+8vls4T98T0qyzsGulY
	1+0w==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=LQjUgeOMe19KxGXlTyp39nYZgINBNkxraCApJwSubp8=;
	b=sjCI4yn4mI0a4qzpBf6QB3ASNrcRb9rLM5RYzNJvoLn8nnlEQA5Do99YvypGsybPUe
	F0IPW5qKmrMmBbEpVd6cjfxsPx1Jg/4f0/ATGRMggR+zEPdh8LcJt18bjdJkxL8O8jb4
	5Xw4iT/iQyrldUuyQpCqkwFAznvkRevUq2USVC2VB11hX2DjgCY+dVcRIjuEkJHaPYzE
	rkEGW51/eFKtRcHjD2M+4p3GUQ78IkCMgILd8I0L/dvnl4ME3perL1QWriF9SD8gRaAM
	qgkLsqZ3JeGlpT/REDsmurcmHNV567WzQhgf8orchkDyLXSz0skI9r81lA4EyimL+u4f
	3rIw==
ARC-Authentication-Results: i=2; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=IM9EGV6I;
	spf=pass (google.com: domain of jagan@amarulasolutions.com designates
	209.85.220.41 as permitted sender)
	smtp.mailfrom=jagan@amarulasolutions.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=amarulasolutions.com; s=google;
	h=from:to:cc:subject:date:message-id:in-reply-to:references
	:mime-version:x-original-sender:x-original-authentication-results
	:precedence:mailing-list:list-id:list-post:list-help:list-archive
	:list-unsubscribe;
	bh=LQjUgeOMe19KxGXlTyp39nYZgINBNkxraCApJwSubp8=;
	b=ex927sqOMpA7Rdry8xpiB1BkfKmstqOv4i3opUzQ7PCfpi/vyPfAQ/ar1NfcIsjsdv
	A7yM2Gx20e4MxJxmqFDx4YYEbVd4WZOxFgAUZsF7dYk6ptre7cCy9Cc1tTNot3P0L4zl
	54ZZO7i7zTW3hG/QDisrNFgun3ZYLqLxMvk1A=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20210112;
	h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
	:references:mime-version:x-original-sender
	:x-original-authentication-results:precedence:mailing-list:list-id
	:x-spam-checked-in-group:list-post:list-help:list-archive
	:list-unsubscribe;
	bh=LQjUgeOMe19KxGXlTyp39nYZgINBNkxraCApJwSubp8=;
	b=2LgysWa+nmgsFyV7OZfF9+B3p7/JdV9dspPhzgJrM6TxUkaGiLFE20wIjGdcoINooW
	yaanZApOS56VNDJNodWcr1u8nXKrIOcIt9taLZDdflWRXUpGJsSSGLmmNZ/zLEbWVmzs
	JtiY9BLpLv9obOb6aJECYmWiLAHCNfnMlezLkUkZpC5+s2RsqG2x+D5UdrJuDgIW43tj
	N7Kn2qy7Thh6SiZMWGw8XyAi0VF+BAgtaRbgePDzhgwJK/+8XkJdkaVQQa9u8fet+gGH
	NQtpaTeFCcR5TVn8Ygp+LbodfCOobxpxFd6wxXP/W2tp9BwoLMGsHLpi5jMiMrAfR8MT
	/eNA==
X-Gm-Message-State: AOAM5318Vd54KCW7HE3ghprw07OfroGz7vaXybHWn8+MCpbDeYx0FbHa
	QT91kWkb1EluPdXbX4IwnZWAJpdD
X-Google-Smtp-Source: 
 ABdhPJzRSfeNYeqJQPO66ER5wJtGqb4Rb/bEjxvqQ6Bzm+/9Og8fRC/Ih7f4m2MEzJIegZ6Y9f4LUQ==
X-Received: by 2002:a17:90b:1193:b0:1bc:1b5a:84e4 with SMTP id
	gk19-20020a17090b119300b001bc1b5a84e4mr6224492pjb.113.1646325474651;
	Thu, 03 Mar 2022 08:37:54 -0800 (PST)
X-BeenThere: linux-amarula@amarulasolutions.com
Received: by 2002:a65:6697:0:b0:37c:63e5:142a with SMTP id
	b23-20020a656697000000b0037c63e5142als601544pgw.10.gmail;
	Thu, 03 Mar 2022 08:37:54 -0800 (PST)
X-Received: by 2002:a05:6a00:188f:b0:4e1:a253:850c with SMTP id
	x15-20020a056a00188f00b004e1a253850cmr38995503pfh.61.1646325473882;
	Thu, 03 Mar 2022 08:37:53 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1646325473; cv=none;
	d=google.com; s=arc-20160816;
	b=f0JsYU0Zdoc2D861mWVwdVafSzvhhyHOAzT4n8DsM8m4xG/nOYnZmKbGRAW8pPBhOl
	S4WYXyDAiJ6GiUpUsPHaNteYnNCShUfx9Zj36RQvYm1lxm2yc7YCQzuz3UuBRtu3Xcon
	lmMwI1D19rMMl9fhYcfdyOwAdipNisonJvDJf+iQ8gBxrTR4s6La69CNybWbslH5M3xT
	BLBdleYMWKMUA9DzjC19wEil9lWzx1rXrvvdMgM8LCzQXVCKDnjh/969ccPhKdLCusVT
	R2NRfLMr8yeC6U/IQqqdXl/vY+4J4MnJAU1qoO3PDNKpdflQaE2ZijMu5g2SgvFi/uJ7
	puag==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=content-transfer-encoding:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=LqxMAJ8/uNH+xDV5ABc3SJFvaxw+zJIGqvUEcIBudhI=;
	b=yw+n6cufyq22d66xPLF7cSdwUiyny1dIP4z3TBcgJVDb+oVODi0wzBeEfjiSJwi13h
	drroHI+OUgzdZy8tLv9vlxadYMCimjMuxPbpcO9hLM/uOeXD/S4Ib5g10PRE+dpHQnyc
	5gxIM6S2eWgfLCGClJg91Sq2UHjbjtY7woeG8PQI4SEO/SaGO9qYD+Cyzx4ERH2yfTzf
	YIiKi1CdLijNvkSYHIpJhkOy7g/rkTFUX/aJatlYtlLNCccoPyksLG+QodsFzcU5/adT
	tVFarxSWp/B8hhqxr5xX7rk4d5eGxp+W1x7s7/mcQk+V45r6iJHlXsfokx9fiu6mbz+i
	oIbw==
ARC-Authentication-Results: i=1; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=IM9EGV6I;
	spf=pass (google.com: domain of jagan@amarulasolutions.com designates
	209.85.220.41 as permitted sender)
	smtp.mailfrom=jagan@amarulasolutions.com
Received: from mail-sor-f41.google.com (mail-sor-f41.google.com.
	[209.85.220.41]) by mx.google.com with SMTPS id
	w129-20020a626287000000b004f3bc62a679sor35139pfb.40.2022.03.03.08.37.53
	for <linux-amarula@amarulasolutions.com>
	(Google Transport Security); Thu, 03 Mar 2022 08:37:53 -0800 (PST)
Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	client-ip=209.85.220.41;
X-Received: by 2002:a05:6a00:1a56:b0:4f4:1a2a:6d1b with SMTP id
	h22-20020a056a001a5600b004f41a2a6d1bmr19378527pfv.65.1646325473491;
	Thu, 03 Mar 2022 08:37:53 -0800 (PST)
Received: from localhost.localdomain
	([2405:201:c00a:a0a9:4526:5253:a010:63f4])
	by smtp.gmail.com with ESMTPSA id
	j20-20020a056a00235400b004e192221ec2sm3220983pfj.14.2022.03.03.08.37.45
	(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
	Thu, 03 Mar 2022 08:37:53 -0800 (PST)
From: Jagan Teki <jagan@amarulasolutions.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Robert Foss <robert.foss@linaro.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	Inki Dae <inki.dae@samsung.com>
Cc: dri-devel@lists.freedesktop.org, linux-amarula@amarulasolutions.com,
	Jagan Teki <jagan@amarulasolutions.com>
Subject: [PATCH v6 3/6] exynos: drm: dsi: Attach in_bridge in MIC driver
Date: Thu,  3 Mar 2022 22:06:51 +0530
Message-Id: <20220303163654.3381470-4-jagan@amarulasolutions.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220303163654.3381470-1-jagan@amarulasolutions.com>
References: <20220303163654.3381470-1-jagan@amarulasolutions.com>
MIME-Version: 1.0
X-Original-Sender: jagan@amarulasolutions.com
X-Original-Authentication-Results: mx.google.com;       dkim=pass
	header.i=@amarulasolutions.com header.s=google header.b=IM9EGV6I;
	spf=pass (google.com: domain of jagan@amarulasolutions.com designates
	209.85.220.41 as permitted sender)
	smtp.mailfrom=jagan@amarulasolutions.com
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Mailing-list: list linux-amarula@amarulasolutions.com;
	contact linux-amarula+owners@amarulasolutions.com
List-ID: <linux-amarula.amarulasolutions.com>
X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com
X-Google-Group-Id: 476853432473
List-Post: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>,
	<mailto:linux-amarula@amarulasolutions.com>
List-Help: 
 <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>,
	<mailto:linux-amarula+help@amarulasolutions.com>
List-Archive: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/>
List-Unsubscribe: 
 <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>,
	<https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe>

MIC drivers in the Exynos5433 display pipeline are already registered
as bridge drivers and it is more advisable to attach the downstream
bridge on the bridge attach call instead of doing the same in the
DSI driver.

This makes bridge attachment more meaningful and avoids the races
during bridge function calls.

So, move the bridge finding and drm_bridge_attach from DSI to MIC.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
Changes for v6:
- new patch

 drivers/gpu/drm/exynos/exynos_drm_dsi.c | 15 ---------------
 drivers/gpu/drm/exynos/exynos_drm_mic.c | 22 ++++++++++++++++++++++
 2 files changed, 22 insertions(+), 15 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index b7d0a4aead0a..741c046513e8 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1660,11 +1660,6 @@ static int exynos_dsi_of_read_u32(const struct device_node *np,
 	return ret;
 }
 
-enum {
-	DSI_PORT_IN,
-	DSI_PORT_OUT
-};
-
 static int exynos_dsi_parse_dt(struct exynos_dsi *dsi)
 {
 	struct device *dev = dsi->dev;
@@ -1695,8 +1690,6 @@ static int exynos_dsi_bind(struct device *dev, struct device *master,
 	struct exynos_dsi *dsi = dev_get_drvdata(dev);
 	struct drm_encoder *encoder = &dsi->encoder;
 	struct drm_device *drm_dev = data;
-	struct device_node *in_bridge_node;
-	struct drm_bridge *in_bridge;
 	int ret;
 
 	drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_TMDS);
@@ -1707,14 +1700,6 @@ static int exynos_dsi_bind(struct device *dev, struct device *master,
 	if (ret < 0)
 		return ret;
 
-	in_bridge_node = of_graph_get_remote_node(dev->of_node, DSI_PORT_IN, 0);
-	if (in_bridge_node) {
-		in_bridge = of_drm_find_bridge(in_bridge_node);
-		if (in_bridge)
-			drm_bridge_attach(encoder, in_bridge, NULL, 0);
-		of_node_put(in_bridge_node);
-	}
-
 	return mipi_dsi_host_register(&dsi->dsi_host);
 }
 
diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
index 32672bf8ae4a..9e06f8e2a863 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
@@ -102,6 +102,7 @@ struct exynos_mic {
 	struct videomode vm;
 	struct drm_encoder *encoder;
 	struct drm_bridge bridge;
+	struct drm_bridge *next_bridge;
 
 	bool enabled;
 };
@@ -298,12 +299,22 @@ static void mic_pre_enable(struct drm_bridge *bridge)
 
 static void mic_enable(struct drm_bridge *bridge) { }
 
+static int mic_attach(struct drm_bridge *bridge,
+		      enum drm_bridge_attach_flags flags)
+{
+	struct exynos_mic *mic = bridge->driver_private;
+
+	return drm_bridge_attach(bridge->encoder, mic->next_bridge,
+				 &mic->bridge, flags);
+}
+
 static const struct drm_bridge_funcs mic_bridge_funcs = {
 	.disable = mic_disable,
 	.post_disable = mic_post_disable,
 	.mode_set = mic_mode_set,
 	.pre_enable = mic_pre_enable,
 	.enable = mic_enable,
+	.attach = mic_attach,
 };
 
 static int exynos_mic_bind(struct device *dev, struct device *master,
@@ -377,6 +388,7 @@ static int exynos_mic_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct exynos_mic *mic;
+	struct device_node *remote;
 	struct resource res;
 	int ret, i;
 
@@ -420,6 +432,16 @@ static int exynos_mic_probe(struct platform_device *pdev)
 		}
 	}
 
+	remote = of_graph_get_remote_node(dev->of_node, 1, 0);
+	mic->next_bridge = of_drm_find_bridge(remote);
+	if (IS_ERR(mic->next_bridge)) {
+		DRM_DEV_ERROR(dev, "mic: Failed to find next bridge\n");
+		ret = PTR_ERR(mic->next_bridge);
+		goto err;
+	}
+
+	of_node_put(remote);
+
 	platform_set_drvdata(pdev, mic);
 
 	mic->bridge.funcs = &mic_bridge_funcs;

From patchwork Thu Mar  3 16:36:52 2022
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Jagan Teki <jagan@amarulasolutions.com>
X-Patchwork-Id: 1858
Return-Path: 
 <linux-amarula+bncBD7MFH7A7EEBB365QOIQMGQEH2IG54A@amarulasolutions.com>
X-Original-To: linux-amarula@patchwork.amarulasolutions.com
Delivered-To: linux-amarula@patchwork.amarulasolutions.com
Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com
	[209.85.214.197])
	by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 8CC483F236
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Thu,  3 Mar 2022 17:38:08 +0100 (CET)
Received: by mail-pl1-f197.google.com with SMTP id
	n12-20020a170902e54c00b0015011534fa3sf3195183plf.9
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Thu, 03 Mar 2022 08:38:08 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1646325487; cv=pass;
	d=google.com; s=arc-20160816;
	b=L0Q5UYfQ3OeFzwPOLBCM3TmznyK5cBbpZ2+eCpOVzc8QMGNvc0vkwxKDYrUxIzOvjl
	1DQs+1H2HP+I8jj/xXFTYiISFFleSZq81Rlo4poRoRDkFmX4iM0474TcGv/+Wp4RpqqI
	GPci8vgz2p+6evHfsZYImR1F+O36e9HynZEXs0ZDXDiGgbFIWjiUjPgKTHcOT+Sv3QN2
	7Rs1b12cwJyjouRMyIBBlSd2rCMfL5L7c+ySF2RTaOju721VcH0pOH0L2NPRZDovtgTb
	O3BPSGnonKqqtZzG8ijG4ZDc0rKCxKqHgmhGFVNrWdbXiJy5j2EK34VymZDDQZvrXwbL
	GBmw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=mdzGhfxfgZiyiOQRrr4uE6JADbPttUDb6C1TlIgorpQ=;
	b=mjpDXzV9KGQRby2a63N8BQXHLStcMTQITBFeOZO2eHc/qyMe4kXF4L/Ri3laH+Ytu2
	86kZ+lDE++YXEYFDSvHh+oRf+YSpRzgUCi2gYFrKHYEC4AtYc8cHWX6V2WoFs5MJjemt
	QZsSG11cGS67J+Zayd8q2QAf7zqlK4wlexngfYd6xySDWeE5BarNr8bob7A2asuRgiUD
	acKsYZozShTHh6UILj4/3g3sNOqeIIv/Vl/fJwyOPqr9kjjEOpB+CTOKkWNCLrKLAfEO
	mhO7EOBhOisXifeWjGEMLNEZAwzsynvoaukABbMuC3cVygZms4jTvV8zS4st9WSSTjXD
	o/tA==
ARC-Authentication-Results: i=2; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=Q7mS9TBz;
	spf=pass (google.com: domain of jagan@amarulasolutions.com designates
	209.85.220.41 as permitted sender)
	smtp.mailfrom=jagan@amarulasolutions.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=amarulasolutions.com; s=google;
	h=from:to:cc:subject:date:message-id:in-reply-to:references
	:mime-version:x-original-sender:x-original-authentication-results
	:precedence:mailing-list:list-id:list-post:list-help:list-archive
	:list-unsubscribe;
	bh=mdzGhfxfgZiyiOQRrr4uE6JADbPttUDb6C1TlIgorpQ=;
	b=L7lwxxYJzK7jicd1QVX90zGeoXkIHCAg38ZnHJuj9C/rh8Ye0x5gbucUIL+tjSiici
	Z/6DycThmSZ83unSYQcQ4k6FgxbNtdg6b0jcxWJ7UK/2mXovQQYynyf7xN9Q58wg1NSP
	bbwQ1FhJ8ZH96fpvaSwa/bu0yCY2lsVcOUr2Q=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20210112;
	h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
	:references:mime-version:x-original-sender
	:x-original-authentication-results:precedence:mailing-list:list-id
	:x-spam-checked-in-group:list-post:list-help:list-archive
	:list-unsubscribe;
	bh=mdzGhfxfgZiyiOQRrr4uE6JADbPttUDb6C1TlIgorpQ=;
	b=3X3wE1+x+1SiAAvE0nwraWHmApJype0o41ZWiqu8DGC8VZDHWPfHiJFKSZu53Utrqp
	fMt58m5WD/WvA6yINKQSb/DnhcKF9YUvlQJi3IDpFR8ZbSPY6ysDq4nkAbRN98Wz93Hk
	jC4WvZa62r+5X3fjXM00yH7ZaU8r2HlH4BH78ezAj7y+HaWM28FU34ae3AQKh9XDCGgy
	hcr0Bx2Nt7Wb+sgLPlEgK7rtt16qtxTS4MKIoDbGU61hWlJVkck26Pzt9PCmS4jaRI0m
	DVo37zQ0GAyYMoHdmwSLe0eRl5b7qMXtlaB3x6gSBEPfqPDp5ujfdSiwsgnQgN/zCVEI
	2l4w==
X-Gm-Message-State: AOAM532E1UvgkdJ3vXF1TiiG4nU5cPsNe+RewgPYgGg902trkLV7ok/i
	3cEx44oxdDPSOTa/ANS+Xq9iZfzH
X-Google-Smtp-Source: 
 ABdhPJxeMshwg0m5+N1f+GsRv/anyt0PYLBg8cj9NoPC/6ztxqWkJkNOEurmxq3DRuFMiKzDuv6t2w==
X-Received: by 2002:a17:902:6941:b0:14c:b815:6d45 with SMTP id
	k1-20020a170902694100b0014cb8156d45mr37648293plt.49.1646325487344;
	Thu, 03 Mar 2022 08:38:07 -0800 (PST)
X-BeenThere: linux-amarula@amarulasolutions.com
Received: by 2002:a17:902:ff0f:b0:151:a570:297a with SMTP id
	f15-20020a170902ff0f00b00151a570297als2516584plj.0.gmail;
	Thu, 03 Mar 2022 08:38:06 -0800 (PST)
X-Received: by 2002:a17:90a:8c86:b0:1bb:fbfc:49cf with SMTP id
	b6-20020a17090a8c8600b001bbfbfc49cfmr6237525pjo.80.1646325486464;
	Thu, 03 Mar 2022 08:38:06 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1646325486; cv=none;
	d=google.com; s=arc-20160816;
	b=edzH3C2SSdPebXU5Rt7h1L2XphfvTCRpPgEKRZ1Eo6FBp8r1yiV5qI8T7omMijtN7p
	lrBJzIsh6mVbq02XYCUicrxRBh6I0PpiFz1rUe4MLu28PeaEaoe0oq4aDM0r2PzMzOiw
	469Rs5ml72G9tKibODQpIBOYpL9oCHtMqRx/bqulNWfvFuuL9QEjv8xZFhfZBziE85Wr
	AlIFQKQ2qDp1LJOwRLJ44im1dlK487iexhm/C6MHdSaFNOnOVLbmdYApRT+3a28bp+CM
	TbzakpTVNl1cAo7cTiX9ORhZcXKfJuBKPoe5rNrHHFH8o+HjdIAp0CNyfkb/27FJ45w2
	Dg6g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=content-transfer-encoding:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=oCoF5MNpfuxI3cBKtQYePj3PhXTndQKRGc6x152fDqQ=;
	b=MEXegB45WIarD4dchrmUQ3bNPmVlykiVDS73U3yf/JQL4ORLT4xP3knecBrbF3mRLM
	a81xjuAqrhhcm6Be79nEwDRqBxQklUwTafoXzGOIojOKg1yCWzJ5/glhCXGEM3daH9Rl
	1Ipys1kXmm33O58c3rNx0c3dz7YdgdzqYUztK0x4Ihah2kYa8ggVfzzp59aLfAqayCxX
	a00MmRihyJ2KYlcAql5xGlwrjIzYEZO8fwNdwXd8pisXvmWSgxtmE+7byCwB/I++Gw9P
	1nHbGKPT0cZ9m5JkRqhPjHMPmRG3oRo0giUKhMd7e5zMoNvRUFHTLfRApcaVQ6BF1kef
	ZX7g==
ARC-Authentication-Results: i=1; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=Q7mS9TBz;
	spf=pass (google.com: domain of jagan@amarulasolutions.com designates
	209.85.220.41 as permitted sender)
	smtp.mailfrom=jagan@amarulasolutions.com
Received: from mail-sor-f41.google.com (mail-sor-f41.google.com.
	[209.85.220.41]) by mx.google.com with SMTPS id
	j5-20020a17090276c500b0014fe92899b2sor10000032plt.98.2022.03.03.08.38.06
	for <linux-amarula@amarulasolutions.com>
	(Google Transport Security); Thu, 03 Mar 2022 08:38:06 -0800 (PST)
Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	client-ip=209.85.220.41;
X-Received: by 2002:a17:90a:4604:b0:1bc:8bdd:4a63 with SMTP id
	w4-20020a17090a460400b001bc8bdd4a63mr6155141pjg.147.1646325486083;
	Thu, 03 Mar 2022 08:38:06 -0800 (PST)
Received: from localhost.localdomain
	([2405:201:c00a:a0a9:4526:5253:a010:63f4])
	by smtp.gmail.com with ESMTPSA id
	j20-20020a056a00235400b004e192221ec2sm3220983pfj.14.2022.03.03.08.37.54
	(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
	Thu, 03 Mar 2022 08:38:05 -0800 (PST)
From: Jagan Teki <jagan@amarulasolutions.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Robert Foss <robert.foss@linaro.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	Inki Dae <inki.dae@samsung.com>
Cc: dri-devel@lists.freedesktop.org, linux-amarula@amarulasolutions.com,
	Jagan Teki <jagan@amarulasolutions.com>
Subject: [PATCH v6 4/6] drm: exynos: dsi: Use drm panel_bridge API
Date: Thu,  3 Mar 2022 22:06:52 +0530
Message-Id: <20220303163654.3381470-5-jagan@amarulasolutions.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220303163654.3381470-1-jagan@amarulasolutions.com>
References: <20220303163654.3381470-1-jagan@amarulasolutions.com>
MIME-Version: 1.0
X-Original-Sender: jagan@amarulasolutions.com
X-Original-Authentication-Results: mx.google.com;       dkim=pass
	header.i=@amarulasolutions.com header.s=google header.b=Q7mS9TBz;
	spf=pass (google.com: domain of jagan@amarulasolutions.com designates
	209.85.220.41 as permitted sender)
	smtp.mailfrom=jagan@amarulasolutions.com
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Mailing-list: list linux-amarula@amarulasolutions.com;
	contact linux-amarula+owners@amarulasolutions.com
List-ID: <linux-amarula.amarulasolutions.com>
X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com
X-Google-Group-Id: 476853432473
List-Post: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>,
	<mailto:linux-amarula@amarulasolutions.com>
List-Help: 
 <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>,
	<mailto:linux-amarula+help@amarulasolutions.com>
List-Archive: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/>
List-Unsubscribe: 
 <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>,
	<https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe>

Replace the manual panel handling code by a drm panel_bridge via
devm_drm_of_get_bridge().

Adding panel_bridge handling,

- Drops drm_connector and related operations as drm_bridge_attach
  creates connector during attachment.

- Drops panel pointer and iterate the bridge, so-that it can operate
  the normal bridge and panel_bridge in constitutive callbacks.

This simplifies the driver and allows all components in the display
pipeline to be treated as bridges.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
Changes for v6, v5:
- none
Changes for v4:
- drop unneeded headers
Changes for v3:
- fix port number
- add print for attached device
Changes for v2:
- new patch

 drivers/gpu/drm/exynos/exynos_drm_dsi.c | 157 ++++--------------------
 1 file changed, 23 insertions(+), 134 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 741c046513e8..953094133ed8 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -24,9 +24,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_mipi_dsi.h>
-#include <drm/drm_panel.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>
@@ -253,8 +251,6 @@ struct exynos_dsi_driver_data {
 struct exynos_dsi {
 	struct drm_encoder encoder;
 	struct mipi_dsi_host dsi_host;
-	struct drm_connector connector;
-	struct drm_panel *panel;
 	struct list_head bridge_chain;
 	struct drm_bridge *out_bridge;
 	struct device *dev;
@@ -285,7 +281,6 @@ struct exynos_dsi {
 };
 
 #define host_to_dsi(host) container_of(host, struct exynos_dsi, dsi_host)
-#define connector_to_dsi(c) container_of(c, struct exynos_dsi, connector)
 
 static inline struct exynos_dsi *encoder_to_dsi(struct drm_encoder *e)
 {
@@ -1380,42 +1375,21 @@ static void exynos_dsi_enable(struct drm_encoder *encoder)
 
 	dsi->state |= DSIM_STATE_ENABLED;
 
-	if (dsi->panel) {
-		ret = drm_panel_prepare(dsi->panel);
-		if (ret < 0)
-			goto err_put_sync;
-	} else {
-		list_for_each_entry_reverse(iter, &dsi->bridge_chain,
-					    chain_node) {
-			if (iter->funcs->pre_enable)
-				iter->funcs->pre_enable(iter);
-		}
+	list_for_each_entry_reverse(iter, &dsi->bridge_chain, chain_node) {
+		if (iter->funcs->pre_enable)
+			iter->funcs->pre_enable(iter);
 	}
 
 	exynos_dsi_set_display_mode(dsi);
 	exynos_dsi_set_display_enable(dsi, true);
 
-	if (dsi->panel) {
-		ret = drm_panel_enable(dsi->panel);
-		if (ret < 0)
-			goto err_display_disable;
-	} else {
-		list_for_each_entry(iter, &dsi->bridge_chain, chain_node) {
-			if (iter->funcs->enable)
-				iter->funcs->enable(iter);
-		}
+	list_for_each_entry(iter, &dsi->bridge_chain, chain_node) {
+		if (iter->funcs->enable)
+			iter->funcs->enable(iter);
 	}
 
 	dsi->state |= DSIM_STATE_VIDOUT_AVAILABLE;
 	return;
-
-err_display_disable:
-	exynos_dsi_set_display_enable(dsi, false);
-	drm_panel_unprepare(dsi->panel);
-
-err_put_sync:
-	dsi->state &= ~DSIM_STATE_ENABLED;
-	pm_runtime_put(dsi->dev);
 }
 
 static void exynos_dsi_disable(struct drm_encoder *encoder)
@@ -1428,15 +1402,12 @@ static void exynos_dsi_disable(struct drm_encoder *encoder)
 
 	dsi->state &= ~DSIM_STATE_VIDOUT_AVAILABLE;
 
-	drm_panel_disable(dsi->panel);
-
 	list_for_each_entry_reverse(iter, &dsi->bridge_chain, chain_node) {
 		if (iter->funcs->disable)
 			iter->funcs->disable(iter);
 	}
 
 	exynos_dsi_set_display_enable(dsi, false);
-	drm_panel_unprepare(dsi->panel);
 
 	list_for_each_entry(iter, &dsi->bridge_chain, chain_node) {
 		if (iter->funcs->post_disable)
@@ -1456,70 +1427,6 @@ static void exynos_dsi_mode_set(struct drm_encoder *encoder,
 	drm_mode_copy(&dsi->mode, adjusted_mode);
 }
 
-static enum drm_connector_status
-exynos_dsi_detect(struct drm_connector *connector, bool force)
-{
-	return connector->status;
-}
-
-static void exynos_dsi_connector_destroy(struct drm_connector *connector)
-{
-	drm_connector_unregister(connector);
-	drm_connector_cleanup(connector);
-	connector->dev = NULL;
-}
-
-static const struct drm_connector_funcs exynos_dsi_connector_funcs = {
-	.detect = exynos_dsi_detect,
-	.fill_modes = drm_helper_probe_single_connector_modes,
-	.destroy = exynos_dsi_connector_destroy,
-	.reset = drm_atomic_helper_connector_reset,
-	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
-	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
-};
-
-static int exynos_dsi_get_modes(struct drm_connector *connector)
-{
-	struct exynos_dsi *dsi = connector_to_dsi(connector);
-
-	if (dsi->panel)
-		return drm_panel_get_modes(dsi->panel, connector);
-
-	return 0;
-}
-
-static const struct drm_connector_helper_funcs exynos_dsi_connector_helper_funcs = {
-	.get_modes = exynos_dsi_get_modes,
-};
-
-static int exynos_dsi_create_connector(struct drm_encoder *encoder)
-{
-	struct exynos_dsi *dsi = encoder_to_dsi(encoder);
-	struct drm_connector *connector = &dsi->connector;
-	struct drm_device *drm = encoder->dev;
-	int ret;
-
-	connector->polled = DRM_CONNECTOR_POLL_HPD;
-
-	ret = drm_connector_init(drm, connector, &exynos_dsi_connector_funcs,
-				 DRM_MODE_CONNECTOR_DSI);
-	if (ret) {
-		DRM_DEV_ERROR(dsi->dev,
-			      "Failed to initialize connector with drm\n");
-		return ret;
-	}
-
-	connector->status = connector_status_disconnected;
-	drm_connector_helper_add(connector, &exynos_dsi_connector_helper_funcs);
-	drm_connector_attach_encoder(connector, encoder);
-	if (!drm->registered)
-		return 0;
-
-	connector->funcs->reset(connector);
-	drm_connector_register(connector);
-	return 0;
-}
-
 static const struct drm_encoder_helper_funcs exynos_dsi_encoder_helper_funcs = {
 	.enable = exynos_dsi_enable,
 	.disable = exynos_dsi_disable,
@@ -1532,33 +1439,23 @@ static int exynos_dsi_host_attach(struct mipi_dsi_host *host,
 				  struct mipi_dsi_device *device)
 {
 	struct exynos_dsi *dsi = host_to_dsi(host);
+	struct device *dev = dsi->dev;
 	struct drm_encoder *encoder = &dsi->encoder;
 	struct drm_device *drm = encoder->dev;
-	struct drm_bridge *out_bridge;
-
-	out_bridge  = of_drm_find_bridge(device->dev.of_node);
-	if (out_bridge) {
-		drm_bridge_attach(encoder, out_bridge, NULL, 0);
-		dsi->out_bridge = out_bridge;
-		list_splice_init(&encoder->bridge_chain, &dsi->bridge_chain);
-	} else {
-		int ret = exynos_dsi_create_connector(encoder);
-
-		if (ret) {
-			DRM_DEV_ERROR(dsi->dev,
-				      "failed to create connector ret = %d\n",
-				      ret);
-			drm_encoder_cleanup(encoder);
-			return ret;
-		}
+	int ret;
 
-		dsi->panel = of_drm_find_panel(device->dev.of_node);
-		if (IS_ERR(dsi->panel))
-			dsi->panel = NULL;
-		else
-			dsi->connector.status = connector_status_connected;
+	dsi->out_bridge = devm_drm_of_get_bridge(dev, dev->of_node, 1, 0);
+	if (IS_ERR(dsi->out_bridge)) {
+		ret = PTR_ERR(dsi->out_bridge);
+		DRM_DEV_ERROR(dev, "failed to find the bridge: %d\n", ret);
+		return ret;
 	}
 
+	DRM_DEV_INFO(dev, "Attached %s device\n", device->name);
+
+	drm_bridge_attach(encoder, dsi->out_bridge, NULL, 0);
+	list_splice_init(&encoder->bridge_chain, &dsi->bridge_chain);
+
 	/*
 	 * This is a temporary solution and should be made by more generic way.
 	 *
@@ -1566,7 +1463,7 @@ static int exynos_dsi_host_attach(struct mipi_dsi_host *host,
 	 * TE interrupt handler.
 	 */
 	if (!(device->mode_flags & MIPI_DSI_MODE_VIDEO)) {
-		int ret = exynos_dsi_register_te_irq(dsi, &device->dev);
+		ret = exynos_dsi_register_te_irq(dsi, &device->dev);
 		if (ret)
 			return ret;
 	}
@@ -1593,18 +1490,10 @@ static int exynos_dsi_host_detach(struct mipi_dsi_host *host,
 	struct exynos_dsi *dsi = host_to_dsi(host);
 	struct drm_device *drm = dsi->encoder.dev;
 
-	if (dsi->panel) {
-		mutex_lock(&drm->mode_config.mutex);
-		exynos_dsi_disable(&dsi->encoder);
-		dsi->panel = NULL;
-		dsi->connector.status = connector_status_disconnected;
-		mutex_unlock(&drm->mode_config.mutex);
-	} else {
-		if (dsi->out_bridge->funcs->detach)
-			dsi->out_bridge->funcs->detach(dsi->out_bridge);
-		dsi->out_bridge = NULL;
-		INIT_LIST_HEAD(&dsi->bridge_chain);
-	}
+	if (dsi->out_bridge->funcs->detach)
+		dsi->out_bridge->funcs->detach(dsi->out_bridge);
+	dsi->out_bridge = NULL;
+	INIT_LIST_HEAD(&dsi->bridge_chain);
 
 	if (drm->mode_config.poll_enabled)
 		drm_kms_helper_hotplug_event(drm);

From patchwork Thu Mar  3 16:36:53 2022
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Jagan Teki <jagan@amarulasolutions.com>
X-Patchwork-Id: 1859
Return-Path: 
 <linux-amarula+bncBD7MFH7A7EEBB6O5QOIQMGQENPTE5KQ@amarulasolutions.com>
X-Original-To: linux-amarula@patchwork.amarulasolutions.com
Delivered-To: linux-amarula@patchwork.amarulasolutions.com
Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com
	[209.85.210.199])
	by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 95A673F236
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Thu,  3 Mar 2022 17:38:18 +0100 (CET)
Received: by mail-pf1-f199.google.com with SMTP id
	i72-20020a62874b000000b004f66c5b963csf1704771pfe.6
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Thu, 03 Mar 2022 08:38:18 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1646325497; cv=pass;
	d=google.com; s=arc-20160816;
	b=YHWSCdVkN3hvfP5qXgl/kjvzRspnbCmi7ZYbQp7Z5oQafABUSfhtAc9g5ULB7H+jLI
	b2OnQPFL/pvlH97qCVF1Pt44sQ1G6kw2CvkBkoTDpPeqFZil8cObNAQRGezwhcPNTV8M
	Q+GQyYoQiMn0eP8qoZhm8FsCSbesRj99WKcysJZSNUrXcjz8RblKPN/RKL6Y6RzyTLGx
	dYnhaW82R8SOEbO8b4WYGB3w7Z4fQSgEcVlHHzCDNoeRT+QnrMIH00M1yVYHsJ8f4Igz
	dn+TQJ6Ibblmh115PnmzKWExM+IO944lrnqXohX+OKMGTkIx7iCyTRa/QfoJbrH6YeUi
	W5Rw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=nGrbjhhOrsTacb4YI1NsRTdux0AC+GzaNZ2/VsA3hY8=;
	b=LZFLH7RIliFbJo/WjGxB6IqOBgaHMEFJmOJ/OzvL6f9pnf4Ujp8CAD9jn0RWM+bDmB
	LBIS22shHKclYdO5fLKrp6DJaKyr1CKJpotohLAr+AWtTYDB+NijLm/1evN8KuXA2AT6
	onXMYJCMtsb3Ugtjec+1NEPjh7Z7Hm93RZoQvDEBRQogq7wwBYHF2WEd7yUJdtkDPa2b
	RE5eSDOFvuleCRqgx8v6Y3Uq8tiERsT2kGX9FF25oc8cfEa62MMpY9130GxqhCZ/4vt3
	sfn44SZlkCK4OKI9K/UZKC7+TFAoj2aN15aRg29fhOo+hXpukHHMzIC7748mnzkOvnR7
	MhZw==
ARC-Authentication-Results: i=2; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=N71k2Qgd;
	spf=pass (google.com: domain of jagan@amarulasolutions.com designates
	209.85.220.41 as permitted sender)
	smtp.mailfrom=jagan@amarulasolutions.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=amarulasolutions.com; s=google;
	h=from:to:cc:subject:date:message-id:in-reply-to:references
	:mime-version:x-original-sender:x-original-authentication-results
	:precedence:mailing-list:list-id:list-post:list-help:list-archive
	:list-unsubscribe;
	bh=nGrbjhhOrsTacb4YI1NsRTdux0AC+GzaNZ2/VsA3hY8=;
	b=j2FJATPvDoVBF9tw5UaAA/Dpz+LEBJ6H9ijacnQZhGnCzuoku/2cV1oFNLe+pCL65k
	7Z8lX5sCtEQ1CAbZdlEUWZza2n08x+0pqMnbHMs39hW3puOF/FJwLeN18lYo34J3czP+
	z1YvouWn8bfEcAt30l4tRxAT4rbj2n9lawUoc=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20210112;
	h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
	:references:mime-version:x-original-sender
	:x-original-authentication-results:precedence:mailing-list:list-id
	:x-spam-checked-in-group:list-post:list-help:list-archive
	:list-unsubscribe;
	bh=nGrbjhhOrsTacb4YI1NsRTdux0AC+GzaNZ2/VsA3hY8=;
	b=fCOSnAvMkmq1K5eAFxVaCzh7qGYwU3Ce4ubWmPAYfwDgs8+zPAGVafBB7hGryR5hro
	QXCxxAzFmTt3KQfOPtgoAQszrBQbDucB5d5yorF5YPkQLbaBhyb90mA5sqrVLuoKT40U
	DLC9wRVZX1ZCa8f9vhn8IhIK3EIBhOCeZsOQ0r0MZFID0amGvJsm/ZasjRN+LX6c/VsA
	X6b8V28g8MAzJCl/z6qG8h4AOhBKQizfASEdTOqF+xp6720awphAqaCOW+AV7hkIZ81E
	+CJGTIO7ISIfLQXBMg6v1paCgGfxFdsOfW5AeEifvoQJp13Omy+wjGGREMWb0X+OOhMB
	p9VA==
X-Gm-Message-State: AOAM530vgBX3Zf0cucCdU1NUyjXC8Ap7JRGkZoE8wCNL1b8gKep9brDN
	2H0N+a0UGi4UptQhaNko7niPATvC
X-Google-Smtp-Source: 
 ABdhPJw/+kKmUy/vdYglnwoYR/l1W7zAvaQk82qzD//dbGVF9rN92ltVCX63WBjb5ADJHSttG7yV0g==
X-Received: by 2002:a63:be0e:0:b0:363:e0be:613f with SMTP id
	l14-20020a63be0e000000b00363e0be613fmr30609974pgf.448.1646325497349;
	Thu, 03 Mar 2022 08:38:17 -0800 (PST)
X-BeenThere: linux-amarula@amarulasolutions.com
Received: by 2002:a62:54c1:0:b0:4e0:1a99:c74b with SMTP id
	i184-20020a6254c1000000b004e01a99c74bls1348132pfb.3.gmail;
	Thu, 03 Mar 2022 08:38:16 -0800 (PST)
X-Received: by 2002:a62:644a:0:b0:4f6:a2e6:c706 with SMTP id
	y71-20020a62644a000000b004f6a2e6c706mr1333452pfb.42.1646325496390;
	Thu, 03 Mar 2022 08:38:16 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1646325496; cv=none;
	d=google.com; s=arc-20160816;
	b=0s+s3bM7NoA3rrsSfLKbpHF3kmGtKK6IhISZdOqUXARf5j92z6rPptFY/Bclx84CIc
	l1HxVEFD79ILX+3s8dst82inso0TyxEn45o28UUB235bmWe/4H4UBBdZjVLdBIzBnm1X
	OGmTTq8girfn5+EYR1D6y7Z2o+VlPYJu42lJ4tsm++D2pxpGGRLtUfXQuNRCU4+TfDOJ
	NsKaDRDMNfRhjK90AB+3nhpMz04xJcciUj3hXuAv9bvTK85/s8I2SwEOJMkAPjLrtswD
	3s1tx3+CMpDWYKeGFDAoHAIUA+hKWSSSkENwE8uKlxY10U9yUpkEpt9e75ea7wlL8y6w
	xibA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=content-transfer-encoding:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=CKZoe4JiEp2MmbPOTfnaYpdtxIogdQhsVfZjlkmH+tI=;
	b=yD/9m4AuXqtiIsU++xSrbKtzU6b4lrbn5ndzhf70nPKxs5gRHdMTNvg30VhJIvrSx+
	ESLe4U0Ls5I2Cg1QT4NxpPF8a6lSWXdZT9SeldS+soEOY6Y/OibdHpiKHEAdVTJsQDyF
	pSfSkTmNvrpZbN/A5mKAthyp2NAvC6BCHzSAMY1kfHLz43oWlXUGamU9ck6XMyCFbodF
	o+M7nCKx8ZsJXxUUDAZ94NXh+q7l7LxZ9tfA+GK4XWGzz5bPr+/3slEkRAPtAsolQhV+
	EtlTFDgMtalDmYzskqI43tPebvTEVz59XhCH7d4TA1usV+861p66SwmNJWxhvBrIGdvN
	B1+A==
ARC-Authentication-Results: i=1; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=N71k2Qgd;
	spf=pass (google.com: domain of jagan@amarulasolutions.com designates
	209.85.220.41 as permitted sender)
	smtp.mailfrom=jagan@amarulasolutions.com
Received: from mail-sor-f41.google.com (mail-sor-f41.google.com.
	[209.85.220.41]) by mx.google.com with SMTPS id
	l1-20020a056a0016c100b004f3bc62a693sor10425490pfc.66.2022.03.03.08.38.16
	for <linux-amarula@amarulasolutions.com>
	(Google Transport Security); Thu, 03 Mar 2022 08:38:16 -0800 (PST)
Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	client-ip=209.85.220.41;
X-Received: by 2002:a05:6a00:23d4:b0:4c9:f1b6:8e97 with SMTP id
	g20-20020a056a0023d400b004c9f1b68e97mr38751714pfc.27.1646325496017;
	Thu, 03 Mar 2022 08:38:16 -0800 (PST)
Received: from localhost.localdomain
	([2405:201:c00a:a0a9:4526:5253:a010:63f4])
	by smtp.gmail.com with ESMTPSA id
	j20-20020a056a00235400b004e192221ec2sm3220983pfj.14.2022.03.03.08.38.06
	(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
	Thu, 03 Mar 2022 08:38:15 -0800 (PST)
From: Jagan Teki <jagan@amarulasolutions.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Robert Foss <robert.foss@linaro.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	Inki Dae <inki.dae@samsung.com>
Cc: dri-devel@lists.freedesktop.org, linux-amarula@amarulasolutions.com,
	Jagan Teki <jagan@amarulasolutions.com>
Subject: [PATCH v6 5/6] drm: exynos: dsi: Convert to bridge driver
Date: Thu,  3 Mar 2022 22:06:53 +0530
Message-Id: <20220303163654.3381470-6-jagan@amarulasolutions.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220303163654.3381470-1-jagan@amarulasolutions.com>
References: <20220303163654.3381470-1-jagan@amarulasolutions.com>
MIME-Version: 1.0
X-Original-Sender: jagan@amarulasolutions.com
X-Original-Authentication-Results: mx.google.com;       dkim=pass
	header.i=@amarulasolutions.com header.s=google header.b=N71k2Qgd;
	spf=pass (google.com: domain of jagan@amarulasolutions.com designates
	209.85.220.41 as permitted sender)
	smtp.mailfrom=jagan@amarulasolutions.com
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Mailing-list: list linux-amarula@amarulasolutions.com;
	contact linux-amarula+owners@amarulasolutions.com
List-ID: <linux-amarula.amarulasolutions.com>
X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com
X-Google-Group-Id: 476853432473
List-Post: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>,
	<mailto:linux-amarula@amarulasolutions.com>
List-Help: 
 <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>,
	<mailto:linux-amarula+help@amarulasolutions.com>
List-Archive: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/>
List-Unsubscribe: 
 <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>,
	<https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe>

Convert the encoders to bridge drivers in order to standardize on
a single API with built-in dumb encoder support for compatibility
with existing component drivers.

Driver bridge conversion will help to reuse the same bridge on
different platforms as exynos dsi driver can be used as a Samsung
DSIM and use it for i.MX8MM platform.

Bridge conversion,

- Drops drm_encoder_helper_funcs.

- Adds drm_bridge_funcs and register a drm bridge.

- Drops bridge_chain.

- Separate pre_enable from enable function.

- Separate post_disable from disable function.

Convert it.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
Changes for v6, v5:
- none
Changes for v4:
- add pre_enable function
- add post_disable function
Changes for v3:
- move bridge add in host_attach
- move bridge remove in host_detach
- use flags, bridge in drm_bridge_attach in attch 
Changes for v2:
- drop bridge_chain

 drivers/gpu/drm/exynos/exynos_drm_dsi.c | 88 +++++++++++++------------
 1 file changed, 45 insertions(+), 43 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 953094133ed8..59a4f7f52180 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -251,7 +251,7 @@ struct exynos_dsi_driver_data {
 struct exynos_dsi {
 	struct drm_encoder encoder;
 	struct mipi_dsi_host dsi_host;
-	struct list_head bridge_chain;
+	struct drm_bridge bridge;
 	struct drm_bridge *out_bridge;
 	struct device *dev;
 	struct drm_display_mode mode;
@@ -282,9 +282,9 @@ struct exynos_dsi {
 
 #define host_to_dsi(host) container_of(host, struct exynos_dsi, dsi_host)
 
-static inline struct exynos_dsi *encoder_to_dsi(struct drm_encoder *e)
+static inline struct exynos_dsi *bridge_to_dsi(struct drm_bridge *b)
 {
-	return container_of(e, struct exynos_dsi, encoder);
+	return container_of(b, struct exynos_dsi, bridge);
 }
 
 enum reg_idx {
@@ -1358,10 +1358,9 @@ static void exynos_dsi_unregister_te_irq(struct exynos_dsi *dsi)
 	}
 }
 
-static void exynos_dsi_enable(struct drm_encoder *encoder)
+static void exynos_dsi_pre_enable(struct drm_bridge *bridge)
 {
-	struct exynos_dsi *dsi = encoder_to_dsi(encoder);
-	struct drm_bridge *iter;
+	struct exynos_dsi *dsi = bridge_to_dsi(bridge);
 	int ret;
 
 	if (dsi->state & DSIM_STATE_ENABLED)
@@ -1374,63 +1373,64 @@ static void exynos_dsi_enable(struct drm_encoder *encoder)
 	}
 
 	dsi->state |= DSIM_STATE_ENABLED;
+}
 
-	list_for_each_entry_reverse(iter, &dsi->bridge_chain, chain_node) {
-		if (iter->funcs->pre_enable)
-			iter->funcs->pre_enable(iter);
-	}
+static void exynos_dsi_enable(struct drm_bridge *bridge)
+{
+	struct exynos_dsi *dsi = bridge_to_dsi(bridge);
 
 	exynos_dsi_set_display_mode(dsi);
 	exynos_dsi_set_display_enable(dsi, true);
 
-	list_for_each_entry(iter, &dsi->bridge_chain, chain_node) {
-		if (iter->funcs->enable)
-			iter->funcs->enable(iter);
-	}
-
 	dsi->state |= DSIM_STATE_VIDOUT_AVAILABLE;
+
 	return;
 }
 
-static void exynos_dsi_disable(struct drm_encoder *encoder)
+static void exynos_dsi_disable(struct drm_bridge *bridge)
 {
-	struct exynos_dsi *dsi = encoder_to_dsi(encoder);
-	struct drm_bridge *iter;
+	struct exynos_dsi *dsi = bridge_to_dsi(bridge);
 
 	if (!(dsi->state & DSIM_STATE_ENABLED))
 		return;
 
 	dsi->state &= ~DSIM_STATE_VIDOUT_AVAILABLE;
+}
 
-	list_for_each_entry_reverse(iter, &dsi->bridge_chain, chain_node) {
-		if (iter->funcs->disable)
-			iter->funcs->disable(iter);
-	}
+static void exynos_dsi_post_disable(struct drm_bridge *bridge)
+{
+	struct exynos_dsi *dsi = bridge_to_dsi(bridge);
 
 	exynos_dsi_set_display_enable(dsi, false);
 
-	list_for_each_entry(iter, &dsi->bridge_chain, chain_node) {
-		if (iter->funcs->post_disable)
-			iter->funcs->post_disable(iter);
-	}
-
 	dsi->state &= ~DSIM_STATE_ENABLED;
 	pm_runtime_put_sync(dsi->dev);
 }
 
-static void exynos_dsi_mode_set(struct drm_encoder *encoder,
-				struct drm_display_mode *mode,
-				struct drm_display_mode *adjusted_mode)
+static void exynos_dsi_mode_set(struct drm_bridge *bridge,
+				const struct drm_display_mode *mode,
+				const struct drm_display_mode *adjusted_mode)
 {
-	struct exynos_dsi *dsi = encoder_to_dsi(encoder);
+	struct exynos_dsi *dsi = bridge_to_dsi(bridge);
 
 	drm_mode_copy(&dsi->mode, adjusted_mode);
 }
 
-static const struct drm_encoder_helper_funcs exynos_dsi_encoder_helper_funcs = {
-	.enable = exynos_dsi_enable,
-	.disable = exynos_dsi_disable,
-	.mode_set = exynos_dsi_mode_set,
+static int exynos_dsi_attach(struct drm_bridge *bridge,
+			     enum drm_bridge_attach_flags flags)
+{
+	struct exynos_dsi *dsi = bridge_to_dsi(bridge);
+
+	return drm_bridge_attach(bridge->encoder, dsi->out_bridge, NULL, flags);
+}
+
+static const struct drm_bridge_funcs exynos_dsi_bridge_funcs = {
+	.pre_enable			= exynos_dsi_pre_enable,
+	.enable				= exynos_dsi_enable,
+	.disable			= exynos_dsi_disable,
+	.post_disable			= exynos_dsi_post_disable,
+	.mode_set			= exynos_dsi_mode_set,
+	.attach				= exynos_dsi_attach,
 };
 
 MODULE_DEVICE_TABLE(of, exynos_dsi_of_match);
@@ -1453,8 +1453,9 @@ static int exynos_dsi_host_attach(struct mipi_dsi_host *host,
 
 	DRM_DEV_INFO(dev, "Attached %s device\n", device->name);
 
-	drm_bridge_attach(encoder, dsi->out_bridge, NULL, 0);
-	list_splice_init(&encoder->bridge_chain, &dsi->bridge_chain);
+	drm_bridge_add(&dsi->bridge);
+
+	drm_bridge_attach(encoder, &dsi->bridge, NULL, 0);
 
 	/*
 	 * This is a temporary solution and should be made by more generic way.
@@ -1493,13 +1494,14 @@ static int exynos_dsi_host_detach(struct mipi_dsi_host *host,
 	if (dsi->out_bridge->funcs->detach)
 		dsi->out_bridge->funcs->detach(dsi->out_bridge);
 	dsi->out_bridge = NULL;
-	INIT_LIST_HEAD(&dsi->bridge_chain);
 
 	if (drm->mode_config.poll_enabled)
 		drm_kms_helper_hotplug_event(drm);
 
 	exynos_dsi_unregister_te_irq(dsi);
 
+	drm_bridge_remove(&dsi->bridge);
+
 	return 0;
 }
 
@@ -1583,8 +1585,6 @@ static int exynos_dsi_bind(struct device *dev, struct device *master,
 
 	drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_TMDS);
 
-	drm_encoder_helper_add(encoder, &exynos_dsi_encoder_helper_funcs);
-
 	ret = exynos_drm_set_possible_crtcs(encoder, EXYNOS_DISPLAY_TYPE_LCD);
 	if (ret < 0)
 		return ret;
@@ -1596,9 +1596,8 @@ static void exynos_dsi_unbind(struct device *dev, struct device *master,
 				void *data)
 {
 	struct exynos_dsi *dsi = dev_get_drvdata(dev);
-	struct drm_encoder *encoder = &dsi->encoder;
 
-	exynos_dsi_disable(encoder);
+	exynos_dsi_disable(&dsi->bridge);
 
 	mipi_dsi_host_unregister(&dsi->dsi_host);
 }
@@ -1621,7 +1620,6 @@ static int exynos_dsi_probe(struct platform_device *pdev)
 	init_completion(&dsi->completed);
 	spin_lock_init(&dsi->transfer_lock);
 	INIT_LIST_HEAD(&dsi->transfer_list);
-	INIT_LIST_HEAD(&dsi->bridge_chain);
 
 	dsi->dsi_host.ops = &exynos_dsi_ops;
 	dsi->dsi_host.dev = dev;
@@ -1689,6 +1687,10 @@ static int exynos_dsi_probe(struct platform_device *pdev)
 
 	pm_runtime_enable(dev);
 
+	dsi->bridge.funcs = &exynos_dsi_bridge_funcs;
+	dsi->bridge.of_node = dev->of_node;
+	dsi->bridge.type = DRM_MODE_CONNECTOR_DSI;
+
 	ret = component_add(dev, &exynos_dsi_component_ops);
 	if (ret)
 		goto err_disable_runtime;

From patchwork Thu Mar  3 16:36:54 2022
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Jagan Teki <jagan@amarulasolutions.com>
X-Patchwork-Id: 1860
Return-Path: 
 <linux-amarula+bncBD7MFH7A7EEBBA66QOIQMGQEYUKD56A@amarulasolutions.com>
X-Original-To: linux-amarula@patchwork.amarulasolutions.com
Delivered-To: linux-amarula@patchwork.amarulasolutions.com
Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com
	[209.85.210.199])
	by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 34A603F236
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Thu,  3 Mar 2022 17:38:29 +0100 (CET)
Received: by mail-pf1-f199.google.com with SMTP id
	v127-20020a622f85000000b004f3dfd386e8sf3449988pfv.16
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Thu, 03 Mar 2022 08:38:29 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1646325508; cv=pass;
	d=google.com; s=arc-20160816;
	b=mnysilQslmgcF58eInFeqFas7fPxuwbTHfQmIV9lLA6xCMwwCjECy0gizte9J1wDm+
	6jjuow6eDenBJmLT11PQ+0MpVhFamspvwzXD9yDy6mZf8goC79ZMzdbLgGlAwePlg8g8
	HbqZkA2tt1+88uWTSZhCV55CPryvhqO+HuPk5XXBkFUgZHPMjXExvvIqpLrBmyV36cTz
	3wkgQSDu5vmvbXAI7lCNR2zB5xRGNw0KzsqowG0GpzSB/3yFgDTVxysOpugs6RNIjT3x
	7el4Ia1g1dX3WGrC1UNEeE5fU6+eUszqQIhC+mCuiLPsDQQ+2YEGBO1NFJqv/tlBkCVN
	AUNw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=MfNJCjDF0Uw6zp8MWKhEX2qTrZ8GIMRv+/2Fz5qbyFc=;
	b=BcfbeP5kBCm+xvl2DE/MEZk8C+2ASMf7NfNM8OMGiX+hAGPetLGlXanifXhOk1jsfn
	gToDhNexOwC3qCayBc2iClTQT9oxz+djddheTBrZcPBBjXzwrKsVFbg6FQtbkIsLjKQm
	R6dWhyX0LlxkKltV0TiIPFGgBl9Nq6eZwbZpAfSDlxEM602gzWS01UIi8o86/gw3Kfkl
	myPvYCMGMfatpkLhsDMUWaCLimxBAzSjPhiCEbO+kl5s5lccKQQPW7W9nFrOS6ZoAvHt
	hY9cHWGh6ecAyYzFjV4RkaFlxJjqsQk8TzKp7iejxR1nJXADFMJarTfbjeT+xpf/uKYz
	gElA==
ARC-Authentication-Results: i=2; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=RNhMYmsg;
	spf=pass (google.com: domain of jagan@amarulasolutions.com designates
	209.85.220.41 as permitted sender)
	smtp.mailfrom=jagan@amarulasolutions.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=amarulasolutions.com; s=google;
	h=from:to:cc:subject:date:message-id:in-reply-to:references
	:mime-version:x-original-sender:x-original-authentication-results
	:precedence:mailing-list:list-id:list-post:list-help:list-archive
	:list-unsubscribe;
	bh=MfNJCjDF0Uw6zp8MWKhEX2qTrZ8GIMRv+/2Fz5qbyFc=;
	b=dgy9VShvTSaNQaMvz7NELHkDgxLDaoE1b2lauHXiVqW+D+PPZZetCtgU+NTuf/0oIe
	pr1ZUUE47Veoco28aSixejTCciZ570vOvSV1UXU68m+lB6MxXD5YU7yMj0G3Me7tqyL4
	aTInyfLyzG4l2GNq3QAWNc3Tby/moKKEHjh/o=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20210112;
	h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
	:references:mime-version:x-original-sender
	:x-original-authentication-results:precedence:mailing-list:list-id
	:x-spam-checked-in-group:list-post:list-help:list-archive
	:list-unsubscribe;
	bh=MfNJCjDF0Uw6zp8MWKhEX2qTrZ8GIMRv+/2Fz5qbyFc=;
	b=suzjwywQ11DdfJXYNCg5M/CZVuIaYHG+NbnrNNYMFmn59fxO9bvseVvquFfmGDx4hK
	uXoG9Eaifs2VlxkOolTjsk7QJ4Y9BQnntq92VIfI3EwThxD+qLS4j3PwWgEU+ty8Tg+/
	R7eF+6N1HZ+KIdNH1Lc/xnuJsTY/UeiH7lEvuJrZU2IfQisCEZysdzV8bcQwIR/d1F3u
	Cwq72bbXfAVqiTXJ3B5wPCGq2VIVR8A4l6jaoVyJltaxDlXWXcusqKorXFF2a5jdIY2i
	D3VVjGriG9bqg7I4ZwFQ4Z5OBJ8wlV3qzyn8pS/6Qh6OfqPLX4G/LT+dHiiOZeGa32O/
	RmWg==
X-Gm-Message-State: AOAM532rjm61w+Oz2C1jcDBOP6+aMh6iIwR0uOFWIGitLNzoIEbZRba9
	Y0r+VbDwFYBvkDxZXR/0NspzEUSd
X-Google-Smtp-Source: 
 ABdhPJxSftYWQL3BEZqcnJ/Aj2BlyAZN2FUTo56fvemDb74NaAvGWeFt5uCtG71A0nxhJ5ihuo44yg==
X-Received: by 2002:a05:6a00:218a:b0:4e1:9ed6:c399 with SMTP id
	h10-20020a056a00218a00b004e19ed6c399mr38863953pfi.8.1646325508021;
	Thu, 03 Mar 2022 08:38:28 -0800 (PST)
X-BeenThere: linux-amarula@amarulasolutions.com
Received: by 2002:a05:6a00:1da5:b0:4df:c6b0:2ef8 with SMTP id
	z37-20020a056a001da500b004dfc6b02ef8ls1345052pfw.4.gmail;
	Thu, 03 Mar 2022 08:38:27 -0800 (PST)
X-Received: by 2002:a65:63d6:0:b0:375:7cc6:2b63 with SMTP id
	n22-20020a6563d6000000b003757cc62b63mr30828279pgv.598.1646325507299;
	Thu, 03 Mar 2022 08:38:27 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1646325507; cv=none;
	d=google.com; s=arc-20160816;
	b=Yq1Z0bfEYlS/WpV5NZHbPwkuk9T2xg5qDyM+zRRsaeGhM/u4w0TLUhi6rgQEUAltzK
	qaaFHq6xHWwTYy5Hjv9otiHqZ4M5cSsEYZFLWpTrWI794qULtE8gLvcwMjcQj5/cpBDK
	8ZYElGRqPFIoqp116ksr0/wfPVoEKWoFcV9ifRP1Br1eqfV4vN817H7SMRtwNmv4m2el
	EKUgqFTioxTi+7LA2sA9SYo7SC2h5J5z6KGxKB13EHP8ObwcIRJS5d+Ovjf0meryGJwB
	VtUe2e83Zu/MhX49h0pV0bXJlMJ8emDOlQEMKSYjWmJIXii4qQnbJdlwDHhJwj6IKzB3
	sXDw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=content-transfer-encoding:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=6JVjelDqCtnq6rwBigOzoJDvHv6ras97xpKYaywy2gI=;
	b=kCNU1n1XYBuSicToh+6smpFGgIvAXEnHs0y7/a/MxvA53IK1Ftj1JMIhwlS4/knKVW
	oRyhm3ygqbcG0EEGs+Pz6MkoYiLjzEy+1Iis77mc41sfROrK6XbtVllEMwjlmpr18AW7
	EJ8+U3fl92fcvAQyNEE2M7taZ74VBexEL05EqrpJBsPE4XiS/E69mu0szI6XJ2tTPblm
	Ylj/ay6Ou41pRquFHTjyLnNijpvqtn8LzSTVHtdEq4KqvxSilbYnNu0HrYbEZfB6OzLy
	OOdNfon0+ouxSWW5q4EtCHaI5O1kCFMfKLFulJEQR+c0GBoB+pRTk92d/03jCn/irGYT
	aU3w==
ARC-Authentication-Results: i=1; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=RNhMYmsg;
	spf=pass (google.com: domain of jagan@amarulasolutions.com designates
	209.85.220.41 as permitted sender)
	smtp.mailfrom=jagan@amarulasolutions.com
Received: from mail-sor-f41.google.com (mail-sor-f41.google.com.
	[209.85.220.41]) by mx.google.com with SMTPS id
	v14-20020a056a00148e00b004f3bc62a695sor10359285pfu.68.2022.03.03.08.38.27
	for <linux-amarula@amarulasolutions.com>
	(Google Transport Security); Thu, 03 Mar 2022 08:38:27 -0800 (PST)
Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	client-ip=209.85.220.41;
X-Received: by 2002:aa7:8432:0:b0:4f6:6dcd:4f19 with SMTP id
	q18-20020aa78432000000b004f66dcd4f19mr4057761pfn.53.1646325507004;
	Thu, 03 Mar 2022 08:38:27 -0800 (PST)
Received: from localhost.localdomain
	([2405:201:c00a:a0a9:4526:5253:a010:63f4])
	by smtp.gmail.com with ESMTPSA id
	j20-20020a056a00235400b004e192221ec2sm3220983pfj.14.2022.03.03.08.38.17
	(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
	Thu, 03 Mar 2022 08:38:26 -0800 (PST)
From: Jagan Teki <jagan@amarulasolutions.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Robert Foss <robert.foss@linaro.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	Inki Dae <inki.dae@samsung.com>
Cc: dri-devel@lists.freedesktop.org, linux-amarula@amarulasolutions.com,
	Jagan Teki <jagan@amarulasolutions.com>
Subject: [PATCH v6 6/6] drm: exynos: dsi: Switch to atomic funcs
Date: Thu,  3 Mar 2022 22:06:54 +0530
Message-Id: <20220303163654.3381470-7-jagan@amarulasolutions.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220303163654.3381470-1-jagan@amarulasolutions.com>
References: <20220303163654.3381470-1-jagan@amarulasolutions.com>
MIME-Version: 1.0
X-Original-Sender: jagan@amarulasolutions.com
X-Original-Authentication-Results: mx.google.com;       dkim=pass
	header.i=@amarulasolutions.com header.s=google header.b=RNhMYmsg;
	spf=pass (google.com: domain of jagan@amarulasolutions.com designates
	209.85.220.41 as permitted sender)
	smtp.mailfrom=jagan@amarulasolutions.com
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Mailing-list: list linux-amarula@amarulasolutions.com;
	contact linux-amarula+owners@amarulasolutions.com
List-ID: <linux-amarula.amarulasolutions.com>
X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com
X-Google-Group-Id: 476853432473
List-Post: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>,
	<mailto:linux-amarula@amarulasolutions.com>
List-Help: 
 <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>,
	<mailto:linux-amarula+help@amarulasolutions.com>
List-Archive: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/>
List-Unsubscribe: 
 <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>,
	<https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe>

The new support drm bridges are moving towards atomic functions.

Replace atomic version of functions to continue the transition
to the atomic API.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
Changes for v6, v5, v4, v3:
- none

 drivers/gpu/drm/exynos/exynos_drm_dsi.c | 25 ++++++++++++++++---------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 59a4f7f52180..06130eee8df8 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1358,7 +1358,8 @@ static void exynos_dsi_unregister_te_irq(struct exynos_dsi *dsi)
 	}
 }
 
-static void exynos_dsi_pre_enable(struct drm_bridge *bridge)
+static void exynos_dsi_atomic_pre_enable(struct drm_bridge *bridge,
+					 struct drm_bridge_state *old_bridge_state)
 {
 	struct exynos_dsi *dsi = bridge_to_dsi(bridge);
 	int ret;
@@ -1375,7 +1376,8 @@ static void exynos_dsi_pre_enable(struct drm_bridge *bridge)
 	dsi->state |= DSIM_STATE_ENABLED;
 }
 
-static void exynos_dsi_enable(struct drm_bridge *bridge)
+static void exynos_dsi_atomic_enable(struct drm_bridge *bridge,
+				     struct drm_bridge_state *old_bridge_state)
 {
 	struct exynos_dsi *dsi = bridge_to_dsi(bridge);
 
@@ -1387,7 +1389,8 @@ static void exynos_dsi_enable(struct drm_bridge *bridge)
 	return;
 }
 
-static void exynos_dsi_disable(struct drm_bridge *bridge)
+static void exynos_dsi_atomic_disable(struct drm_bridge *bridge,
+				      struct drm_bridge_state *old_bridge_state)
 {
 	struct exynos_dsi *dsi = bridge_to_dsi(bridge);
 
@@ -1397,7 +1400,8 @@ static void exynos_dsi_disable(struct drm_bridge *bridge)
 	dsi->state &= ~DSIM_STATE_VIDOUT_AVAILABLE;
 }
 
-static void exynos_dsi_post_disable(struct drm_bridge *bridge)
+static void exynos_dsi_atomic_post_disable(struct drm_bridge *bridge,
+					   struct drm_bridge_state *old_bridge_state)
 {
 	struct exynos_dsi *dsi = bridge_to_dsi(bridge);
 
@@ -1425,10 +1429,13 @@ static int exynos_dsi_attach(struct drm_bridge *bridge,
 }
 
 static const struct drm_bridge_funcs exynos_dsi_bridge_funcs = {
-	.pre_enable			= exynos_dsi_pre_enable,
-	.enable				= exynos_dsi_enable,
-	.disable			= exynos_dsi_disable,
-	.post_disable			= exynos_dsi_post_disable,
+	.atomic_duplicate_state		= drm_atomic_helper_bridge_duplicate_state,
+	.atomic_destroy_state		= drm_atomic_helper_bridge_destroy_state,
+	.atomic_reset			= drm_atomic_helper_bridge_reset,
+	.atomic_pre_enable		= exynos_dsi_atomic_pre_enable,
+	.atomic_enable			= exynos_dsi_atomic_enable,
+	.atomic_disable			= exynos_dsi_atomic_disable,
+	.atomic_post_disable		= exynos_dsi_atomic_post_disable,
 	.mode_set			= exynos_dsi_mode_set,
 	.attach				= exynos_dsi_attach,
 };
@@ -1597,7 +1604,7 @@ static void exynos_dsi_unbind(struct device *dev, struct device *master,
 {
 	struct exynos_dsi *dsi = dev_get_drvdata(dev);
 
-	exynos_dsi_disable(&dsi->bridge);
+	exynos_dsi_atomic_disable(&dsi->bridge, NULL);
 
 	mipi_dsi_host_unregister(&dsi->dsi_host);
 }