From patchwork Fri Sep 9 07:05:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 2351 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id A15403F0D5 for ; Fri, 9 Sep 2022 09:06:12 +0200 (CEST) Received: by mail-ej1-f70.google.com with SMTP id nb19-20020a1709071c9300b0074151953770sf529870ejc.21 for ; Fri, 09 Sep 2022 00:06:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1662707171; cv=pass; d=google.com; s=arc-20160816; b=0kbeuO7S0iTsRin8MMm+Oc8KzsPn7I0BGkYy/L+yH91utSdGYbbsSe0yP9FbD+n7VR NkDPGuuoWCC9LN4JYixMyJO0EFHHboR2dlecRhR/B7clQAHlXITaRGwW3a1t7IMDr2v5 NnqkRyDB0jlU78YlpjjsggWU/qZxUK0zJW9Uo3BR1T7z24usDG5rU/Hig0UaOhBdQfmN BRq4FuIBITIr0QHqNlAifhH+2e2pMwo+fxmDQASdhg1E9Z6YVpeGFLBnGRcOWnMf3bIh H782fxROfxrRJn9QvAuLq6t8aAKvoEUTraQtRbM8YS8bEt9DA8sH1vWIPREh0EUb6XZx XnGQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=99bxO/2BIPueVpeEvOmFbeoRUzctgahjeQsIn9Pggjw=; b=EPb30kBXqQ+8BDuxXLCE+2DXPBTcIz7BOcCjOgobLlYhqw2bnn0hnPUgdGV2Y+caMl EdNo8ZDK8EO60qaElAMG+UYhYDb7a6Lj6esL3JrOXRlWTwlouSFvdttjpmy4kql9yF9d tEJsnrIMnAFpzKKGU48hY8T5nmLiULkExbbZRhOG45ddFAiBHXUSeeUEjCxIoXZxjgyL XcycdrZhRyyatqJH90dVdItSitVno8HFIogDfiEFZ8txlDBDjIBHFvRuwLamS2uCgSaI yTIypGmhgoLn0SGD8IdZGzZGEqrwz+hNSI/6Fsc0VZ8Qs6hP6mAhSByLJ8LBpHHGgOoX a8pQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=JZeCWg0l; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :from:to:cc:subject:date; bh=99bxO/2BIPueVpeEvOmFbeoRUzctgahjeQsIn9Pggjw=; b=mUHZKg9mAlJrDKsRVtelzqHPtwm1M2AkJec0N3GyiRODuPWrsxMXcIH0PSywMCgpxf eQLaN2BrkVqAYNYmDsb1j2jLSCrXBWllJeZp8b5oJHUqxd5PNxL8EqOWjtx7FQNg+qVV tguMEXEHybGQMdG9RELXvolS9nfhJcAyCw7ng= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=99bxO/2BIPueVpeEvOmFbeoRUzctgahjeQsIn9Pggjw=; b=0uWyPTcnW6GrXD977PideQcLEmyJs7zt3K8DNDyA3BJPG6JuIH80pCZTsI25Po9QmC JO15GBMWeXw+gjL0hv9vReoj1KSHYwK2gsDRmJZW+Hho0ntYV6EvGrX/XwbinpWdCeo/ rPkT6k26Tmuochheo79oJg8o6ZKPaYAzKIVBjmK0b86j3AFS351fGrQ+HkPmNUqriPp2 lR7Y6CEKVkt8VFy0vOXGIfJQsVvydYjMiygG5meYPmP6V2RHnVwKORTN4bUL1RwUbban CqxkINYcUhDwMKlx2AZWNCGW5lDnJOg73f9dO+ZPhsGbfFY1wQeYVvC4yLbVqGiv6OOC koaw== X-Gm-Message-State: ACgBeo0KI6ca1b0JoBhd9vqELogXNCtRNIzGQ1NQ2Cc7c6VYKm9ukYbX 1hUgdJJLaLEm2cgnyJXbSScI3+OP X-Google-Smtp-Source: AA6agR4R4WnH5Kb5BezOwNL5Tag/pJVMLD6ZylJQrwQTz+ckvk2gzuzYab323tLVzwEuK7lSJ3Vz2w== X-Received: by 2002:a17:907:7e8a:b0:732:ff29:d1d6 with SMTP id qb10-20020a1709077e8a00b00732ff29d1d6mr9025676ejc.175.1662707171529; Fri, 09 Sep 2022 00:06:11 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a05:6402:278e:b0:44e:93b9:21c8 with SMTP id b14-20020a056402278e00b0044e93b921c8ls722113ede.1.-pod-prod-gmail; Fri, 09 Sep 2022 00:06:10 -0700 (PDT) X-Received: by 2002:aa7:dcce:0:b0:44e:68a2:572d with SMTP id w14-20020aa7dcce000000b0044e68a2572dmr10065213edu.246.1662707170279; Fri, 09 Sep 2022 00:06:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662707170; cv=none; d=google.com; s=arc-20160816; b=mh/qEslB4Tg52EeK7dLiFXVAgePGNjSGt6KStP+5p0ytVKDrsLK19o9psqB5WcY7w0 GJlu2nDt0m2/A/0VmDTA/Km45nnHcUU1iFIJlblg5UAZ0KC36H6YZ88qcNKsb2pS7GJ5 gsQRz5WaLDcE9OCOBbk8j8KU5jdlfWn/XtyVuZhPzxPAQ/rqnFa6v7aXyqWjqsNFHULT x8cVJ8IRRUiOs3BzsRqsrr7pSL1ek1z4P6h4NmsQJmDMQHM7SmWpOO/b6B0ibc0GLFCa PgRnAPpybFvRiYO2IMR15qm3ldwClHQWfyVxIS8/mzJeypDg+Jlf9Do+zUS8cPNs0dSn 77rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=X8eeAPtqmw8RzZTUzvCg8gt0OKS8MUeyq5T0HoYRPyo=; b=MYCIygBOamgV3+42B5ZKaXxw3u+8RmLYugoyyvO9rmRBi6jMdBAMbLZknFlIZOGXeW kFl377muFbyq15S9li4z4P04ll18GymoQJbJ2H6zfr07zxZkgfwv6V1Ilofd2GxuwGrH Niw3FGCdP4Z/ViwQfPLMJZO7WMXTPwbpsyyonZD81dFBmACcNXYO/bHO9w7KtPEijFAG lhBurfcf4fFU/Lslk/x54ydKYfEceYL6oZ7fMQ7DELi/OpZi+BN7OPtNQPYPXML61vhW 5pBQVsDb1jqQRha1rMZcyvGaffWvXwSxueP6NYBGX6p6clpjGqhNG8fLGdTq6c0oA/8/ J18Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=JZeCWg0l; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id hb8-20020a170906b88800b0077a3d581ba8sor3976ejb.84.2022.09.09.00.06.10 for (Google Transport Security); Fri, 09 Sep 2022 00:06:10 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:907:728d:b0:73d:693c:738 with SMTP id dt13-20020a170907728d00b0073d693c0738mr8834620ejc.134.1662707170010; Fri, 09 Sep 2022 00:06:10 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-31-31-9.retail.telecomitalia.it. [79.31.31.9]) by smtp.gmail.com with ESMTPSA id 2-20020a170906210200b0077086d2db8esm548272ejt.140.2022.09.09.00.06.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Sep 2022 00:06:08 -0700 (PDT) From: Dario Binacchi To: busybox@busybox.net Cc: vda.linux@googlemail.com, linux-amarula@amarulasolutions.com, Dario Binacchi Subject: [RESEND RFC PATCH 1/2] fbset: abort on not handled options Date: Fri, 9 Sep 2022 09:05:51 +0200 Message-Id: <20220909070552.860452-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=JZeCWg0l; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Not all options are actually implemented. In this case, return a message and an error code to make it clear that the requested command has not been executed. Signed-off-by: Dario Binacchi --- util-linux/fbset.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/util-linux/fbset.c b/util-linux/fbset.c index 41cc29f37b78..0eaa7c0a6427 100644 --- a/util-linux/fbset.c +++ b/util-linux/fbset.c @@ -519,6 +519,9 @@ int fbset_main(int argc, char **argv) var_set.bits_per_pixel = xatou32(argv[1]); break; #endif + default: + bb_perror_msg_and_die("option '%s' not handled", + g_cmdoptions[i].name); } switch (g_cmdoptions[i].code) { case CMD_FB: