From patchwork Sat Nov 11 10:41:50 2023
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Dario Binacchi <dario.binacchi@amarulasolutions.com>
X-Patchwork-Id: 2998
Return-Path: 
 <linux-amarula+bncBCQ4XFG47UFRBHVVXWVAMGQEVJ4T5XI@amarulasolutions.com>
X-Original-To: linux-amarula@patchwork.amarulasolutions.com
Delivered-To: linux-amarula@patchwork.amarulasolutions.com
Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com
	[209.85.208.72])
	by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 44E3C3FA58
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Sat, 11 Nov 2023 11:42:39 +0100 (CET)
Received: by mail-ed1-f72.google.com with SMTP id
	4fb4d7f45d1cf-54061ad6600sf2045562a12.3
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Sat, 11 Nov 2023 02:42:39 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1699699359; cv=pass;
	d=google.com; s=arc-20160816;
	b=xHu1jzldvojissU0NpQYRoVkrPfWETRYzL4u/Kgzxh0EzaesFSlvpVcAvziMN+tevI
	ZQ8bsoVWOwdgUKhalD4LDk9WzlhmFTxKsoJUde7PXv4aM73vLlg35iyyc9CKFbflycY3
	dmABxAxq+mWvFcu9NvyNgTBWdER0GNwxiW1Y/sOV6BpYZ50qbeglYiFzNVMkB/XIyrvZ
	Jhwy4YHUg92zE7TIOx0q0whtqbWyN2x5/onArCngoRk1hpV8esqoPR/CzFTRwMaxJPJB
	7PDOcBOmY5KvZLmiHJ1zm9DmzpbjnU17T76AOxybPdLVmtJC1cN1jIQdKcQSY/3ZMrV5
	V/3A==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=XEUFmSmt4+kDUFZOvwPvI3ZXApfyh/WxojWjQBSgcKU=;
	fh=GXyCuaO7mljfRZuDSHr1xseCHKUjkPQV0dF3zOsFIac=;
	b=n/kyj1dcrcFBa/Q7VftRis8OTWRWW1Iq/gBh4doRwAS010GS6VEFQWDvstOA/7Bg9o
	PRxy/FLw/wstE4r9orua8nDNrEkzWaVDmUXbLB0V4b16kVRCWSpGw4lKOjBgrQt59fei
	DOarlZXuc0Yw/GjQedErz5pXXS1ngqEm4sKnM4HoBJxKExCsnGEsWq09xvZXcM6Cdn96
	+lsZB8d6kyaLKrYfZjh048VCM3IrFkTOQXTjOWlqvGfyUTxqO6sj4D9xsakMVtlEE/y3
	/puKAy1a89As0iJutzLna/nBvrcPVMViNJIdEQ3F6pp9Cpz4IPwayzd0RCq01xwSaAwZ
	vffA==
ARC-Authentication-Results: i=2; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=UrjsZXky;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.65 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=amarulasolutions.com; s=google; t=1699699359; x=1700304159;
	darn=patchwork.amarulasolutions.com;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:x-original-authentication-results
	:x-original-sender:mime-version:references:in-reply-to:message-id
	:date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
	bh=XEUFmSmt4+kDUFZOvwPvI3ZXApfyh/WxojWjQBSgcKU=;
	b=mzqeP8FkZJHtEJ/8ib1IvYS2k/dOhkrQvxQPR6ROqBnkmknK7qMqWstcMclq12aSL+
	s/63UEPfGK89O1ryBgVTPPSRn2NH8LctGL06xqQH1EFiwRQUN1lbR0FDfSeVE/uTSkLN
	3ua7usAK0yTblRS1rk2uwNZ2pLVgfhOMwTelU=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20230601; t=1699699359; x=1700304159;
	h=list-unsubscribe:list-archive:list-help:list-post
	:x-spam-checked-in-group:list-id:mailing-list:precedence
	:x-original-authentication-results:x-original-sender:mime-version
	:references:in-reply-to:message-id:date:subject:cc:to:from
	:x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id
	:reply-to;
	bh=XEUFmSmt4+kDUFZOvwPvI3ZXApfyh/WxojWjQBSgcKU=;
	b=DaqQUaN4iOhUSp8S/fBvE1vMZGzE/G9RchStJHF+gOmhaBYBwChdnElOxpgX+lUTMa
	3p12Nr6j4b3aiXKeZOK2MI//RzDEgahIPasJ2bFObhrbyCcIn4Dsf+PVvjD+Lsr28rYK
	b+lKHmr4ldyJ+bYv/nzMKTKNsTARQAyo7xOD6SOITJesNNZ4edUCn1y9pBN4D+gwqrNa
	DwCUPWkQkCkHTqvrqTJJRxjKT+qhEpNWSTmRJiNlE1cQaCmqchSu6VV+CuOZXI0gcXzO
	PoJVm1qzGt54AZbmixqme0mhxagOImiF4Al7TuPEz+bRV5nxt72Gr4WXav1+ZVB8p/jx
	Etog==
X-Gm-Message-State: AOJu0Yxg1ZVhidQ1Py0kLCgbSI8HfEDHiaHQnjCB/c/DLgvMgMRWFrOz
	jhi8VPsBB6ZLiLMQGU5GWijG9/GY
X-Google-Smtp-Source: 
 AGHT+IFIv+bEwOoA8RfuB4Nqdn4nyiTAUeZJYZo6OcNxeIipM+asVqApS1dhx87x8oQq+smOvECPOA==
X-Received: by 2002:a50:ff14:0:b0:543:75cb:214e with SMTP id
	a20-20020a50ff14000000b0054375cb214emr1299973edu.11.1699699358972;
	Sat, 11 Nov 2023 02:42:38 -0800 (PST)
X-BeenThere: linux-amarula@amarulasolutions.com
Received: by 2002:a05:6402:5156:b0:534:7b4a:8d91 with SMTP id
	n22-20020a056402515600b005347b4a8d91ls50563edd.2.-pod-prod-06-eu;
	Sat, 11 Nov 2023 02:42:37 -0800 (PST)
X-Received: by 2002:a17:906:c30a:b0:9e6:568:7374 with SMTP id
	s10-20020a170906c30a00b009e605687374mr1024209ejz.1.1699699357453;
	Sat, 11 Nov 2023 02:42:37 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1699699357; cv=none;
	d=google.com; s=arc-20160816;
	b=RYYHQC2p7l/yKZQ6C5nDyk9umVKyNBgI+aJU4ngOmjK/2aUDNtGJbrzDmmgyDr8kEP
	tHMDVBCrPTq3yjOwDS6E+L/Lddkbw6qRowtrm59ezFkV7RkgaMtG77pR3ckc+yxKpyV4
	nPyI0T2GY+rSC0nuCfdwQ6kYQ7RBFpP2AvBhlb85yLaRtxh33blKaYoQIfyuTi4imPXs
	Ur5ofkUkZJwa8v44lwMrNtxnq1ZRyfwP1woiuc/Bat4OlWZm2D6NZ5XtyEgTsR2ghQYI
	JvklrPcGdRkN1NMO94dWDXv+78U+Sqh6YCOTvHkeB9SI3lorp12ILg+bPbvUK4raaZjx
	w4WA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=content-transfer-encoding:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=eutcu8nha5gIvSO1Nw/orY10THf/Z0yjX5SxOR1EIyg=;
	fh=GXyCuaO7mljfRZuDSHr1xseCHKUjkPQV0dF3zOsFIac=;
	b=0hu6dE+SYfd//BXE1nbyVsoT2ONoJEn6uWZRZtsynuCE5gPPX2WrU/anP94XxDPKVG
	nwrKHEEv5PwwNu9gFK2XrQHU3XHyMetWvfDctXdv0iEkTxMwhLn4h4wp3szqZbFcx5DJ
	Rg548xVLziCoVFlJAYy1nstXNaMx5G1w8DBC2DoqeB6DXBDqRzrQkCsnajNEp063LnVV
	z8/aVjbUTBe/UAwV56fEmF2TvN2i2cJMcNrX8IUabFaqg4PfknwOlqURIaRdlAVPeEYf
	MWVAcbKV2H84j3Yj3wz+uLqjU+yP0ZVlcSMuu0JvuGfGeB0t8yRC50/+F0LEvMuQ8D0v
	+KSg==
ARC-Authentication-Results: i=1; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=UrjsZXky;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.65 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
Received: from mail-sor-f65.google.com (mail-sor-f65.google.com.
	[209.85.220.65]) by mx.google.com with SMTPS id
	21-20020a170906101500b009cd938511dfsor265306ejm.19.2023.11.11.02.42.37
	for <linux-amarula@amarulasolutions.com>
	(Google Transport Security); Sat, 11 Nov 2023 02:42:37 -0800 (PST)
Received-SPF: pass (google.com: domain of
	dario.binacchi@amarulasolutions.com designates 209.85.220.65
	as permitted sender) client-ip=209.85.220.65;
X-Received: by 2002:a17:906:4742:b0:9bf:4915:22ca with SMTP id
	j2-20020a170906474200b009bf491522camr1072967ejs.45.1699699357215;
	Sat, 11 Nov 2023 02:42:37 -0800 (PST)
Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it
	(host-79-20-97-182.retail.telecomitalia.it. [79.20.97.182])
	by smtp.gmail.com with ESMTPSA id
	ga33-20020a1709070c2100b0099e12a49c8fsm872183ejc.173.2023.11.11.02.42.36
	(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
	Sat, 11 Nov 2023 02:42:36 -0800 (PST)
From: Dario Binacchi <dario.binacchi@amarulasolutions.com>
To: linux-kernel@vger.kernel.org
Cc: linux-amarula@amarulasolutions.com,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	Fabio Estevam <festevam@gmail.com>, Helge Deller <deller@gmx.de>,
	Martin Kaiser <martin@kaiser.cx>, NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>,
	dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org,
	linux-fbdev@vger.kernel.org
Subject: [PATCH 01/10] fbdev: imxfb: fix left margin setting
Date: Sat, 11 Nov 2023 11:41:50 +0100
Message-ID: <20231111104225.136512-2-dario.binacchi@amarulasolutions.com>
X-Mailer: git-send-email 2.42.0
In-Reply-To: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com>
References: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com>
MIME-Version: 1.0
X-Original-Sender: dario.binacchi@amarulasolutions.com
X-Original-Authentication-Results: mx.google.com;       dkim=pass
	header.i=@amarulasolutions.com header.s=google header.b=UrjsZXky;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.65 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Mailing-list: list linux-amarula@amarulasolutions.com;
	contact linux-amarula+owners@amarulasolutions.com
List-ID: <linux-amarula.amarulasolutions.com>
X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com
X-Google-Group-Id: 476853432473
List-Post: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>,
	<mailto:linux-amarula@amarulasolutions.com>
List-Help: 
 <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>,
	<mailto:linux-amarula+help@amarulasolutions.com>
List-Archive: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/>
List-Unsubscribe: 
 <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>,
	<https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe>

The previous setting did not take into account the CSTN mode.
For the H_WAIT_2 bitfield (bits 0-7) of the LCDC Horizontal Configuration
Register (LCDCR), the IMX25RM manual states that:

In TFT mode, it specifies the number of SCLK periods between the end of
HSYNC and the beginning of OE signal, and the total delay time equals
(H_WAIT_2 + 3) of SCLK periods.
In CSTN mode, it specifies the number of SCLK periods between the end of
HSYNC and the first display data in each line, and the total delay time
equals (H_WAIT_2 + 2) of SCLK periods.

The patch handles both cases.

Fixes: 4e47382fbca9 ("fbdev: imxfb: warn about invalid left/right margin")
Fixes: 7e8549bcee00 ("imxfb: Fix margin settings")
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 drivers/video/fbdev/imxfb.c | 27 +++++++++++++++++++++++++--
 1 file changed, 25 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
index 84201c9608d3..7042a43b81d8 100644
--- a/drivers/video/fbdev/imxfb.c
+++ b/drivers/video/fbdev/imxfb.c
@@ -42,6 +42,7 @@
 #include <video/videomode.h>
 
 #define PCR_TFT		(1 << 31)
+#define PCR_COLOR	(1 << 30)
 #define PCR_BPIX_8	(3 << 25)
 #define PCR_BPIX_12	(4 << 25)
 #define PCR_BPIX_16	(5 << 25)
@@ -150,6 +151,12 @@ enum imxfb_type {
 	IMX21_FB,
 };
 
+enum imxfb_panel_type {
+	PANEL_TYPE_MONOCHROME,
+	PANEL_TYPE_CSTN,
+	PANEL_TYPE_TFT,
+};
+
 struct imxfb_info {
 	struct platform_device  *pdev;
 	void __iomem		*regs;
@@ -157,6 +164,7 @@ struct imxfb_info {
 	struct clk		*clk_ahb;
 	struct clk		*clk_per;
 	enum imxfb_type		devtype;
+	enum imxfb_panel_type	panel_type;
 	bool			enabled;
 
 	/*
@@ -444,6 +452,13 @@ static int imxfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
 	if (!is_imx1_fb(fbi) && imxfb_mode->aus_mode)
 		fbi->lauscr = LAUSCR_AUS_MODE;
 
+	if (imxfb_mode->pcr & PCR_TFT)
+		fbi->panel_type = PANEL_TYPE_TFT;
+	else if (imxfb_mode->pcr & PCR_COLOR)
+		fbi->panel_type = PANEL_TYPE_CSTN;
+	else
+		fbi->panel_type = PANEL_TYPE_MONOCHROME;
+
 	/*
 	 * Copy the RGB parameters for this display
 	 * from the machine specific parameters.
@@ -596,6 +611,7 @@ static int imxfb_activate_var(struct fb_var_screeninfo *var, struct fb_info *inf
 {
 	struct imxfb_info *fbi = info->par;
 	u32 ymax_mask = is_imx1_fb(fbi) ? YMAX_MASK_IMX1 : YMAX_MASK_IMX21;
+	u8 left_margin_low;
 
 	pr_debug("var: xres=%d hslen=%d lm=%d rm=%d\n",
 		var->xres, var->hsync_len,
@@ -604,6 +620,13 @@ static int imxfb_activate_var(struct fb_var_screeninfo *var, struct fb_info *inf
 		var->yres, var->vsync_len,
 		var->upper_margin, var->lower_margin);
 
+	if (fbi->panel_type == PANEL_TYPE_TFT)
+		left_margin_low = 3;
+	else if (fbi->panel_type == PANEL_TYPE_CSTN)
+		left_margin_low = 2;
+	else
+		left_margin_low = 0;
+
 #if DEBUG_VAR
 	if (var->xres < 16        || var->xres > 1024)
 		printk(KERN_ERR "%s: invalid xres %d\n",
@@ -611,7 +634,7 @@ static int imxfb_activate_var(struct fb_var_screeninfo *var, struct fb_info *inf
 	if (var->hsync_len < 1    || var->hsync_len > 64)
 		printk(KERN_ERR "%s: invalid hsync_len %d\n",
 			info->fix.id, var->hsync_len);
-	if (var->left_margin < 3  || var->left_margin > 255)
+	if (var->left_margin < left_margin_low  || var->left_margin > 255)
 		printk(KERN_ERR "%s: invalid left_margin %d\n",
 			info->fix.id, var->left_margin);
 	if (var->right_margin < 1 || var->right_margin > 255)
@@ -637,7 +660,7 @@ static int imxfb_activate_var(struct fb_var_screeninfo *var, struct fb_info *inf
 
 	writel(HCR_H_WIDTH(var->hsync_len - 1) |
 		HCR_H_WAIT_1(var->right_margin - 1) |
-		HCR_H_WAIT_2(var->left_margin - 3),
+		HCR_H_WAIT_2(var->left_margin - left_margin_low),
 		fbi->regs + LCDC_HCR);
 
 	writel(VCR_V_WIDTH(var->vsync_len) |

From patchwork Sat Nov 11 10:41:51 2023
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Dario Binacchi <dario.binacchi@amarulasolutions.com>
X-Patchwork-Id: 2999
Return-Path: 
 <linux-amarula+bncBCQ4XFG47UFRBIFVXWVAMGQE3PFJ2DI@amarulasolutions.com>
X-Original-To: linux-amarula@patchwork.amarulasolutions.com
Delivered-To: linux-amarula@patchwork.amarulasolutions.com
Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com
	[209.85.218.70])
	by ganimede.amarulasolutions.com (Postfix) with ESMTPS id EAD943F057
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Sat, 11 Nov 2023 11:42:40 +0100 (CET)
Received: by mail-ej1-f70.google.com with SMTP id
	a640c23a62f3a-9a62adedadbsf215451066b.1
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Sat, 11 Nov 2023 02:42:40 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1699699360; cv=pass;
	d=google.com; s=arc-20160816;
	b=IkkTXiGi2WvNhhY5u3rOPDiNM6NzoL049N3n29/8UcBn1hn9GXSalIoVe235YzBqdS
	e7dwBhJtrQSMSW64ugPaQFFFnw2SORdUMab77bnGkYSA8/9lrORr6d2dn1mdjDQbpPl8
	7Ek9bt9w+KT9EEyn5vOgC8Of2kEHYALpf+II+4vZv6tvshHo5L2XIv13tV36tAWUrFb3
	4pq9Mpb6FxH/jpR4lOfsVw3bBFhyqfm7kjk7xmJqMQcBntFta/yocuHIU5ZYPClEYixr
	8n+aq25ZNHXYaWNsk/HeFWWeEP2BmRxwiTTYAfXz3FLu4WFj1ss9RQDYofyNQpZf9J7F
	PonA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=jNBGLsLR8f+JTNtNqSdQJHKORiE5JjwyvNZshyd8r38=;
	fh=CRQFspQ+XVmz3jTpDmawxjgq3paXQGVEDP+3Wpr+FXU=;
	b=OKaMA/wM1W3gSUgAV30cHShKelPtaHh+snsTSN8DFmXn6UGEw4wBOhDTHU7s/SL0lx
	8cj8lTnVn5142vG5v6Lqz3/tz2h+1pd7jZhKW85x2kIu1Rk5kRI7bPh0CM/in4TKxXRd
	nxloN/QbOtC72F5RwOqbph0SJDT0ulB1Q+Ro514War6LuNtC0LVZfDHsisk8H9O+iKux
	78sB5W9j06Iximg26oRJQ6o2t4KofPd7Z9UuQqziB4RfV0Pem8SUhRtm2Meaq428byCl
	JsRKftFBK+WxLf9ay7voxgJY9CNff08Piyq9TxDZXlvcItJhPk5RMAfPYsbMuMOUcQMo
	CTRA==
ARC-Authentication-Results: i=2; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=mqVVFw4e;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=amarulasolutions.com; s=google; t=1699699360; x=1700304160;
	darn=patchwork.amarulasolutions.com;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:x-original-authentication-results
	:x-original-sender:mime-version:references:in-reply-to:message-id
	:date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
	bh=jNBGLsLR8f+JTNtNqSdQJHKORiE5JjwyvNZshyd8r38=;
	b=E0GYWd+cdQksuzMK/7evkoAiviDzPKmraa6EnQ5H4D69TrrwiTziMnVOZNAWkmPcYD
	4dvTFdQ6mETsQ0oNx1F/Foq/LpJsgnK8aj4FaNSPwSyVZJI1jJs5nkD6nWGeob/DcWN0
	bU7SX6lEJaB21Dm93P5HUXWrpxIy8wg1iay70=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20230601; t=1699699360; x=1700304160;
	h=list-unsubscribe:list-archive:list-help:list-post
	:x-spam-checked-in-group:list-id:mailing-list:precedence
	:x-original-authentication-results:x-original-sender:mime-version
	:references:in-reply-to:message-id:date:subject:cc:to:from
	:x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id
	:reply-to;
	bh=jNBGLsLR8f+JTNtNqSdQJHKORiE5JjwyvNZshyd8r38=;
	b=JNgDlBujWULgMXCvTBXo5oVBc1yzaFlRxEh+yRoqIBNNrJKxv7HhK5dauPNi3Goxht
	Tv7XDdlG5Lb2q0vEZXJFJuuCczp0TuIDG254alPTuqlpZRPy8RiVwugBu3YbuQMsf940
	36vU86m3Q4zpC9C1Mi4xK1aICPCynkIST8JMhjHgp38ZFt1ev7QIEsLQs1W74tLBYOKD
	5juOyGQPERs31ROHybeW9aeeb4osjYq4p4m5T6vIb2VtpSpqlZaap1XM+hCBluUh5t3V
	AmacI82Wxss2VGGEWNVX2y1xRCK5ysEdLZ8Tl/z9IZoBj9UQqnyGPyWbtUqpLuzAPPSP
	qcAQ==
X-Gm-Message-State: AOJu0YwtYEi5T82ZN3o60nYpd0rSThm/6/YTpAZmv8UFVMeMQP6K1U6Q
	5nQq+CQJT3ecuyBIdnELIDAzH9eJ
X-Google-Smtp-Source: 
 AGHT+IFjsWcHR1lM1F2BS+z2+iCvsDoFOyakKvl+6IRNXerKXZ4mT9wQXDjynp+M0kStMFahRA0SOg==
X-Received: by 2002:a05:6402:1116:b0:543:858b:9d94 with SMTP id
	u22-20020a056402111600b00543858b9d94mr998812edv.41.1699699360435;
	Sat, 11 Nov 2023 02:42:40 -0800 (PST)
X-BeenThere: linux-amarula@amarulasolutions.com
Received: by 2002:a05:6402:4cf:b0:540:e958:cfd8 with SMTP id
	n15-20020a05640204cf00b00540e958cfd8ls762612edw.2.-pod-prod-01-eu;
	Sat, 11 Nov 2023 02:42:39 -0800 (PST)
X-Received: by 2002:a17:906:770d:b0:9e3:b513:7004 with SMTP id
	q13-20020a170906770d00b009e3b5137004mr1056133ejm.47.1699699358870;
	Sat, 11 Nov 2023 02:42:38 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1699699358; cv=none;
	d=google.com; s=arc-20160816;
	b=toTpy8gdERU57g7QPnX5ktlwPglCmNQMjSp5sMHvWviS+wnwOfZXMehqZoxvSbd7S2
	vSOywF7Do6kkB2x4eaoqf0QKm3AlHtEpurn1nRBEKoVOyz22UULeiGWNh/dpvQeMHuxz
	0LZbLI1PAdwGHjy5/0RZJiYucYg3o8dJisPxn1rCoKvs1W6j4jhODs1hPBJLVYbYPpZE
	ouiDLouCGKRfdMaqTGBZQWu6vC5B4TbfDvBSXgvFuSMtJ1cx7FXbZY0NiI6Iw8VKeJ7L
	GyCv5sBx3VdOZfpKG6th/dPCZVWMTHgjelMTSykD1Vd4K8AZVGcYTyqRxZUabbTcia9/
	lg8Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=content-transfer-encoding:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=cv+Nw99h5TQ+ZdPAOUHCJ7Is/AuyKPzv38qwm03SYTY=;
	fh=CRQFspQ+XVmz3jTpDmawxjgq3paXQGVEDP+3Wpr+FXU=;
	b=SEp2cliQXZUQ/iAnGx9yO4spZSXqN8oubVRQPcKnh8xIRVIAr0dA3tMZyLVcKkjquj
	fI2oZg5c9aadzZWGKn7ppRfKMRQ0glxmKa8YYyeXjX26p+/gV/Y7lE6bBb4k8u04yICV
	lg57b6ci/2FSPFE4i79cDHRnOI7U6dVTSMeqWsLfrZksS+gksziG8jr6TbcG/kgxlyV5
	WXbAMKx3xumUgevLrVV3q4KBN8gv0VDAiq94OOrBan3cBwA7B8tX9XW26dqsbNmln9/g
	yqYb8fGl8dDBkYypkQ32W59yK5BnLn95QYQ0LaXzNkvIO7el8Il1Vo7umM9lYcIsGIgi
	d+CA==
ARC-Authentication-Results: i=1; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=mqVVFw4e;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
Received: from mail-sor-f41.google.com (mail-sor-f41.google.com.
	[209.85.220.41]) by mx.google.com with SMTPS id
	y8-20020a1709063a8800b009bd915885a8sor260045ejd.17.2023.11.11.02.42.38
	for <linux-amarula@amarulasolutions.com>
	(Google Transport Security); Sat, 11 Nov 2023 02:42:38 -0800 (PST)
Received-SPF: pass (google.com: domain of
	dario.binacchi@amarulasolutions.com designates 209.85.220.41
	as permitted sender) client-ip=209.85.220.41;
X-Received: by 2002:a17:906:fc0a:b0:9e0:5d5c:aa81 with SMTP id
	ov10-20020a170906fc0a00b009e05d5caa81mr1063698ejb.27.1699699358600;
	Sat, 11 Nov 2023 02:42:38 -0800 (PST)
Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it
	(host-79-20-97-182.retail.telecomitalia.it. [79.20.97.182])
	by smtp.gmail.com with ESMTPSA id
	ga33-20020a1709070c2100b0099e12a49c8fsm872183ejc.173.2023.11.11.02.42.37
	(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
	Sat, 11 Nov 2023 02:42:38 -0800 (PST)
From: Dario Binacchi <dario.binacchi@amarulasolutions.com>
To: linux-kernel@vger.kernel.org
Cc: linux-amarula@amarulasolutions.com,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	Fabio Estevam <festevam@gmail.com>, Helge Deller <deller@gmx.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>,
	dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org,
	linux-fbdev@vger.kernel.org
Subject: [PATCH 02/10] fbdev: imxfb: move PCR bitfields near their offset
Date: Sat, 11 Nov 2023 11:41:51 +0100
Message-ID: <20231111104225.136512-3-dario.binacchi@amarulasolutions.com>
X-Mailer: git-send-email 2.42.0
In-Reply-To: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com>
References: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com>
MIME-Version: 1.0
X-Original-Sender: dario.binacchi@amarulasolutions.com
X-Original-Authentication-Results: mx.google.com;       dkim=pass
	header.i=@amarulasolutions.com header.s=google header.b=mqVVFw4e;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Mailing-list: list linux-amarula@amarulasolutions.com;
	contact linux-amarula+owners@amarulasolutions.com
List-ID: <linux-amarula.amarulasolutions.com>
X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com
X-Google-Group-Id: 476853432473
List-Post: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>,
	<mailto:linux-amarula@amarulasolutions.com>
List-Help: 
 <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>,
	<mailto:linux-amarula+help@amarulasolutions.com>
List-Archive: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/>
List-Unsubscribe: 
 <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>,
	<https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe>

The patch moves the bitfields of the PCR register near the macro that
defines its offset, just like for all the other registers.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 drivers/video/fbdev/imxfb.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
index 7042a43b81d8..6af5f09d9c85 100644
--- a/drivers/video/fbdev/imxfb.c
+++ b/drivers/video/fbdev/imxfb.c
@@ -41,13 +41,6 @@
 #include <video/of_videomode.h>
 #include <video/videomode.h>
 
-#define PCR_TFT		(1 << 31)
-#define PCR_COLOR	(1 << 30)
-#define PCR_BPIX_8	(3 << 25)
-#define PCR_BPIX_12	(4 << 25)
-#define PCR_BPIX_16	(5 << 25)
-#define PCR_BPIX_18	(6 << 25)
-
 struct imx_fb_videomode {
 	struct fb_videomode mode;
 	u32 pcr;
@@ -88,6 +81,12 @@ struct imx_fb_videomode {
 #define LCDC_LCHCC	0x14
 
 #define LCDC_PCR	0x18
+#define PCR_TFT		(1 << 31)
+#define PCR_COLOR	(1 << 30)
+#define PCR_BPIX_8	(3 << 25)
+#define PCR_BPIX_12	(4 << 25)
+#define PCR_BPIX_16	(5 << 25)
+#define PCR_BPIX_18	(6 << 25)
 
 #define LCDC_HCR	0x1C
 #define HCR_H_WIDTH(x)	(((x) & 0x3f) << 26)

From patchwork Sat Nov 11 10:41:52 2023
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Dario Binacchi <dario.binacchi@amarulasolutions.com>
X-Patchwork-Id: 3000
Return-Path: 
 <linux-amarula+bncBCQ4XFG47UFRBINVXWVAMGQE7J2L75Q@amarulasolutions.com>
X-Original-To: linux-amarula@patchwork.amarulasolutions.com
Delivered-To: linux-amarula@patchwork.amarulasolutions.com
Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com
	[209.85.208.71])
	by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 394B33F057
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Sat, 11 Nov 2023 11:42:42 +0100 (CET)
Received: by mail-ed1-f71.google.com with SMTP id
	4fb4d7f45d1cf-542d910f34bsf2132658a12.3
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Sat, 11 Nov 2023 02:42:42 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1699699362; cv=pass;
	d=google.com; s=arc-20160816;
	b=NRWGfxgUSTFd4PKTuQAmVMvmuhBXpBEFKxG28QPFrfxquZF4B1J89izbNpslISzAIo
	AoiLyZvW7EAxnklgMHWNdvNeMDGYGnR67bh3yxfvtiSUrRfPh33YZ9aLzzHupSJ/O6fl
	zdEXPMIQ1YMEav08Zp3GZrug11nf8D05MQ2Eykaq7QxCcP5m2jfSWWQlU8arRdjEVMbd
	+Z7OhbsSIexDHF+Cfp5r687guQ8Tm09dqkUlaCpnb4Wl+TjculGaOhDubnfPA7ji5IQu
	WvKEHRzky+Jhhv+/66v1LVu4cfraQQJigFMaxUK3OVPGY0IrJrpBqMQIVfKPqGhTjIGw
	RmZA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=eFItHm4yzYce4R10MhN1KkWpSPlJbehp7eQirD960uw=;
	fh=CRQFspQ+XVmz3jTpDmawxjgq3paXQGVEDP+3Wpr+FXU=;
	b=pwJcHQdeNuymhecakjV4SygyUgfiFe5XfVtrDYqLFypBmT9UgEvcPkVPbWJr0shnda
	fDUM9XENizjXs3ZPeMyDtAP2dj5D0hR0N44PQf1rz3o0jeOvlMkmu73ruh6+kknmy1ti
	14nsl4awzk+yhJTck6s5pkEGa8tazenE+ApGEv29yrMgH3olminXjIzxWNFWnWrMo2fV
	Z5kJ5l0ymd9ersEvAcmI9SlS/F2m8TizB+XJLLFMnkto5aDQ9ID/xCsWyu6Gcyt8cRIN
	RmgaONCBK1RYmTLeOL1P9wwJzy0w+kdWPR+TcVnPiS2LyNy0I+waaJcLCgXLr0Shfgck
	8/VA==
ARC-Authentication-Results: i=2; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=EQ2oF+Wo;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=amarulasolutions.com; s=google; t=1699699362; x=1700304162;
	darn=patchwork.amarulasolutions.com;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:x-original-authentication-results
	:x-original-sender:mime-version:references:in-reply-to:message-id
	:date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
	bh=eFItHm4yzYce4R10MhN1KkWpSPlJbehp7eQirD960uw=;
	b=dRta5oMKMEs2M7mfNGghWb0A576ihTbXn+NOuVouI90QWunRF1o6Szf3ulkKaCqzbV
	8uH2/MpsDJIArdoDPydjFypLabFtbC724ymrSeTZKyFqa9RoZAgot3zh77Gen9EEO65E
	IpKpTFHYajqnovYWZvGVcV/q1iMhB06HRa6x4=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20230601; t=1699699362; x=1700304162;
	h=list-unsubscribe:list-archive:list-help:list-post
	:x-spam-checked-in-group:list-id:mailing-list:precedence
	:x-original-authentication-results:x-original-sender:mime-version
	:references:in-reply-to:message-id:date:subject:cc:to:from
	:x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id
	:reply-to;
	bh=eFItHm4yzYce4R10MhN1KkWpSPlJbehp7eQirD960uw=;
	b=iHCnjh0mN8V3rvmXacCY2GMlJ3AenOjqa4+kWKNsg/reuJfFLLOYtxOlaNvvHIW09R
	moCqo5/610zsT0TdgustMz31/k3zTFQj/9Q4oenzHVkHtzuyS6nWbcxorMIOgMH04fC2
	EOW3fxHV/OuY4TNFpUQmX6PRsy1iD3kzOCWFN3icEFJjYLJ3pDasWcmZJa+thC6qTC5e
	5FVC420aGrqa8ywNolbceCeV6Un2zQUhUTiXQqNPvFeSz2pZMaNVsJS4ruG126gmjzrC
	M1PHZapN5f3FTUfl/XDsqwArYMQXoiQ6C961VDytTlr+LKkBIX3tC0gB7h+2tE8c3wQa
	fygw==
X-Gm-Message-State: AOJu0YyFr4xTC3pVy3Hi5GGxkpnTVRN7+s21EbKF+AyRW5wbv+RGxXgU
	keSixRt0r+M+DKYi9JOq+/1Z4xbd
X-Google-Smtp-Source: 
 AGHT+IGZSDhlZ/WOZnLAj6/YHr81Q8JOVgmR4q/o+vjrkd92gwMh6floQHP0L0d9THTX1b7PSXtn7w==
X-Received: by 2002:a05:6402:1042:b0:540:c989:fcdd with SMTP id
	e2-20020a056402104200b00540c989fcddmr1279868edu.11.1699699362048;
	Sat, 11 Nov 2023 02:42:42 -0800 (PST)
X-BeenThere: linux-amarula@amarulasolutions.com
Received: by 2002:aa7:d044:0:b0:53d:beed:e28f with SMTP id
	n4-20020aa7d044000000b0053dbeede28fls656694edo.1.-pod-prod-02-eu;
	Sat, 11 Nov 2023 02:42:40 -0800 (PST)
X-Received: by 2002:a17:906:4351:b0:9df:bc50:2508 with SMTP id
	z17-20020a170906435100b009dfbc502508mr882314ejm.57.1699699360446;
	Sat, 11 Nov 2023 02:42:40 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1699699360; cv=none;
	d=google.com; s=arc-20160816;
	b=LWk2EbIiVrBtahTm/KAUv44JVv8fI/QhyJ/JarXA51TF3BZQOxQbZDt2I6Fk8AMnZ0
	HY0Yy2hfKMJSc08vBLksCROfo8zt5EWYeS5l22NyN+WkHx9ZDNncte0WTxC5yZADgHF8
	lF7PIZW+my75BZwNaFikH2InS/rhSfZut9D95mv64QKfm7d8u0GDvROvOm51fFAvQEqG
	gpNKaBAalW9SyEcA98yriELiThT5Wk+kR/mv601V0bv8UG5yttzl/gGLD1GWiFx+4sgS
	2VKOy3hnCxysNoYwUJ7y7HixCBprXA5nBXORulh8KvPlV3mcygf1VGw1FGu+Ay0ptpWl
	ocFg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=content-transfer-encoding:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=GD7GxvQQhDBqOuYxhMX/0KhWBgo/RCUVCo38r5g0tkk=;
	fh=CRQFspQ+XVmz3jTpDmawxjgq3paXQGVEDP+3Wpr+FXU=;
	b=snDga3HSS4FRja4gmt24pJsBsSCx5fIx3m2G/dgk044cquJpMTcoz/A8slWMwbtSgi
	Mftp40i/OFT71QINxXo03627LcwH/7SYkQmBdTBjU6ZkXGMZFbKWheRfHbasM+3qM1Tn
	66BFQ5QaV0jo0TrMOaaVYnMnnZrrRnt/cpAuYg9D+YIK1cIglzCW9/b3ie7l0WseyrrR
	z4tVEpXPydqWNAvwcFxuzbtAYwqB1LMEGbWgB1RfI9Tzq3nn31WBVamm3WRnbD4mR6qJ
	Q3jnYvjMCB4Vfk0LmYqumLcy8E3mgEP3cxSvhA9xkCaM7EqYsuQz78YxaEn+X2wUuEtw
	3TvA==
ARC-Authentication-Results: i=1; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=EQ2oF+Wo;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
Received: from mail-sor-f41.google.com (mail-sor-f41.google.com.
	[209.85.220.41]) by mx.google.com with SMTPS id
	20-20020a17090602d400b009ae5d029dadsor250255ejk.18.2023.11.11.02.42.40
	for <linux-amarula@amarulasolutions.com>
	(Google Transport Security); Sat, 11 Nov 2023 02:42:40 -0800 (PST)
Received-SPF: pass (google.com: domain of
	dario.binacchi@amarulasolutions.com designates 209.85.220.41
	as permitted sender) client-ip=209.85.220.41;
X-Received: by 2002:a17:906:7f94:b0:9c4:67f:3ef5 with SMTP id
	f20-20020a1709067f9400b009c4067f3ef5mr1052700ejr.50.1699699359971;
	Sat, 11 Nov 2023 02:42:39 -0800 (PST)
Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it
	(host-79-20-97-182.retail.telecomitalia.it. [79.20.97.182])
	by smtp.gmail.com with ESMTPSA id
	ga33-20020a1709070c2100b0099e12a49c8fsm872183ejc.173.2023.11.11.02.42.38
	(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
	Sat, 11 Nov 2023 02:42:39 -0800 (PST)
From: Dario Binacchi <dario.binacchi@amarulasolutions.com>
To: linux-kernel@vger.kernel.org
Cc: linux-amarula@amarulasolutions.com,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	Fabio Estevam <festevam@gmail.com>, Helge Deller <deller@gmx.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>,
	dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org,
	linux-fbdev@vger.kernel.org
Subject: [PATCH 03/10] fbdev: imxfb: use BIT, FIELD_{GET,
	PREP} and GENMASK macros
Date: Sat, 11 Nov 2023 11:41:52 +0100
Message-ID: <20231111104225.136512-4-dario.binacchi@amarulasolutions.com>
X-Mailer: git-send-email 2.42.0
In-Reply-To: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com>
References: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com>
MIME-Version: 1.0
X-Original-Sender: dario.binacchi@amarulasolutions.com
X-Original-Authentication-Results: mx.google.com;       dkim=pass
	header.i=@amarulasolutions.com header.s=google header.b=EQ2oF+Wo;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Mailing-list: list linux-amarula@amarulasolutions.com;
	contact linux-amarula+owners@amarulasolutions.com
List-ID: <linux-amarula.amarulasolutions.com>
X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com
X-Google-Group-Id: 476853432473
List-Post: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>,
	<mailto:linux-amarula@amarulasolutions.com>
List-Help: 
 <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>,
	<mailto:linux-amarula+help@amarulasolutions.com>
List-Archive: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/>
List-Unsubscribe: 
 <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>,
	<https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe>

Replace opencoded masking and shifting, with BIT(), GENMASK(),
FIELD_GET() and FIELD_PREP() macros.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 drivers/video/fbdev/imxfb.c | 113 +++++++++++++++++++-----------------
 1 file changed, 59 insertions(+), 54 deletions(-)

diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
index 6af5f09d9c85..b7ef43a7930a 100644
--- a/drivers/video/fbdev/imxfb.c
+++ b/drivers/video/fbdev/imxfb.c
@@ -34,6 +34,7 @@
 #include <linux/math64.h>
 #include <linux/of.h>
 #include <linux/of_device.h>
+#include <linux/bitfield.h>
 
 #include <linux/regulator/consumer.h>
 
@@ -58,48 +59,49 @@ struct imx_fb_videomode {
 #define LCDC_SSA	0x00
 
 #define LCDC_SIZE	0x04
-#define SIZE_XMAX(x)	((((x) >> 4) & 0x3f) << 20)
+#define SIZE_XMAX_MASK	GENMASK(25, 20)
 
-#define YMAX_MASK_IMX1	0x1ff
-#define YMAX_MASK_IMX21	0x3ff
+#define YMAX_MASK_IMX1	GENMASK(8, 0)
+#define YMAX_MASK_IMX21	GENMASK(9, 0)
 
 #define LCDC_VPW	0x08
-#define VPW_VPW(x)	((x) & 0x3ff)
+#define VPW_VPW_MASK	GENMASK(9, 0)
 
 #define LCDC_CPOS	0x0C
-#define CPOS_CC1	(1<<31)
-#define CPOS_CC0	(1<<30)
-#define CPOS_OP		(1<<28)
-#define CPOS_CXP(x)	(((x) & 3ff) << 16)
+#define CPOS_CC1	BIT(31)
+#define CPOS_CC0	BIT(30)
+#define CPOS_OP		BIT(28)
+#define CPOS_CXP_MASK	GENMASK(25, 16)
 
 #define LCDC_LCWHB	0x10
-#define LCWHB_BK_EN	(1<<31)
-#define LCWHB_CW(w)	(((w) & 0x1f) << 24)
-#define LCWHB_CH(h)	(((h) & 0x1f) << 16)
-#define LCWHB_BD(x)	((x) & 0xff)
+#define LCWHB_BK_EN	BIT(31)
+#define LCWHB_CW_MASK	GENMASK(28, 24)
+#define LCWHB_CH_MASK	GENMASK(20, 16)
+#define LCWHB_BD_MASK	GENMASK(7, 0)
 
 #define LCDC_LCHCC	0x14
 
 #define LCDC_PCR	0x18
-#define PCR_TFT		(1 << 31)
-#define PCR_COLOR	(1 << 30)
-#define PCR_BPIX_8	(3 << 25)
-#define PCR_BPIX_12	(4 << 25)
-#define PCR_BPIX_16	(5 << 25)
-#define PCR_BPIX_18	(6 << 25)
+#define PCR_TFT		BIT(31)
+#define PCR_COLOR	BIT(30)
+#define PCR_BPIX_MASK	GENMASK(27, 25)
+#define PCR_BPIX_8	3
+#define PCR_BPIX_12	4
+#define PCR_BPIX_16	5
+#define PCR_BPIX_18	6
 
 #define LCDC_HCR	0x1C
-#define HCR_H_WIDTH(x)	(((x) & 0x3f) << 26)
-#define HCR_H_WAIT_1(x)	(((x) & 0xff) << 8)
-#define HCR_H_WAIT_2(x)	((x) & 0xff)
+#define HCR_H_WIDTH_MASK	GENMASK(31, 26)
+#define HCR_H_WAIT_1_MASK	GENMASK(15, 8)
+#define HCR_H_WAIT_2_MASK	GENMASK(7, 0)
 
 #define LCDC_VCR	0x20
-#define VCR_V_WIDTH(x)	(((x) & 0x3f) << 26)
-#define VCR_V_WAIT_1(x)	(((x) & 0xff) << 8)
-#define VCR_V_WAIT_2(x)	((x) & 0xff)
+#define VCR_V_WIDTH_MASK	GENMASK(31, 26)
+#define VCR_V_WAIT_1_MASK	GENMASK(15, 8)
+#define VCR_V_WAIT_2_MASK	GENMASK(7, 0)
 
 #define LCDC_POS	0x24
-#define POS_POS(x)	((x) & 1f)
+#define POS_POS_MASK	GENMASK(4, 0)
 
 #define LCDC_LSCR1	0x28
 /* bit fields in imxfb.h */
@@ -112,24 +114,24 @@ struct imx_fb_videomode {
 
 #define LCDC_RMCR	0x34
 
-#define RMCR_LCDC_EN_MX1	(1<<1)
+#define RMCR_LCDC_EN_MX1	BIT(1)
 
-#define RMCR_SELF_REF	(1<<0)
+#define RMCR_SELF_REF	BIT(0)
 
 #define LCDC_LCDICR	0x38
-#define LCDICR_INT_SYN	(1<<2)
-#define LCDICR_INT_CON	(1)
+#define LCDICR_INT_SYN	BIT(2)
+#define LCDICR_INT_CON	BIT(0)
 
 #define LCDC_LCDISR	0x40
-#define LCDISR_UDR_ERR	(1<<3)
-#define LCDISR_ERR_RES	(1<<2)
-#define LCDISR_EOF	(1<<1)
-#define LCDISR_BOF	(1<<0)
+#define LCDISR_UDR_ERR	BIT(3)
+#define LCDISR_ERR_RES	BIT(2)
+#define LCDISR_EOF	BIT(1)
+#define LCDISR_BOF	BIT(0)
 
 #define IMXFB_LSCR1_DEFAULT 0x00120300
 
 #define LCDC_LAUSCR	0x80
-#define LAUSCR_AUS_MODE	(1<<31)
+#define LAUSCR_AUS_MODE	BIT(31)
 
 /* Used fb-mode. Can be set on kernel command line, therefore file-static. */
 static const char *fb_mode;
@@ -420,15 +422,15 @@ static int imxfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
 
 	switch (var->bits_per_pixel) {
 	case 32:
-		pcr |= PCR_BPIX_18;
+		pcr |= FIELD_PREP(PCR_BPIX_MASK, PCR_BPIX_18);
 		rgb = &def_rgb_18;
 		break;
 	case 16:
 	default:
 		if (is_imx1_fb(fbi))
-			pcr |= PCR_BPIX_12;
+			pcr |= FIELD_PREP(PCR_BPIX_MASK, PCR_BPIX_12);
 		else
-			pcr |= PCR_BPIX_16;
+			pcr |= FIELD_PREP(PCR_BPIX_MASK, PCR_BPIX_16);
 
 		if (imxfb_mode->pcr & PCR_TFT)
 			rgb = &def_rgb_16_tft;
@@ -436,7 +438,7 @@ static int imxfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
 			rgb = &def_rgb_16_stn;
 		break;
 	case 8:
-		pcr |= PCR_BPIX_8;
+		pcr |= FIELD_PREP(PCR_BPIX_MASK, PCR_BPIX_8);
 		rgb = &def_rgb_8;
 		break;
 	}
@@ -520,7 +522,7 @@ static int imxfb_enable_controller(struct imxfb_info *fbi)
 	writel(fbi->map_dma, fbi->regs + LCDC_SSA);
 
 	/* panning offset 0 (0 pixel offset)        */
-	writel(0x00000000, fbi->regs + LCDC_POS);
+	writel(FIELD_PREP(POS_POS_MASK, 0), fbi->regs + LCDC_POS);
 
 	/* disable hardware cursor */
 	writel(readl(fbi->regs + LCDC_CPOS) & ~(CPOS_CC0 | CPOS_CC1),
@@ -654,21 +656,24 @@ static int imxfb_activate_var(struct fb_var_screeninfo *var, struct fb_info *inf
 #endif
 
 	/* physical screen start address	    */
-	writel(VPW_VPW(var->xres * var->bits_per_pixel / 8 / 4),
-		fbi->regs + LCDC_VPW);
-
-	writel(HCR_H_WIDTH(var->hsync_len - 1) |
-		HCR_H_WAIT_1(var->right_margin - 1) |
-		HCR_H_WAIT_2(var->left_margin - left_margin_low),
-		fbi->regs + LCDC_HCR);
-
-	writel(VCR_V_WIDTH(var->vsync_len) |
-		VCR_V_WAIT_1(var->lower_margin) |
-		VCR_V_WAIT_2(var->upper_margin),
-		fbi->regs + LCDC_VCR);
-
-	writel(SIZE_XMAX(var->xres) | (var->yres & ymax_mask),
-			fbi->regs + LCDC_SIZE);
+	writel(FIELD_PREP(VPW_VPW_MASK,
+			  var->xres * var->bits_per_pixel / 8 / 4),
+	       fbi->regs + LCDC_VPW);
+
+	writel(FIELD_PREP(HCR_H_WIDTH_MASK, var->hsync_len - 1) |
+	       FIELD_PREP(HCR_H_WAIT_1_MASK, var->right_margin - 1) |
+	       FIELD_PREP(HCR_H_WAIT_2_MASK,
+			  var->left_margin - left_margin_low),
+	       fbi->regs + LCDC_HCR);
+
+	writel(FIELD_PREP(VCR_V_WIDTH_MASK, var->vsync_len) |
+	       FIELD_PREP(VCR_V_WAIT_1_MASK, var->lower_margin) |
+	       FIELD_PREP(VCR_V_WAIT_2_MASK, var->upper_margin),
+	       fbi->regs + LCDC_VCR);
+
+	writel(FIELD_PREP(SIZE_XMAX_MASK, var->xres >> 4) |
+	       (var->yres & ymax_mask),
+	       fbi->regs + LCDC_SIZE);
 
 	writel(fbi->pcr, fbi->regs + LCDC_PCR);
 	if (fbi->pwmr)

From patchwork Sat Nov 11 10:41:53 2023
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Dario Binacchi <dario.binacchi@amarulasolutions.com>
X-Patchwork-Id: 3001
Return-Path: 
 <linux-amarula+bncBCQ4XFG47UFRBI5VXWVAMGQEJCU2Q3A@amarulasolutions.com>
X-Original-To: linux-amarula@patchwork.amarulasolutions.com
Delivered-To: linux-amarula@patchwork.amarulasolutions.com
Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com
	[209.85.208.70])
	by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 75CDE3F057
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Sat, 11 Nov 2023 11:42:43 +0100 (CET)
Received: by mail-ed1-f70.google.com with SMTP id
	4fb4d7f45d1cf-54356d8ea43sf2046602a12.2
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Sat, 11 Nov 2023 02:42:43 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1699699363; cv=pass;
	d=google.com; s=arc-20160816;
	b=Gv6kIHE1vyROXBzuG1MToAdYLZqowtOT2NCM50c2uQTdyKw3UC7NX54NTs1Zq7ap5o
	gUFyPV/kPWuTKGhCBhS++PVJTV2GoEJnnO9SRTn8MEs8P3XtNmgDFCUmDlAA+SeqPdBR
	55WAboRWOm/IK/8nG/wm5eYIxCPcOLpXCv4yjDjf0nozfRkOg9phLYP2CvTwR1ohywqN
	B3/5C/pHrFNsSc/bSl6GnxNRNNXHT+UFMAArigTa2oFaRDFVq5NDTvUiF26Avlcs0MkX
	mxIw6O3AZrZZIR7niRU++Ym6i71i3rIJlIvHEpdmwMKiEyykCqi0tCntDeqqD8xwFYsZ
	e07w==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=zUZK735Yr3+TtvwADh4fq0jQSebkuh+l86UMJ1QYIEo=;
	fh=CRQFspQ+XVmz3jTpDmawxjgq3paXQGVEDP+3Wpr+FXU=;
	b=qfHE+Y+dMyqOMY8e7iqnWsLlGgUO3bzMxU3Od9TiUMhOounMs81wEKE1WSIN0ghWad
	tJyLYAZYNqDVdN3eHIxNYtwXUF7DBd7JVCXg4gpsHtIwyWn9fpgDI/3SBARMa7RQ6tIW
	oBlafGu4RlxUHluqD+eZ/2sYcWGu+9FMmeeDhTNMmGp6FfH8/llHNJZXLt4q0XMwn+JJ
	F1t2x85uNaUERDskPzxmUSF8p9IC7Ui0jHCYtRONIT/yI/Bm7zUafiyzRdu+tuGIsswR
	1FwbnAmBGEWBvCC3HTxY5TUmlXSK9BVlqqHjEzyC6hc7tuotrSrFCpzvUB9XD4HxcdNB
	E7Jw==
ARC-Authentication-Results: i=2; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=Ln6dH3k3;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=amarulasolutions.com; s=google; t=1699699363; x=1700304163;
	darn=patchwork.amarulasolutions.com;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:x-original-authentication-results
	:x-original-sender:mime-version:references:in-reply-to:message-id
	:date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
	bh=zUZK735Yr3+TtvwADh4fq0jQSebkuh+l86UMJ1QYIEo=;
	b=aX3/0L2xYL9sHy14DpIS7+xoMw4GrxWNS3hKAnkdAEwrsgf3/pRCeWEEClmaAK12GW
	aJWxZuUwtX/jkxI++k9i8GA3eFO1FvEMqC7vgbeiilRkha2FHxaIStUYgmaBB0nOxC7O
	4Mdz2K3X8SQDNEFJCG56T19sLx7vN8kLh1NTU=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20230601; t=1699699363; x=1700304163;
	h=list-unsubscribe:list-archive:list-help:list-post
	:x-spam-checked-in-group:list-id:mailing-list:precedence
	:x-original-authentication-results:x-original-sender:mime-version
	:references:in-reply-to:message-id:date:subject:cc:to:from
	:x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id
	:reply-to;
	bh=zUZK735Yr3+TtvwADh4fq0jQSebkuh+l86UMJ1QYIEo=;
	b=a1voj6YsP4xqnTWZOPjFZrS6lODiuXRlOf5OckBR1iRSMgsTGqMVHUPl/bNEWzdDZ9
	9k441eaYMvF4RBazq24az0HTx6RiLGmk2l0o35xSsLkm3UpxRWi8Sdqranv7jh0bFiJT
	jzPm48ZCGsuRD5gkj+H/UG+KD5TflVU/rXWeDHCoUdoMxAh6UwiE0hohuzTnmxjXRVqh
	zKou7XJlJ0GKvt+qxIWH+0hsMHT1SZtbsLyOR2yHHZXsoYuhDZ/MGElnn8Xx5PBY4cIm
	O3feMdfMqDMKUGkf1UW9iuV5JWo0Fmvu0/fpSk4j9pGzbSH0NDu+5kopQsQIVaJ8Yv2x
	KG2Q==
X-Gm-Message-State: AOJu0YxUXzthsTDxLRQZjbwp4HV1fVYrUdhhF6F3tiXHa9T62vmze5gc
	YJNsfxSwXPpZCNfNTIifKxdyD0PN
X-Google-Smtp-Source: 
 AGHT+IHOUxD42eHq8IlIOFr/YNZYux47QsvU70Vk4ZWcssEjnBkzzS/PVEbhjbpyNXL9KugmXObQVQ==
X-Received: by 2002:aa7:d5cd:0:b0:53b:9948:cc1f with SMTP id
	d13-20020aa7d5cd000000b0053b9948cc1fmr1312536eds.12.1699699363263;
	Sat, 11 Nov 2023 02:42:43 -0800 (PST)
X-BeenThere: linux-amarula@amarulasolutions.com
Received: by 2002:a05:6402:1645:b0:542:df39:bcf2 with SMTP id
	s5-20020a056402164500b00542df39bcf2ls762905edx.1.-pod-prod-01-eu;
	Sat, 11 Nov 2023 02:42:42 -0800 (PST)
X-Received: by 2002:a17:906:24d4:b0:9c7:5a14:ecf2 with SMTP id
	f20-20020a17090624d400b009c75a14ecf2mr1102195ejb.56.1699699361699;
	Sat, 11 Nov 2023 02:42:41 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1699699361; cv=none;
	d=google.com; s=arc-20160816;
	b=SAGh5XJTokiqs6a/pyF6VaPZieZ06Qq8Zbh4j87HBOWVOkcHDxw9dAvS4m7/BHY0wK
	zOs3Vg4U/olt626Cvpz8dCeLfhib+ws4vkCGZIlinXX/UDYq8RVYzKi1IZVyWknXG1QV
	5vfJBP3C+sVVM+36tJNQcvI7lkbWPoQwrD7bF2WmFfCEOeQrq403TE+vLuGs6Pth2h6R
	c0EHG2iUmpbZyo2g43IqdYqRNr92pP8cZxEWg/znrlxhzsD8irq1KgPAjAdB2BzuWnUR
	PdqVvFo2MyXvZkoOcZt9xgGBLHwycD+de0HqlXjryTJfWkOmUHcvw1dNGh9i6nD1gLXt
	cVWg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=content-transfer-encoding:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=ZuBW6agG70lIoCkGnVCWEFfcl6uwNB9B1+pa2Yxc8Go=;
	fh=CRQFspQ+XVmz3jTpDmawxjgq3paXQGVEDP+3Wpr+FXU=;
	b=ErCQhStD13qn25cm9TB2b9smNOMxhysY1Fr4blmnCTSfLUkoKBPK/MhmHW5y9MNUWD
	RBAG5DvqCsXrCQHuf1mFCzNANOI3pRyp3FoTBzR8nyeKLPYggK5K44dDDI9J2UjkJzNI
	j3WUg6A2aPkG7uroshEn7m65vzLy1XmM43lqNdYjmFcyMKmEwucIw96MpCy5Elk13RZM
	3vnL1t1iL1LdRwMWAsr/X5xpkUBcQ3M/Y7XXWs6AjgWpRCdUtSIZ/9WZzLPVyFUi203t
	Q5wQZ97XjGJuXAo15V9edcYoP4q9x9Id+08wo32IHMFDz7Mve8eHWsq55bFpX662EZOz
	exCg==
ARC-Authentication-Results: i=1; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=Ln6dH3k3;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
Received: from mail-sor-f41.google.com (mail-sor-f41.google.com.
	[209.85.220.41]) by mx.google.com with SMTPS id
	v17-20020a17090651d100b009b2b42978adsor261523ejk.7.2023.11.11.02.42.41
	for <linux-amarula@amarulasolutions.com>
	(Google Transport Security); Sat, 11 Nov 2023 02:42:41 -0800 (PST)
Received-SPF: pass (google.com: domain of
	dario.binacchi@amarulasolutions.com designates 209.85.220.41
	as permitted sender) client-ip=209.85.220.41;
X-Received: by 2002:a17:906:3c9:b0:9e6:59d5:7a86 with SMTP id
	c9-20020a17090603c900b009e659d57a86mr915376eja.57.1699699361285;
	Sat, 11 Nov 2023 02:42:41 -0800 (PST)
Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it
	(host-79-20-97-182.retail.telecomitalia.it. [79.20.97.182])
	by smtp.gmail.com with ESMTPSA id
	ga33-20020a1709070c2100b0099e12a49c8fsm872183ejc.173.2023.11.11.02.42.40
	(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
	Sat, 11 Nov 2023 02:42:41 -0800 (PST)
From: Dario Binacchi <dario.binacchi@amarulasolutions.com>
To: linux-kernel@vger.kernel.org
Cc: linux-amarula@amarulasolutions.com,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	Fabio Estevam <festevam@gmail.com>, Helge Deller <deller@gmx.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>,
	dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org,
	linux-fbdev@vger.kernel.org
Subject: [PATCH 04/10] fbdev: imxfb: replace some magic numbers with
	constants
Date: Sat, 11 Nov 2023 11:41:53 +0100
Message-ID: <20231111104225.136512-5-dario.binacchi@amarulasolutions.com>
X-Mailer: git-send-email 2.42.0
In-Reply-To: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com>
References: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com>
MIME-Version: 1.0
X-Original-Sender: dario.binacchi@amarulasolutions.com
X-Original-Authentication-Results: mx.google.com;       dkim=pass
	header.i=@amarulasolutions.com header.s=google header.b=Ln6dH3k3;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Mailing-list: list linux-amarula@amarulasolutions.com;
	contact linux-amarula+owners@amarulasolutions.com
List-ID: <linux-amarula.amarulasolutions.com>
X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com
X-Google-Group-Id: 476853432473
List-Post: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>,
	<mailto:linux-amarula@amarulasolutions.com>
List-Help: 
 <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>,
	<mailto:linux-amarula+help@amarulasolutions.com>
List-Archive: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/>
List-Unsubscribe: 
 <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>,
	<https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe>

The patch gets rid of magic numbers replacing them with appropriate
macros.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 drivers/video/fbdev/imxfb.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
index b7ef43a7930a..485e57fa9389 100644
--- a/drivers/video/fbdev/imxfb.c
+++ b/drivers/video/fbdev/imxfb.c
@@ -89,6 +89,7 @@ struct imx_fb_videomode {
 #define PCR_BPIX_12	4
 #define PCR_BPIX_16	5
 #define PCR_BPIX_18	6
+#define PCR_PCD_MASK	GENMASK(5, 0)
 
 #define LCDC_HCR	0x1C
 #define HCR_H_WIDTH_MASK	GENMASK(31, 26)
@@ -414,8 +415,8 @@ static int imxfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
 
 	pcr = (unsigned int)tmp;
 
-	if (--pcr > 0x3F) {
-		pcr = 0x3F;
+	if (--pcr > PCR_PCD_MASK) {
+		pcr = PCR_PCD_MASK;
 		printk(KERN_WARNING "Must limit pixel clock to %luHz\n",
 				lcd_clk / pcr);
 	}
@@ -444,7 +445,7 @@ static int imxfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
 	}
 
 	/* add sync polarities */
-	pcr |= imxfb_mode->pcr & ~(0x3f | (7 << 25));
+	pcr |= imxfb_mode->pcr & ~(PCR_PCD_MASK | PCR_BPIX_MASK);
 
 	fbi->pcr = pcr;
 	/*

From patchwork Sat Nov 11 10:41:54 2023
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Dario Binacchi <dario.binacchi@amarulasolutions.com>
X-Patchwork-Id: 3002
Return-Path: 
 <linux-amarula+bncBCQ4XFG47UFRBJFVXWVAMGQE6WOR73A@amarulasolutions.com>
X-Original-To: linux-amarula@patchwork.amarulasolutions.com
Delivered-To: linux-amarula@patchwork.amarulasolutions.com
Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com
	[209.85.221.71])
	by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 25B193F057
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Sat, 11 Nov 2023 11:42:45 +0100 (CET)
Received: by mail-wr1-f71.google.com with SMTP id
	ffacd0b85a97d-32f7cfab43esf1409759f8f.1
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Sat, 11 Nov 2023 02:42:45 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1699699365; cv=pass;
	d=google.com; s=arc-20160816;
	b=t3P5IFrmMmbUsTPU0yOLwINCCHPwznWw6/gs3n2EzfOBT31++nP1ivUmB6Zf6GhRnI
	WnAQhXBLO4Nv2FIT/IzstfM9nO/uUtlNdix1S28MOuK1SS/bB7R7EEEsZVpOfsuWlQ5A
	WsuJslEEHSJFqHKO3sCCY7BfFD9tT9wUk+h8CVNhVX1jIdeJbgT7abLUaXwpS46LBXoW
	9VT6vJpsuQ/YRevx++68p55gUSnP4/fEg7ukIwauBh+ejR1jKqXARINsnSePltKf+ee4
	htUTGXZ2kS9Am+uQZpmkEq24atfspPz/Swto1tYm9JCeH/njmDx5Vv83aiA7cE+doit0
	GeLw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=UTKPSfuCkKCU/8P6GJcAbthdMjTEmxGeXRDOzasBvzw=;
	fh=CRQFspQ+XVmz3jTpDmawxjgq3paXQGVEDP+3Wpr+FXU=;
	b=gvbVXS5sMhhVMx0m3yaFGilVEUJzfUiMGWVEK36iH+YwkKfTqeqFn9rDHGU4mlB262
	4h4BixiZanstPF7TaP3mbPrbmkVvewxiHwszwC/955tN6TNMixNGzqoXk+nrAyVIuR8t
	NmnMQnxIJler1VObRRGkx/bswDIRXhcvYwsI+5YjXoOQAM3pWlj1r8Es8yfhvBHMCYMa
	aizNaIvxEHyzBSsTqvEieHENnZJ4PKpyxZcNy7FJHlj49iJ1p2CaxNq39FKw46Y+9d2m
	pzsaqjqiIoqG1MAneTk31F6ptXq5RRRYdpuzsWp7Oq/qaC03OSSBIxShk2JzIJQkJKTF
	3pGA==
ARC-Authentication-Results: i=2; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=HDkuf41u;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.65 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=amarulasolutions.com; s=google; t=1699699365; x=1700304165;
	darn=patchwork.amarulasolutions.com;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:x-original-authentication-results
	:x-original-sender:mime-version:references:in-reply-to:message-id
	:date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
	bh=UTKPSfuCkKCU/8P6GJcAbthdMjTEmxGeXRDOzasBvzw=;
	b=JFMcN1219QzK81z4ZMPn8U2konUw7gIgU0IMk7fwOav0ZBt4xulIlgbEqar+aqRKnH
	lm/VLmaI1fzsmYJiuUwFuzfuvj9wC9BnVty5+t6sZagbb9Szy8aMXoCeTqTLvIzleNRU
	D8X02knf46N9Mz+iRUBm/rKAwZNnIfrK3fzW4=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20230601; t=1699699365; x=1700304165;
	h=list-unsubscribe:list-archive:list-help:list-post
	:x-spam-checked-in-group:list-id:mailing-list:precedence
	:x-original-authentication-results:x-original-sender:mime-version
	:references:in-reply-to:message-id:date:subject:cc:to:from
	:x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id
	:reply-to;
	bh=UTKPSfuCkKCU/8P6GJcAbthdMjTEmxGeXRDOzasBvzw=;
	b=fo68uuNqPUMrRH/rvqgcq9AKImZ4a0dHpGP8Ea2fJXnbXJuLUhMQHVbX+x3F5diOHU
	0cGvjQx6vThS8yTj9k3k5+lvoJCEr9n9uanxOpASdX1lrSCAl3FO5c45mg0xepl19WlQ
	Z37Co0rhxmmbApt9d2TF1reNXERs3/yMij+EVPIbBTptBnZoYO+Yg2HHvRM8BmV+NLtr
	I2fnLwwmCRRwNoZWX4i8OYckWA6ulLId0WdkBpbruVWTQKht53e8E47/f+X6BmRIzBGk
	kIBupv5Fg1vvHBsETkZTy656YsfwZVaVxNnp2EnvDgiQt+xlItt3CBzW5Bdl/IhJQurO
	b1uQ==
X-Gm-Message-State: AOJu0Yw0NpZDyT/ix2oeSFQMQXUiz0WCf7zFmN0tNnFmLQzTxhITdxb+
	4x9muYY+np2Nu0AUVdGriXIAooBnNTpD6Vz8
X-Google-Smtp-Source: 
 AGHT+IEblRHfsI+GOTZl2R7QwRxcoI78LZfAqjR1mEhVZiOSGITdo+wY4esQaOD5GHMLim7EM85EtQ==
X-Received: by 2002:a05:6000:1acc:b0:331:338c:c74d with SMTP id
	i12-20020a0560001acc00b00331338cc74dmr1291555wry.70.1699699364842;
	Sat, 11 Nov 2023 02:42:44 -0800 (PST)
X-BeenThere: linux-amarula@amarulasolutions.com
Received: by 2002:a05:6000:1e8b:b0:32f:7fdc:ea3 with SMTP id
	dd11-20020a0560001e8b00b0032f7fdc0ea3ls825926wrb.1.-pod-prod-04-eu;
	Sat, 11 Nov 2023 02:42:43 -0800 (PST)
X-Received: by 2002:a17:906:7943:b0:9d3:e48f:30d3 with SMTP id
	l3-20020a170906794300b009d3e48f30d3mr1318360ejo.31.1699699363220;
	Sat, 11 Nov 2023 02:42:43 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1699699363; cv=none;
	d=google.com; s=arc-20160816;
	b=i4FhQOrab6I6/tYlH3GJXRyy6z02D+cno9Kpp1n04I8HgUebSPozV1N9SgGfNcH/ZR
	fdC+Tj2HHcrPoX9M4sr3pkKmAIPzUWmat3UdsAq8EslcZ2VwaBKV15vAF8yHHNkzF8Po
	smz8a2i0aCJsz3BbiDVFBLvHsaME103TInxmJs4L7ArqzH5xPlnopZUs1clPO9AIzB8c
	4ysZ9B2HA3jlVCDypMgz1dMu97YPsDQfTTcs7Ntrc7jsidQ6DsOPWx2wX0GzqX05Qr8o
	kidq5q90q4/c5fPfcXFGLi6d3TwtIDy0dOhD65lkQKBDaAec1y+8SKkYnbWZloaipRBC
	8pqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=content-transfer-encoding:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=VfR080tdra7BLhUIWSvcaEDMSQNVyZv5MjwAaJaquw0=;
	fh=CRQFspQ+XVmz3jTpDmawxjgq3paXQGVEDP+3Wpr+FXU=;
	b=pC69pH4F3HCEb17mkqlqvgEgkaQFNNvmHCyjjMnqfFCBH448/lMx8fN8hpO4bfThoN
	zcFjNoANGRKqk+mTtQmwidsYMB4OAfYHxmcHnYJnpwNaw+95Fw3WiTa8gvcsKR45SvUM
	a8G9E0oybeAN5/r3gVHVN+zc92di1ylZmBRlU+QpFm/nNa/9qHVzqUPja4Upjiyp22um
	DDXGoI64472/FxqhE82k/0u/Ufpw3jfNQrVMjB6MUNtGdl87Qu3VCLHx8revoUR15ZpR
	la0qgIZl31E1wwKMHrrtL1F7Zz0u5d35QUQRFSG7AkAVja1/Iv7/8T3R/r8069eoiiUO
	466Q==
ARC-Authentication-Results: i=1; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=HDkuf41u;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.65 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
Received: from mail-sor-f65.google.com (mail-sor-f65.google.com.
	[209.85.220.65]) by mx.google.com with SMTPS id
	10-20020a170906224a00b009dd97aaafcbsor260085ejr.17.2023.11.11.02.42.43
	for <linux-amarula@amarulasolutions.com>
	(Google Transport Security); Sat, 11 Nov 2023 02:42:43 -0800 (PST)
Received-SPF: pass (google.com: domain of
	dario.binacchi@amarulasolutions.com designates 209.85.220.65
	as permitted sender) client-ip=209.85.220.65;
X-Received: by 2002:a17:906:32d9:b0:9cc:97b:5a15 with SMTP id
	k25-20020a17090632d900b009cc097b5a15mr963727ejk.64.1699699362713;
	Sat, 11 Nov 2023 02:42:42 -0800 (PST)
Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it
	(host-79-20-97-182.retail.telecomitalia.it. [79.20.97.182])
	by smtp.gmail.com with ESMTPSA id
	ga33-20020a1709070c2100b0099e12a49c8fsm872183ejc.173.2023.11.11.02.42.41
	(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
	Sat, 11 Nov 2023 02:42:42 -0800 (PST)
From: Dario Binacchi <dario.binacchi@amarulasolutions.com>
To: linux-kernel@vger.kernel.org
Cc: linux-amarula@amarulasolutions.com,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	Fabio Estevam <festevam@gmail.com>, Helge Deller <deller@gmx.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>,
	dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org,
	linux-fbdev@vger.kernel.org
Subject: [PATCH 05/10] fbdev: imxfb: add missing SPDX tag
Date: Sat, 11 Nov 2023 11:41:54 +0100
Message-ID: <20231111104225.136512-6-dario.binacchi@amarulasolutions.com>
X-Mailer: git-send-email 2.42.0
In-Reply-To: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com>
References: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com>
MIME-Version: 1.0
X-Original-Sender: dario.binacchi@amarulasolutions.com
X-Original-Authentication-Results: mx.google.com;       dkim=pass
	header.i=@amarulasolutions.com header.s=google header.b=HDkuf41u;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.65 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Mailing-list: list linux-amarula@amarulasolutions.com;
	contact linux-amarula+owners@amarulasolutions.com
List-ID: <linux-amarula.amarulasolutions.com>
X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com
X-Google-Group-Id: 476853432473
List-Post: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>,
	<mailto:linux-amarula@amarulasolutions.com>
List-Help: 
 <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>,
	<mailto:linux-amarula+help@amarulasolutions.com>
List-Archive: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/>
List-Unsubscribe: 
 <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>,
	<https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe>

Resolve the following warning reported by checkpatch.pl:

WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

The patch also removes some license info made redundant by the addition
of the SPDX tag.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 drivers/video/fbdev/imxfb.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
index 485e57fa9389..de1434069530 100644
--- a/drivers/video/fbdev/imxfb.c
+++ b/drivers/video/fbdev/imxfb.c
@@ -1,13 +1,10 @@
+// SPDX-License-Identifier: GPL-2.0-only
 /*
  *  Freescale i.MX Frame Buffer device driver
  *
  *  Copyright (C) 2004 Sascha Hauer, Pengutronix
  *   Based on acornfb.c Copyright (C) Russell King.
  *
- * This file is subject to the terms and conditions of the GNU General Public
- * License.  See the file COPYING in the main directory of this archive for
- * more details.
- *
  * Please direct your questions and comments on this driver to the following
  * email address:
  *

From patchwork Sat Nov 11 10:41:55 2023
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Dario Binacchi <dario.binacchi@amarulasolutions.com>
X-Patchwork-Id: 3003
Return-Path: 
 <linux-amarula+bncBCQ4XFG47UFRBJNVXWVAMGQEFWOY66A@amarulasolutions.com>
X-Original-To: linux-amarula@patchwork.amarulasolutions.com
Delivered-To: linux-amarula@patchwork.amarulasolutions.com
Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com
	[209.85.208.70])
	by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 3EF923F057
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Sat, 11 Nov 2023 11:42:46 +0100 (CET)
Received: by mail-ed1-f70.google.com with SMTP id
	4fb4d7f45d1cf-54366567af4sf3368389a12.1
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Sat, 11 Nov 2023 02:42:46 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1699699366; cv=pass;
	d=google.com; s=arc-20160816;
	b=U8ioNQeASs/9l463wUkVoX1yKmt+q7uesYQB6A6dhEPnpzC4J5TQdtb1DLPBv1FXJo
	w4HK8WpnCgSl7yyelImCXQf0KIwPZ0sVzHHnk+hmwQ+Q4POxlhsIEXOyoIYTH0aIq6mH
	hLeJV2vnkN5CeMriFZiM9nN2YTGiHlmBo2kwqY3z1zQZhRQxHFE0GLf25hghokWr7HnL
	pgHBfEmTPUEBzOp1FCn2Bh9JVE1Wd5Paeivyna2cLeMJoLVgbw9MLbCkF6l6Vb+r9NsM
	OJqqNqb8kvvR7bakk8XbWCFFRN8IAqu5mwlb7gqhl78P2EX4okr5U8LQfFQEfnGetI8D
	VRWg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=n5ZA4eNFC3Y5cpyx5VFAFZ/R79Zrzw2X3HvWsNxEswI=;
	fh=CRQFspQ+XVmz3jTpDmawxjgq3paXQGVEDP+3Wpr+FXU=;
	b=l7Lr6fPtr9/YuPGP3z2NJg5d+0VsmdNSPbcy11NyVp1FQRBQI6OA8U5LQ3I2Cf0fEx
	E0pZCJU7mijfsjoKiry8g9KTz9smZINc4i4vNz6ZlmDr0JTwCicrNyYURsNUO4G0HUuN
	HvbIFBsQA7W3OjnELrLsAy5R07+f1Aedwvv4etcG3WrpCqgnhOJQgY5tTzfpGsI5tIR9
	lYlWjCAfruvIfjklPitzqtQZkPZEzGlTbNgiDJbGcL7iGgGqcvA+kuO6K/H3DrxgPWj5
	KEIctmIl127pvsDYlhqyXQv8/f6yrGY9rUH3EARDclBvIF74n+LZeeIAqzU/osg7mlQA
	VO7A==
ARC-Authentication-Results: i=2; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=DbBWP2XH;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=amarulasolutions.com; s=google; t=1699699366; x=1700304166;
	darn=patchwork.amarulasolutions.com;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:x-original-authentication-results
	:x-original-sender:mime-version:references:in-reply-to:message-id
	:date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
	bh=n5ZA4eNFC3Y5cpyx5VFAFZ/R79Zrzw2X3HvWsNxEswI=;
	b=fEu+kv4r4UT0kPz2B+EVPphE9n1RSmV6AqBRdeJyv8pWmsDICtX7Xk/TQJqhu/kD2h
	lYQMhJGdjQZA1yuFpNBEKjKD6p/gt0yD4JhOG2/ihrL3hwPGHFchPpXTa0kd2jQBcew4
	T2XB1qB6HNtw06dkdHXn9CL9H4vEZc97s+U68=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20230601; t=1699699366; x=1700304166;
	h=list-unsubscribe:list-archive:list-help:list-post
	:x-spam-checked-in-group:list-id:mailing-list:precedence
	:x-original-authentication-results:x-original-sender:mime-version
	:references:in-reply-to:message-id:date:subject:cc:to:from
	:x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id
	:reply-to;
	bh=n5ZA4eNFC3Y5cpyx5VFAFZ/R79Zrzw2X3HvWsNxEswI=;
	b=JcP9iZTM13eoGRWxgbJiewig/e1GbB7ZyujHtzPXxzUAdz6eQkphuhgg3nM42/iix0
	hjNCUmVyW412ME8G+MjHCrA7VaflGxrTtEMKfDLDZ7VjWcgKDIE+RB3IFyR6xU7th6Sy
	gX02pV24NtjSa+CoF6qfMi7JmypfM0pRTQH4DFuPw99miLeuyevuM8lyEseRDmJkY84z
	cHwZu2oBri+Vj/E2ybnYq3spsKDd4MAPZVznYRbVg1iZnOEhB4UY6MBxsMJlb3E4ZOON
	kh8bgWR69+To1NB744yZT18251m99UGQWepahdxPJ/vCbCktfZIjfNyc6ErAY+K+wfA0
	Y8SQ==
X-Gm-Message-State: AOJu0YwXjwVZoHvLpxw1niRM/o7ds1TcUqYczYaoRTPpIQjH4DdPwKUr
	kxxBjqHPUdDsXy8GGMfpb29RZ5XTHL0M9RET
X-Google-Smtp-Source: 
 AGHT+IGhRw45cjnKmLFxGamQJVNdo2AlcDW80BgxaomtQ5yaSpq0BETrUnhNzXBN4d16rasb7d8z7w==
X-Received: by 2002:a05:6402:35cb:b0:544:3ad0:37ad with SMTP id
	z11-20020a05640235cb00b005443ad037admr4547816edc.3.1699699366080;
	Sat, 11 Nov 2023 02:42:46 -0800 (PST)
X-BeenThere: linux-amarula@amarulasolutions.com
Received: by 2002:a05:6402:c4e:b0:547:2571:d5ae with SMTP id
	cs14-20020a0564020c4e00b005472571d5aels6219edb.1.-pod-prod-00-eu;
	Sat, 11 Nov 2023 02:42:44 -0800 (PST)
X-Received: by 2002:a17:907:c07:b0:9e5:26b2:b38d with SMTP id
	ga7-20020a1709070c0700b009e526b2b38dmr1905094ejc.10.1699699364487;
	Sat, 11 Nov 2023 02:42:44 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1699699364; cv=none;
	d=google.com; s=arc-20160816;
	b=FkQyJ+CuumwxcF46CEEI+58gmEcfpBsQuKFwBUSeWKh0YZ6ZKQ91YrutkF/cdGKq3f
	r4KiPlNnN/VZ9iLBGhBrz2vA/GBqR4Mx8M48P/5EI1jFEQ3d7jvXOXnsqTM20NadzBWO
	h9+d1FN5fs4e7+D68graLLXeCNA5Da3fuo1h2dhtimw/9hsB/r5yobRZxElPiP0dEc9P
	1O3gQWf4q8W9+3Au+f4vNdCIxd3kGUvevKW9ET3x8OOcVns6frBa4OrbBDy7loE56hLX
	HFDc5QptJk6oQls58iCWopyBhetheGUqYj6+f0T5muQoJFsetLYkpGH8oIvH+k3RpSgT
	aDUA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=content-transfer-encoding:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=gKRsMdTRp52wX/RfOne0bAjVlYqKCb2FkmXxuvgSsdI=;
	fh=CRQFspQ+XVmz3jTpDmawxjgq3paXQGVEDP+3Wpr+FXU=;
	b=IoSZI4p3QoPksgAQ0hvHfJLaieIqCf9j4T0fo/srUfX4Xa3ZVBbrz3C7MW8EOYyIAw
	e1JIrvxdabiDaQdS24i/1rULKagrh7lk8pGJCdxQGYj5Bd5rdAjumNltxYOgGPuuC7ob
	BpmADyY25cusSNcUCOZyRi0/kOE2tIhmaz9uj6gGQkPljMWrxb4ySun+J85vJJTUJaLl
	5W+4Yw3MGDwpgzG4M2wswlSMWRmCXDxMobGRfJYZzDmL8GBO4BwhNg9fm7tXIrCkcWjS
	YnutLqW5yg4WGzNr3bWzs1DOsoAGFUqgInPrZE8XdiJCj7+4jM0Xh7UvqzA7ZJALQ7KZ
	gs5g==
ARC-Authentication-Results: i=1; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=DbBWP2XH;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
Received: from mail-sor-f41.google.com (mail-sor-f41.google.com.
	[209.85.220.41]) by mx.google.com with SMTPS id
	un4-20020a170907cb8400b009b2a78a219esor278037ejc.3.2023.11.11.02.42.44
	for <linux-amarula@amarulasolutions.com>
	(Google Transport Security); Sat, 11 Nov 2023 02:42:44 -0800 (PST)
Received-SPF: pass (google.com: domain of
	dario.binacchi@amarulasolutions.com designates 209.85.220.41
	as permitted sender) client-ip=209.85.220.41;
X-Received: by 2002:a17:906:4e4d:b0:9ba:8ed:ea58 with SMTP id
	g13-20020a1709064e4d00b009ba08edea58mr1653246ejw.30.1699699364258;
	Sat, 11 Nov 2023 02:42:44 -0800 (PST)
Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it
	(host-79-20-97-182.retail.telecomitalia.it. [79.20.97.182])
	by smtp.gmail.com with ESMTPSA id
	ga33-20020a1709070c2100b0099e12a49c8fsm872183ejc.173.2023.11.11.02.42.43
	(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
	Sat, 11 Nov 2023 02:42:43 -0800 (PST)
From: Dario Binacchi <dario.binacchi@amarulasolutions.com>
To: linux-kernel@vger.kernel.org
Cc: linux-amarula@amarulasolutions.com,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	Fabio Estevam <festevam@gmail.com>, Helge Deller <deller@gmx.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>,
	dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org,
	linux-fbdev@vger.kernel.org
Subject: [PATCH 06/10] fbdev: imxfb: drop ftrace-like logging
Date: Sat, 11 Nov 2023 11:41:55 +0100
Message-ID: <20231111104225.136512-7-dario.binacchi@amarulasolutions.com>
X-Mailer: git-send-email 2.42.0
In-Reply-To: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com>
References: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com>
MIME-Version: 1.0
X-Original-Sender: dario.binacchi@amarulasolutions.com
X-Original-Authentication-Results: mx.google.com;       dkim=pass
	header.i=@amarulasolutions.com header.s=google header.b=DbBWP2XH;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Mailing-list: list linux-amarula@amarulasolutions.com;
	contact linux-amarula+owners@amarulasolutions.com
List-ID: <linux-amarula.amarulasolutions.com>
X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com
X-Google-Group-Id: 476853432473
List-Post: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>,
	<mailto:linux-amarula@amarulasolutions.com>
List-Help: 
 <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>,
	<mailto:linux-amarula+help@amarulasolutions.com>
List-Archive: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/>
List-Unsubscribe: 
 <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>,
	<https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe>

Resolve the following warning reported by checkpatch:

WARNING: Unnecessary ftrace-like logging - prefer using ftrace

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 drivers/video/fbdev/imxfb.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
index de1434069530..83497f6998f1 100644
--- a/drivers/video/fbdev/imxfb.c
+++ b/drivers/video/fbdev/imxfb.c
@@ -694,8 +694,6 @@ static int imxfb_init_fbinfo(struct platform_device *pdev)
 	struct imxfb_info *fbi = info->par;
 	struct device_node *np;
 
-	pr_debug("%s\n",__func__);
-
 	info->pseudo_palette = devm_kmalloc_array(&pdev->dev, 16,
 						  sizeof(u32), GFP_KERNEL);
 	if (!info->pseudo_palette)

From patchwork Sat Nov 11 10:41:56 2023
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Dario Binacchi <dario.binacchi@amarulasolutions.com>
X-Patchwork-Id: 3004
Return-Path: 
 <linux-amarula+bncBCQ4XFG47UFRBJ5VXWVAMGQE6GQ6S5I@amarulasolutions.com>
X-Original-To: linux-amarula@patchwork.amarulasolutions.com
Delivered-To: linux-amarula@patchwork.amarulasolutions.com
Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com
	[209.85.208.69])
	by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 8126C3F057
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Sat, 11 Nov 2023 11:42:47 +0100 (CET)
Received: by mail-ed1-f69.google.com with SMTP id
	4fb4d7f45d1cf-542d5dd0c8esf4519805a12.1
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Sat, 11 Nov 2023 02:42:47 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1699699367; cv=pass;
	d=google.com; s=arc-20160816;
	b=Q+mRUlABKxKui7Vu0ogZ97+mvR/yWKLLaOi8lTItYVhnrZEdLZRsg258eqqSa09lon
	BW4MxH2chSoUcONdDZ25hapX5XK/OURJdC/mS2EaUSL6JeSz6TVr3bsC3XJK+4AhP4qR
	WKZJq4XdMyiLr0p9l9LLPAo3t0krR+Cwuo8GdbECXS/ZfNYaV9MOI2CTQBfLzfe7TMig
	lhgJdQLtEuLtTQ07Fr6sXvQgxZlkvFx0/O5sJslCK/3dEKvbJcoVHqUqcc3OvZg/UIpB
	DqjmHc65BTOgKdFZuaKUpi/2z1ds8ktjD3cfnxyjbmh8aYGKWELPd3CffQ5kQj6b7yK8
	P3bA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=TwOupDUvsrscBLkvpqJGSzll8pnT5of+cE5m/PBRxPU=;
	fh=CRQFspQ+XVmz3jTpDmawxjgq3paXQGVEDP+3Wpr+FXU=;
	b=aCrUf4RWEJH0ixSZnVHxOOc0JCDIt9CZA/8UnmWBIGeal717iaUDUxyAd1oTBKHSjm
	I90G8U4eNjNfaxgpem9E6qd3Ilhw7lT5HHmh7QXgIZElKmuZT2cUN58EVtAMg+e05H18
	zL0Vfsi5DKPqUg9xubcqyHXwnWHjvIr3KhQF2p3Xsc2IjJE0bWZwM6fS2XaZXL3wuSjm
	lVOErEV6PvUGfxPl7EDJqJ5fVOCV1VJU5RQvLr6Nzt9PAGjO2WQjohO+gwesTgieDWQ0
	kdJvWv0m6ojYmIxQyEo+/2a8Z9SNrPLD7mARQHtZJOPv5h/t1P3TMYf3qu8CpyVvT9kd
	gNEg==
ARC-Authentication-Results: i=2; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b="hs/4ojc0";
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=amarulasolutions.com; s=google; t=1699699367; x=1700304167;
	darn=patchwork.amarulasolutions.com;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:x-original-authentication-results
	:x-original-sender:mime-version:references:in-reply-to:message-id
	:date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
	bh=TwOupDUvsrscBLkvpqJGSzll8pnT5of+cE5m/PBRxPU=;
	b=eCRkT6EMzi7QInG2kJJdWT9N9J40iZzrTMo0IKSnJUjGEMCphgQhPMJc6/CsKUggA4
	qjkTEeQjjvW7oCGdH/wSePDBpT4XIEk4qsIkZUxZyuWBeQlYLQM+7O2af8n54pUysaMn
	uFzwhtjP9dHeR2FZRd+z+hN3ftCtsDO/st9vw=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20230601; t=1699699367; x=1700304167;
	h=list-unsubscribe:list-archive:list-help:list-post
	:x-spam-checked-in-group:list-id:mailing-list:precedence
	:x-original-authentication-results:x-original-sender:mime-version
	:references:in-reply-to:message-id:date:subject:cc:to:from
	:x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id
	:reply-to;
	bh=TwOupDUvsrscBLkvpqJGSzll8pnT5of+cE5m/PBRxPU=;
	b=fYlbBhuBhq4bbWkKO/rkbiRMo9oDnGATN0qLmjl+UEFH3OCy/9X+tVu1wS5aWlRVhl
	4jXZ9d1A3QaNGR/bFNlO0TFJbHK7MN1DhrTxS/gJpDXZBDHC8y0A7tRVuXYR42Ubd0l4
	Mvi1B2gwfHTzw9p9KQqBk9oef0fI2bi2fyBIzBimxF09nQ6Fqg1lzyt7gvYnxAIpRjit
	8zn5053kTK0xQxaqt7fwMmoJueHMNZuuasHDp60OHp4Q2U7C5S/PTkoWA7TDnPdy2QPk
	vZFKqx1wplh170ctHS30fz/AxkCCtIi9H5jZLLY8xWPbuw8dke6wUBKxbmGmy1knsnLe
	hWjA==
X-Gm-Message-State: AOJu0YzeYyqQIBpayFubdGyM3OalnisRMs+4cAzD+dkjeK3KXsYHmYfQ
	2Rp4VdOFJ1m4NCvHFP8XIEoEdIGY
X-Google-Smtp-Source: 
 AGHT+IFkhEi8FPCWfyeHSRNZOctRkvjDfz06GnpEtmU4qWB/a3ERJwW9Alyl5zrD/bi5JJ0GJDCYmQ==
X-Received: by 2002:a50:d4c7:0:b0:543:5dd9:a72 with SMTP id
	e7-20020a50d4c7000000b005435dd90a72mr1609562edj.1.1699699367346;
	Sat, 11 Nov 2023 02:42:47 -0800 (PST)
X-BeenThere: linux-amarula@amarulasolutions.com
Received: by 2002:a05:6402:c4e:b0:547:2571:d5ae with SMTP id
	cs14-20020a0564020c4e00b005472571d5aels6223edb.1.-pod-prod-00-eu;
	Sat, 11 Nov 2023 02:42:46 -0800 (PST)
X-Received: by 2002:a17:907:7e96:b0:9b2:be2f:e31a with SMTP id
	qb22-20020a1709077e9600b009b2be2fe31amr2072459ejc.31.1699699365827;
	Sat, 11 Nov 2023 02:42:45 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1699699365; cv=none;
	d=google.com; s=arc-20160816;
	b=ib6eHTwv3G7wZxPa1GzW3kIaeLxc1Rl5SmdC1/Ke4lt6Lol8d3mwbwJ5VBjCQ629wr
	nc7kFurOm85vL819zcTGaUAUqxkIOyfYUJI9b6r3CaFMgLFyJ2EdoNsF9Fxhs4WtUzG0
	DAdcXnjs02gwWSrG0XtI+AncKWzmiP1z8ufx/gG5blODMAJk95Kv/fFK0NkaEr/URIPZ
	xPlY0VfoNpXWJcRqdS6vrGrgfRX2ZfDJzf2XlYlG/8FAUjC6JPk+r9w2R5MRgDCt3eyw
	NjYGek/f2ekd5poLoU/v+cEUDKIR65wcOK5HKpk3mgHFWMEwM3ElFDeZPOCzowfkMDoK
	25cA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=content-transfer-encoding:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=IDgHYbXQcqXOi8pgjjCFs89msy5Cd5Tn06zlqflQDL0=;
	fh=CRQFspQ+XVmz3jTpDmawxjgq3paXQGVEDP+3Wpr+FXU=;
	b=JWsnHxCc9JRgZFzs96FzDHhXhvc3IJdp/40P4IJHl4dSCUZLKNZKmzVwBODCtM6+Us
	U154aH+5Nj+KQMNozf1lkUZuFlHtyRErasU+tsb4e70Xq8Lx8NY45J6Zj7U77m0NTfdW
	uQ9rq0zkEJozyodoRXjjDNzEnRztJtECW38ZLOeOW1nP0jec2ovbErUzaLq8cZtfJeuM
	9oHLZ+7m5gHh0VR0i7DxUvvM64oe6w8YEMbcssBzccXfOst66/wflZIG5KkgKWYH3DCC
	0BQF4YijcITlWKy+b+EMq5/ECDu0ytpm+Y+maXg3MWol7MUUw6MB8nnbO+cZ/hTA7qyR
	beuQ==
ARC-Authentication-Results: i=1; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b="hs/4ojc0";
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
Received: from mail-sor-f41.google.com (mail-sor-f41.google.com.
	[209.85.220.41]) by mx.google.com with SMTPS id
	qw35-20020a1709066a2300b009ae66306542sor268975ejc.9.2023.11.11.02.42.45
	for <linux-amarula@amarulasolutions.com>
	(Google Transport Security); Sat, 11 Nov 2023 02:42:45 -0800 (PST)
Received-SPF: pass (google.com: domain of
	dario.binacchi@amarulasolutions.com designates 209.85.220.41
	as permitted sender) client-ip=209.85.220.41;
X-Received: by 2002:a17:906:80c4:b0:9ae:50ec:bd81 with SMTP id
	a4-20020a17090680c400b009ae50ecbd81mr4311227ejx.21.1699699365597;
	Sat, 11 Nov 2023 02:42:45 -0800 (PST)
Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it
	(host-79-20-97-182.retail.telecomitalia.it. [79.20.97.182])
	by smtp.gmail.com with ESMTPSA id
	ga33-20020a1709070c2100b0099e12a49c8fsm872183ejc.173.2023.11.11.02.42.44
	(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
	Sat, 11 Nov 2023 02:42:45 -0800 (PST)
From: Dario Binacchi <dario.binacchi@amarulasolutions.com>
To: linux-kernel@vger.kernel.org
Cc: linux-amarula@amarulasolutions.com,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	Fabio Estevam <festevam@gmail.com>, Helge Deller <deller@gmx.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>,
	dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org,
	linux-fbdev@vger.kernel.org
Subject: [PATCH 07/10] fbdev: imxfb: add missing spaces after ','
Date: Sat, 11 Nov 2023 11:41:56 +0100
Message-ID: <20231111104225.136512-8-dario.binacchi@amarulasolutions.com>
X-Mailer: git-send-email 2.42.0
In-Reply-To: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com>
References: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com>
MIME-Version: 1.0
X-Original-Sender: dario.binacchi@amarulasolutions.com
X-Original-Authentication-Results: mx.google.com;       dkim=pass
	header.i=@amarulasolutions.com header.s=google header.b="hs/4ojc0";
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Mailing-list: list linux-amarula@amarulasolutions.com;
	contact linux-amarula+owners@amarulasolutions.com
List-ID: <linux-amarula.amarulasolutions.com>
X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com
X-Google-Group-Id: 476853432473
List-Post: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>,
	<mailto:linux-amarula@amarulasolutions.com>
List-Help: 
 <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>,
	<mailto:linux-amarula+help@amarulasolutions.com>
List-Archive: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/>
List-Unsubscribe: 
 <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>,
	<https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe>

Fix the following checkpatch error:

ERROR: space required after that ',' (ctx:VxV)

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 drivers/video/fbdev/imxfb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
index 83497f6998f1..ad293dc44dbb 100644
--- a/drivers/video/fbdev/imxfb.c
+++ b/drivers/video/fbdev/imxfb.c
@@ -280,10 +280,10 @@ static int imxfb_setpalettereg(u_int regno, u_int red, u_int green, u_int blue,
 	struct imxfb_info *fbi = info->par;
 	u_int val, ret = 1;
 
-#define CNVT_TOHW(val,width) ((((val)<<(width))+0x7FFF-(val))>>16)
+#define CNVT_TOHW(val, width) ((((val)<<(width))+0x7FFF-(val))>>16)
 	if (regno < fbi->palette_size) {
 		val = (CNVT_TOHW(red, 4) << 8) |
-		      (CNVT_TOHW(green,4) << 4) |
+		      (CNVT_TOHW(green, 4) << 4) |
 		      CNVT_TOHW(blue,  4);
 
 		writel(val, fbi->regs + 0x800 + (regno << 2));

From patchwork Sat Nov 11 10:41:57 2023
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Dario Binacchi <dario.binacchi@amarulasolutions.com>
X-Patchwork-Id: 3005
Return-Path: 
 <linux-amarula+bncBCQ4XFG47UFRBKFVXWVAMGQE4UEKRYI@amarulasolutions.com>
X-Original-To: linux-amarula@patchwork.amarulasolutions.com
Delivered-To: linux-amarula@patchwork.amarulasolutions.com
Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com
	[209.85.208.69])
	by ganimede.amarulasolutions.com (Postfix) with ESMTPS id BA11D3F057
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Sat, 11 Nov 2023 11:42:48 +0100 (CET)
Received: by mail-ed1-f69.google.com with SMTP id
	4fb4d7f45d1cf-543f1c6dcaesf2047506a12.1
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Sat, 11 Nov 2023 02:42:48 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1699699368; cv=pass;
	d=google.com; s=arc-20160816;
	b=VZ5iFgRzsa9S+GivUobyzZbm/IRsaHeP1n4rDvmvRg9kLZIJOWfbafQt6Rz4gUJef4
	ScQ1UM3wbsbNBBqw3rx/3rFGiXtUV9IV54w5m+NirSkHgHmxCy5PCqYRrp3s81mo2TPA
	N5WB4yHr7fVbRpbIIX86ryaWtDhEqS3ThKRj8gJ83eGhrBuKAsMO56Yx1LBC9g0ptM4V
	kwMVYsHpfjs3x0RMTDQWQvwXBGPtv5O3nIDNYaeu8EYAGnNJjp08RG3tX/l90nj/uEF/
	1ipEbhtcW0RMazwTWGuGYIity7A2bjNDI8JObkzMMcEGRZRSPkQsnTXZ2mNBNgubPEsQ
	QeRw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=8ncvB88PTqHONTD/YGcq98AY9oQgPnEd/6rge7dcvpo=;
	fh=CRQFspQ+XVmz3jTpDmawxjgq3paXQGVEDP+3Wpr+FXU=;
	b=Wdf/I6nvn+WI066lHx0d5JIoRbA41ieU8q3CjY0mSHKNCGhApllAcgUBAE8gCPEjZu
	9KmSdXxBLLDGVi1YWTh0r0C0mRK1iwQPt4vu5c/R5vN8eRvFiO/Ae0t4ahmFEDI1XmHp
	XQCBgDxQMuIYU03VsG3M9IHa3h3LADuVAw41tSOszrfKap26ga2vQQnYCJNrqsQzuv+0
	1OzxplyQ12DwOyAMfYB1UsLokVDCw+PCnUOiW1D9dbDozMespaExyfbeCXYfO2joTPyC
	mGpOnTO6WH7sqV4fXUCVFtm0JAdfGnBQ6HFyQkdEm5MPmsypgVC7AJyT2rgdK6bdnZCK
	aFGQ==
ARC-Authentication-Results: i=2; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=a0S4AlS6;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.65 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=amarulasolutions.com; s=google; t=1699699368; x=1700304168;
	darn=patchwork.amarulasolutions.com;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:x-original-authentication-results
	:x-original-sender:mime-version:references:in-reply-to:message-id
	:date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
	bh=8ncvB88PTqHONTD/YGcq98AY9oQgPnEd/6rge7dcvpo=;
	b=U3n9TSnR5ilaBzaOqX4u/LjgJghfDt/ygcS25GkfquzLKfTusp/oVWWTqZxkWTN38l
	BdNQonPLFOsHGjVVdvBgim1Tk5cHXt8zu0tBmcB13Y9RnbZXRYzGFwRSC2kxa0i3PQj0
	NXjkZASNKxeh8/6HCbY1SWAEZM379YFMfvfNc=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20230601; t=1699699368; x=1700304168;
	h=list-unsubscribe:list-archive:list-help:list-post
	:x-spam-checked-in-group:list-id:mailing-list:precedence
	:x-original-authentication-results:x-original-sender:mime-version
	:references:in-reply-to:message-id:date:subject:cc:to:from
	:x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id
	:reply-to;
	bh=8ncvB88PTqHONTD/YGcq98AY9oQgPnEd/6rge7dcvpo=;
	b=ExojP/VavHEfPr/ZZym2CtOtgQC7LP3ElWoYB5Evj45x8AS0/shogYxHKjBJmLNmlm
	CFbRdhHVjmFCituWR9iT+um3fk6C0QgpKhMpGKiX5SpCcxt0EhVz2DH5QWr9ekbMleOo
	f5Qiyu02eE1XZlNu9rMRJ3YXkg3z1K4chxQYyc99PyUcyWnIrHVbf60nr7HJJv1RbHK9
	7T3t487ThrKrYbER2/n08Gvnj9AyK7UxaBmW76Fb50UGe8NdikI4o5P5AlHHj2vOmEAT
	0EOwVdnvH1bYBIeH8zj9a9QB0CKbkWQCgBadMrvb0ryJbzihwUCpvnqOa8LGjlS7YfOA
	kjBw==
X-Gm-Message-State: AOJu0YyhBIjzyfsI+dtxQua5gIyomiM3P08E2PUnEALOPc6546+BUEOg
	BrzinBDt9NV4xGUMm9uiIcDa8LFm3D3PAAWc
X-Google-Smtp-Source: 
 AGHT+IGIOD7xY1w0NRplhQm2g1HgAA+1QSku8RdafRBaPtg3jFrk9UuWEK1z5KLRopdG56199icI7w==
X-Received: by 2002:a05:6402:12cd:b0:543:6678:5559 with SMTP id
	k13-20020a05640212cd00b0054366785559mr1282480edx.27.1699699368568;
	Sat, 11 Nov 2023 02:42:48 -0800 (PST)
X-BeenThere: linux-amarula@amarulasolutions.com
Received: by 2002:a05:6402:5156:b0:534:7b4a:8d91 with SMTP id
	n22-20020a056402515600b005347b4a8d91ls50594edd.2.-pod-prod-06-eu;
	Sat, 11 Nov 2023 02:42:47 -0800 (PST)
X-Received: by 2002:a17:906:4a84:b0:9e3:859a:52ae with SMTP id
	x4-20020a1709064a8400b009e3859a52aemr1028108eju.28.1699699367185;
	Sat, 11 Nov 2023 02:42:47 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1699699367; cv=none;
	d=google.com; s=arc-20160816;
	b=hHWcY2yGX+wFLmaAOYqg+yDflEUzL7nVTKX0FC9TeXbQbRtuEj3i9UnZ4epTW26idt
	QHJ0lXlEarbJt5w7rh7J53bKGDzKnAqe9zB/g6DWzIc/R7zy4k9s7EoQ5VjlWuDX742u
	XTTCh3UCiiwVHSwLPSRag28UhYamJ8Q1jaEFW4DnKPR2MelPCi3OdI8HfstFy/wpLZ+N
	HtipoB/Xb0lJSiVyAZH59CHosBHbixYsZ+AxszvBmmh17OMs+fru5I4DDON6xfhg4keB
	vWvA8IWLX80CSA4pnAwP8dxBQi3bRqVKvjgS5c3Nk+vYh+5q84Rx3DmeV1S7DPPGF9BD
	FUxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=content-transfer-encoding:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=uXZvMG+ePha/xCPPyQSZcW7mIHQVo6pfDhdFQ8Ys4tc=;
	fh=CRQFspQ+XVmz3jTpDmawxjgq3paXQGVEDP+3Wpr+FXU=;
	b=cHit70rAa5q7L3PXFXgkLp6z6D7/1yzhjnU6cbXzTICimbYhHiQNBEgLTgU5v7qds0
	vakSSTi1oVFW2qg0zWVNYQoj5lGVfr97shif8IFeixvGQ+041BGinz+cNNWPmEKD2cao
	BkoHo7U/jM1d/ZS1IEXC/2MzzvzEje4AnCwc84TM+NQF7Nn8BNVCTD4tuNJYkVr6uwBT
	bSpgrYKzuaX0NfUTki3SY2fMR4ZOQ+zQTXA4ohRM5TQJrjb6eY+AK2HeEyUISEAYjx5F
	8TmuPvV5jLSfnczCEdtaZoH2xuDQYxR+4kUHag7/mO+qIUAChUafvR7j3bWE8tX2KcU1
	VXng==
ARC-Authentication-Results: i=1; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=a0S4AlS6;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.65 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
Received: from mail-sor-f65.google.com (mail-sor-f65.google.com.
	[209.85.220.65]) by mx.google.com with SMTPS id
	21-20020a170906225500b009ddfc78027dsor273982ejr.3.2023.11.11.02.42.47
	for <linux-amarula@amarulasolutions.com>
	(Google Transport Security); Sat, 11 Nov 2023 02:42:47 -0800 (PST)
Received-SPF: pass (google.com: domain of
	dario.binacchi@amarulasolutions.com designates 209.85.220.65
	as permitted sender) client-ip=209.85.220.65;
X-Received: by 2002:a17:906:fa9b:b0:9dd:6664:1a3a with SMTP id
	lt27-20020a170906fa9b00b009dd66641a3amr1013488ejb.51.1699699366905;
	Sat, 11 Nov 2023 02:42:46 -0800 (PST)
Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it
	(host-79-20-97-182.retail.telecomitalia.it. [79.20.97.182])
	by smtp.gmail.com with ESMTPSA id
	ga33-20020a1709070c2100b0099e12a49c8fsm872183ejc.173.2023.11.11.02.42.45
	(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
	Sat, 11 Nov 2023 02:42:46 -0800 (PST)
From: Dario Binacchi <dario.binacchi@amarulasolutions.com>
To: linux-kernel@vger.kernel.org
Cc: linux-amarula@amarulasolutions.com,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	Fabio Estevam <festevam@gmail.com>, Helge Deller <deller@gmx.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>,
	dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org,
	linux-fbdev@vger.kernel.org
Subject: [PATCH 08/10] fbdev: imxfb: Fix style warnings relating to printk()
Date: Sat, 11 Nov 2023 11:41:57 +0100
Message-ID: <20231111104225.136512-9-dario.binacchi@amarulasolutions.com>
X-Mailer: git-send-email 2.42.0
In-Reply-To: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com>
References: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com>
MIME-Version: 1.0
X-Original-Sender: dario.binacchi@amarulasolutions.com
X-Original-Authentication-Results: mx.google.com;       dkim=pass
	header.i=@amarulasolutions.com header.s=google header.b=a0S4AlS6;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.65 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Mailing-list: list linux-amarula@amarulasolutions.com;
	contact linux-amarula+owners@amarulasolutions.com
List-ID: <linux-amarula.amarulasolutions.com>
X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com
X-Google-Group-Id: 476853432473
List-Post: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>,
	<mailto:linux-amarula@amarulasolutions.com>
List-Help: 
 <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>,
	<mailto:linux-amarula+help@amarulasolutions.com>
List-Archive: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/>
List-Unsubscribe: 
 <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>,
	<https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe>

Resolve the following warning reported by checkpatch:

WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

This made it necessary to move the 'fbi->pdev = pdev' setting to the
beginning of the driver's probing.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 drivers/video/fbdev/imxfb.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
index ad293dc44dbb..a0172ff75c46 100644
--- a/drivers/video/fbdev/imxfb.c
+++ b/drivers/video/fbdev/imxfb.c
@@ -414,8 +414,8 @@ static int imxfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
 
 	if (--pcr > PCR_PCD_MASK) {
 		pcr = PCR_PCD_MASK;
-		printk(KERN_WARNING "Must limit pixel clock to %luHz\n",
-				lcd_clk / pcr);
+		dev_warn(&fbi->pdev->dev, "Must limit pixel clock to %luHz\n",
+			 lcd_clk / pcr);
 	}
 
 	switch (var->bits_per_pixel) {
@@ -628,28 +628,28 @@ static int imxfb_activate_var(struct fb_var_screeninfo *var, struct fb_info *inf
 
 #if DEBUG_VAR
 	if (var->xres < 16        || var->xres > 1024)
-		printk(KERN_ERR "%s: invalid xres %d\n",
+		dev_err(&fbi->pdev->dev, "%s: invalid xres %d\n",
 			info->fix.id, var->xres);
 	if (var->hsync_len < 1    || var->hsync_len > 64)
-		printk(KERN_ERR "%s: invalid hsync_len %d\n",
+		dev_err(&fbi->pdev->dev, "%s: invalid hsync_len %d\n",
 			info->fix.id, var->hsync_len);
 	if (var->left_margin < left_margin_low  || var->left_margin > 255)
-		printk(KERN_ERR "%s: invalid left_margin %d\n",
+		dev_err(&fbi->pdev->dev, "%s: invalid left_margin %d\n",
 			info->fix.id, var->left_margin);
 	if (var->right_margin < 1 || var->right_margin > 255)
-		printk(KERN_ERR "%s: invalid right_margin %d\n",
+		dev_err(&fbi->pdev->dev, "%s: invalid right_margin %d\n",
 			info->fix.id, var->right_margin);
 	if (var->yres < 1 || var->yres > ymax_mask)
-		printk(KERN_ERR "%s: invalid yres %d\n",
+		dev_err(&fbi->pdev->dev, "%s: invalid yres %d\n",
 			info->fix.id, var->yres);
 	if (var->vsync_len > 100)
-		printk(KERN_ERR "%s: invalid vsync_len %d\n",
+		dev_err(&fbi->pdev->dev, "%s: invalid vsync_len %d\n",
 			info->fix.id, var->vsync_len);
 	if (var->upper_margin > 63)
-		printk(KERN_ERR "%s: invalid upper_margin %d\n",
+		dev_err(&fbi->pdev->dev, "%s: invalid upper_margin %d\n",
 			info->fix.id, var->upper_margin);
 	if (var->lower_margin > 255)
-		printk(KERN_ERR "%s: invalid lower_margin %d\n",
+		dev_err(&fbi->pdev->dev, "%s: invalid lower_margin %d\n",
 			info->fix.id, var->lower_margin);
 #endif
 
@@ -701,6 +701,7 @@ static int imxfb_init_fbinfo(struct platform_device *pdev)
 
 	memset(fbi, 0, sizeof(struct imxfb_info));
 
+	fbi->pdev = pdev;
 	fbi->devtype = pdev->id_entry->driver_data;
 
 	strscpy(info->fix.id, IMX_NAME, sizeof(info->fix.id));
@@ -1044,7 +1045,6 @@ static int imxfb_probe(struct platform_device *pdev)
 	lcd->props.max_contrast = 0xff;
 
 	imxfb_enable_controller(fbi);
-	fbi->pdev = pdev;
 
 	return 0;
 

From patchwork Sat Nov 11 10:41:58 2023
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Dario Binacchi <dario.binacchi@amarulasolutions.com>
X-Patchwork-Id: 3006
Return-Path: 
 <linux-amarula+bncBCQ4XFG47UFRBKNVXWVAMGQERZIBSEY@amarulasolutions.com>
X-Original-To: linux-amarula@patchwork.amarulasolutions.com
Delivered-To: linux-amarula@patchwork.amarulasolutions.com
Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com
	[209.85.167.72])
	by ganimede.amarulasolutions.com (Postfix) with ESMTPS id B09533F057
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Sat, 11 Nov 2023 11:42:50 +0100 (CET)
Received: by mail-lf1-f72.google.com with SMTP id
	2adb3069b0e04-5079fe7cc7csf3179957e87.2
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Sat, 11 Nov 2023 02:42:50 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1699699370; cv=pass;
	d=google.com; s=arc-20160816;
	b=MlwOqobwEkeuWMVKq4gvX9VIWhPPRxBsXkT7jkJ+hx2cPak13Wnh31hQgZut8wD1FA
	IqIELdrOg4dwOaa1awzmS3HAHIQMXd5ksP2DX8eNDH+6OJyv2WTxPuLLyLqB925z57K0
	wrkXraYKZd5DlPScGToP+bWwIpj896IYWnSLxmJJO5KtDUFiB7Pb7+uHlxD8Wf5cJPzD
	oY4Dpgehu/NUvWqtOPV6Rw5DYaFoP8leGH55KWZ7L49J4MC3mSDb+wKPNj8n9gc6eXkc
	nQaGh/ToUXpRt8ap4DSQzCM/KW/PLSDMLAl+lTdeRblz82eDB8nd1qm5umTkztpcAUt4
	YhIQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=+NHvexBvwtcXa/Ycp92q5DOBBsf8lOZLAcBSKyPxONM=;
	fh=CRQFspQ+XVmz3jTpDmawxjgq3paXQGVEDP+3Wpr+FXU=;
	b=XBOVauIZsFUu6nLmSD5hxNDHmCkdp0SAJKM5abgoQBJC7syK3UYFVqLzb9hhlZjsoh
	L89YdY9ICPcoH7sN7RTVA5o9j+LGhioJY4h7KVQM2Ee4rTXaYN23YcxS6UnX7eUb3FlJ
	BYvUZodeTQ5RWNaZcu0NCWhbNPoTR3y0cxuLXenMf89XRl9W6AVcZDZ4olxrGuo81o0o
	wh5Dl2IY842EzbibJrM4w5OCj0nLpj77mh8BQkfa/UIcMtW4NPhBh585AkxEAhLR7Jk9
	9SC+h+iwNsJNzlAh0xCN/m2T6waCENVXBXEAXfdZ9rS48WXglNAWdOFAAJsER3wdGhFW
	9HNg==
ARC-Authentication-Results: i=2; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b="HVa/mbUD";
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=amarulasolutions.com; s=google; t=1699699370; x=1700304170;
	darn=patchwork.amarulasolutions.com;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:x-original-authentication-results
	:x-original-sender:mime-version:references:in-reply-to:message-id
	:date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
	bh=+NHvexBvwtcXa/Ycp92q5DOBBsf8lOZLAcBSKyPxONM=;
	b=RHzbJHB1mApTkAIVOk6zNN1CKnHI0vfrN1G2Dy0OxZiZJQV1zJFcyDojIjgT5Xm9zI
	iTm9H7kNJdU97+HSYwqrVTrMV3IMfYGSvfq7sUom69puo2DvLQsEtIAirMrVaXrwwE5W
	6CyYpstXB+1tuwJqDTtpxPBBtgr2HMbat75oM=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20230601; t=1699699370; x=1700304170;
	h=list-unsubscribe:list-archive:list-help:list-post
	:x-spam-checked-in-group:list-id:mailing-list:precedence
	:x-original-authentication-results:x-original-sender:mime-version
	:references:in-reply-to:message-id:date:subject:cc:to:from
	:x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id
	:reply-to;
	bh=+NHvexBvwtcXa/Ycp92q5DOBBsf8lOZLAcBSKyPxONM=;
	b=GTJgnYWLTBJU3ByC6G1gJMEaaqvFG9uHWr7pe/PXGtzNXEY+qNFDv2iOuV9t1z+3Id
	geI1g46A1AWwblOiQm9bNtPiGTWbx6fAgkfNlIS3/KtOSM+8gQzCaa+zVeYDO4PUnSHv
	TPAWbj22A9VSgY/X6iUuCIbc/a3yngwOJ5/kYpXK351yQqYr6eKxD/BnHgE5piGHaBBE
	ig0uQ/q6089y3kNCYDQ1CuGkI3rs8Mgsw58/hPLh3+tW8EXVUvgL+WTqVScWIeydhGqG
	MlJbpnBFqkdofvKrQcj5UBi9qULZxUL9cPuGRe/VeLpUeMHK9OPd8Rb88UEpuIJq3Uj4
	VsMA==
X-Gm-Message-State: AOJu0Yx0lvCYwxFcdBUQkJVZvlLgl/KKrwE2b/MBeWsKxuqSGA4hDQp9
	sFvigsOLCHlj4CFsZJlh0gwcJBj+rpa5XKAC
X-Google-Smtp-Source: 
 AGHT+IG52HV5Rl0EioRbsD7xwuyFKUdgTU0KX6LlReFcEmqtFZdminQiC5ykgbk2jQAi52Zi3xRGEA==
X-Received: by 2002:a05:6512:b05:b0:503:3816:c42c with SMTP id
	w5-20020a0565120b0500b005033816c42cmr1396143lfu.41.1699699369886;
	Sat, 11 Nov 2023 02:42:49 -0800 (PST)
X-BeenThere: linux-amarula@amarulasolutions.com
Received: by 2002:a05:6402:40b:b0:53f:9578:1b14 with SMTP id
	q11-20020a056402040b00b0053f95781b14ls657229edv.0.-pod-prod-02-eu;
	Sat, 11 Nov 2023 02:42:48 -0800 (PST)
X-Received: by 2002:a17:906:6a1f:b0:9a5:9f3c:9615 with SMTP id
	qw31-20020a1709066a1f00b009a59f3c9615mr1472425ejc.63.1699699368416;
	Sat, 11 Nov 2023 02:42:48 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1699699368; cv=none;
	d=google.com; s=arc-20160816;
	b=cED1X2aaS0IcOgGclfG9jHLjBPslwsbr3H+tUgObJ54GoZuRhKeJFbeNG3HA/l8eKg
	tPOde6pQovxqO5V4EtSRrpPITTKF64qKvADJ5KNjn/lme0jLsHhRFUYve7csWDfZKI5i
	xdipsxfuCIXdp+mNHZiGa1ZWrij8nWBbmxRswr8Dbw1rHuzRQiLTXrnA+JKEy1FQQjX1
	7l0ZgpTOjztyEzu9g3yP4zhxrSFgBw0wYpujQJwYYBzfZo3Ace2rIf17Qa3SExI3iOxc
	hk2cmhIH3t5lGIxxFcABlblh/cB3uN1PIDFe+aIF/BrmUQ2NsQIaDZ7KFm27pR5xQL1K
	hvbA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=content-transfer-encoding:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=0fPpjqbZXDXnwfpqh3sU0UKiF5sG/PgBCsBX0KBupbI=;
	fh=CRQFspQ+XVmz3jTpDmawxjgq3paXQGVEDP+3Wpr+FXU=;
	b=VBDeFfFugMt27zOf0qUqYg9wjoPkotpCiBIK8t4DKKQZp8wqhsUKzzKJzTtvqrZBqg
	Dc+PJM0tXmXCjWMNPWBZZV1ZUKDBw6dEAilZP2jcpvkmp1gSP+Me2dFPaEIbkcYxalWn
	0E3pbVWHJAcFYKbDTug1ltrZUvdCl3uUVHPwYCpKi8ugHsRbnkJnaTbQWj0X1houQ6Bz
	PXr+uGukRRLAhh3Fj45z4lKgbuO2TT6LG6qobgnOD7J6xQJ8nMcbMpuaMnaqZsLkS+VY
	bqY1uz0ttWDWPgzkAgho08rea8iipnIhzlbupyNKHVL8kuPl7cdnHcb+m7JgxPN/JeKM
	3SHA==
ARC-Authentication-Results: i=1; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b="HVa/mbUD";
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
Received: from mail-sor-f41.google.com (mail-sor-f41.google.com.
	[209.85.220.41]) by mx.google.com with SMTPS id
	n20-20020a17090673d400b009e786c802f8sor152781ejl.9.2023.11.11.02.42.48
	for <linux-amarula@amarulasolutions.com>
	(Google Transport Security); Sat, 11 Nov 2023 02:42:48 -0800 (PST)
Received-SPF: pass (google.com: domain of
	dario.binacchi@amarulasolutions.com designates 209.85.220.41
	as permitted sender) client-ip=209.85.220.41;
X-Received: by 2002:a17:906:f247:b0:9d2:bf19:88aa with SMTP id
	gy7-20020a170906f24700b009d2bf1988aamr1056461ejb.59.1699699368178;
	Sat, 11 Nov 2023 02:42:48 -0800 (PST)
Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it
	(host-79-20-97-182.retail.telecomitalia.it. [79.20.97.182])
	by smtp.gmail.com with ESMTPSA id
	ga33-20020a1709070c2100b0099e12a49c8fsm872183ejc.173.2023.11.11.02.42.47
	(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
	Sat, 11 Nov 2023 02:42:47 -0800 (PST)
From: Dario Binacchi <dario.binacchi@amarulasolutions.com>
To: linux-kernel@vger.kernel.org
Cc: linux-amarula@amarulasolutions.com,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	Fabio Estevam <festevam@gmail.com>, Helge Deller <deller@gmx.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>,
	dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org,
	linux-fbdev@vger.kernel.org
Subject: [PATCH 09/10] fbdev: imxfb: use __func__ for function name
Date: Sat, 11 Nov 2023 11:41:58 +0100
Message-ID: <20231111104225.136512-10-dario.binacchi@amarulasolutions.com>
X-Mailer: git-send-email 2.42.0
In-Reply-To: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com>
References: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com>
MIME-Version: 1.0
X-Original-Sender: dario.binacchi@amarulasolutions.com
X-Original-Authentication-Results: mx.google.com;       dkim=pass
	header.i=@amarulasolutions.com header.s=google header.b="HVa/mbUD";
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Mailing-list: list linux-amarula@amarulasolutions.com;
	contact linux-amarula+owners@amarulasolutions.com
List-ID: <linux-amarula.amarulasolutions.com>
X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com
X-Google-Group-Id: 476853432473
List-Post: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>,
	<mailto:linux-amarula@amarulasolutions.com>
List-Help: 
 <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>,
	<mailto:linux-amarula+help@amarulasolutions.com>
List-Archive: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/>
List-Unsubscribe: 
 <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>,
	<https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe>

Resolve the following warning reported by checkpatch:

WARNING: Prefer using '"%s...", __func__' to using 'imxfb_blank', this function's name, in a string

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 drivers/video/fbdev/imxfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
index a0172ff75c46..8d6943f0bfca 100644
--- a/drivers/video/fbdev/imxfb.c
+++ b/drivers/video/fbdev/imxfb.c
@@ -576,7 +576,7 @@ static int imxfb_blank(int blank, struct fb_info *info)
 {
 	struct imxfb_info *fbi = info->par;
 
-	pr_debug("imxfb_blank: blank=%d\n", blank);
+	pr_debug("%s: blank=%d\n", __func__, blank);
 
 	switch (blank) {
 	case FB_BLANK_POWERDOWN:

From patchwork Sat Nov 11 10:41:59 2023
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Dario Binacchi <dario.binacchi@amarulasolutions.com>
X-Patchwork-Id: 3007
Return-Path: 
 <linux-amarula+bncBCQ4XFG47UFRBKVVXWVAMGQEB6F3JMI@amarulasolutions.com>
X-Original-To: linux-amarula@patchwork.amarulasolutions.com
Delivered-To: linux-amarula@patchwork.amarulasolutions.com
Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com
	[209.85.221.69])
	by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 50DF93FA58
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Sat, 11 Nov 2023 11:42:51 +0100 (CET)
Received: by mail-wr1-f69.google.com with SMTP id
	ffacd0b85a97d-32d9751ca2csf1406335f8f.3
	for <linux-amarula@patchwork.amarulasolutions.com>;
	Sat, 11 Nov 2023 02:42:51 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1699699371; cv=pass;
	d=google.com; s=arc-20160816;
	b=TDDoB9OF85n7wgWwjT8VgVKSOIv+ZFZSLn8ARlivFJvdlbNflXAGJsQHPybZAdY41Y
	PgFRYhr2ZVZmmvgZjOJFVGVsH+pV8I6GqEbCAEIYcYef30WAivoMigp1myW9xmDEJMya
	Wv35CRNino3375LnsLafgha3tPtIW8UlvGBPBp2LoWl3If90aq3Om+wW1TWXeGH7x61i
	PdnopP7VnP1xUB1ILBDbHGEmk2PWBZMM40AT6+s3y8DenoQYDdFraBRE5DBFVec78e4E
	zDJlqUgjoNmiXWjq62/UCUbH6t73dS83NytKbprO6/p2Cvd1CPxC4n9zBnnCNbmxZgO5
	7aBg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=7bTWtsdOoZNlzjYut4eOTfflJABYMc+j+fb+i5c/reo=;
	fh=CRQFspQ+XVmz3jTpDmawxjgq3paXQGVEDP+3Wpr+FXU=;
	b=JsjDcjQuoFPsuRhrF9cs0rywcybP3UHsn36EV3Se7CcMIZA5qvK9PQhygX1KVcBol5
	o/YaF3RBG+uYEWsvhB2MU0Y0QF9zyetcWf/jSFYvEhhyFcuBOCcYYXtR/KBgZjk2nBwI
	xXhkRaFCZsswP7QGZYng4zhxQ0iHghTMvy/Unp/cJGyeeIKPHt0so/WfeG8lth/i6ARX
	XE1beJn9bCbP7jnBJN/WmrJbgFu4wiG7KYlLYQ1A06rHxPgs36VJdbnVO9gqGKqwY5kx
	JSfp/H5mNpRtQ/lJAD6mdft9QQpgezWn5Xxu26Wzu1TC3IlSptvBvYUIosNPHtdAvCju
	9XUQ==
ARC-Authentication-Results: i=2; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=RwjZbAaz;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=amarulasolutions.com; s=google; t=1699699371; x=1700304171;
	darn=patchwork.amarulasolutions.com;
	h=list-unsubscribe:list-archive:list-help:list-post:list-id
	:mailing-list:precedence:x-original-authentication-results
	:x-original-sender:mime-version:references:in-reply-to:message-id
	:date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
	bh=7bTWtsdOoZNlzjYut4eOTfflJABYMc+j+fb+i5c/reo=;
	b=VPPeHSiWlTWHDUB/gKbr7twNJJwKFa5DHTQIP69QM2ESF7WwkFlHStC7S7mMNvRlY5
	GH9++88v9dxYoAxp8rKHMatkG8J91u0ZtAFD0Ouco8lWNW63P6zkF4J5M18tvvR8dmkT
	PISAHBbGhBODWEuUkLghgymTsB4kKiFwj/Z1A=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20230601; t=1699699371; x=1700304171;
	h=list-unsubscribe:list-archive:list-help:list-post
	:x-spam-checked-in-group:list-id:mailing-list:precedence
	:x-original-authentication-results:x-original-sender:mime-version
	:references:in-reply-to:message-id:date:subject:cc:to:from
	:x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id
	:reply-to;
	bh=7bTWtsdOoZNlzjYut4eOTfflJABYMc+j+fb+i5c/reo=;
	b=Vqe96RNs+GPRw4B9EBxPopwGkTROo4c8PG7ihup2gFIfkLtEaIjCkdY4cSBqbG1kUG
	HdKoVanZT496mG3T433Ir6EzQdXMWxgXjoqMLxXZED7wKM59wiEtompw9QhlPtL0FblP
	AY5nDS4Ru4DTPy6HcLQMQ37jEQH9YIyH1pdV7CIuxO++FnB9tc7/50fL3Utnf4meGpYk
	kVHtRIqNAOkJ7QglIqgkfC4a5eVZ6+aKN6nTK1JG7fdEr1XKYytkBDUlXjmpZ19F4FaJ
	mzLzFPs78X5fmIai4lR36L2LSxJ3IMU6ob946iqd+DXymyArMm0FM7KykQF7htm4Vv3T
	46Lg==
X-Gm-Message-State: AOJu0YzLNZmExXTz5kntSbppoSbBJ1QX3sZqqBc4rwn06l02vxUK/NGE
	ya0sWjmiUUMLDepWVC/TTX0Nc5S0
X-Google-Smtp-Source: 
 AGHT+IHxcqy0W/suqxAmmwM8juM0phKz8M78xrFMw8sKLEoEzVoFTa1uY0Ymj/olXzPKhA5zWbLmbw==
X-Received: by 2002:a5d:4576:0:b0:32f:7ee7:1f6c with SMTP id
	a22-20020a5d4576000000b0032f7ee71f6cmr1054452wrc.35.1699699371083;
	Sat, 11 Nov 2023 02:42:51 -0800 (PST)
X-BeenThere: linux-amarula@amarulasolutions.com
Received: by 2002:a05:6000:1e8b:b0:32f:7fdc:ea3 with SMTP id
	dd11-20020a0560001e8b00b0032f7fdc0ea3ls825947wrb.1.-pod-prod-04-eu;
	Sat, 11 Nov 2023 02:42:50 -0800 (PST)
X-Received: by 2002:a17:906:5253:b0:9e6:59d5:71ca with SMTP id
	y19-20020a170906525300b009e659d571camr1019428ejm.13.1699699369704;
	Sat, 11 Nov 2023 02:42:49 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1699699369; cv=none;
	d=google.com; s=arc-20160816;
	b=RHHF/ggJQAMjl0tN6lhE2zUk7WufNLmb3rIPQgy3T93h+Wa3xtcFji93Eu3EcZEAdN
	/TS2oZ/8HzUjfTkGpAqQU3LRmREy1MJb2z7O/GpRmFBzAaAtC4yAw0boSZgP8pSFBTcK
	3a168VyBTFaD61/aHY8YoYDftbcom/tZk+XVtggd24e9PDE3NH9RZIkg6GiCFmodsoAP
	zbazFSTPtGlZdB7hzEE/jS8T5TMj+Vuq7GPGTiwKQf0ntLas/TpFZf6KT/UiGBxJHFyM
	zzaOHMkPBXs4557UvNb1KAD5G4VFuBzEWkkWZzFkoj2TT8wW1RIAeysjwzEw6A4Up3zx
	GmCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20160816;
	h=content-transfer-encoding:mime-version:references:in-reply-to
	:message-id:date:subject:cc:to:from:dkim-signature;
	bh=57XfclRA1DPTjEGTeta8gbvZTvGhPeSww56J1vwZoGA=;
	fh=CRQFspQ+XVmz3jTpDmawxjgq3paXQGVEDP+3Wpr+FXU=;
	b=nhjq4WdPJLNhOQu+KgYBSBwZGbqwHXoYQoSazccOmqk19A2seTX7B6Mwm4icP9mAOG
	Q9U4QAr2POYC/NViH6jGdhKUdM0Kj+bqlphD9OSSvzRJD2UxHBflIt07nyG9DYrEbuB8
	g0g/CGCp3OWRaRhLGE0lBQQJ8GJIQ0olPl9GH+m2FwCTLouffOllFt2QZRR2IRGVdW40
	4K0WV8az3oG1VU0r7V4XJWlov2m8V/k+kRoI20UwMFErOe6vXnq5R2XsHgr7ypX4/Af7
	rP+ujJwN4hhloP07JiG5UYtOwu5OMp4IpJOef7WlZlWFeSzEqL2AdSG2XBYoEMOHlS4q
	8l1g==
ARC-Authentication-Results: i=1; mx.google.com;
	dkim=pass header.i=@amarulasolutions.com header.s=google
	header.b=RwjZbAaz;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
Received: from mail-sor-f41.google.com (mail-sor-f41.google.com.
	[209.85.220.41]) by mx.google.com with SMTPS id
	21-20020a170906101500b009b927358aabsor263980ejm.3.2023.11.11.02.42.49
	for <linux-amarula@amarulasolutions.com>
	(Google Transport Security); Sat, 11 Nov 2023 02:42:49 -0800 (PST)
Received-SPF: pass (google.com: domain of
	dario.binacchi@amarulasolutions.com designates 209.85.220.41
	as permitted sender) client-ip=209.85.220.41;
X-Received: by 2002:a17:906:361a:b0:9dd:bd42:4ec2 with SMTP id
	q26-20020a170906361a00b009ddbd424ec2mr908050ejb.10.1699699369457;
	Sat, 11 Nov 2023 02:42:49 -0800 (PST)
Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it
	(host-79-20-97-182.retail.telecomitalia.it. [79.20.97.182])
	by smtp.gmail.com with ESMTPSA id
	ga33-20020a1709070c2100b0099e12a49c8fsm872183ejc.173.2023.11.11.02.42.48
	(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
	Sat, 11 Nov 2023 02:42:49 -0800 (PST)
From: Dario Binacchi <dario.binacchi@amarulasolutions.com>
To: linux-kernel@vger.kernel.org
Cc: linux-amarula@amarulasolutions.com,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	Fabio Estevam <festevam@gmail.com>, Helge Deller <deller@gmx.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>,
	dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org,
	linux-fbdev@vger.kernel.org
Subject: [PATCH 10/10] fbdev: imxfb: add '*/' on a separate line in block
	comment
Date: Sat, 11 Nov 2023 11:41:59 +0100
Message-ID: <20231111104225.136512-11-dario.binacchi@amarulasolutions.com>
X-Mailer: git-send-email 2.42.0
In-Reply-To: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com>
References: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com>
MIME-Version: 1.0
X-Original-Sender: dario.binacchi@amarulasolutions.com
X-Original-Authentication-Results: mx.google.com;       dkim=pass
	header.i=@amarulasolutions.com header.s=google header.b=RwjZbAaz;
	spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com
	designates 209.85.220.41 as permitted sender)
	smtp.mailfrom=dario.binacchi@amarulasolutions.com;
	dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Mailing-list: list linux-amarula@amarulasolutions.com;
	contact linux-amarula+owners@amarulasolutions.com
List-ID: <linux-amarula.amarulasolutions.com>
X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com
X-Google-Group-Id: 476853432473
List-Post: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>,
	<mailto:linux-amarula@amarulasolutions.com>
List-Help: 
 <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>,
	<mailto:linux-amarula+help@amarulasolutions.com>
List-Archive: 
 <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/>
List-Unsubscribe: 
 <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>,
	<https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe>

Linux kernel coding style uses '*/' on a separate line at the end of
multi line comments.

Fix block comments by moving '*/' at the end of block comments on a
separate line as reported by checkpatch:

WARNING: Block comments use a trailing */ on a separate line

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 drivers/video/fbdev/imxfb.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
index 8d6943f0bfca..a4dbc72f93c3 100644
--- a/drivers/video/fbdev/imxfb.c
+++ b/drivers/video/fbdev/imxfb.c
@@ -946,8 +946,10 @@ static int imxfb_probe(struct platform_device *pdev)
 	if (ret)
 		goto failed_init;
 
-	/* Calculate maximum bytes used per pixel. In most cases this should
-	 * be the same as m->bpp/8 */
+	/*
+	 * Calculate maximum bytes used per pixel. In most cases this should
+	 * be the same as m->bpp/8
+	 */
 	m = &fbi->mode[0];
 	bytes_per_pixel = (m->bpp + 7) / 8;
 	for (i = 0; i < fbi->num_modes; i++, m++)