From patchwork Thu Dec 5 16:29:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 3713 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 1199A3FA09 for ; Thu, 5 Dec 2024 17:30:10 +0100 (CET) Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2ff13df3766sf7414841fa.3 for ; Thu, 05 Dec 2024 08:30:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1733416209; cv=pass; d=google.com; s=arc-20240605; b=g7RHLf6qwcvnsP2F2dj0SEwRoLAHMvJ5lkiqXrMDY965YfUcdj1Ud3M/nkKQlOmpnJ 5m8Is+teJClY5bZ0Uo6q1lijVqjCWdjSvPP4lu4fbZrYdRq4QpU2ylhBNKIlilH/2mfr 7HLR2PnSZHzl3FaJk1DmQyyAB4Jz32hIzdn3MN0+VPLUatgI9nI+A5CmmRxG9xS/wJRv QW71wqY7iqplCZA0K7sTEDoWwiEU/Z5elI4va268CxDN7Rt55Wh9Ijq1w/N9imI2Tg6R LtvXjJF9DOVu58Z9yTiu31sUq/lpkXidUdZb20/FNzdbPXC+hvQ0rIXRX8M7GEWkAe9Y Xidg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=AmnTgIuNOB7w4K+P4EVwCavWnNZSjRsxoMyrnDeJ6Hs=; fh=a9FAkI5KODM6og7Q1RN+hyCmSNVh8yUdQIr5Lj06E7A=; b=H4Xug9L398FLf0z/ErN7gASvxKv65HwJhMKmcqcJprxgLQSJ9W/t13gekkNe8yWA20 OXxkOgt3jB64Q4O83UD+/zrd76U5rP9dGBYx5Ukv6b7C+CO91iYNFoU/zDLPN3AKuWcn QBGVek6V+5KSDnE7V69PiUcjbxiNOYOtUZZp1sss9d6vyKPVyGeyGbb3G70fQO03E05w YuMzebBE2p10jtrXdIxdKaLVyzOKCT3ayR+X5YSkBEhREkV2j0Uwn2MWY9G0nQhkyTDE 9HArTgl4eyEsDao1UB363ujyMba2WSvPvCk1cpKFZZ1H3sDHyoDaa2AC+cSTe7GJrk9E iL/w==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=BkctGQWV; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1733416209; x=1734021009; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :from:to:cc:subject:date:message-id:reply-to; bh=AmnTgIuNOB7w4K+P4EVwCavWnNZSjRsxoMyrnDeJ6Hs=; b=WK2BBJ84+8iic0dynucAg6r0+yJY/gmCdyUBKB16jvSri1Lp0wGs9o4KvXO0QGtU9G RuqUXz97FDwPsgAXtO5t9L5dA58cFryxoemHZmG7ZiIqBSzxz0FDl5D0VgYCuJmuLFVC Y2HomnNcyyVpQtd2iL1RpQn11qvG9ogJKFIZA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733416209; x=1734021009; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=AmnTgIuNOB7w4K+P4EVwCavWnNZSjRsxoMyrnDeJ6Hs=; b=LHpm/QZMnx+1nDGLClWkh31NL9NmOHYsFI/Vw8fGs9h6azyWag3ymkOC9kv83Qe8FO 6wDFOs7rX+DwvIUwGLOsESlv/1Pjwb+bZaVfxJUup1i2WIAZ0jmtwz5hcKuSOc5WeORk fdKXh4ipKu6GKe+YVOwKb3omzEEcmOmljtRRvTfjTlTMQp5Ydd8Zqxw+yDmrcZ/eFr5C KZ4bWa0iU50jd6W3CGGMiBrzfCwv4yEWX25Ok8brQAc3+VtEkltA6qzhI2rVuK7IilCM xCWTtUhkKPSyHplC2y1ROWf1WUhCRLT2q4fLyMtZ4m3Ao30ganhLx+K8arumh3w187co CmfA== X-Forwarded-Encrypted: i=2; AJvYcCX2QUlwvbfpmWRrDg6yk4a9I0cl2rf4nmDfXHMjxqXsZ4Ve0wV8+smTIZI5jYC7q2K2JIwTfU8Vv7QzvMxy@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YySjnICv/sy6fDQ/eDDFvFRznVcwk2HNAvUxHOyOd0dGNWS+he/ 3d7pjFSXjTwXvJyN3xdxTn+lsbKAINUaBUMjJXi1+TzYXFx04yBz+FM51+ce0JIBDw== X-Google-Smtp-Source: AGHT+IHQ/b11eRdAsL3Q6CuUzrMDe0Gkp1LsgXcmJDQ5i/uRT0nTf+tgk3ctIDycxUS992SPvjTWPQ== X-Received: by 2002:a2e:a911:0:b0:2ff:d2c8:84fb with SMTP id 38308e7fff4ca-30009c61a31mr71745241fa.24.1733416209177; Thu, 05 Dec 2024 08:30:09 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a2e:b60a:0:b0:300:dd1:c533 with SMTP id 38308e7fff4ca-3001ed68a38ls304331fa.1.-pod-prod-09-eu; Thu, 05 Dec 2024 08:30:07 -0800 (PST) X-Received: by 2002:a2e:b890:0:b0:2ff:d49f:dd3e with SMTP id 38308e7fff4ca-30009c2c645mr74016231fa.12.1733416207137; Thu, 05 Dec 2024 08:30:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1733416207; cv=none; d=google.com; s=arc-20240605; b=fU3n9gDraYsSBY8KofZoQbnIP9vn5rlP51nRqLORR48PQtbBlNKjBsAuPW4g2T0F9T /+Tjdr8HfvIxowLvk0Iyo0M4f6VHIiGyfKa5+2yetV9rrWBtKfUqkAJ32/j6vOx8+NGK iuI59HX5YmFdMAk4LHcO9hiFjkjlejODtViN8jiFtMDPSSu9yor2QqiM97K7kj4i/Zcb 5EAOvNilmZzcp3/QztfvwvF+DKqrTOQR9UDHzj18dQGslKuBomyvotC/KrF23EdFPUfl HLX3ls6oBzrrvGIsZ70au+cB/vJ0s3zTaz9XkWW52IT4KE6SCpjB8EOebSXFBPlk0iT5 gx2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=ZMjnh9e7Jw2TD0W4BB+OtBZvaU7qr6SdoxJVRCE4W9g=; fh=rUrWmyQoPtNrqCwbfwBbYj/vT+yzYVvbptHCu1Fbrvk=; b=bgavgCbyCAyxLsx9wm/eZPpUSgFCUgvEaZxofzhoVQI5zce7WxZz/dQBcDQ6JpQFFt rfV1FPgiJ5nKyiP8C6SjesSl6Y7BJmF3RoG0rr86U9G9vQ6sbCOuW1n9iESgOu789P12 dooeqwPaq6VL2Z5kZUKxFpyIB21ZOJaAo/MVIg2Ugf4Pb2YOVxEO8tPvDvo2AX2CGb5z V54+/XeBvmoos5lUocQZQ+yXYDb/M1V9h1JzVMEho+7rj5wMUyo9V7CZWYc8Ss8cGI4Z MZ9QSQnyRIvuO1BqXzQvfwZWc+MZlcmqNq1wXk43fYMbAUxM8GJ5JYZJsZMGOVPnzUHB FQGQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=BkctGQWV; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 38308e7fff4ca-30020dc45casor4507581fa.7.2024.12.05.08.30.07 for (Google Transport Security); Thu, 05 Dec 2024 08:30:07 -0800 (PST) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGncsYRQgc/NyLVSHoUSeJQLv9kgaDNjG7+ftw/lZT6VrW7kb8T8urtSSm2DKuL9c 7osHX1mu++CLJRFBPbwu6Drg05WpsWNulm/+teACAEMvIV20rawCsYoes/gm7ANtdAK8rqHsUP9 QqlgQ+t5vk0E5ZY13YoZ/dLyxiFIjSt1+hRov4LnMjHQXqcX7CO8V0b1vaLkfaC1TLAEa6cWpei R0gUrlbf+d/hF8luQ/lo3aT08I1FKNI+Rj3PD6RDgehfALv1x7uiJAR9/GiPLlzC3/ntGlqaKok /5fmpoD+v8Rir7h7K5FbSBKhjy1UNMIkJRyPLo7/x4SBuA== X-Received: by 2002:a2e:a907:0:b0:300:8ff:d93f with SMTP id 38308e7fff4ca-30009c50cb0mr67442741fa.22.1733416206629; Thu, 05 Dec 2024 08:30:06 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.amarulasolutions.com ([2001:b07:6474:ebbf:61a1:9bc8:52c6:3c2d]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d14c799219sm984973a12.55.2024.12.05.08.30.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Dec 2024 08:30:05 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Michael Trimarchi , Dario Binacchi , Neil Armstrong , David Airlie , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [RESEND PATCH v2] drm/panel: synaptics-r63353: Fix regulator unbalance Date: Thu, 5 Dec 2024 17:29:58 +0100 Message-ID: <20241205163002.1804784-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=BkctGQWV; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Michael Trimarchi The shutdown function can be called when the display is already unprepared. For example during reboot this trigger a kernel backlog. Calling the drm_panel_unprepare, allow us to avoid to trigger the kernel warning. Fixes: 2e87bad7cd33 ("drm/panel: Add Synaptics R63353 panel driver") Tested-by: Dario Binacchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Reviewed-by: Neil Armstrong Reviewed-by: Jessica Zhang --- Changes in v2: - Add 'Fixes' tag. - Add 'Reviewed-by' tag of Neil Armstrong. drivers/gpu/drm/panel/panel-synaptics-r63353.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-synaptics-r63353.c b/drivers/gpu/drm/panel/panel-synaptics-r63353.c index 169c629746c7..17349825543f 100644 --- a/drivers/gpu/drm/panel/panel-synaptics-r63353.c +++ b/drivers/gpu/drm/panel/panel-synaptics-r63353.c @@ -325,7 +325,7 @@ static void r63353_panel_shutdown(struct mipi_dsi_device *dsi) { struct r63353_panel *rpanel = mipi_dsi_get_drvdata(dsi); - r63353_panel_unprepare(&rpanel->base); + drm_panel_unprepare(&rpanel->base); } static const struct r63353_desc sharp_ls068b3sx02_data = {