From patchwork Wed May 8 14:42:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 400 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 572A23F066 for ; Wed, 8 May 2019 16:43:09 +0200 (CEST) Received: by mail-pg1-f197.google.com with SMTP id z12sf12819891pgs.4 for ; Wed, 08 May 2019 07:43:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1557326587; cv=pass; d=google.com; s=arc-20160816; b=wVZ+VpkVU7xJLWwBY1EHHmRy8W8TKwEY07B9RkmK0LKp8DockFys2smYrQVYGC8W5L WC7rldOjvRaAuw4PeyhRifEYK8lF9QrFZHrc0gaxitn8QN1R8SqEKq27DdgaO8PYeeeH pfTYh8fEwUNj+QyAkHBPmZ44TylU5KnUMaWKkaprijg8ZvyC9arugZpMRYgceLvz1xJK bqwKLUxk87uTnbdy7o+GJpGByPTV6eYHetTEittP/c+wv4riylIrCaGmw07dRyWZEzFl FoAtykDlmC/EbkQaeDHNP+JORLRl8lTXSJNMRI3Ik2j7UXZiokSy5WoSTZNZUO1uQfnQ l40A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=h/Spndf9jHtWMvVAne5DqsGodAbm/2/daxgdzbIsj+M=; b=fyoRtdTrWFZWycdrmnhmQPEtcUVDOJPdjbQFN3oCgQ5JMjt6Xr7NksW9Us8VTeHSsR hRuOdYB0s+dzD/d1/9FMgTuxh7RqXuTttE4k9hcKC/PYbZpWo2r6AliV+ntBBCc2I26/ HjrXN4uofTw0/bvOzI3aeRwpCWjZk72FTv43CDJ6amyIIJ5cs8iqle8RFOEV8lcZznpX p0mL6+k0K/Gcv/tG3yXQ8vEq+yZJpOuCDmOS9kPZTJu1fNSP3KtfpkA2MTgUgWiSbi42 tUg/UG1wBbgEHgK1BLOZzf74nvcSycOo8cKwgehOcJaKCiUlwRR0u7rdaeOKGoBOv6a1 ZotA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=NHBDdh48; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=h/Spndf9jHtWMvVAne5DqsGodAbm/2/daxgdzbIsj+M=; b=cB2UAJGE/Qoxk8pEB5jNuMUAz147s7yQBXWlEAR/D4bYF35qpMEXycyY8MSmKhWaEo 9u7xUknMZLXRsboYonOXiSjHqJLltxKVnVGcYYbe1Jcgob0ip5nf43Y6LB/dRg4vwedh syKhpSu59SEGDtsg5YaQZ5lIlSwDt7Ad9W1KA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:x-spam-checked-in-group:list-post:list-help :list-archive:list-unsubscribe; bh=h/Spndf9jHtWMvVAne5DqsGodAbm/2/daxgdzbIsj+M=; b=gTWZ08kaEXKJ8tyOfctHQE108tbRG7WcVigwfOq2KQnno1M+Bsv48mlBmmtrzbbIUW kn8lCGva1Z29Lefjc/yWL3t6MNMqkmtvpXn2Mqd14/BePaxxZ+CqoqCElVS6vS4cmDCh ujcHlcedxj/WbtfQcB4HYW55Tg4/mlvWZ9NKSHljcSKYg7/4036Sb3SyMMUQ9Y0PdfO9 Gj97AU4kTtMCvjxscYQVTVedb6jCXc1a/DnZWWDg+/Ah4K+zUupncWKyfCOyEu4rJoFO aTVlgwliDbP7lqkaTiBr0e/xQe4PYQpZaQte7wrbNbUZG33f5BW89QX6kMcShwMbo1x4 dFEA== X-Gm-Message-State: APjAAAU4bJz6UaMZHbRHPkigQgCh1+foYUtQ4He2tJafsiou+fzWX448 CQjEg6M5L4keRt7ZZbLsgT4Jb62U X-Google-Smtp-Source: APXvYqxSj0SPqrs5bz4Lgopimm4emdyiSPQc/weLN8U2sFXZfyHfhKEJXp7QpNm5WPsok9+HP55TuQ== X-Received: by 2002:a62:489d:: with SMTP id q29mr49204255pfi.45.1557326587366; Wed, 08 May 2019 07:43:07 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a62:2c51:: with SMTP id s78ls5583190pfs.1.gmail; Wed, 08 May 2019 07:43:07 -0700 (PDT) X-Received: by 2002:a63:690:: with SMTP id 138mr46746108pgg.415.1557326586989; Wed, 08 May 2019 07:43:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557326586; cv=none; d=google.com; s=arc-20160816; b=nhE6it0JqdrtKwcAZTEBLR9y/AnlzLVwtHlDzK6MZQMjd1AYQSEWyDjE/TaFEC5TG4 vqHwA0SHJMyEJrxVF4VhhtjCtnMLNxH5qcInx+xAlQqmA3Ld9Spt96/nn+BE2bj53QT6 NA/cT56PLpmjU+V3TZ0g3TYcmB7iXp6rrs1HFGMtnuisz7/5y98O7Zt/vCi490AOR9oh 15d3EwEA6mhHuVYlTcWn5hSueBiXayBemMtQBW9kHCGvzpHgIPSjleg9epMoixnEVUcn zRvSJlvTENxXkhnFebWAFUsCzSgEs/oxDAYxGjSWMtr3AS5pNdHNvxRT3KekmwHelmTo lwMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=PZAFSbjLALM+3E0G4WN3w/EHxMNFIUeSqjYfnAz02nk=; b=rU3kUoQC5m5T3Ugiu1OulqHHTuJ5nZzDOOZob0SS7R/kGchhPHxKYn/opVSMGmbRV4 PROCdA/3ebCjED51ZL1FlAW/0DX0xMDP8sV1IwKbT+KIxCbxfXlcMgVLxZOqDqaiV0v9 +rS99s87FcRf+kWuvOmayh6Ktv9jAzXHHB9O1z0LLEqKOaY0I8NUdcZto02zd9gGdrkH Su/q00l8GSC92YwMOJWQGDTxl5bEzWaZJOztzuvqvp0MjQMTX+k5Bl77gslLjg7CAXB0 G/tR3Mde9xSCl05gsfg9bPBHRPzGH6Iz+trWJabWO/v+ZMzGMp8mN5Vq+skgnp4ivq0u Ze+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=NHBDdh48; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id o61sor15116638pld.19.2019.05.08.07.43.06 for (Google Transport Security); Wed, 08 May 2019 07:43:06 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; X-Received: by 2002:a17:902:6842:: with SMTP id f2mr48101350pln.189.1557326585912; Wed, 08 May 2019 07:43:05 -0700 (PDT) Received: from localhost.localdomain ([183.82.225.185]) by smtp.gmail.com with ESMTPSA id p7sm20864307pgn.64.2019.05.08.07.43.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 May 2019 07:43:05 -0700 (PDT) From: Jagan Teki To: u-boot@lists.denx.de, Tom Rini Cc: linux-amarula@amarulasolutions.com, Jagan Teki Subject: [PATCH 1/3] spi: atcspi200: Change include order Date: Wed, 8 May 2019 20:12:50 +0530 Message-Id: <20190508144252.31001-1-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=NHBDdh48; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Like clk_get_by_index, there is requirement for clk_get_by_index_nodev. In this case to make common code functionalities for dev and nodev, clk_get_by_index is trying to get the index of clock by passing ofnode instead of actual dev like current gpio uclass does. In these scenarios with current order of include files the atcspi200_spi driver is unable to find CONFIG_ENV_SIZE. In file included from arch/nds32/include/asm/u-boot.h:24, from include/dm/of.h:10, from include/dm/ofnode.h:12, from include/clk.h:11, from drivers/spi/atcspi200_spi.c:9: include/environment.h:145:19: error: 'CONFIG_ENV_SIZE' undeclared here (not in a function); did you mean 'CONFIG_CMD_XIMG'? #define ENV_SIZE (CONFIG_ENV_SIZE - ENV_HEADER_SIZE) So, fix consists of changing the order of include files in atcspi200_spi.c to include first common.h file. Signed-off-by: Jagan Teki Reviewed-by: Bin Meng --- drivers/spi/atcspi200_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/atcspi200_spi.c b/drivers/spi/atcspi200_spi.c index af96c6d21e..e0cc323444 100644 --- a/drivers/spi/atcspi200_spi.c +++ b/drivers/spi/atcspi200_spi.c @@ -6,8 +6,8 @@ * Author: Rick Chen (rick@andestech.com) */ -#include #include +#include #include #include #include From patchwork Wed May 8 14:42:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 401 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id E9EB13F066 for ; Wed, 8 May 2019 16:43:11 +0200 (CEST) Received: by mail-pl1-f197.google.com with SMTP id y1sf5439637plr.13 for ; Wed, 08 May 2019 07:43:11 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1557326590; cv=pass; d=google.com; s=arc-20160816; b=kRkiYfCdlcEYXIlQL/OLTinG192oky4HB2eC0CzJpUnHY27sMJy4hXJksnq0MY2BfA hqxmdr39NlmiZDmP3j6sq6JSTcrzXEXtLWeTGJabBQi/4NGgt0E7I9C7LhVrRvqcLniP fVhrHOZD62KPFo1hMINDR6OqkwaE+zNif7qQE4HMm2yvA1R5Vxs1Ryj3HQkU+naMp7ym i3U8weuv9nweA/8P0WkRbG1tmoCO8XDl2MfMzM1KlXPqzAfqBzPBPIoHxHtaq/N+rYbe Tmbo/02zPbpDm+sTWvrObDbFA0e/vhA3iu5PEaZ4ePUOWtGi9ds0FxVEPoOdPnxK8KAN 0PQw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=QNx9PfHpa7hVsPvFEbUHK9BxWd7TLH85O6xMCYX03u8=; b=Cv/VqReKbwCX4uUW7qV1Pn9G5zeaE2rEM4AxlFLRiqFKZ8CjmltwNtTwbWBtiSe/Wb RbGFIOUMFkn73k4niAfBzhYE4gjKftsX869NhQtjxBHQzRUd3QE5n8hlQS3ukbcvy/3v zpz4YzUMjw1GpXplo7pTLjSNcZWYJvKWPnPjX5TmECKynEwoXig9AH8lX+8/afE193oC zJ6MbL1UXrch3w4OXXTpnh7Zq36bJ9UqcNiiy6JK610s0kfzyl83AOxxjBckP2kCkhHx 9cCsEWtUpBjkIYCuLmmfktWS/jnWfHX75zJLRqEbpwu9pOnpw97MfhDjwctmHlmCuqCq 0z/A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=enc0HGZ7; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=QNx9PfHpa7hVsPvFEbUHK9BxWd7TLH85O6xMCYX03u8=; b=C4QpimqU7H8guu4DkG4HXWGk252FP6ne0lXuKx1keBuHZDC1qr043TPKtnLitET2z3 WqVVcIrqBOCqisgQRKKKgon+Z9uDalPlXloldoT/gYEvejFdyFYk6S2H/+2BXlneTPfH 5Q/2Hkcs+dV8SfiIDvwN/oLu7F+2NZEFyKqp0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=QNx9PfHpa7hVsPvFEbUHK9BxWd7TLH85O6xMCYX03u8=; b=I3QLcNhum+PO9HSDyJgI0XVa91TUtSF/leASPiRydy7wSo+JUIJkAiGcFScmknBRao p3EIMHBuN8OjS471qkJpcdkOwr3iu4dysew3+ZuopbGKmSaOVXJgB29kAeLM4szfRtGd +xF3M0v2Xsvk+3KDOUnsi0ODbyRPxZcVxKrjqnHmC2gNn/ElWpGiP38sE4iq8ISAiatN d0tDfHF4m5KSsM0nPDzmBtL2GkSvgrZUqURJImAus+PxGcAvBjkY8aAbNSgfSL11XapB CXLZMSFhZY40msaYqgDFaj61U6DIC6Rv0JpBnDy0UfTSM5vAnRlK5FpMRLroJZxxyuPq siIg== X-Gm-Message-State: APjAAAVXNpspnwg9RB8pzOYgtUeMOdQE7GbO9+Kl7vFsUsW8CQPvEwrB 6Cga10s6OY2+LzmWGwWqUACnkFux X-Google-Smtp-Source: APXvYqxZfYDWGWU4qX94VsbuPZF5QLrNmT43C0HFRyRwNhWLsb0AnNdeSR5HiyJOMZ/Fy/kdMVDTKg== X-Received: by 2002:a63:4a4f:: with SMTP id j15mr46568560pgl.338.1557326590029; Wed, 08 May 2019 07:43:10 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a62:120a:: with SMTP id a10ls5577637pfj.10.gmail; Wed, 08 May 2019 07:43:09 -0700 (PDT) X-Received: by 2002:aa7:8392:: with SMTP id u18mr50552770pfm.217.1557326589588; Wed, 08 May 2019 07:43:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557326589; cv=none; d=google.com; s=arc-20160816; b=zESTt2RzwHUuTdf+jklEDLfiBbyIb8M8JhIgC3wGRqtLctoZxlwIS8wK50346+x3Zx tCD7n/JToUoM7F2JQ6ABMVfDdyKZBQIGMRvlphrgJ3jT/qYmXDvWce4sMdXIA0fQE65n Het9KFHs9PM/G0J82uVg7JrBJ696HPWYz7tq/aoN9brwb6NpeagFftp9fntTKBSMTLb1 gZQBp2XMNuLQ98IGIcVUkzCSYLew0pqajOg8nl9JFnWs97h0hNk/CTuYba/JS129zB3O f0GKpS/tB0K71ivZeksH3VIIRPlikgxNr/WIfOv405eQQFpMV0yRB9mMHLlkrVMZltvF 3IZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=DIAk7AlP4BsXCYNNZbordBOyoaPZtdnXPU8gfq5aJ64=; b=bGj8unBgIyrkrAoie2qIvo3gBQZvJGOwf1RrIhnagGUu47gmg1xKbzT+juyoJD2DdU uZGN1cJosTOCIVhIJHLmXQ/9jXhXAzQiCYftbmGmfs7X4BiTIheqY7cwFVOU67xhwoep RRNFaTDOzpXXtWtgiToGjBmKm7N2g3UJbtewNMRsJVF7yGkXMguhbyf8iIvxzletghIj eHkIn+PTvhyXXSgTMVDuv8caduMUCqP2LAmPaQB00jbjDwHKF/VJLt5L2N1zSloO1X29 tdE6BGMO7yEsGuYtDM1dE1KEamlGR3lNMosXfSZKFSRlZwIhjuEpZWa/Y75ZKkEnoKa4 OlOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=enc0HGZ7; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id l7sor17747786pgm.9.2019.05.08.07.43.09 for (Google Transport Security); Wed, 08 May 2019 07:43:09 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; X-Received: by 2002:a63:171c:: with SMTP id x28mr46822211pgl.12.1557326589286; Wed, 08 May 2019 07:43:09 -0700 (PDT) Received: from localhost.localdomain ([183.82.225.185]) by smtp.gmail.com with ESMTPSA id p7sm20864307pgn.64.2019.05.08.07.43.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 May 2019 07:43:08 -0700 (PDT) From: Jagan Teki To: u-boot@lists.denx.de, Tom Rini Cc: linux-amarula@amarulasolutions.com, Jagan Teki , Anup Patel , Rick Chen , Paul Walmsley Subject: [PATCH 2/3] clk: sifive: fu540-prci: Change include order Date: Wed, 8 May 2019 20:12:51 +0530 Message-Id: <20190508144252.31001-2-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20190508144252.31001-1-jagan@amarulasolutions.com> References: <20190508144252.31001-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=enc0HGZ7; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Like clk_get_by_index, there is requirement for clk_get_by_index_nodev. In this case to make common code functionalities for dev and nodev, clk_get_by_index is trying to get the index of clock by passing ofnode instead of actual dev like current gpio uclass does. In these scenarios with current order of include files the fu540-prci driver is unable to find CONFIG_ENV_SIZE. In file included from arch/riscv/include/asm/u-boot.h:23:0, from include/dm/of.h:10, from include/dm/ofnode.h:12, from include/clk.h:11, from include/clk-uclass.h:13, from drivers/clk/sifive/fu540-prci.c:32: include/environment.h:145:19: error: 'CONFIG_ENV_SIZE' undeclared here (not in a function); did you mean 'CONFIG_CMD_XIMG'? #define ENV_SIZE (CONFIG_ENV_SIZE - ENV_HEADER_SIZE) So, fix consists of changing the order of include files in fu540-prci.c to include first common.h file. Cc: Anup Patel Cc: Rick Chen Cc: Paul Walmsley Signed-off-by: Jagan Teki Reviewed-by: Bin Meng --- drivers/clk/sifive/fu540-prci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/sifive/fu540-prci.c b/drivers/clk/sifive/fu540-prci.c index e1b5f8e6a9..2d47ebc6b1 100644 --- a/drivers/clk/sifive/fu540-prci.c +++ b/drivers/clk/sifive/fu540-prci.c @@ -28,10 +28,10 @@ * - SiFive FU540-C000 manual v1p0, Chapter 7 "Clocking and Reset" */ +#include #include #include #include -#include #include #include #include From patchwork Wed May 8 14:42:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 402 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 6840B3F066 for ; Wed, 8 May 2019 16:43:14 +0200 (CEST) Received: by mail-pl1-f197.google.com with SMTP id y9sf1890203plt.11 for ; Wed, 08 May 2019 07:43:14 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1557326593; cv=pass; d=google.com; s=arc-20160816; b=BjPKirFr91SRa7fNh/y+6sIeBKb5q3zv+HzOJ0eaia9EZ6gD+9e+Wq3uzXIGBbQDXw GFZ3Dmu9XAiollgn1QcYqxNy0oXvcFdvnXLbywn1LWs2POvuA2wR2fUiBMR5Lb365ng5 SR75Pfk+TDA7C8+3BqN8SlXCLLsRp22g0qGZVBCYHjP80eBP8GokBwBcmPpQV4/0k7hn DzDETvyiwrDftMMgmbqnQsKhvYiX6raRET2b2ebFssXUKd/eVlwJ9ElTob26tZES8qMz tkLlFIgfOLrVuU1zQ0Zm4NjRMZlL36v1v9ur0sSxSw37bWROWrSjtKg1Nkcu8QJnt2Zu PQMQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=5HN0uxu1RCfiDph/f8dSBdpUZWs/IQTiJu6wtgoYckY=; b=Ag9RbQImu/zM5ccLmQqKJYqPHUpnDHIbRVT6/sdRZwonU2VZ+QWYox3qf1jswVIob5 1n++DE+lXx0cDQJvCLp3gRE6+ZZqBh8Xm1dfbATfRW6hmRcircp4mlEHLSOX2+ta/cUY MorneUYGuSPI/N3QgI8LX6FHMd7S7+zPiGZLzkPZHq0WWsQjShaXVzKnLgXuDSuLYlYP O1WzpCSyZh4MxF/d0FsZPHn+MniqGJzVhdJtSd9D99VRPIabfyB6GAWzoNfHD8E7ehiG gid615DBulPo79YwEnFOLEDtWt5kG1EWy1YITU5Q2cacYrehjoqJuf5emnmpVoQq/+uL PIeA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=GTLKG6n6; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=5HN0uxu1RCfiDph/f8dSBdpUZWs/IQTiJu6wtgoYckY=; b=j/EB2ltH8bb73JOplorY0IaDwHUne0O8vx8UTuE6xO0mPNMlQcbpeIuMZpYytP8jy0 /qX4YhPntKnzi8fGCS0/IKjTDflEHGACyehonSA9r9Na8mM8W8C0kvcIvAMq046cgG98 SnjAF7e8KORpETmepeSO6iA/iCT0cByuoo/eY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=5HN0uxu1RCfiDph/f8dSBdpUZWs/IQTiJu6wtgoYckY=; b=B1xd91DJiswPnsEXHE2VLZgpusrkCX/RNSUQXlZoXSBoDcb+LoekJbdAWHwdL1NMII Du4lRhAu5o8+l2siJ+15AemSE2WJx+DNhaRJb/eYeYTM4PJgntfOjGIgoVOHu9f7IJMH QsTch7TDd9T0T4X9OzlaG6PDhsIW7HeZbzVrJcJIN2x4/smcIufAMjlAPYhjQnJ2gDh3 05IZMP4MrKz1z/IIS3xYIa5q57+V4geBdkjG4r3ufRIu3w3EslmcKNv7LbKlYCUmNj39 jKNkHwjtI2bAOVP3brcir5EQl0zbWZs6NkHNfZjrDzQnLqY8BR8WvEPwcTy7L0SW5+In q7pg== X-Gm-Message-State: APjAAAXIHzmqyqqh512b/78LtP2XKgohVrZ/Uopwn/qPxJshM5TNiw5w MbPcDKv1CdIk8l3aArxVZy+iuv61 X-Google-Smtp-Source: APXvYqzh8zaI/9gpIrpVCa8C+mJM6Bj0QmOxZD5vx1ScBYWCVsYhWXg6nv8Ao4pSXSJ4v4shK2CLvA== X-Received: by 2002:a65:480c:: with SMTP id h12mr46319087pgs.266.1557326593219; Wed, 08 May 2019 07:43:13 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a62:130a:: with SMTP id b10ls2007971pfj.14.gmail; Wed, 08 May 2019 07:43:12 -0700 (PDT) X-Received: by 2002:a62:6444:: with SMTP id y65mr41228119pfb.148.1557326592828; Wed, 08 May 2019 07:43:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557326592; cv=none; d=google.com; s=arc-20160816; b=JLJfTK2lcA9SOq1ISRgUzXuGfW63xFFRrirDca8oq4eKNMqi6QDkftyqbDR/paWCkk ad9xs791kKGozi+UmWsf9hKRdWDPBYAy7qTw+htcFrz5TUSb83Cp+RvLnXQIQYE0Sjs6 g+4ZMIG/Yy0rsatEUGauW2Xf+gmCxMrUAQezGSyTnWQkXeAGcIzfBN9bkn/hj8A4WN0x bIBkjn39XEucJMfqxgZNIoYlscaeJ7LgT8z+gFEO23gpYJE0OAvu2oddXf4J3cS21xrb hfFkdbKr5FEsDS8xqhwnMlwr60jFMr8uVQea7eeYhUHFpUKywkl1IpE/tB5uAEZCddn3 hHnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=qMdqWGAiNPcJ3MLJrizvgww7TeegVpny6bBtAZYbZq0=; b=CNuwtx5n9eaKYSTb7yRtc844iAe0Vbo7bZmubrXe0u3RcANMSi925P3MCHuO0K2j+B oH2441IESgwFpV8JIPExkCLOHzLCj/0TdtE6QMKrAtpnXi+sYhaHBVnA1qXBKtjMbHuc jtdxivqQnhq+GLMotLhTs5PYo8eoHvnObXZm3RHxi9Rb9Nj3/anp1W+jIYIFBL5qaEG5 scKbi3jI+K8w1ySN5lBqzDtm1jtXzenarq6uRTSgo8rlGBNB2WdVl4Co4m6oXOAKegWO 8kuxlNQ/CBaJy64KWUEf2hyf+IP5enm10Xc35ObeFkfHn+pBxM04dhmsFLldthIo8Q5U AbCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=GTLKG6n6; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id u1sor13883978pgq.63.2019.05.08.07.43.12 for (Google Transport Security); Wed, 08 May 2019 07:43:12 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; X-Received: by 2002:a65:478a:: with SMTP id e10mr47545829pgs.310.1557326592540; Wed, 08 May 2019 07:43:12 -0700 (PDT) Received: from localhost.localdomain ([183.82.225.185]) by smtp.gmail.com with ESMTPSA id p7sm20864307pgn.64.2019.05.08.07.43.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 May 2019 07:43:11 -0700 (PDT) From: Jagan Teki To: u-boot@lists.denx.de, Tom Rini Cc: linux-amarula@amarulasolutions.com, Jagan Teki , Anup Patel , Rick Chen , Paul Walmsley Subject: [PATCH 3/3] serial: sifive: Change include order Date: Wed, 8 May 2019 20:12:52 +0530 Message-Id: <20190508144252.31001-3-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20190508144252.31001-1-jagan@amarulasolutions.com> References: <20190508144252.31001-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=GTLKG6n6; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Like clk_get_by_index, there is requirement for clk_get_by_index_nodev. In this case to make common code functionalities for dev and nodev, clk_get_by_index is trying to get the index of clock by passing ofnode instead of actual dev like current gpio uclass does. In these scenarios with current order of include files the serial_sifive driver is unable to find CONFIG_ENV_SIZE. In file included from arch/riscv/include/asm/u-boot.h:23:0, from include/dm/of.h:10, from include/dm/ofnode.h:12, from include/clk.h:11, from drivers/serial/serial_sifive.c:6: include/environment.h:145:19: error: 'CONFIG_ENV_SIZE' undeclared here (not in a function); did you mean 'CONFIG_CMD_XIMG'? #define ENV_SIZE (CONFIG_ENV_SIZE - ENV_HEADER_SIZE) So, fix consists of changing the order of include files in serial_sifive.c to include first common.h file. Cc: Anup Patel Cc: Rick Chen Cc: Paul Walmsley Signed-off-by: Jagan Teki Reviewed-by: Bin Meng --- drivers/serial/serial_sifive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/serial/serial_sifive.c b/drivers/serial/serial_sifive.c index 537bc7a975..fdfef69aaa 100644 --- a/drivers/serial/serial_sifive.c +++ b/drivers/serial/serial_sifive.c @@ -3,8 +3,8 @@ * Copyright (C) 2018 Anup Patel */ -#include #include +#include #include #include #include