From patchwork Thu May 15 11:42:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Nazzareno Trimarchi X-Patchwork-Id: 4020 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 620963F97E for ; Thu, 15 May 2025 13:42:34 +0200 (CEST) Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43d0830c3f7sf6023515e9.2 for ; Thu, 15 May 2025 04:42:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1747309354; cv=pass; d=google.com; s=arc-20240605; b=i54ikyqUZ3Q8V/4fsRn8ibyjamYKYt0BPF54jvxLcbmgdVR9VLDlrI1uQzfoak69wX 56sctiDVaf35CNzApHhXQL6OsPlvWYHOle4xGA3DYu8SZ4KtT21kvjVYIYf5g7t1ogn4 5+Me5Ladxo3xbH1u0OWxqn0pqnr9Wz8XpWiRzdB8UPVBpE2r7KvDS4R5b2vxHlvIiUL/ 99uaPoGQ+B8u0JuBHr1GxMj+DKg1pmLJV87NOHHhmsGRx2ZvWgN2HhxuWN4xa5DsREBW ZjQZklNOJX7H5ZOd/jieKfbvD0uOhv21tykA2The0vyRWFnQ7/Y3TOs80oVxrxFrlD7B bAkQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=zfyhkTjCB1GuvqqfQZKpE0dJI/nGSkAA+zK89yJpa+o=; fh=ttEDQkk1klLCjxsVrKe2vSsoasMGxhs1Y7+paITpSF4=; b=Z67vrdQ2AjFmTfgZcdroUHA4XO3U9Czl/ad6NK2Vhp15iyA1OHOuUCpNRN/wh417vf bTb7SPj2FV6w5HmEICz36ZJZgdL6WQeKNYsEiFTooVoQIdOqqxO3toThh0H4XL4eQkQj MCz9IQg2NV5QBmubrROL45stljwfw3mpZ6lFHeMepRQmf3UD2yxiuCE08p3C/V/c1RXq cE3EHAHZrak5IlqYm5xdVFQ2S6ghssfaoxAqtyxiVg2m+GbEsPoW/ZfGhT1sSDN+hR8+ onff5ERel51GwGqH6KbhlaBms+tqH4JL4GHn3pnWLVFcmqn2CDY4N3IYoTk/RNcQtt96 7sCQ==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=DyPIWn1j; spf=pass (google.com: domain of michael@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=michael@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1747309354; x=1747914154; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :from:to:cc:subject:date:message-id:reply-to; bh=zfyhkTjCB1GuvqqfQZKpE0dJI/nGSkAA+zK89yJpa+o=; b=g+XhEA4e1qx0th5gq6PLrFmCSyzAd9QbFakEvm+i6uPgBIxMQKsP1q5C4hl7DW6beh akVT2CZjZIauJNU2QAgnGULsgXqYxD3S8yZ8ZR1uq3I67tYUKVV8CFsyE8kqPXLElAYA gnfVZ/PsY/QEiCLoR90thlsLOnHJrQvuY+z6A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747309354; x=1747914154; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=zfyhkTjCB1GuvqqfQZKpE0dJI/nGSkAA+zK89yJpa+o=; b=Ec6oFqME8sB8ActkSd4IhTrAT9vNRRe2FGCbcFEGonWprHc5AtECLp1xck/jrVLOtV ClZXVwvCfD8Wz9Jovs8LwwSu1sBaqCJukjg8/H5nzE0ij8jrg3WY4eE6kFQUmUw7BQDW NY9Tj02KF4AaGZ6gh+45nn5j6uo/th+HIRTULOIgdOboTsqPuWnCaMX2W8dMYVd75zzN inI8sQmIcIXMYVkUaeDq3IG8faM8XWmQ78cOPpW+8pYxgQvfArXX+2xhfZV0XxaoN5GT jdXex+JBXoz5h0/2OpaJUTR5DEnRZqvgHqYV9LFDkwHg9o61N3uOVAgegLq93wL0BgbK rgQA== X-Forwarded-Encrypted: i=2; AJvYcCU/iqotSvuZpX+Cy09y8z9Jrm/Ag+5PNQ3YMu+A1EY/OPehRQZmfReKSxfe0wraKG+1Bc/jyDugFvRfG9uX@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YzxR07Fsjr2O3Gj76fOXukrTAj6psgys/AMNkDMiGX5+raaIsii 1hCClHQ50ami/HSVincF17zD5ykPAlJ57Tlzt61SNUfoBKTltRvFyOf+aiaflFF77Blf9UXzsA= = X-Google-Smtp-Source: AGHT+IHVHnNAp08Apbalrk4zgTLqv8ZcIJwdf0FslP85egTsK2/IfbOZ3jOB3rJi7XukmZo2y6k/Tg== X-Received: by 2002:a05:600c:1385:b0:43d:b32:40aa with SMTP id 5b1f17b1804b1-442f20baa06mr76573315e9.3.1747309353555; Thu, 15 May 2025 04:42:33 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=AVT/gBHFyLSx56FDz+lD33OHy6wwmX+sRe0DCFu9GzTXs1aflA== Received: by 2002:a05:600c:1e02:b0:43c:eb7b:1403 with SMTP id 5b1f17b1804b1-442f878077cls4798925e9.1.-pod-prod-09-eu; Thu, 15 May 2025 04:42:31 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVefpY6hvYPIksbB0vXTm58XdR/DAk7mknPFevQH6Y4V48N5pIDqEX2RlbeYlpPpiz7qNm6IJok1qC9iVEU@amarulasolutions.com X-Received: by 2002:a05:600c:5125:b0:43c:ec97:75db with SMTP id 5b1f17b1804b1-442f20e3e9bmr61177935e9.11.1747309351126; Thu, 15 May 2025 04:42:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1747309351; cv=none; d=google.com; s=arc-20240605; b=OYULj6OJIlYyd/BXvZBr0nnhKzCka9CZbid0dTYemkIMy4IVm7TYotpgaJUq2fa70J ICtO0IUZh7FJyuElceiqcRl1yo6wyeguXZQtR6btga4fRNq09KWDC4rTxiqnNuXIyC25 lCKwNAbwD1kg4HXgma6MHJ4NsT+55lVypwDwG6SEP33wpGiajFHUpHGYkIsJ39rRQy0V lq+H9poVbMYKi5tuK3aP0Femhw591BA35faJ6bb/WcCnh8ve9lDep3MvuPdZwzCOP9lp sIRT51GXLO/+WOaf+h7xDC1QSJjoxQdM+J84f2J1Ube3C7VVtr19ahOOD4IyejAuwm1J 5nJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=FouuJ1o2eXS/CmPDJBY8FiJN0WfCkNIPxSz3kBraOmM=; fh=y2fvfMz8TQMNHBSdckPEa7AVChmyIys9++44P4GRuwQ=; b=j6rMNIkLNepxIphltI3NQSrHvXGCUyZf2+zxk6o3/lsqVG5wzXY9+r4GiGJlWFyLjq rJHuvT4D1IG+Hjsh53A9p1HNIqY0ZX437XVfyLLKNl/qHha12o8ALd8E/9XN3iAk8NcG aKTAHrOCdWcoAum8PbgZaeL3c/tEvmFMgF4mZoxVVsVLMr6qksZhggVP4v66WxRwVV2/ 2EHkkKmHBAh56i5+ExDO1GQ1mpdaPvCeiyBnC/eDdICLNXNxcM5tQAWjcqebbTXR19Kl dbxH6wnrT7DY1j8kTf0ZnIT5BTqO3l8vVXTVYP5RryWF7CxqU68JcTW581DMNo+/z2UK U26Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=DyPIWn1j; spf=pass (google.com: domain of michael@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=michael@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 5b1f17b1804b1-442d67d778asor58580235e9.2.2025.05.15.04.42.31 for (Google Transport Security); Thu, 15 May 2025 04:42:31 -0700 (PDT) Received-SPF: pass (google.com: domain of michael@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCViKzzxUkD9xWdYlAhMjmzyPF4iPjwgpOTbYBETawXQqQaLdB/P0upVutd387nYUvMoDZQ2xM88zQhKs6NR@amarulasolutions.com X-Gm-Gg: ASbGncu5pprO9kUOsO4RlVw6WTO6LwXiwT+kamskVKfDt+dSaY+WxYlzzAuMrqAzyW3 OhtpmvzhOI2v/ON8VSbjTJ4gbHiibv9jccYQ8meARTkgiFpfSfldGv5Dh4CEIeBPYcNxyCggwNe ri481hm08F8BZiW7wKuHDCnz0X9t1gpyxvnztCTJsQzRYcan1x4QacQoi5cOl1XfMhZiXYkI3ZN uaNMv/VkFCW4uP286oxXda0wE/ra6uyahsrEVD6tbFdGUdipRsJoVNL8xcqSAC/gJbxm2ph8pTr wsF8jHBoHh7CGO/46OeQAscwlO7Ybhoh2H6CNOEUeXBqdZojlX7YKaSDHi2VvB44kMLk5Dv2MHg y4osiRnyuy2r8xs/55J9GyztGXnVFVRvkQED6HvzzEIh1PzApc1E= X-Received: by 2002:a05:600c:6099:b0:439:6118:c188 with SMTP id 5b1f17b1804b1-442f2110fe7mr69404485e9.19.1747309350745; Thu, 15 May 2025 04:42:30 -0700 (PDT) Received: from panicking.amarulasolutions.com (p5b26784b.dip0.t-ipconnect.de. [91.38.120.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442f39e851bsm67918975e9.28.2025.05.15.04.42.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 May 2025 04:42:30 -0700 (PDT) From: Michael Trimarchi To: connman@lists.linux.dev Cc: denkenz@gmail.com, linux-amarula@amarulasolutions.com, Michael Trimarchi , Andrea Ricchi Subject: [PATCH] timezone: Fix compare_file comparison in timezone checking Date: Thu, 15 May 2025 13:42:26 +0200 Message-ID: <20250515114226.1456590-1-michael@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Original-Sender: michael@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=DyPIWn1j; spf=pass (google.com: domain of michael@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=michael@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The patch allow to compare file only when are not in the same path. The compare_file is used to understand if the set timezone if the same we are going to set Signed-off-by: Andrea Ricchi Signed-off-by: Michael Trimarchi --- src/timezone.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/timezone.c b/src/timezone.c index 89c44895..fba8b925 100644 --- a/src/timezone.c +++ b/src/timezone.c @@ -124,8 +124,8 @@ static int compare_file(void *src_map, struct stat *src_st, DBG("real path %s path name %s", real_path, pathname); - if (real_path && g_strcmp0(real_path, pathname)) - return -1; + if (real_path && !g_strcmp0(real_path, pathname)) + return 0; fd = open(pathname, O_RDONLY | O_CLOEXEC); if (fd < 0)