From patchwork Mon May 13 14:24:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uenal Mutlu X-Patchwork-Id: 413 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 612003F08F for ; Mon, 13 May 2019 16:24:43 +0200 (CEST) Received: by mail-wr1-f70.google.com with SMTP id r7sf8528273wrv.19 for ; Mon, 13 May 2019 07:24:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1557757483; cv=pass; d=google.com; s=arc-20160816; b=WaFYBQ9Z22//VdHicBS2NrPbGi7hGwnh2I0rrpFAvfSOW4D0BYO7AhmPwmBrtYPvwb yYEYl8koh7um7vnqMMfPScoQZtwS8iGR0FQNqWLWh5SV8yqhQMORmipmRc+ZiYOxN4Za fM2ZrAb5JTxIFgAbpioKxVSB4j7aK9x5cDR3/iYbLpek0qhTJkxDvaAcXe79GWpucEMi t/pNQ6QM19ZFx6DpRPsg9Uirhj+MB53jtl0Xe3s9Sg0zBiegvI89nBLb8e//QJ36rPgK R9Hyslv4HWAHpUaBYuRijZmg14jVtg7ATw/gm438QGHwPc4vHLjO7jH4Fhf+wVh2772w xyVQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:message-id:date:subject:cc:to:from :mime-version:sender:dkim-signature; bh=G02MQOK9mg6OGxsZ2iYy84q7EQXz6ogvYdOLVLCaWu8=; b=kMMb8PVM0BUGaIPiZQU0TbR6j1Ahd/WmqvJceaA8nJiuTexuZyw1+j89bDs4cMBc+/ u8UBH321MBKEwIjF/PlgdL5etysa8g3iKdXXdn0q5Blt7oCG+YTfUfc2w+ocrzjIn2hM M3MDqbbRNzChr8iK/whmz6etZJ/kpwS59Tp6R35pwlfU8tG0zENVJvRpTDTNAV5DUx6j hcvFSIffahl+IoRhPlQRyRxbl7Rff8Wj+2K2dQ3BKMdd7S+US6I1N0TOtHOlVQ53c9zR xQNq2T9NRY+nozfYjheRo3MXb4hB9HprGeLFeheRV1FIMjjgk9EUQZ2jDXUQjoF1UdQH OVAg== ARC-Authentication-Results: i=2; mx.google.com; spf=pass (google.com: domain of um@mutluit.com designates 82.211.8.197 as permitted sender) smtp.mailfrom=um@mutluit.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=sender:mime-version:from:to:cc:subject:date:message-id :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=G02MQOK9mg6OGxsZ2iYy84q7EQXz6ogvYdOLVLCaWu8=; b=CtXrKx4w/dRUcpbYGlzFz04ywoexZGpaUJGSgNcpZ7nHyV8o5PvUCp+uzRoKe+NIFU xWXzldvnskZlbTVp2a7JnpvC/CDO2TzJnAFSGRuW2cDSwjXUzvsCqSJC2M0GVv31BLKD E/gawN9a1tIIT6tTMw6z+WooGaRzlTaFtrBqc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:mime-version:from:to:cc:subject:date :message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-unsubscribe; bh=G02MQOK9mg6OGxsZ2iYy84q7EQXz6ogvYdOLVLCaWu8=; b=MBHPSy6Gb8NxRkoZ1Fbux0GDXu9/ZqjP5se1OIiCFLeVDqoMKd+Zz6uOT2SUq/1/m0 tFe/d/8Mw8DAL72P5Bj7wKf03MDXAMHTX+OZG9k/SCHNNqu/onbRfYln6CL0F/5AkEE4 YFh2ljJzwcvZQMkyVhvfB+zaHUOWQvCX09zbxra+KMB7FawaIAjcM1uJ+gkkmbMBoRvX s3hxYrlCMMtk+U9zYZqiPUPsVjw3CH8Hpubbww7yUC+nSWcaV1z5czYtoXKIjR6W7D7f YbyedZeX1azChkgq55P5BO/IlfkwL9FLYUXwhtwzlFDoD74gop5RiwNabisKuvfO5xU1 EKAw== Sender: linux-amarula@amarulasolutions.com X-Gm-Message-State: APjAAAUABolFN4b0rE/Won38+s6Hnx8BsftiMMJ7k6ZZM9AQIOMFP9xy Rion3JWwSEYKEXICGW9+RtsoNLyO X-Google-Smtp-Source: APXvYqyT/pWv7o+u1uO6+FrIfHZREHhLfnB1mIYvxICd0DEhOMoXQnyCFhHHyZF5N5NZRl2+i27NTg== X-Received: by 2002:adf:eb4c:: with SMTP id u12mr18697780wrn.235.1557757482936; Mon, 13 May 2019 07:24:42 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a1c:f310:: with SMTP id q16ls3720880wmq.3.gmail; Mon, 13 May 2019 07:24:42 -0700 (PDT) X-Received: by 2002:a1c:f909:: with SMTP id x9mr2231997wmh.12.1557757482319; Mon, 13 May 2019 07:24:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557757482; cv=none; d=google.com; s=arc-20160816; b=SQN4zweazMBq/sWvlgfYsP7q8owIFsRZsAh7u+OclejzAE1CVJM0EkFS+tuVQHaJ9+ yBN/MjzuBJvltGrO/NuZ2jYegkuy1iEh+o8vraO9kLNZe7FDRAn9Vr9VB/bHY98YDLvD BVNC/ThntN1v8xsu74WrXw6qCFm0++O8dc4TU+uNs6L5mKIZjJgZp9TB+qsE/mmc65HR Rm5a7CnCsT3l2smShRsK0fDrb+dGZIxqkVitNQcmD0NFmETltTbe3vBUy2jyJs8vqGpP YXrIEGWt069G7oyuXwCOn4nLmp8lFlAViOai5x2NN3byCcDkxnTlP3wHBYTlFViadrPJ Sz1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from; bh=N0Hpl1LpATYP6v1hqDVWRl93tnF8HLTh1iTL34IjQcA=; b=Z3HUO402vlSZEaVCIHcqZ0dFCaTRNGpWbmoQvNmOYesBl53VU+evzI3zxJPksvdgxl A2jGu8vfafaeGY2lT4ugOFmDuOCRlYGIDHdfv0RwCcQjVMLi7s62pnrZ6AuyUbm2ywC8 7sxnc4rQJrqq1t/n2I04p/EnEn32dpyR39NqtTkPmprKLsRy1nRBzHDtUSr66045WLh2 jFXq8WWx+UXAixGIuInNrIJuBt/U21UzxGtBtpxstOqlybttZSgF7RlNUwUCRKPk0OaN fJIP6bBknLHficDuE4Ai1T6lAoDqqVLgHdcdgkSM/zO+yc06Pd5D9R1uOT+ir44HsyQ4 7aOQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of um@mutluit.com designates 82.211.8.197 as permitted sender) smtp.mailfrom=um@mutluit.com Received: from mutluit.com (mutluit.com. [82.211.8.197]) by mx.google.com with ESMTP id x5si8414397wmh.88.2019.05.13.07.24.42 for ; Mon, 13 May 2019 07:24:42 -0700 (PDT) Received-SPF: pass (google.com: domain of um@mutluit.com designates 82.211.8.197 as permitted sender) client-ip=82.211.8.197; Received: from c22-local.mutluit.com (ip4d155212.dynamic.kabel-deutschland.de [77.21.82.18]:58476) by mutluit.com (s2.mutluit.com [82.211.8.197]:25) with ESMTP ([XMail 1.27 ESMTP Server]) id for from ; Mon, 13 May 2019 10:24:41 -0400 From: Uenal Mutlu To: Jens Axboe , Maxime Ripard , Chen-Yu Tsai , linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Uenal Mutlu , linux-sunxi@googlegroups.com, linux-amarula@amarulasolutions.com, Jagan Teki , Pablo Greco , Mark Rutland , Oliver Schinagl , Linus Walleij , Hans de Goede , FUKAUMI Naoki , Andre Przywara , Stefan Monnier Subject: [PATCH v3] drivers: ata: ahci_sunxi: Increased SATA/AHCI DMA TX/RX FIFOs Date: Mon, 13 May 2019 16:24:10 +0200 Message-Id: <20190513142410.9299-1-um@mutluit.com> X-Mailer: git-send-email 2.11.0 X-Patchwork-Bot: notify X-Original-Sender: um@mutluit.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of um@mutluit.com designates 82.211.8.197 as permitted sender) smtp.mailfrom=um@mutluit.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Increasing the SATA/AHCI DMA TX/RX FIFOs (P0DMACR.TXTS and .RXTS, ie. TX_TRANSACTION_SIZE and RX_TRANSACTION_SIZE) from default 0x0 each to 0x3 each, gives a write performance boost of 120 MiB/s to 132 MiB/s from lame 36 MiB/s to 45 MiB/s previously. Read performance is above 200 MiB/s. [tested on SSD using dd bs=4K/8K/12K/16K/20K/24K/32K: peak-perf at 12K] Tested on the SBCs Banana Pi R1 (aka Lamobo R1) and Banana Pi M1 which are based on the Allwinner A20 32bit-SoC (ARMv7-a / arm-linux-gnueabihf). These devices are RaspberryPi-like small devices. This problem of slow SATA write-speed with these small devices lasts for about 7 years now (beginning with the A10 SoC). Many commentators throughout the years wrongly assumed the slow write speed was a hardware limitation. This patch finally solves the problem, which in fact was just a hard-to-find software problem due to lack of SATA/AHCI documentation by the SoC-maker Allwinner Technology. Lists of the affected sunxi and other boards and SoCs with SATA using the ahci_sunxi driver: $ grep -i -e "^&ahci" arch/arm/boot/dts/sun*dts and http://linux-sunxi.org/SATA#Devices_with_SATA_ports See also http://linux-sunxi.org/Category:Devices_with_SATA_port Acked-by: Maxime Ripard Reviewed-by: Hans de Goede Signed-off-by: Uenal Mutlu Tested-by: Chen-Yu Tsai --- v3: * Removed RFC from Subject line, and also the explicit call for RFC in the text, thereby submitting the patch for official merging. v2: * Commented the patch in-place in ahci_sunxi.c * With bs=12K and no conv=... passed to dd, the write performance rises further to 132 MiB/s * Changed MB/s to MiB/s * Posted the story behind the patch: http://lkml.iu.edu/hypermail/linux/kernel/1905.1/03506.html * Posted a dd test script to find optimal bs, and some results: https://bit.ly/2YoOzEM v1: * States bs=4K for dd and a write performance of 120 MiB/s --- drivers/ata/ahci_sunxi.c | 47 +++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 45 insertions(+), 2 deletions(-) diff --git a/drivers/ata/ahci_sunxi.c b/drivers/ata/ahci_sunxi.c index 911710643305..018186a39a69 100644 --- a/drivers/ata/ahci_sunxi.c +++ b/drivers/ata/ahci_sunxi.c @@ -157,8 +157,51 @@ static void ahci_sunxi_start_engine(struct ata_port *ap) void __iomem *port_mmio = ahci_port_base(ap); struct ahci_host_priv *hpriv = ap->host->private_data; - /* Setup DMA before DMA start */ - sunxi_clrsetbits(hpriv->mmio + AHCI_P0DMACR, 0x0000ff00, 0x00004400); + /* Setup DMA before DMA start + * + * NOTE: A similar SoC with SATA/AHCI by Texas Instruments documents + * this Vendor Specific Port (P0DMACR, aka PxDMACR) in its + * User's Guide document (TMS320C674x/OMAP-L1x Processor + * Serial ATA (SATA) Controller, Literature Number: SPRUGJ8C, + * March 2011, Chapter 4.33 Port DMA Control Register (P0DMACR), + * p.68, https://www.ti.com/lit/ug/sprugj8c/sprugj8c.pdf) + * as equivalent to the following struct: + * + * struct AHCI_P0DMACR_t + * { + * unsigned TXTS : 4; + * unsigned RXTS : 4; + * unsigned TXABL : 4; + * unsigned RXABL : 4; + * unsigned Reserved : 16; + * }; + * + * TXTS: Transmit Transaction Size (TX_TRANSACTION_SIZE). + * This field defines the DMA transaction size in DWORDs for + * transmit (system bus read, device write) operation. [...] + * + * RXTS: Receive Transaction Size (RX_TRANSACTION_SIZE). + * This field defines the Port DMA transaction size in DWORDs + * for receive (system bus write, device read) operation. [...] + * + * TXABL: Transmit Burst Limit. + * This field allows software to limit the VBUSP master read + * burst size. [...] + * + * RXABL: Receive Burst Limit. + * Allows software to limit the VBUSP master write burst + * size. [...] + * + * Reserved: Reserved. + * + * + * NOTE: According to the above document, the following alternative + * to the code below could perhaps be a better option + * (or preparation) for possible further improvements later: + * sunxi_clrsetbits(hpriv->mmio + AHCI_P0DMACR, 0x0000ffff, + * 0x00000033); + */ + sunxi_clrsetbits(hpriv->mmio + AHCI_P0DMACR, 0x0000ffff, 0x00004433); /* Start DMA */ sunxi_setbits(port_mmio + PORT_CMD, PORT_CMD_START);