From patchwork Tue Jul 22 10:36:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4219 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 2D2E23F18B for ; Tue, 22 Jul 2025 12:37:19 +0200 (CEST) Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-60c776678edsf6135233a12.1 for ; Tue, 22 Jul 2025 03:37:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1753180639; cv=pass; d=google.com; s=arc-20240605; b=hmt1oTiTmQKjqi+vRfFfxyXLEnq/XI0fN2ocqh3u9E4HuQsbQYZ8V/2SIcmxJVUlju IkmS+6sr59w51NPC8QXPCfajRY2Wx+C1X/77QdrRvx8h7Riv4p5c2c7SjlpSCoHvUhlw Dn0HuhowrE9Z+BT6dvkBajRDOI/y3Ek9hZvfiqRYkbEySb/DITcE+uECJKH6fZUjHalT h23e7IkRnimZPi+AXcA571Gpul94zh8Y2zKEhcNfgSKmC71DXDoxQWAnnnKnM3qgxjhV irBGnCF/yB8BgA4/teRuKM7B+vlE60fZZ32/KdM1+TLs4sGuyYb37lQlPfesoxrNKDh7 r7mg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=4zNlbSj3K5eKjcQ7aJkmtVqvlY5zvsjWBS2L/TCMjRM=; fh=naUGaOvPtTBxgqsBMummTTcUqk8dnhDzaZjo/PuUnIk=; b=Ey3Gl2ne1V4Oxe1f/LFGag/YRGhUZjUO6lRY7n893EN4xl9CZDYLsi7WHYPOfkEh+0 mU0LMY1pBgrqtR5lhzUdtXqszGlhE9jf807EdGukr0G47qN7QnsEDkJysu99AxxeuQw0 LZMcyBlAj0Dd773eTOfEXISfTOMF3DREDMddKDg2hTpu/0TNtMA7OKXXFVwm1iUDBkQa jQ/d+P1BFIhLF6sNJY2avv9s+XvSJ/E0mIbmCL1J7VI1qU7YltguJFK+HZDcBa/irSX9 Tfg+TZwL3jAoRKF1D6batK1tDumbPH3ggwNja6pGi2zNtjt6YPU6xMAPJsd71/UO4AHB rnZA==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Bs3VcqWO; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1753180639; x=1753785439; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=4zNlbSj3K5eKjcQ7aJkmtVqvlY5zvsjWBS2L/TCMjRM=; b=SG+lXMA5riggbnCdc43HU2NyGIi1mKq313HhRerwr8rtVvSvAEAa7l+jVJeYe5ZJ/t V7jBjfA8wE0neos198cJS927szr0gICa1LxFNWb5Dc6G3q11L+h82KrkkyvWXxLUnoJS EQrbzPym8Cyjfb8OVfnTx4YPKaWt33I/jjC44= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753180639; x=1753785439; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4zNlbSj3K5eKjcQ7aJkmtVqvlY5zvsjWBS2L/TCMjRM=; b=UG5pzZLHN58YB3pPI3X0bqKmU5f+uyLpZDCilDbA2VdE2QaGXmbkknGKldURy47WmA xckwzYphK/ZFrU/qOkdOF8K9casMbqdKAhdOUAP9a+/Huy2+IZ+L4k6eAhTTCMi7p5Gu f9xY1TCrhEpLkmiYip7hzlpmEI0GoApDgtdgWwOIaDNfG2VgZt/no/Xq8CJfqWVB6xK4 avTGG/f/yRS6GkLH+af+1PqhgYEpmkJDR67x4r1AIKMDji7W+tExNGcAy2BIeXx8r+Be GrGmgPRdpTcJ4kE5tn93ki60yyFubC0NtRTFvtv6ppMyRa0awLCRt7eBQ84Jd1CnP4Cm C0ng== X-Forwarded-Encrypted: i=2; AJvYcCWCbd3kpQiRVntQx9GXVQ+1GoaEUXwTO+FTrCjhm5YRBx/CcXqJQlahwHgg2V8KRW1B81OcJOmfn2hyuEYP@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Yyh9T5a7ULnI0cqtDTlbTGeuVlxnT0K9TNKjSi838DvsAQwDOIK nfmbIObS9HYhCFu0J4VBa2NU49p0k5YSglbjmbImBq5DP94RRURc+P0dpawi6BOBSPU1og== X-Google-Smtp-Source: AGHT+IGdnMwk60t//lQobuF2P13aF1JM0wskP8XaeSaQuSEG8XKaiRy2M/1TDky/Uw/n/cVb+PDCNg== X-Received: by 2002:a05:6402:84e:b0:612:d5aa:a9e5 with SMTP id 4fb4d7f45d1cf-61346c8a44emr2453580a12.5.1753180638468; Tue, 22 Jul 2025 03:37:18 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=AZMbMZcpuQD5WOgVi6ql5d/MLGACjLm7ro5TE2qKpA4X74nLtw== Received: by 2002:a05:6402:2682:b0:607:2358:a304 with SMTP id 4fb4d7f45d1cf-612d49067e6ls2091254a12.1.-pod-prod-00-eu; Tue, 22 Jul 2025 03:37:16 -0700 (PDT) X-Received: by 2002:a17:907:961b:b0:ae9:cd0a:5827 with SMTP id a640c23a62f3a-af153828db5mr296145066b.20.1753180635895; Tue, 22 Jul 2025 03:37:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1753180635; cv=none; d=google.com; s=arc-20240605; b=CWNDze+F2QEZ6g4T/ibxehhYqBXQxL8+swY7nfUsAVtujMZtHDPvCbmAGKB/jQrWmF 3Uh2SlaI/UrPAJIgegx5Xs+N2V6JtjITWjosytT0YsgTWLc3cRflR8xuoHo7ugnqXnMW 9GkLSqNPxjprQELOzoQK5+epay44yAw9B9XbdM3tIOy+y7bkVVx+rllB6A8x0/hUjVU3 aoWcDA1khQ/r7AM2TpZBpUwK4E2U+gOlaaOE+LMrDujQcEPzT6zGETpx9yETwE67LfdF /7RbodC6qxmM3ub2Qop1GDHrFu4HcieP0sz3plCxEE0exlcyo/qbTVNJE8W3xWpDQc7o uFHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=fOaQOy4NwCzyitlYEvpuiMsUEgnozIVGmGmKLfL9eXI=; fh=AUpCjfKtUfys7cG3pwG6onzZKCwAk3NzwNW/OBNBOi8=; b=X3k6rr/FPwHsFytpUIxIJw4BEhWLCh2IRZA1lAKAJjLLyKDWNJ7ZBjWZY5ZrfXn6i+ 5WaRuspJO59lknqiNqYH8NpO0+8qg12hz0OyTBh0pbaNSZOhh7/nqrJuX0+lKUCV+y24 ldfG04uPCQo+8W/xBs3ofSjse3xjzsHTC5WB2NB2Y1AasqK2chskXV24CZ6yNKtYGMnV 57NM+6g4HPGV1h5Y3+ReQzkM+RXLpPv9rzGts/qkAyPYE7yu92S/O6oWxm5jU30XZgU1 mdYXI0kDoP8f+xuklXnGjuo6Ay97G4fUF1opQYdnh4XqPFnqxHtkUbqx3xRekymsMB6l WnAA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Bs3VcqWO; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-aec6c785677sor425043166b.2.2025.07.22.03.37.15 for (Google Transport Security); Tue, 22 Jul 2025 03:37:15 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGncuACEJoszYZJFY6Ob2VgVEy2RGww8Mik3QqEEXdLaaDmkgFcpwpdiymkuDg0xV onFjzjcbEcTZeik2Rz7zQcYCy+T/2l2nLMcKMD+wO5XBTsP+KVqftq0vs9pnvUmTK8dKdxZKSI8 af3rYCZRRa7XxaDG+DpDNqGDW2IfaN5L3CCN1omeq2f6amBVF5aqpGUXhD0JmV67/+BvMRuO0NB 48ryhSMMQXQeliXoaKhzBE7sRVthyo1KDFeGqjyXUiPpjV504uctYh55e8H1RhnORiEVCz0OSOA FBjL/Txnc/Wot2S5xrd0/Voy407kyIpr5F74EIrQmvmTylOtlDJ7PrLhTsaD4AKNKoZbYf/i0vg ssvVXPMXzJTvCCZSBHVodVEAyTz6+Ew/bOBfAl7IUCPudDyIGjjhXb4w0mTM= X-Received: by 2002:a17:907:2d20:b0:adb:2f9b:e16f with SMTP id a640c23a62f3a-af153339173mr333989466b.16.1753180635127; Tue, 22 Jul 2025 03:37:15 -0700 (PDT) Received: from localhost.localdomain ([2001:b07:6474:ebbf:2bba:d7b0:8e79:c982]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aec6ca310e2sm844568766b.79.2025.07.22.03.37.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jul 2025 03:37:14 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Michael Trimarchi , Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH 1/4] Input: imx6ul_tsc - fix typo in register name Date: Tue, 22 Jul 2025 12:36:15 +0200 Message-ID: <20250722103706.3440777-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250722103706.3440777-1-dario.binacchi@amarulasolutions.com> References: <20250722103706.3440777-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Bs3VcqWO; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Michael Trimarchi Replace 'SETING' with 'SETTING'. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- drivers/input/touchscreen/imx6ul_tsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index 6ac8fa84ed9f..c2c6e50efc54 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -55,7 +55,7 @@ #define ADC_TIMEOUT msecs_to_jiffies(100) /* TSC registers */ -#define REG_TSC_BASIC_SETING 0x00 +#define REG_TSC_BASIC_SETTING 0x00 #define REG_TSC_PRE_CHARGE_TIME 0x10 #define REG_TSC_FLOW_CONTROL 0x20 #define REG_TSC_MEASURE_VALUE 0x30 @@ -192,7 +192,7 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) basic_setting |= tsc->measure_delay_time << 8; basic_setting |= DETECT_4_WIRE_MODE | AUTO_MEASURE; - writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETING); + writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); From patchwork Tue Jul 22 10:36:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4220 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 99D7C3F165 for ; Tue, 22 Jul 2025 12:37:20 +0200 (CEST) Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-adb33457610sf527832266b.3 for ; Tue, 22 Jul 2025 03:37:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1753180640; cv=pass; d=google.com; s=arc-20240605; b=bill4gBycVuhiZ+OXe53Pg1YAqsT0u0P9trYl1sd2hPiLW5AefqOljJDf/O4qYlsaS CqQ+NDaLNyBzPwFub2YPwC+8Y7h/vyJkzjaiYCuxGXlhX+uufekBJeRaFfE6z91dl8Xa Zd9fQIbXhLMpBXt7dq2McAh4cpwq3C8THFcULUO/lT4kRkMys31C3X3KnN+ePY6POzaX m+OOcD07VfDcCFC8KGkm2ed+OrbiP7kGn++3siC8yNoDnyGDHz+iWHFq31xzXDS5Fpme hQPqvGecShNGA9KmGdya3tiNlXj5rYcNj9GeiZjO0pzVaX+vyqcrZRprXu0hopk/iiEd //iA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=PIXC/ArfQmnrQNbmnxsxaVZMl4LHraFo8UBIC6q/P1w=; fh=TMw059+V29n+YAFoAkBTp3YNbZLQrplUVELmlgVa68k=; b=HjLd1vI9FSc1qOHVL9stjT6DtDFaJY6hdUjf8JLISqVlvw6cEacTYgdPoMvyejG+UO fQVRhd4+E+D7bmeDlQo8I8/wctLYyY09LCa4tW3NyVXBsqqEHBrUsd8PsJMcuOx0PJYh va+ej6xZ7QPMiJRi1hUMY+od1KlT+2/sjoWOrvth5d9RZu+4vlHus5yuiz3NH9dyqbUF TAee2p5vvzQKSyQx9889KpFEZYL2e97fltiVbhwPgMh0i+RL4jqc5+5TTHdd7y8peR7n NIpBXR87Wi6t2LIomkjoJ4vH4Or/QitkNwiqM+M+yx+sEAkSNX5CLFeDeumIaK6h6Xhf CquA==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ot7q9YtX; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1753180640; x=1753785440; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=PIXC/ArfQmnrQNbmnxsxaVZMl4LHraFo8UBIC6q/P1w=; b=AQ/DWtiCwvTPLjEVZu1K4prD8R4g7OtFd82IMUEHwNZdoDKUYsBvMDhOAHD1ZHALL5 0tKoFzOA3+7222+0nwb/LtrKAsE9mQepraH/134WMap4yKPQ/HMpwQ6+f1lP4MMRKXAI f1ceGm+T1w+ts1VZZk9js6pmAMCBwT+HyN2Ys= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753180640; x=1753785440; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PIXC/ArfQmnrQNbmnxsxaVZMl4LHraFo8UBIC6q/P1w=; b=tEAhh+OyeVk8kIdBOF09BHdR7N/kgMsfF5OYJ29bOLGv2IVxL+q2pd7XqGm4Y7GPl5 WHgXxRjPkN5/a7rRwjVJAgRxllqBLXNgpDRqTQiXysEOJn4bvbaPQESnTlE2pIUV+5a4 dNcIz0JjeoloXmcIeXbsWTR1lm2WtpAfs3PzKtRNZ6SiHJXbKWQpgO4jcUILQamZ0Uh6 KxfI67CwfuK3gIfvOZWy75+vEj9T/3OZv+PQ/n/JhJzmu5nOxqKtf9oG+GX2njT/0gRE ljrjNbByAZqHF4a1NcDGkdFKbKzTNiOPoHNPEaCCkur2/FrSa0GjACiMaz/3S056eDU/ BCSw== X-Forwarded-Encrypted: i=2; AJvYcCVepZ00htr9dQUq7lFFzVZ4fjU5Tr6sVj3EZQGV8ajCz56z4f/4hEtZ28Bpz/SkvEeS8d5wpbDAZWpXJerL@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YyR6oux0vdj+LBFfoIX2vsf3zWhWKsmVm9ds839IJxZXnwRP7Ve QLoyO2+V1CBKjLoqMotJ/4JgVDsjgLCIEI5XU6a++0nI72QQIDaA3f3+03bPaGwUJPtnUA== X-Google-Smtp-Source: AGHT+IFVNM6M2cW/IGgABK401lJuCWbnR7Zya9yJTy2fj6oZvbP+wTPPuOTElw+8S7uJMgUKcrCTbA== X-Received: by 2002:a17:907:983:b0:ae0:54b9:dc17 with SMTP id a640c23a62f3a-ae9cdd8605amr2195181766b.11.1753180639913; Tue, 22 Jul 2025 03:37:19 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=AZMbMZdMH76vQj7dAE+OJAmbgT0mtmTanMwksADzD6ZvG8HReQ== Received: by 2002:a05:6402:2109:b0:60c:50c2:e48b with SMTP id 4fb4d7f45d1cf-612a0a3c40fls4657592a12.1.-pod-prod-08-eu; Tue, 22 Jul 2025 03:37:17 -0700 (PDT) X-Received: by 2002:a17:907:f1de:b0:ae0:d4b1:b5f0 with SMTP id a640c23a62f3a-ae9ce0d6011mr2230510366b.35.1753180637181; Tue, 22 Jul 2025 03:37:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1753180637; cv=none; d=google.com; s=arc-20240605; b=J9cPRMje27lF00qpl1zNxK6dHmJfJl9Ku4kNpB0odQ2Z/8poXcqXR1tsYkkzXfYqgU MQ75fa/foKX895w8Ql2xNV7uBi92dk/Hg5y6OPzfIyF4ADzGrG4gzdiBf6MU04ilPGLs 7y225GbTj4EoyR0hAYKtxJHPpdbaZi6B2upeCesQlFKYMeQmv7zzsZnunuExpp0SygJc SfvdHCjcbdXs9SboNJttXYyB2i7rOl4KrQYaW8PuX/cRt7NBXHuW0HvQAhZErMmWMwqm BqMegJDdCBA3kbhhZNmFOFICzy6VFgi2Lp0deEMkV9mWvZnAlk1w7iBRqjWFut1JkAWk Ym+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=GtY6xQODciaFQXT13QEjMt2xFfxEtt0WYueluTMBhAE=; fh=euIalU/jf6N5x2NNEskqvzHuFozMvE/8fvBnhWHdeuM=; b=kgX3nTqHOybnZ3UD+zGExSiIxv5jGZYltH9PDUAlt+YNYcV+iTrjNsJGZ5pMprPnBn FpgLOR7A7WMy1/WZkJQbpRdX5soIHC05pfWsHmT1mGO9W/ZwzRe39/ELNiz8zpwhAeno TpfuQr6DNAT+tVs9E4PfTHPxZ/zOsmfAFXTLwrFtLKtWr3r4oHIjvlT5VLrWKVM4RbmL UzBeGTqBrc+TRWeN6cXU0gdS3kOiuKWEQVlcoywz6/xunzFs8dxZFrqm53wJcc3GNQU0 42CH34VBahUwFZOEuKW73dm3lu1YYjpnjSM/Wnan6lNkLY01sYKwY1dAxffrt+zsgxab Zb2w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ot7q9YtX; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-af26fade230sor3115166b.0.2025.07.22.03.37.17 for (Google Transport Security); Tue, 22 Jul 2025 03:37:17 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGncvAjVRA3sK5myJemjg9VMNl/UJan7NUHqMrJ/b+sP2e4fAU50zgx1zI5WyoS5I kiJIi9ju89YkWp11gcymIRcQqOYMDY+pXWCrdugle3Mwmg1rjb89haYfqtFksYFtkQJ47PPgKXD 9ORLEB/tHS7K+g/JRnjxDpIRjAvGJq3X8KVB0GMJ+MtmEU8sg/gCzOfVBQPSVtyLrN9gmz6uG6b 1VHXNDuU12vIr9HASa1Ch7hWgpp2MlKsI8mcr43BDmKIghtBRSkl0RhzHzD+6GQtSNor+RkQWNx 5S5HJDsPAKzpKsFi6G50Wtsr6PfVnAY2gxUbc6cUgo8OgwmbEx0VZ3jJlSEGXSrO2M8d67+y0/p vUTwRiR2jFp1XtMxGYOYylqFwlW+YUOnyH4q4KhgrYk58EtAV+GSLWLPZg/I= X-Received: by 2002:a17:906:9fc9:b0:ae3:cd73:e95a with SMTP id a640c23a62f3a-ae9ce0d2aedmr2549138266b.36.1753180636628; Tue, 22 Jul 2025 03:37:16 -0700 (PDT) Received: from localhost.localdomain ([2001:b07:6474:ebbf:2bba:d7b0:8e79:c982]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aec6ca310e2sm844568766b.79.2025.07.22.03.37.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jul 2025 03:37:16 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Conor Dooley , Dmitry Torokhov , Fabio Estevam , Haibo Chen , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH 2/4] dt-bindings: input: touchscreen: fsl,imx6ul-tsc: add fsl,glitch-threshold Date: Tue, 22 Jul 2025 12:36:16 +0200 Message-ID: <20250722103706.3440777-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250722103706.3440777-1-dario.binacchi@amarulasolutions.com> References: <20250722103706.3440777-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ot7q9YtX; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Add support for glitch threshold configuration. A detected signal is valid only if it lasts longer than the set threshold; otherwise, it is regarded as a glitch. Signed-off-by: Dario Binacchi --- .../input/touchscreen/fsl,imx6ul-tsc.yaml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml index 678756ad0f92..2fee2940213f 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml @@ -62,6 +62,23 @@ properties: description: Number of data samples which are averaged for each read. enum: [ 1, 4, 8, 16, 32 ] + fsl,glitch-threshold: + $ref: /schemas/types.yaml#/definitions/uint32 + default: 0 + enum: [ 0, 1, 2, 3 ] + description: | + Indicates the glitch threshold. The threshold is defined by number + of clock cycles. A detect signal is only valid if it is exist longer + than threshold; otherwise, it is regarded as a glitch. + 0: Normal function: 8191 clock cycles + Low power mode: 9 clock cycles + 1: Normal function: 4095 clock cycles + Low power mode: 7 clock cycles + 2: Normal function: 2047 clock cycles + Low power mode: 5 clock cycles + 3: Normal function: 1023 clock cycles + Low power mode: 3 clock cycles + required: - compatible - reg @@ -94,4 +111,5 @@ examples: measure-delay-time = <0xfff>; pre-charge-time = <0xffff>; touchscreen-average-samples = <32>; + fsl,glitch-threshold = <2>; }; From patchwork Tue Jul 22 10:36:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4221 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id A1FDB3F18B for ; Tue, 22 Jul 2025 12:37:21 +0200 (CEST) Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-606ae00e924sf564981a12.2 for ; Tue, 22 Jul 2025 03:37:21 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1753180641; cv=pass; d=google.com; s=arc-20240605; b=Q0SHZre9O5EdJ9dwHEvf8PixxxWF+fm+vxH7p/jgvS82JcCD8CE/hTnL8I2fK1+nQH u+mU52dawpCtcol4TlW1DXtPpPB/uMA9YJUfxkx2JONjONYsIwHFEHgof2ZeY/ArF3Sr uIbo1b0uhroxzUP2dQSBIdNG4C5bYDomKIUhjFrUxbGnYhEhQOsqe/JbOlVVAbVlv3tF H6/SIeNmlg7L3ZIPcBS5ngf9egFjBNzuUfL07h413LepL0oBg+oBujQONEI85S0q810H gt13KjWMFO0s0UYuJWVQN6zGisl9rEJs07hi5LU8q5PoAuhlnIOlpgFV+shkfIgkvA03 T6mw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=caRuVMvZU4mj559QiA5FDIYylRJectxLC7J/y8bOFEo=; fh=wWaEzdzul6cTzCAnLCNbel5cfik8DBpAuG6CJwVPnxI=; b=QilJW4JAIjF+v40/VLr5nLrgEGCl5lFucgYNEY0hscYo8e+zBRNMQOmLhAGTeXi7HY m+5dKdd7J21/syzAQkZVgNqzbo3Uu1liQAUDPkZuytzRVC7j/VVRWzXIFBJeO0DIk271 17A+K2wg6mzokzMXlNoUj0VxZrDmAFQP81rIUE2dhvu7JoKxArjySnU+yzz+536Msto2 02YX4Pg1ZyQADak2LBV/4ehE1euAFDK4bNAEiLQ7YBgIOuMB6sUr5A4bCJvI/H1ArwSt WOqanT0ydZh+TCK+Zmmngphwu/59wx98R/8u/x29/Ixl0gCmsI/Aj5aLUOMN0vL31m3s 3/Tg==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=MYUKn22w; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1753180641; x=1753785441; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=caRuVMvZU4mj559QiA5FDIYylRJectxLC7J/y8bOFEo=; b=rIs6eOB2/polMKDes9sa8VHKHbY9Z5C1OeuZqFbnW860OR+m7GicXCKjA3+eZKNKTS 7UoJEbKoLp19g635tnKr+zx+7dz6oY8DFn41U/NJ7sFwEgGB0CC07BiS74inYCsYefiI AjJahzq8THOyFozk4+qRP1lw7X2W19bXmuKpk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753180641; x=1753785441; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=caRuVMvZU4mj559QiA5FDIYylRJectxLC7J/y8bOFEo=; b=dLYyapBUuEzuXK/iWqOcSaycgsCDaK22dukNVjaihi4Zl015sHj8dbWja6c9lcgDHb nDhadah2qrOcXhhkt8A+BLEzTYDDl6+IyLoX6d5AG/FQmJh1Frd8xqJukZ4u5jcgYS84 U1YRRt0Kc5LHTHuZWhu3RM0ZK7W6Kv5NwubcHBDDLi+nPSo/ZYTjksXiT7wkR33tqDCt Y8glWXmusVT7iPqP+mB/4JmlCk9DVZzhI0Yn/qz1sRQT+X4ltxpiNqo9jx58qZhWQMSZ RLOPVxLb3cCfQY9E+yDArnr48fG/LsGrGSpLeJvKkSUNhJ5XIccLqV9wH5QIQTzYAF5B 6p4g== X-Forwarded-Encrypted: i=2; AJvYcCVhES6l2rii0pAFdeo9LilJICt+J81Jla8ULoeUsv1kfJkTOFkcQbwKTqUpI9B6/nNP6fzYtZgBjo+MGcfJ@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YyuqVvtw5TNGDcnjZZZV6xqUbWqp/yd5VZPaY7RJrUznfWG0gDo QWjbVl0lGU/DW6vpP9ErIS/XqphtsohSRjlfskwsI6ooMZt+G90ZLcez5SmzTpnv8WTlAg== X-Google-Smtp-Source: AGHT+IGsLBr6Oj77mlcRynFLhJjRKV3v7cn1p6dFAax+lNlsjPTF2VAikgLThlof8D3v4y5gCASHxg== X-Received: by 2002:a05:6402:4404:b0:612:c73b:17bc with SMTP id 4fb4d7f45d1cf-612c73b19fbmr5674780a12.3.1753180641100; Tue, 22 Jul 2025 03:37:21 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=AZMbMZdsWMx820FPu3gjhXgtXVHUK7ntex/IQSUySkTGfxWVBQ== Received: by 2002:a05:6402:13ca:b0:602:104a:c090 with SMTP id 4fb4d7f45d1cf-6129fe4b915ls4198584a12.0.-pod-prod-05-eu; Tue, 22 Jul 2025 03:37:18 -0700 (PDT) X-Received: by 2002:a17:907:720d:b0:ae3:c767:da11 with SMTP id a640c23a62f3a-ae9ce17e845mr2376706266b.50.1753180638627; Tue, 22 Jul 2025 03:37:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1753180638; cv=none; d=google.com; s=arc-20240605; b=cA/TIThbOQOgELM1R+/7nM7Q6C2iaRl7yQ/pR3n8yB+1D7Wef1VK5z/DyX6C5JRMYB fopQv2GSqTyJUbSKY0GKg66jG5LGKvFAiDDgbgolyGPvYPaAaXFbFYVIPNdMiLDRVe/j KTntRBpTFLhhl/5jFBVCMYCMxFyVFtUu9hG/QxEFx4eU1+/4fOmI0hDzybv8pWVxvEfI BuHtn0UtTq4IAV9AHshfvjaa2cqsi2LsVW5a2TaZzF3Lm12Usp/0EyIT/V+8SbqgSeow kgdTUtz4g1fQkwOIxiCj4YEQfEOSwrw/zMpnyEGIbsDPTw/PiSaYXEAv//RavdfFjFMB HM9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=B0R5rRW0Dwv8g9EBflVK6bi6TKX/71M89TmluJsUG60=; fh=4gXLHhtG5blgxpWML+oiv0GiMs5uzMuOuNd/RJVWDWw=; b=J034O9Jrf76p6sCSTzwwXO5YyEAwybNjd7b1vI4NtKW8fElVfPCCSKx3yH7PXgFAzM yfeuCkninSl7jprVhLIgbNdCKlH1+n+HrLxO3s0z1zDzCpyIr4hgEpO5lS+oZLlD8Gfk AzkzUihJqYrPlJNY7B56qYtQK9TGSduhD0rLeCoyc9+EUVP+umEsENpegDyn7iWPgz5q vc6WiIo3Dv9EFSCk2JnDyx9Sw9EqmJItqngZv35aOKO3LI9C57XOCKRvNouEKfT6RFcD xJ217z8fZ7HeHifGYEUXSCC9Okny1XTkMeufLKwX0QY5rYTNpQtnPJj20saONhx0vCoI b3Og==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=MYUKn22w; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-af10243b6bbsor113528166b.3.2025.07.22.03.37.18 for (Google Transport Security); Tue, 22 Jul 2025 03:37:18 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGncsdH1gu/J19CMy2I6jYzMuidk52cCy1nbcRg29G2uGxrtKVUKGhQtYBW783PVL fdsFpBhfCvGP3E5c6Xv/aN9Eh3KYFftQGSX8e92K5uCj7dEQPyO41KbsIzJO3/uYxjluNwPohfr iQeRRumozuuIxsy/9nVRqASD0VPZVlDbztDLk6kr/p3P7wXr93DkWCdYjVh6MII3c+iUe3JtzqO TCj5axzoYeS5oVXKTwd+RGjRDVFxBozZZAxGOaREhNKlBQtkqpX91/9MrBMcg5CG0AkJTgsOs8A WfJdkcKqBMI5611UV78ijN2hOID6XmSGEnJZW/u53oXekevkAB/GnwEkOfkFLz2jWm8gyjA4yt+ vztCRBxLe5x5AiJZQYvFGTvvlkLpWR69PfI4hHLw8J7qphPI6A2rW7PBR0Ng= X-Received: by 2002:a17:907:cb81:b0:ae9:c494:1ade with SMTP id a640c23a62f3a-ae9ce199db0mr2520430366b.53.1753180638060; Tue, 22 Jul 2025 03:37:18 -0700 (PDT) Received: from localhost.localdomain ([2001:b07:6474:ebbf:2bba:d7b0:8e79:c982]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aec6ca310e2sm844568766b.79.2025.07.22.03.37.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jul 2025 03:37:17 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH 3/4] Input: imx6ul_tsc - set glitch threshold by DTS property Date: Tue, 22 Jul 2025 12:36:17 +0200 Message-ID: <20250722103706.3440777-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250722103706.3440777-1-dario.binacchi@amarulasolutions.com> References: <20250722103706.3440777-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=MYUKn22w; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Set the glitch threshold previously hardcoded in the driver. The change is backward compatible. Signed-off-by: Dario Binacchi --- drivers/input/touchscreen/imx6ul_tsc.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index c2c6e50efc54..a6066643bd48 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -74,7 +75,8 @@ #define MEASURE_INT_EN 0x1 #define MEASURE_SIG_EN 0x1 #define VALID_SIG_EN (0x1 << 8) -#define DE_GLITCH_2 (0x2 << 29) +#define DE_GLITCH_MASK GENMASK(30, 29) +#define DE_GLITCH_DEF 0x02 #define START_SENSE (0x1 << 12) #define TSC_DISABLE (0x1 << 16) #define DETECT_MODE 0x2 @@ -92,6 +94,7 @@ struct imx6ul_tsc { u32 pre_charge_time; bool average_enable; u32 average_select; + u32 de_glitch; struct completion completion; }; @@ -188,13 +191,15 @@ static void imx6ul_tsc_channel_config(struct imx6ul_tsc *tsc) static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) { u32 basic_setting = 0; + u32 debug_mode2; u32 start; basic_setting |= tsc->measure_delay_time << 8; basic_setting |= DETECT_4_WIRE_MODE | AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); - writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); + debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, tsc->de_glitch); + writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); writel(MEASURE_INT_EN, tsc->tsc_regs + REG_TSC_INT_EN); @@ -501,6 +506,17 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) return -EINVAL; } + err = of_property_read_u32(np, "fsl,glitch-threshold", &tsc->de_glitch); + if (err) + tsc->de_glitch = DE_GLITCH_DEF; + + if (tsc->de_glitch > FIELD_MAX(DE_GLITCH_MASK)) { + dev_err(&pdev->dev, + "fsl,glitch-threshold (%u) must be less or equal to %lu\n", + tsc->de_glitch, FIELD_MAX(DE_GLITCH_MASK)); + return -EINVAL; + } + err = input_register_device(tsc->input); if (err) { dev_err(&pdev->dev, From patchwork Tue Jul 22 10:36:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4222 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id D159E3F165 for ; Tue, 22 Jul 2025 12:37:23 +0200 (CEST) Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-606ee65164fsf5716424a12.1 for ; Tue, 22 Jul 2025 03:37:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1753180643; cv=pass; d=google.com; s=arc-20240605; b=Z5v8RuvS8UvkfSkAAyWqkrsjYrI72mdavJ+loJgMJfALwypgwKnTRv0BuXk1nt1WD3 V+26JCVxqUZpk9QFf2l9CgnhJBLHLz1tENAGoVBTAxy3ABd1tiha5e3VLqVCR05OoY97 SYqCl4PEnK00SVvQ3SUkXLn0rhnJptaioWXvhVvzbMy9HEpnV/dl92V7UpgHz1FNSrUt I1TVUZw9Os0e7xEZt/fVpH83OtjhwgBUDW/mNkBvM4pnwy1fOEIT2Cok02Dar1f0nsen R7vYEiQyBl0OJ9yC2fPjnfzwV4M8kelT8ndJyJhxOXFeUZmM7IkqtahUBpZ0OyPMnyNW dmTQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=NwIYOPx+SivDsZ+fJEZfMbkbJ4KKzXEO3esPBItUo1E=; fh=esN95S88be7IJFq5A0dB3/mtpZJA3m0leKRzmW7Jf2Y=; b=k7Qd8egW/Eme7a3scjZ75m+php8BUPK9rZPZc/Q6wzsKCsbeWxAy+iNYdpGupkQZ3q vtfMceAjG8HjFvrEUs4JKuxxB06xWrKkpP06mZcbjh6PrcTlOKC3Maaj87UHG36HZGye 2TxhZEWFGRv5iIvcEEWYvzDwcNtEiQVCWMhWEc/4UMzIveqV3zstXq3FfoSdrHG+xWb0 MQdd3lTPyx5DVHMzRfWPHE3ugARF4TEbA14xtcrKVZqM2VA5OCu9JWIL6mPx0n2UaM1m SYQatW2dDwEj0J56iN5m5UgetnMll121X8jJzNQSJdZNPQJUIu55ROYUztwr9wnkjAMh zC7A==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=GgXbR74x; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1753180643; x=1753785443; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=NwIYOPx+SivDsZ+fJEZfMbkbJ4KKzXEO3esPBItUo1E=; b=hSFHgSZl81ioRa37fLFdGtlYyC7PeT7Pajy4wtib/LkWW2M4QOIrkA2BWi5dqBwb9w +vfP19ierAfzSB5+FSLzPH36NIxCxbAvYqnwCmIDZLQyL+3ur0go7rggk31VP8i4Yh0N jNq9eRSXhZQPZXMmYRnPS2x2iHxUvbVXAOjps= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753180643; x=1753785443; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NwIYOPx+SivDsZ+fJEZfMbkbJ4KKzXEO3esPBItUo1E=; b=DuR9/+b+d8fnfjCPQUfUoc8Us+poEsd1DvLZeO2NBDxggoAOunwr0iFVIiJTG2ES5P FbzzHKOvGWEDYwxaSn6d9LJyTThE5PhGQJRYu7OiminmTDlhLJeFPrjWyJB0LIJfenqp YuBd6UjGQgN7AS18NhKmEaXuOyiXxmrcKkZpLa7AgbFizihBt2q7jYtVIVT8KnBeEVNX pjLUmYluphBE0uqkkfeSyxpJxt1mwszre2RsVhq3oNBSFU+oO3fPR3QRNQh0qsbPP9K4 p4RV72Y9PHyy7Hha5p3crWph7eLyTIvP0L5wJ4ZIowC7w17mvGyonB39OgY+s9V66u+q tS9w== X-Forwarded-Encrypted: i=2; AJvYcCVBuBaoTySKuR0p2dbfLOFHpAfoQ/BF98jF7v2/t08Rv9YrwvwHyTcq4Ovc58pZD2draEhtXREjF5smdhJc@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YzfKCtDaMslEs2x3NdGYiKmuHouFtn2zlaUcvn2X/sUnt85koZk sOiAoEG39zNFYUAHaz2TDFaCo+qABgXgtAHO3LB7yq3mBmnyTW0njV1tK4SVDGrpGWLXtw== X-Google-Smtp-Source: AGHT+IGDWyenAar4srVO0H7JVqaFNCMdoZrEQCxeTSnRnAAde8hKN3I/e4q48+UNwH1giY8mQJNV5Q== X-Received: by 2002:a05:6402:2350:b0:5e6:e842:f9d2 with SMTP id 4fb4d7f45d1cf-612c74072c5mr12492930a12.29.1753180642867; Tue, 22 Jul 2025 03:37:22 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=AZMbMZf9uOcjbEDDtwcFeieB4w8ZlMtw6WaEE8Dow6lvSleI/g== Received: by 2002:a05:6402:2344:b0:60c:397b:eeae with SMTP id 4fb4d7f45d1cf-612a02cfb87ls4542393a12.0.-pod-prod-04-eu; Tue, 22 Jul 2025 03:37:20 -0700 (PDT) X-Received: by 2002:a17:906:6a0e:b0:ae0:c497:c5ca with SMTP id a640c23a62f3a-aec6a492febmr1547988666b.3.1753180640106; Tue, 22 Jul 2025 03:37:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1753180640; cv=none; d=google.com; s=arc-20240605; b=fjTQ8f6zUIK88ZxtnUBq0oy6NZ6/tPH//s1eHb6qCuPWekGDFP/CnZka1hcbrrNrqX s9DEC6pf/I6QWoJPq1fELaeioqb69PCM7mODcIqsbA16fgtGu6pl6nFgXKxJbFHkCnAJ 2Bnuy8iKNn3Drdvqcb89dgEIdKuCxAHy2V1WgZLGNi0z+4eroll66RFbXmmQ6A83xYJi haqrQp2HrQm9dmHct5nVmdCVVDfJdGopbEYRYuWHcNhyhKZIWHlO6/HkaS68F8UVADnx sxbJdaoaWTaK5AfClahjP2UdBc/nBose0ayLLVSxQtdfuBZvQezOMzRb3RFrEXu2SArF 3t3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=2oVD/JfoNNaDmsm+Xmi5oDSaNjfSX3YkjZgxJuhnDRo=; fh=4gXLHhtG5blgxpWML+oiv0GiMs5uzMuOuNd/RJVWDWw=; b=Pr+QuypTEYHytLA4lxMeEOthoxLy/yojMYWM63UclUP6SJXIVumhana+gN//efN/YY CPG5rnz2Hc9vSbwsIdsMuAp4Lus8oBtLKM4xtQqPD5c5uKuEY4o0bo2vqgiOkFI/9Wm1 6eCNorpp7qSvFu6Ay1uAH6sLbOE3dfniubc5bDjnk8hmMpuLZect+G/1+gVu4+katqVy AR2QkPjfoVqpqmR9D5cQsDdG2C4hQF1g2rG5OllyMcQXj6ofsGlYFVGXCj248zGS1itX lT50eKSmvtZzuTLT6azKOWqj7nRZ4c+UqYaQiulOPUz8NoeJAbZfDQv1WaAxsLRPZXSw DJ5g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=GgXbR74x; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-af188164a09sor98230266b.10.2025.07.22.03.37.20 for (Google Transport Security); Tue, 22 Jul 2025 03:37:20 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGncshBeOLMFWQSTtF9WYI84drLVJ5qz7f+MyfWn8pusnunRNrHy5eEtJSjCOVmAh 8h22DRA0hxyhAE1E0ROgQqQwgIQKQa283EDma8vhPaUUJLvb93sniFAs/79BXwswO/XWXrydfhR h4JXdtJzQxBcjE+tOS+vT82txa+pwGVAKaSfwoL+ZgqDQ07qe575qy7pBanzi3M2cfIulpUGWQ1 mFYu4QL7EXoP8jKGa0EKcLig6dvcc3WcJxZhzgmE6R6hMpSIJql3djMBqAvEskoce6+771puLPe x98QLqNf/0QbivmaFnjb0CmR6w54383Gc3QaZF9YqaHCU1GTB4w3w2NIuVRhE4UbUVYNu+r9o2M 6yMfQ/+6AOCjPD2/7FXXQ0GH1UhHH5RG1qqb7GMYF2E3kbR+qpDxM3in4m84= X-Received: by 2002:a17:907:3e93:b0:ae3:d026:36cd with SMTP id a640c23a62f3a-aec6a6235eemr1682182966b.42.1753180639487; Tue, 22 Jul 2025 03:37:19 -0700 (PDT) Received: from localhost.localdomain ([2001:b07:6474:ebbf:2bba:d7b0:8e79:c982]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aec6ca310e2sm844568766b.79.2025.07.22.03.37.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jul 2025 03:37:19 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH 4/4] Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros Date: Tue, 22 Jul 2025 12:36:18 +0200 Message-ID: <20250722103706.3440777-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250722103706.3440777-1-dario.binacchi@amarulasolutions.com> References: <20250722103706.3440777-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=GgXbR74x; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Replace opencoded masking and shifting, with BIT(), GENMASK(), FIELD_GET() and FIELD_PREP() macros. Signed-off-by: Dario Binacchi --- drivers/input/touchscreen/imx6ul_tsc.c | 88 ++++++++++++++------------ 1 file changed, 48 insertions(+), 40 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index a6066643bd48..e74999c5e22f 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -21,25 +21,23 @@ #include /* ADC configuration registers field define */ -#define ADC_AIEN (0x1 << 7) +#define ADC_AIEN BIT(7) +#define ADC_ADCH_MASK GENMASK(4, 0) #define ADC_CONV_DISABLE 0x1F -#define ADC_AVGE (0x1 << 5) -#define ADC_CAL (0x1 << 7) -#define ADC_CALF 0x2 -#define ADC_12BIT_MODE (0x2 << 2) -#define ADC_CONV_MODE_MASK (0x3 << 2) +#define ADC_AVGE BIT(5) +#define ADC_CAL BIT(7) +#define ADC_CALF BIT(1) +#define ADC_CONV_MODE_MASK GENMASK(3, 2) +#define ADC_12BIT_MODE 0x2 #define ADC_IPG_CLK 0x00 -#define ADC_INPUT_CLK_MASK 0x3 -#define ADC_CLK_DIV_8 (0x03 << 5) -#define ADC_CLK_DIV_MASK (0x3 << 5) -#define ADC_SHORT_SAMPLE_MODE (0x0 << 4) -#define ADC_SAMPLE_MODE_MASK (0x1 << 4) -#define ADC_HARDWARE_TRIGGER (0x1 << 13) -#define ADC_AVGS_SHIFT 14 -#define ADC_AVGS_MASK (0x3 << 14) +#define ADC_INPUT_CLK_MASK GENMASK(1, 0) +#define ADC_CLK_DIV_8 0x03 +#define ADC_CLK_DIV_MASK GENMASK(6, 5) +#define ADC_SAMPLE_MODE BIT(4) +#define ADC_HARDWARE_TRIGGER BIT(13) +#define ADC_AVGS_MASK GENMASK(15, 14) #define SELECT_CHANNEL_4 0x04 #define SELECT_CHANNEL_1 0x01 -#define DISABLE_CONVERSION_INT (0x0 << 7) /* ADC registers */ #define REG_ADC_HC0 0x00 @@ -66,20 +64,26 @@ #define REG_TSC_DEBUG_MODE 0x70 #define REG_TSC_DEBUG_MODE2 0x80 +/* TSC_MEASURE_VALUE register field define */ +#define X_VALUE_MASK GENMASK(27, 16) +#define Y_VALUE_MASK GENMASK(11, 0) + /* TSC configuration registers field define */ -#define DETECT_4_WIRE_MODE (0x0 << 4) -#define AUTO_MEASURE 0x1 -#define MEASURE_SIGNAL 0x1 -#define DETECT_SIGNAL (0x1 << 4) -#define VALID_SIGNAL (0x1 << 8) -#define MEASURE_INT_EN 0x1 -#define MEASURE_SIG_EN 0x1 -#define VALID_SIG_EN (0x1 << 8) +#define MEASURE_DELAY_TIME_MASK GENMASK(31, 8) +#define DETECT_5_WIRE_MODE BIT(4) +#define AUTO_MEASURE BIT(0) +#define MEASURE_SIGNAL BIT(0) +#define DETECT_SIGNAL BIT(4) +#define VALID_SIGNAL BIT(8) +#define MEASURE_INT_EN BIT(0) +#define MEASURE_SIG_EN BIT(0) +#define VALID_SIG_EN BIT(8) #define DE_GLITCH_MASK GENMASK(30, 29) #define DE_GLITCH_DEF 0x02 -#define START_SENSE (0x1 << 12) -#define TSC_DISABLE (0x1 << 16) +#define START_SENSE BIT(12) +#define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 +#define STATE_MACHINE_MASK GENMASK(22, 20) struct imx6ul_tsc { struct device *dev; @@ -115,19 +119,20 @@ static int imx6ul_adc_init(struct imx6ul_tsc *tsc) adc_cfg = readl(tsc->adc_regs + REG_ADC_CFG); adc_cfg &= ~(ADC_CONV_MODE_MASK | ADC_INPUT_CLK_MASK); - adc_cfg |= ADC_12BIT_MODE | ADC_IPG_CLK; - adc_cfg &= ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE_MASK); - adc_cfg |= ADC_CLK_DIV_8 | ADC_SHORT_SAMPLE_MODE; + adc_cfg |= FIELD_PREP(ADC_CONV_MODE_MASK, ADC_12BIT_MODE) | + FIELD_PREP(ADC_INPUT_CLK_MASK, ADC_IPG_CLK); + adc_cfg &= ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE); + adc_cfg |= FIELD_PREP(ADC_CLK_DIV_MASK, ADC_CLK_DIV_8); if (tsc->average_enable) { adc_cfg &= ~ADC_AVGS_MASK; - adc_cfg |= (tsc->average_select) << ADC_AVGS_SHIFT; + adc_cfg |= FIELD_PREP(ADC_AVGS_MASK, tsc->average_select); } adc_cfg &= ~ADC_HARDWARE_TRIGGER; writel(adc_cfg, tsc->adc_regs + REG_ADC_CFG); /* enable calibration interrupt */ adc_hc |= ADC_AIEN; - adc_hc |= ADC_CONV_DISABLE; + adc_hc |= FIELD_PREP(ADC_ADCH_MASK, ADC_CONV_DISABLE); writel(adc_hc, tsc->adc_regs + REG_ADC_HC0); /* start ADC calibration */ @@ -167,19 +172,21 @@ static void imx6ul_tsc_channel_config(struct imx6ul_tsc *tsc) { u32 adc_hc0, adc_hc1, adc_hc2, adc_hc3, adc_hc4; - adc_hc0 = DISABLE_CONVERSION_INT; + adc_hc0 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc0, tsc->adc_regs + REG_ADC_HC0); - adc_hc1 = DISABLE_CONVERSION_INT | SELECT_CHANNEL_4; + adc_hc1 = FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_4); writel(adc_hc1, tsc->adc_regs + REG_ADC_HC1); - adc_hc2 = DISABLE_CONVERSION_INT; + adc_hc2 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc2, tsc->adc_regs + REG_ADC_HC2); - adc_hc3 = DISABLE_CONVERSION_INT | SELECT_CHANNEL_1; + adc_hc3 = FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_1); writel(adc_hc3, tsc->adc_regs + REG_ADC_HC3); - adc_hc4 = DISABLE_CONVERSION_INT; + adc_hc4 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc4, tsc->adc_regs + REG_ADC_HC4); } @@ -194,8 +201,9 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) u32 debug_mode2; u32 start; - basic_setting |= tsc->measure_delay_time << 8; - basic_setting |= DETECT_4_WIRE_MODE | AUTO_MEASURE; + basic_setting |= FIELD_PREP(MEASURE_DELAY_TIME_MASK, + tsc->measure_delay_time); + basic_setting |= AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, tsc->de_glitch); @@ -255,7 +263,7 @@ static bool tsc_wait_detect_mode(struct imx6ul_tsc *tsc) usleep_range(200, 400); debug_mode2 = readl(tsc->tsc_regs + REG_TSC_DEBUG_MODE2); - state_machine = (debug_mode2 >> 20) & 0x7; + state_machine = FIELD_GET(STATE_MACHINE_MASK, debug_mode2); } while (state_machine != DETECT_MODE); usleep_range(200, 400); @@ -283,8 +291,8 @@ static irqreturn_t tsc_irq_fn(int irq, void *dev_id) if (status & MEASURE_SIGNAL) { value = readl(tsc->tsc_regs + REG_TSC_MEASURE_VALUE); - x = (value >> 16) & 0x0fff; - y = value & 0x0fff; + x = FIELD_GET(X_VALUE_MASK, value); + y = FIELD_GET(Y_VALUE_MASK, value); /* * In detect mode, we can get the xnur gpio value,