| Message ID | 20200722190949.215656-1-jagan@amarulasolutions.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-amarula+bncBD7MFH7A7EEBBCM64L4AKGQEJZYNHVI@amarulasolutions.com> X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 096FD3F03F for <linux-amarula@patchwork.amarulasolutions.com>; Wed, 22 Jul 2020 21:10:04 +0200 (CEST) Received: by mail-pg1-f197.google.com with SMTP id e127sf2352199pgc.2 for <linux-amarula@patchwork.amarulasolutions.com>; Wed, 22 Jul 2020 12:10:03 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1595445002; cv=pass; d=google.com; s=arc-20160816; b=FIzCMbFv67Z44qoadkCNpjMkaQH9rfbO6YnurTFkRGhXnMpcLbiqHBVG4RiRSgXUFV Ic2swp5d+bAhEObIoCDg39IMBWeojUSN9++PjcPBKPy4DFOP8741qFDeGBKn0F/gfvFF B3UdxEyCgJ/ACzkzLuTk1XVL/5J7EPuYizy67de8XQjCJcH0aJPRhohQqpifk+1QuFB1 0cmSoiXcqfjyRtukP+8Gc9aqY62GkjOiahOJcWiHypq0qeA0l5mudirbY0foayzu5qym srQGAjACe49WawnlobB/srT/K3DXMgl8VeBSXX9Hg87R0LnWY3WK0cQfNde/ZT/YpTtm EkRA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=XPXEeRi/ekW+L3GGdtIS27DOqqtC8wiEv5BGVyiSa/E=; b=KuxwwltKWdyPow1/Zvq3KBRhHFV7NDV1YYLLKBsqWoL7t9zbpuSY7LOQIL5GaoueWS tg+9veRxiATr/zPTztBsA0jO0bKmr9vez5wt5Qryp58oVhHjfnlGqZeSay+WbhDCodt5 VwE0TApGM6WBKX8zUd9EQ2ADcVCyQ1TJHTl+ZLktBYsH91mM1J+V6+JtXAYyZ6em65/d Tmk1XtKQznYjTN1aIBVvqevhW/Q4hfyInVI4ERAE/7olcuBfFLygMVwjhsepDpmXZaVM /P0uFeNmbz8Pgbt9yUT52xkDbMmTC2oHj2QnJxeGKKg00OVInn11rxUC8MOM2rtQpAiT /KCg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=d9mR8BMy; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=XPXEeRi/ekW+L3GGdtIS27DOqqtC8wiEv5BGVyiSa/E=; b=d4Jbj5whkSIOzRBPr9OUVIXunyGQzCwpfHcQInpKPcJMCphFeqVEKtQ8vDEITu8DS5 aCw56Zs3APesR+RUSVgRSpwKHaLouSMpAIGVaguR0EQz8+3PwG4zKcWDvgtMQbj3YgfW U7QIjL1ycNibQVpPuYOW14daJ1kTtImaT/Dd8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:x-spam-checked-in-group:list-post:list-help :list-archive:list-unsubscribe; bh=XPXEeRi/ekW+L3GGdtIS27DOqqtC8wiEv5BGVyiSa/E=; b=KSRocwtbbM8gc5qa+D73BvTnduaF21rNXttqLPr7wDpALKMOCVQZyb9lw9uzHiEFRT VdqD9PaS8q19SsldyIZp6EX3Kk7CiMrsxzWtYdf04AH4V5RhbDTqoxWSZB7GB4YhrIG8 C8bu18wTFCiLbQQ9gywz4DQSkAiL4GCub4yFfyC0WOyOO+UKDSSSqSM4g605I6QHyNsq VN08NCESW7o0TPtEA214PPhFdSdQs/Tq9J+U5YoCdnPM1Z/o5MXrh51vleskVKz1zxxs Sg4oPIR4KDj8DqctI/tpCj48iYXN66MU38W7lloqGQH+C0dQehBUZ5Qfe8HsvNosMkxD 6bvQ== X-Gm-Message-State: AOAM53298rntLza+6DTCpQDVA8f/1pe6K1GrVubsMiGqiP9DyI3SfovJ UXkyx/vfEZbUWk6ryhcwBRyPVIJJ X-Google-Smtp-Source: ABdhPJzdrrCOgGGogIWbfKXWYcqcZjr6oTiLBAxAMhyHE6Eks+E/Kso8OW6CRcUV/7v0HsGhIVasZg== X-Received: by 2002:a17:90a:df88:: with SMTP id p8mr823474pjv.84.1595445001970; Wed, 22 Jul 2020 12:10:01 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:aa7:864e:: with SMTP id a14ls1032851pfo.7.gmail; Wed, 22 Jul 2020 12:10:01 -0700 (PDT) X-Received: by 2002:a63:3ece:: with SMTP id l197mr1104810pga.313.1595445001494; Wed, 22 Jul 2020 12:10:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595445001; cv=none; d=google.com; s=arc-20160816; b=HQFXPw9Ku5G5CFvC9SrQKTm8n4IaOGSMCIVkYk7Gn7fLxpKjOqTfYpVOLCGbgswz0l VEJMb2deYXtPtyaHTIOyyuDM+L0X6TKp+K2IEeR/f7f+NHmFrIaedmHiIGJKMa2Je/Bq aoi0kmVtaeer8Vd4gU9q+KUzb0/qn51raUzMLAc0niRXg9PgTpsbBCsblEdlTZ8Wgt8j bPtVy3McJqZ4yLpJmmyQhkWGlRZ4t7Zm0eOtW7ThwxjJ483+ePUE7d7GliNbiRUrnccW wiO8I32mIf+uyPJkT3PCpS7J3f+5qhh4pEKdi9AfC0cbxSyy+uAz0nACafWRVkryhmPP etYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=WuJDZTXppS2/lPeSSOe4OB8nx8zh/tKr/I+u+TYREG8=; b=tm3ghFrS9wmv1qSH6A6QrOK50Q/2Idl6133C6/uAzEs4u0dG+To0w7a8HrNXDE8SgB ZO+MTkYoqmUKPG/Uu2es6VMikzamJfsvE2ZAaRkgW6h1/DB00/zipAbBOWX5pW8b+EVD YplVBGCMr6j+gzMJhtcfvFtGyrX8Orox9zUSBbydBiGzC672gaapdylBtX7u9QLExiR1 jrZ+aHnkWX7FV+vMlqak6pQ+2iea26gJ6k9tR4a1lTIEYpFp+4GXRpOHHFRYwQkmlGO9 q85OM2jIoUCulNLVNcrpfU6AI55qSPzBhkcN75ugJeLKtUPaFP71tG92GA5OIbjDiXIs 3EYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=d9mR8BMy; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id u10sor612820pfk.100.2020.07.22.12.10.00 for <linux-amarula@amarulasolutions.com> (Google Transport Security); Wed, 22 Jul 2020 12:10:00 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:aa7:91cd:: with SMTP id z13mr995868pfa.133.1595445000304; Wed, 22 Jul 2020 12:10:00 -0700 (PDT) Received: from localhost.localdomain ([2405:201:c809:c7d5:fda7:aaf8:9d1a:6749]) by smtp.gmail.com with ESMTPSA id n137sm342398pfd.194.2020.07.22.12.09.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2020 12:09:59 -0700 (PDT) From: Jagan Teki <jagan@amarulasolutions.com> To: Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh+dt@kernel.org> Cc: Suniel Mahesh <sunil@amarulasolutions.com>, Michael Trimarchi <michael@amarulasolutions.com>, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amarula <linux-amarula@amarulasolutions.com>, Jagan Teki <jagan@amarulasolutions.com> Subject: [PATCH v2 1/6] dt-bindings: arm: rockchip: Update ROCKPi 4 with 4A binding Date: Thu, 23 Jul 2020 00:39:44 +0530 Message-Id: <20200722190949.215656-1-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=d9mR8BMy; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: <linux-amarula.amarulasolutions.com> X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>, <mailto:linux-amarula@amarulasolutions.com> List-Help: <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>, <mailto:linux-amarula+help@amarulasolutions.com> List-Archive: <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/> List-Unsubscribe: <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>, <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe> |
| Series |
[v2,1/6] dt-bindings: arm: rockchip: Update ROCKPi 4 with 4A binding
|
|
Commit Message
Jagan Teki
July 22, 2020, 7:09 p.m. UTC
ROCKPi 4 has 3 variants of hardware platforms called
ROCKPi 4A, 4B, and 4C.
- ROCKPi 4A has no Wif/BT.
- ROCKPi 4B has AP6256 Wifi/BT, PoE.
- ROCKPi 4C has AP6256 Wifi/BT, PoE, miniDP, USB Host enabled
GPIO pin change compared to 4B, 4C
So, update the existing ROCKPi 4 with ROCKPi 4A binding.
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- new patch
Documentation/devicetree/bindings/arm/rockchip.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On Thu, Jul 23, 2020 at 12:39:44AM +0530, Jagan Teki wrote: > ROCKPi 4 has 3 variants of hardware platforms called > ROCKPi 4A, 4B, and 4C. > > - ROCKPi 4A has no Wif/BT. > - ROCKPi 4B has AP6256 Wifi/BT, PoE. > - ROCKPi 4C has AP6256 Wifi/BT, PoE, miniDP, USB Host enabled > GPIO pin change compared to 4B, 4C > > So, update the existing ROCKPi 4 with ROCKPi 4A binding. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > Changes for v2: > - new patch > > Documentation/devicetree/bindings/arm/rockchip.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index 41f919de1ad4..36057c9e4b83 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -442,9 +442,10 @@ properties: > - const: radxa,rock > - const: rockchip,rk3188 > > - - description: Radxa ROCK Pi 4 > + - description: Radxa ROCK Pi 4A > items: > - const: radxa,rockpi4 > + - const: radxa,rockpi4a > - const: rockchip,rk3399 That's not what I suggested. And this is just wrong as the order is most specific to least specific. This is what I suggest: items: - enum: - radxa,rockpi4 # ROCK Pi 4A - radxa,rockpi4b - radxa,rockpi4c - const: rockchip,rk3399 > > - description: Radxa ROCK Pi N8 > -- > 2.25.1 >
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index 41f919de1ad4..36057c9e4b83 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -442,9 +442,10 @@ properties: - const: radxa,rock - const: rockchip,rk3188 - - description: Radxa ROCK Pi 4 + - description: Radxa ROCK Pi 4A items: - const: radxa,rockpi4 + - const: radxa,rockpi4a - const: rockchip,rk3399 - description: Radxa ROCK Pi N8