| Message ID | 20201221113151.94515-7-jagan@amarulasolutions.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-amarula+bncBD7MFH7A7EEBBWEPQL7QKGQEKZQRHBI@amarulasolutions.com> X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id C30963F0D3 for <linux-amarula@patchwork.amarulasolutions.com>; Mon, 21 Dec 2020 12:32:41 +0100 (CET) Received: by mail-pj1-f71.google.com with SMTP id c21sf6818530pjr.8 for <linux-amarula@patchwork.amarulasolutions.com>; Mon, 21 Dec 2020 03:32:41 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1608550360; cv=pass; d=google.com; s=arc-20160816; b=0nl30Q5X0O5s1sFfrSFVMiTsGjuh6JXcuLUrNoObkbml7BGGaaTPQgstC1zeDDhUMU j11UMjMwnICAsLSrKYy4dPByCxz077lbbl1snCFHk0dNl6BlWQfNf0gGiinNfiW7Nso7 DBZuYv9iBvOOIJWuMO7Sd+A0JFC0PSa0geuH9aguWpvp7mbmtxkJ7ANlA0OJeGxezrzm cr6ylmnKBHfsD/yQrYfm2RhMvix+a4myKE3S/oxcUZy3ArjDaKx6oWOu8W0vurtjp+SR jCt97OD+ilwCiaAy0tV0uKuz1x1r53WxIQNgJYd8hSsWb16JptUpDpfca4q2MBe3iaJP MAVQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=GotzmK7MkO5Qvi/88RdMM4cHp7rApjlHO9AdfZTxew8=; b=pVyVNbRygGRBXyE9hVlNmR0PEfKJlcqRyoxzV2dFnzPQBHT2PjTLeunePOMGT320eu B6KiTmIaP9+s8b18ClSmnWdw1aqBQcTWUNWtq1qNP/jDK1fEqT7MIgLJKQGeEYPfYzcg mGpR/XCldPtXMEBH9l5jO3qC7J9e+krfDuw6fFvadwlExsPwvNhuuZNXvoETCGDEXC3r mUHobE4/NyRvxE3Hm8vl0JQEmKVrpGzzs71fJJFzDeNla0toUh3JHd4Q7IOPY42lVw1b Abhfj34raCMoKzujIIcz9JytBoCFE/yYKWcu+2cX817fxPJftJq46RTL+zI0E3Dmnl2i 6rjQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=lQP3ku+V; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=GotzmK7MkO5Qvi/88RdMM4cHp7rApjlHO9AdfZTxew8=; b=PWaM6LuYgfR15Gu6V2VW4VRvAtT2mSEz2ti6C2tleqqOP3o0xG8ayT/vFM68Zspqw2 iyiu8IK2tZpKJcHcq7AmYOLPxpS+hlBCkTQpl4GmVhM87PMgNIpCrxhD5qvedf+wsg9f AflsizrorcFlKWvEWgccwU1u3/MGnXOjOImkw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=GotzmK7MkO5Qvi/88RdMM4cHp7rApjlHO9AdfZTxew8=; b=rTzBmPo470VH1vj3t7wMf5itrTIkrxY71b21coa9u9dNJ9mv5Sg1ddDglLVPWnrhgh Xw+cv4E7yYNCWgKBoVFATjmmc7o0xIP5Kbwn0rRCRSBDqWYpHuI6c2/JJQ+FV8teM1yC iLlqYq0Hn9zqE9bQZEqKOrRDwnWVFjInrWdZT7m1seDiN9Rd4PCMkNk2AVByWO/lHJ4R tj5YDG7naIaNtezVpI6/6tLriy5OtVpUFuiQjpvkqGmff26Hhel04k5kzhDCK+qYEBI1 y/yoIz96r4rTYGgivYEhGZM//u4egwAhT5t3dF+CJ+3lsoKDSa5O2kNdtuOmKRD45N/2 gaBw== X-Gm-Message-State: AOAM533gGe038g1wxsBxzb5O2rbu6nu0nF526ilUDuDc7w1ZnivkGvVa OQWF1dK0KwMaJtMvEnBlLsYuyQuY X-Google-Smtp-Source: ABdhPJz8yg+5aeOho0tZTgsldRMN+8/UiUVk2QEVrUUTmY0EZi96jvli9KcEYZOJC21e/Jqvw6uK5w== X-Received: by 2002:a17:902:868a:b029:da:ea50:d55f with SMTP id g10-20020a170902868ab02900daea50d55fmr16164095plo.84.1608550360618; Mon, 21 Dec 2020 03:32:40 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:90a:ac0b:: with SMTP id o11ls9022465pjq.3.gmail; Mon, 21 Dec 2020 03:32:40 -0800 (PST) X-Received: by 2002:a17:90a:be17:: with SMTP id a23mr16824943pjs.236.1608550359946; Mon, 21 Dec 2020 03:32:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608550359; cv=none; d=google.com; s=arc-20160816; b=QEBtZwuYuk4HwPUEJ/fGt2WskFIIWKQhNG2xWACB6d4CW0fOX3JbxBYBvx2dvSOha6 DO0Z8JHrMcB0EdjR3fR1dhhbKlO/tsQCIilHm8zNor7VKWKyfY/SN5Ljt0zBvgcORPTq 2t/2GKFyf1Ow7F3hk5amF+dnIA59vx9PFMKn4fXTWfoH0pZa+YPs41oMdSjkEiEFX+XD hJm+C2d0e18gGgNBNm1+X7StCGc3pUgZSgUcyOrrJFsNXelt6b0p1vYQJ6jvNFkfVm83 Go5zvt1Pcu3Xz1yZcSpIQMv17cx0kphOl6X3JSLRwaRXK6PpyD/881IgKHut4HERJeio 7oSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=VePJY0a6rjDmZpfDR0wNpF7s+xv1D864zlJ9ZXiy38M=; b=bUl1RzaC/vMPxbUyQpDDE/5ff0bmeIoI8OVAERfFvQq6RWeqBEkV+tO1eR0P06UXmn JZk7cMXFTnAGen42PtQcxBM+vBRENO/OQK72jHJOXGswWkyBsXT/kYmBwdawbRhBS9Dj lLs3PErPD/BluIJkhSmQK8mXBTs9+ORTTXRhYuIPoeQnG/yxDQEeJUZe88IMfroTJq4o QsMGd9j8bUFuxSWUgqOuPof02PA4noqUHjvDXmVDC3uQ8LY875fZL5R7+3t5ETqFeHl2 /ims/GabywyBQcLLyTq2sW/ODBXrZFCqT0raLNcSQTg9hyDs7AWlOWKdWCXX/8/cMNIS Ln7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=lQP3ku+V; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 1sor7727101pjz.9.2020.12.21.03.32.39 for <linux-amarula@amarulasolutions.com> (Google Transport Security); Mon, 21 Dec 2020 03:32:39 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:90b:19d2:: with SMTP id nm18mr17477538pjb.159.1608550359687; Mon, 21 Dec 2020 03:32:39 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a884:b9d4:ed90:a69c:2530]) by smtp.gmail.com with ESMTPSA id 197sm16714859pgd.69.2020.12.21.03.32.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Dec 2020 03:32:39 -0800 (PST) From: Jagan Teki <jagan@amarulasolutions.com> To: Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Li Yang <leoyang.li@nxp.com>, Fabio Estevam <festevam@gmail.com>, Krzysztof Kozlowski <krzk@kernel.org> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team <linux-imx@nxp.com>, linux-amarula@amarulasolutions.com, Jagan Teki <jagan@amarulasolutions.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Matteo Lisi <matteo.lisi@engicam.com> Subject: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit Date: Mon, 21 Dec 2020 17:01:51 +0530 Message-Id: <20201221113151.94515-7-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201221113151.94515-1-jagan@amarulasolutions.com> References: <20201221113151.94515-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=lQP3ku+V; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: <linux-amarula.amarulasolutions.com> X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/post>, <mailto:linux-amarula@amarulasolutions.com> List-Help: <https://support.google.com/a/amarulasolutions.com/bin/topic.py?topic=25838>, <mailto:linux-amarula+help@amarulasolutions.com> List-Archive: <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/> List-Unsubscribe: <mailto:googlegroups-manage+476853432473+unsubscribe@googlegroups.com>, <https://groups.google.com/a/amarulasolutions.com/group/linux-amarula/subscribe> |
| Series |
arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini
|
|
Commit Message
Jagan Teki
Dec. 21, 2020, 11:31 a.m. UTC
Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive Evaluation Board. Genaral features: - LCD 7" C.Touch - microSD slot - Ethernet 1Gb - Wifi/BT - 2x LVDS Full HD interfaces - 3x USB 2.0 - 1x USB 3.0 - HDMI Out - Mini PCIe - MIPI CSI - 2x CAN - Audio Out i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam. i.Core MX8M Mini needs to mount on top of this Evaluation board for creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit. PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once Mainline Linux supported. Add support for it. Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- Changes for v2: - updated commit message - dropped engicam from filename since it aligned with imx6 engicam dts files naming conventions. arch/arm64/boot/dts/freescale/Makefile | 1 + .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++ .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++ 3 files changed, 29 insertions(+) create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
Comments
On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote: > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive > Evaluation Board. > > Genaral features: > - LCD 7" C.Touch > - microSD slot > - Ethernet 1Gb > - Wifi/BT > - 2x LVDS Full HD interfaces > - 3x USB 2.0 > - 1x USB 3.0 > - HDMI Out > - Mini PCIe > - MIPI CSI > - 2x CAN > - Audio Out > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam. > > i.Core MX8M Mini needs to mount on top of this Evaluation board for > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit. > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once > Mainline Linux supported. > > Add support for it. > > Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > Changes for v2: > - updated commit message > - dropped engicam from filename since it aligned with imx6 engicam > dts files naming conventions. > > arch/arm64/boot/dts/freescale/Makefile | 1 + > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++ > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++ > 3 files changed, 29 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > index 8d49a2c74604..43783076f856 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > new file mode 100644 > index 000000000000..294df07289a2 > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > @@ -0,0 +1,7 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2020 Engicam srl > + * Copyright (c) 2020 Amarula Solutions(India) > + */ > + > +#include "imx8mm-engicam-common.dtsi" It seems you ignored my comments from previous email. That's not how we go with the process. Don't create confusing or overcomplicated hierarchy of includes. Don't create files which do nothing. Best regards, Krzysztof
On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote: > > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive > > Evaluation Board. > > > > Genaral features: > > - LCD 7" C.Touch > > - microSD slot > > - Ethernet 1Gb > > - Wifi/BT > > - 2x LVDS Full HD interfaces > > - 3x USB 2.0 > > - 1x USB 3.0 > > - HDMI Out > > - Mini PCIe > > - MIPI CSI > > - 2x CAN > > - Audio Out > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam. > > > > i.Core MX8M Mini needs to mount on top of this Evaluation board for > > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit. > > > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once > > Mainline Linux supported. > > > > Add support for it. > > > > Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com> > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > Changes for v2: > > - updated commit message > > - dropped engicam from filename since it aligned with imx6 engicam > > dts files naming conventions. > > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++ > > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++ > > 3 files changed, 29 insertions(+) > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > index 8d49a2c74604..43783076f856 100644 > > --- a/arch/arm64/boot/dts/freescale/Makefile > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > new file mode 100644 > > index 000000000000..294df07289a2 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > @@ -0,0 +1,7 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * Copyright (c) 2020 Engicam srl > > + * Copyright (c) 2020 Amarula Solutions(India) > > + */ > > + > > +#include "imx8mm-engicam-common.dtsi" > > It seems you ignored my comments from previous email. That's not how we > go with the process. > > Don't create confusing or overcomplicated hierarchy of includes. Don't > create files which do nothing. Idea is to move common nodes in separate dtsi instead of adding redundant nodes into respective areas. let me know if it still confusing. Jagan.
On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote: > On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote: > > > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive > > > Evaluation Board. > > > > > > Genaral features: > > > - LCD 7" C.Touch > > > - microSD slot > > > - Ethernet 1Gb > > > - Wifi/BT > > > - 2x LVDS Full HD interfaces > > > - 3x USB 2.0 > > > - 1x USB 3.0 > > > - HDMI Out > > > - Mini PCIe > > > - MIPI CSI > > > - 2x CAN > > > - Audio Out > > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam. > > > > > > i.Core MX8M Mini needs to mount on top of this Evaluation board for > > > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit. > > > > > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once > > > Mainline Linux supported. > > > > > > Add support for it. > > > > > > Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com> > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > > --- > > > Changes for v2: > > > - updated commit message > > > - dropped engicam from filename since it aligned with imx6 engicam > > > dts files naming conventions. > > > > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++ > > > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++ > > > 3 files changed, 29 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > > index 8d49a2c74604..43783076f856 100644 > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > new file mode 100644 > > > index 000000000000..294df07289a2 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > @@ -0,0 +1,7 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * Copyright (c) 2020 Engicam srl > > > + * Copyright (c) 2020 Amarula Solutions(India) > > > + */ > > > + > > > +#include "imx8mm-engicam-common.dtsi" > > > > It seems you ignored my comments from previous email. That's not how we > > go with the process. > > > > Don't create confusing or overcomplicated hierarchy of includes. Don't > > create files which do nothing. > > Idea is to move common nodes in separate dtsi instead of adding > redundant nodes into respective areas. let me know if it still > confusing. A file which *only* includes another file does not fulfill this idea of moving common nodes to a separate DTSI file. Or if I still miss something, please point me, what common nodes are stored in imx8mm-engicam-edimm2.2.dtsi? Best regards, Krzysztof
On Tue, Dec 22, 2020 at 2:36 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote: > > On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > > > > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote: > > > > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive > > > > Evaluation Board. > > > > > > > > Genaral features: > > > > - LCD 7" C.Touch > > > > - microSD slot > > > > - Ethernet 1Gb > > > > - Wifi/BT > > > > - 2x LVDS Full HD interfaces > > > > - 3x USB 2.0 > > > > - 1x USB 3.0 > > > > - HDMI Out > > > > - Mini PCIe > > > > - MIPI CSI > > > > - 2x CAN > > > > - Audio Out > > > > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam. > > > > > > > > i.Core MX8M Mini needs to mount on top of this Evaluation board for > > > > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit. > > > > > > > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once > > > > Mainline Linux supported. > > > > > > > > Add support for it. > > > > > > > > Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com> > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > > > --- > > > > Changes for v2: > > > > - updated commit message > > > > - dropped engicam from filename since it aligned with imx6 engicam > > > > dts files naming conventions. > > > > > > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > > > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++ > > > > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++ > > > > 3 files changed, 29 insertions(+) > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > > > index 8d49a2c74604..43783076f856 100644 > > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > > new file mode 100644 > > > > index 000000000000..294df07289a2 > > > > --- /dev/null > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > > @@ -0,0 +1,7 @@ > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > +/* > > > > + * Copyright (c) 2020 Engicam srl > > > > + * Copyright (c) 2020 Amarula Solutions(India) > > > > + */ > > > > + > > > > +#include "imx8mm-engicam-common.dtsi" > > > > > > It seems you ignored my comments from previous email. That's not how we > > > go with the process. > > > > > > Don't create confusing or overcomplicated hierarchy of includes. Don't > > > create files which do nothing. > > > > Idea is to move common nodes in separate dtsi instead of adding > > redundant nodes into respective areas. let me know if it still > > confusing. > > A file which *only* includes another file does not fulfill this idea of > moving common nodes to a separate DTSI file. Or if I still miss > something, please point me, what common nodes are stored in > imx8mm-engicam-edimm2.2.dtsi? imx8mm-engicam-edimm2.2.dtsi for EDIMM2.2 Carrier imx8mm-engicam-ctouch2.dtsi for C.TOUCH2 Carrier imx8mm-engicam-common.dtsi for common nodes for above 2 carrier boards. Yes, imx8mm-engicam-edimm2.2.dtsi is empty now but nodes like PCIe, CSI, DSI will support once the respective drivers are part of Mainline but those are not supported in C.TOUCH2 carrier board dtsi. There are some GPIO pins differences between EDIMM2.2 and C.TOUCH2 carriers on WiFi/BT so those will be part of the respective carrier dtsi. Hope this would clear. Jagan.
On Tue, Dec 22, 2020 at 02:20:55PM +0530, Jagan Teki wrote: > On Tue, Dec 22, 2020 at 2:36 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > > On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote: > > > On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > > > > > > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote: > > > > > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive > > > > > Evaluation Board. > > > > > > > > > > Genaral features: > > > > > - LCD 7" C.Touch > > > > > - microSD slot > > > > > - Ethernet 1Gb > > > > > - Wifi/BT > > > > > - 2x LVDS Full HD interfaces > > > > > - 3x USB 2.0 > > > > > - 1x USB 3.0 > > > > > - HDMI Out > > > > > - Mini PCIe > > > > > - MIPI CSI > > > > > - 2x CAN > > > > > - Audio Out > > > > > > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam. > > > > > > > > > > i.Core MX8M Mini needs to mount on top of this Evaluation board for > > > > > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit. > > > > > > > > > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once > > > > > Mainline Linux supported. > > > > > > > > > > Add support for it. > > > > > > > > > > Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com> > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > > > > --- > > > > > Changes for v2: > > > > > - updated commit message > > > > > - dropped engicam from filename since it aligned with imx6 engicam > > > > > dts files naming conventions. > > > > > > > > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > > > > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++ > > > > > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++ > > > > > 3 files changed, 29 insertions(+) > > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts > > > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > > > > index 8d49a2c74604..43783076f856 100644 > > > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > > > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb > > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > > > new file mode 100644 > > > > > index 000000000000..294df07289a2 > > > > > --- /dev/null > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > > > @@ -0,0 +1,7 @@ > > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > > +/* > > > > > + * Copyright (c) 2020 Engicam srl > > > > > + * Copyright (c) 2020 Amarula Solutions(India) > > > > > + */ > > > > > + > > > > > +#include "imx8mm-engicam-common.dtsi" > > > > > > > > It seems you ignored my comments from previous email. That's not how we > > > > go with the process. > > > > > > > > Don't create confusing or overcomplicated hierarchy of includes. Don't > > > > create files which do nothing. > > > > > > Idea is to move common nodes in separate dtsi instead of adding > > > redundant nodes into respective areas. let me know if it still > > > confusing. > > > > A file which *only* includes another file does not fulfill this idea of > > moving common nodes to a separate DTSI file. Or if I still miss > > something, please point me, what common nodes are stored in > > imx8mm-engicam-edimm2.2.dtsi? > > imx8mm-engicam-edimm2.2.dtsi for EDIMM2.2 Carrier > imx8mm-engicam-ctouch2.dtsi for C.TOUCH2 Carrier > imx8mm-engicam-common.dtsi for common nodes for above 2 carrier boards. > > Yes, imx8mm-engicam-edimm2.2.dtsi is empty now Then that's the answer. We do not create empty files. > but nodes like PCIe, > CSI, DSI will support once the respective drivers are part of Mainline > but those are not supported in C.TOUCH2 carrier board dtsi. There are > some GPIO pins differences between EDIMM2.2 and C.TOUCH2 carriers on > WiFi/BT so those will be part of the respective carrier dtsi. It's the same clear as before. Don't create empty files. Once you decide to bring new features, you create a new file. Best regards, Krzysztof
On Tue, Dec 22, 2020 at 2:23 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Tue, Dec 22, 2020 at 02:20:55PM +0530, Jagan Teki wrote: > > On Tue, Dec 22, 2020 at 2:36 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > > > > On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote: > > > > On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > > > > > > > > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote: > > > > > > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive > > > > > > Evaluation Board. > > > > > > > > > > > > Genaral features: > > > > > > - LCD 7" C.Touch > > > > > > - microSD slot > > > > > > - Ethernet 1Gb > > > > > > - Wifi/BT > > > > > > - 2x LVDS Full HD interfaces > > > > > > - 3x USB 2.0 > > > > > > - 1x USB 3.0 > > > > > > - HDMI Out > > > > > > - Mini PCIe > > > > > > - MIPI CSI > > > > > > - 2x CAN > > > > > > - Audio Out > > > > > > > > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam. > > > > > > > > > > > > i.Core MX8M Mini needs to mount on top of this Evaluation board for > > > > > > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit. > > > > > > > > > > > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once > > > > > > Mainline Linux supported. > > > > > > > > > > > > Add support for it. > > > > > > > > > > > > Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com> > > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > > > > > --- > > > > > > Changes for v2: > > > > > > - updated commit message > > > > > > - dropped engicam from filename since it aligned with imx6 engicam > > > > > > dts files naming conventions. > > > > > > > > > > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > > > > > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++ > > > > > > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++ > > > > > > 3 files changed, 29 insertions(+) > > > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts > > > > > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > > > > > index 8d49a2c74604..43783076f856 100644 > > > > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > > > > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb > > > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > > > > new file mode 100644 > > > > > > index 000000000000..294df07289a2 > > > > > > --- /dev/null > > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > > > > @@ -0,0 +1,7 @@ > > > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > > > +/* > > > > > > + * Copyright (c) 2020 Engicam srl > > > > > > + * Copyright (c) 2020 Amarula Solutions(India) > > > > > > + */ > > > > > > + > > > > > > +#include "imx8mm-engicam-common.dtsi" > > > > > > > > > > It seems you ignored my comments from previous email. That's not how we > > > > > go with the process. > > > > > > > > > > Don't create confusing or overcomplicated hierarchy of includes. Don't > > > > > create files which do nothing. > > > > > > > > Idea is to move common nodes in separate dtsi instead of adding > > > > redundant nodes into respective areas. let me know if it still > > > > confusing. > > > > > > A file which *only* includes another file does not fulfill this idea of > > > moving common nodes to a separate DTSI file. Or if I still miss > > > something, please point me, what common nodes are stored in > > > imx8mm-engicam-edimm2.2.dtsi? > > > > imx8mm-engicam-edimm2.2.dtsi for EDIMM2.2 Carrier > > imx8mm-engicam-ctouch2.dtsi for C.TOUCH2 Carrier > > imx8mm-engicam-common.dtsi for common nodes for above 2 carrier boards. > > > > Yes, imx8mm-engicam-edimm2.2.dtsi is empty now > > Then that's the answer. We do not create empty files. > > > but nodes like PCIe, > > CSI, DSI will support once the respective drivers are part of Mainline > > but those are not supported in C.TOUCH2 carrier board dtsi. There are > > some GPIO pins differences between EDIMM2.2 and C.TOUCH2 carriers on > > WiFi/BT so those will be part of the respective carrier dtsi. > > It's the same clear as before. Don't create empty files. Once you decide > to bring new features, you create a new file. Okay, then will add w/o common file in next version. Jagan.
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile index 8d49a2c74604..43783076f856 100644 --- a/arch/arm64/boot/dts/freescale/Makefile +++ b/arch/arm64/boot/dts/freescale/Makefile @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi new file mode 100644 index 000000000000..294df07289a2 --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi @@ -0,0 +1,7 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (c) 2020 Engicam srl + * Copyright (c) 2020 Amarula Solutions(India) + */ + +#include "imx8mm-engicam-common.dtsi" diff --git a/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts new file mode 100644 index 000000000000..672aee1800c4 --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts @@ -0,0 +1,21 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (c) 2019 NXP + * Copyright (c) 2019 Engicam srl + * Copyright (c) 2020 Amarula Solutions(India) + */ + +/dts-v1/; +#include "imx8mm.dtsi" +#include "imx8mm-engicam-edimm2.2.dtsi" +#include "imx8mm-icore-mx8mm.dtsi" + +/ { + model = "Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit"; + compatible = "engicam,icore-mx8mm-edimm2.2", "engicam,icore-mx8mm", + "fsl,imx8mm"; + + chosen { + stdout-path = &uart2; + }; +};