| Message ID | 20220714075131.411548-8-michael@amarulasolutions.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Hi Michael, On Thu, Jul 14, 2022 at 9:51 AM Michael Trimarchi <michael@amarulasolutions.com> wrote: > > Upstream commit 9b2d61f80b060ce3ea5af2a99e148b0b214932b2 > > Move Toshiba specific initialization and detection logic into > nand_toshiba.c. This is part of the "separate vendor specific code from > core" cleanup process. > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> > Acked-by: Richard Weinberger <richard@nod.at> > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com> > --- > drivers/mtd/nand/raw/Makefile | 3 +- > drivers/mtd/nand/raw/nand_base.c | 21 ++---------- > drivers/mtd/nand/raw/nand_ids.c | 2 +- > drivers/mtd/nand/raw/nand_toshiba.c | 53 +++++++++++++++++++++++++++++ > include/linux/mtd/rawnand.h | 1 + > 5 files changed, 59 insertions(+), 21 deletions(-) > create mode 100644 drivers/mtd/nand/raw/nand_toshiba.c > > diff --git a/drivers/mtd/nand/raw/Makefile b/drivers/mtd/nand/raw/Makefile > index d6ba111ab2..2eb08c1a9f 100644 > --- a/drivers/mtd/nand/raw/Makefile > +++ b/drivers/mtd/nand/raw/Makefile > @@ -14,7 +14,7 @@ obj-$(CONFIG_SPL_NAND_DENALI) += denali_spl.o > obj-$(CONFIG_SPL_NAND_SIMPLE) += nand_spl_simple.o > obj-$(CONFIG_SPL_NAND_LOAD) += nand_spl_load.o > obj-$(CONFIG_SPL_NAND_ECC) += nand_ecc.o > -obj-$(CONFIG_SPL_NAND_BASE) += nand_base.o nand_hynix.o nand_samsung.o > +obj-$(CONFIG_SPL_NAND_BASE) += nand_base.o nand_hynix.o nand_samsung.o nand_toshiba.o > obj-$(CONFIG_SPL_NAND_IDENT) += nand_ids.o nand_timings.o > obj-$(CONFIG_SPL_NAND_INIT) += nand.o > ifeq ($(CONFIG_SPL_ENV_SUPPORT),y) > @@ -33,6 +33,7 @@ obj-y += nand_ecc.o > obj-y += nand_base.o > obj-y += nand_hynix.o > obj-y += nand_samsung.o > +obj-y += nand_toshiba.o > obj-y += nand_timings.o > > endif # not spl > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > index da22cf6e79..c5a5c22b12 100644 > --- a/drivers/mtd/nand/raw/nand_base.c > +++ b/drivers/mtd/nand/raw/nand_base.c > @@ -4155,12 +4155,11 @@ static int nand_get_bits_per_cell(u8 cellinfo) > void nand_decode_ext_id(struct nand_chip *chip) > { > struct mtd_info *mtd = &chip->mtd; > - int extid, id_len; > + int extid; > /* The 3rd id byte holds MLC / multichip data */ > chip->bits_per_cell = nand_get_bits_per_cell(chip->id.data[2]); > /* The 4th id byte is the important one */ > extid = chip->id.data[3]; > - id_len = chip->id.len; > > /* Calc pagesize */ > mtd->writesize = 1024 << (extid & 0x03); > @@ -4176,21 +4175,6 @@ void nand_decode_ext_id(struct nand_chip *chip) > /* Get buswidth information */ > if (extid & 0x1) > chip->options |= NAND_BUSWIDTH_16; > - > - /* > - * Toshiba 24nm raw SLC (i.e., not BENAND) have 32B OOB per > - * 512B page. For Toshiba SLC, we decode the 5th/6th byte as > - * follows: > - * - ID byte 6, bits[2:0]: 100b -> 43nm, 101b -> 32nm, > - * 110b -> 24nm > - * - ID byte 5, bit[7]: 1 -> BENAND, 0 -> raw SLC > - */ > - if (id_len >= 6 && chip->id.data[0] == NAND_MFR_TOSHIBA && > - nand_is_slc(chip) && > - (chip->id.data[5] & 0x7) == 0x6 /* 24nm */ && > - !(chip->id.data[4] & 0x80) /* !BENAND */) { > - mtd->oobsize = 32 * mtd->writesize >> 9; > - } > } > EXPORT_SYMBOL_GPL(nand_decode_ext_id); > > @@ -4282,8 +4266,7 @@ static void nand_decode_bbm_options(struct mtd_info *mtd, > * AMD/Spansion, and Macronix. All others scan only the first page. > */ > if ((nand_is_slc(chip) && > - (maf_id == NAND_MFR_TOSHIBA || > - maf_id == NAND_MFR_AMD || > + (maf_id == NAND_MFR_AMD || > maf_id == NAND_MFR_MACRONIX)) || > (mtd->writesize == 2048 && maf_id == NAND_MFR_MICRON)) > chip->bbt_options |= NAND_BBT_SCAN2NDPAGE; > diff --git a/drivers/mtd/nand/raw/nand_ids.c b/drivers/mtd/nand/raw/nand_ids.c > index ec263a4327..509652c8e2 100644 > --- a/drivers/mtd/nand/raw/nand_ids.c > +++ b/drivers/mtd/nand/raw/nand_ids.c > @@ -188,7 +188,7 @@ struct nand_flash_dev nand_flash_ids[] = { > > /* Manufacturer IDs */ > struct nand_manufacturers nand_manuf_ids[] = { > - {NAND_MFR_TOSHIBA, "Toshiba"}, > + {NAND_MFR_TOSHIBA, "Toshiba", &toshiba_nand_manuf_ops}, > {NAND_MFR_SAMSUNG, "Samsung", &samsung_nand_manuf_ops}, > {NAND_MFR_FUJITSU, "Fujitsu"}, > {NAND_MFR_NATIONAL, "National"}, > diff --git a/drivers/mtd/nand/raw/nand_toshiba.c b/drivers/mtd/nand/raw/nand_toshiba.c > new file mode 100644 > index 0000000000..1ac80df651 > --- /dev/null > +++ b/drivers/mtd/nand/raw/nand_toshiba.c > @@ -0,0 +1,53 @@ > +/* > + * Copyright (C) 2017 Free Electrons > + * Copyright (C) 2017 NextThing Co > + * > + * Author: Boris Brezillon <boris.brezillon@free-electrons.com> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +#include <linux/bug.h> > +#include <linux/mtd/nand.h> > +#include <linux/mtd/rawnand.h> > + > +static void toshiba_nand_decode_id(struct nand_chip *chip) > +{ > + struct mtd_info *mtd = nand_to_mtd(chip); > + > + nand_decode_ext_id(chip); > + > + /* > + * Toshiba 24nm raw SLC (i.e., not BENAND) have 32B OOB per > + * 512B page. For Toshiba SLC, we decode the 5th/6th byte as > + * follows: > + * - ID byte 6, bits[2:0]: 100b -> 43nm, 101b -> 32nm, > + * 110b -> 24nm > + * - ID byte 5, bit[7]: 1 -> BENAND, 0 -> raw SLC > + */ > + if (chip->id.len >= 6 && nand_is_slc(chip) && > + (chip->id.data[5] & 0x7) == 0x6 /* 24nm */ && > + !(chip->id.data[4] & 0x80) /* !BENAND */) > + mtd->oobsize = 32 * mtd->writesize >> 9; > +} > + > +static int toshiba_nand_init(struct nand_chip *chip) > +{ > + if (nand_is_slc(chip)) > + chip->bbt_options |= NAND_BBT_SCAN2NDPAGE; > + > + return 0; > +} > + > +const struct nand_manufacturer_ops toshiba_nand_manuf_ops = { > + .detect = toshiba_nand_decode_id, > + .init = toshiba_nand_init, > +}; > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h > index d35277d187..73abb34016 100644 > --- a/include/linux/mtd/rawnand.h > +++ b/include/linux/mtd/rawnand.h > @@ -1158,6 +1158,7 @@ struct nand_manufacturers { > extern struct nand_flash_dev nand_flash_ids[]; > extern struct nand_manufacturers nand_manuf_ids[]; > > +extern const struct nand_manufacturer_ops toshiba_nand_manuf_ops; > extern const struct nand_manufacturer_ops samsung_nand_manuf_ops; > extern const struct nand_manufacturer_ops hynix_nand_manuf_ops; > > -- > 2.34.1 > Looks good to me. Regards Dario
diff --git a/drivers/mtd/nand/raw/Makefile b/drivers/mtd/nand/raw/Makefile index d6ba111ab2..2eb08c1a9f 100644 --- a/drivers/mtd/nand/raw/Makefile +++ b/drivers/mtd/nand/raw/Makefile @@ -14,7 +14,7 @@ obj-$(CONFIG_SPL_NAND_DENALI) += denali_spl.o obj-$(CONFIG_SPL_NAND_SIMPLE) += nand_spl_simple.o obj-$(CONFIG_SPL_NAND_LOAD) += nand_spl_load.o obj-$(CONFIG_SPL_NAND_ECC) += nand_ecc.o -obj-$(CONFIG_SPL_NAND_BASE) += nand_base.o nand_hynix.o nand_samsung.o +obj-$(CONFIG_SPL_NAND_BASE) += nand_base.o nand_hynix.o nand_samsung.o nand_toshiba.o obj-$(CONFIG_SPL_NAND_IDENT) += nand_ids.o nand_timings.o obj-$(CONFIG_SPL_NAND_INIT) += nand.o ifeq ($(CONFIG_SPL_ENV_SUPPORT),y) @@ -33,6 +33,7 @@ obj-y += nand_ecc.o obj-y += nand_base.o obj-y += nand_hynix.o obj-y += nand_samsung.o +obj-y += nand_toshiba.o obj-y += nand_timings.o endif # not spl diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c index da22cf6e79..c5a5c22b12 100644 --- a/drivers/mtd/nand/raw/nand_base.c +++ b/drivers/mtd/nand/raw/nand_base.c @@ -4155,12 +4155,11 @@ static int nand_get_bits_per_cell(u8 cellinfo) void nand_decode_ext_id(struct nand_chip *chip) { struct mtd_info *mtd = &chip->mtd; - int extid, id_len; + int extid; /* The 3rd id byte holds MLC / multichip data */ chip->bits_per_cell = nand_get_bits_per_cell(chip->id.data[2]); /* The 4th id byte is the important one */ extid = chip->id.data[3]; - id_len = chip->id.len; /* Calc pagesize */ mtd->writesize = 1024 << (extid & 0x03); @@ -4176,21 +4175,6 @@ void nand_decode_ext_id(struct nand_chip *chip) /* Get buswidth information */ if (extid & 0x1) chip->options |= NAND_BUSWIDTH_16; - - /* - * Toshiba 24nm raw SLC (i.e., not BENAND) have 32B OOB per - * 512B page. For Toshiba SLC, we decode the 5th/6th byte as - * follows: - * - ID byte 6, bits[2:0]: 100b -> 43nm, 101b -> 32nm, - * 110b -> 24nm - * - ID byte 5, bit[7]: 1 -> BENAND, 0 -> raw SLC - */ - if (id_len >= 6 && chip->id.data[0] == NAND_MFR_TOSHIBA && - nand_is_slc(chip) && - (chip->id.data[5] & 0x7) == 0x6 /* 24nm */ && - !(chip->id.data[4] & 0x80) /* !BENAND */) { - mtd->oobsize = 32 * mtd->writesize >> 9; - } } EXPORT_SYMBOL_GPL(nand_decode_ext_id); @@ -4282,8 +4266,7 @@ static void nand_decode_bbm_options(struct mtd_info *mtd, * AMD/Spansion, and Macronix. All others scan only the first page. */ if ((nand_is_slc(chip) && - (maf_id == NAND_MFR_TOSHIBA || - maf_id == NAND_MFR_AMD || + (maf_id == NAND_MFR_AMD || maf_id == NAND_MFR_MACRONIX)) || (mtd->writesize == 2048 && maf_id == NAND_MFR_MICRON)) chip->bbt_options |= NAND_BBT_SCAN2NDPAGE; diff --git a/drivers/mtd/nand/raw/nand_ids.c b/drivers/mtd/nand/raw/nand_ids.c index ec263a4327..509652c8e2 100644 --- a/drivers/mtd/nand/raw/nand_ids.c +++ b/drivers/mtd/nand/raw/nand_ids.c @@ -188,7 +188,7 @@ struct nand_flash_dev nand_flash_ids[] = { /* Manufacturer IDs */ struct nand_manufacturers nand_manuf_ids[] = { - {NAND_MFR_TOSHIBA, "Toshiba"}, + {NAND_MFR_TOSHIBA, "Toshiba", &toshiba_nand_manuf_ops}, {NAND_MFR_SAMSUNG, "Samsung", &samsung_nand_manuf_ops}, {NAND_MFR_FUJITSU, "Fujitsu"}, {NAND_MFR_NATIONAL, "National"}, diff --git a/drivers/mtd/nand/raw/nand_toshiba.c b/drivers/mtd/nand/raw/nand_toshiba.c new file mode 100644 index 0000000000..1ac80df651 --- /dev/null +++ b/drivers/mtd/nand/raw/nand_toshiba.c @@ -0,0 +1,53 @@ +/* + * Copyright (C) 2017 Free Electrons + * Copyright (C) 2017 NextThing Co + * + * Author: Boris Brezillon <boris.brezillon@free-electrons.com> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <linux/bug.h> +#include <linux/mtd/nand.h> +#include <linux/mtd/rawnand.h> + +static void toshiba_nand_decode_id(struct nand_chip *chip) +{ + struct mtd_info *mtd = nand_to_mtd(chip); + + nand_decode_ext_id(chip); + + /* + * Toshiba 24nm raw SLC (i.e., not BENAND) have 32B OOB per + * 512B page. For Toshiba SLC, we decode the 5th/6th byte as + * follows: + * - ID byte 6, bits[2:0]: 100b -> 43nm, 101b -> 32nm, + * 110b -> 24nm + * - ID byte 5, bit[7]: 1 -> BENAND, 0 -> raw SLC + */ + if (chip->id.len >= 6 && nand_is_slc(chip) && + (chip->id.data[5] & 0x7) == 0x6 /* 24nm */ && + !(chip->id.data[4] & 0x80) /* !BENAND */) + mtd->oobsize = 32 * mtd->writesize >> 9; +} + +static int toshiba_nand_init(struct nand_chip *chip) +{ + if (nand_is_slc(chip)) + chip->bbt_options |= NAND_BBT_SCAN2NDPAGE; + + return 0; +} + +const struct nand_manufacturer_ops toshiba_nand_manuf_ops = { + .detect = toshiba_nand_decode_id, + .init = toshiba_nand_init, +}; diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h index d35277d187..73abb34016 100644 --- a/include/linux/mtd/rawnand.h +++ b/include/linux/mtd/rawnand.h @@ -1158,6 +1158,7 @@ struct nand_manufacturers { extern struct nand_flash_dev nand_flash_ids[]; extern struct nand_manufacturers nand_manuf_ids[]; +extern const struct nand_manufacturer_ops toshiba_nand_manuf_ops; extern const struct nand_manufacturer_ops samsung_nand_manuf_ops; extern const struct nand_manufacturer_ops hynix_nand_manuf_ops;