[1/7] mtd: nand: Rename the nand_manufacturers struct
diff mbox series

Message ID 20220727093748.1415135-2-michael@amarulasolutions.com
State New
Headers show
Series
  • NAND new improvements
Related show

Commit Message

Michael Nazzareno Trimarchi July 27, 2022, 9:37 a.m. UTC 
Upstream linux commit 8cfb9ab68f9070.

Drop the 's' at the end of nand_manufacturers since the struct is actually
describing a single manufacturer, not a manufacturer table.

Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
 drivers/mtd/nand/raw/nand_base.c | 4 ++--
 drivers/mtd/nand/raw/nand_ids.c  | 2 +-
 include/linux/mtd/rawnand.h      | 8 ++++----
 3 files changed, 7 insertions(+), 7 deletions(-)

Comments

Dario Binacchi July 27, 2022, 10:16 a.m. UTC | #1 
Hi Michael,

On Wed, Jul 27, 2022 at 11:37 AM Michael Trimarchi
<michael@amarulasolutions.com> wrote:
>
> Upstream linux commit 8cfb9ab68f9070.
>
> Drop the 's' at the end of nand_manufacturers since the struct is actually
> describing a single manufacturer, not a manufacturer table.
>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
>  drivers/mtd/nand/raw/nand_base.c | 4 ++--
>  drivers/mtd/nand/raw/nand_ids.c  | 2 +-
>  include/linux/mtd/rawnand.h      | 8 ++++----
>  3 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
> index 4b09a11288..9d8ccfda53 100644
> --- a/drivers/mtd/nand/raw/nand_base.c
> +++ b/drivers/mtd/nand/raw/nand_base.c
> @@ -4261,7 +4261,7 @@ static bool find_full_id_nand(struct mtd_info *mtd, struct nand_chip *chip,
>   * Returns a nand_manufacturer_desc object if the manufacturer is defined
>   * in the NAND manufacturers database, NULL otherwise.
>   */
> -static const struct nand_manufacturers *nand_get_manufacturer_desc(u8 id)
> +static const struct nand_manufacturer *nand_get_manufacturer_desc(u8 id)
>  {
>         int i;
>
> @@ -4281,7 +4281,7 @@ struct nand_flash_dev *nand_get_flash_type(struct nand_chip *chip, int *maf_id,
>                                            struct nand_flash_dev *type)
>  {
>         struct mtd_info *mtd = &chip->mtd;
> -       const struct nand_manufacturers *manufacturer_desc;
> +       const struct nand_manufacturer *manufacturer_desc;
>         int busw, ret;
>         u8 *id_data = chip->id.data;
>
> diff --git a/drivers/mtd/nand/raw/nand_ids.c b/drivers/mtd/nand/raw/nand_ids.c
> index 4dece1b206..d0cfacc69b 100644
> --- a/drivers/mtd/nand/raw/nand_ids.c
> +++ b/drivers/mtd/nand/raw/nand_ids.c
> @@ -177,7 +177,7 @@ struct nand_flash_dev nand_flash_ids[] = {
>  };
>
>  /* Manufacturer IDs */
> -struct nand_manufacturers nand_manuf_ids[] = {
> +struct nand_manufacturer nand_manuf_ids[] = {
>         {NAND_MFR_TOSHIBA, "Toshiba", &toshiba_nand_manuf_ops},
>         {NAND_MFR_SAMSUNG, "Samsung", &samsung_nand_manuf_ops},
>         {NAND_MFR_FUJITSU, "Fujitsu"},
> diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
> index aa45558b3d..8dc2d81dba 100644
> --- a/include/linux/mtd/rawnand.h
> +++ b/include/linux/mtd/rawnand.h
> @@ -976,7 +976,7 @@ struct nand_chip {
>         void *priv;
>
>         struct {
> -               const struct nand_manufacturers *desc;
> +               const struct nand_manufacturer *desc;
>                 void *priv;
>         } manufacturer;
>  };
> @@ -1124,19 +1124,19 @@ struct nand_flash_dev {
>  };
>
>  /**
> - * struct nand_manufacturers - NAND Flash Manufacturer ID Structure
> + * struct nand_manufacturer - NAND Flash Manufacturer ID Structure
>   * @name:      Manufacturer name
>   * @id:                manufacturer ID code of device.
>   * @ops:       manufacturer operations
>  */
> -struct nand_manufacturers {
> +struct nand_manufacturer {
>         int id;
>         char *name;
>         const struct nand_manufacturer_ops *ops;
>  };
>
>  extern struct nand_flash_dev nand_flash_ids[];
> -extern struct nand_manufacturers nand_manuf_ids[];
> +extern struct nand_manufacturer nand_manuf_ids[];
>
>  extern const struct nand_manufacturer_ops toshiba_nand_manuf_ops;
>  extern const struct nand_manufacturer_ops samsung_nand_manuf_ops;
> --
> 2.34.1
>

looks good to me.
Dario
Tommaso Merciai July 28, 2022, 7:35 a.m. UTC | #2 
On Wed, Jul 27, 2022 at 11:37:42AM +0200, Michael Trimarchi wrote:
> Upstream linux commit 8cfb9ab68f9070.
> 
> Drop the 's' at the end of nand_manufacturers since the struct is actually
> describing a single manufacturer, not a manufacturer table.
> 
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
>  drivers/mtd/nand/raw/nand_base.c | 4 ++--
>  drivers/mtd/nand/raw/nand_ids.c  | 2 +-
>  include/linux/mtd/rawnand.h      | 8 ++++----
>  3 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
> index 4b09a11288..9d8ccfda53 100644
> --- a/drivers/mtd/nand/raw/nand_base.c
> +++ b/drivers/mtd/nand/raw/nand_base.c
> @@ -4261,7 +4261,7 @@ static bool find_full_id_nand(struct mtd_info *mtd, struct nand_chip *chip,
>   * Returns a nand_manufacturer_desc object if the manufacturer is defined
>   * in the NAND manufacturers database, NULL otherwise.
>   */
> -static const struct nand_manufacturers *nand_get_manufacturer_desc(u8 id)
> +static const struct nand_manufacturer *nand_get_manufacturer_desc(u8 id)
>  {
>  	int i;
>  
> @@ -4281,7 +4281,7 @@ struct nand_flash_dev *nand_get_flash_type(struct nand_chip *chip, int *maf_id,
>  					   struct nand_flash_dev *type)
>  {
>  	struct mtd_info *mtd = &chip->mtd;
> -	const struct nand_manufacturers *manufacturer_desc;
> +	const struct nand_manufacturer *manufacturer_desc;
>  	int busw, ret;
>  	u8 *id_data = chip->id.data;
>  
> diff --git a/drivers/mtd/nand/raw/nand_ids.c b/drivers/mtd/nand/raw/nand_ids.c
> index 4dece1b206..d0cfacc69b 100644
> --- a/drivers/mtd/nand/raw/nand_ids.c
> +++ b/drivers/mtd/nand/raw/nand_ids.c
> @@ -177,7 +177,7 @@ struct nand_flash_dev nand_flash_ids[] = {
>  };
>  
>  /* Manufacturer IDs */
> -struct nand_manufacturers nand_manuf_ids[] = {
> +struct nand_manufacturer nand_manuf_ids[] = {
>  	{NAND_MFR_TOSHIBA, "Toshiba", &toshiba_nand_manuf_ops},
>  	{NAND_MFR_SAMSUNG, "Samsung", &samsung_nand_manuf_ops},
>  	{NAND_MFR_FUJITSU, "Fujitsu"},
> diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
> index aa45558b3d..8dc2d81dba 100644
> --- a/include/linux/mtd/rawnand.h
> +++ b/include/linux/mtd/rawnand.h
> @@ -976,7 +976,7 @@ struct nand_chip {
>  	void *priv;
>  
>  	struct {
> -		const struct nand_manufacturers *desc;
> +		const struct nand_manufacturer *desc;
>  		void *priv;
>  	} manufacturer;
>  };
> @@ -1124,19 +1124,19 @@ struct nand_flash_dev {
>  };
>  
>  /**
> - * struct nand_manufacturers - NAND Flash Manufacturer ID Structure
> + * struct nand_manufacturer - NAND Flash Manufacturer ID Structure
>   * @name:	Manufacturer name
>   * @id:		manufacturer ID code of device.
>   * @ops:	manufacturer operations
>  */
> -struct nand_manufacturers {
> +struct nand_manufacturer {
>  	int id;
>  	char *name;
>  	const struct nand_manufacturer_ops *ops;
>  };
>  
>  extern struct nand_flash_dev nand_flash_ids[];
> -extern struct nand_manufacturers nand_manuf_ids[];
> +extern struct nand_manufacturer nand_manuf_ids[];
>  
>  extern const struct nand_manufacturer_ops toshiba_nand_manuf_ops;
>  extern const struct nand_manufacturer_ops samsung_nand_manuf_ops;
> -- 
> 2.34.1
> 

Hi Michael,
Looks good to me.

Patch
diff mbox series 

diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index 4b09a11288..9d8ccfda53 100644
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -4261,7 +4261,7 @@  static bool find_full_id_nand(struct mtd_info *mtd, struct nand_chip *chip,
  * Returns a nand_manufacturer_desc object if the manufacturer is defined
  * in the NAND manufacturers database, NULL otherwise.
  */
-static const struct nand_manufacturers *nand_get_manufacturer_desc(u8 id)
+static const struct nand_manufacturer *nand_get_manufacturer_desc(u8 id)
 {
 	int i;
 
@@ -4281,7 +4281,7 @@  struct nand_flash_dev *nand_get_flash_type(struct nand_chip *chip, int *maf_id,
 					   struct nand_flash_dev *type)
 {
 	struct mtd_info *mtd = &chip->mtd;
-	const struct nand_manufacturers *manufacturer_desc;
+	const struct nand_manufacturer *manufacturer_desc;
 	int busw, ret;
 	u8 *id_data = chip->id.data;
 
diff --git a/drivers/mtd/nand/raw/nand_ids.c b/drivers/mtd/nand/raw/nand_ids.c
index 4dece1b206..d0cfacc69b 100644
--- a/drivers/mtd/nand/raw/nand_ids.c
+++ b/drivers/mtd/nand/raw/nand_ids.c
@@ -177,7 +177,7 @@  struct nand_flash_dev nand_flash_ids[] = {
 };
 
 /* Manufacturer IDs */
-struct nand_manufacturers nand_manuf_ids[] = {
+struct nand_manufacturer nand_manuf_ids[] = {
 	{NAND_MFR_TOSHIBA, "Toshiba", &toshiba_nand_manuf_ops},
 	{NAND_MFR_SAMSUNG, "Samsung", &samsung_nand_manuf_ops},
 	{NAND_MFR_FUJITSU, "Fujitsu"},
diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
index aa45558b3d..8dc2d81dba 100644
--- a/include/linux/mtd/rawnand.h
+++ b/include/linux/mtd/rawnand.h
@@ -976,7 +976,7 @@  struct nand_chip {
 	void *priv;
 
 	struct {
-		const struct nand_manufacturers *desc;
+		const struct nand_manufacturer *desc;
 		void *priv;
 	} manufacturer;
 };
@@ -1124,19 +1124,19 @@  struct nand_flash_dev {
 };
 
 /**
- * struct nand_manufacturers - NAND Flash Manufacturer ID Structure
+ * struct nand_manufacturer - NAND Flash Manufacturer ID Structure
  * @name:	Manufacturer name
  * @id:		manufacturer ID code of device.
  * @ops:	manufacturer operations
 */
-struct nand_manufacturers {
+struct nand_manufacturer {
 	int id;
 	char *name;
 	const struct nand_manufacturer_ops *ops;
 };
 
 extern struct nand_flash_dev nand_flash_ids[];
-extern struct nand_manufacturers nand_manuf_ids[];
+extern struct nand_manufacturer nand_manuf_ids[];
 
 extern const struct nand_manufacturer_ops toshiba_nand_manuf_ops;
 extern const struct nand_manufacturer_ops samsung_nand_manuf_ops;