clk: ti: mux: don't free `parent_names' on kzalloc() failure
diff mbox series

Message ID 20221017164646.4193618-1-dario.binacchi@amarulasolutions.com
State New
Headers show
Series
  • clk: ti: mux: don't free `parent_names' on kzalloc() failure
Related show

Commit Message

Dario Binacchi Oct. 17, 2022, 4:46 p.m. UTC 
Although no operation is performed by kfree() on a NULL pointer, it's
however suboptimal and semantically wrong doing it.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

---

 drivers/clk/ti/mux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Boyd Oct. 28, 2022, 12:41 a.m. UTC | #1 
Quoting Dario Binacchi (2022-10-17 09:46:46)
> Although no operation is performed by kfree() on a NULL pointer, it's
> however suboptimal and semantically wrong doing it.

Passing NULL to kfree() is fine. This is trying to optimize an error
path as well. No thanks.

Patch
diff mbox series 

diff --git a/drivers/clk/ti/mux.c b/drivers/clk/ti/mux.c
index 46b45b3e8319..1f924db2ad98 100644
--- a/drivers/clk/ti/mux.c
+++ b/drivers/clk/ti/mux.c
@@ -182,7 +182,7 @@  static void of_mux_clk_setup(struct device_node *node)
 	}
 	parent_names = kzalloc((sizeof(char *) * num_parents), GFP_KERNEL);
 	if (!parent_names)
-		goto cleanup;
+		return;
 
 	of_clk_parent_fill(node, parent_names, num_parents);