mtd: nand: drop EXPORT_SYMBOL_GPL for nanddev_erase()

Message ID 20221108090719.3631621-1-dario.binacchi@amarulasolutions.com
State New
Headers show
Series
  • mtd: nand: drop EXPORT_SYMBOL_GPL for nanddev_erase()
Related show

Commit Message

Dario Binacchi Nov. 8, 2022, 9:07 a.m. UTC
This function is only used within this module, so it is no longer
necessary to use EXPORT_SYMBOL_GPL().

This patch parallels the work done in the following patch:
https://lore.kernel.org/linux-mtd/20221018170205.1733958-1-dario.binacchi@amarulasolutions.com

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

---

 drivers/mtd/nand/core.c  | 3 +--
 include/linux/mtd/nand.h | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

Comments

Michael Trimarchi Nov. 8, 2022, 9:25 a.m. UTC | #1
On Tue, Nov 8, 2022 at 10:07 AM Dario Binacchi
<dario.binacchi@amarulasolutions.com> wrote:
>
> This function is only used within this module, so it is no longer
> necessary to use EXPORT_SYMBOL_GPL().
>
> This patch parallels the work done in the following patch:
> https://lore.kernel.org/linux-mtd/20221018170205.1733958-1-dario.binacchi@amarulasolutions.com
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

Reviewed-By: Michael Trimarchi <michael@amarulasolutions.com>

>
> ---
>
>  drivers/mtd/nand/core.c  | 3 +--
>  include/linux/mtd/nand.h | 1 -
>  2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/core.c b/drivers/mtd/nand/core.c
> index 99c29670c75e..4b9dd6a92694 100644
> --- a/drivers/mtd/nand/core.c
> +++ b/drivers/mtd/nand/core.c
> @@ -129,7 +129,7 @@ EXPORT_SYMBOL_GPL(nanddev_isreserved);
>   *
>   * Return: 0 in case of success, a negative error code otherwise.
>   */
> -int nanddev_erase(struct nand_device *nand, const struct nand_pos *pos)
> +static int nanddev_erase(struct nand_device *nand, const struct nand_pos *pos)
>  {
>         unsigned int entry;
>
> @@ -147,7 +147,6 @@ int nanddev_erase(struct nand_device *nand, const struct nand_pos *pos)
>
>         return nand->ops->erase(nand, pos);
>  }
> -EXPORT_SYMBOL_GPL(nanddev_erase);
>
>  /**
>   * nanddev_mtd_erase() - Generic mtd->_erase() implementation for NAND devices
> diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
> index 7774c17ad5d5..aeb38dec2e03 100644
> --- a/include/linux/mtd/nand.h
> +++ b/include/linux/mtd/nand.h
> @@ -691,7 +691,6 @@ static inline bool nanddev_io_iter_end(struct nand_device *nand,
>
>  bool nanddev_isbad(struct nand_device *nand, const struct nand_pos *pos);
>  bool nanddev_isreserved(struct nand_device *nand, const struct nand_pos *pos);
> -int nanddev_erase(struct nand_device *nand, const struct nand_pos *pos);
>  int nanddev_markbad(struct nand_device *nand, const struct nand_pos *pos);
>
>  /* BBT related functions */
> --
> 2.32.0
>

Patch

diff --git a/drivers/mtd/nand/core.c b/drivers/mtd/nand/core.c
index 99c29670c75e..4b9dd6a92694 100644
--- a/drivers/mtd/nand/core.c
+++ b/drivers/mtd/nand/core.c
@@ -129,7 +129,7 @@  EXPORT_SYMBOL_GPL(nanddev_isreserved);
  *
  * Return: 0 in case of success, a negative error code otherwise.
  */
-int nanddev_erase(struct nand_device *nand, const struct nand_pos *pos)
+static int nanddev_erase(struct nand_device *nand, const struct nand_pos *pos)
 {
 	unsigned int entry;
 
@@ -147,7 +147,6 @@  int nanddev_erase(struct nand_device *nand, const struct nand_pos *pos)
 
 	return nand->ops->erase(nand, pos);
 }
-EXPORT_SYMBOL_GPL(nanddev_erase);
 
 /**
  * nanddev_mtd_erase() - Generic mtd->_erase() implementation for NAND devices
diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
index 7774c17ad5d5..aeb38dec2e03 100644
--- a/include/linux/mtd/nand.h
+++ b/include/linux/mtd/nand.h
@@ -691,7 +691,6 @@  static inline bool nanddev_io_iter_end(struct nand_device *nand,
 
 bool nanddev_isbad(struct nand_device *nand, const struct nand_pos *pos);
 bool nanddev_isreserved(struct nand_device *nand, const struct nand_pos *pos);
-int nanddev_erase(struct nand_device *nand, const struct nand_pos *pos);
 int nanddev_markbad(struct nand_device *nand, const struct nand_pos *pos);
 
 /* BBT related functions */