diff mbox series

rockchip: Fix the broken Video out for rk3288 boards

Message ID 20230102182345.31066-1-jagan@amarulasolutions.com
State New
Headers
Series rockchip: Fix the broken Video out for rk3288 boards |

Commit Message

Jagan Teki Jan. 2, 2023, 6:23 p.m. UTC 
Video out on RK3288 boards has been broken since from few
releases due to the adding of reset support on vop but
missed enabling DM_RESET on associated boards.

This patch fixes those RK3288 boards.

Cc: Simon Glass <sjg@chromium.org>
Cc: Lin Huang <hl@rock-chips.com>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Michael Trimarchi <michael@amarulasolutions.com>
Cc: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
Fixes: <9749d2ea29e1> ("rockchip: video: vop: Add reset support")
Reported-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 configs/evb-rk3288_defconfig        | 1 +
 configs/firefly-rk3288_defconfig    | 1 +
 configs/miqi-rk3288_defconfig       | 1 +
 configs/rock-pi-n8-rk3288_defconfig | 1 +
 configs/tinker-rk3288_defconfig     | 1 +
 configs/tinker-s-rk3288_defconfig   | 1 +
 configs/vyasa-rk3288_defconfig      | 1 +
 7 files changed, 7 insertions(+)

Comments

Simon Glass Jan. 4, 2023, 8:01 p.m. UTC | #1 
On Mon, 2 Jan 2023 at 11:24, Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> Video out on RK3288 boards has been broken since from few
> releases due to the adding of reset support on vop but
> missed enabling DM_RESET on associated boards.
>
> This patch fixes those RK3288 boards.
>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Lin Huang <hl@rock-chips.com>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> Cc: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
> Fixes: <9749d2ea29e1> ("rockchip: video: vop: Add reset support")
> Reported-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>  configs/evb-rk3288_defconfig        | 1 +
>  configs/firefly-rk3288_defconfig    | 1 +
>  configs/miqi-rk3288_defconfig       | 1 +
>  configs/rock-pi-n8-rk3288_defconfig | 1 +
>  configs/tinker-rk3288_defconfig     | 1 +
>  configs/tinker-s-rk3288_defconfig   | 1 +
>  configs/vyasa-rk3288_defconfig      | 1 +
>  7 files changed, 7 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

This should get in for the release
Tom Rini Jan. 6, 2023, 4:52 p.m. UTC | #2 
On Mon, Jan 02, 2023 at 11:53:45PM +0530, Jagan Teki wrote:

> Video out on RK3288 boards has been broken since from few
> releases due to the adding of reset support on vop but
> missed enabling DM_RESET on associated boards.
> 
> This patch fixes those RK3288 boards.
> 
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Lin Huang <hl@rock-chips.com>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> Cc: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
> Fixes: <9749d2ea29e1> ("rockchip: video: vop: Add reset support")
> Reported-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/configs/evb-rk3288_defconfig b/configs/evb-rk3288_defconfig
index 7c0b856ca5..2c2c679b29 100644
--- a/configs/evb-rk3288_defconfig
+++ b/configs/evb-rk3288_defconfig
@@ -80,6 +80,7 @@  CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_PWM_ROCKCHIP=y
 CONFIG_RAM=y
 CONFIG_SPL_RAM=y
+CONFIG_DM_RESET=y
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYSRESET=y
 CONFIG_USB=y
diff --git a/configs/firefly-rk3288_defconfig b/configs/firefly-rk3288_defconfig
index 63c53a0248..12ed055acf 100644
--- a/configs/firefly-rk3288_defconfig
+++ b/configs/firefly-rk3288_defconfig
@@ -77,6 +77,7 @@  CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_PWM_ROCKCHIP=y
 CONFIG_RAM=y
 CONFIG_SPL_RAM=y
+CONFIG_DM_RESET=y
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYSRESET=y
 CONFIG_USB=y
diff --git a/configs/miqi-rk3288_defconfig b/configs/miqi-rk3288_defconfig
index 0811e70dce..2cf0efc816 100644
--- a/configs/miqi-rk3288_defconfig
+++ b/configs/miqi-rk3288_defconfig
@@ -74,6 +74,7 @@  CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_PWM_ROCKCHIP=y
 CONFIG_RAM=y
 CONFIG_SPL_RAM=y
+CONFIG_DM_RESET=y
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYSRESET=y
 CONFIG_USB=y
diff --git a/configs/rock-pi-n8-rk3288_defconfig b/configs/rock-pi-n8-rk3288_defconfig
index 4ed98c0a51..757d99b8b5 100644
--- a/configs/rock-pi-n8-rk3288_defconfig
+++ b/configs/rock-pi-n8-rk3288_defconfig
@@ -73,6 +73,7 @@  CONFIG_PWM_ROCKCHIP=y
 CONFIG_RAM=y
 CONFIG_SPL_RAM=y
 # CONFIG_RAM_ROCKCHIP_DEBUG is not set
+CONFIG_DM_RESET=y
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYSRESET=y
 CONFIG_USB=y
diff --git a/configs/tinker-rk3288_defconfig b/configs/tinker-rk3288_defconfig
index 85d94a6ea8..e69ef6875f 100644
--- a/configs/tinker-rk3288_defconfig
+++ b/configs/tinker-rk3288_defconfig
@@ -82,6 +82,7 @@  CONFIG_REGULATOR_RK8XX=y
 CONFIG_PWM_ROCKCHIP=y
 CONFIG_RAM=y
 CONFIG_SPL_RAM=y
+CONFIG_DM_RESET=y
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYSRESET=y
 CONFIG_USB=y
diff --git a/configs/tinker-s-rk3288_defconfig b/configs/tinker-s-rk3288_defconfig
index 7dfbad8083..eb153dc8d5 100644
--- a/configs/tinker-s-rk3288_defconfig
+++ b/configs/tinker-s-rk3288_defconfig
@@ -82,6 +82,7 @@  CONFIG_REGULATOR_RK8XX=y
 CONFIG_PWM_ROCKCHIP=y
 CONFIG_RAM=y
 CONFIG_SPL_RAM=y
+CONFIG_DM_RESET=y
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYSRESET=y
 CONFIG_USB=y
diff --git a/configs/vyasa-rk3288_defconfig b/configs/vyasa-rk3288_defconfig
index cbae60f987..f503cc1604 100644
--- a/configs/vyasa-rk3288_defconfig
+++ b/configs/vyasa-rk3288_defconfig
@@ -82,6 +82,7 @@  CONFIG_REGULATOR_RK8XX=y
 CONFIG_PWM_ROCKCHIP=y
 CONFIG_RAM=y
 CONFIG_SPL_RAM=y
+CONFIG_DM_RESET=y
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYSRESET=y
 CONFIG_USB=y