| Message ID | 20230208081540.2381272-1-dario.binacchi@amarulasolutions.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Hi Stefano On Wed, Feb 8, 2023 at 9:15 AM Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote: > > The Linux kernel device tree already specifies the device to be used for > boot console output with a stdout-path property under /chosen. > > Commit 36b661dc919da ("Merge branch 'next'") re-added the console > setting that commit bede82f750752 ("configs: imx8mn_bsh_smm_s2: remove > console from bootargs") had previously removed. > > Fixes: 36b661dc919da ("Merge branch 'next'") > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > Reviewed-by: Fabio Estevam <festevam@denx.de> > > --- > > Changes in v2: > - Add the 'Reviewed-by' tag. > - Improve commit message. > > include/configs/imx8mn_bsh_smm_s2.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/configs/imx8mn_bsh_smm_s2.h b/include/configs/imx8mn_bsh_smm_s2.h > index e97b8e871d22..deeed9c2f582 100644 > --- a/include/configs/imx8mn_bsh_smm_s2.h > +++ b/include/configs/imx8mn_bsh_smm_s2.h > @@ -14,7 +14,7 @@ > #include <config_distro_bootcmd.h> > > #define NANDARGS \ > - "nandargs=setenv bootargs console=${console} " \ > + "nandargs=setenv bootargs " \ > "${optargs} " \ > "mtdparts=${mtdparts} " \ > "root=${nandroot} " \ > -- This patch is a regression fix, can you pick it? Michael > 2.32.0 >
On 13.02.23 14:28, Michael Nazzareno Trimarchi wrote: > Hi Stefano > > On Wed, Feb 8, 2023 at 9:15 AM Dario Binacchi > <dario.binacchi@amarulasolutions.com> wrote: >> >> The Linux kernel device tree already specifies the device to be used for >> boot console output with a stdout-path property under /chosen. >> >> Commit 36b661dc919da ("Merge branch 'next'") re-added the console >> setting that commit bede82f750752 ("configs: imx8mn_bsh_smm_s2: remove >> console from bootargs") had previously removed. >> >> Fixes: 36b661dc919da ("Merge branch 'next'") >> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> >> Reviewed-by: Fabio Estevam <festevam@denx.de> >> >> --- >> >> Changes in v2: >> - Add the 'Reviewed-by' tag. >> - Improve commit message. >> >> include/configs/imx8mn_bsh_smm_s2.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/configs/imx8mn_bsh_smm_s2.h b/include/configs/imx8mn_bsh_smm_s2.h >> index e97b8e871d22..deeed9c2f582 100644 >> --- a/include/configs/imx8mn_bsh_smm_s2.h >> +++ b/include/configs/imx8mn_bsh_smm_s2.h >> @@ -14,7 +14,7 @@ >> #include <config_distro_bootcmd.h> >> >> #define NANDARGS \ >> - "nandargs=setenv bootargs console=${console} " \ >> + "nandargs=setenv bootargs " \ >> "${optargs} " \ >> "mtdparts=${mtdparts} " \ >> "root=${nandroot} " \ >> -- > > This patch is a regression fix, can you pick it? I'll do it, thanks ! Stefano > > Michael > >> 2.32.0 >>
diff --git a/include/configs/imx8mn_bsh_smm_s2.h b/include/configs/imx8mn_bsh_smm_s2.h index e97b8e871d22..deeed9c2f582 100644 --- a/include/configs/imx8mn_bsh_smm_s2.h +++ b/include/configs/imx8mn_bsh_smm_s2.h @@ -14,7 +14,7 @@ #include <config_distro_bootcmd.h> #define NANDARGS \ - "nandargs=setenv bootargs console=${console} " \ + "nandargs=setenv bootargs " \ "${optargs} " \ "mtdparts=${mtdparts} " \ "root=${nandroot} " \
The Linux kernel device tree already specifies the device to be used for boot console output with a stdout-path property under /chosen. Commit 36b661dc919da ("Merge branch 'next'") re-added the console setting that commit bede82f750752 ("configs: imx8mn_bsh_smm_s2: remove console from bootargs") had previously removed. Fixes: 36b661dc919da ("Merge branch 'next'") Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> Reviewed-by: Fabio Estevam <festevam@denx.de> --- Changes in v2: - Add the 'Reviewed-by' tag. - Improve commit message. include/configs/imx8mn_bsh_smm_s2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)