| Message ID | 20230804160258.3918831-1-dario.binacchi@amarulasolutions.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Dario, All, On 2023-08-04 18:02 +0200, Dario Binacchi spake thusly: > The patch only installs the executables (less than 100kb) saving 1.4Mb > of rootfs data. > > The list of what is no longer being installed: > - arp-fingerprint.1 -> /usr/share/man/man1 > - arp-scan.1 -> /usr/share/man/man1 > - get-oui.1 -> /usr/share/man/man1 > - ieee-oui.txt -> /usr/share/arp-scan > - mac-vendor.txt -> /etc/arp-scan > - mac-vendor.5 -> /usr/share/man/man5 The man stuff will get removed automatically by Buildroot in the target-finalize step, so that's not a concern that they get installed. Plus see below... > > Cc: Angelo Compagnucci <angelo@amarulasolutions.com> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > --- > package/arp-scan/arp-scan.mk | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/package/arp-scan/arp-scan.mk b/package/arp-scan/arp-scan.mk > index 89644be9d3ef..1c1bd34882ea 100644 > --- a/package/arp-scan/arp-scan.mk > +++ b/package/arp-scan/arp-scan.mk > @@ -23,4 +23,6 @@ else > ARP_SCAN_CONF_OPTS += --without-libcap > endif > > +ARP_SCAN_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) install-exec I think we want an option that makes the installation of that data optional. Since that was installed so far, the option should default to 'y' for legacy purposes: config BR2_PACKAGE_ARP_SCAN_DATA bool "install data (OUI)" default y # legacy Regards, Yann E. MORIN. > $(eval $(autotools-package)) > -- > 2.34.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
diff --git a/package/arp-scan/arp-scan.mk b/package/arp-scan/arp-scan.mk index 89644be9d3ef..1c1bd34882ea 100644 --- a/package/arp-scan/arp-scan.mk +++ b/package/arp-scan/arp-scan.mk @@ -23,4 +23,6 @@ else ARP_SCAN_CONF_OPTS += --without-libcap endif +ARP_SCAN_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) install-exec + $(eval $(autotools-package))
The patch only installs the executables (less than 100kb) saving 1.4Mb of rootfs data. The list of what is no longer being installed: - arp-fingerprint.1 -> /usr/share/man/man1 - arp-scan.1 -> /usr/share/man/man1 - get-oui.1 -> /usr/share/man/man1 - ieee-oui.txt -> /usr/share/arp-scan - mac-vendor.txt -> /etc/arp-scan - mac-vendor.5 -> /usr/share/man/man5 Cc: Angelo Compagnucci <angelo@amarulasolutions.com> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> --- package/arp-scan/arp-scan.mk | 2 ++ 1 file changed, 2 insertions(+)