mtd: nand: complete nand_register() arguments check

Message ID 20231102112743.57420-1-dario.binacchi@amarulasolutions.com
State New
Headers show
Series
  • mtd: nand: complete nand_register() arguments check
Related show

Commit Message

Dario Binacchi Nov. 2, 2023, 11:27 a.m. UTC
The patch checks that the "mtd" parameter is accessible before
proceeding.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

---

 drivers/mtd/nand/raw/nand.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Nazzareno Trimarchi Nov. 13, 2023, 8:45 a.m. UTC | #1
On Thu, Nov 2, 2023 at 12:27 PM Dario Binacchi
<dario.binacchi@amarulasolutions.com> wrote:
>
> The patch checks that the "mtd" parameter is accessible before
> proceeding.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>
> ---
>
>  drivers/mtd/nand/raw/nand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/nand.c b/drivers/mtd/nand/raw/nand.c
> index eacd99c4e275..d31bb580c46a 100644
> --- a/drivers/mtd/nand/raw/nand.c
> +++ b/drivers/mtd/nand/raw/nand.c
> @@ -52,7 +52,7 @@ int nand_mtd_to_devnum(struct mtd_info *mtd)
>  /* Register an initialized NAND mtd device with the U-Boot NAND command. */
>  int nand_register(int devnum, struct mtd_info *mtd)
>  {
> -       if (devnum >= CONFIG_SYS_MAX_NAND_DEVICE)
> +       if (!mtd || devnum >= CONFIG_SYS_MAX_NAND_DEVICE)
>                 return -EINVAL;
>
>         nand_info[devnum] = mtd;
> --
> 2.42.0
>

Reviewed-by: Michael Trimarchi <michael@amarulasolutions.com>

Patch

diff --git a/drivers/mtd/nand/raw/nand.c b/drivers/mtd/nand/raw/nand.c
index eacd99c4e275..d31bb580c46a 100644
--- a/drivers/mtd/nand/raw/nand.c
+++ b/drivers/mtd/nand/raw/nand.c
@@ -52,7 +52,7 @@  int nand_mtd_to_devnum(struct mtd_info *mtd)
 /* Register an initialized NAND mtd device with the U-Boot NAND command. */
 int nand_register(int devnum, struct mtd_info *mtd)
 {
-	if (devnum >= CONFIG_SYS_MAX_NAND_DEVICE)
+	if (!mtd || devnum >= CONFIG_SYS_MAX_NAND_DEVICE)
 		return -EINVAL;
 
 	nand_info[devnum] = mtd;