[5/6] package/libopenssl: no-engine
diff mbox series

Message ID 20240621161049.4085310-5-dario.binacchi@amarulasolutions.com
State New
Headers show
Series
  • [1/6] package/libopenssl: use $(RM) instead of rm
Related show

Commit Message

Dario Binacchi June 21, 2024, 4:10 p.m. UTC 
Even though the "no-engine" option effectively disables the compilation
of the engine, it still creates the installation directory, which ends up
being empty. For this reason, the patch does not remove the hook for
removing the directory if the BR2_PACKAGE_LIBOPENSSL_ENGINES option is
not enabled.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
 package/libopenssl/libopenssl.mk | 1 +
 1 file changed, 1 insertion(+)

Comments

Peter Korsgaard July 8, 2024, 6:53 a.m. UTC | #1 
>>>>> "Dario" == Dario Binacchi <dario.binacchi@amarulasolutions.com> writes:

 > Even though the "no-engine" option effectively disables the compilation
 > of the engine, it still creates the installation directory, which ends up
 > being empty. For this reason, the patch does not remove the hook for
 > removing the directory if the BR2_PACKAGE_LIBOPENSSL_ENGINES option is
 > not enabled.

 > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

Committed to 2024.02.x and 2024.05.x, thanks.

Patch
diff mbox series 

diff --git a/package/libopenssl/libopenssl.mk b/package/libopenssl/libopenssl.mk
index fe472e2c7a19..89a9189bb851 100644
--- a/package/libopenssl/libopenssl.mk
+++ b/package/libopenssl/libopenssl.mk
@@ -85,6 +85,7 @@  define LIBOPENSSL_CONFIGURE_CMDS
 			no-fuzz-afl \
 			no-afalgeng \
 			$(if $(BR2_PACKAGE_LIBOPENSSL_BIN),,no-apps) \
+			$(if $(BR2_PACKAGE_LIBOPENSSL_ENGINES),,no-engine) \
 			$(if $(BR2_PACKAGE_LIBOPENSSL_ENABLE_CHACHA),,no-chacha) \
 			$(if $(BR2_PACKAGE_LIBOPENSSL_ENABLE_RC2),,no-rc2) \
 			$(if $(BR2_PACKAGE_LIBOPENSSL_ENABLE_RC4),,no-rc4) \